LTS: proc: fix lookup in /proc/net subdirectories after setns(2)

2021-01-07 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
Hi Greg, Can you cherry-pick these to 4.19.y & 5.4.y: commit e06689bf57017ac022ccf0f2a5071f760821ce0f Author: Alexey Dobriyan Date: Wed Dec 4 16:49:59 2019 -0800 proc: change ->nlink under proc_subdir_lock commit c6c75deda81344c3a95d1d1f606d5cee109e5d54 Author: Alexey Dobriyan Date:

/proc/net/sctp/snmp, setns, proc: revalidate misc dentries

2020-12-01 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
Hello, Bisected problems with setns() and /proc/net/sctp/snmp to this: commit 1da4d377f943fe4194ffb9fb9c26cc58fad4dd24 Author: Alexey Dobriyan Date: Fri Apr 13 15:35:42 2018 -0700 proc: revalidate misc dentries Reproduces for example with Fedora 5.9.10-100.fc32.x86_64, so 1fde6f21d90f

Re: [PATCH] selftests: intel_pstate: ftime() is deprecated

2020-10-28 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
On Tue, 2020-10-27 at 14:08 -0600, Shuah Khan wrote: > > > @@ -73,8 +80,8 @@ int main(int argc, char **argv) { > > aperf = new_aperf-old_aperf; > > mperf = new_mperf-old_mperf; > > > > - start = before.time*1000 + before.millitm; > > - finish = after.time*1000 + after.millitm; > >

LTS couple perf test and perf top fixes

2020-10-09 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
Hi Greg, Sasha, Can you pick this to 5.4: commit dbd660e6b2884b864d2642d930a163d3bcebe4be Author: Tommi Rantala Date: Thu Apr 23 14:53:40 2020 +0300 perf test session topology: Fix data path And this to 5.4 and older LTS trees too: commit 29b4f5f188571c112713c35cc87eefb46efee612

Re: [PATCH 4.14 038/190] KVM: x86: only do L1TF workaround on affected processors

2020-06-26 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
On Wed, 2020-06-24 at 10:15 -0400, Sasha Levin wrote: > On Wed, Jun 24, 2020 at 12:00:59PM +0000, Rantala, Tommi T. (Nokia - > FI/Espoo) wrote: > > On Fri, 2020-06-19 at 16:31 +0200, Greg Kroah-Hartman wrote: > > > From: Paolo Bonzini > >

Re: [PATCH 4.14 038/190] KVM: x86: only do L1TF workaround on affected processors

2020-06-24 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
On Fri, 2020-06-19 at 16:31 +0200, Greg Kroah-Hartman wrote: > From: Paolo Bonzini > > [ Upstream commit d43e2675e96fc6ae1a633b6a69d296394448cc32 ] > > KVM stores the gfn in MMIO SPTEs as a caching optimization. These are > split > in two parts, as in "[high 1 low]", to thwart any attempt

rseq selftests param_test.c gettid build failure

2019-09-12 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
Hi Mathieu, I'm getting rseq selftest build failure with glibc 2.30, which added gettid(): param_test.c:18:21: error: static declaration of 'gettid' follows non- static declaration 18 | static inline pid_t gettid(void) | ^~ In file included from

nfs4 server stops responding

2019-08-19 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
Hello, I have two VMs, exporting some directories in one VM: # cat /etc/exports /mnt 192.168.1.0/24(ro,fsid=0,no_subtree_check,sync) /mnt/export 192.168.1.0/24(rw,no_root_squash,sync,no_wdelay,no_subtree_check) [...] And NFS mounting in the second VM: # grep nfs /proc/mounts server:/export

Re: [PATCH 4.14 43/43] tipc: pass tunnel dev as NULL to udp_tunnel(6)_xmit_skb

2019-08-02 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
On Fri, 2019-08-02 at 09:28 +0200, gre...@linuxfoundation.org wrote: > On Thu, Aug 01, 2019 at 10:17:30AM +0000, Rantala, Tommi T. (Nokia - > FI/Espoo) wrote: > > Hi, > > > > This tipc patch added in 4.14.132 is triggering a crash for me, > > revert > >

Re: [PATCH 4.14 43/43] tipc: pass tunnel dev as NULL to udp_tunnel(6)_xmit_skb

2019-08-01 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
On Tue, 2019-07-02 at 10:02 +0200, Greg Kroah-Hartman wrote: > From: Xin Long > > commit c3bcde026684c62d7a2b6f626dc7cf763833875c upstream. > > udp_tunnel(6)_xmit_skb() called by tipc_udp_xmit() expects a tunnel > device > to count packets on dev->tstats, a perpcu variable. However, TIPC is >

[PATCH 4.14] perf machine: Guard against NULL in machine__exit()

2019-06-19 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
From: Arnaldo Carvalho de Melo commit 4a2233b194c77ae1ea8304cb7c00b551de4313f0 upstream. A recent fix for 'perf trace' introduced a bug where machine__exit(trace->host) could be called while trace->host was still NULL, so make this more robust by guarding against NULL, just like free() does.

perf top --stdio, glibc 2.28, stdio EOF sticky

2019-06-06 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
Hello, "perf top --stdio" (or perf kvm top --stdio) keyboard handling does not work properly for me. Instead of accepting key presses, it just displays the "Mapped keys:" help output always. Seems to be related to this glibc 2.28 stdio change:

Re: [PATCH 4.19 144/187] selftests/bpf: skip verifier tests for unsupported program types

2019-05-23 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
On Thu, 2019-04-04 at 10:48 +0200, Greg Kroah-Hartman wrote: > 4.19-stable review patch. If anyone has any objections, please let > me know. > > -- > > [ Upstream commit 8184d44c9a577a2f1842ed6cc844bfd4a9981d8e ] > > Use recently introduced bpf_probe_prog_type() to skip tests

Re: [PATCH 4.14 09/69] x86: vdso: Use $LD instead of $CC to link

2019-04-26 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
On Fri, 2019-04-26 at 05:48 -0700, Nathan Chancellor wrote: > On Fri, Apr 26, 2019 at 11:41:30AM +0000, Rantala, Tommi T. (Nokia - > FI/Espoo) wrote: > > On Mon, 2019-04-15 at 20:58 +0200, Greg Kroah-Hartman wrote: > > > commit 379d98ddf41344273d9718556f761420f4dc80b3 upstrea

Re: [PATCH 4.14 09/69] x86: vdso: Use $LD instead of $CC to link

2019-04-26 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
On Mon, 2019-04-15 at 20:58 +0200, Greg Kroah-Hartman wrote: > commit 379d98ddf41344273d9718556f761420f4dc80b3 upstream. > Hi, With this patch in 4.14.112 build-id is now missing in vdso32.so: $ file arch/x86/entry/vdso/vdso*so* arch/x86/entry/vdso/vdso32.so: ELF 32-bit LSB pie executable,

/proc/sys/kernel/sched_domain/, isolcpus, CONFIG_CPUMASK_OFFSTACK

2019-02-15 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
Hello, /proc/sys/kernel/sched_domain/ seems to be somewhat broken when kernel is configured without CONFIG_CPUMASK_OFFSTACK and booting with isolcpus= option. Example with 8x CPU. With CONFIG_CPUMASK_OFFSTACK=y and "isolcpus=2": # uname -r 5.0.0-0.rc3.git0.1.fc30.x86_64 # ls

4.14 perf test patches

2019-02-13 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
Hi, Can you pick these patches to 4.14.y? These fix some "perf test" errors seen when running in VM. commit 10836d9f9ac63d40ccfa756f871ce4ed51ae3b52 Author: Jiri Olsa Date: Mon Jul 3 16:50:30 2017 +0200 perf tests attr: Fix task term values commit

[PATCH 4.14 6/8] uio: fix wrong return value from uio_mmap()

2019-02-13 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
From: Hailong Liu commit e7de2590f18a272e63732b9d519250d1b522b2c4 upstream. uio_mmap has multiple fail paths to set return value to nonzero then goto out. However, it always returns *0* from the *out* at end, and this will mislead callers who check the return value of this function. Fixes:

[PATCH 4.14 8/8] Revert "uio: use request_threaded_irq instead"

2019-02-13 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
From: Xiubo Li commit 3d27c4de8d4fb2d4099ff324671792aa2578c6f9 upstream. Since mutex lock in irq hanler is useless currently, here will remove it together with it. This reverts commit 9421e45f5ff3d558cf8b75a8cc0824530caf3453. Reported-by: james.r.har...@intel.com CC: Ahsan Atta

[PATCH 4.14 7/8] uio: fix possible circular locking dependency

2019-02-13 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
From: Xiubo Li commit b34e9a15b37b8ddbf06a4da142b0c39c74211eb4 upstream. The call trace: XXX/1910 is trying to acquire lock: (>mmap_sem){++}, at: [] might_fault+0x57/0xb0 but task is already holding lock: (>info_lock){+.+...}, at: [] uio_write+0x46/0x130 [uio] which lock already depends

[PATCH 4.14 4/8] uio: change to use the mutex lock instead of the spin lock

2019-02-13 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
From: Xiubo Li commit 543af5861f41af0a5d2432f6fb5976af50f9cee5 upstream. We are hitting a regression with the following commit: commit a93e7b331568227500186a465fee3c2cb5dffd1f Author: Hamish Martin Date: Mon May 14 13:32:23 2018 +1200 uio: Prevent device destruction while fds are open

[PATCH 4.14 5/8] uio: fix crash after the device is unregistered

2019-02-13 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
From: Xiubo Li commit 57c5f4df0a5a0ee83df71251e2ee93a5e4e9 upstream. For the target_core_user use case, after the device is unregistered it maybe still opened in user space, then the kernel will crash, like: [ 251.163692] BUG: unable to handle kernel NULL pointer dereference at

[PATCH 4.14 1/8] uio: Reduce return paths from uio_write()

2019-02-13 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
From: Hamish Martin commit 81daa406c2cc97d85eef9409400404efc2a3f756 upstream. Drive all return paths for uio_write() through a single block at the end of the function. Signed-off-by: Hamish Martin Reviewed-by: Chris Packham Signed-off-by: Greg Kroah-Hartman Signed-off-by: Tommi Rantala ---

[PATCH 4.14 3/8] uio: use request_threaded_irq instead

2019-02-13 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
From: Xiubo Li commit 9421e45f5ff3d558cf8b75a8cc0824530caf3453 upstream. Prepraing for changing to use mutex lock. Signed-off-by: Xiubo Li Signed-off-by: Greg Kroah-Hartman Signed-off-by: Tommi Rantala --- drivers/uio/uio.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff

[PATCH 4.14 2/8] uio: Prevent device destruction while fds are open

2019-02-13 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
From: Hamish Martin commit a93e7b331568227500186a465fee3c2cb5dffd1f upstream. Prevent destruction of a uio_device while user space apps hold open file descriptors to that device. Further, access to the 'info' member of the struct uio_device is protected by spinlock. This is to ensure stale

[PATCH 4.14 0/8] uio backport fixes for 4.14

2019-02-13 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
Backport uio fixes to 4.14, to fix use-after-free memory errors. Changed __poll_t to unsigned int as the former not found in 4.14, and resolved some patch context conflicts. Hailong Liu (1): uio: fix wrong return value from uio_mmap() Hamish Martin (2): uio: Reduce return paths from

Re: Suspected SPAM - Re: [PATCH 4.14 198/205] perf/core: Dont WARN() for impossible ring-buffer sizes

2019-02-13 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
On Wed, 2019-02-13 at 13:03 +, Rantala, Tommi T. (Nokia - FI/Espoo) wrote: > On Mon, 2019-02-11 at 15:19 +0100, Greg Kroah-Hartman wrote: > > 4.14-stable review patch. If anyone has any objections, please let > > me know. > > > > --

Re: [PATCH 4.14 198/205] perf/core: Dont WARN() for impossible ring-buffer sizes

2019-02-13 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
On Mon, 2019-02-11 at 15:19 +0100, Greg Kroah-Hartman wrote: > 4.14-stable review patch. If anyone has any objections, please let > me know. > > -- > > From: Mark Rutland > > commit 9dff0aa95a324e262ffb03f425d00e4751f3294e upstream. > > The perf tool uses

4.4 "rcu: Force boolean subscript for expedited stall warnings"

2019-02-06 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
Hi, Can you pick this tiny one-liner patch to 4.4.y? Fixes unexpected null byte in RCU "expedited stall" message. commit ec3833ed02ae6ef2a933ece9de7cbab0c64c699e Author: Paul E. McKenney Date: Mon Jan 11 16:29:29 2016 -0800 rcu: Force boolean subscript for expedited stall warnings

4.14 "random: add a config option to trust the CPU's hwrng"

2019-02-06 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
Hi stable maintainers, Can you consider including these "random" patches in 4.14.y? These are very useful in fixing esp. first-bootup delays of VMs due to entropy starvation. commit 39a8883a2b989d1d21bd8dd99f5557f0c5e89694 Author: Theodore Ts'o Date: Tue Jul 17 18:24:27 2018 -0400

4.14 "uio: Prevent device destruction while fds are open"

2019-02-06 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
Hi, I hit use-after-free issues in UIO in 4.14.x, and discovered that it's already fixed in later kernel versions: commit a93e7b331568227500186a465fee3c2cb5dffd1f Author: Hamish Martin Date: Mon May 14 13:32:23 2018 +1200 uio: Prevent device destruction while fds are open Can we have

4.14 revert "seccomp: add a selftest for get_metadata"

2019-01-28 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
Hi Greg, Can you please revert this commit in 4.14? commit e65cd9a20343ea90f576c24c38ee85ab6e7d5fec Author: Tycho Andersen Date: Tue Feb 20 19:47:47 2018 -0700 seccomp: add a selftest for get_metadata [ Upstream commit d057dc4e35e16050befa3dda943876dab39cbf80 ] Let's

4.14 perf unwind fixes

2019-01-28 Thread Rantala, Tommi T. (Nokia - FI/Espoo)
Hi Greg, Can you please pick these two upstream patches to 4.14? They fix broken perf unwinding for me. commit 3d20c6246690219881786de10d2dda93f616d0ac Author: Martin Vuille < jpm...@aim.com> Date: Sun Feb 11 16:24:20 2018 -0500 perf unwind: Unwind with libdw doesn't take symfs into