[patch] Remove unneeded null tty check in drivers/usb/serial/io_ti.c

2008-02-22 Thread Ray Lee
The Coverity checker (and Adrian Bunk) spotted an inconsistent NULL check of port->tty (it's blindly dereferenced later without the check). Alan Cox confirmed the check can go. Signed-off-by: Ray Lee <[EMAIL PROTECTED]> cc: [EMAIL PROTECTED] cc: Greg KH <[EMAIL PROTECTED]>

[patch] Remove unneeded null tty check in drivers/usb/serial/io_ti.c

2008-02-22 Thread Ray Lee
The Coverity checker (and Adrian Bunk) spotted an inconsistent NULL check of port-tty (it's blindly dereferenced later without the check). Alan Cox confirmed the check can go. Signed-off-by: Ray Lee [EMAIL PROTECTED] cc: [EMAIL PROTECTED] cc: Greg KH [EMAIL PROTECTED] cc: Adrian Bunk [EMAIL

Re: Merging of completely unreviewed drivers

2008-02-21 Thread Ray Lee
On Thu, Feb 21, 2008 at 7:13 PM, Linus Torvalds <[EMAIL PROTECTED]> wrote: > So I'd be happier with warnings about deep indentation (but how do you > count it? Will people then try to fake things out by using 4-space indents > and then "deep" indentations will look like just a couple of tabs?)

Re: Merging of completely unreviewed drivers

2008-02-21 Thread Ray Lee
On Thu, Feb 21, 2008 at 7:13 PM, Linus Torvalds [EMAIL PROTECTED] wrote: So I'd be happier with warnings about deep indentation (but how do you count it? Will people then try to fake things out by using 4-space indents and then deep indentations will look like just a couple of tabs?) I

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread Ray Lee
On Wed, Feb 20, 2008 at 7:20 AM, Balbir Singh <[EMAIL PROTECTED]> wrote: > John Stoffel wrote: > > I know this is a pedantic comment, but why the heck is it called such > > a generic term as "Memory Controller" which doesn't give any > > indication of what it does. > > > > Shouldn't it be

Re: [PATCH] Document huge memory/cache overhead of memory controller in Kconfig

2008-02-20 Thread Ray Lee
On Wed, Feb 20, 2008 at 7:20 AM, Balbir Singh [EMAIL PROTECTED] wrote: John Stoffel wrote: I know this is a pedantic comment, but why the heck is it called such a generic term as Memory Controller which doesn't give any indication of what it does. Shouldn't it be something like

Re: usb/serial/io_ti.c: inconsequent NULL checking

2008-02-19 Thread Ray Lee
On Feb 19, 2008 3:25 PM, Greg KH <[EMAIL PROTECTED]> wrote: > On Wed, Feb 20, 2008 at 12:49:15AM +0200, Adrian Bunk wrote: > > The Coverity checker spotted the following inconsequent NULL checking > > introduced by commit d5f5bcd425b771c0b7ff5a650b2ce061ac8bbb87: > > > > <-- snip --> > > It's

Re: usb/serial/io_ti.c: inconsequent NULL checking

2008-02-19 Thread Ray Lee
On Feb 19, 2008 3:25 PM, Greg KH [EMAIL PROTECTED] wrote: On Wed, Feb 20, 2008 at 12:49:15AM +0200, Adrian Bunk wrote: The Coverity checker spotted the following inconsequent NULL checking introduced by commit d5f5bcd425b771c0b7ff5a650b2ce061ac8bbb87: -- snip -- It's not a real

Re: 2.6.25-rc1/2 regression: first-time login into gnome fails

2008-02-18 Thread Ray Lee
On Feb 18, 2008 2:56 AM, Romano Giannetti <[EMAIL PROTECTED]> wrote: > > Hi, > > I have a very strange, but fully reproducible, regression with > 2.6.25-rc1 -rc2. I have an ubuntu 7.10 fully updated. > > The first time after boot, when I login to gnome (through gdm) > the login

Re: 2.6.25-rc1/2 regression: first-time login into gnome fails

2008-02-18 Thread Ray Lee
On Feb 18, 2008 2:56 AM, Romano Giannetti [EMAIL PROTECTED] wrote: Hi, I have a very strange, but fully reproducible, regression with 2.6.25-rc1 -rc2. I have an ubuntu 7.10 fully updated. The first time after boot, when I login to gnome (through gdm) the login half-fails

Re: [RFC] bitmap relative operator for mempolicy extensions

2008-02-14 Thread Ray Lee
On Thu, Feb 14, 2008 at 8:35 AM, Paul Jackson <[EMAIL PROTECTED]> wrote: > Kosaki-san wrote: > > i prefer another name [!relative]. > > Any suggestions? > > I'll give the name some thought myself. > I like good names, and this is the right > time to get this one right. 'Relative map' implies

Re: [RFC] bitmap relative operator for mempolicy extensions

2008-02-14 Thread Ray Lee
On Thu, Feb 14, 2008 at 8:35 AM, Paul Jackson [EMAIL PROTECTED] wrote: Kosaki-san wrote: i prefer another name [!relative]. Any suggestions? I'll give the name some thought myself. I like good names, and this is the right time to get this one right. 'Relative map' implies a constant

Re: [REGRESSION]fan turns at highspeed after suspend2ram

2008-02-11 Thread Ray Lee
On Feb 11, 2008 7:56 AM, Mirco Tischler <[EMAIL PROTECTED]> wrote: > On Sunday, 10 of February 2008, Rafaek J. Wysocki wrote: > > > Can you apply the appended patch on top of the current mainline and tetest? > > > > Thanks, > > Rafael > > > > Sorry, that doesn't fix it. > But I'm pretty sure it is

Re: [REGRESSION]fan turns at highspeed after suspend2ram

2008-02-11 Thread Ray Lee
On Feb 11, 2008 7:56 AM, Mirco Tischler [EMAIL PROTECTED] wrote: On Sunday, 10 of February 2008, Rafaek J. Wysocki wrote: Can you apply the appended patch on top of the current mainline and tetest? Thanks, Rafael Sorry, that doesn't fix it. But I'm pretty sure it is related to that

Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'

2008-02-10 Thread Ray Lee
On Feb 10, 2008 5:47 PM, Mr. James W. Laferriere <[EMAIL PROTECTED]> wrote: > Hello All , grabbed using git just moments ago . > > make V=1 KBUILD_VERBOSE=1 INSTALL_PATH=/boot clean all install modules_install > > ...snip... > make -f scripts/Makefile.clean obj=sound/usb/usx2y > make -f

Re: [git pull] kgdb light, v5

2008-02-10 Thread Ray Lee
On Feb 10, 2008 9:39 AM, Jan Kiszka <[EMAIL PROTECTED]> wrote: > Ray Lee wrote: > > unsigned int void u64_to_hex(u64 val, unsigned char *buf) > > { > > int i; > > for (i=15; i>=0; i--) { > > buf[i] = hexchars[ val

Re: [REGRESSION]fan turns at highspeed after suspend2ram

2008-02-10 Thread Ray Lee
On Feb 10, 2008 9:21 AM, Mirco Tischler <[EMAIL PROTECTED]> wrote: > Hi > > I think I found a regression in 2.6.24-git. After waking up from suspend > 2 ram, the fan of my laptop turns constantly at highest speed. It didn't > do this in 2.6.24. > > I bisected it down to this commit: > > commit

Re: [git pull] kgdb light, v5

2008-02-10 Thread Ray Lee
On Feb 10, 2008 8:36 AM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > +#ifdef CONFIG_64BIT > + } else if ((count == 8) && (((long)mem & 7) == 0)) { > + u64 tmp_ll; > + if (probe_kernel_address(mem, tmp_ll)) > + return ERR_PTR(-EINVAL); > + > +

Re: [git pull] kgdb light, v5

2008-02-10 Thread Ray Lee
On Feb 10, 2008 8:36 AM, Ingo Molnar [EMAIL PROTECTED] wrote: +#ifdef CONFIG_64BIT + } else if ((count == 8) (((long)mem 7) == 0)) { + u64 tmp_ll; + if (probe_kernel_address(mem, tmp_ll)) + return ERR_PTR(-EINVAL); + +

Re: [REGRESSION]fan turns at highspeed after suspend2ram

2008-02-10 Thread Ray Lee
On Feb 10, 2008 9:21 AM, Mirco Tischler [EMAIL PROTECTED] wrote: Hi I think I found a regression in 2.6.24-git. After waking up from suspend 2 ram, the fan of my laptop turns constantly at highest speed. It didn't do this in 2.6.24. I bisected it down to this commit: commit

Re: [git pull] kgdb light, v5

2008-02-10 Thread Ray Lee
On Feb 10, 2008 9:39 AM, Jan Kiszka [EMAIL PROTECTED] wrote: Ray Lee wrote: unsigned int void u64_to_hex(u64 val, unsigned char *buf) { int i; for (i=15; i=0; i--) { buf[i] = hexchars[ val 0x0f ]; val = 4

Re: Linux 2.6.25-rc1 , syntax error near unexpected token `;'

2008-02-10 Thread Ray Lee
On Feb 10, 2008 5:47 PM, Mr. James W. Laferriere [EMAIL PROTECTED] wrote: Hello All , grabbed using git just moments ago . make V=1 KBUILD_VERBOSE=1 INSTALL_PATH=/boot clean all install modules_install ...snip... make -f scripts/Makefile.clean obj=sound/usb/usx2y make -f

Re: Fwd: Re: e1000 1sec latency problem

2008-02-09 Thread Ray Lee
On Feb 9, 2008 1:51 PM, Kok, Auke <[EMAIL PROTECTED]> wrote: > > Martin Rogge wrote: > > On Saturday 09 February 2008 11:07:26 Martin Rogge wrote: > >> Hi, > >> > >> I am not so familiar with the various mailing lists and missed out on > >> [EMAIL PROTECTED] the first time. Please cc me on any >

Re: [PATCH 1/8] kgdb: core API and gdb protocol handler

2008-02-09 Thread Ray Lee
2008/2/9 Ray Lee <[EMAIL PROTECTED]>: > On Feb 9, 2008 9:27 AM, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > On Sat, Feb 09, 2008 at 07:35:07AM -0600, [EMAIL PROTECTED] wrote: > > > +#ifdef __BIG_ENDIAN > > > + *buf++ = hexchars[(tmp_s

Re: [PATCH 1/8] kgdb: core API and gdb protocol handler

2008-02-09 Thread Ray Lee
On Feb 9, 2008 9:27 AM, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > On Sat, Feb 09, 2008 at 07:35:07AM -0600, [EMAIL PROTECTED] wrote: > > +#ifdef __BIG_ENDIAN > > + *buf++ = hexchars[(tmp_s >> 12) & 0xf]; > > + *buf++ = hexchars[(tmp_s >> 8) & 0xf]; > > +

Re: [PATCH 1/8] kgdb: core API and gdb protocol handler

2008-02-09 Thread Ray Lee
On Feb 9, 2008 9:27 AM, Christoph Hellwig [EMAIL PROTECTED] wrote: On Sat, Feb 09, 2008 at 07:35:07AM -0600, [EMAIL PROTECTED] wrote: +#ifdef __BIG_ENDIAN + *buf++ = hexchars[(tmp_s 12) 0xf]; + *buf++ = hexchars[(tmp_s 8) 0xf]; + *buf++ =

Re: [PATCH 1/8] kgdb: core API and gdb protocol handler

2008-02-09 Thread Ray Lee
2008/2/9 Ray Lee [EMAIL PROTECTED]: On Feb 9, 2008 9:27 AM, Christoph Hellwig [EMAIL PROTECTED] wrote: On Sat, Feb 09, 2008 at 07:35:07AM -0600, [EMAIL PROTECTED] wrote: +#ifdef __BIG_ENDIAN + *buf++ = hexchars[(tmp_s 12) 0xf]; + *buf++ = hexchars[(tmp_s 8

Re: Fwd: Re: e1000 1sec latency problem

2008-02-09 Thread Ray Lee
On Feb 9, 2008 1:51 PM, Kok, Auke [EMAIL PROTECTED] wrote: Martin Rogge wrote: On Saturday 09 February 2008 11:07:26 Martin Rogge wrote: Hi, I am not so familiar with the various mailing lists and missed out on [EMAIL PROTECTED] the first time. Please cc me on any replies. I am

Re: ACPI_WMI: worst config description of all times

2008-02-07 Thread Ray Lee
On Feb 7, 2008 5:19 PM, Carlos Corbacho <[EMAIL PROTECTED]> wrote: > On Friday 08 February 2008 00:12:24 Ray Lee wrote: > > On Feb 7, 2008 3:51 PM, Carlos Corbacho <[EMAIL PROTECTED]> wrote: > > > On Thursday 07 February 2008 23:33:54 Ray Lee wrote: > > > &

Re: ACPI_WMI: worst config description of all times

2008-02-07 Thread Ray Lee
On Feb 7, 2008 3:51 PM, Carlos Corbacho <[EMAIL PROTECTED]> wrote: > On Thursday 07 February 2008 23:33:54 Ray Lee wrote: > > Do you have list of hardware/platforms that require this feature to > > get the hardware to work? (acer abc123, tcm1100 xyz) > > I have a ver

Re: ACPI_WMI: worst config description of all times

2008-02-07 Thread Ray Lee
On Feb 7, 2008 3:18 PM, Carlos Corbacho <[EMAIL PROTECTED]> wrote: > As for the Kconfig - I'm open to suggestions. While the kconfig text is supposed to say 'what' something is, the more valuable piece of information it provides is *why* one would want to enable it. Do you have list of

Re: ACPI_WMI: worst config description of all times

2008-02-07 Thread Ray Lee
On Feb 7, 2008 3:18 PM, Carlos Corbacho [EMAIL PROTECTED] wrote: As for the Kconfig - I'm open to suggestions. While the kconfig text is supposed to say 'what' something is, the more valuable piece of information it provides is *why* one would want to enable it. Do you have list of

Re: ACPI_WMI: worst config description of all times

2008-02-07 Thread Ray Lee
On Feb 7, 2008 3:51 PM, Carlos Corbacho [EMAIL PROTECTED] wrote: On Thursday 07 February 2008 23:33:54 Ray Lee wrote: Do you have list of hardware/platforms that require this feature to get the hardware to work? (acer abc123, tcm1100 xyz) I have a very long list of Acer laptops

Re: ACPI_WMI: worst config description of all times

2008-02-07 Thread Ray Lee
On Feb 7, 2008 5:19 PM, Carlos Corbacho [EMAIL PROTECTED] wrote: On Friday 08 February 2008 00:12:24 Ray Lee wrote: On Feb 7, 2008 3:51 PM, Carlos Corbacho [EMAIL PROTECTED] wrote: On Thursday 07 February 2008 23:33:54 Ray Lee wrote: Do you have list of hardware/platforms that require

Re: how to tell i386 from x86-64 kernel

2008-01-31 Thread Ray Lee
On Jan 31, 2008 4:42 PM, Pavel Machek <[EMAIL PROTECTED]> wrote: > Quiz: on a booted system, how do you tell 32bit from 64bit kernel? Uhm, is this a trick question? What's wrong with uname(2)? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: how to tell i386 from x86-64 kernel

2008-01-31 Thread Ray Lee
On Jan 31, 2008 4:42 PM, Pavel Machek [EMAIL PROTECTED] wrote: Quiz: on a booted system, how do you tell 32bit from 64bit kernel? Uhm, is this a trick question? What's wrong with uname(2)? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: Unpredictable performance

2008-01-25 Thread Ray Lee
On Jan 25, 2008 3:32 AM, Asbjorn Sannes <[EMAIL PROTECTED]> wrote: > Hi, > > I am experiencing unpredictable results with the following test > without other processes running (exception is udev, I believe): > cd /usr/src/test > tar -jxf ../linux-2.6.22.12 > cp ../working-config

Re: Unpredictable performance

2008-01-25 Thread Ray Lee
On Jan 25, 2008 3:32 AM, Asbjorn Sannes [EMAIL PROTECTED] wrote: Hi, I am experiencing unpredictable results with the following test without other processes running (exception is udev, I believe): cd /usr/src/test tar -jxf ../linux-2.6.22.12 cp ../working-config linux-2.6.22.12/.config cd

Re: Massive IDE problems. Who leaves data here?

2008-01-22 Thread Ray Lee
On Jan 22, 2008 1:04 PM, Manuel Reimer <[EMAIL PROTECTED]> wrote: > Ray Lee wrote: > > (Please always do a reply-to-all for this email list.) > > Currently I don't have a SMTP server configured. As soon as my system is > trustworthy, again, I'll do that. Oy. Just know th

Re: Massive IDE problems. Who leaves data here?

2008-01-22 Thread Ray Lee
(Please always do a reply-to-all for this email list.) On Jan 22, 2008 12:40 PM, Manuel Reimer <[EMAIL PROTECTED]> wrote: > Jeff Garzik wrote: > > If your IDE interface is complaining about BadCRC errors, then it's > > complaining about hardware problems (bad cable, etc.) > > The cable already

Re: Massive IDE problems. Who leaves data here?

2008-01-22 Thread Ray Lee
(Please always do a reply-to-all for this email list.) On Jan 22, 2008 12:40 PM, Manuel Reimer [EMAIL PROTECTED] wrote: Jeff Garzik wrote: If your IDE interface is complaining about BadCRC errors, then it's complaining about hardware problems (bad cable, etc.) The cable already has been

Re: Massive IDE problems. Who leaves data here?

2008-01-22 Thread Ray Lee
On Jan 22, 2008 1:04 PM, Manuel Reimer [EMAIL PROTECTED] wrote: Ray Lee wrote: (Please always do a reply-to-all for this email list.) Currently I don't have a SMTP server configured. As soon as my system is trustworthy, again, I'll do that. Oy. Just know that without CC:ing people, I'm

Re: [PATCH] x86 reboot: Remove inb_p usage

2008-01-19 Thread Ray Lee
On Jan 19, 2008 7:44 AM, Alan Cox <[EMAIL PROTECTED]> wrote: > We are driving a motherboard port so use a 2uS explicit delay at this > point. > > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> > > diff -u --new-file --recursive --exclude-from /usr/src/exclude >

Re: [PATCH] x86 reboot: Remove inb_p usage

2008-01-19 Thread Ray Lee
On Jan 19, 2008 7:44 AM, Alan Cox [EMAIL PROTECTED] wrote: We are driving a motherboard port so use a 2uS explicit delay at this point. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude

Re: Updatedb hangs Kernel 2.6.22.9-cfs-v22

2008-01-16 Thread Ray Lee
On Jan 14, 2008 7:28 AM, Renato S. Yamane <[EMAIL PROTECTED]> wrote: > Ray Lee escreveu: > > On Jan 12, 2008 10:03 AM, Renato S. Yamane wrote: > >> I can't use updatedb in Debian Etch (stable) using customized Kernel > >> 2.6.22.9-cfs-v22. > >> > >

Re: Updatedb hangs Kernel 2.6.22.9-cfs-v22

2008-01-16 Thread Ray Lee
On Jan 14, 2008 7:28 AM, Renato S. Yamane [EMAIL PROTECTED] wrote: Ray Lee escreveu: On Jan 12, 2008 10:03 AM, Renato S. Yamane wrote: I can't use updatedb in Debian Etch (stable) using customized Kernel 2.6.22.9-cfs-v22. When I ran updatedb, after ~1 minute my system hangs and caps

Re: Updatedb hangs Kernel 2.6.22.9-cfs-v22

2008-01-12 Thread Ray Lee
On Jan 12, 2008 10:03 AM, Renato S. Yamane <[EMAIL PROTECTED]> wrote: > Hi, > I can't use updatedb in Debian Etch (stable) using customized Kernel > 2.6.22.9-cfs-v22. > > When I ran updatedb, after ~1 minute my system hangs and "caps lock" LED > is blinking. No log is registered. Please switch

Re: Updatedb hangs Kernel 2.6.22.9-cfs-v22

2008-01-12 Thread Ray Lee
On Jan 12, 2008 10:03 AM, Renato S. Yamane [EMAIL PROTECTED] wrote: Hi, I can't use updatedb in Debian Etch (stable) using customized Kernel 2.6.22.9-cfs-v22. When I ran updatedb, after ~1 minute my system hangs and caps lock LED is blinking. No log is registered. Please switch out of X11

Re: questions on NAPI processing latency and dropped network packets

2008-01-11 Thread Ray Lee
On Jan 10, 2008 9:24 AM, Chris Friesen <[EMAIL PROTECTED]> wrote: > After a recent userspace app change, we've started seeing packets being > dropped by the ethernet hardware (e1000, NAPI is enabled). The > error/dropped/fifo counts are going up in ethtool: (These are perhaps too obvious, but I

Re: [PATCH 1/4] fs/autofs: Use time_before, time_before_eq, etc.

2007-12-26 Thread Ray Lee
On Dec 26, 2007 7:21 AM, Julia Lawall <[EMAIL PROTECTED]> wrote: > - if (jiffies - ent->last_usage < timeout) > + if (time_before(jiffies, ent->last_usage + timeout)) I don't think this is a safe change? subtraction is always safe (if you think about it as 'distance'),

Re: [PATCH 1/4] fs/autofs: Use time_before, time_before_eq, etc.

2007-12-26 Thread Ray Lee
On Dec 26, 2007 7:21 AM, Julia Lawall [EMAIL PROTECTED] wrote: - if (jiffies - ent-last_usage timeout) + if (time_before(jiffies, ent-last_usage + timeout)) I don't think this is a safe change? subtraction is always safe (if you think about it as 'distance'),

Re: Debugging process hanging in D status and not responding to SIGKILL

2007-12-21 Thread Ray Lee
On Dec 21, 2007 7:38 AM, Christian Hammers <[EMAIL PROTECTED]> wrote: > Hello > > Occasionally all my apache2 processes hang in "D" process status where they > are > no longer responsible to SIGKILL which makes the server almost un-rebootable. > The processes usually vanish after about 15-30min.

Re: Debugging process hanging in D status and not responding to SIGKILL

2007-12-21 Thread Ray Lee
On Dec 21, 2007 7:38 AM, Christian Hammers [EMAIL PROTECTED] wrote: Hello Occasionally all my apache2 processes hang in D process status where they are no longer responsible to SIGKILL which makes the server almost un-rebootable. The processes usually vanish after about 15-30min. I know

Re: Signed divides vs shifts (Re: [Security] /dev/urandom uses uninit bytes, leaks user data)

2007-12-17 Thread Ray Lee
On Dec 17, 2007 10:10 AM, Eric Dumazet <[EMAIL PROTECTED]> wrote: > On Mon, 17 Dec 2007 10:05:35 -0800 > "Ray Lee" <[EMAIL PROTECTED]> wrote: > > > On Dec 17, 2007 9:55 AM, Eric Dumazet <[EMAIL PROTECTED]> wrote: > > > - mid =

Re: Signed divides vs shifts (Re: [Security] /dev/urandom uses uninit bytes, leaks user data)

2007-12-17 Thread Ray Lee
On Dec 17, 2007 9:55 AM, Eric Dumazet <[EMAIL PROTECTED]> wrote: > - mid = (last - first) / 2 + first; > + while (low <= high) { > + mid = (low + high) / 2; I think you just introduced a bug. Think about what happens if low=high=MAX_LONG/2 + 1. -- To unsubscribe

Re: Signed divides vs shifts (Re: [Security] /dev/urandom uses uninit bytes, leaks user data)

2007-12-17 Thread Ray Lee
On Dec 17, 2007 9:55 AM, Eric Dumazet [EMAIL PROTECTED] wrote: - mid = (last - first) / 2 + first; + while (low = high) { + mid = (low + high) / 2; I think you just introduced a bug. Think about what happens if low=high=MAX_LONG/2 + 1. -- To unsubscribe from

Re: Signed divides vs shifts (Re: [Security] /dev/urandom uses uninit bytes, leaks user data)

2007-12-17 Thread Ray Lee
On Dec 17, 2007 10:10 AM, Eric Dumazet [EMAIL PROTECTED] wrote: On Mon, 17 Dec 2007 10:05:35 -0800 Ray Lee [EMAIL PROTECTED] wrote: On Dec 17, 2007 9:55 AM, Eric Dumazet [EMAIL PROTECTED] wrote: - mid = (last - first) / 2 + first; + while (low = high

Re: Regression: Wireshark sees no packets in 2.6.24-rc3

2007-12-15 Thread Ray Lee
On Dec 14, 2007 11:09 PM, Ray Lee <[EMAIL PROTECTED]> wrote: > On Dec 14, 2007 6:41 PM, Gabriel C <[EMAIL PROTECTED]> wrote: > Correct, absolutely no traffic. So if it works for you, then either > it's something that got fixed between -rc3 and -rc5, or something odd > whe

Re: Regression: Wireshark sees no packets in 2.6.24-rc3

2007-12-15 Thread Ray Lee
On Dec 14, 2007 11:09 PM, Ray Lee [EMAIL PROTECTED] wrote: On Dec 14, 2007 6:41 PM, Gabriel C [EMAIL PROTECTED] wrote: Correct, absolutely no traffic. So if it works for you, then either it's something that got fixed between -rc3 and -rc5, or something odd when I did a make oldconfig, I

Re: Regression: Wireshark sees no packets in 2.6.24-rc3

2007-12-14 Thread Ray Lee
On Dec 14, 2007 6:41 PM, Gabriel C <[EMAIL PROTECTED]> wrote: > Rafael J. Wysocki wrote: > > On Friday, 14 of December 2007, Ray Lee wrote: > >> tshark -i eth0, eth1, lo are all empty. Works under 2.6.23.0 just > >> fine. A quick scan of the log between 2.6.

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
On Dec 14, 2007 12:13 PM, Michael Buesch <[EMAIL PROTECTED]> wrote: > Ray, I _do_ want to understand what is going on in your machine. > I _have_ to understand it. But I currently do not understand how the > quoted patch could fix modprobe of b43 or rfkill. I'd simply call that > impossible. Then

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
On Dec 14, 2007 11:38 AM, Michael Buesch <[EMAIL PROTECTED]> wrote: > On Friday 14 December 2007 20:25:39 Ray Lee wrote: > > > I'm sorry. The patch that _you_ quoted fixes a blinking LED > > > and nothing else. > > > > Well, you're wrong. Sorry, b

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
On Dec 14, 2007 11:05 AM, Michael Buesch <[EMAIL PROTECTED]> wrote: > On Friday 14 December 2007 19:45:02 Ray Lee wrote: > > > > One problem related to b43 source code, patch exists, has yet to be > > > > merged upstream. > > > > > > Yeah. A p

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
On Dec 14, 2007 10:11 AM, Ingo Molnar <[EMAIL PROTECTED]> wrote: > * Ray Lee <[EMAIL PROTECTED]> wrote: > > > Now I'm going to go off, sit in the sun, sip some coffee, and think > > happy thoughts of kittens playing with yarn for a while. > > ok, and given the

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
I've run out of time to donate to the kernel today, so I'll keep this short. On Dec 14, 2007 10:22 AM, Michael Buesch <[EMAIL PROTECTED]> wrote: > > > If you have a PCI device probing works as follows: > > > The PCI table is in ssb. So as soon as your kernel detects the PCI device > > > it will

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
On Dec 14, 2007 8:49 AM, Michael Buesch <[EMAIL PROTECTED]> wrote: > On Friday 14 December 2007 17:06:39 Ray Lee wrote: > > Hi all. Perhaps I can inject some facts into this? > > > > On Dec 14, 2007 5:08 AM, Michael Buesch <[EMAIL PROTECTED]> wrote: > >

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
On Dec 14, 2007 8:59 AM, Michael Buesch <[EMAIL PROTECTED]> wrote: > What if you want to compile your own kernel? Well, then you are on > your own anyway. You have to track kernel changes anyway. I'm trying to help you test your code before it goes out to the unsuspecting masses. Do you think I

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
On Dec 14, 2007 8:27 AM, Ray Lee <[EMAIL PROTECTED]> wrote: > On Dec 14, 2007 6:40 AM, <[EMAIL PROTECTED]> wrote: > > Agreed. As a b43legacy maintainer, I'd be happy to know if Ingo > > suggests other ways to smooth out the transition. I haven't read > > pro

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
On Dec 14, 2007 6:40 AM, <[EMAIL PROTECTED]> wrote: > Agreed. As a b43legacy maintainer, I'd be happy to know if Ingo > suggests other ways to smooth out the transition. I haven't read > proposals yet. This isn't rocket science guys. Put a file in somewhere in your tree called

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
Hi all. Perhaps I can inject some facts into this? On Dec 14, 2007 5:08 AM, Michael Buesch <[EMAIL PROTECTED]> wrote: > > > This user did get the following messages in dmesg: > > > > > > b43err(dev->wl, "Firmware file \"%s\" not found " > > >"or load failed.\n", path); > > > b43err(wl,

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
Hi all. Perhaps I can inject some facts into this? On Dec 14, 2007 5:08 AM, Michael Buesch [EMAIL PROTECTED] wrote: This user did get the following messages in dmesg: b43err(dev-wl, Firmware file \%s\ not found or load failed.\n, path); b43err(wl, You must go to

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
On Dec 14, 2007 6:40 AM, [EMAIL PROTECTED] wrote: Agreed. As a b43legacy maintainer, I'd be happy to know if Ingo suggests other ways to smooth out the transition. I haven't read proposals yet. This isn't rocket science guys. Put a file in somewhere in your tree called ReleaseAnnouncement or

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
On Dec 14, 2007 8:27 AM, Ray Lee [EMAIL PROTECTED] wrote: On Dec 14, 2007 6:40 AM, [EMAIL PROTECTED] wrote: Agreed. As a b43legacy maintainer, I'd be happy to know if Ingo suggests other ways to smooth out the transition. I haven't read proposals yet. This isn't rocket science guys. Put

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
On Dec 14, 2007 8:59 AM, Michael Buesch [EMAIL PROTECTED] wrote: What if you want to compile your own kernel? Well, then you are on your own anyway. You have to track kernel changes anyway. I'm trying to help you test your code before it goes out to the unsuspecting masses. Do you think I do

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
On Dec 14, 2007 10:11 AM, Ingo Molnar [EMAIL PROTECTED] wrote: * Ray Lee [EMAIL PROTECTED] wrote: Now I'm going to go off, sit in the sun, sip some coffee, and think happy thoughts of kittens playing with yarn for a while. ok, and given the time-shift and apparent season-shift i'll sit

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
On Dec 14, 2007 8:49 AM, Michael Buesch [EMAIL PROTECTED] wrote: On Friday 14 December 2007 17:06:39 Ray Lee wrote: Hi all. Perhaps I can inject some facts into this? On Dec 14, 2007 5:08 AM, Michael Buesch [EMAIL PROTECTED] wrote: This user did get the following messages in dmesg

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
I've run out of time to donate to the kernel today, so I'll keep this short. On Dec 14, 2007 10:22 AM, Michael Buesch [EMAIL PROTECTED] wrote: If you have a PCI device probing works as follows: The PCI table is in ssb. So as soon as your kernel detects the PCI device it will load ssb.

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
On Dec 14, 2007 11:05 AM, Michael Buesch [EMAIL PROTECTED] wrote: On Friday 14 December 2007 19:45:02 Ray Lee wrote: One problem related to b43 source code, patch exists, has yet to be merged upstream. Yeah. A problem preventing a LED from blinking. That's a real regression

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
On Dec 14, 2007 11:38 AM, Michael Buesch [EMAIL PROTECTED] wrote: On Friday 14 December 2007 20:25:39 Ray Lee wrote: I'm sorry. The patch that _you_ quoted fixes a blinking LED and nothing else. Well, you're wrong. Sorry, but that's just the way it is. See below. It does _not_ fix

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-14 Thread Ray Lee
On Dec 14, 2007 12:13 PM, Michael Buesch [EMAIL PROTECTED] wrote: Ray, I _do_ want to understand what is going on in your machine. I _have_ to understand it. But I currently do not understand how the quoted patch could fix modprobe of b43 or rfkill. I'd simply call that impossible. Then

Re: Regression: Wireshark sees no packets in 2.6.24-rc3

2007-12-14 Thread Ray Lee
On Dec 14, 2007 6:41 PM, Gabriel C [EMAIL PROTECTED] wrote: Rafael J. Wysocki wrote: On Friday, 14 of December 2007, Ray Lee wrote: tshark -i eth0, eth1, lo are all empty. Works under 2.6.23.0 just fine. A quick scan of the log between 2.6.24-rc3 and current tip (-rc5) doesn't show any

Regression: Wireshark sees no packets in 2.6.24-rc3

2007-12-13 Thread Ray Lee
tshark -i eth0, eth1, lo are all empty. Works under 2.6.23.0 just fine. A quick scan of the log between 2.6.24-rc3 and current tip (-rc5) doesn't show any obvious fixes, but then again, what do I know. I'll check current tip on the weekend when I'll have the luxury to have my main system down long

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-13 Thread Ray Lee
On Dec 13, 2007 4:43 PM, Michael Buesch <[EMAIL PROTECTED]> wrote: > On Friday 14 December 2007 01:05:00 Ray Lee wrote: > > Okay, I had to modprobe rfkill-input and rfkill by hand, didn't > > realize that. Hopefully that'll be automatic soon. Regardless, upon > > doing

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-13 Thread Ray Lee
On Dec 13, 2007 5:45 AM, Michael Buesch <[EMAIL PROTECTED]> wrote: > On Thursday 13 December 2007 02:17:16 Ray Lee wrote: > > Uhm, hijacking the thread a bit here, but which driver is supposed to > > be supporting my 4309? Neither b43 nor b43legacy found my wireless, > >

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-13 Thread Ray Lee
On Dec 13, 2007 5:45 AM, Michael Buesch [EMAIL PROTECTED] wrote: On Thursday 13 December 2007 02:17:16 Ray Lee wrote: Uhm, hijacking the thread a bit here, but which driver is supposed to be supporting my 4309? Neither b43 nor b43legacy found my wireless, and I'm not seeing its PCI ID

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-13 Thread Ray Lee
On Dec 13, 2007 4:43 PM, Michael Buesch [EMAIL PROTECTED] wrote: On Friday 14 December 2007 01:05:00 Ray Lee wrote: Okay, I had to modprobe rfkill-input and rfkill by hand, didn't realize that. Hopefully that'll be automatic soon. Regardless, upon doing so, and loading ssb and b43, it sees

Regression: Wireshark sees no packets in 2.6.24-rc3

2007-12-13 Thread Ray Lee
tshark -i eth0, eth1, lo are all empty. Works under 2.6.23.0 just fine. A quick scan of the log between 2.6.24-rc3 and current tip (-rc5) doesn't show any obvious fixes, but then again, what do I know. I'll check current tip on the weekend when I'll have the luxury to have my main system down long

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-12 Thread Ray Lee
On Dec 12, 2007 4:48 PM, Michael Buesch <[EMAIL PROTECTED]> wrote: > This driver is scheduled for removal, so I'd not touch it anymore > to avoid the possibility to introduce a lastminute regression. > The new drivers (b43 and b43legacy) have this fixed (in a different > way by completely removing

Re: [PATCH 3/3] net: wireless: bcm43xx: big_buffer_sem semaphore to mutex

2007-12-12 Thread Ray Lee
On Dec 12, 2007 4:48 PM, Michael Buesch [EMAIL PROTECTED] wrote: This driver is scheduled for removal, so I'd not touch it anymore to avoid the possibility to introduce a lastminute regression. The new drivers (b43 and b43legacy) have this fixed (in a different way by completely removing it).

Re: Why does reading from /dev/urandom deplete entropy so much?

2007-12-11 Thread Ray Lee
On Dec 11, 2007 11:46 AM, Phillip Susi <[EMAIL PROTECTED]> wrote: > Theodore Tso wrote: > > Note that even paranoid applicatons should not be using /dev/random > > for session keys; again, /dev/random isn't magic, and entropy isn't > > unlimited. Instead, such an application should pull 16 bytes

Re: Why does reading from /dev/urandom deplete entropy so much?

2007-12-11 Thread Ray Lee
On Dec 11, 2007 11:46 AM, Phillip Susi [EMAIL PROTECTED] wrote: Theodore Tso wrote: Note that even paranoid applicatons should not be using /dev/random for session keys; again, /dev/random isn't magic, and entropy isn't unlimited. Instead, such an application should pull 16 bytes or so,

Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23

2007-12-09 Thread Ray Lee
On Dec 9, 2007 2:01 PM, Alan Cox <[EMAIL PROTECTED]> wrote: > > Btw, Alan, that "math" is total and utter BULLSH*T, and you should know > > that. > > To blindly argue regressions are critical is sometimes (as in this case) > to argue that "this freeway is no longer compatible with a horse and >

Re: programs vanish with 2.6.22+

2007-12-09 Thread Ray Lee
On Dec 8, 2007 4:25 AM, Markus <[EMAIL PROTECTED]> wrote: > Well, just tried it. Started a dozen konquerors and attached strace to > everyone. When one disapeared, I only got a "Process 9246 detached", > nothing else is printed or written in the log. You could try an ltrace instead, and see if

Re: programs vanish with 2.6.22+

2007-12-09 Thread Ray Lee
On Dec 8, 2007 4:25 AM, Markus [EMAIL PROTECTED] wrote: Well, just tried it. Started a dozen konquerors and attached strace to everyone. When one disapeared, I only got a Process 9246 detached, nothing else is printed or written in the log. You could try an ltrace instead, and see if it's one

Re: 2.6.24-rc4-git5: Reported regressions from 2.6.23

2007-12-09 Thread Ray Lee
On Dec 9, 2007 2:01 PM, Alan Cox [EMAIL PROTECTED] wrote: Btw, Alan, that math is total and utter BULLSH*T, and you should know that. To blindly argue regressions are critical is sometimes (as in this case) to argue that this freeway is no longer compatible with a horse and cart means the

Re: 2.6.24: false double-clicks from USB mouse

2007-12-07 Thread Ray Lee
On Dec 7, 2007 10:32 AM, Dmitry Torokhov <[EMAIL PROTECTED]> wrote: > On Dec 7, 2007 12:59 PM, Ray Lee <[EMAIL PROTECTED]> wrote: > > On Dec 2, 2007 2:07 PM, Jiri Kosina <[EMAIL PROTECTED]> wrote: > > > Thanks. To sum up this longish thread: > > &g

Re: 2.6.24: false double-clicks from USB mouse

2007-12-07 Thread Ray Lee
On Dec 2, 2007 2:07 PM, Jiri Kosina <[EMAIL PROTECTED]> wrote: > Thanks. To sum up this longish thread: > > - Mark seems to be able to reproduce the problem quite easily; I was not > successful reproducing this no matter how hard I tried, and I also > didn't receive any similar bugreports from

Re: 2.6.24: false double-clicks from USB mouse

2007-12-07 Thread Ray Lee
On Dec 2, 2007 2:07 PM, Jiri Kosina [EMAIL PROTECTED] wrote: Thanks. To sum up this longish thread: - Mark seems to be able to reproduce the problem quite easily; I was not successful reproducing this no matter how hard I tried, and I also didn't receive any similar bugreports from anyone

Re: 2.6.24: false double-clicks from USB mouse

2007-12-07 Thread Ray Lee
On Dec 7, 2007 10:32 AM, Dmitry Torokhov [EMAIL PROTECTED] wrote: On Dec 7, 2007 12:59 PM, Ray Lee [EMAIL PROTECTED] wrote: On Dec 2, 2007 2:07 PM, Jiri Kosina [EMAIL PROTECTED] wrote: Thanks. To sum up this longish thread: - Mark seems to be able to reproduce the problem quite easily

Re: Why does reading from /dev/urandom deplete entropy so much?

2007-12-04 Thread Ray Lee
(Why hasn't anyone been cc:ing Matt on this?) On Dec 4, 2007 8:18 AM, Adrian Bunk <[EMAIL PROTECTED]> wrote: > On Tue, Dec 04, 2007 at 12:41:25PM +0100, Marc Haber wrote: > > > While debugging Exim4's GnuTLS interface, I recently found out that > > reading from /dev/urandom depletes entropy as

  1   2   3   4   5   >