[PATCH v9 07/29] x86/mpx: Do not use SIB.index if its value is 100b and ModRM.mod is not 11b

v.shan...@intel.com> Cc: x...@kernel.org Reviewed-by: Borislav Petkov <b...@suse.de> Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86/mm/mpx.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/mpx.c

[PATCH v9 06/29] x86/mpx: Use signed variables to compute effective addresses

t;liverl...@gmail.com> Cc: Adan Hawthorn <adanhawth...@gmail.com> Cc: Joe Perches <j...@perches.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86/mm/mpx.c | 20 ++

[PATCH v9 07/29] x86/mpx: Do not use SIB.index if its value is 100b and ModRM.mod is not 11b

...@kernel.org Reviewed-by: Borislav Petkov Signed-off-by: Ricardo Neri --- arch/x86/mm/mpx.c | 21 +++-- 1 file changed, 19 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/mpx.c b/arch/x86/mm/mpx.c index 57e5bf5..2ad1d4a 100644 --- a/arch/x86/mm/mpx.c +++ b/arch/x86/mm/mpx.c

[PATCH v9 06/29] x86/mpx: Use signed variables to compute effective addresses

Stoakes Cc: Qiaowei Ren Cc: Peter Zijlstra Cc: Nathan Howard Cc: Adan Hawthorn Cc: Joe Perches Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/mm/mpx.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/arch/x86/mm/mpx.c

[PATCH v9 11/29] x86/insn-eval: Add a utility function to get register offsets

l.com> Cc: x...@kernel.org Reviewed-by: Borislav Petkov <b...@suse.de> Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86/include/asm/insn-eval.h | 1 + arch/x86/lib/insn-eval.c | 17 + 2 files changed, 18 insertions(+) diff --git a/a

[PATCH v9 11/29] x86/insn-eval: Add a utility function to get register offsets

Cc: Qiaowei Ren Cc: Arnaldo Carvalho de Melo Cc: Masami Hiramatsu Cc: Adrian Hunter Cc: Kees Cook Cc: Thomas Garnier Cc: Peter Zijlstra Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Reviewed-by: Borislav Petkov Signed-off-by: Ricardo Neri --- arch/x86

[PATCH v9 15/29] x86/insn-eval: Add utility functions to get segment descriptor base address and limit

lt;dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86/include/asm/insn-eval.h | 1 + arch/x86/lib/insn-eval.c | 117 +++ 2

[PATCH v9 15/29] x86/insn-eval: Add utility functions to get segment descriptor base address and limit

Signed-off-by: Ricardo Neri --- arch/x86/include/asm/insn-eval.h | 1 + arch/x86/lib/insn-eval.c | 117 +++ 2 files changed, 118 insertions(+) diff --git a/arch/x86/include/asm/insn-eval.h b/arch/x86/include/asm/insn-eval.h index 7e8c963..25d6e44 100644

[PATCH v9 14/29] x86/insn-eval: Add utility function to get segment descriptor

kov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86/lib/insn-eval.c | 57 ++

[PATCH v9 12/29] x86/insn-eval: Add utility function to identify string instructions

<pet...@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Reviewed-by: Borislav Petkov <b...@suse.de> Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.i

[PATCH v9 14/29] x86/insn-eval: Add utility function to get segment descriptor

Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/lib/insn-eval.c | 57 1 file changed, 57 insertions(+) diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c index 77b48f9..d599dc3 100644 --- a/arch

[PATCH v9 12/29] x86/insn-eval: Add utility function to identify string instructions

Zijlstra Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Reviewed-by: Borislav Petkov Signed-off-by: Ricardo Neri --- arch/x86/lib/insn-eval.c | 28 1 file changed, 28 insertions(+) diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib

[PATCH v9 04/29] uprobes/x86: Use existing definitions for segment override prefixes

<b...@suse.de> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Denys Vlasenko <dvlas...@redhat.com> Cc: Srikar Dronamraju <sri...@linux.vnet.ibm.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> ---

[PATCH v9 13/29] x86/insn-eval: Add utility functions to get segment selector

Adrian Hunter <adrian.hun...@intel.com> Cc: Kees Cook <keesc...@chromium.org> Cc: Thomas Garnier <thgar...@google.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v

[PATCH v9 04/29] uprobes/x86: Use existing definitions for segment override prefixes

. Shankar Signed-off-by: Ricardo Neri --- arch/x86/kernel/uprobes.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/uprobes.c b/arch/x86/kernel/uprobes.c index 495c776..a3755d2 100644 --- a/arch/x86/kernel/uprobes.c +++ b/arch/x86/kernel/uprobes.c

[PATCH v9 13/29] x86/insn-eval: Add utility functions to get segment selector

Cc: Lorenzo Stoakes Cc: Qiaowei Ren Cc: Arnaldo Carvalho de Melo Cc: Masami Hiramatsu Cc: Adrian Hunter Cc: Kees Cook Cc: Thomas Garnier Cc: Peter Zijlstra Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/include/asm

[PATCH v9 21/29] x86/insn-eval: Handle 32-bit address encodings in virtual-8086 mode

<pet...@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86/lib/insn-eval.c | 11 +

[PATCH v9 22/29] x86/insn-eval: Add support to resolve 16-bit addressing encodings

Garnier <thgar...@google.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Signed-off-by: Rica

[PATCH v9 18/29] x86/insn-eval: Incorporate segment base in linear address computation

rnel.org> Cc: Adrian Hunter <adrian.hun...@intel.com> Cc: Kees Cook <keesc...@chromium.org> Cc: Thomas Garnier <thgar...@google.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shan

[PATCH v9 21/29] x86/insn-eval: Handle 32-bit address encodings in virtual-8086 mode

Zijlstra Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/lib/insn-eval.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c index 1d510a6..d43808c 100644

[PATCH v9 22/29] x86/insn-eval: Add support to resolve 16-bit addressing encodings

Cc: Kees Cook Cc: Thomas Garnier Cc: Peter Zijlstra Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/lib/insn-eval.c | 182 +++ 1 file changed, 182 insertions(+) diff --git

[PATCH v9 18/29] x86/insn-eval: Incorporate segment base in linear address computation

King Cc: Lorenzo Stoakes Cc: Qiaowei Ren Cc: Arnaldo Carvalho de Melo Cc: Masami Hiramatsu Cc: Adrian Hunter Cc: Kees Cook Cc: Thomas Garnier Cc: Peter Zijlstra Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/lib

[PATCH v9 17/29] x86/insn-eval: Indicate a 32-bit displacement if ModRM.mod is 0 and ModRM.rm is 101b

..@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86/lib/insn-eval.c | 25 +

[PATCH v9 17/29] x86/insn-eval: Indicate a 32-bit displacement if ModRM.mod is 0 and ModRM.rm is 101b

: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/lib/insn-eval.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c index cb2734a

[PATCH v9 16/29] x86/insn-eval: Add function to get default params of code segment

r...@google.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com&

[PATCH v9 16/29] x86/insn-eval: Add function to get default params of code segment

Cook Cc: Thomas Garnier Cc: Peter Zijlstra Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/include/asm/insn-eval.h | 5 arch/x86/lib/insn-eval.c | 64 2 files changed

[PATCH v9 25/29] x86/umip: Force a page fault when unable to copy emulated result to user

> Cc: Vlastimil Babka <vba...@suse.cz> Cc: Tony Luck <tony.l...@intel.com> Cc: Paolo Bonzini <pbonz...@redhat.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86/kernel/umip.c | 45 +

[PATCH v9 25/29] x86/umip: Force a page fault when unable to copy emulated result to user

: Huang Rui Cc: Jiri Slaby Cc: Jonathan Corbet Cc: Michael S. Tsirkin Cc: Paul Gortmaker Cc: Peter Zijlstra Cc: Ravi V. Shankar Cc: Shuah Khan Cc: Vlastimil Babka Cc: Tony Luck Cc: Paolo Bonzini Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/kernel/umip.c | 45

[PATCH v9 23/29] x86/cpufeature: Add User-Mode Instruction Prevention definitions

t; Cc: Paolo Bonzini <pbonz...@redhat.com> Cc: x...@kernel.org Reviewed-by: Borislav Petkov <b...@suse.de> Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/include/asm/disabled-features.h| 8 ++

[PATCH v9 24/29] x86: Add emulation code for UMIP instructions

@intel.com> Cc: Shuah Khan <sh...@kernel.org> Cc: Vlastimil Babka <vba...@suse.cz> Cc: Tony Luck <tony.l...@intel.com> Cc: Paolo Bonzini <pbonz...@redhat.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linu

[PATCH v9 23/29] x86/cpufeature: Add User-Mode Instruction Prevention definitions

aul Gortmaker Cc: Peter Zijlstra Cc: Ravi V. Shankar Cc: Shuah Khan Cc: Vlastimil Babka Cc: Tony Luck Cc: Paolo Bonzini Cc: x...@kernel.org Reviewed-by: Borislav Petkov Signed-off-by: Ricardo Neri --- arch/x86/include/asm/cpufeatures.h | 1 + arch/x86/include/asm/disabled-features.h

[PATCH v9 24/29] x86: Add emulation code for UMIP instructions

ris Metcalf Cc: Dave Hansen Cc: Fenghua Yu Cc: Huang Rui Cc: Jiri Slaby Cc: Jonathan Corbet Cc: Michael S. Tsirkin Cc: Paul Gortmaker Cc: Peter Zijlstra Cc: Ravi V. Shankar Cc: Shuah Khan Cc: Vlastimil Babka Cc: Tony Luck Cc: Paolo Bonzini Cc: x...@kernel.org Signed-off-by: Ricardo N

[PATCH v9 05/29] x86/mpx: Simplify handling of errors when computing linear addresses

Perches <j...@perches.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Suggested-by: Borislav Petkov <b...@suse.de> Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86/mm/mpx.c | 13 ++--- 1 file changed, 6 insertions(

[PATCH v9 05/29] x86/mpx: Simplify handling of errors when computing linear addresses

Hawthorn Cc: Joe Perches Cc: Ravi V. Shankar Cc: x...@kernel.org Suggested-by: Borislav Petkov Signed-off-by: Ricardo Neri --- arch/x86/mm/mpx.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/x86/mm/mpx.c b/arch/x86/mm/mpx.c index 9ceaa95..f4c48a0 100644

[PATCH v9 26/29] x86: Enable User-Mode Instruction Prevention

pet...@infradead.org> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: Shuah Khan <sh...@kernel.org> Cc: Vlastimil Babka <vba...@suse.cz> Cc: Tony Luck <tony.l...@intel.com> Cc: Paolo Bonzini <pbonz...@redhat.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <

[PATCH v9 27/29] x86/traps: Fixup general protection faults caused by UMIP

Khan <sh...@kernel.org> Cc: Vlastimil Babka <vba...@suse.cz> Cc: Tony Luck <tony.l...@intel.com> Cc: Paolo Bonzini <pbonz...@redhat.com> Cc: x...@kernel.org Reviewed-by: Andy Lutomirski <l...@kernel.org> Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.

[PATCH v9 26/29] x86: Enable User-Mode Instruction Prevention

Bonzini Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/Kconfig | 10 ++ arch/x86/kernel/cpu/common.c | 25 - 2 files changed, 34 insertions(+), 1 deletion(-) diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig index 5442735..b7c06d8 100644

[PATCH v9 27/29] x86/traps: Fixup general protection faults caused by UMIP

sen Cc: Fenghua Yu Cc: Huang Rui Cc: Jiri Slaby Cc: Jonathan Corbet Cc: Michael S. Tsirkin Cc: Paul Gortmaker Cc: Peter Zijlstra Cc: Ravi V. Shankar Cc: Shuah Khan Cc: Vlastimil Babka Cc: Tony Luck Cc: Paolo Bonzini Cc: x...@kernel.org Reviewed-by: Andy Lutomirski Signed-off-by: Rica

[PATCH v9 29/29] selftests/x86: Add tests for instruction str and sldt

lt;m...@redhat.com> Cc: Paul Gortmaker <paul.gortma...@windriver.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: Shuah Khan <sh...@kernel.org> Cc: Vlastimil Babka <vba...@suse.cz> Signed-off-by: Ricardo Neri <ricardo.

[PATCH v9 29/29] selftests/x86: Add tests for instruction str and sldt

l S. Tsirkin Cc: Paul Gortmaker Cc: Peter Zijlstra Cc: Ravi V. Shankar Cc: Shuah Khan Cc: Vlastimil Babka Signed-off-by: Ricardo Neri --- tools/testing/selftests/x86/entry_from_vm86.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/

[PATCH v9 28/29] selftests/x86: Add tests for User-Mode Instruction Prevention

: Jiri Slaby <jsl...@suse.cz> Cc: Jonathan Corbet <cor...@lwn.net> Cc: Michael S. Tsirkin <m...@redhat.com> Cc: Paul Gortmaker <paul.gortma...@windriver.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: Shuah Khan <sh.

[PATCH v9 28/29] selftests/x86: Add tests for User-Mode Instruction Prevention

Cc: Dave Hansen Cc: Fenghua Yu Cc: Huang Rui Cc: Jiri Slaby Cc: Jonathan Corbet Cc: Michael S. Tsirkin Cc: Paul Gortmaker Cc: Peter Zijlstra Cc: Ravi V. Shankar Cc: Shuah Khan Cc: Vlastimil Babka Signed-off-by: Ricardo Neri --- tools/testing/selftests/x86/entry_from_vm86.c | 73

[PATCH v9 03/29] ptrace,x86: Make user_64bit_mode() available to 32-bit builds

: Kees Cook <keesc...@chromium.org> Cc: Thomas Garnier <thgar...@google.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org R

[PATCH v9 19/29] x86/insn-eval: Add support to resolve 32-bit address encodings

Hunter <adrian.hun...@intel.com> Cc: Kees Cook <keesc...@chromium.org> Cc: Thomas Garnier <thgar...@google.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan.

[PATCH v9 03/29] ptrace,x86: Make user_64bit_mode() available to 32-bit builds

: Masami Hiramatsu Cc: Adrian Hunter Cc: Kees Cook Cc: Thomas Garnier Cc: Peter Zijlstra Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Reviewed-by: Borislav Petkov Signed-off-by: Ricardo Neri --- arch/x86/include/asm/ptrace.h | 6 +- 1 file changed, 5

[PATCH v9 19/29] x86/insn-eval: Add support to resolve 32-bit address encodings

: Lorenzo Stoakes Cc: Qiaowei Ren Cc: Arnaldo Carvalho de Melo Cc: Masami Hiramatsu Cc: Adrian Hunter Cc: Kees Cook Cc: Thomas Garnier Cc: Peter Zijlstra Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/lib/insn-eval.c | 160

[PATCH v9 20/29] x86/insn-eval: Add wrapper function for 32 and 64-bit addresses

..@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86/lib/insn-eval.c | 57 +

[PATCH v9 20/29] x86/insn-eval: Add wrapper function for 32 and 64-bit addresses

Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/lib/insn-eval.c | 57 +++- 1 file changed, 52 insertions(+), 5 deletions(-) diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib

Re: [PATCH v8 12/28] x86/insn-eval: Add utility functions to get segment selector

On Thu, 2017-09-28 at 11:36 +0200, Borislav Petkov wrote: > On Wed, Sep 27, 2017 at 03:32:26PM -0700, Ricardo Neri wrote: > > > > The idea is that get_overridden_seg_reg() would implement the logic you > > just described. It would return return INAT_SEG_REG_DEFAULT/IG

Re: [PATCH v8 12/28] x86/insn-eval: Add utility functions to get segment selector

On Thu, 2017-09-28 at 11:36 +0200, Borislav Petkov wrote: > On Wed, Sep 27, 2017 at 03:32:26PM -0700, Ricardo Neri wrote: > > > > The idea is that get_overridden_seg_reg() would implement the logic you > > just described. It would return return INAT_SEG_REG_DEFAULT/IG

Re: [PATCH v8 12/28] x86/insn-eval: Add utility functions to get segment selector

On Wed, 2017-09-27 at 13:47 +0200, Borislav Petkov wrote: > On Tue, Sep 26, 2017 at 09:21:44PM -0700, Ricardo Neri wrote: > > > > This is true except when we don't have an insn at all (well, it may > > be > > non-NULL but it will only contain garbage). The case to which

Re: [PATCH v8 12/28] x86/insn-eval: Add utility functions to get segment selector

On Wed, 2017-09-27 at 13:47 +0200, Borislav Petkov wrote: > On Tue, Sep 26, 2017 at 09:21:44PM -0700, Ricardo Neri wrote: > > > > This is true except when we don't have an insn at all (well, it may > > be > > non-NULL but it will only contain garbage). The case to which

Re: [PATCH v8 12/28] x86/insn-eval: Add utility functions to get segment selector

On Tue, 2017-09-26 at 12:43 +0200, Borislav Petkov wrote: > Hi, > > On Fri, Aug 18, 2017 at 05:27:53PM -0700, Ricardo Neri wrote: > > > > When computing a linear address and segmentation is used, we need > > to know > > the base address of the segment involve

Re: [PATCH v8 12/28] x86/insn-eval: Add utility functions to get segment selector

On Tue, 2017-09-26 at 12:43 +0200, Borislav Petkov wrote: > Hi, > > On Fri, Aug 18, 2017 at 05:27:53PM -0700, Ricardo Neri wrote: > > > > When computing a linear address and segmentation is used, we need > > to know > > the base address of the segment involve

Re: [PATCH v8 11/28] x86/insn-eval: Add utility function to identify string instructions

On Fri, 2017-09-08 at 15:57 +0200, Borislav Petkov wrote: > On Fri, Aug 18, 2017 at 05:27:52PM -0700, Ricardo Neri wrote: > > > > String instructions are special because, in protected mode, the > > linear > > address is always obtained via the ES segment register i

Re: [PATCH v8 11/28] x86/insn-eval: Add utility function to identify string instructions

On Fri, 2017-09-08 at 15:57 +0200, Borislav Petkov wrote: > On Fri, Aug 18, 2017 at 05:27:52PM -0700, Ricardo Neri wrote: > > > > String instructions are special because, in protected mode, the > > linear > > address is always obtained via the ES segment register i

Re: [PATCH v8 10/28] x86/insn-eval: Add a utility function to get register offsets

On Fri, 2017-09-08 at 15:35 +0200, Borislav Petkov wrote: > On Fri, Aug 18, 2017 at 05:27:51PM -0700, Ricardo Neri wrote: > > > > The function get_reg_offset() returns the offset to the register > > the > > argument specifies as indicated in an enumeration

Re: [PATCH v8 10/28] x86/insn-eval: Add a utility function to get register offsets

On Fri, 2017-09-08 at 15:35 +0200, Borislav Petkov wrote: > On Fri, Aug 18, 2017 at 05:27:51PM -0700, Ricardo Neri wrote: > > > > The function get_reg_offset() returns the offset to the register > > the > > argument specifies as indicated in an enumeration

Re: [PATCH v8 09/28] x86/insn-eval: Do not BUG on invalid register type

On Thu, 2017-09-07 at 19:54 +0200, Borislav Petkov wrote: > > Also, I meant to add it to pr_fmt. Feel free to merge this hunk ontop > of > yours: > > --- > diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c > index 3919458fecbf..d46034ddfbb7 100644 > --- a/arch/x86/lib/insn-eval.c

Re: [PATCH v8 09/28] x86/insn-eval: Do not BUG on invalid register type

On Thu, 2017-09-07 at 19:54 +0200, Borislav Petkov wrote: > > Also, I meant to add it to pr_fmt. Feel free to merge this hunk ontop > of > yours: > > --- > diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c > index 3919458fecbf..d46034ddfbb7 100644 > --- a/arch/x86/lib/insn-eval.c

Re: [PATCH v8 08/28] x86/mpx, x86/insn: Relocate insn util functions to a new insn-eval file

On Wed, 2017-09-06 at 17:54 +0200, Borislav Petkov wrote: > On Fri, Aug 18, 2017 at 05:27:49PM -0700, Ricardo Neri wrote: > > Other kernel submodules can benefit from using the utility functions > > defined in mpx.c to obtain the addresses and values of operands contained >

Re: [PATCH v8 08/28] x86/mpx, x86/insn: Relocate insn util functions to a new insn-eval file

On Wed, 2017-09-06 at 17:54 +0200, Borislav Petkov wrote: > On Fri, Aug 18, 2017 at 05:27:49PM -0700, Ricardo Neri wrote: > > Other kernel submodules can benefit from using the utility functions > > defined in mpx.c to obtain the addresses and values of operands contained >

Re: [PATCH v8 02/28] x86/boot: Relocate definition of the initial state of CR0

On Thu, 2017-08-31 at 11:51 +0200, Borislav Petkov wrote: > On Wed, Aug 30, 2017 at 09:04:18PM -0700, Ricardo Neri wrote: > > Thank you! Is it necessary for me to submit a v9 with these updates? > > Perhaps I can make these updates in branch for the maintainers to pull > >

Re: [PATCH v8 02/28] x86/boot: Relocate definition of the initial state of CR0

On Thu, 2017-08-31 at 11:51 +0200, Borislav Petkov wrote: > On Wed, Aug 30, 2017 at 09:04:18PM -0700, Ricardo Neri wrote: > > Thank you! Is it necessary for me to submit a v9 with these updates? > > Perhaps I can make these updates in branch for the maintainers to pull > >

Re: [PATCH v8 06/28] x86/mpx: Do not use SIB.index if its value is 100b and ModRM.mod is not 11b

On Thu, 2017-08-31 at 21:38 +0200, Borislav Petkov wrote: > On Fri, Aug 18, 2017 at 05:27:47PM -0700, Ricardo Neri wrote: > > Section 2.2.1.2 of the Intel 64 and IA-32 Architectures Software > > Developer's Manual volume 2A states that when ModRM.mod !=11b and > > ModRM.rm =

Re: [PATCH v8 06/28] x86/mpx: Do not use SIB.index if its value is 100b and ModRM.mod is not 11b

On Thu, 2017-08-31 at 21:38 +0200, Borislav Petkov wrote: > On Fri, Aug 18, 2017 at 05:27:47PM -0700, Ricardo Neri wrote: > > Section 2.2.1.2 of the Intel 64 and IA-32 Architectures Software > > Developer's Manual volume 2A states that when ModRM.mod !=11b and > > ModRM.rm =

Re: [PATCH v8 05/28] x86/mpx: Use signed variables to compute effective addresses

On Tue, 2017-08-29 at 18:09 +0200, Borislav Petkov wrote: > On Fri, Aug 18, 2017 at 05:27:46PM -0700, Ricardo Neri wrote: > > Even though memory addresses are unsigned, the operands used to compute the > > effective address do have a sign. This is true for ModRM.rm, SIB.base, > &

Re: [PATCH v8 05/28] x86/mpx: Use signed variables to compute effective addresses

On Tue, 2017-08-29 at 18:09 +0200, Borislav Petkov wrote: > On Fri, Aug 18, 2017 at 05:27:46PM -0700, Ricardo Neri wrote: > > Even though memory addresses are unsigned, the operands used to compute the > > effective address do have a sign. This is true for ModRM.rm, SIB.base, > &

Re: [PATCH v8 02/28] x86/boot: Relocate definition of the initial state of CR0

On Fri, 2017-08-25 at 19:41 +0200, Borislav Petkov wrote: Thanks Borislav for your feedback! > On Fri, Aug 18, 2017 at 05:27:43PM -0700, Ricardo Neri wrote: > > Both head_32.S and head_64.S utilize the same value to initialize the > > control register CR0. Also, other parts of t

Re: [PATCH v8 02/28] x86/boot: Relocate definition of the initial state of CR0

On Fri, 2017-08-25 at 19:41 +0200, Borislav Petkov wrote: Thanks Borislav for your feedback! > On Fri, Aug 18, 2017 at 05:27:43PM -0700, Ricardo Neri wrote: > > Both head_32.S and head_64.S utilize the same value to initialize the > > control register CR0. Also, other parts of t

[PATCH v8 01/28] x86/mm: Relocate page fault error codes to traps.h

e...@linux.intel.com> Cc: Josh Poimboeuf <jpoim...@redhat.com> Cc: Dave Hansen <dave.han...@linux.intel.com> Cc: Paul Gortmaker <paul.gortma...@windriver.com> Cc: x...@kernel.org Reviewed-by: Andy Lutomirski <l...@kernel.org> Reviewed-by: Borislav Petkov <b...@suse.de> S

[PATCH v8 01/28] x86/mm: Relocate page fault error codes to traps.h

-by: Borislav Petkov Signed-off-by: Ricardo Neri --- arch/x86/include/asm/traps.h | 18 + arch/x86/mm/fault.c | 88 +--- 2 files changed, 52 insertions(+), 54 deletions(-) diff --git a/arch/x86/include/asm/traps.h b/arch/x86/inclu

[PATCH v8 06/28] x86/mpx: Do not use SIB.index if its value is 100b and ModRM.mod is not 11b

gt; Cc: Lorenzo Stoakes <lstoa...@gmail.com> Cc: Qiaowei Ren <qiaowei@intel.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Nathan Howard <liverl...@gmail.com> Cc: Adan Hawthorn <adanhawth...@gmail.com> Cc: Joe Perches <j...@perches.com> Cc: Ravi V. Shankar <ravi

[PATCH v8 06/28] x86/mpx: Do not use SIB.index if its value is 100b and ModRM.mod is not 11b

...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/mm/mpx.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/arch/x86/mm/mpx.c b/arch/x86/mm/mpx.c index 9eec98022510..892aa6468805 100644 --- a/arch/x86/mm/mpx.c +++ b/arch/x86/mm/mpx.c @@ -110,6 +110,15

[PATCH v8 07/28] x86/mpx: Do not use SIB.base if its value is 101b and ModRM.mod = 0

d.org> Cc: Nathan Howard <liverl...@gmail.com> Cc: Adan Hawthorn <adanhawth...@gmail.com> Cc: Joe Perches <j...@perches.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com>

[PATCH v8 07/28] x86/mpx: Do not use SIB.base if its value is 101b and ModRM.mod = 0

Buchbinder Cc: Colin Ian King Cc: Lorenzo Stoakes Cc: Qiaowei Ren Cc: Peter Zijlstra Cc: Nathan Howard Cc: Adan Hawthorn Cc: Joe Perches Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/mm/mpx.c | 28 +++- 1 file changed, 19 insertions

[PATCH v8 02/28] x86/boot: Relocate definition of the initial state of CR0

Peter Zijlstra <pet...@infradead.org> Cc: Thomas Gleixner <t...@linutronix.de> Cc: linux-a...@vger.kernel.org Cc: linux...@kvack.org Suggested-by: Borislav Petkov <b...@alien8.de> Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86/include/uapi/asm/process

[PATCH v8 02/28] x86/boot: Relocate definition of the initial state of CR0

: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: linux-a...@vger.kernel.org Cc: linux...@kvack.org Suggested-by: Borislav Petkov Signed-off-by: Ricardo Neri --- arch/x86/include/uapi/asm/processor-flags.h | 6 ++ arch/x86/kernel/head_32.S | 3 --- arch/x86/kernel

[PATCH v8 03/28] ptrace,x86: Make user_64bit_mode() available to 32-bit builds

: Kees Cook <keesc...@chromium.org> Cc: Thomas Garnier <thgar...@google.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org R

[PATCH v8 00/28] x86: Enable User-Mode Instruction Prevention

f SIGSEGV signals when running in virtual-8086 mode. * Reused code from MPX to decode instructions operands. For this purpose code was put in a common location. * Fixed two bugs in MPX code that decodes operands. Ricardo Neri (28): x86/mm: Relocate page fault error codes to traps.h x86/boot:

[PATCH v8 03/28] ptrace,x86: Make user_64bit_mode() available to 32-bit builds

: Masami Hiramatsu Cc: Adrian Hunter Cc: Kees Cook Cc: Thomas Garnier Cc: Peter Zijlstra Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Reviewed-by: Borislav Petkov Signed-off-by: Ricardo Neri --- arch/x86/include/asm/ptrace.h | 6 +- 1 file changed, 5

[PATCH v8 00/28] x86: Enable User-Mode Instruction Prevention

f SIGSEGV signals when running in virtual-8086 mode. * Reused code from MPX to decode instructions operands. For this purpose code was put in a common location. * Fixed two bugs in MPX code that decodes operands. Ricardo Neri (28): x86/mm: Relocate page fault error codes to traps.h x86/boot:

[PATCH v8 12/28] x86/insn-eval: Add utility functions to get segment selector

<pet...@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86/include/asm/inat.h | 10 +

[PATCH v8 12/28] x86/insn-eval: Add utility functions to get segment selector

Zijlstra Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/include/asm/inat.h | 10 ++ arch/x86/lib/insn-eval.c| 278 2 files changed, 288 insertions(+) diff --git a/arch/x86

[PATCH v8 13/28] x86/insn-eval: Add utility function to get segment descriptor

v <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86/lib/insn-eval.c | 55 1

[PATCH v8 15/28] x86/insn-eval: Add function to get default params of code segment

r...@google.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com&

[PATCH v8 13/28] x86/insn-eval: Add utility function to get segment descriptor

Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/lib/insn-eval.c | 55 1 file changed, 55 insertions(+) diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c index 86f58ce6c302..9cf2c49afc15 100644

[PATCH v8 15/28] x86/insn-eval: Add function to get default params of code segment

Cook Cc: Thomas Garnier Cc: Peter Zijlstra Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/include/asm/insn-eval.h | 5 arch/x86/lib/insn-eval.c | 59 2 files changed

[PATCH v8 16/28] x86/insn-eval: Indicate a 32-bit displacement if ModRM.mod is 0 and ModRM.rm is 101b

..@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86/lib/insn-eval.c | 26 +

[PATCH v8 14/28] x86/insn-eval: Add utility functions to get segment descriptor base address and limit

Hunter <adrian.hun...@intel.com> Cc: Kees Cook <keesc...@chromium.org> Cc: Thomas Garnier <thgar...@google.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan.

[PATCH v8 16/28] x86/insn-eval: Indicate a 32-bit displacement if ModRM.mod is 0 and ModRM.rm is 101b

: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/lib/insn-eval.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c index

[PATCH v8 14/28] x86/insn-eval: Add utility functions to get segment descriptor base address and limit

: Lorenzo Stoakes Cc: Qiaowei Ren Cc: Arnaldo Carvalho de Melo Cc: Masami Hiramatsu Cc: Adrian Hunter Cc: Kees Cook Cc: Thomas Garnier Cc: Peter Zijlstra Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/include/asm/insn

[PATCH v8 04/28] uprobes/x86: Use existing definitions for segment override prefixes

<b...@suse.de> Cc: Masami Hiramatsu <mhira...@kernel.org> Cc: Denys Vlasenko <dvlas...@redhat.com> Cc: Srikar Dronamraju <sri...@linux.vnet.ibm.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> ---

[PATCH v8 19/28] x86/insn-eval: Add wrapper function for 32 and 64-bit addresses

m> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86

[PATCH v8 19/28] x86/insn-eval: Add wrapper function for 32 and 64-bit addresses

: Thomas Garnier Cc: Peter Zijlstra Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/lib/insn-eval.c | 53 ++-- 1 file changed, 47 insertions(+), 6 deletions(-) diff --git a/arch/x86

[PATCH v8 04/28] uprobes/x86: Use existing definitions for segment override prefixes

. Shankar Signed-off-by: Ricardo Neri --- arch/x86/kernel/uprobes.c | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/arch/x86/kernel/uprobes.c b/arch/x86/kernel/uprobes.c index 495c776de4b4..a3755d293a48 100644 --- a/arch/x86/kernel/uprobes.c +++ b/arch/x86/kernel

[PATCH v8 21/28] x86/insn-eval: Add support to resolve 16-bit addressing encodings

Garnier <thgar...@google.com> Cc: Peter Zijlstra <pet...@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Signed-off-by: Rica

[PATCH v8 21/28] x86/insn-eval: Add support to resolve 16-bit addressing encodings

Cc: Kees Cook Cc: Thomas Garnier Cc: Peter Zijlstra Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/lib/insn-eval.c | 171 +++ 1 file changed, 171 insertions(+) diff --git

[PATCH v8 20/28] x86/insn-eval: Handle 32-bit address encodings in virtual-8086 mode

<pet...@infradead.org> Cc: Borislav Petkov <b...@suse.de> Cc: Dmitry Vyukov <dvyu...@google.com> Cc: Ravi V. Shankar <ravi.v.shan...@intel.com> Cc: x...@kernel.org Signed-off-by: Ricardo Neri <ricardo.neri-calde...@linux.intel.com> --- arch/x86/lib/insn-eval.c | 11 +

[PATCH v8 20/28] x86/insn-eval: Handle 32-bit address encodings in virtual-8086 mode

Zijlstra Cc: Borislav Petkov Cc: Dmitry Vyukov Cc: Ravi V. Shankar Cc: x...@kernel.org Signed-off-by: Ricardo Neri --- arch/x86/lib/insn-eval.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/arch/x86/lib/insn-eval.c b/arch/x86/lib/insn-eval.c index 6537b613d0b3..93a6d1f57c2d

<    1   2   3   4   5   6   7   8   9   10   >