Re: [alsa-devel] [PATCH v3] ASoC: sgtl5000: add avc support

2017-07-20 Thread Richard Leitner
Hi Fabio, thanks for the testing/reporting! On 07/20/2017 07:11 PM, Fabio Estevam wrote: Running linux-next-20170720 on a imx53-qsb I get the following issue: root@imx53qsb:~# reboot ... ALSA: Storing mixer settings... [ 20.031604] Unable to handle kernel paging request at virtual address

Re: [alsa-devel] [PATCH v3] ASoC: sgtl5000: add avc support

2017-07-20 Thread Richard Leitner
Hi Fabio, thanks for the testing/reporting! On 07/20/2017 07:11 PM, Fabio Estevam wrote: Running linux-next-20170720 on a imx53-qsb I get the following issue: root@imx53qsb:~# reboot ... ALSA: Storing mixer settings... [ 20.031604] Unable to handle kernel paging request at virtual address

Re: [PATCH] ASoC: sgtl5000: add AVC configuration controls

2017-07-18 Thread Richard Leitner
On 07/18/2017 03:55 PM, Mark Brown wrote: On Tue, Jun 06, 2017 at 02:04:22PM +0200, Richard Leitner wrote: For the configuration of the automatic volume control block (AVC), which reduces loud signals and amplifies low level signals for easier listening, following controls are added

Re: [PATCH] ASoC: sgtl5000: add AVC configuration controls

2017-07-18 Thread Richard Leitner
On 07/18/2017 03:55 PM, Mark Brown wrote: On Tue, Jun 06, 2017 at 02:04:22PM +0200, Richard Leitner wrote: For the configuration of the automatic volume control block (AVC), which reduces loud signals and amplifies low level signals for easier listening, following controls are added

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-12 Thread Richard Leitner
On 07/07/2017 04:00 PM, Andrew Lunn wrote: >> Ok. I'm fine with moving the phy-reset-gpios binding into the PHY. >> But one question still remains: Who should then trigger the "hard >> reset" of the PHY? > > Hi Richard > > I think i see a few whys to do this, but first i need to check >

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-12 Thread Richard Leitner
On 07/07/2017 04:00 PM, Andrew Lunn wrote: >> Ok. I'm fine with moving the phy-reset-gpios binding into the PHY. >> But one question still remains: Who should then trigger the "hard >> reset" of the PHY? > > Hi Richard > > I think i see a few whys to do this, but first i need to check >

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-07 Thread Richard Leitner
Hi Andy, thanks for the clarifications! On 07/07/2017 01:08 PM, Andy Duan wrote: 3. Who should then trigger the "hard reset" of the PHY? phy_init_hw? The FEC? The point is that the LAN8710 is currently not always working correctly, therefore this small change was proposed. Should we really

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-07 Thread Richard Leitner
Hi Andy, thanks for the clarifications! On 07/07/2017 01:08 PM, Andy Duan wrote: 3. Who should then trigger the "hard reset" of the PHY? phy_init_hw? The FEC? The point is that the LAN8710 is currently not always working correctly, therefore this small change was proposed. Should we really

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-07 Thread Richard Leitner
On 07/07/2017 09:03 AM, Andy Duan wrote: From: Richard Leitner <richard.leit...@skidata.com> Sent: Friday, July 07, 2017 1:51 PM Since it is common issue so long as using the PHY, can you move it into smsc phy driver like in .smsc_phy_reset() function ? And get the reset pin from p

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-07 Thread Richard Leitner
On 07/07/2017 09:03 AM, Andy Duan wrote: From: Richard Leitner Sent: Friday, July 07, 2017 1:51 PM Since it is common issue so long as using the PHY, can you move it into smsc phy driver like in .smsc_phy_reset() function ? And get the reset pin from phy dts node. Some more points

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-07 Thread Richard Leitner
On 07/07/2017 07:30 AM, Andy Duan wrote: From: Richard Leitner <richard.leit...@skidata.com> Sent: Thursday, July 06, 2017 9:06 PM To: Andy Duan <fugang.d...@nxp.com>; robh...@kernel.org; mark.rutl...@arm.com Cc: net...@vger.kernel.org; devicet...@vger.kernel.org

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-07 Thread Richard Leitner
On 07/07/2017 07:30 AM, Andy Duan wrote: From: Richard Leitner Sent: Thursday, July 06, 2017 9:06 PM To: Andy Duan ; robh...@kernel.org; mark.rutl...@arm.com Cc: net...@vger.kernel.org; devicet...@vger.kernel.org; linux- ker...@vger.kernel.org; d...@g0hl1n.net; Richard Leitner Subject

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-06 Thread Richard Leitner
On 07/06/2017 03:55 PM, Andrew Lunn wrote: >> diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt >> b/Documentation/devicetree/bindings/net/fsl-fec.txt >> index 6f55bdd..1766579 100644 >> --- a/Documentation/devicetree/bindings/net/fsl-fec.txt >> +++

Re: [PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-06 Thread Richard Leitner
On 07/06/2017 03:55 PM, Andrew Lunn wrote: >> diff --git a/Documentation/devicetree/bindings/net/fsl-fec.txt >> b/Documentation/devicetree/bindings/net/fsl-fec.txt >> index 6f55bdd..1766579 100644 >> --- a/Documentation/devicetree/bindings/net/fsl-fec.txt >> +++

[PATCH 1/2] net: ethernet: freescale: simplify fec_reset_phy

2017-07-06 Thread Richard Leitner
anytime after probe. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- drivers/net/ethernet/freescale/fec.h | 4 ++ drivers/net/ethernet/freescale/fec_main.c | 85 --- 2 files changed, 47 insertions(+), 42 deletions(-) diff --git a/drive

[PATCH 1/2] net: ethernet: freescale: simplify fec_reset_phy

2017-07-06 Thread Richard Leitner
anytime after probe. Signed-off-by: Richard Leitner --- drivers/net/ethernet/freescale/fec.h | 4 ++ drivers/net/ethernet/freescale/fec_main.c | 85 --- 2 files changed, 47 insertions(+), 42 deletions(-) diff --git a/drivers/net/ethernet/freescale/fec.h b

[PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-06 Thread Richard Leitner
389902 https://community.nxp.com/message/309354 With this patch applied the issue didn't occur for at least a few hundred PORs of our board. Fixes: e8fcfcd5684a ("net: fec: optimize the clock management to sa...") Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --

[PATCH 2/2] net: ethernet: fsl: add phy reset after clk enable option

2017-07-06 Thread Richard Leitner
389902 https://community.nxp.com/message/309354 With this patch applied the issue didn't occur for at least a few hundred PORs of our board. Fixes: e8fcfcd5684a ("net: fec: optimize the clock management to sa...") Signed-off-by: Richard Leitner --- Documentation/devicetree

Re: [EXT] Re: [PATCH v2] mmc: core: add mmc-card hardware reset enable support

2017-06-20 Thread Richard Leitner
On 06/20/2017 11:45 AM, Linus Walleij wrote: >> IMHO mmc-util is where the patch really stands: the enabling is OTP, >> the programmer have to use mmc-util only once and the kernel >> will behave accordingly. > > So we should not add it to the device tree. > >> Any platform vendor must check

Re: [EXT] Re: [PATCH v2] mmc: core: add mmc-card hardware reset enable support

2017-06-20 Thread Richard Leitner
On 06/20/2017 11:45 AM, Linus Walleij wrote: >> IMHO mmc-util is where the patch really stands: the enabling is OTP, >> the programmer have to use mmc-util only once and the kernel >> will behave accordingly. > > So we should not add it to the device tree. > >> Any platform vendor must check

[PATCH v4] ASoC: sgtl5000: add avc support

2017-06-14 Thread Richard Leitner
ckpatch.pl strict checks are ignored because the indentation style is different for the struct snd_kcontrol_new definition: patch:147: CHECK: Alignment should match open parenthesis patch:150: CHECK: Alignment should match open parenthesis Signed-off-by: Richard Leitner <

[PATCH v4] ASoC: sgtl5000: add avc support

2017-06-14 Thread Richard Leitner
ckpatch.pl strict checks are ignored because the indentation style is different for the struct snd_kcontrol_new definition: patch:147: CHECK: Alignment should match open parenthesis patch:150: CHECK: Alignment should match open parenthesis Signed-off-by: Richard Leitner ---

Re: [PATCH v2] mmc: core: add mmc-card hardware reset enable support

2017-06-14 Thread Richard Leitner
On 04/11/2017 12:43 PM, Ulf Hansson wrote: > On 11 April 2017 at 10:17, Linus Walleij <linus.wall...@linaro.org> wrote: >> On Tue, Apr 11, 2017 at 9:31 AM, Richard Leitner >> <richard.leit...@skidata.com> wrote: >> >>> Some eMMCs disable their hardwar

Re: [PATCH v2] mmc: core: add mmc-card hardware reset enable support

2017-06-14 Thread Richard Leitner
On 04/11/2017 12:43 PM, Ulf Hansson wrote: > On 11 April 2017 at 10:17, Linus Walleij wrote: >> On Tue, Apr 11, 2017 at 9:31 AM, Richard Leitner >> wrote: >> >>> Some eMMCs disable their hardware reset line (RST_N) by default. To enable >>> it the host

[PATCH v3] ASoC: sgtl5000: add avc support

2017-06-13 Thread Richard Leitner
ckpatch.pl strict checks are ignored because the indentation style is different for the struct snd_kcontrol_new definition: patch:145: CHECK: Alignment should match open parenthesis patch:148: CHECK: Alignment should match open parenthesis Signed-off-by: Richard Leitner <

[PATCH v3] ASoC: sgtl5000: add avc support

2017-06-13 Thread Richard Leitner
ckpatch.pl strict checks are ignored because the indentation style is different for the struct snd_kcontrol_new definition: patch:145: CHECK: Alignment should match open parenthesis patch:148: CHECK: Alignment should match open parenthesis Signed-off-by: Richard Leitner ---

[PATCH] ASoC: sgtl5000: add AVC configuration controls

2017-06-06 Thread Richard Leitner
definition: patch:144: CHECK: Alignment should match open parenthesis patch:147: CHECK: Alignment should match open parenthesis Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- sound/soc/codecs/sgtl5000.c | 85 + 1 file change

[PATCH] ASoC: sgtl5000: add AVC configuration controls

2017-06-06 Thread Richard Leitner
definition: patch:144: CHECK: Alignment should match open parenthesis patch:147: CHECK: Alignment should match open parenthesis Signed-off-by: Richard Leitner --- sound/soc/codecs/sgtl5000.c | 85 + 1 file changed, 85 insertions(+) diff --git a

[PATCH v2] ASoC: sgtl5000: add avc enable control

2017-05-30 Thread Richard Leitner
This control enables the automatic volume control (AVC) of SGTL5000 using its DAP_AVC_CTRL register. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- CHANGES v2: - added trailing "Switch" as covered in ControlNames.txt --- sound/soc/codecs/sgtl5000.

[PATCH v2] ASoC: sgtl5000: add avc enable control

2017-05-30 Thread Richard Leitner
This control enables the automatic volume control (AVC) of SGTL5000 using its DAP_AVC_CTRL register. Signed-off-by: Richard Leitner --- CHANGES v2: - added trailing "Switch" as covered in ControlNames.txt --- sound/soc/codecs/sgtl5000.c | 2 ++ 1 file changed, 2 insertion

Re: [PATCH] ASoC: sgtl5000: add avc enable control

2017-05-30 Thread Richard Leitner
On 05/30/2017 01:33 PM, Mark Brown wrote: > On Tue, May 30, 2017 at 01:00:19PM +0200, Richard Leitner wrote: > >> + >> +SOC_SINGLE("AVC Enable", SGTL5000_DAP_AVC_CTRL, 0, 1, 0), > > All on/off switches should end in Switch as covered in ControlNames.txt. Ok. Sorry & Thanks. I'll send a V2.

Re: [PATCH] ASoC: sgtl5000: add avc enable control

2017-05-30 Thread Richard Leitner
On 05/30/2017 01:33 PM, Mark Brown wrote: > On Tue, May 30, 2017 at 01:00:19PM +0200, Richard Leitner wrote: > >> + >> +SOC_SINGLE("AVC Enable", SGTL5000_DAP_AVC_CTRL, 0, 1, 0), > > All on/off switches should end in Switch as covered in ControlNames.txt. Ok. Sorry & Thanks. I'll send a V2.

[PATCH] ASoC: sgtl5000: add avc enable control

2017-05-30 Thread Richard Leitner
This control enables the automatic volume control (AVC) of SGTL5000 using its DAP_AVC_CTRL register. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- sound/soc/codecs/sgtl5000.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/

[PATCH] ASoC: sgtl5000: add avc enable control

2017-05-30 Thread Richard Leitner
This control enables the automatic volume control (AVC) of SGTL5000 using its DAP_AVC_CTRL register. Signed-off-by: Richard Leitner --- sound/soc/codecs/sgtl5000.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index 5a2702e

Re: Microchip USB Hub Driver Harmonization

2017-05-17 Thread Richard Leitner
On 05/17/2017 06:01 PM, Krzysztof Kozlowski wrote: On Wed, May 17, 2017 at 12:58:38PM +0200, Richard Leitner wrote: ... 1. Currently usb251xb uses i2c_smbus_*, usb3503 uses regmap_* and usb4604 uses i2c_master_* functions for the hub configuration. What would be the preferred solution

Re: Microchip USB Hub Driver Harmonization

2017-05-17 Thread Richard Leitner
On 05/17/2017 06:01 PM, Krzysztof Kozlowski wrote: On Wed, May 17, 2017 at 12:58:38PM +0200, Richard Leitner wrote: ... 1. Currently usb251xb uses i2c_smbus_*, usb3503 uses regmap_* and usb4604 uses i2c_master_* functions for the hub configuration. What would be the preferred solution

Microchip USB Hub Driver Harmonization

2017-05-17 Thread Richard Leitner
Hello, due to the fact (all?) the Microchip (former SMSC) USB hubs share the same I2C configuration interface, I'm currently working on harmonizing those USB Hub drivers. Currently this affects the usb251xb, usb3503 and usb4604 drivers. To avoid preventable efforts (and patch versions) I have some

Microchip USB Hub Driver Harmonization

2017-05-17 Thread Richard Leitner
Hello, due to the fact (all?) the Microchip (former SMSC) USB hubs share the same I2C configuration interface, I'm currently working on harmonizing those USB Hub drivers. Currently this affects the usb251xb, usb3503 and usb4604 drivers. To avoid preventable efforts (and patch versions) I have some

[PATCH v2] mmc: core: add mmc-card hardware reset enable support

2017-04-11 Thread Richard Leitner
initialization. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- CHANGES v2: - add RST_N_FUNCTION value to dt documentation - set RST_N_FUNCTION only if it was not set before --- Documentation/devicetree/bindings/mmc/mmc-card.txt | 4 drivers/mmc/core

[PATCH v2] mmc: core: add mmc-card hardware reset enable support

2017-04-11 Thread Richard Leitner
initialization. Signed-off-by: Richard Leitner --- CHANGES v2: - add RST_N_FUNCTION value to dt documentation - set RST_N_FUNCTION only if it was not set before --- Documentation/devicetree/bindings/mmc/mmc-card.txt | 4 drivers/mmc/core/mmc.c | 23

Re: [PATCH] mmc: core: add mmc-card hardware reset enable support

2017-04-05 Thread Richard Leitner
On 04/05/2017 06:40 AM, Jaehoon Chung wrote: > Hi, > > On 04/04/2017 11:16 PM, Richard Leitner wrote: >> Some eMMCs disable their hardware reset line (RST_N) by default. To enable >> it the host must set the corresponding bit in ECSD. An example for such >> a device is

Re: [PATCH] mmc: core: add mmc-card hardware reset enable support

2017-04-05 Thread Richard Leitner
On 04/05/2017 06:40 AM, Jaehoon Chung wrote: > Hi, > > On 04/04/2017 11:16 PM, Richard Leitner wrote: >> Some eMMCs disable their hardware reset line (RST_N) by default. To enable >> it the host must set the corresponding bit in ECSD. An example for such >> a device is

[PATCH] mmc: core: add mmc-card hardware reset enable support

2017-04-04 Thread Richard Leitner
initialization. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- Documentation/devicetree/bindings/mmc/mmc-card.txt | 3 +++ drivers/mmc/core/mmc.c | 21 + 2 files changed, 24 insertions(+) diff --git a/Documentation/devicetree/bindin

[PATCH] mmc: core: add mmc-card hardware reset enable support

2017-04-04 Thread Richard Leitner
initialization. Signed-off-by: Richard Leitner --- Documentation/devicetree/bindings/mmc/mmc-card.txt | 3 +++ drivers/mmc/core/mmc.c | 21 + 2 files changed, 24 insertions(+) diff --git a/Documentation/devicetree/bindings/mmc/mmc-card.txt b/Documentation

Re: [PATCH 2/2] nvmem: imx-ocotp: add write support

2017-03-27 Thread Richard Leitner
On 03/27/2017 03:42 PM, Fabio Estevam wrote: > [Adding Pengutronix folks and Shawn on Cc] > > On Mon, Mar 27, 2017 at 10:31 AM, Richard Leitner > <richard.leit...@skidata.com> wrote: >> Implement write routine for OCOTP controller found in i.MX6 SoC's. >> Furth

Re: [PATCH 2/2] nvmem: imx-ocotp: add write support

2017-03-27 Thread Richard Leitner
On 03/27/2017 03:42 PM, Fabio Estevam wrote: > [Adding Pengutronix folks and Shawn on Cc] > > On Mon, Mar 27, 2017 at 10:31 AM, Richard Leitner > wrote: >> Implement write routine for OCOTP controller found in i.MX6 SoC's. >> Furthermore add locking to the read

[PATCH 1/2] nvmem: imx-ocotp: clear error bit after reading locked values

2017-03-27 Thread Richard Leitner
When reading a "read locked" value from the OCOTP controller on i.MX6 SoC's an error bit is set. This bit has to be cleared by software before any new write, read or reload access can be issued. Therefore clear it after we detect such an "locked read". Signed-off

[PATCH 1/2] nvmem: imx-ocotp: clear error bit after reading locked values

2017-03-27 Thread Richard Leitner
When reading a "read locked" value from the OCOTP controller on i.MX6 SoC's an error bit is set. This bit has to be cleared by software before any new write, read or reload access can be issued. Therefore clear it after we detect such an "locked read". Signed-off

[PATCH 2/2] nvmem: imx-ocotp: add write support

2017-03-27 Thread Richard Leitner
Implement write routine for OCOTP controller found in i.MX6 SoC's. Furthermore add locking to the read function to prevent race conditions. The write routine code is based on the fsl_otp driver from Freescale. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- .../devi

[PATCH 2/2] nvmem: imx-ocotp: add write support

2017-03-27 Thread Richard Leitner
Implement write routine for OCOTP controller found in i.MX6 SoC's. Furthermore add locking to the read function to prevent race conditions. The write routine code is based on the fsl_otp driver from Freescale. Signed-off-by: Richard Leitner --- .../devicetree/bindings/nvmem/imx-ocotp.txt

[PATCH] nvmem: imx-ocotp: fix usage of "dev" pointers

2017-03-23 Thread Richard Leitner
Assign the correct dev pointer to struct ocotp_priv during probe. This is needed to display dev_* messages correctly. Furthermore harmonize the usage of dev (instead of >dev) in the probe function. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- drivers/nvmem/imx-oc

[PATCH] nvmem: imx-ocotp: fix usage of "dev" pointers

2017-03-23 Thread Richard Leitner
Assign the correct dev pointer to struct ocotp_priv during probe. This is needed to display dev_* messages correctly. Furthermore harmonize the usage of dev (instead of >dev) in the probe function. Signed-off-by: Richard Leitner --- drivers/nvmem/imx-ocotp.c | 4 +++- 1 file changed

[PATCH v2 0/4] usb: misc: fix/improve USB251xB/xBi dt bindings

2017-03-06 Thread Richard Leitner
MAINTAINERS Richard Leitner (4): usb: usb251xb: remove max_{power,current}_{sp,bp} properties usb: usb251xb: dt: add unit suffix to oc-delay and power-on-time doc: dt-bindings: usb251xb: mark reg as required MAINTAINERS: usb251xb: remove reference inexistent file Documentation/devicetree

[PATCH v2 0/4] usb: misc: fix/improve USB251xB/xBi dt bindings

2017-03-06 Thread Richard Leitner
MAINTAINERS Richard Leitner (4): usb: usb251xb: remove max_{power,current}_{sp,bp} properties usb: usb251xb: dt: add unit suffix to oc-delay and power-on-time doc: dt-bindings: usb251xb: mark reg as required MAINTAINERS: usb251xb: remove reference inexistent file Documentation/devicetree

[PATCH v2 3/4] doc: dt-bindings: usb251xb: mark reg as required

2017-03-06 Thread Richard Leitner
Mark the reg property as required and furthermore fix some typos and spellings in the documentation. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- Documentation/devicetree/bindings/usb/usb251xb.txt | 23 +++--- 1 file changed, 12 insertions(+), 11 del

[PATCH v2 3/4] doc: dt-bindings: usb251xb: mark reg as required

2017-03-06 Thread Richard Leitner
Mark the reg property as required and furthermore fix some typos and spellings in the documentation. Signed-off-by: Richard Leitner --- Documentation/devicetree/bindings/usb/usb251xb.txt | 23 +++--- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/Documentation

[PATCH v2 2/4] usb: usb251xb: dt: add unit suffix to oc-delay and power-on-time

2017-03-06 Thread Richard Leitner
Rename oc-delay-* to oc-delay-us and make it expect a time value. Furthermore add -ms suffix to power-on-time. There changes were suggested by Rob Herring in https://lkml.org/lkml/2017/2/15/1283. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- Documentation/devicetree/bi

[PATCH v2 2/4] usb: usb251xb: dt: add unit suffix to oc-delay and power-on-time

2017-03-06 Thread Richard Leitner
Rename oc-delay-* to oc-delay-us and make it expect a time value. Furthermore add -ms suffix to power-on-time. There changes were suggested by Rob Herring in https://lkml.org/lkml/2017/2/15/1283. Signed-off-by: Richard Leitner --- Documentation/devicetree/bindings/usb/usb251xb.txt | 10

[PATCH v2 1/4] usb: usb251xb: remove max_{power,current}_{sp,bp} properties

2017-03-06 Thread Richard Leitner
-by: Richard Leitner <richard.leit...@skidata.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/usb/usb251xb.txt | 20 -- drivers/usb/misc/usb251xb.c| 24 -- 2 files changed, 4 insertions(+),

[PATCH v2 1/4] usb: usb251xb: remove max_{power,current}_{sp,bp} properties

2017-03-06 Thread Richard Leitner
-by: Richard Leitner Acked-by: Rob Herring --- Documentation/devicetree/bindings/usb/usb251xb.txt | 20 -- drivers/usb/misc/usb251xb.c| 24 -- 2 files changed, 4 insertions(+), 40 deletions(-) diff --git a/Documentation/devicetree/bindings

[PATCH v2 4/4] MAINTAINERS: usb251xb: remove reference inexistent file

2017-03-06 Thread Richard Leitner
The platform_data header file was dropped in the merged version of the USB251xB driver. Therefore remove its reference from the MAINTAINERS file. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAI

[PATCH v2 4/4] MAINTAINERS: usb251xb: remove reference inexistent file

2017-03-06 Thread Richard Leitner
The platform_data header file was dropped in the merged version of the USB251xB driver. Therefore remove its reference from the MAINTAINERS file. Signed-off-by: Richard Leitner --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index c265a5f..c776906

Re: [PATCH v5] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-27 Thread Richard Leitner
On 02/27/2017 10:48 AM, Jan Lübbe wrote: > On Di, 2017-02-21 at 15:57 +0100, Richard Leitner wrote: >>>>> This is a lot of properties. Are you really finding a need for all of >>>>> them? Is this to handle h/w designers too cheap to put down the EEPROM? >>&g

Re: [PATCH v5] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-27 Thread Richard Leitner
On 02/27/2017 10:48 AM, Jan Lübbe wrote: > On Di, 2017-02-21 at 15:57 +0100, Richard Leitner wrote: >>>>> This is a lot of properties. Are you really finding a need for all of >>>>> them? Is this to handle h/w designers too cheap to put down the EEPROM? >>&g

Re: [PATCH v5] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-21 Thread Richard Leitner
On 02/21/2017 03:37 PM, Rob Herring wrote: > On Thu, Feb 16, 2017 at 12:36 AM, Richard Leitner <m...@g0hl1n.net> wrote: >> On 02/16/2017 03:30 AM, Rob Herring wrote: >>> >>> On Fri, Feb 10, 2017 at 09:19:27AM +0100, Richard Leitner wrote: >>>> &g

Re: [PATCH v5] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-21 Thread Richard Leitner
On 02/21/2017 03:37 PM, Rob Herring wrote: > On Thu, Feb 16, 2017 at 12:36 AM, Richard Leitner wrote: >> On 02/16/2017 03:30 AM, Rob Herring wrote: >>> >>> On Fri, Feb 10, 2017 at 09:19:27AM +0100, Richard Leitner wrote: >>>> >>>> This pat

[PATCH 1/3] usb: usb251xb: remove max_{power,current}_{sp,bp} properties

2017-02-21 Thread Richard Leitner
-by: Richard Leitner <richard.leit...@skidata.com> --- Documentation/devicetree/bindings/usb/usb251xb.txt | 20 -- drivers/usb/misc/usb251xb.c| 24 -- 2 files changed, 4 insertions(+), 40 deletions(-) diff --git a/Documentation/devi

[PATCH 1/3] usb: usb251xb: remove max_{power,current}_{sp,bp} properties

2017-02-21 Thread Richard Leitner
-by: Richard Leitner --- Documentation/devicetree/bindings/usb/usb251xb.txt | 20 -- drivers/usb/misc/usb251xb.c| 24 -- 2 files changed, 4 insertions(+), 40 deletions(-) diff --git a/Documentation/devicetree/bindings/usb/usb251xb.txt b

[PATCH 0/3] usb: misc: improve USB251xB/xBi dt bindings

2017-02-21 Thread Richard Leitner
This patchset improves/fixes the USB251xB/xBi devicetree bindings as recommended by Rob Herring. Richard Leitner (3): usb: usb251xb: remove max_{power,current}_{sp,bp} properties usb: usb251xb: dt: add unit suffix to oc-delay and power-on-time doc: dt-bindings: usb251xb: mark reg

[PATCH 0/3] usb: misc: improve USB251xB/xBi dt bindings

2017-02-21 Thread Richard Leitner
This patchset improves/fixes the USB251xB/xBi devicetree bindings as recommended by Rob Herring. Richard Leitner (3): usb: usb251xb: remove max_{power,current}_{sp,bp} properties usb: usb251xb: dt: add unit suffix to oc-delay and power-on-time doc: dt-bindings: usb251xb: mark reg

[PATCH 3/3] doc: dt-bindings: usb251xb: mark reg as required

2017-02-21 Thread Richard Leitner
Mark the reg property as required and furthermore fix some typos and spellings in the documentation. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- Documentation/devicetree/bindings/usb/usb251xb.txt | 23 +++--- 1 file changed, 12 insertions(+), 11 del

[PATCH 3/3] doc: dt-bindings: usb251xb: mark reg as required

2017-02-21 Thread Richard Leitner
Mark the reg property as required and furthermore fix some typos and spellings in the documentation. Signed-off-by: Richard Leitner --- Documentation/devicetree/bindings/usb/usb251xb.txt | 23 +++--- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/Documentation

[PATCH 2/3] usb: usb251xb: dt: add unit suffix to oc-delay and power-on-time

2017-02-21 Thread Richard Leitner
Rename oc-delay-* to oc-delay-us and make it expect a time value. Furthermore add -ms suffix to power-on-time. These changes were suggested by Rob Herring in https://lkml.org/lkml/2017/2/15/1283. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- Documentation/devicetree/bi

[PATCH 2/3] usb: usb251xb: dt: add unit suffix to oc-delay and power-on-time

2017-02-21 Thread Richard Leitner
Rename oc-delay-* to oc-delay-us and make it expect a time value. Furthermore add -ms suffix to power-on-time. These changes were suggested by Rob Herring in https://lkml.org/lkml/2017/2/15/1283. Signed-off-by: Richard Leitner --- Documentation/devicetree/bindings/usb/usb251xb.txt | 9

Re: [PATCH v5] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-15 Thread Richard Leitner
On 02/16/2017 03:30 AM, Rob Herring wrote: On Fri, Feb 10, 2017 at 09:19:27AM +0100, Richard Leitner wrote: This patch adds a driver for configuration of the Microchip USB251xB/xBi USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus configuration interface and two to four

Re: [PATCH v5] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-15 Thread Richard Leitner
On 02/16/2017 03:30 AM, Rob Herring wrote: On Fri, Feb 10, 2017 at 09:19:27AM +0100, Richard Leitner wrote: This patch adds a driver for configuration of the Microchip USB251xB/xBi USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus configuration interface and two to four

[PATCH v5] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-10 Thread Richard Leitner
at the manufacturers website, see [1]. All device-tree exposed configuration features have been tested on a i.MX6 platform with a USB2512B hub. [1] http://ww1.microchip.com/downloads/en/DeviceDoc/1692C.pdf Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- CHANGES v5:

[PATCH v5] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-10 Thread Richard Leitner
at the manufacturers website, see [1]. All device-tree exposed configuration features have been tested on a i.MX6 platform with a USB2512B hub. [1] http://ww1.microchip.com/downloads/en/DeviceDoc/1692C.pdf Signed-off-by: Richard Leitner --- CHANGES v5: - Put includes in alphabetical

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-09 Thread Richard Leitner
On 02/08/2017 09:16 PM, Andy Shevchenko wrote: > On Wed, 2017-02-08 at 21:03 +0100, Richard Leitner wrote: >> Should I keep my inline {clr,set}_bit_in_byte() >> functions an use BIT() in there, or delete them and use BIT() >> directly >> in usb251xb_get_ofdata() ?

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-09 Thread Richard Leitner
On 02/08/2017 09:16 PM, Andy Shevchenko wrote: > On Wed, 2017-02-08 at 21:03 +0100, Richard Leitner wrote: >> Should I keep my inline {clr,set}_bit_in_byte() >> functions an use BIT() in there, or delete them and use BIT() >> directly >> in usb251xb_get_ofdata() ?

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 05:40 PM, Andy Shevchenko wrote: On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: On 02/08/2017 02:59 PM, Greg KH wrote: On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote: On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote: From: Richard Leitner &l

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 05:40 PM, Andy Shevchenko wrote: On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: On 02/08/2017 02:59 PM, Greg KH wrote: On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote: On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote: From: Richard Leitner

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 08:20 PM, Andy Shevchenko wrote: On Wed, 2017-02-08 at 19:45 +0100, Richard Leitner wrote: On 02/08/2017 05:40 PM, Andy Shevchenko wrote: On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: On 02/08/2017 02:59 PM, Greg KH wrote: On Wed, Feb 08, 2017 at 03:21:08PM +0200

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 08:20 PM, Andy Shevchenko wrote: On Wed, 2017-02-08 at 19:45 +0100, Richard Leitner wrote: On 02/08/2017 05:40 PM, Andy Shevchenko wrote: On Wed, 2017-02-08 at 16:17 +0100, Richard Leitner wrote: On 02/08/2017 02:59 PM, Greg KH wrote: On Wed, Feb 08, 2017 at 03:21:08PM +0200

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 02:59 PM, Greg KH wrote: > On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote: >> On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote: >>> From: Richard Leitner <d...@g0hl1n.net> >> >> If you want to fix the above you have to

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 02:59 PM, Greg KH wrote: > On Wed, Feb 08, 2017 at 03:21:08PM +0200, Andy Shevchenko wrote: >> On Wed, 2017-02-08 at 09:52 +0100, Richard Leitner wrote: >>> From: Richard Leitner >> >> If you want to fix the above you have to fix your Git configuration

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 09:52 AM, Richard Leitner wrote: > From: Richard Leitner <d...@g0hl1n.net> Please drop/ignore that "From". This patch is from: Richard Leitner <richard.leit...@skidata.com> > > This patch adds a driver for configuration of the Micro

Re: [PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
On 02/08/2017 09:52 AM, Richard Leitner wrote: > From: Richard Leitner Please drop/ignore that "From". This patch is from: Richard Leitner > > This patch adds a driver for configuration of the Microchip USB251xB/xBi > USB 2.0 hub controller series with USB 2.0

[PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
From: Richard Leitner <d...@g0hl1n.net> This patch adds a driver for configuration of the Microchip USB251xB/xBi USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus configuration interface and two to four USB 2.0 downstream ports. Furthermore add myself as a main

[PATCH v4] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-08 Thread Richard Leitner
From: Richard Leitner This patch adds a driver for configuration of the Microchip USB251xB/xBi USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus configuration interface and two to four USB 2.0 downstream ports. Furthermore add myself as a maintainer for this driver

Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

2017-02-08 Thread Richard Leitner
On 02/06/2017 05:48 PM, Sergei Shtylyov wrote: > Hello! > > On 02/06/2017 05:03 PM, Richard Leitner wrote: > >> For USB string descriptors we need to convert ASCII strings to UTF16-LE. >> Therefore make a simple helper function (based on ascii2desc from &

Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

2017-02-08 Thread Richard Leitner
On 02/06/2017 05:48 PM, Sergei Shtylyov wrote: > Hello! > > On 02/06/2017 05:03 PM, Richard Leitner wrote: > >> For USB string descriptors we need to convert ASCII strings to UTF16-LE. >> Therefore make a simple helper function (based on ascii2desc from &

Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

2017-02-06 Thread Richard Leitner
On 02/06/2017 04:40 PM, Alan Stern wrote: > On Mon, 6 Feb 2017, Richard Leitner wrote: >> So it would be OK to include linux/nls.h and use utf8s_to_utf16s() in >> drivers/usb/{core/hcd.c,misc/usb251xb.c}? > > Well, we already include linux/nls.h in drivers/usb/core/messag

Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

2017-02-06 Thread Richard Leitner
On 02/06/2017 04:40 PM, Alan Stern wrote: > On Mon, 6 Feb 2017, Richard Leitner wrote: >> So it would be OK to include linux/nls.h and use utf8s_to_utf16s() in >> drivers/usb/{core/hcd.c,misc/usb251xb.c}? > > Well, we already include linux/nls.h in drivers/usb/core/messag

Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

2017-02-06 Thread Richard Leitner
On 02/06/2017 04:12 PM, Alan Stern wrote: > On Mon, 6 Feb 2017, Richard Leitner wrote: > >> For USB string descriptors we need to convert ASCII strings to UTF16-LE. >> Therefore make a simple helper function (based on ascii2desc from >> drivers/usb/core/hcd.c) for that pu

Re: [PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

2017-02-06 Thread Richard Leitner
On 02/06/2017 04:12 PM, Alan Stern wrote: > On Mon, 6 Feb 2017, Richard Leitner wrote: > >> For USB string descriptors we need to convert ASCII strings to UTF16-LE. >> Therefore make a simple helper function (based on ascii2desc from >> drivers/usb/core/hcd.c) for that pu

[PATCH v3 3/3] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-06 Thread Richard Leitner
at the manufacturers website, see [1]. All device-tree exposed configuration features have been tested on a i.MX6 platform with a USB2512B hub. [1] http://ww1.microchip.com/downloads/en/DeviceDoc/1692C.pdf Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- Documentation/devi

[PATCH v3 3/3] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-06 Thread Richard Leitner
at the manufacturers website, see [1]. All device-tree exposed configuration features have been tested on a i.MX6 platform with a USB2512B hub. [1] http://ww1.microchip.com/downloads/en/DeviceDoc/1692C.pdf Signed-off-by: Richard Leitner --- Documentation/devicetree/bindings/usb/usb251xb.txt

[PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

2017-02-06 Thread Richard Leitner
For USB string descriptors we need to convert ASCII strings to UTF16-LE. Therefore make a simple helper function (based on ascii2desc from drivers/usb/core/hcd.c) for that purpose. Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- include/linux/string.h | 1 + lib/st

[PATCH v3 1/3] lib/string: introduce ascii2utf16le() helper

2017-02-06 Thread Richard Leitner
For USB string descriptors we need to convert ASCII strings to UTF16-LE. Therefore make a simple helper function (based on ascii2desc from drivers/usb/core/hcd.c) for that purpose. Signed-off-by: Richard Leitner --- include/linux/string.h | 1 + lib/string.c | 26

<    1   2   3   4   >