[PATCH v3 0/3] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-06 Thread Richard Leitner
for ascii2desc in drivers/usb/core/hcd.c - remove platform data support from usb251xb driver CHANGES v2: - fix max-{b,s}p-current property name - add descriptor string handling from platform_data - fix non-dt handling Richard Leitner (3): lib/string

[PATCH v3 0/3] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-06 Thread Richard Leitner
for ascii2desc in drivers/usb/core/hcd.c - remove platform data support from usb251xb driver CHANGES v2: - fix max-{b,s}p-current property name - add descriptor string handling from platform_data - fix non-dt handling Richard Leitner (3): lib/string

[PATCH v3 2/3] usb: core: hcd: use ascii2utf16le() in ascii2desc()

2017-02-06 Thread Richard Leitner
As string.c now provides ascii2utf16le() use it in ascii2desc() for converting the string descriptor. Furthermore fix checkpatch.pl issues in ascii2desc(). Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- drivers/usb/core/hcd.c | 22 ++ 1 file chang

[PATCH v3 2/3] usb: core: hcd: use ascii2utf16le() in ascii2desc()

2017-02-06 Thread Richard Leitner
As string.c now provides ascii2utf16le() use it in ascii2desc() for converting the string descriptor. Furthermore fix checkpatch.pl issues in ascii2desc(). Signed-off-by: Richard Leitner --- drivers/usb/core/hcd.c | 22 ++ 1 file changed, 10 insertions(+), 12 deletions

Re: [PATCH v2] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-06 Thread Richard Leitner
On 02/05/2017 08:42 AM, Greg KH wrote: > On Fri, Feb 03, 2017 at 11:55:24AM +0100, Richard Leitner wrote: >> +/** >> + * ascii2utf16le() - Helper routine for producing UTF-16LE string >> descriptors >> + * @s: Null-terminated ASCII (actually ISO-8859-1) string >&

Re: [PATCH v2] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-06 Thread Richard Leitner
On 02/05/2017 08:42 AM, Greg KH wrote: > On Fri, Feb 03, 2017 at 11:55:24AM +0100, Richard Leitner wrote: >> +/** >> + * ascii2utf16le() - Helper routine for producing UTF-16LE string >> descriptors >> + * @s: Null-terminated ASCII (actually ISO-8859-1) string >&

[PATCH v2] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-03 Thread Richard Leitner
at the manufacturers website, see [1]. All device-tree exposed configuration features have been tested on a i.MX6 platform with a USB2512B hub. [1] http://ww1.microchip.com/downloads/en/DeviceDoc/1692C.pdf Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- CHANGES v2:

[PATCH v2] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-03 Thread Richard Leitner
at the manufacturers website, see [1]. All device-tree exposed configuration features have been tested on a i.MX6 platform with a USB2512B hub. [1] http://ww1.microchip.com/downloads/en/DeviceDoc/1692C.pdf Signed-off-by: Richard Leitner --- CHANGES v2: - fix max-{b,s}p-current property

Re: [RFC PATCH] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-03 Thread Richard Leitner
Hi Greg, On 02/03/2017 10:03 AM, Greg KH wrote: > On Thu, Feb 02, 2017 at 02:44:29PM +0100, Richard Leitner wrote: >> This patch adds a driver for configuration of the Microchip USB251xB/xBi >> USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus >> co

Re: [RFC PATCH] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-03 Thread Richard Leitner
Hi Greg, On 02/03/2017 10:03 AM, Greg KH wrote: > On Thu, Feb 02, 2017 at 02:44:29PM +0100, Richard Leitner wrote: >> This patch adds a driver for configuration of the Microchip USB251xB/xBi >> USB 2.0 hub controller series with USB 2.0 upstream connectivity, SMBus >> co

[RFC PATCH] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-02 Thread Richard Leitner
at the manufacturers website, see [1]. All device-tree exposed configuration features have been tested on a i.MX6 platform with a USB2512B hub. [1] http://ww1.microchip.com/downloads/en/DeviceDoc/1692C.pdf Signed-off-by: Richard Leitner <richard.leit...@skidata.com> --- Documentation/devi

[RFC PATCH] usb: misc: add USB251xB/xBi Hi-Speed Hub Controller Driver

2017-02-02 Thread Richard Leitner
at the manufacturers website, see [1]. All device-tree exposed configuration features have been tested on a i.MX6 platform with a USB2512B hub. [1] http://ww1.microchip.com/downloads/en/DeviceDoc/1692C.pdf Signed-off-by: Richard Leitner --- Documentation/devicetree/bindings/usb/usb251xb.txt

Re: [PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls

2016-10-10 Thread Richard Leitner
On 09/09/2016 12:17 PM, Mark Brown wrote: On Fri, Sep 09, 2016 at 09:46:45AM +0200, Richard Leitner wrote: Hi, any comments, updates or ideas for improvement on that patch? On Wed, 31 Aug 2016 09:26:31 +0200 Richard Leitner <d...@g0hl1n.net> wrote: Please don't top post, reply i

Re: [PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls

2016-10-10 Thread Richard Leitner
On 09/09/2016 12:17 PM, Mark Brown wrote: On Fri, Sep 09, 2016 at 09:46:45AM +0200, Richard Leitner wrote: Hi, any comments, updates or ideas for improvement on that patch? On Wed, 31 Aug 2016 09:26:31 +0200 Richard Leitner wrote: Please don't top post, reply in line with needed context

Re: [PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls

2016-09-09 Thread Richard Leitner
Hi, any comments, updates or ideas for improvement on that patch? regards, Richard On Wed, 31 Aug 2016 09:26:31 +0200 Richard Leitner <d...@g0hl1n.net> wrote: > These controls mute/unmute the LINEOUT and headphone outputs of SGTL5000 > using its CHIP_ANA_CTRL register. >

Re: [PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls

2016-09-09 Thread Richard Leitner
Hi, any comments, updates or ideas for improvement on that patch? regards, Richard On Wed, 31 Aug 2016 09:26:31 +0200 Richard Leitner wrote: > These controls mute/unmute the LINEOUT and headphone outputs of SGTL5000 > using its CHIP_ANA_CTRL register. > > Signed-off-by: Ric

[PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls

2016-08-31 Thread Richard Leitner
These controls mute/unmute the LINEOUT and headphone outputs of SGTL5000 using its CHIP_ANA_CTRL register. Signed-off-by: Richard Leitner <d...@g0hl1n.net> --- CHANGES v2: fix invert value for both controls (sorry I've missed that in my initial tests!) --- sound/soc/codecs/sgtl5000

[PATCH v2] ASoC: sgtl5000: add headphone and LINEOUT mute controls

2016-08-31 Thread Richard Leitner
These controls mute/unmute the LINEOUT and headphone outputs of SGTL5000 using its CHIP_ANA_CTRL register. Signed-off-by: Richard Leitner --- CHANGES v2: fix invert value for both controls (sorry I've missed that in my initial tests!) --- sound/soc/codecs/sgtl5000.c | 3 +++ 1 file

[PATCH] ASoC: sgtl5000: add headphone and LINEOUT mute controls

2016-08-30 Thread Richard Leitner
These controls mute/unmute the LINEOUT and headphone outputs of SGTL5000 using its CHIP_ANA_CTRL register. Signed-off-by: Richard Leitner <d...@g0hl1n.net> --- sound/soc/codecs/sgtl5000.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/

[PATCH] ASoC: sgtl5000: add headphone and LINEOUT mute controls

2016-08-30 Thread Richard Leitner
These controls mute/unmute the LINEOUT and headphone outputs of SGTL5000 using its CHIP_ANA_CTRL register. Signed-off-by: Richard Leitner --- sound/soc/codecs/sgtl5000.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/sgtl5000.c b/sound/soc/codecs/sgtl5000.c index

[PATCH] mm/memblock.c: remove unnecessary always-true comparison

2016-05-10 Thread Richard Leitner
son of unsigned expression >= 0 is always true [-Wtype-limits] if (*idx >= 0 && *idx < type->cnt) { Signed-off-by: Richard Leitner <d...@g0hl1n.net> --- mm/memblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memblock.c b/mm/memblock.c index b57

[PATCH] mm/memblock.c: remove unnecessary always-true comparison

2016-05-10 Thread Richard Leitner
son of unsigned expression >= 0 is always true [-Wtype-limits] if (*idx >= 0 && *idx < type->cnt) { Signed-off-by: Richard Leitner --- mm/memblock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memblock.c b/mm/memblock.c index b570ddd..a1b8549 100644 --- a

[PATCH] iio: ak8975: fix maybe-uninitialized warning

2016-04-05 Thread Richard Leitner
warning: drivers/iio/magnetometer/ak8975.c: In function ‘ak8975_probe’: drivers/iio/magnetometer/ak8975.c:788:14: warning: ‘chipset’ may be used uninitialized in this function [-Wmaybe-uninitialized] data->def = _def_array[chipset]; Signed-off-by: Richard Leitner <d...@g0hl1n.net> --- dr

[PATCH] iio: ak8975: fix maybe-uninitialized warning

2016-04-05 Thread Richard Leitner
warning: drivers/iio/magnetometer/ak8975.c: In function ‘ak8975_probe’: drivers/iio/magnetometer/ak8975.c:788:14: warning: ‘chipset’ may be used uninitialized in this function [-Wmaybe-uninitialized] data->def = _def_array[chipset]; Signed-off-by: Richard Leitner --- drivers/iio/magnetome

Re: [PATCH] misc: ioc4: simplify wave period measurement in clock_calibrate

2014-12-08 Thread Richard Leitner
on't have to look up the function an see the implementation at the first glance. Some comments on the code are embedded below. On Mon, 08 Dec 2014 16:54:11 +0100 Paul Bolle wrote: > On Mon, 2014-12-08 at 16:28 +0100, Richard Leitner wrote: > > The loop for measuring the square

Re: [PATCH] misc: ioc4: simplify wave period measurement in clock_calibrate

2014-12-08 Thread Richard Leitner
On Mon, 08 Dec 2014 16:46:31 +0100 Arnd Bergmann wrote: > On Monday 08 December 2014 16:28:10 Richard Leitner wrote: > > > > Signed-off-by: Richard Leitner > > Acked-by: Arnd Bergmann > > > With the changed loop, do you still get a warning if you > remov

[PATCH] misc: ioc4: simplify wave period measurement in clock_calibrate

2014-12-08 Thread Richard Leitner
^ Signed-off-by: Richard Leitner --- A simplification of this loop was suggested by Andrew Morton [1]. This is my first proposal of such a simplification. Furthermore I'm not sure if the commit message is sufficient. Please give me also some feedback on it. If this simplification is not need

Re: [PATCH] misc: ioc4: fix variable may be used uninitialized warning

2014-12-08 Thread Richard Leitner
On Mon, 08 Dec 2014 13:42:47 +0100 Arnd Bergmann wrote: > On Monday 08 December 2014 13:27:20 Richard Leitner wrote: > > > > As far as I can tell 'start' cannot really be used uninitialized > > here, but for the sanity of gcc output explicitly initialize it. > > Same

[PATCH] misc: ioc4: fix variable may be used uninitialized warning

2014-12-08 Thread Richard Leitner
uint64_t start, end, period; ^ As far as I can tell 'start' cannot really be used uninitialized here, but for the sanity of gcc output explicitly initialize it. Same goes for the 'end' variable. Signed-off-by: Richard Leitner --- Used gcc version was 4.9.1 (Debian 4.9.1-19) P.S.: I

[PATCH] misc: ioc4: fix variable may be used uninitialized warning

2014-12-08 Thread Richard Leitner
uint64_t start, end, period; ^ As far as I can tell 'start' cannot really be used uninitialized here, but for the sanity of gcc output explicitly initialize it. Same goes for the 'end' variable. Signed-off-by: Richard Leitner d...@g0hl1n.net --- Used gcc version was 4.9.1 (Debian 4.9.1

Re: [PATCH] misc: ioc4: fix variable may be used uninitialized warning

2014-12-08 Thread Richard Leitner
On Mon, 08 Dec 2014 13:42:47 +0100 Arnd Bergmann a...@arndb.de wrote: On Monday 08 December 2014 13:27:20 Richard Leitner wrote: As far as I can tell 'start' cannot really be used uninitialized here, but for the sanity of gcc output explicitly initialize it. Same goes for the 'end

[PATCH] misc: ioc4: simplify wave period measurement in clock_calibrate

2014-12-08 Thread Richard Leitner
-by: Richard Leitner d...@g0hl1n.net --- A simplification of this loop was suggested by Andrew Morton [1]. This is my first proposal of such a simplification. Furthermore I'm not sure if the commit message is sufficient. Please give me also some feedback on it. If this simplification is not needed only

Re: [PATCH] misc: ioc4: simplify wave period measurement in clock_calibrate

2014-12-08 Thread Richard Leitner
On Mon, 08 Dec 2014 16:46:31 +0100 Arnd Bergmann a...@arndb.de wrote: On Monday 08 December 2014 16:28:10 Richard Leitner wrote: Signed-off-by: Richard Leitner d...@g0hl1n.net Acked-by: Arnd Bergmann a...@arndb.de With the changed loop, do you still get a warning if you remove

Re: [PATCH] misc: ioc4: simplify wave period measurement in clock_calibrate

2014-12-08 Thread Richard Leitner
the function an see the implementation at the first glance. Some comments on the code are embedded below. On Mon, 08 Dec 2014 16:54:11 +0100 Paul Bolle pebo...@tiscali.nl wrote: On Mon, 2014-12-08 at 16:28 +0100, Richard Leitner wrote: The loop for measuring the square wave periods over some cycles

[PATCH v2] Documentation/email-clients.txt: add info about Claws Mail

2014-12-02 Thread Richard Leitner
Claws Mail GUI client works. The client is available at http://www.claws-mail.org Signed-off-by: Richard Leitner --- changes for v2: mention that disabling Auto wrapping is only needed when the patch has to be edited in the Claws composition window --- Documentation/email

[PATCH v2] Documentation/email-clients.txt: add info about Claws Mail

2014-12-02 Thread Richard Leitner
Claws Mail GUI client works. The client is available at http://www.claws-mail.org Signed-off-by: Richard Leitner d...@g0hl1n.net --- changes for v2: mention that disabling Auto wrapping is only needed when the patch has to be edited in the Claws composition window

Re: [PATCH] Documentation/email-clients.txt: add info about Claws Mail

2014-12-01 Thread Richard Leitner
Hi jon, thanks for your reply. On Mon, 1 Dec 2014 17:34:05 -0500 Jonathan Corbet wrote: > Interesting, I've sent an awful lot of patches with claws and I have > wrapping (a useful feature) enabled. I can't see it being a problem > unless you're writing the patch itself in the claws composition

[PATCH] Documentation/email-clients.txt: add info about Claws Mail

2014-12-01 Thread Richard Leitner
Claws Mail GUI client works when "Auto wrapping" is disabled. Signed-off-by: Richard Leitner --- Documentation/email-clients.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt index 9af538be..1f89

[PATCH] Documentation/email-clients.txt: add info about Claws Mail

2014-12-01 Thread Richard Leitner
Claws Mail GUI client works when Auto wrapping is disabled. Signed-off-by: Richard Leitner d...@g0hl1n.net --- Documentation/email-clients.txt | 9 + 1 file changed, 9 insertions(+) diff --git a/Documentation/email-clients.txt b/Documentation/email-clients.txt index 9af538be..1f8929e

Re: [PATCH] Documentation/email-clients.txt: add info about Claws Mail

2014-12-01 Thread Richard Leitner
Hi jon, thanks for your reply. On Mon, 1 Dec 2014 17:34:05 -0500 Jonathan Corbet cor...@lwn.net wrote: Interesting, I've sent an awful lot of patches with claws and I have wrapping (a useful feature) enabled. I can't see it being a problem unless you're writing the patch itself in the claws

Re: [PATCH] input: avoid negative input device numbers

2014-10-08 Thread Richard Leitner
On Wed, 8 Oct 2014 14:30:51 -0700 Dmitry Torokhov wrote: > On Wed, Oct 08, 2014 at 02:25:38PM -0700, Dmitry Torokhov wrote: > > On Wed, Oct 08, 2014 at 10:42:45PM +0200, Richard Leitner wrote: > > > From: Richard Leitner > > > > > > Fix the format str

[PATCH] serio: avoid negative serio device numbers

2014-10-08 Thread Richard Leitner
From: Richard Leitner Fix the format string for serio device name generation to avoid negative device numbers when the id exceeds the maximum signed integer value. Signed-off-by: Richard Leitner --- drivers/input/serio/serio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH] input: avoid negative input device numbers

2014-10-08 Thread Richard Leitner
From: Richard Leitner Fix the format string for input device name generation to avoid negative device numbers when the id exceeds the maximum signed integer value. Signed-off-by: Richard Leitner --- drivers/input/input.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[RFC] avoid (theoretical) conflicts of input device file names

2014-10-08 Thread Richard Leitner
Hi, currently I discovered the possibility that device file numbers of the input subsystem could go negative when the signed int "border" is passed. To fix this behaviour I sent a patch a few minutes ago. But as the subject says there is currently the (theoretical) possibility that the same input

[RFC] avoid (theoretical) conflicts of input device file names

2014-10-08 Thread Richard Leitner
Hi, currently I discovered the possibility that device file numbers of the input subsystem could go negative when the signed int border is passed. To fix this behaviour I sent a patch a few minutes ago. But as the subject says there is currently the (theoretical) possibility that the same input

[PATCH] input: avoid negative input device numbers

2014-10-08 Thread Richard Leitner
From: Richard Leitner richard.leit...@skidata.com Fix the format string for input device name generation to avoid negative device numbers when the id exceeds the maximum signed integer value. Signed-off-by: Richard Leitner richard.leit...@skidata.com --- drivers/input/input.c | 2 +- 1 file

Re: [PATCH] input: avoid negative input device numbers

2014-10-08 Thread Richard Leitner
On Wed, 8 Oct 2014 14:30:51 -0700 Dmitry Torokhov dmitry.torok...@gmail.com wrote: On Wed, Oct 08, 2014 at 02:25:38PM -0700, Dmitry Torokhov wrote: On Wed, Oct 08, 2014 at 10:42:45PM +0200, Richard Leitner wrote: From: Richard Leitner richard.leit...@skidata.com Fix the format string

[PATCH] serio: avoid negative serio device numbers

2014-10-08 Thread Richard Leitner
From: Richard Leitner richard.leit...@skidata.com Fix the format string for serio device name generation to avoid negative device numbers when the id exceeds the maximum signed integer value. Signed-off-by: Richard Leitner richard.leit...@skidata.com --- drivers/input/serio/serio.c | 4 ++-- 1

[PATCH] usb: gadget: serial: remove PREFIX macro

2014-08-21 Thread Richard Leitner
have ignored this. Due to the fact the usage of this PREFIX in all debug calls would have resulted in a hard to read/grep code it is removed completely. Signed-off-by: Richard Leitner --- changes from RFC to PATCH: - rebased on v3.17-rc1 - fixed some PARENTHESIS_ALIGNMENT

[PATCH v2] usb: gadget: serial: replace {V,}DBG macro with dev_{v,}dbg

2014-08-21 Thread Richard Leitner
Replace the VDBG and DBG macro with the kernels "proper" debug macros (dev_vdbg and dev_dbg) in f_acm.c, f_obex.c & f_serial.c Signed-off-by: Richard Leitner --- v2: - rebased on Linux v3.17-rc1 - fixed some PARENTHESIS_ALIGNMENT checkpatch.pl warnings --- drivers/usb/g

[PATCH v2] usb: gadget: serial: replace {V,}DBG macro with dev_{v,}dbg

2014-08-21 Thread Richard Leitner
Replace the VDBG and DBG macro with the kernels proper debug macros (dev_vdbg and dev_dbg) in f_acm.c, f_obex.c f_serial.c Signed-off-by: Richard Leitner richard.leit...@skidata.com --- v2: - rebased on Linux v3.17-rc1 - fixed some PARENTHESIS_ALIGNMENT checkpatch.pl warnings --- drivers

[PATCH] usb: gadget: serial: remove PREFIX macro

2014-08-21 Thread Richard Leitner
have ignored this. Due to the fact the usage of this PREFIX in all debug calls would have resulted in a hard to read/grep code it is removed completely. Signed-off-by: Richard Leitner richard.leit...@skidata.com --- changes from RFC to PATCH: - rebased on v3.17-rc1 - fixed some

Re: [RFC] usb: gadget: serial: remove PREFIX macro

2014-08-11 Thread Richard Leitner
Hi, On Mon, 11 Aug 2014 08:50:34 -0500 Felipe Balbi wrote: > On Mon, Aug 11, 2014 at 03:04:35PM +0200, Richard Leitner wrote: > > Hi, > > this patch was lying around for some time... > > are there any comments or objections on this? > > you realise we're still in the

Re: [RFC] usb: gadget: serial: remove PREFIX macro

2014-08-11 Thread Richard Leitner
Hi, this patch was lying around for some time... are there any comments or objections on this? regards, richard On Fri, 18 Jul 2014 11:39:46 +0200 Richard Leitner wrote: > Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with > the hardcoded ttyGS

Re: [RFC] usb: gadget: serial: remove PREFIX macro

2014-08-11 Thread Richard Leitner
Hi, this patch was lying around for some time... are there any comments or objections on this? regards, richard On Fri, 18 Jul 2014 11:39:46 +0200 Richard Leitner richard.leit...@skidata.com wrote: Remove the ttyGS PREFIX macro from u_serial.c and replace all occurences with the hardcoded

Re: [RFC] usb: gadget: serial: remove PREFIX macro

2014-08-11 Thread Richard Leitner
Hi, On Mon, 11 Aug 2014 08:50:34 -0500 Felipe Balbi ba...@ti.com wrote: On Mon, Aug 11, 2014 at 03:04:35PM +0200, Richard Leitner wrote: Hi, this patch was lying around for some time... are there any comments or objections on this? you realise we're still in the middle of the merge

[RFC] usb: gadget: serial: remove PREFIX macro

2014-07-18 Thread Richard Leitner
have ignored this because of the hardcoded strings. Due to the fact the usage of this PREFIX instead of the hardcoded strings in all debug calls would have resulted in a hard to read/grep code it is removed completely. Signed-off-by: Richard Leitner --- note: previous discussion was at https

[PATCH] usb: gadget: serial: replace {V,}DBG macro with dev_{v,}dbg

2014-07-18 Thread Richard Leitner
Replace the VDBG and DBG macro with the kernels "proper" debug macros (dev_vdbg and dev_dbg) in f_acm.c, f_obex.c & f_serial.c Signed-off-by: Richard Leitner --- drivers/usb/gadget/f_acm.c| 41 - drivers/usb/gadget/f_o

[PATCH] usb: gadget: serial: replace {V,}DBG macro with dev_{v,}dbg

2014-07-18 Thread Richard Leitner
Replace the VDBG and DBG macro with the kernels proper debug macros (dev_vdbg and dev_dbg) in f_acm.c, f_obex.c f_serial.c Signed-off-by: Richard Leitner richard.leit...@skidata.com --- drivers/usb/gadget/f_acm.c| 41 - drivers/usb/gadget/f_obex.c

[RFC] usb: gadget: serial: remove PREFIX macro

2014-07-18 Thread Richard Leitner
have ignored this because of the hardcoded strings. Due to the fact the usage of this PREFIX instead of the hardcoded strings in all debug calls would have resulted in a hard to read/grep code it is removed completely. Signed-off-by: Richard Leitner richard.leit...@skidata.com --- note: previous

Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-07-01 Thread Richard Leitner
On Tue, 1 Jul 2014 09:31:49 +0200 Richard Leitner wrote: > On Mon, 30 Jun 2014 07:45:43 -0700 > Greg Kroah-Hartman wrote: > > > > > > > From: Of Richard Leitner > > > > > > > Replaces all hardcoded ttyGS strings with the PREFIX macro. > >

Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-07-01 Thread Richard Leitner
On Mon, 30 Jun 2014 07:45:43 -0700 Greg Kroah-Hartman wrote: > > > > > From: Of Richard Leitner > > > > > > Replaces all hardcoded ttyGS strings with the PREFIX macro. > > > > > > Due to the fact the strings are spread over different source f

Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-07-01 Thread Richard Leitner
On Mon, 30 Jun 2014 07:45:43 -0700 Greg Kroah-Hartman gre...@linuxfoundation.org wrote: From: Of Richard Leitner Replaces all hardcoded ttyGS strings with the PREFIX macro. Due to the fact the strings are spread over different source files the PREFIX definition

Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-07-01 Thread Richard Leitner
On Tue, 1 Jul 2014 09:31:49 +0200 Richard Leitner richard.leit...@skidata.com wrote: On Mon, 30 Jun 2014 07:45:43 -0700 Greg Kroah-Hartman gre...@linuxfoundation.org wrote: From: Of Richard Leitner Replaces all hardcoded ttyGS strings with the PREFIX macro. Due to the fact

Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Hi, On Mon, 30 Jun 2014 09:08:01 + David Laight wrote: > > > From: Of Richard Leitner > > > > Replaces all hardcoded ttyGS strings with the PREFIX macro. > > > > Due to the fact the strings are spread over different source files the > > >

Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Hi, On Mon, 30 Jun 2014 08:41:18 + David Laight wrote: > From: Of Richard Leitner > > Replaces all hardcoded ttyGS strings with the PREFIX macro. > > Due to the fact the strings are spread over different source files the > > PREFIX definition is moved to u_serial.h >

[PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Replaces all hardcoded ttyGS strings with the PREFIX macro. Due to the fact the strings are spread over different source files the PREFIX definition is moved to u_serial.h Signed-off-by: Richard Leitner --- v2: removed checkpatch.pl resovling (will be in a separate patch) --- drivers/usb/gadget

Re: [PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Hello, thanks for your reply! On Fri, 27 Jun 2014 10:46:28 -0700 Greg Kroah-Hartman wrote: > On Fri, Jun 27, 2014 at 01:37:21PM +0200, Richard Leitner wrote: > > Replace all hardcoded ttyGS strings with the PREFIX macro. > > Why? Because IMHO if PREFIX is available it should be

Re: [PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Hello, thanks for your reply! On Fri, 27 Jun 2014 10:46:28 -0700 Greg Kroah-Hartman gre...@linuxfoundation.org wrote: On Fri, Jun 27, 2014 at 01:37:21PM +0200, Richard Leitner wrote: Replace all hardcoded ttyGS strings with the PREFIX macro. Why? Because IMHO if PREFIX is available

[PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Replaces all hardcoded ttyGS strings with the PREFIX macro. Due to the fact the strings are spread over different source files the PREFIX definition is moved to u_serial.h Signed-off-by: Richard Leitner richard.leit...@skidata.com --- v2: removed checkpatch.pl resovling (will be in a separate

Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Hi, On Mon, 30 Jun 2014 08:41:18 + David Laight david.lai...@aculab.com wrote: From: Of Richard Leitner Replaces all hardcoded ttyGS strings with the PREFIX macro. Due to the fact the strings are spread over different source files the PREFIX definition is moved to u_serial.h Lots

Re: [PATCHv2] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-30 Thread Richard Leitner
Hi, On Mon, 30 Jun 2014 09:08:01 + David Laight david.lai...@aculab.com wrote: From: Of Richard Leitner Replaces all hardcoded ttyGS strings with the PREFIX macro. Due to the fact the strings are spread over different source files the PREFIX definition is moved to u_serial.h

[PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-27 Thread Richard Leitner
Replace all hardcoded ttyGS strings with the PREFIX macro. Therefore the PREFIX definition is moved to u_serial.h. Furthermore the modified files are checkpatch.pl compliant now. Signed-off-by: Richard Leitner --- drivers/usb/gadget/f_acm.c| 49

[PATCH] usb: gadget: serial: replace hardcoded ttyGS with PREFIX

2014-06-27 Thread Richard Leitner
Replace all hardcoded ttyGS strings with the PREFIX macro. Therefore the PREFIX definition is moved to u_serial.h. Furthermore the modified files are checkpatch.pl compliant now. Signed-off-by: Richard Leitner richard.leit...@skidata.com --- drivers/usb/gadget/f_acm.c| 49

[PATCH v2] i2c: busses: ali1563: fix checkpatch.pl issues

2014-04-11 Thread Richard Leitner
Fixed most checkpatch.pl issues Signed-off-by: Richard Leitner Reviewed-by: Jean Delvare --- v2: applied changes recommended by Jean Delvare --- drivers/i2c/busses/i2c-ali1563.c | 82 ++-- 1 file changed, 45 insertions(+), 37 deletions(-) diff --git

[PATCH v2] i2c: busses: ali1563: fix checkpatch.pl issues

2014-04-11 Thread Richard Leitner
Fixed most checkpatch.pl issues Signed-off-by: Richard Leitner m...@g0hl1n.net Reviewed-by: Jean Delvare jdelv...@suse.de --- v2: applied changes recommended by Jean Delvare --- drivers/i2c/busses/i2c-ali1563.c | 82 ++-- 1 file changed, 45 insertions(+), 37

[PATCH] i2c: busses: ali1563: fix checkpatch.pl issues

2014-04-10 Thread Richard Leitner
Fixed most checkpatch.pl issues Signed-off-by: Richard Leitner --- drivers/i2c/busses/i2c-ali1563.c | 83 ++-- 1 file changed, 45 insertions(+), 38 deletions(-) diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c index 98a1c97

[PATCH] i2c: busses: ali1563: fix checkpatch.pl issues

2014-04-10 Thread Richard Leitner
Fixed most checkpatch.pl issues Signed-off-by: Richard Leitner m...@g0hl1n.net --- drivers/i2c/busses/i2c-ali1563.c | 83 ++-- 1 file changed, 45 insertions(+), 38 deletions(-) diff --git a/drivers/i2c/busses/i2c-ali1563.c b/drivers/i2c/busses/i2c-ali1563.c

[PATCH] staging: comedi: adl_pci9118: fix whitespace issues

2014-04-09 Thread Richard Leitner
Removed not needed spaces and fixed too long lines Signed-off-by: Richard Leitner --- drivers/staging/comedi/drivers/adl_pci9118.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118

[PATCH] staging: comedi: adl_pci9118: fix whitespace issues

2014-04-09 Thread Richard Leitner
Removed not needed spaces and fixed too long lines PS: this is an exercise to get into the "patch submitting workflow" Signed-off-by: Richard Leitner --- drivers/staging/comedi/drivers/adl_pci9118.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drive

[PATCH] staging: comedi: adl_pci9118: fix whitespace issues

2014-04-09 Thread Richard Leitner
Removed not needed spaces and fixed too long lines PS: this is an exercise to get into the patch submitting workflow Signed-off-by: Richard Leitner m...@g0hl1n.net --- drivers/staging/comedi/drivers/adl_pci9118.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH] staging: comedi: adl_pci9118: fix whitespace issues

2014-04-09 Thread Richard Leitner
Removed not needed spaces and fixed too long lines Signed-off-by: Richard Leitner m...@g0hl1n.net --- drivers/staging/comedi/drivers/adl_pci9118.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi

<    1   2   3   4