Re: Kernel 2.6.5 - Compaq Fibre Channel 64-bit/66Mhz HBA [PATCH]

2005-08-16 Thread Rolf Eike Beer
Bolke de Bruin wrote: Rolf Eike Beer wrote: If I can still help you then depends on your scheduling of this job. I'll try to do some hacking at the weekends. Does this mean you will not have time until October 5th or just time in the weekend until that time? For the moment my weekends are more

[PATCH 2.6.13-rc6] remove dead reset function from cpqfcTS driver

2005-08-16 Thread Rolf Eike Beer
cpqfcTS_reset() is never referenced from anywhere. By using the nonexistent constant SCSI_RESET_ERROR it causes just another unneeded compile error. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- a/drivers/scsi/cpqfcTSinit.c2005-08-13 09:34:20.0 +0200 +++ b/drivers/scsi

[PATCH 2.6.13-rc6] remove 2.4 compat code from cpqfcTS driver

2005-08-16 Thread Rolf Eike Beer
Remove compat code for Linux 2.4 and earlier. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- a/drivers/scsi/cpqfcTScontrol.c 2005-08-13 19:00:35.0 +0200 +++ b/drivers/scsi/cpqfcTScontrol.c 2005-08-14 11:02:09.0 +0200 @@ -28,8 +28,6 @@ Hewlitt Packard Manual Part

[PATCH 2.6.13-rc6] remove superfluos ioctls from cpqfcTS

2005-08-16 Thread Rolf Eike Beer
Remove ioctls to get PCI information and driver version. These information can be found via lspci or dmesg. Also remove two typedefs already commented out. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- a/drivers/scsi/cpqfcTSioctl.h 2005-08-07 20:18:56.0 +0200 +++ b/drivers

[PATCH 2.6.13-rc6] more whitespace cleanups for cpqfcTS

2005-08-16 Thread Rolf Eike Beer
More whitespace cleanups: -remove trailing whitespace -remove brakets around return statements -remove some double (or more) newlines Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- a/drivers/scsi/cpqfcTSi2c.c 2005-08-07 20:18:56.0 +0200 +++ b/drivers/scsi/cpqfcTSi2c.c 2005-08-14 15

[PATCH 2.6.13-rc6] MODULE_DEVICE_TABLE for cpqfcTS driver

2005-08-16 Thread Rolf Eike Beer
superfluos defines for device scanning. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- a/drivers/scsi/cpqfcTSstructs.h 2005-08-14 10:56:41.0 +0200 +++ b/drivers/scsi/cpqfcTSstructs.h 2005-08-14 10:57:32.0 +0200 @@ -95,12 +95,6 @@ #define DEV_NAME cpqfcTS -struct

Re: [PATCH 2.6.13-rc6] remove dead reset function from cpqfcTS driver

2005-08-16 Thread Rolf Eike Beer
Christoph Hellwig wrote: On Tue, Aug 16, 2005 at 11:11:06AM +0200, Rolf Eike Beer wrote: cpqfcTS_reset() is never referenced from anywhere. By using the nonexistent constant SCSI_RESET_ERROR it causes just another unneeded compile error. That was the old reset handler. Do you actually have

Re: [PATCH 2.6.13-rc6] MODULE_DEVICE_TABLE for cpqfcTS driver

2005-08-16 Thread Rolf Eike Beer
Jiri Slaby wrote: Rolf Eike Beer napsal(a): Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- a/drivers/scsi/cpqfcTSinit.c 2005-08-14 14:20:40.0 +0200 +++ b/drivers/scsi/cpqfcTSinit.c 2005-08-14 14:25:33.0 +0200 @@ -264,18 +264,14 @@ static void launch_FCworker_thread

[PATCH 2.6.13-rc6] remove 2.4 compat code from cpqfcTS driver, take 2

2005-08-16 Thread Rolf Eike Beer
Remove compat code for Linux 2.4 and earlier. Fixed bug in earlier version that caused compile error. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- a/drivers/scsi/cpqfcTScontrol.c 2005-08-13 19:00:35.0 +0200 +++ b/drivers/scsi/cpqfcTScontrol.c 2005-08-14 11:02:09.0

[PATCH 2.6.13-rc6] MODULE_DEVICE_TABLE for cpqfcTS driver, take 2

2005-08-16 Thread Rolf Eike Beer
superfluos defines for device scanning. Version 2: -use PCI_DEVICE makro (thanks to Jiri Slaby for pointing this out) -fix compile error (diffed wrong files) Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- a/drivers/scsi/cpqfcTSstructs.h 2005-08-14 10:56:41.0 +0200 +++ b/drivers/scsi

[PATCH 2.6.13-rc6] remove 2.4 compat code from cpqfcTS driver, take 3

2005-08-16 Thread Rolf Eike Beer
Remove compat code for Linux 2.4 and earlier. Version 2: Fixed bug in earlier version that caused compile error. Version 3: found bug in previous patch, changed this to apply cleanly. Sorry for the noise. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- a/drivers/scsi/cpqfcTScontrol.c

[PATCH 2.6.13-rc6] improve start/stop code for worker thread in cpqfcTS driver

2005-08-16 Thread Rolf Eike Beer
-by: Rolf Eike Beer [EMAIL PROTECTED] diff -aup linux-2.6.13-rc6/drivers/scsi/cpqfcTSinit.c linux-2.6.13-rc6-eike/drivers/scsi/cpqfcTSinit.c --- linux-2.6.13-rc6/drivers/scsi/cpqfcTSinit.c 2005-08-16 16:42:14.0 +0200 +++ linux-2.6.13-rc6-eike/drivers/scsi/cpqfcTSinit.c2005-08-16 16

Re: [PATCH 2.6.13-rc6] remove dead reset function from cpqfcTS driver

2005-08-16 Thread Rolf Eike Beer
Martin K. Petersen wrote: Rolf == Rolf Eike Beer [EMAIL PROTECTED] writes: Hey Rolf! I should go and use R. Eike Beer ;) Rolf There was a request on lkml last week for a working version of Rolf this driver. For the moment I try to clean this up a bit before Rolf doing some real work. I found 4

[PATCH 2.6.13-rc6] improve start/stop code for worker thread in cpqfcTS driver, take 2

2005-08-16 Thread Rolf Eike Beer
: remove that lock_kernel() stuff missed in the first version Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] diff -aup linux-2.6.13-rc6/drivers/scsi/cpqfcTSinit.c linux-2.6.13-rc6-eike/drivers/scsi/cpqfcTSinit.c --- linux-2.6.13-rc6/drivers/scsi/cpqfcTSinit.c 2005-08-16 16:42:14.0 +0200

[PATCH 2.6.13-rc6] improve start/stop code for worker thread in cpqfcTS driver, take 3

2005-08-16 Thread Rolf Eike Beer
(pointed out by Christoph Hellwig) Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] diff -aup linux-2.6.13-rc6/drivers/scsi/cpqfcTSinit.c linux-2.6.13-rc6-eike/drivers/scsi/cpqfcTSinit.c --- linux-2.6.13-rc6/drivers/scsi/cpqfcTSinit.c 2005-08-16 16:42:14.0 +0200 +++ linux-2.6.13-rc6-eike

Re: Kernel 2.6.5 - Compaq Fibre Channel 64-bit/66Mhz HBA [PATCH]

2005-08-11 Thread Rolf Eike Beer
Bolke de Bruin wrote: >So the basic question is. Does this controller work on kernel 2.6.5? Don't think about it. This thing is a mess. I tried to remove the #errors (which was rather simple) and replace them by kmalloc(). Of course then someone should care about ENOMEM case. One function had

Re: Kernel 2.6.5 - Compaq Fibre Channel 64-bit/66Mhz HBA

2005-08-11 Thread Rolf Eike Beer
Am Donnerstag, 11. August 2005 18:41 schrieben Sie: >>arrays allocated by the driver eat 2kB each, so a stack overflow is very >>likely. Even with 8kB stack it is still not impossible. Using the version >>from 2.6.5 will not be a very good idea I think, it's likely to crash your >>machine one day.

Re: Kernel 2.6.5 - Compaq Fibre Channel 64-bit/66Mhz HBA

2005-08-11 Thread Rolf Eike Beer
Bolke de Bruin wrote: >So the basic question is. Does this controller work on kernel 2.6.5? The problem is that the default stack size was reduced to 4kB. The local arrays allocated by the driver eat 2kB each, so a stack overflow is very likely. Even with 8kB stack it is still not impossible.

Re: Kernel 2.6.5 - Compaq Fibre Channel 64-bit/66Mhz HBA

2005-08-11 Thread Rolf Eike Beer
Bolke de Bruin wrote: So the basic question is. Does this controller work on kernel 2.6.5? The problem is that the default stack size was reduced to 4kB. The local arrays allocated by the driver eat 2kB each, so a stack overflow is very likely. Even with 8kB stack it is still not impossible.

Re: Kernel 2.6.5 - Compaq Fibre Channel 64-bit/66Mhz HBA

2005-08-11 Thread Rolf Eike Beer
Am Donnerstag, 11. August 2005 18:41 schrieben Sie: arrays allocated by the driver eat 2kB each, so a stack overflow is very likely. Even with 8kB stack it is still not impossible. Using the version from 2.6.5 will not be a very good idea I think, it's likely to crash your machine one day. :-( :

Re: Kernel 2.6.5 - Compaq Fibre Channel 64-bit/66Mhz HBA [PATCH]

2005-08-11 Thread Rolf Eike Beer
Bolke de Bruin wrote: So the basic question is. Does this controller work on kernel 2.6.5? Don't think about it. This thing is a mess. I tried to remove the #errors (which was rather simple) and replace them by kmalloc(). Of course then someone should care about ENOMEM case. One function had

[PATCH 2.6.13-rc5] rewrite drivers/scsi/cpqfcTScontrol.c::CpqTsGetSFQEntry

2005-08-09 Thread Rolf Eike Beer
names anyway While I'm at it, I fixed the coding style of this function. The rest of the file is is still horror, but this no excuse for not fixing this function. This shrinks the file by another 500 bytes and should not make any difference in function. Signed-off-by: Rolf Eike Beer <[EMAIL PROTEC

[PATCH 2.6.13-rc5] rewrite drivers/scsi/cpqfcTScontrol.c::CpqTsGetSFQEntry

2005-08-09 Thread Rolf Eike Beer
names anyway While I'm at it, I fixed the coding style of this function. The rest of the file is is still horror, but this no excuse for not fixing this function. This shrinks the file by another 500 bytes and should not make any difference in function. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED

[PATCH 2.6.13-rc6] Fix handling in parport_pc init code

2005-08-08 Thread Rolf Eike Beer
eft this the way it is if there is some magic I missed. The return code of this function is of no interest, I did not touch it for now because I don't wanted to change all the header files, I just changed it to always return 0. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- linux-2.6.13-rc

[PATCH 2.6.13-rc6] Fix handling in parport_pc init code

2005-08-08 Thread Rolf Eike Beer
this the way it is if there is some magic I missed. The return code of this function is of no interest, I did not touch it for now because I don't wanted to change all the header files, I just changed it to always return 0. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- linux-2.6.13-rc3

Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

2005-08-04 Thread Rolf Eike Beer
Dave Jones wrote: >On Thu, Aug 04, 2005 at 05:56:14PM +0200, Rolf Eike Beer wrote: > > Am Donnerstag, 4. August 2005 17:40 schrieb Dave Jones: > > >On Thu, Aug 04, 2005 at 11:38:30AM +0200, Rolf Eike Beer wrote: > > > > >+ulFibreFra

Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

2005-08-04 Thread Rolf Eike Beer
Am Donnerstag, 4. August 2005 17:40 schrieb Dave Jones: >On Thu, Aug 04, 2005 at 11:38:30AM +0200, Rolf Eike Beer wrote: > > >+ulFibreFrame = kmalloc((2048/4), GFP_KERNEL); > > > > The size bug was already found by Dave Jones. This never should be > > wr

Re: [PATCH 1/2] cpqfc: fix for "Using too much stach" in 2.6 kernel

2005-08-04 Thread Rolf Eike Beer
Saripalli, Venkata Ramanamurthy (STSD) wrote: >Patch 1 of 2 > >This patch fixes the "#error this is too much stack" in 2.6 kernel. >Using kmalloc to allocate memory to ulFibreFrame. Good idea. >Please consider this for inclusion Your patch is line-wrapped and can't be applied. Your second patch

Re: Documentation - how to apply patches for various trees

2005-08-04 Thread Rolf Eike Beer
Jesper Juhl wrote: >+The 2.6.x.y (-stable) and 2.6.x patches live at >+ ftp://ftp.kernel.org/pub/linux/kernel/v2.6/ >+ >+The -rc patches live at >+ ftp://ftp.kernel.org/pub/linux/kernel/v2.6/testing/ >+ >+The -git patches live at >+ ftp://ftp.kernel.org/pub/linux/kernel/v2.6/snapshots/ >+ >+The

Re: Documentation - how to apply patches for various trees

2005-08-04 Thread Rolf Eike Beer
Jesper Juhl wrote: +The 2.6.x.y (-stable) and 2.6.x patches live at + ftp://ftp.kernel.org/pub/linux/kernel/v2.6/ + +The -rc patches live at + ftp://ftp.kernel.org/pub/linux/kernel/v2.6/testing/ + +The -git patches live at + ftp://ftp.kernel.org/pub/linux/kernel/v2.6/snapshots/ + +The -mm kernels

Re: [PATCH 1/2] cpqfc: fix for Using too much stach in 2.6 kernel

2005-08-04 Thread Rolf Eike Beer
Saripalli, Venkata Ramanamurthy (STSD) wrote: Patch 1 of 2 This patch fixes the #error this is too much stack in 2.6 kernel. Using kmalloc to allocate memory to ulFibreFrame. Good idea. Please consider this for inclusion Your patch is line-wrapped and can't be applied. Your second patch is

Re: [PATCH 1/2] cpqfc: fix for Using too much stach in 2.6 kernel

2005-08-04 Thread Rolf Eike Beer
Am Donnerstag, 4. August 2005 17:40 schrieb Dave Jones: On Thu, Aug 04, 2005 at 11:38:30AM +0200, Rolf Eike Beer wrote: +ulFibreFrame = kmalloc((2048/4), GFP_KERNEL); The size bug was already found by Dave Jones. This never should be written this way (not your fault). The array should

Re: [PATCH 1/2] cpqfc: fix for Using too much stach in 2.6 kernel

2005-08-04 Thread Rolf Eike Beer
Dave Jones wrote: On Thu, Aug 04, 2005 at 05:56:14PM +0200, Rolf Eike Beer wrote: Am Donnerstag, 4. August 2005 17:40 schrieb Dave Jones: On Thu, Aug 04, 2005 at 11:38:30AM +0200, Rolf Eike Beer wrote: +ulFibreFrame = kmalloc((2048/4), GFP_KERNEL); The size bug was already

Re: Documentation - how to apply patches for various trees

2005-08-03 Thread Rolf Eike Beer
Jesper Juhl wrote: >+Where can I download the patches? Maybe it would be useful to once again mention that local mirrors should be used at least for stable releases and */testing/*. >+The 2.6.x kernels [...] >+# moving from 2.6.11 to 2.6.12 >+$ cd ~/linux-2.6.11 # change to

Re: Documentation - how to apply patches for various trees

2005-08-03 Thread Rolf Eike Beer
Jesper Juhl wrote: +Where can I download the patches? Maybe it would be useful to once again mention that local mirrors should be used at least for stable releases and */testing/*. +The 2.6.x kernels [...] +# moving from 2.6.11 to 2.6.12 +$ cd ~/linux-2.6.11 # change to

[PATCH 2.6.13-rc3-git4] watchdog: add missing 0x in alim1535_wdt.c

2005-07-22 Thread Rolf Eike Beer
Hi, usually the device IDs are given in hex. This one is a bit strange: it is without 0x in the first place and used with it some lines later. I suspect the first one to be the wrong. Patch attached. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- a/drivers/char/watchdog/alim1535

[PATCH 2.6.13-rc3-git4] watchdog: add missing 0x in alim1535_wdt.c

2005-07-22 Thread Rolf Eike Beer
Hi, usually the device IDs are given in hex. This one is a bit strange: it is without 0x in the first place and used with it some lines later. I suspect the first one to be the wrong. Patch attached. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- a/drivers/char/watchdog/alim1535_wdt.c

Re: [PATCH] remove unneeded indentation in drivers/char/watchdog/i8xx_tco.c

2005-07-21 Thread Rolf Eike Beer
Nils Faerber wrote: >Rolf Eike Beer schrieb: >> this patch changes a bit of indentation. Currently it is >> [...] >> Also some superfluous spaces are killed to match Codingstyle > >Don't know who added those strange things ;) >But looks OK to me to change it t

Re: [PATCH] Remove Comtrol mail address from MAINTAINERS [next 1 address]

2005-07-21 Thread Rolf Eike Beer
Am Donnerstag, 21. Juli 2005 01:43 schrieb Jiri Slaby: >Rolf Eike Beer wrotes: >>Send a patch, you know the addresses. > >kernel 2.6.13-rc3-git4 > >Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> > >--- a/MAINTAINERS 2005-07-21 01:13:32.0 +0200 >+++

Re: [PATCH] Remove Comtrol mail address from MAINTAINERS [next 1 address]

2005-07-21 Thread Rolf Eike Beer
Am Donnerstag, 21. Juli 2005 01:43 schrieb Jiri Slaby: Rolf Eike Beer wrotes: Send a patch, you know the addresses. kernel 2.6.13-rc3-git4 Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- a/MAINTAINERS 2005-07-21 01:13:32.0 +0200 +++ b/MAINTAINERS 2005-07-21 01:17:41.0

Re: [PATCH] remove unneeded indentation in drivers/char/watchdog/i8xx_tco.c

2005-07-21 Thread Rolf Eike Beer
Nils Faerber wrote: Rolf Eike Beer schrieb: this patch changes a bit of indentation. Currently it is [...] Also some superfluous spaces are killed to match Codingstyle Don't know who added those strange things ;) But looks OK to me to change it this way. So please go ahead and forward

Re: [PATCH] Remove Comtrol mail address from MAINTAINERS

2005-07-20 Thread Rolf Eike Beer
Am Mittwoch, 20. Juli 2005 14:12 schrieb Jiri Slaby: >Rolf Eike Beer napsal(a): >>Every Mail to this address produces a mail telling that they do no longer >>monitor this address and you should use their webinterface. >> >>"We are pleased to offer this powerf

Re: [PATCH] pci_find_device --> pci_get_device

2005-07-20 Thread Rolf Eike Beer
Jiri Slaby wrote: >Rolf Eike Beer napsal(a): >>Am Mittwoch, 20. Juli 2005 12:40 schrieb Jiri Slaby: >>>Rolf Eike Beer napsal(a): >>>>Your patch to arch/sparc64/kernel/ebus.c is broken, the removed and added >>>>parts do not match in behaviour. >>

Re: [PATCH] pci_find_device --> pci_get_device

2005-07-20 Thread Rolf Eike Beer
Am Mittwoch, 20. Juli 2005 12:40 schrieb Jiri Slaby: >Rolf Eike Beer napsal(a): >>Your patch to arch/sparc64/kernel/ebus.c is broken, the removed and added >>parts do not match in behaviour. > >I can't still see the difference. diff --git a/arch/sparc64/kernel/ebus.c b/arch/

[PATCH] remove unneeded indentation in drivers/char/watchdog/i8xx_tco.c

2005-07-20 Thread Rolf Eike Beer
Hi, this patch changes a bit of indentation. Currently it is if (i8xx_tcp_pci) { ... return 1; } return 0; Now it will be if (!i8xx_tcp_pci) return 0; ... return 1; Also some superfluous spaces are killed to match Codingstyle. Signed-off-by: Rolf Eike Beer <[EMAIL PROTEC

[PATCH] Remove Comtrol mail address from MAINTAINERS

2005-07-20 Thread Rolf Eike Beer
Every Mail to this address produces a mail telling that they do no longer monitor this address and you should use their webinterface. "We are pleased to offer this powerful replacement to standard email support." Some people just don't understand. Signed-off-by: Rolf Eike Be

[PATCH] Remove Comtrol mail address from MAINTAINERS

2005-07-20 Thread Rolf Eike Beer
Every Mail to this address produces a mail telling that they do no longer monitor this address and you should use their webinterface. We are pleased to offer this powerful replacement to standard email support. Some people just don't understand. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED

[PATCH] remove unneeded indentation in drivers/char/watchdog/i8xx_tco.c

2005-07-20 Thread Rolf Eike Beer
Hi, this patch changes a bit of indentation. Currently it is if (i8xx_tcp_pci) { ... return 1; } return 0; Now it will be if (!i8xx_tcp_pci) return 0; ... return 1; Also some superfluous spaces are killed to match Codingstyle. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED

Re: [PATCH] pci_find_device -- pci_get_device

2005-07-20 Thread Rolf Eike Beer
Am Mittwoch, 20. Juli 2005 12:40 schrieb Jiri Slaby: Rolf Eike Beer napsal(a): Your patch to arch/sparc64/kernel/ebus.c is broken, the removed and added parts do not match in behaviour. I can't still see the difference. diff --git a/arch/sparc64/kernel/ebus.c b/arch/sparc64/kernel/ebus.c

Re: [PATCH] pci_find_device -- pci_get_device

2005-07-20 Thread Rolf Eike Beer
Jiri Slaby wrote: Rolf Eike Beer napsal(a): Am Mittwoch, 20. Juli 2005 12:40 schrieb Jiri Slaby: Rolf Eike Beer napsal(a): Your patch to arch/sparc64/kernel/ebus.c is broken, the removed and added parts do not match in behaviour. I can't still see the difference. diff --git a/arch/sparc64/kernel

Re: [PATCH] Remove Comtrol mail address from MAINTAINERS

2005-07-20 Thread Rolf Eike Beer
Am Mittwoch, 20. Juli 2005 14:12 schrieb Jiri Slaby: Rolf Eike Beer napsal(a): Every Mail to this address produces a mail telling that they do no longer monitor this address and you should use their webinterface. We are pleased to offer this powerful replacement to standard email support. Some

Re: [PATCH] pci_find_device --> pci_get_device

2005-07-19 Thread Rolf Eike Beer
Am Dienstag, 19. Juli 2005 17:44 schrieb Jiri Slaby: >Rolf Eike Beer napsal(a): >>Jiri Slaby wrote: >>>Kernel version: 2.6.13-rc3-git4 >>> >>>* This patch removes from kernel tree pci_find_device and changes >>>it with pci_get_device. Next, it add

Re: [PATCH] pci_find_device --> pci_get_device

2005-07-19 Thread Rolf Eike Beer
Jiri Slaby wrote: >The patch is for mixed files from all over the tree. > >Kernel version: 2.6.13-rc3-git4 > >* This patch removes from kernel tree pci_find_device and changes >it with pci_get_device. Next, it adds pci_dev_put, to decrease reference >count of the variable. >* Next, there are some

Re: [PATCH] pci_find_device -- pci_get_device

2005-07-19 Thread Rolf Eike Beer
Jiri Slaby wrote: The patch is for mixed files from all over the tree. Kernel version: 2.6.13-rc3-git4 * This patch removes from kernel tree pci_find_device and changes it with pci_get_device. Next, it adds pci_dev_put, to decrease reference count of the variable. * Next, there are some (about

Re: [PATCH] pci_find_device -- pci_get_device

2005-07-19 Thread Rolf Eike Beer
Am Dienstag, 19. Juli 2005 17:44 schrieb Jiri Slaby: Rolf Eike Beer napsal(a): Jiri Slaby wrote: Kernel version: 2.6.13-rc3-git4 * This patch removes from kernel tree pci_find_device and changes it with pci_get_device. Next, it adds pci_dev_put, to decrease reference count of the variable. * Next

Re: [PATCH 3/6]init call cleanup

2005-04-12 Thread Rolf Eike Beer
Li Shaohua wrote: > Trival patch for CPU hotplug. In CPU identify part, only did cleaup for > intel CPUs. Need do for other CPUs if they support S3 SMP. > > @@ -405,7 +405,7 @@ void __init init_bsp_APIC(void) > apic_write_around(APIC_LVT1, value); > } > > -void __init setup_local_APIC

Re: [PATCH 3/6]init call cleanup

2005-04-12 Thread Rolf Eike Beer
Li Shaohua wrote: Trival patch for CPU hotplug. In CPU identify part, only did cleaup for intel CPUs. Need do for other CPUs if they support S3 SMP. @@ -405,7 +405,7 @@ void __init init_bsp_APIC(void) apic_write_around(APIC_LVT1, value); } -void __init setup_local_APIC (void)

Re: [PATCH] PCI Hotplug: remove code duplication in drivers/pci/hotplug/ibmphp_pci.c

2005-04-08 Thread Rolf Eike Beer
Greg KH wrote: > On Sat, Apr 02, 2005 at 02:20:11PM +0200, Rolf Eike Beer wrote: > > Greg KH wrote: > > > ChangeSet 1.2181.16.9, 2005/03/17 13:54:33-08:00, > > > [EMAIL PROTECTED] > > > > > > [PATCH] PCI Hotplug: remove code duplicat

Re: [PATCH] PCI Hotplug: remove code duplication in drivers/pci/hotplug/ibmphp_pci.c

2005-04-08 Thread Rolf Eike Beer
Greg KH wrote: On Sat, Apr 02, 2005 at 02:20:11PM +0200, Rolf Eike Beer wrote: Greg KH wrote: ChangeSet 1.2181.16.9, 2005/03/17 13:54:33-08:00, [EMAIL PROTECTED] [PATCH] PCI Hotplug: remove code duplication in drivers/pci/hotplug/ibmphp_pci.c This patch removes some code

Re: [PATCH] PCI Hotplug: remove code duplication in drivers/pci/hotplug/ibmphp_pci.c

2005-04-02 Thread Rolf Eike Beer
Greg KH wrote: > ChangeSet 1.2181.16.9, 2005/03/17 13:54:33-08:00, [EMAIL PROTECTED] > > [PATCH] PCI Hotplug: remove code duplication in > drivers/pci/hotplug/ibmphp_pci.c > > This patch removes some code duplication where if and else have the > same code at the beginning and the end of the

Re: [PATCH] PCI Hotplug: remove code duplication in drivers/pci/hotplug/ibmphp_pci.c

2005-04-02 Thread Rolf Eike Beer
Greg KH wrote: ChangeSet 1.2181.16.9, 2005/03/17 13:54:33-08:00, [EMAIL PROTECTED] [PATCH] PCI Hotplug: remove code duplication in drivers/pci/hotplug/ibmphp_pci.c This patch removes some code duplication where if and else have the same code at the beginning and the end of the branch.

Re: [PATCH] typo fix in Documentation/eisa.txt

2005-03-27 Thread Rolf Eike Beer
Typo fixes. Thanks to Randy Dunlap and Jean Delvare. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- linux-2.6.11/Documentation/eisa.txt 2005-03-02 08:38:12.0 +0100 +++ linux-2.6.12-rc1/Documentation/eisa.txt 2005-03-27 21:58:04.0 +0200 @@ -171,9

Re: [PATCH] typo fix in Documentation/eisa.txt

2005-03-27 Thread Rolf Eike Beer
Jean Delvare wrote: > Hi Eike, > > > Trivial typo fix. > > (...) > > Force the probing code to probe EISA slots even when it cannot find an > > -EISA compliant mainboard (nothing appears on slot 0). Defaultd to 0 > > +EISA compliant mainboard (nothing appears on slot 0). Default to 0 > > (don't

[PATCH] typo fix in drivers/scsi/sata_svw.c

2005-03-27 Thread Rolf Eike Beer
Add missing brace. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- linux-2.6.11/drivers/scsi/sata_svw.c2005-03-21 11:41:58.0 +0100 +++ linux-2.6.12-rc1/drivers/scsi/sata_svw.c2005-03-27 15:50:38.0 +0200 @@ -395,7 +395,7 @@ /* Clear a mag

[PATCH] shrink drivers/pci/proc.c::pci_seq_start()

2005-03-27 Thread Rolf Eike Beer
Hi, this patch shrinks pci_seq_start by using for_each_pci_dev() macro instead of explicitely using a loop and avoiding a goto. Eike Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- linux-2.6.11/drivers/pci/proc.c 2005-03-21 11:41:56.0 +0100 +++ linux-2.6.12-rc1/drive

[PATCH] s/driverfs/sysfs/ in include/linux/cpu.h and net/sunrpc/rpc_pipe.c

2005-03-27 Thread Rolf Eike Beer
driverfs has been renamed to sysfs long time ago. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- linux-2.6.10/include/linux/cpu.h2005-01-01 17:55:38.0 +0100 +++ linux-2.6.10/include/linux/cpu.h.fixed 2005-01-07 13:55:36.167681848 +0100 @@ -8,7 +8,7 @@ * Basic ha

[PATCH] typo fix in Documentation/eisa.txt

2005-03-27 Thread Rolf Eike Beer
Trivial typo fix. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- linux-2.6.0-test9/Documentation/eisa.txt2003-10-25 20:43:59.0 +0200 +++ linux-2.6.0-test9-eike/Documentation/eisa.txt 2003-11-12 09:29:47.0 +0100 @@ -171,7 +171,7 @@ virtual_root.force

[PATCH] Kill stupid warning when compiling riocmd.c

2005-03-27 Thread Rolf Eike Beer
Hi, my gcc complains about RIOCommandRup(), this is because this one has no forward declaration and uses old style parameter declaration. This patch changes all function headers in riocmd.c to use their parameter types in function header directly. Please apply, Eike Signed-off-by: Rolf Eike

[PATCH] Kill stupid warning when compiling riocmd.c

2005-03-27 Thread Rolf Eike Beer
Hi, my gcc complains about RIOCommandRup(), this is because this one has no forward declaration and uses old style parameter declaration. This patch changes all function headers in riocmd.c to use their parameter types in function header directly. Please apply, Eike Signed-off-by: Rolf Eike

[PATCH] typo fix in Documentation/eisa.txt

2005-03-27 Thread Rolf Eike Beer
Trivial typo fix. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- linux-2.6.0-test9/Documentation/eisa.txt2003-10-25 20:43:59.0 +0200 +++ linux-2.6.0-test9-eike/Documentation/eisa.txt 2003-11-12 09:29:47.0 +0100 @@ -171,7 +171,7 @@ virtual_root.force_probe

[PATCH] s/driverfs/sysfs/ in include/linux/cpu.h and net/sunrpc/rpc_pipe.c

2005-03-27 Thread Rolf Eike Beer
driverfs has been renamed to sysfs long time ago. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- linux-2.6.10/include/linux/cpu.h2005-01-01 17:55:38.0 +0100 +++ linux-2.6.10/include/linux/cpu.h.fixed 2005-01-07 13:55:36.167681848 +0100 @@ -8,7 +8,7 @@ * Basic handling

[PATCH] shrink drivers/pci/proc.c::pci_seq_start()

2005-03-27 Thread Rolf Eike Beer
Hi, this patch shrinks pci_seq_start by using for_each_pci_dev() macro instead of explicitely using a loop and avoiding a goto. Eike Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- linux-2.6.11/drivers/pci/proc.c 2005-03-21 11:41:56.0 +0100 +++ linux-2.6.12-rc1/drivers/pci

[PATCH] typo fix in drivers/scsi/sata_svw.c

2005-03-27 Thread Rolf Eike Beer
Add missing brace. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- linux-2.6.11/drivers/scsi/sata_svw.c2005-03-21 11:41:58.0 +0100 +++ linux-2.6.12-rc1/drivers/scsi/sata_svw.c2005-03-27 15:50:38.0 +0200 @@ -395,7 +395,7 @@ /* Clear a magic bit in SCR1

Re: [PATCH] typo fix in Documentation/eisa.txt

2005-03-27 Thread Rolf Eike Beer
Jean Delvare wrote: Hi Eike, Trivial typo fix. (...) Force the probing code to probe EISA slots even when it cannot find an -EISA compliant mainboard (nothing appears on slot 0). Defaultd to 0 +EISA compliant mainboard (nothing appears on slot 0). Default to 0 (don't force), and

Re: [PATCH] typo fix in Documentation/eisa.txt

2005-03-27 Thread Rolf Eike Beer
Typo fixes. Thanks to Randy Dunlap and Jean Delvare. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- linux-2.6.11/Documentation/eisa.txt 2005-03-02 08:38:12.0 +0100 +++ linux-2.6.12-rc1/Documentation/eisa.txt 2005-03-27 21:58:04.0 +0200 @@ -171,9 +171,9

Re: PCI: remove pci_find_device usage from pci sysfs code.

2005-03-25 Thread Rolf Eike Beer
Greg KH wrote: > On Sun, Mar 20, 2005 at 03:53:58PM +0100, Rolf Eike Beer wrote: > > Greg KH wrote: > > > ChangeSet 1.1998.11.23, 2005/02/25 08:26:11-08:00, [EMAIL PROTECTED] > > > > > > PCI: remove pci_find_device usage from pci sysfs code. > > Any reaso

Re: drivers/pci/hotplug/cpqphp_ctrl.c: board_replaced: dead code

2005-03-25 Thread Rolf Eike Beer
in the whole function. If this is not a bug than this patch removes all the dead code. Eike Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- linux-2.6.11/drivers/pci/hotplug/cpqphp_ctrl.c 2005-03-02 08:37:55.0 +0100 +++ linux-2.6.12-rc1/drivers/pci/hotplug/cpqphp_ctrl.c 2

Re: drivers/pci/hotplug/cpqphp_ctrl.c: board_replaced: dead code

2005-03-25 Thread Rolf Eike Beer
all the dead code. Eike Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- linux-2.6.11/drivers/pci/hotplug/cpqphp_ctrl.c 2005-03-02 08:37:55.0 +0100 +++ linux-2.6.12-rc1/drivers/pci/hotplug/cpqphp_ctrl.c 2005-03-24 19:01:23.0 +0100 @@ -1284,7 +1284,6 @@ static u32

Re: PCI: remove pci_find_device usage from pci sysfs code.

2005-03-25 Thread Rolf Eike Beer
Greg KH wrote: On Sun, Mar 20, 2005 at 03:53:58PM +0100, Rolf Eike Beer wrote: Greg KH wrote: ChangeSet 1.1998.11.23, 2005/02/25 08:26:11-08:00, [EMAIL PROTECTED] PCI: remove pci_find_device usage from pci sysfs code. Any reasons why you are not using for_each_pci_dev(pdev) here

Re: PCI: remove pci_find_device usage from pci sysfs code.

2005-03-20 Thread Rolf Eike Beer
Greg KH wrote: > ChangeSet 1.1998.11.23, 2005/02/25 08:26:11-08:00, [EMAIL PROTECTED] > > PCI: remove pci_find_device usage from pci sysfs code. > diff -Nru a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c > --- a/drivers/pci/pci-sysfs.c 2005-03-04 12:41:33 -08:00 > +++

Re: PCI: remove pci_find_device usage from pci sysfs code.

2005-03-20 Thread Rolf Eike Beer
Greg KH wrote: ChangeSet 1.1998.11.23, 2005/02/25 08:26:11-08:00, [EMAIL PROTECTED] PCI: remove pci_find_device usage from pci sysfs code. diff -Nru a/drivers/pci/pci-sysfs.c b/drivers/pci/pci-sysfs.c --- a/drivers/pci/pci-sysfs.c 2005-03-04 12:41:33 -08:00 +++ b/drivers/pci/pci-sysfs.c

[PATCH] make ACPI_BLACKLIST_YEAR depend on ACPI

2005-02-14 Thread Rolf Eike Beer
Hi, this oneliner fixes the situation that I can enter a year to blacklist ACPI devices if ACPI is completely disabled. Signed-off-by: Rolf Eike Beer <[EMAIL PROTECTED]> --- linux-2.6.11-rc3/drivers/acpi/Kconfig 2005-02-07 21:12:45.0 +0100 +++ linux-2.6.11-rc3/driver

[PATCH] make ACPI_BLACKLIST_YEAR depend on ACPI

2005-02-14 Thread Rolf Eike Beer
Hi, this oneliner fixes the situation that I can enter a year to blacklist ACPI devices if ACPI is completely disabled. Signed-off-by: Rolf Eike Beer [EMAIL PROTECTED] --- linux-2.6.11-rc3/drivers/acpi/Kconfig 2005-02-07 21:12:45.0 +0100 +++ linux-2.6.11-rc3/drivers/acpi

<    1   2   3   4