Hi Sergey,
Paolo Abeni had sent a patch:
https://www.mail-archive.com/netdev@vger.kernel.org/msg179192.html
Regards,
Rami Rosen
-Original Message-
From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
Behalf Of Sergey Senozhatsky
Sent: Wednesday, July 26, 2017
Hi Sergey,
Paolo Abeni had sent a patch:
https://www.mail-archive.com/netdev@vger.kernel.org/msg179192.html
Regards,
Rami Rosen
-Original Message-
From: netdev-ow...@vger.kernel.org [mailto:netdev-ow...@vger.kernel.org] On
Behalf Of Sergey Senozhatsky
Sent: Wednesday, July 26, 2017
Hi, Alexander,
>This link seems to be broken.
Seems that it should be:
https://www.kernel.org/pub/linux/utils/net/bridge-utils/bridge-utils-1.6.tar.gz
Instead of:
>
> http://www.kernel.org/pub/linux/utils/net/bridge-utils/bridge-utils.1.6.tar.gz
Regards,
Rami Rosen
Intel Corporation
Hi, Alexander,
>This link seems to be broken.
Seems that it should be:
https://www.kernel.org/pub/linux/utils/net/bridge-utils/bridge-utils-1.6.tar.gz
Instead of:
>
> http://www.kernel.org/pub/linux/utils/net/bridge-utils/bridge-utils.1.6.tar.gz
Regards,
Rami Rosen
Intel Corporation
Hi, Amir,
>This patch is the communication with the FW.
>The network functionality is added in the next patches in the series
>and with it, more messages from FW.
>Indeed this function always returns true in this patch,
>but while writing it, I predicted that the network functionality will
Hi, Amir,
>This patch is the communication with the FW.
>The network functionality is added in the next patches in the series
>and with it, more messages from FW.
>Indeed this function always returns true in this patch,
>but while writing it, I predicted that the network functionality will
Hi Amir,
Here are my 2 cents:
This method always returns true, should be void (unless you will change
PDF_ERROR_NOTIFICATION or other pdf values to return false), and likewise its
invocation should not check return value.
> +static bool nhi_msg_from_icm_analysis(struct tbt_nhi_ctxt
Hi Amir,
Here are my 2 cents:
This method always returns true, should be void (unless you will change
PDF_ERROR_NOTIFICATION or other pdf values to return false), and likewise its
invocation should not check return value.
> +static bool nhi_msg_from_icm_analysis(struct tbt_nhi_ctxt
Hi all,
A very limited review below.
+
+ /* get capabilities of particular feature */
+ ENA_ADMIN_GET_FEATURE = 8,
Instead /* get capabilities SHOULD BE: /* set capabilities .
+
+ /* get capabilities of particular feature */
+ ENA_ADMIN_SET_FEATURE = 9,
+
..
Hi all,
A very limited review below.
+
+ /* get capabilities of particular feature */
+ ENA_ADMIN_GET_FEATURE = 8,
Instead /* get capabilities SHOULD BE: /* set capabilities .
+
+ /* get capabilities of particular feature */
+ ENA_ADMIN_SET_FEATURE = 9,
+
..
Hi, Netanel,
+into 5 levels and assignes interrupt delay value to each level.
Should be: assigns
+The ENA device AQ and AENQ are allocated on probe and freed ontermination.
Should be: on termination.
+ /* commit previously loaded firmare */
Should be: firmware
+static int
Hi, Netanel,
+into 5 levels and assignes interrupt delay value to each level.
Should be: assigns
+The ENA device AQ and AENQ are allocated on probe and freed ontermination.
Should be: on termination.
+ /* commit previously loaded firmare */
Should be: firmware
+static int
Hi,
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -604,11 +604,11 @@ static inline struct cgroup *sock_cgroup_ptr(struct
sock_cgroup_data *skcd)
#endif
}
In this occasion, seems that maybe something else is also missing:
Shouldn't it be hereafter : +#else /*
Hi,
--- a/include/linux/cgroup.h
+++ b/include/linux/cgroup.h
@@ -604,11 +604,11 @@ static inline struct cgroup *sock_cgroup_ptr(struct
sock_cgroup_data *skcd)
#endif
}
In this occasion, seems that maybe something else is also missing:
Shouldn't it be hereafter : +#else /*
Hi, all,
Regarding preferring using netlink sockets versus ethtool IOCTLs for setting
kernel network attributes from userspace, I fully agree with Marco. The netlink
API is much more structured and
much more geared towards this type of operation, than the IOCTL-based ethtool.
Regards,
Rami
Hi, all,
Regarding preferring using netlink sockets versus ethtool IOCTLs for setting
kernel network attributes from userspace, I fully agree with Marco. The netlink
API is much more structured and
much more geared towards this type of operation, than the IOCTL-based ethtool.
Regards,
Rami
16 matches
Mail list logo
