Re: [PATCH v3 2/4] KVM: X86: Fix loss of exception which has not yet injected

On Wed, Aug 23, 2017 at 10:21 PM, Wanpeng Li wrote: > From: Wanpeng Li > > vmx_complete_interrupts() assumes that the exception is always injected, > so it would be dropped by kvm_clear_exception_queue(). This patch separates > exception.pending from exception.injected, exception.inject

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Fri, Dec 22, 2017 at 02:53:42PM -0800, Dan Williams wrote: > On Thu, Dec 21, 2017 at 12:31 PM, Brice Goglin <brice.gog...@gmail.com> wrote: > > Le 20/12/2017 à 23:41, Ross Zwisler a écrit : > [..] > > Hello > > > > I can confirm that HPC runtimes are going to

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Fri, Dec 22, 2017 at 02:53:42PM -0800, Dan Williams wrote: > On Thu, Dec 21, 2017 at 12:31 PM, Brice Goglin wrote: > > Le 20/12/2017 à 23:41, Ross Zwisler a écrit : > [..] > > Hello > > > > I can confirm that HPC runtimes are going to use these patches (at least &

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Fri, Dec 22, 2017 at 08:39:41AM +0530, Anshuman Khandual wrote: > On 12/14/2017 07:40 AM, Ross Zwisler wrote: <> > > We solve this issue by providing userspace with performance information on > > individual memory ranges. This performance information is exposed via > &g

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Fri, Dec 22, 2017 at 08:39:41AM +0530, Anshuman Khandual wrote: > On 12/14/2017 07:40 AM, Ross Zwisler wrote: <> > > We solve this issue by providing userspace with performance information on > > individual memory ranges. This performance information is exposed via > &g

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Fri, Dec 22, 2017 at 08:39:41AM +0530, Anshuman Khandual wrote: > On 12/14/2017 07:40 AM, Ross Zwisler wrote: > > Quick Summary > > > > Platforms exist today which have multiple types of memory attached to a > > single CPU. These disparate memory range

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Fri, Dec 22, 2017 at 08:39:41AM +0530, Anshuman Khandual wrote: > On 12/14/2017 07:40 AM, Ross Zwisler wrote: > > Quick Summary > > > > Platforms exist today which have multiple types of memory attached to a > > single CPU. These disparate memory range

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Thu, Dec 21, 2017 at 01:41:15AM +, Elliott, Robert (Persistent Memory) wrote: > > > > -Original Message- > > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of > > Ross Zwisler > ... > > > > On Wed, Dec 20, 2017 at

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Thu, Dec 21, 2017 at 01:41:15AM +, Elliott, Robert (Persistent Memory) wrote: > > > > -Original Message- > > From: Linux-nvdimm [mailto:linux-nvdimm-boun...@lists.01.org] On Behalf Of > > Ross Zwisler > ... > > > > On Wed, Dec 20, 2017 at

Re: [PATCH 2/2] Introduce __cond_lock_err

On Thu, Dec 21, 2017 at 02:00:16PM -0800, Josh Triplett wrote: > On Thu, Dec 21, 2017 at 02:48:10PM -0700, Ross Zwisler wrote: > > On Tue, Dec 19, 2017 at 08:58:23AM -0800, Matthew Wilcox wrote: > > > From: Matthew Wilcox <mawil...@microsoft.com> > > > &g

Re: [PATCH 2/2] Introduce __cond_lock_err

On Thu, Dec 21, 2017 at 02:00:16PM -0800, Josh Triplett wrote: > On Thu, Dec 21, 2017 at 02:48:10PM -0700, Ross Zwisler wrote: > > On Tue, Dec 19, 2017 at 08:58:23AM -0800, Matthew Wilcox wrote: > > > From: Matthew Wilcox > > > > > > The __cond_lock macro

Re: [PATCH 2/2] Introduce __cond_lock_err

On Tue, Dec 19, 2017 at 08:58:23AM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > The __cond_lock macro expects the function to return 'true' if the lock > was acquired and 'false' if it wasn't. We have another common calling > convention in the kernel, which is

Re: [PATCH 2/2] Introduce __cond_lock_err

On Tue, Dec 19, 2017 at 08:58:23AM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > The __cond_lock macro expects the function to return 'true' if the lock > was acquired and 'false' if it wasn't. We have another common calling > convention in the kernel, which is returning 0 on success

Re: [PATCH 1/2] mm: Make follow_pte_pmd an inline

On Tue, Dec 19, 2017 at 08:58:22AM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > The one user of follow_pte_pmd (dax) emits a sparse warning because > it doesn't know that follow_pte_pmd conditionally returns with the > pte/pmd locked. The required annotation

Re: [PATCH 1/2] mm: Make follow_pte_pmd an inline

On Tue, Dec 19, 2017 at 08:58:22AM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > The one user of follow_pte_pmd (dax) emits a sparse warning because > it doesn't know that follow_pte_pmd conditionally returns with the > pte/pmd locked. The required annotation is already there; it's

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Wed, Dec 20, 2017 at 02:29:56PM -0800, Dan Williams wrote: > On Wed, Dec 20, 2017 at 1:24 PM, Ross Zwisler > <ross.zwis...@linux.intel.com> wrote: > > On Wed, Dec 20, 2017 at 01:16:49PM -0800, Matthew Wilcox wrote: > >> On Wed, Dec 20, 2017 at 12:22:21PM -0800, Dave

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Wed, Dec 20, 2017 at 02:29:56PM -0800, Dan Williams wrote: > On Wed, Dec 20, 2017 at 1:24 PM, Ross Zwisler > wrote: > > On Wed, Dec 20, 2017 at 01:16:49PM -0800, Matthew Wilcox wrote: > >> On Wed, Dec 20, 2017 at 12:22:21PM -0800, Dave Hansen wrote: > >> >

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Wed, Dec 20, 2017 at 01:16:49PM -0800, Matthew Wilcox wrote: > On Wed, Dec 20, 2017 at 12:22:21PM -0800, Dave Hansen wrote: > > On 12/20/2017 10:19 AM, Matthew Wilcox wrote: > > > I don't know what the right interface is, but my laptop has a set of > > > /sys/devices/system/memory/memoryN/

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Wed, Dec 20, 2017 at 01:16:49PM -0800, Matthew Wilcox wrote: > On Wed, Dec 20, 2017 at 12:22:21PM -0800, Dave Hansen wrote: > > On 12/20/2017 10:19 AM, Matthew Wilcox wrote: > > > I don't know what the right interface is, but my laptop has a set of > > > /sys/devices/system/memory/memoryN/

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Wed, Dec 20, 2017 at 10:19:37AM -0800, Matthew Wilcox wrote: > On Mon, Dec 18, 2017 at 01:35:47PM -0700, Ross Zwisler wrote: > > What I'm hoping to do with this series is to just provide a sysfs > > representation of the HMAT so that applications can know which NUMA node

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Wed, Dec 20, 2017 at 10:19:37AM -0800, Matthew Wilcox wrote: > On Mon, Dec 18, 2017 at 01:35:47PM -0700, Ross Zwisler wrote: > > What I'm hoping to do with this series is to just provide a sysfs > > representation of the HMAT so that applications can know which NUMA node

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Mon, Dec 18, 2017 at 01:35:47PM -0700, Ross Zwisler wrote: > On Thu, Dec 14, 2017 at 02:00:32PM +0100, Michal Hocko wrote: <> > > What is the testing procedure? How can I setup qemu to simlate such HW? > > Well, the QEMU table simulation is gross, so I'd rather not g

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Mon, Dec 18, 2017 at 01:35:47PM -0700, Ross Zwisler wrote: > On Thu, Dec 14, 2017 at 02:00:32PM +0100, Michal Hocko wrote: <> > > What is the testing procedure? How can I setup qemu to simlate such HW? > > Well, the QEMU table simulation is gross, so I'd rather not g

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Thu, Dec 14, 2017 at 02:00:32PM +0100, Michal Hocko wrote: > [CC linix-api] Oh, thanks. I'll add them to my CC list for sysfs related changes in the future. > On Wed 13-12-17 19:10:16, Ross Zwisler wrote: > > This is the third revision of my patches adding a sysfs re

Re: [PATCH v3 0/3] create sysfs representation of ACPI HMAT

On Thu, Dec 14, 2017 at 02:00:32PM +0100, Michal Hocko wrote: > [CC linix-api] Oh, thanks. I'll add them to my CC list for sysfs related changes in the future. > On Wed 13-12-17 19:10:16, Ross Zwisler wrote: > > This is the third revision of my patches adding a sysfs re

Re: [PATCH v3 2/3] hmat: add heterogeneous memory sysfs support

On Fri, Dec 15, 2017 at 01:52:03AM +0100, Rafael J. Wysocki wrote: <> > > diff --git a/drivers/acpi/hmat/core.c b/drivers/acpi/hmat/core.c > > new file mode 100644 > > index ..61b90dadf84b > > --- /dev/null > > +++ b/drivers/acpi/hmat/core.c > > @@ -0,0 +1,536 @@ > > +/* > > + *

Re: [PATCH v3 2/3] hmat: add heterogeneous memory sysfs support

On Fri, Dec 15, 2017 at 01:52:03AM +0100, Rafael J. Wysocki wrote: <> > > diff --git a/drivers/acpi/hmat/core.c b/drivers/acpi/hmat/core.c > > new file mode 100644 > > index ..61b90dadf84b > > --- /dev/null > > +++ b/drivers/acpi/hmat/core.c > > @@ -0,0 +1,536 @@ > > +/* > > + *

[PATCH v3 1/3] acpi: HMAT support in acpi_parse_entries_array()

they have subtable headers of type struct acpi_hmat_structure which has a 2 byte type and a 4 byte length. Enhance the subtable parsing in acpi_parse_entries_array() so that it can handle these new HMAT subtables. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- drivers/acpi/ta

[PATCH v3 1/3] acpi: HMAT support in acpi_parse_entries_array()

they have subtable headers of type struct acpi_hmat_structure which has a 2 byte type and a 4 byte length. Enhance the subtable parsing in acpi_parse_entries_array() so that it can handle these new HMAT subtables. Signed-off-by: Ross Zwisler --- drivers/acpi/tables.c | 52

[PATCH v3 2/3] hmat: add heterogeneous memory sysfs support

── node2 -> ../../node/node2 ├── power │   ├── async │   ... ├── subsystem -> ../../../../bus/hmat └── uevent Users can discover information about the memory owned by this memory target by following the node2 symlink and looking at meminfo, vmstat and at the memory* memory section symlin

[PATCH v3 2/3] hmat: add heterogeneous memory sysfs support

── node2 -> ../../node/node2 ├── power │   ├── async │   ... ├── subsystem -> ../../../../bus/hmat └── uevent Users can discover information about the memory owned by this memory target by following the node2 symlink and looking at meminfo, vmstat and at the memory* memory section symlinks. Signed-

[PATCH v3 3/3] hmat: add performance attributes

regardless of how we nest them in a directory hierarchy. By only representing performance information for local (initiator,target) pairings, we reduce the number of sysfs entries to O(num_targets). Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- dri

[PATCH v3 3/3] hmat: add performance attributes

regardless of how we nest them in a directory hierarchy. By only representing performance information for local (initiator,target) pairings, we reduce the number of sysfs entries to O(num_targets). Signed-off-by: Ross Zwisler --- drivers/acpi/hmat/Makefile | 2 +- drivers/acpi/hmat/c

[PATCH v3 0/3] create sysfs representation of ACPI HMAT

d be present in very large systems, so in this series we only surface performance information for local (initiator,target) pairings. The changelog for patch 5 discusses this in detail. Ross Zwisler (3): acpi: HMAT support in acpi_parse_entries_array() hmat: add heterogeneous memory sysfs sup

[PATCH v3 0/3] create sysfs representation of ACPI HMAT

d be present in very large systems, so in this series we only surface performance information for local (initiator,target) pairings. The changelog for patch 5 discusses this in detail. Ross Zwisler (3): acpi: HMAT support in acpi_parse_entries_array() hmat: add heterogeneous memory sysfs sup

Re: [PATCH v4 00/73] XArray version 4

On Tue, Dec 05, 2017 at 04:40:46PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > I looked through some notes and decided this was version 4 of the XArray. > Last posted two weeks ago, this version includes a *lot* of changes. > I'd like to thank Dave Chinner for

Re: [PATCH v4 00/73] XArray version 4

On Tue, Dec 05, 2017 at 04:40:46PM -0800, Matthew Wilcox wrote: > From: Matthew Wilcox > > I looked through some notes and decided this was version 4 of the XArray. > Last posted two weeks ago, this version includes a *lot* of changes. > I'd like to thank Dave Chinner for his feedback,

Re: [fstests PATCH v3] generic: add test for DAX MAP_SYNC support

On Thu, Oct 26, 2017 at 07:59:39AM +0300, Amir Goldstein wrote: > On Wed, Oct 25, 2017 at 11:47 PM, Ross Zwisler > <ross.zwis...@linux.intel.com> wrote: > > Add a test that exercises DAX's new MAP_SYNC flag. > > > > This test creates a file and writes to it via an m

Re: [fstests PATCH v3] generic: add test for DAX MAP_SYNC support

On Thu, Oct 26, 2017 at 07:59:39AM +0300, Amir Goldstein wrote: > On Wed, Oct 25, 2017 at 11:47 PM, Ross Zwisler > wrote: > > Add a test that exercises DAX's new MAP_SYNC flag. > > > > This test creates a file and writes to it via an mmap(), but never syncs > >

Re: [fstests PATCH v3] generic: add test for DAX MAP_SYNC support

On Thu, Nov 16, 2017 at 02:28:15PM -0700, Ross Zwisler wrote: > On Thu, Oct 26, 2017 at 08:56:38AM +1100, Dave Chinner wrote: > > Perhaps stat -c %b $SCRATCH_MNT/test ? > > Maybe, but doesn't the output of 'stat -c %b' depend on the block size the > filesystem is using? I thi

Re: [fstests PATCH v3] generic: add test for DAX MAP_SYNC support

On Thu, Nov 16, 2017 at 02:28:15PM -0700, Ross Zwisler wrote: > On Thu, Oct 26, 2017 at 08:56:38AM +1100, Dave Chinner wrote: > > Perhaps stat -c %b $SCRATCH_MNT/test ? > > Maybe, but doesn't the output of 'stat -c %b' depend on the block size the > filesystem is using? I thi

Re: [fstests PATCH v3] generic: add test for DAX MAP_SYNC support

On Thu, Oct 26, 2017 at 08:56:38AM +1100, Dave Chinner wrote: > On Wed, Oct 25, 2017 at 02:47:04PM -0600, Ross Zwisler wrote: > > Add a test that exercises DAX's new MAP_SYNC flag. > > > > This test creates a file and writes to it via an mmap(), but never syncs > > via

Re: [fstests PATCH v3] generic: add test for DAX MAP_SYNC support

On Thu, Oct 26, 2017 at 08:56:38AM +1100, Dave Chinner wrote: > On Wed, Oct 25, 2017 at 02:47:04PM -0600, Ross Zwisler wrote: > > Add a test that exercises DAX's new MAP_SYNC flag. > > > > This test creates a file and writes to it via an mmap(), but never syncs > > via

[fstests PATCH v3] generic: add test for DAX MAP_SYNC support

the mmap(), so we can't do any data integrity checking. We can only verify that the metadata writes for the page faults happened. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- Changes since v2: - Fixed _require_log_writes() so that DAX will be disallowed if the v

[fstests PATCH v3] generic: add test for DAX MAP_SYNC support

the mmap(), so we can't do any data integrity checking. We can only verify that the metadata writes for the page faults happened. Signed-off-by: Ross Zwisler --- Changes since v2: - Fixed _require_log_writes() so that DAX will be disallowed if the version of the dm-log-writes target is older

Re: [fstests PATCH v2] generic: add test for DAX MAP_SYNC support

On Wed, Oct 25, 2017 at 03:19:22PM +0300, Amir Goldstein wrote: > On Sun, Oct 22, 2017 at 9:56 AM, Amir Goldstein <amir7...@gmail.com> wrote: > > On Sat, Oct 21, 2017 at 12:25 AM, Ross Zwisler > > <ross.zwis...@linux.intel.com> wrote: > >> Add a test th

Re: [fstests PATCH v2] generic: add test for DAX MAP_SYNC support

On Wed, Oct 25, 2017 at 03:19:22PM +0300, Amir Goldstein wrote: > On Sun, Oct 22, 2017 at 9:56 AM, Amir Goldstein wrote: > > On Sat, Oct 21, 2017 at 12:25 AM, Ross Zwisler > > wrote: > >> Add a test that exercises DAX's new MAP_SYNC flag. > >> > >> Thi

Re: [PATCH 2/2] dm log writes: add support for DAX

On Tue, Oct 24, 2017 at 03:22:23PM -0400, Mike Snitzer wrote: > On Fri, Oct 20 2017 at 1:24am -0400, > Ross Zwisler <ross.zwis...@linux.intel.com> wrote: > > > Now that we have the ability log filesystem writes using a flat buffer, add > > support for DAX. Unfortun

Re: [PATCH 2/2] dm log writes: add support for DAX

On Tue, Oct 24, 2017 at 03:22:23PM -0400, Mike Snitzer wrote: > On Fri, Oct 20 2017 at 1:24am -0400, > Ross Zwisler wrote: > > > Now that we have the ability log filesystem writes using a flat buffer, add > > support for DAX. Unfortunately we can't easily track data that

Re: [PATCH 2/2] dm log writes: add support for DAX

On Mon, Oct 23, 2017 at 01:34:09PM -0400, Josef Bacik wrote: > On Thu, Oct 19, 2017 at 11:24:04PM -0600, Ross Zwisler wrote: > > Now that we have the ability log filesystem writes using a flat buffer, add > > support for DAX. Unfortunately we can't easily track data that has been

Re: [PATCH 2/2] dm log writes: add support for DAX

On Mon, Oct 23, 2017 at 01:34:09PM -0400, Josef Bacik wrote: > On Thu, Oct 19, 2017 at 11:24:04PM -0600, Ross Zwisler wrote: > > Now that we have the ability log filesystem writes using a flat buffer, add > > support for DAX. Unfortunately we can't easily track data that has been

[fstests PATCH v2] generic: add test for DAX MAP_SYNC support

the mmap(), so we can't do any data integrity checking. We can only verify that the metadata writes for the page faults happened. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- Changes since v1: - Addressed review feedback from Amir. Thank you for the review! --- .git

[fstests PATCH v2] generic: add test for DAX MAP_SYNC support

the mmap(), so we can't do any data integrity checking. We can only verify that the metadata writes for the page faults happened. Signed-off-by: Ross Zwisler --- Changes since v1: - Addressed review feedback from Amir. Thank you for the review! --- .gitignore| 1 + common

[fstests PATCH] generic: add test for DAX MAP_SYNC support

the mmap(), so we can't do any data integrity checking. We can only verify that the metadata writes for the page faults happened. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- For this test to run successfully you'll need both Jan's MAP_SYNC series: https://www.spinics.net

[fstests PATCH] generic: add test for DAX MAP_SYNC support

the mmap(), so we can't do any data integrity checking. We can only verify that the metadata writes for the page faults happened. Signed-off-by: Ross Zwisler --- For this test to run successfully you'll need both Jan's MAP_SYNC series: https://www.spinics.net/lists/linux-xfs/msg11852.html and my

[PATCH 1/2] dm log writes: Add support for inline data buffers

() which allows us to write filesystem data using a flat buffer as a source, and wire it up in log_one_block(). Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- drivers/md/dm-log-writes.c | 90 +++--- 1 file changed, 86 insertions

[PATCH 1/2] dm log writes: Add support for inline data buffers

() which allows us to write filesystem data using a flat buffer as a source, and wire it up in log_one_block(). Signed-off-by: Ross Zwisler --- drivers/md/dm-log-writes.c | 90 +++--- 1 file changed, 86 insertions(+), 4 deletions(-) diff --git a/drivers/md

[PATCH 2/2] dm log writes: add support for DAX

that can test the new MAP_SYNC DAX flag. By logging the filesystem activity with dm-log-writes we can show that the MAP_SYNC page faults are writing out their metadata as they happen, instead of requiring an explicit msync/fsync. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com>

[PATCH 2/2] dm log writes: add support for DAX

that can test the new MAP_SYNC DAX flag. By logging the filesystem activity with dm-log-writes we can show that the MAP_SYNC page faults are writing out their metadata as they happen, instead of requiring an explicit msync/fsync. Signed-off-by: Ross Zwisler --- Here's a link to Jan's latest MAP_SY

[PATCH v2] dev/dax: fix uninitialized variable build warning

Fix this build warning: warning: 'phys' may be used uninitialized in this function [-Wuninitialized] As reported here: https://lkml.org/lkml/2017/10/16/152 http://kisskb.ellerman.id.au/kisskb/buildresult/13181373/log/ Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- drive

[PATCH v2] dev/dax: fix uninitialized variable build warning

Fix this build warning: warning: 'phys' may be used uninitialized in this function [-Wuninitialized] As reported here: https://lkml.org/lkml/2017/10/16/152 http://kisskb.ellerman.id.au/kisskb/buildresult/13181373/log/ Signed-off-by: Ross Zwisler --- drivers/dax/device.c | 3 ++- 1 file

[PATCH 2/2] MAINTAINERS: Add entry for device DAX

And update the entry for filesystem DAX to differentiate them. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- MAINTAINERS | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index a74227a..b2b2e75 100644 --- a/MAINTAINERS

[PATCH 2/2] MAINTAINERS: Add entry for device DAX

And update the entry for filesystem DAX to differentiate them. Signed-off-by: Ross Zwisler --- MAINTAINERS | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index a74227a..b2b2e75 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4162,7 +4162,7

[PATCH 1/2] dev/dax: fix uninitialized variable build warning

'phys' being uninitialized if you broke out early in the above loop, in which case 'phys' will be set. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- drivers/dax/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dax/device.c b/drivers/dax/de

[PATCH 1/2] dev/dax: fix uninitialized variable build warning

'phys' being uninitialized if you broke out early in the above loop, in which case 'phys' will be set. Signed-off-by: Ross Zwisler --- drivers/dax/device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dax/device.c b/drivers/dax/device.c index e9f3b3e..4aca0a2 100644

Re: [PATCH] fs/block_dev: remove vfs_msg() interface

On Wed, Oct 11, 2017 at 6:08 AM, Rakesh Pandit <rak...@tuxera.com> wrote: > Replaced by pr_err usage in commit ef51042472f5 ("block, dax: move > "select DAX" from BLOCK to FS_DAX") > > Signed-off-by: Rakesh Pandit <rak...@tuxera.com> Acked-by: Ross Zwisler <ross.zwis...@linux.intel.com>

Re: [PATCH] fs/block_dev: remove vfs_msg() interface

On Wed, Oct 11, 2017 at 6:08 AM, Rakesh Pandit wrote: > Replaced by pr_err usage in commit ef51042472f5 ("block, dax: move > "select DAX" from BLOCK to FS_DAX") > > Signed-off-by: Rakesh Pandit Acked-by: Ross Zwisler

Re: [PATCH v2 0/5] ext4: DAX data corruption fixes

On Mon, Sep 11, 2017 at 11:05:21PM -0600, Ross Zwisler wrote: > This series prevents a pair of data corruptions with ext4 + DAX. The first > such corruption happens when combining the inline data feature with DAX, > and the second happens when combining data journaling with DAX. >

Re: [PATCH v2 0/5] ext4: DAX data corruption fixes

On Mon, Sep 11, 2017 at 11:05:21PM -0600, Ross Zwisler wrote: > This series prevents a pair of data corruptions with ext4 + DAX. The first > such corruption happens when combining the inline data feature with DAX, > and the second happens when combining data journaling with DAX. >

Re: [PATCH 1/7] xfs: always use DAX if mount option is used

On Tue, Sep 26, 2017 at 11:40:01PM -0700, Christoph Hellwig wrote: > On Tue, Sep 26, 2017 at 11:30:57AM -0600, Ross Zwisler wrote: > > I agree that Christoph's idea about having the system intelligently adjust > > to > > use DAX based on performance information it gathers

Re: [PATCH 1/7] xfs: always use DAX if mount option is used

On Tue, Sep 26, 2017 at 11:40:01PM -0700, Christoph Hellwig wrote: > On Tue, Sep 26, 2017 at 11:30:57AM -0600, Ross Zwisler wrote: > > I agree that Christoph's idea about having the system intelligently adjust > > to > > use DAX based on performance information it gathers

Re: [PATCH 6/7] mm, fs: introduce file_operations->post_mmap()

On Wed, Sep 27, 2017 at 01:35:27PM +0200, Jan Kara wrote: > On Tue 26-09-17 14:41:53, Dan Williams wrote: > > On Tue, Sep 26, 2017 at 2:06 PM, Ross Zwisler > > <ross.zwis...@linux.intel.com> wrote: > > > On Tue, Sep 26, 2017 at 12:19:21PM -0700, Dan Williams wrot

Re: [PATCH 6/7] mm, fs: introduce file_operations->post_mmap()

On Wed, Sep 27, 2017 at 01:35:27PM +0200, Jan Kara wrote: > On Tue 26-09-17 14:41:53, Dan Williams wrote: > > On Tue, Sep 26, 2017 at 2:06 PM, Ross Zwisler > > wrote: > > > On Tue, Sep 26, 2017 at 12:19:21PM -0700, Dan Williams wrote: > > >> On Tue, Se

Re: [PATCH 6/7] mm, fs: introduce file_operations->post_mmap()

On Tue, Sep 26, 2017 at 12:19:21PM -0700, Dan Williams wrote: > On Tue, Sep 26, 2017 at 11:57 AM, Ross Zwisler <> > > This decision can only be made (in this > > proposed scheme) *after* the inode->i_mapping->i_mmap tree has been > > populated, which means we need

Re: [PATCH 6/7] mm, fs: introduce file_operations->post_mmap()

On Tue, Sep 26, 2017 at 12:19:21PM -0700, Dan Williams wrote: > On Tue, Sep 26, 2017 at 11:57 AM, Ross Zwisler <> > > This decision can only be made (in this > > proposed scheme) *after* the inode->i_mapping->i_mmap tree has been > > populated, which means we need

Re: [PATCH 7/7] xfs: re-enable XFS per-inode DAX

On Tue, Sep 26, 2017 at 08:36:11AM +0200, Christoph Hellwig wrote: > On Mon, Sep 25, 2017 at 05:14:04PM -0600, Ross Zwisler wrote: > > Re-enable the XFS per-inode DAX flag, preventing S_DAX from changing when > > any mappings are present. > > Before we re-enable it please co

Re: [PATCH 7/7] xfs: re-enable XFS per-inode DAX

On Tue, Sep 26, 2017 at 08:36:11AM +0200, Christoph Hellwig wrote: > On Mon, Sep 25, 2017 at 05:14:04PM -0600, Ross Zwisler wrote: > > Re-enable the XFS per-inode DAX flag, preventing S_DAX from changing when > > any mappings are present. > > Before we re-enable it please co

Re: [PATCH 6/7] mm, fs: introduce file_operations->post_mmap()

On Mon, Sep 25, 2017 at 04:38:45PM -0700, Dan Williams wrote: > On Mon, Sep 25, 2017 at 4:14 PM, Ross Zwisler > <ross.zwis...@linux.intel.com> wrote: > > When mappings are created the vma->vm_flags that they use vary based on > > whether the inode being mapped is us

Re: [PATCH 6/7] mm, fs: introduce file_operations->post_mmap()

On Mon, Sep 25, 2017 at 04:38:45PM -0700, Dan Williams wrote: > On Mon, Sep 25, 2017 at 4:14 PM, Ross Zwisler > wrote: > > When mappings are created the vma->vm_flags that they use vary based on > > whether the inode being mapped is using DAX or not. This setup happens in &g

Re: [PATCH 1/7] xfs: always use DAX if mount option is used

On Tue, Sep 26, 2017 at 09:38:12AM +1000, Dave Chinner wrote: > On Mon, Sep 25, 2017 at 05:13:58PM -0600, Ross Zwisler wrote: > > Before support for the per-inode DAX flag was disabled the XFS the code had > > an issue where the user couldn't reliably tell whether or not DAX was

Re: [PATCH 1/7] xfs: always use DAX if mount option is used

On Tue, Sep 26, 2017 at 09:38:12AM +1000, Dave Chinner wrote: > On Mon, Sep 25, 2017 at 05:13:58PM -0600, Ross Zwisler wrote: > > Before support for the per-inode DAX flag was disabled the XFS the code had > > an issue where the user couldn't reliably tell whether or not DAX was

Re: [PATCH 1/7] xfs: always use DAX if mount option is used

On Tue, Sep 26, 2017 at 04:37:43PM +0200, Christoph Hellwig wrote: > On Tue, Sep 26, 2017 at 09:09:57PM +1000, Dave Chinner wrote: > > Well, quite frankly, I never wanted the mount option for XFS. It was > > supposed to be for initial testing only, then we'd /always/ use the > > the inode flags.

Re: [PATCH 1/7] xfs: always use DAX if mount option is used

On Tue, Sep 26, 2017 at 04:37:43PM +0200, Christoph Hellwig wrote: > On Tue, Sep 26, 2017 at 09:09:57PM +1000, Dave Chinner wrote: > > Well, quite frankly, I never wanted the mount option for XFS. It was > > supposed to be for initial testing only, then we'd /always/ use the > > the inode flags.

Re: [PATCH 2/7] xfs: validate bdev support for DAX inode flag

On Tue, Sep 26, 2017 at 08:36:50AM +0200, Christoph Hellwig wrote: > On Mon, Sep 25, 2017 at 05:13:59PM -0600, Ross Zwisler wrote: > > Currently only the blocksize is checked, but we should really be calling > > bdev_dax_supported() which also tests to make sure we can get a > &

Re: [PATCH 2/7] xfs: validate bdev support for DAX inode flag

On Tue, Sep 26, 2017 at 08:36:50AM +0200, Christoph Hellwig wrote: > On Mon, Sep 25, 2017 at 05:13:59PM -0600, Ross Zwisler wrote: > > Currently only the blocksize is checked, but we should really be calling > > bdev_dax_supported() which also tests to make sure we can get a > &

[PATCH 2/7] xfs: validate bdev support for DAX inode flag

fill_super(). Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> Reviewed-by: Christoph Hellwig <h...@lst.de> --- fs/xfs/xfs_ioctl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c index 26faeb9..0433aef 100644 --- a/fs/xf

[PATCH 2/7] xfs: validate bdev support for DAX inode flag

fill_super(). Signed-off-by: Ross Zwisler Reviewed-by: Christoph Hellwig --- fs/xfs/xfs_ioctl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c index 26faeb9..0433aef 100644 --- a/fs/xfs/xfs_ioctl.c +++ b/fs/xfs/xfs_ioctl.c @@ -1088

[PATCH 3/7] xfs: protect S_DAX transitions in XFS read path

d path. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- fs/xfs/xfs_file.c | 42 +- 1 file changed, 13 insertions(+), 29 deletions(-) diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index ebdd0bd..ca4c8fd 100644 --- a/fs/xfs/xfs_file.c

[PATCH 3/7] xfs: protect S_DAX transitions in XFS read path

d path. Signed-off-by: Ross Zwisler --- fs/xfs/xfs_file.c | 42 +- 1 file changed, 13 insertions(+), 29 deletions(-) diff --git a/fs/xfs/xfs_file.c b/fs/xfs/xfs_file.c index ebdd0bd..ca4c8fd 100644 --- a/fs/xfs/xfs_file.c +++ b/fs/xfs/xfs_file.c @@ -207,7

[PATCH 0/7] re-enable XFS per-inode DAX

implementation, and then to do a similar implementation for ext4 based on my previous ext4 DAX inode flag patches: https://patchwork.kernel.org/patch/9939743/ These patches apply cleanly to v4.14-rc2. Ross Zwisler (7): xfs: always use DAX if mount option is used xfs: validate bdev support

[PATCH 1/7] xfs: always use DAX if mount option is used

s that DAX will always be used for all inodes on a filesystem mounted with -o dax, making the usage reliable and detectable. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> Reviewed-by: Christoph Hellwig <h...@lst.de> --- fs/xfs/xfs_ioctl.c | 11 +-- 1 file changed, 9 inse

[PATCH 0/7] re-enable XFS per-inode DAX

implementation, and then to do a similar implementation for ext4 based on my previous ext4 DAX inode flag patches: https://patchwork.kernel.org/patch/9939743/ These patches apply cleanly to v4.14-rc2. Ross Zwisler (7): xfs: always use DAX if mount option is used xfs: validate bdev support

[PATCH 1/7] xfs: always use DAX if mount option is used

s that DAX will always be used for all inodes on a filesystem mounted with -o dax, making the usage reliable and detectable. Signed-off-by: Ross Zwisler Reviewed-by: Christoph Hellwig --- fs/xfs/xfs_ioctl.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/fs/xfs/xfs_ioct

[PATCH 4/7] xfs: protect S_DAX transitions in XFS write path

APLOCK|XFS_IOLOCK) sets S_DAX releases XFS_MMAPLOCK and XFS_IOLOCK xfs_file_buffered_aio_write() does buffered I/O to DAX inode, death Fix this by ensuring that we only check S_DAX when we hold the XFS_IOLOCK in the write path. Signed-off-by

[PATCH 4/7] xfs: protect S_DAX transitions in XFS write path

APLOCK|XFS_IOLOCK) sets S_DAX releases XFS_MMAPLOCK and XFS_IOLOCK xfs_file_buffered_aio_write() does buffered I/O to DAX inode, death Fix this by ensuring that we only check S_DAX when we hold the XFS_IOLOCK in the write path. Signed-off-by

[PATCH 7/7] xfs: re-enable XFS per-inode DAX

Re-enable the XFS per-inode DAX flag, preventing S_DAX from changing when any mappings are present. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- fs/xfs/xfs_ioctl.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/fs/xfs/xfs_ioctl.c b/

[PATCH 7/7] xfs: re-enable XFS per-inode DAX

Re-enable the XFS per-inode DAX flag, preventing S_DAX from changing when any mappings are present. Signed-off-by: Ross Zwisler --- fs/xfs/xfs_ioctl.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs/xfs_ioctl.c index 386b437

[PATCH 5/7] xfs: introduce xfs_is_dax_state_changing

Pull this code out of xfs_ioctl_setattr_dax_invalidate() as it will be used in multiple places soon. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- fs/xfs/xfs_ioctl.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/

[PATCH 6/7] mm, fs: introduce file_operations->post_mmap()

is post_mmap() op now happens at a time when we can be sure whether the mapping will use DAX or not, and we can set up the vma->vm_flags appropriately. Signed-off-by: Ross Zwisler <ross.zwis...@linux.intel.com> --- fs/xfs/xfs_file.c | 15 ++- include/linux/fs.h | 1 + mm/mm

[PATCH 5/7] xfs: introduce xfs_is_dax_state_changing

Pull this code out of xfs_ioctl_setattr_dax_invalidate() as it will be used in multiple places soon. Signed-off-by: Ross Zwisler --- fs/xfs/xfs_ioctl.c | 34 +++--- 1 file changed, 23 insertions(+), 11 deletions(-) diff --git a/fs/xfs/xfs_ioctl.c b/fs/xfs

<    1   2   3   4   5   6   7   8   9   10   >