Re: [PATCH 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

On Mon, 2017-08-28 at 14:22:03 -0400, Nicolas Dufresne wrote: > Le lundi 28 août 2017 à 08:15 -0700, Soren Brinkmann a écrit : [...] > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > index 94153895fcd4..4e8b64575b2a 100644 > > --- a/drivers/media/i2c/Kconfig > > +++

Re: [PATCH 2/2] media:imx274 V4l2 driver for Sony imx274 CMOS sensor

On Mon, 2017-08-28 at 14:22:03 -0400, Nicolas Dufresne wrote: > Le lundi 28 août 2017 à 08:15 -0700, Soren Brinkmann a écrit : [...] > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > > index 94153895fcd4..4e8b64575b2a 100644 > > --- a/drivers/media/i2c/Kconfig > > +++

Re: [RFC PATCH 1/4] serial: uartps: Remove console_initcall from the driver

On Fri, 2017-07-21 at 11:32:24 +0200, Michal Simek wrote: > register_console() is called from > uart_add_one_port()->uart_configure_port() > that's why register_console() is called twice. > > This patch remove console_initcall to call register_console() only from > one location. > > Also based

Re: [RFC PATCH 1/4] serial: uartps: Remove console_initcall from the driver

On Fri, 2017-07-21 at 11:32:24 +0200, Michal Simek wrote: > register_console() is called from > uart_add_one_port()->uart_configure_port() > that's why register_console() is called twice. > > This patch remove console_initcall to call register_console() only from > one location. > > Also based

Re: [PATCH] dmaengine: zynqmp_dma: fix error return code in zynqmp_dma_chan_probe()

On Fri, 2017-06-30 at 02:42:47 -0500, Gustavo A. R. Silva wrote: > Print error message and propagate the return value of > platform_get_irq on failure. > > Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Reviewed-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Sören

Re: [PATCH] dmaengine: zynqmp_dma: fix error return code in zynqmp_dma_chan_probe()

On Fri, 2017-06-30 at 02:42:47 -0500, Gustavo A. R. Silva wrote: > Print error message and propagate the return value of > platform_get_irq on failure. > > Signed-off-by: Gustavo A. R. Silva Reviewed-by: Sören Brinkmann Sören

Re: [PATCH] usb: gadget: udc-xilinx: remove useless variable assignment in xudc_read_fifo()

A. R. Silva <garsi...@embeddedor.com> Reviewed-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Sören

Re: [PATCH] usb: gadget: udc-xilinx: remove useless variable assignment in xudc_read_fifo()

ustavo A. R. Silva Reviewed-by: Sören Brinkmann Sören

Re: [PATCH] gpio: zynq: remove unneeded (void *) casts in of_match_table

On Sat, 2017-05-13 at 01:18:45 +0900, Masahiro Yamada wrote: > of_device_id::data is an opaque pointer. No explicit cast is needed. > > Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> Acked-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Sören

Re: [PATCH] gpio: zynq: remove unneeded (void *) casts in of_match_table

On Sat, 2017-05-13 at 01:18:45 +0900, Masahiro Yamada wrote: > of_device_id::data is an opaque pointer. No explicit cast is needed. > > Signed-off-by: Masahiro Yamada Acked-by: Sören Brinkmann Sören

Re: [PATCH] usb: gadget: udc-xilinx: clean up a variable name

On Thu, 2017-04-27 at 12:11:18 +0300, Dan Carpenter wrote: > "ep->udc->lock" and "udc->lock" are the same thing. It confuses Smatch > if we don't use the same name consistently. > > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Reviewed-

Re: [PATCH] usb: gadget: udc-xilinx: clean up a variable name

On Thu, 2017-04-27 at 12:11:18 +0300, Dan Carpenter wrote: > "ep->udc->lock" and "udc->lock" are the same thing. It confuses Smatch > if we don't use the same name consistently. > > Signed-off-by: Dan Carpenter Reviewed-by: Sören Brinkmann Sören

Re: [PATCH v2] ARM64: zynqmp: Fix i2c node's compatible string

tems. > > Signed-off-by: Moritz Fischer <m...@kernel.org> > Cc: Michal Simek <michal.si...@xilinx.com> > Cc: Sören Brinkmann <soren.brinkm...@xilinx.com> > Cc: Rob Herring <robh...@kernel.org> Acked-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Sören

Re: [PATCH v2] ARM64: zynqmp: Fix i2c node's compatible string

Signed-off-by: Moritz Fischer > Cc: Michal Simek > Cc: Sören Brinkmann > Cc: Rob Herring Acked-by: Sören Brinkmann Sören

Re: [PATCH 3/4] fpga mgr: zynq: Add support for encrypted bitstreams

ES & HMAC units > are disabled by the boot ROM, therefore the capability > is not available. > > Signed-off-by: Moritz Fischer <moritz.fisc...@ettus.com> > Cc: Alan Tull <at...@opensource.altera.com> > Cc: Michal Simek <michal.si...@xilinx.com> > Cc: Sören

Re: [PATCH 3/4] fpga mgr: zynq: Add support for encrypted bitstreams

ES & HMAC units > are disabled by the boot ROM, therefore the capability > is not available. > > Signed-off-by: Moritz Fischer > Cc: Alan Tull > Cc: Michal Simek > Cc: Sören Brinkmann > Cc: linux-kernel@vger.kernel.org > Cc: linux-arm-ker...@lists.infradead.o

Re: [Patch v5 04/12] irqchip: xilinx: Add support for parent intc

On Tue, 2016-10-25 at 12:49:33 +0200, Thomas Gleixner wrote: > On Tue, 25 Oct 2016, Zubair Lutfullah Kakakhel wrote: > > On 10/21/2016 10:48 AM, Marc Zyngier wrote: > > > Shouldn't you return an error if irq is zero? > > > > > > > I'll add the following for the error case > > > >

Re: [Patch v5 04/12] irqchip: xilinx: Add support for parent intc

On Tue, 2016-10-25 at 12:49:33 +0200, Thomas Gleixner wrote: > On Tue, 25 Oct 2016, Zubair Lutfullah Kakakhel wrote: > > On 10/21/2016 10:48 AM, Marc Zyngier wrote: > > > Shouldn't you return an error if irq is zero? > > > > > > > I'll add the following for the error case > > > >

Re: [PATCH] Adding Support for Coresight Components on Zynq 7000.

Hi Muhammad, On Mon, 2016-10-03 at 14:56:16 +0200, Muhammad Abdul WAHAB wrote: > Hi Sören, > > > I tried to refresh my Zynq knowledge a bit. The clkc provides the > > dbg_trc clock, and that is the clock you need (not fclk). I couldn't > > find it in the binding (I guess I messed that up), but

Re: [PATCH] Adding Support for Coresight Components on Zynq 7000.

Hi Muhammad, On Mon, 2016-10-03 at 14:56:16 +0200, Muhammad Abdul WAHAB wrote: > Hi Sören, > > > I tried to refresh my Zynq knowledge a bit. The clkc provides the > > dbg_trc clock, and that is the clock you need (not fclk). I couldn't > > find it in the binding (I guess I messed that up), but

Re: [PATCH] Adding Support for Coresight Components on Zynq 7000.

Hi Muhammad, On Fri, 2016-09-30 at 09:39:51 +0200, Muhammad Abdul WAHAB wrote: > Hi Sören, > > Thank you for your remarks. I corrected a few things as you suggested. > [...] > >> +tpiu@F8803000 { > >>> > >>> +compatible = "arm,coresight-tpiu", "arm,primecell"; > >>> +

Re: [PATCH] Adding Support for Coresight Components on Zynq 7000.

Hi Muhammad, On Fri, 2016-09-30 at 09:39:51 +0200, Muhammad Abdul WAHAB wrote: > Hi Sören, > > Thank you for your remarks. I corrected a few things as you suggested. > [...] > >> +tpiu@F8803000 { > >>> > >>> +compatible = "arm,coresight-tpiu", "arm,primecell"; > >>> +

Re: [PATCH 2/2] mmc: sdhci-of-arasan: mark sdhci_arasan_reset() static

On Fri, 2016-09-30 at 09:37:39 +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/mmc/host/sdhci-of-arasan.c:253:6: warning: no previous prototype for > 'sdhci_arasan_reset' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it

Re: [PATCH 2/2] mmc: sdhci-of-arasan: mark sdhci_arasan_reset() static

On Fri, 2016-09-30 at 09:37:39 +0800, Baoyou Xie wrote: > We get 1 warning when building kernel with W=1: > drivers/mmc/host/sdhci-of-arasan.c:253:6: warning: no previous prototype for > 'sdhci_arasan_reset' [-Wmissing-prototypes] > > In fact, this function is only used in the file in which it

Re: [PATCH] Adding Support for Coresight Components on Zynq 7000.

Hi Muhammad, On Thu, 2016-09-29 at 12:26:13 +0200, Muhammad Abdul WAHAB wrote: > The Coresight components are present on the Zynq SoC but the corresponding > device tree entries are missing. This patch adds device tree entries for > coresight components while explaining how it was done in order

Re: [PATCH] Adding Support for Coresight Components on Zynq 7000.

Hi Muhammad, On Thu, 2016-09-29 at 12:26:13 +0200, Muhammad Abdul WAHAB wrote: > The Coresight components are present on the Zynq SoC but the corresponding > device tree entries are missing. This patch adds device tree entries for > coresight components while explaining how it was done in order

Re: [PATCH v2] arm: dts: zynq: Add MicroZed board support

On Thu, 2016-09-22 at 18:51:29 +0530, Jagan Teki wrote: > From: Jagan Teki > > Added basic dts support for MicroZed board. > > - UART > - SDHCI > - Ethernet > > Cc: Soren Brinkmann > Cc: Michal Simek > Signed-off-by:

Re: [PATCH v2] arm: dts: zynq: Add MicroZed board support

On Thu, 2016-09-22 at 18:51:29 +0530, Jagan Teki wrote: > From: Jagan Teki > > Added basic dts support for MicroZed board. > > - UART > - SDHCI > - Ethernet > > Cc: Soren Brinkmann > Cc: Michal Simek > Signed-off-by: Jagan Teki > --- > Changes for v2: > - Add SDHCI > - Add

Re: [PATCH] gpio: Added zynq specific check for special pins on bank zero

o/gpio-zynq.c > @@ -96,6 +96,10 @@ > /* GPIO upper 16 bit mask */ > #define ZYNQ_GPIO_UPPER_MASK 0x > > +/* For GPIO quirks */ > +#define ZYNQ_GPIOBIT(0) > +#define ZYNQMP_GPIO BIT(1) I'd make sure all quirks are easily identifiable and call them somet

Re: [PATCH] gpio: Added zynq specific check for special pins on bank zero

@@ > /* GPIO upper 16 bit mask */ > #define ZYNQ_GPIO_UPPER_MASK 0x > > +/* For GPIO quirks */ > +#define ZYNQ_GPIOBIT(0) > +#define ZYNQMP_GPIO BIT(1) I'd make sure all quirks are easily identifiable and call them something like 'ZYNQ_GPIO_QUIRK_FOO' Apart from that: Acked-by: Sören Brinkmann Sören

Re: [PATCH v5] Axi-usb: Add support for 64-bit addressing.

On Thu, 2016-09-01 at 14:22:56 +0530, Nava kishore Manne wrote: > This patch updates the driver to support 64-bit DMA addressing. > > Signed-off-by: Nava kishore Manne > Acked-by: Rob Herring > --- > Changes for v5: > -None. > > Changes for

Re: [PATCH v5] Axi-usb: Add support for 64-bit addressing.

On Thu, 2016-09-01 at 14:22:56 +0530, Nava kishore Manne wrote: > This patch updates the driver to support 64-bit DMA addressing. > > Signed-off-by: Nava kishore Manne > Acked-by: Rob Herring > --- > Changes for v5: > -None. > > Changes for v4: > -Used boolen

Re: [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit

On Thu, 2016-08-25 at 17:23:47 +0200, Lars-Peter Clausen wrote: > On 08/25/2016 05:10 PM, Sören Brinkmann wrote: > > On Wed, 2016-08-24 at 18:23:03 -0500, Zach Brown wrote: > >> The sdhci controller on xilinx zynq devices will not function unless > >> the cd bit is prov

Re: [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit

On Thu, 2016-08-25 at 17:23:47 +0200, Lars-Peter Clausen wrote: > On 08/25/2016 05:10 PM, Sören Brinkmann wrote: > > On Wed, 2016-08-24 at 18:23:03 -0500, Zach Brown wrote: > >> The sdhci controller on xilinx zynq devices will not function unless > >> the cd bit is prov

Re: [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit

On Wed, 2016-08-24 at 18:23:03 -0500, Zach Brown wrote: > The sdhci controller on xilinx zynq devices will not function unless > the cd bit is provided. http://www.xilinx.com/support/answers/61064.html > In cases where it is impossible to provide the cd bit in hardware, > setting the controller to

Re: [PATCH 1/2] sdhci-of-arasan: Add quirk and device tree parameter to fake CD bit

On Wed, 2016-08-24 at 18:23:03 -0500, Zach Brown wrote: > The sdhci controller on xilinx zynq devices will not function unless > the cd bit is provided. http://www.xilinx.com/support/answers/61064.html > In cases where it is impossible to provide the cd bit in hardware, > setting the controller to

Re: SOC-specific action for irq_set_wake

On Wed, 2016-07-20 at 14:36:12 +0100, Marc Zyngier wrote: > Hi Sören, > > On 20/07/16 14:16, Sören Brinkmann wrote: > > Hi Marc, > > >>>>> Does anybody have similar problems and probably already solved it? > >>>>> Any other suggestions for a

Re: SOC-specific action for irq_set_wake

On Wed, 2016-07-20 at 14:36:12 +0100, Marc Zyngier wrote: > Hi Sören, > > On 20/07/16 14:16, Sören Brinkmann wrote: > > Hi Marc, > > >>>>> Does anybody have similar problems and probably already solved it? > >>>>> Any other suggestions for a

Re: SOC-specific action for irq_set_wake

Hi Thomas, On Wed, 2016-07-20 at 08:28:35 +0200, Thomas Gleixner wrote: > On Tue, 19 Jul 2016, Sören Brinkmann wrote: > > we are working on the PM solution for Zynq MPSOC and ran into some > > problem when setting the wake source. > > > > The situation is that when the

Re: SOC-specific action for irq_set_wake

Hi Thomas, On Wed, 2016-07-20 at 08:28:35 +0200, Thomas Gleixner wrote: > On Tue, 19 Jul 2016, Sören Brinkmann wrote: > > we are working on the PM solution for Zynq MPSOC and ran into some > > problem when setting the wake source. > > > > The situation is that when the

Re: SOC-specific action for irq_set_wake

Hi Marc, On Wed, 2016-07-20 at 09:17:16 +0100, Marc Zyngier wrote: > On 20/07/16 00:34, Sören Brinkmann wrote: > > Hi Andy, > > > > On Tue, 2016-07-19 at 17:47:13 -0500, Andy Gross wrote: > >> On Tue, Jul 19, 2016 at 11:18:04AM -0700, Sören Brinkmann wrote: > &

Re: SOC-specific action for irq_set_wake

Hi Marc, On Wed, 2016-07-20 at 09:17:16 +0100, Marc Zyngier wrote: > On 20/07/16 00:34, Sören Brinkmann wrote: > > Hi Andy, > > > > On Tue, 2016-07-19 at 17:47:13 -0500, Andy Gross wrote: > >> On Tue, Jul 19, 2016 at 11:18:04AM -0700, Sören Brinkmann wrote: > &

Re: SOC-specific action for irq_set_wake

Hi Andy, On Tue, 2016-07-19 at 17:47:13 -0500, Andy Gross wrote: > On Tue, Jul 19, 2016 at 11:18:04AM -0700, Sören Brinkmann wrote: > > Hi, > > > > we are working on the PM solution for Zynq MPSOC and ran into some > > problem when setting the wake source. > >

Re: SOC-specific action for irq_set_wake

Hi Andy, On Tue, 2016-07-19 at 17:47:13 -0500, Andy Gross wrote: > On Tue, Jul 19, 2016 at 11:18:04AM -0700, Sören Brinkmann wrote: > > Hi, > > > > we are working on the PM solution for Zynq MPSOC and ran into some > > problem when setting the wake source. > >

SOC-specific action for irq_set_wake

Hi, we are working on the PM solution for Zynq MPSOC and ran into some problem when setting the wake source. The situation is that when the A53 is in suspend, the GIC(v2) may be powered down. In that state a companion core is handling wake events/IRQs, but we expect the OS/Linux to notify the

SOC-specific action for irq_set_wake

Hi, we are working on the PM solution for Zynq MPSOC and ran into some problem when setting the wake source. The situation is that when the A53 is in suspend, the GIC(v2) may be powered down. In that state a companion core is handling wake events/IRQs, but we expect the OS/Linux to notify the

Re: [PATCH] clk: zynq: avoid retrieving clock names from DT property

On Sun, 2016-07-17 at 09:11:10 -0700, Sören Brinkmann wrote: > On Sun, 2016-07-17 at 00:15:23 +0900, Masahiro Yamada wrote: > > The "clock-output-names" property is useful for generic clock > > providers such as fixed-clock, fixed-factor-clock, etc. > > &

Re: [PATCH] clk: zynq: avoid retrieving clock names from DT property

On Sun, 2016-07-17 at 09:11:10 -0700, Sören Brinkmann wrote: > On Sun, 2016-07-17 at 00:15:23 +0900, Masahiro Yamada wrote: > > The "clock-output-names" property is useful for generic clock > > providers such as fixed-clock, fixed-factor-clock, etc. > > &

Re: [PATCH] clk: zynq: avoid retrieving clock names from DT property

On Sun, 2016-07-17 at 00:15:23 +0900, Masahiro Yamada wrote: > The "clock-output-names" property is useful for generic clock > providers such as fixed-clock, fixed-factor-clock, etc. > > On the other hand, it should not be used for really SoC-specific > clock providers like this one. As you see

Re: [PATCH] clk: zynq: avoid retrieving clock names from DT property

On Sun, 2016-07-17 at 00:15:23 +0900, Masahiro Yamada wrote: > The "clock-output-names" property is useful for generic clock > providers such as fixed-clock, fixed-factor-clock, etc. > > On the other hand, it should not be used for really SoC-specific > clock providers like this one. As you see

Re: [PATCH] PCI: xilinx: Fix return value in case of error

of error is always 0, which means 'success'. > Change it to return -ENODEV instead. > > Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Acked-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Sören

Re: [PATCH] PCI: xilinx: Fix return value in case of error

of error is always 0, which means 'success'. > Change it to return -ENODEV instead. > > Signed-off-by: Christophe JAILLET Acked-by: Sören Brinkmann Sören

Re: [PATCH] clocksource: cadence_ttc: fix a return value in case of error

On Wed, 2016-07-06 at 07:35:23 +0200, Christophe JAILLET wrote: > IS_ERR and PTR_ERR should use the same variable, clk_ce in this case. > > Fixes: 4de1eb07c47f (Convert init function to return error) > > Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> Acke

Re: [PATCH] clocksource: cadence_ttc: fix a return value in case of error

On Wed, 2016-07-06 at 07:35:23 +0200, Christophe JAILLET wrote: > IS_ERR and PTR_ERR should use the same variable, clk_ce in this case. > > Fixes: 4de1eb07c47f (Convert init function to return error) > > Signed-off-by: Christophe JAILLET Acked-by: Sören Brinkmann Sören

Re: [PATCH V2 07/63] clocksource/drivers/cadence_ttc: Convert init function to return error

thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano <daniel.lezc...@linaro.org> Acked-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Sören

Re: [PATCH V2 07/63] clocksource/drivers/cadence_ttc: Convert init function to return error

thus this change just return back an error or success in the init > function. > > Signed-off-by: Daniel Lezcano Acked-by: Sören Brinkmann Sören

Re: [PATCH 7/9] pinctrl: zynq: make it explicitly non-modular

s unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Linus Walleij <linus.wall...@linaro

Re: [PATCH 7/9] pinctrl: zynq: make it explicitly non-modular

s unchanged with > this commit. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Linus Walleij > Cc: Michal Sime

Re: [PATCH 7/9] clocksource/drivers/cadence_ttc: Convert init function to return error

Hi Daniel, On Wed, 2016-06-01 at 10:34:50 +0200, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and >make the system boot up correctly > > or > > - print an error

Re: [PATCH 7/9] clocksource/drivers/cadence_ttc: Convert init function to return error

Hi Daniel, On Wed, 2016-06-01 at 10:34:50 +0200, Daniel Lezcano wrote: > The init functions do not return any error. They behave as the following: > > - panic, thus leading to a kernel crash while another timer may work and >make the system boot up correctly > > or > > - print an error

Re: [PATCH 2/5] dmaengine: vdma: Use dma_pool_zalloc

; > @@ > > d = > -dma_pool_alloc > +dma_pool_zalloc > (...); > if (!d) S > - memset(d, 0, sizeof(*d)); > // > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Acked-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Sören

Re: [PATCH 2/5] dmaengine: vdma: Use dma_pool_zalloc

; > @@ > > d = > -dma_pool_alloc > +dma_pool_zalloc > (...); > if (!d) S > - memset(d, 0, sizeof(*d)); > // > > Signed-off-by: Julia Lawall Acked-by: Sören Brinkmann Sören

Re: [PATCH v2 6/6] mmc: sdhci-of-arasan: overwrite enhanced strobe callback

SAN_VENDOR_REGISTER 0x78 Just as a note: This register doesn't seem to exist in the IP version Zynq is using. So, as long as we exclude that version from accessing it, things should be fine (IIUC, that is the case). Acked-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Sören

Re: [PATCH v2 6/6] mmc: sdhci-of-arasan: overwrite enhanced strobe callback

a note: This register doesn't seem to exist in the IP version Zynq is using. So, as long as we exclude that version from accessing it, things should be fine (IIUC, that is the case). Acked-by: Sören Brinkmann Sören

Re: [PATCH v3 3/3] dmaengine: vdma: Add clock support

On Thu, 2016-04-21 at 09:32:44 -0700, Appana Durga Kedareswara Rao wrote: > Hi Soren, > > > -Original Message- > > From: Sören Brinkmann [mailto:soren.brinkm...@xilinx.com] > > Sent: Thursday, April 21, 2016 9:52 PM > > To: Appana Durga Kedareswara Rao <

Re: [PATCH v3 3/3] dmaengine: vdma: Add clock support

On Thu, 2016-04-21 at 09:32:44 -0700, Appana Durga Kedareswara Rao wrote: > Hi Soren, > > > -Original Message- > > From: Sören Brinkmann [mailto:soren.brinkm...@xilinx.com] > > Sent: Thursday, April 21, 2016 9:52 PM > > To: Appana Durga Kedareswara Rao >

Re: [PATCH v3 3/3] dmaengine: vdma: Add clock support

On Thu, 2016-04-21 at 16:08:38 +0530, Kedareswara rao Appana wrote: > Added basic clock support for axi dma's. > The clocks are requested at probe and released at remove. > > Reviewed-by: Shubhrajyoti Datta > Signed-off-by: Kedareswara rao Appana > --- >

Re: [PATCH v3 3/3] dmaengine: vdma: Add clock support

On Thu, 2016-04-21 at 16:08:38 +0530, Kedareswara rao Appana wrote: > Added basic clock support for axi dma's. > The clocks are requested at probe and released at remove. > > Reviewed-by: Shubhrajyoti Datta > Signed-off-by: Kedareswara rao Appana > --- > Changes for v3: > ---> Added clock

Re: [PATCH v2 2/2] dmaengine: vdma: Add clock support

On Wed, 2016-04-20 at 07:55:27 -0700, Appana Durga Kedareswara Rao wrote: > Hi Soren, > > > -Original Message- > > From: Sören Brinkmann [mailto:soren.brinkm...@xilinx.com] > > Sent: Wednesday, April 20, 2016 8:06 PM > > To: Appana Durga Kedareswara Rao <

Re: [PATCH v2 2/2] dmaengine: vdma: Add clock support

On Wed, 2016-04-20 at 07:55:27 -0700, Appana Durga Kedareswara Rao wrote: > Hi Soren, > > > -Original Message- > > From: Sören Brinkmann [mailto:soren.brinkm...@xilinx.com] > > Sent: Wednesday, April 20, 2016 8:06 PM > > To: Appana Durga Kedareswara R

Re: [PATCH v2 2/2] dmaengine: vdma: Add clock support

On Wed, 2016-04-20 at 17:13:19 +0530, Kedareswara rao Appana wrote: > Added basic clock support. The clocks are requested at probe > and released at remove. > > Signed-off-by: Kedareswara rao Appana > --- > Changes for v2: > --> None. > > drivers/dma/xilinx/xilinx_vdma.c |

Re: [PATCH v2 2/2] dmaengine: vdma: Add clock support

On Wed, 2016-04-20 at 17:13:19 +0530, Kedareswara rao Appana wrote: > Added basic clock support. The clocks are requested at probe > and released at remove. > > Signed-off-by: Kedareswara rao Appana > --- > Changes for v2: > --> None. > > drivers/dma/xilinx/xilinx_vdma.c | 56 >

Re: [PATCH v2 1/2] Documentation: DT: vdma: Add clock support for vdma

to common clock bindings. > +- clock-names: List of input clocks "s_axi_lite_aclk", "m_axi_mm2s_aclk" > +"m_axi_s2mm_aclk", "m_axis_mm2s_aclk", "s_axis_s2mm_aclk" > +(list of input cloks may vary based on the ip configuration. s/cloks/clocks Acked-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Sören

Re: [PATCH v2 1/2] Documentation: DT: vdma: Add clock support for vdma

> +- clock-names: List of input clocks "s_axi_lite_aclk", "m_axi_mm2s_aclk" > +"m_axi_s2mm_aclk", "m_axis_mm2s_aclk", "s_axis_s2mm_aclk" > +(list of input cloks may vary based on the ip configuration. s/cloks/clocks Acked-by: Sören Brinkmann Sören

Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan

On Wed, 2016-04-06 at 22:13:59 +, Koul, Vinod wrote: > On Wed, 2016-04-06 at 23:16 +0200, Lars-Peter Clausen wrote: > > On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote: > > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > > > > +++ > > > > >

Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan

On Wed, 2016-04-06 at 22:13:59 +, Koul, Vinod wrote: > On Wed, 2016-04-06 at 23:16 +0200, Lars-Peter Clausen wrote: > > On 04/06/2016 06:25 PM, Appana Durga Kedareswara Rao wrote: > > > a/Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt > > > > > +++ > > > > >

Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan

On Wed, 2016-04-06 at 21:45:31 +0530, Kedareswara rao Appana wrote: > This patch renames the vdma-mm2s-channel/vdma-s2mm-channel > property with dma-mm2s-channel/dma-s2mm-channel to sync with > the driver. > > Signed-off-by: Kedareswara rao Appana > --- > Changes for v3: >

Re: [PATCH v3 1/5] Documentation: DT: vdma: Rename vdma-chan prefix to dma-chan

On Wed, 2016-04-06 at 21:45:31 +0530, Kedareswara rao Appana wrote: > This patch renames the vdma-mm2s-channel/vdma-s2mm-channel > property with dma-mm2s-channel/dma-s2mm-channel to sync with > the driver. > > Signed-off-by: Kedareswara rao Appana > --- > Changes for v3: > ---> New patch. > >

Re: [PATCH v2 5/6] Documentation: DT: vdma: update binding doc for AXI CDMA

On Sun, 2016-03-27 at 23:36:06 +0530, Kedareswara rao Appana wrote: > This patch updates the device-tree binding doc for > adding support for AXI CDMA. > > Signed-off-by: Kedareswara rao Appana > --- > ---> Modified commit message as suggested by Vinod. > ---> Moved the patch

Re: [PATCH v2 5/6] Documentation: DT: vdma: update binding doc for AXI CDMA

On Sun, 2016-03-27 at 23:36:06 +0530, Kedareswara rao Appana wrote: > This patch updates the device-tree binding doc for > adding support for AXI CDMA. > > Signed-off-by: Kedareswara rao Appana > --- > ---> Modified commit message as suggested by Vinod. > ---> Moved the patch to forward in the

Re: [PATCH v2 3/6] Documentation: DT: vdma: update binding doc for AXI DMA

On Sun, 2016-03-27 at 23:36:05 +0530, Kedareswara rao Appana wrote: > This patch updates the device-tree binding doc for > adding support for AXI DMA. > > Signed-off-by: Kedareswara rao Appana > --- > Changes for v2: > ---> Modified commit message as suggested by Vinod. >

Re: [PATCH v2 3/6] Documentation: DT: vdma: update binding doc for AXI DMA

On Sun, 2016-03-27 at 23:36:05 +0530, Kedareswara rao Appana wrote: > This patch updates the device-tree binding doc for > adding support for AXI DMA. > > Signed-off-by: Kedareswara rao Appana > --- > Changes for v2: > ---> Modified commit message as suggested by Vinod. > ---> Moved the patch to

Re: [PATCH 38/41] clk: si5{14,351,70}: Remove CLK_IS_ROOT

On Tue, 2016-03-01 at 11:00:23 -0800, Stephen Boyd wrote: > This flag is a no-op now. Remove usage of the flag. > > Cc: Sebastian Hesselbarth <sebastian.hesselba...@gmail.com> > Cc: Guenter Roeck <li...@roeck-us.net> > Cc: Sören Brinkmann <soren.brinkm...@xi

Re: [PATCH 38/41] clk: si5{14,351,70}: Remove CLK_IS_ROOT

On Tue, 2016-03-01 at 11:00:23 -0800, Stephen Boyd wrote: > This flag is a no-op now. Remove usage of the flag. > > Cc: Sebastian Hesselbarth > Cc: Guenter Roeck > Cc: Sören Brinkmann > Cc: Mike Looijmans > Signed-off-by: Stephen Boyd Reviewed-by: Sören Brink

Re: [PATCH 24/41] clk: zynq: Remove CLK_IS_ROOT

On Tue, 2016-03-01 at 11:00:09 -0800, Stephen Boyd wrote: > This flag is a no-op now. Remove usage of the flag. > > Cc: Sören Brinkmann <soren.brinkm...@xilinx.com> > Signed-off-by: Stephen Boyd <sb...@codeaurora.org> Reviewed-by: Sören Brinkmann <soren.brinkm...@

Re: [PATCH 24/41] clk: zynq: Remove CLK_IS_ROOT

On Tue, 2016-03-01 at 11:00:09 -0800, Stephen Boyd wrote: > This flag is a no-op now. Remove usage of the flag. > > Cc: Sören Brinkmann > Signed-off-by: Stephen Boyd Reviewed-by: Sören Brinkmann Thanks, Sören

Re: [RFC PATCH] ARM: clocksource: make ARM_GLOBAL_TIMER selectable

On Fri, 2016-02-26 at 15:03:19 +0200, Grygorii Strashko wrote: > On 02/05/2016 01:39 AM, Sören Brinkmann wrote: > > On Thu, 2016-02-04 at 15:14:47 -0800, Moritz Fischer wrote: > >> Hi Soeren, > >> > >> On Thu, Feb 4, 2016 at 2:41 PM, Sören Brinkmann >

Re: [RFC PATCH] ARM: clocksource: make ARM_GLOBAL_TIMER selectable

On Fri, 2016-02-26 at 15:03:19 +0200, Grygorii Strashko wrote: > On 02/05/2016 01:39 AM, Sören Brinkmann wrote: > > On Thu, 2016-02-04 at 15:14:47 -0800, Moritz Fischer wrote: > >> Hi Soeren, > >> > >> On Thu, Feb 4, 2016 at 2:41 PM, Sören Brinkmann > >

Re: [PATCH 50/50] pinctrl: zynq: Use devm_pinctrl_register() for pinctrl registration

On Wed, 2016-02-24 at 18:46:15 +0530, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and > remove the need of .remove callback. > > Signed-off-by: Laxman Dewangan <ldewan...@nvidia.com> > Cc: Michal Simek <michal.si...@xilinx.co

Re: [PATCH 50/50] pinctrl: zynq: Use devm_pinctrl_register() for pinctrl registration

On Wed, 2016-02-24 at 18:46:15 +0530, Laxman Dewangan wrote: > Use devm_pinctrl_register() for pin control registration and > remove the need of .remove callback. > > Signed-off-by: Laxman Dewangan > Cc: Michal Simek > Cc: Sören Brinkmann > Cc: linux-g...@vger.kernel.or

Re: [RFC PATCH] ARM: clocksource: make ARM_GLOBAL_TIMER selectable

On Thu, 2016-02-04 at 15:14:47 -0800, Moritz Fischer wrote: > Hi Soeren, > > On Thu, Feb 4, 2016 at 2:41 PM, Sören Brinkmann > wrote: > > > But with this change the 'if !CPU_FREQ' becomes obsolete. > I'm confused, could you explain that statement? You don't want peopl

Re: [RFC PATCH] ARM: clocksource: make ARM_GLOBAL_TIMER selectable

; Cc: Florian Fainelli > Cc: Russell King > Cc: Wei Xu > Cc: Shawn Guo > Cc: Sascha Hauer > Cc: Srinivas Kandagatla > Cc: Maxime Coquelin > Cc: Masahiro Yamada > Cc: Liviu Dudau > Cc: Sudeep Holla > Cc: Jun Nie > Cc: Michal Simek > Cc: "Sören Br

Re: [RFC PATCH] ARM: clocksource: make ARM_GLOBAL_TIMER selectable

On Thu, 2016-02-04 at 15:14:47 -0800, Moritz Fischer wrote: > Hi Soeren, > > On Thu, Feb 4, 2016 at 2:41 PM, Sören Brinkmann > <soren.brinkm...@xilinx.com> wrote: > > > But with this change the 'if !CPU_FREQ' becomes obsolete. > I'm confused, could you explain

Re: [RFC PATCH] ARM: clocksource: make ARM_GLOBAL_TIMER selectable

..@gmail.com> > Cc: Maxime Coquelin <maxime.coque...@st.com> > Cc: Masahiro Yamada <yamada.masah...@socionext.com> > Cc: Liviu Dudau <liviu.du...@arm.com> > Cc: Sudeep Holla <sudeep.ho...@arm.com> > Cc: Jun Nie <jun@linaro.org> > Cc: Michal Si

Re: [PATCH LINUX 0/6] Second part of xuartps fixes

nds on the patches mentioned above. It > includes several minor improvements and refactoring and the refactoring > of the IRQ management, which prevents lock ups that could happen when > RX-related IRQs fired while the receiver was disabled. > > Thanks, > Sören > > S

Re: [PATCH LINUX 0/6] Second part of xuartps fixes

nds on the patches mentioned above. It > includes several minor improvements and refactoring and the refactoring > of the IRQ management, which prevents lock ups that could happen when > RX-related IRQs fired while the receiver was disabled. > > Thanks, > Sören > > S

Re: [PATCH v4 05/13] mmc: sdhci-of-arasan: fix clk issue in sdhci_arasan_remove()

; > Signed-off-by: Jisheng Zhang Acked-by: Sören Brinkmann Sören

Re: [PATCH v4 05/13] mmc: sdhci-of-arasan: fix clk issue in sdhci_arasan_remove()

; > Signed-off-by: Jisheng Zhang <jszh...@marvell.com> Acked-by: Sören Brinkmann <soren.brinkm...@xilinx.com> Sören

Re: [RFC LINUX PATCH] dt: xilinx: xadc: provision to control clock frequency

On Wed, 2015-12-23 at 03:58PM +0530, Ranjit Waghmode wrote: > This patch adds parameter to the xilinx-xadc node for controlling > clock frequency. > > Following are the possible options for user to control the frequency: > * 00 : 1/2 of clock frequency > * 01 : 1/4 of clock frequency

Re: [RFC LINUX PATCH] dt: xilinx: xadc: provision to control clock frequency

On Wed, 2015-12-23 at 03:58PM +0530, Ranjit Waghmode wrote: > This patch adds parameter to the xilinx-xadc node for controlling > clock frequency. > > Following are the possible options for user to control the frequency: > * 00 : 1/2 of clock frequency > * 01 : 1/4 of clock frequency

  1   2   3   4   5   6   7   8   9   10   >