Re: [Industrypack-devel] [PATCH v1 1/2] ipack: Fail earlier for drivers without probe function

Hi Uwe, Thanks for the patches! Patch series is, Acked-by: Samuel Iglesias Gonsalvez Greg, Would you mind picking this patch series through your char-misc tree? Thanks! Sam On Sun, 2021-02-07 at 22:55 +0100, Uwe Kleine-König wrote: > A driver without a probe function isn't useful as it can

Re: [Industrypack-devel] [PATCH] ipack: iopctal: remove unneeded break

Hi Tom, Thanks for the patch! Patch is, Acked-by: Samuel Iglesias Gonsalvez Greg, Would you mind picking this patch through your char-misc tree? Thanks! Sam On Mon, 2020-10-19 at 12:32 -0700, t...@redhat.com wrote: > From: Tom Rix > > A break is not needed if it is preceded by a return >

Re: [PATCH -next] ipack: tpci200: fix error return code in tpci200_register()

Hello Wei, Thanks for the patch! Patch is, Acked-by: Samuel Iglesias Gonsalvez Greg, Would you mind picking this patch series through your char-misc tree? Thanks! Sam On Thu, 2020-05-07 at 09:42 +, Wei Yongjun wrote: > Fix to return negative error code -ENOMEM from the ioremap() error

[PATCH 2/2] ipack: Improve a size determination in ipack_bus_register()

d-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- drivers/ipack/ipack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c index 575c4f29e0f7..a1e07a77d4e

[PATCH 2/2] ipack: Improve a size determination in ipack_bus_register()

by: Samuel Iglesias Gonsálvez --- drivers/ipack/ipack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c index 575c4f29e0f7..a1e07a77d4e6 100644 --- a/drivers/ipack/ipack.c +++ b/drivers/ipack/ipack.c @@ -212,7 +212,7 @@ struct ipack_

[PATCH 1/2] ipack: Delete an error message for a failed memory allocation in ipack_device_read_id()

ed-off-by: Markus Elfring <elfr...@users.sourceforge.net> Acked-by: Samuel Iglesias Gonsálvez <sigles...@igalia.com> --- Greg, Would you mind picking this patch series through your char-misc tree? Sam drivers/ipack/ipack.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drive

[PATCH 1/2] ipack: Delete an error message for a failed memory allocation in ipack_device_read_id()

-by: Samuel Iglesias Gonsálvez --- Greg, Would you mind picking this patch series through your char-misc tree? Sam drivers/ipack/ipack.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/ipack/ipack.c b/drivers/ipack/ipack.c index 12102448fddd..575c4f29e0f7 100644 --- a/drivers/ipack

Re: [PATCH 2/2] ipack: Improve a size determination in ipack_bus_register()

Hello Markus, Thanks for the patches! Series is, Acked-by: Samuel Iglesias Gonsalvez Greg, Would you mind picking this patch series through your char-misc tree? Sam On Sat, 2017-05-13 at 10:56 +0200, SF Markus Elfring wrote: > From: Markus Elfring

Re: [PATCH 2/2] ipack: Improve a size determination in ipack_bus_register()

Hello Markus, Thanks for the patches! Series is, Acked-by: Samuel Iglesias Gonsalvez Greg, Would you mind picking this patch series through your char-misc tree? Sam On Sat, 2017-05-13 at 10:56 +0200, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 13 May 2017 10:37:06 +0200 >

Re: [PATCH 2/3] ipack: save carrier owner to allow device to get it

On Tue, 2014-09-02 at 17:31 +0200, Federico Vaga wrote: > There was not any kind of protection against carrier driver removal. > In this way, device driver can 'get' the carrier driver when it is > using it. > > Signed-off-by: Federico Vaga > --- > drivers/ipack/carriers/tpci200.c |3 ++- >

Re: [PATCH 1/3] ipoctal: reset function istead of duplicate code

On Tue, 2014-09-02 at 17:31 +0200, Federico Vaga wrote: > Signed-off-by: Federico Vaga > --- > drivers/ipack/devices/ipoctal.c | 35 ++- > 1 file changed, 14 insertions(+), 21 deletions(-) > > diff --git a/drivers/ipack/devices/ipoctal.c

Re: [PATCH 3/3] ipoctal: get carrier driver to avoid rmmod

On Tue, 2014-09-02 at 17:31 +0200, Federico Vaga wrote: > Signed-off-by: Federico Vaga > --- > drivers/ipack/devices/ipoctal.c | 30 +++--- > 1 file changed, 27 insertions(+), 3 deletions(-) > > diff --git a/drivers/ipack/devices/ipoctal.c

Re: [PATCH 3/3] ipoctal: get carrier driver to avoid rmmod

On Tue, 2014-09-02 at 17:31 +0200, Federico Vaga wrote: Signed-off-by: Federico Vaga federico.v...@cern.ch --- drivers/ipack/devices/ipoctal.c | 30 +++--- 1 file changed, 27 insertions(+), 3 deletions(-) diff --git a/drivers/ipack/devices/ipoctal.c

Re: [PATCH 2/3] ipack: save carrier owner to allow device to get it

On Tue, 2014-09-02 at 17:31 +0200, Federico Vaga wrote: There was not any kind of protection against carrier driver removal. In this way, device driver can 'get' the carrier driver when it is using it. Signed-off-by: Federico Vaga federico.v...@cern.ch ---

Re: [PATCH 1/3] ipoctal: reset function istead of duplicate code

On Tue, 2014-09-02 at 17:31 +0200, Federico Vaga wrote: Signed-off-by: Federico Vaga federico.v...@cern.ch --- drivers/ipack/devices/ipoctal.c | 35 ++- 1 file changed, 14 insertions(+), 21 deletions(-) diff --git a/drivers/ipack/devices/ipoctal.c

Re: [PATCH] ipoctal: clear break interrupt as soon as it occurs

On Mon, 2014-09-01 at 13:49 +0200, Federico Vaga wrote: > In some condition we receive the break interrupt but nothing is putted > in the Rx FIFO and the correspondend bit in the status register is not > set. Thus, no-one clear the interrupt and the handler will be called > forever. > > This

Re: [PATCH] ipoctal: clear break interrupt as soon as it occurs

On Mon, 2014-09-01 at 13:49 +0200, Federico Vaga wrote: In some condition we receive the break interrupt but nothing is putted in the Rx FIFO and the correspondend bit in the status register is not set. Thus, no-one clear the interrupt and the handler will be called forever. This patch

Re: [PATCH] drivers/ipack/devices/ipoctal.h: Fix typo in include guard

On 2014-08-22 14:09, Rasmus Villemoes wrote: Signed-off-by: Rasmus Villemoes --- drivers/ipack/devices/ipoctal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ipack/devices/ipoctal.h b/drivers/ipack/devices/ipoctal.h index 28f1c42..7fede0e 100644 ---

Re: [PATCH] drivers/ipack/devices/ipoctal.h: Fix typo in include guard

On 2014-08-22 14:09, Rasmus Villemoes wrote: Signed-off-by: Rasmus Villemoes li...@rasmusvillemoes.dk --- drivers/ipack/devices/ipoctal.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ipack/devices/ipoctal.h b/drivers/ipack/devices/ipoctal.h index

Re: [PATCH 25/25] ipack: Replace DEFINE_PCI_DEVICE_TABLE macro use

On Fri, 2014-07-18 at 17:27 +0200, Benoit Taine wrote: > We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet > kernel coding style guidelines. This issue was reported by checkpatch. > > Signed-off-by: Benoit Taine > > --- > Tested by compilation without errors. > >

Re: [PATCH 25/25] ipack: Replace DEFINE_PCI_DEVICE_TABLE macro use

On Fri, 2014-07-18 at 17:27 +0200, Benoit Taine wrote: We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to meet kernel coding style guidelines. This issue was reported by checkpatch. Signed-off-by: Benoit Taine benoit.ta...@lip6.fr --- Tested by compilation without

Re: [PATCH] ipoctal: request_irq after configuration

On Thu, 2014-07-03 at 10:53 +0200, Federico Vaga wrote: > The request for an IRQ handler must be done after whole configuration. This > was not the case for this driver which request the IRQ in the middle of > the configuration. Sometimes, it happens that something is not completely > configured,

Re: [Industrypack-devel] [PATCH] ipoctal: protect only the real critical section

On Thu, 2014-06-26 at 09:52 +0200, Samuel Iglesias Gonsálvez wrote: > On Thu, 2014-06-26 at 09:46 +0200, Federico Vaga wrote: > > In some conditions (echo or particular sequence of special > > characters), on buffer push, the tty layer calls the write operation > >

Re: [Industrypack-devel] [PATCH] ipoctal: protect only the real critical section

On Thu, 2014-06-26 at 09:52 +0200, Samuel Iglesias Gonsálvez wrote: On Thu, 2014-06-26 at 09:46 +0200, Federico Vaga wrote: In some conditions (echo or particular sequence of special characters), on buffer push, the tty layer calls the write operation while we are holding the spinlock

Re: [PATCH] ipoctal: request_irq after configuration

On Thu, 2014-07-03 at 10:53 +0200, Federico Vaga wrote: The request for an IRQ handler must be done after whole configuration. This was not the case for this driver which request the IRQ in the middle of the configuration. Sometimes, it happens that something is not completely configured, we

Re: [PATCH] ipoctal: protect only the real critical section

On Thu, 2014-06-26 at 09:46 +0200, Federico Vaga wrote: > In some conditions (echo or particular sequence of special > characters), on buffer push, the tty layer calls the write operation > while we are holding the spinlock. This means deadlock within the same > process on kernels version < 3.12.

Re: [PATCH] ipoctal: protect only the real critical section

On Thu, 2014-06-26 at 09:46 +0200, Federico Vaga wrote: In some conditions (echo or particular sequence of special characters), on buffer push, the tty layer calls the write operation while we are holding the spinlock. This means deadlock within the same process on kernels version 3.12. It

Re: [PATCH 2/8] ipack: convert bus code to use dev_groups

On lun, 2013-10-07 at 18:27 -0700, Greg Kroah-Hartman wrote: > The dev_attrs field of struct bus_type is going away soon, dev_groups > should be used instead. This converts the ipack bus code to use the > correct field. > > Cc: Samuel Iglesias Gonsalvez > Cc: Jens Taprogge > Cc: >

Re: [PATCH 2/8] ipack: convert bus code to use dev_groups

On lun, 2013-10-07 at 18:27 -0700, Greg Kroah-Hartman wrote: The dev_attrs field of struct bus_type is going away soon, dev_groups should be used instead. This converts the ipack bus code to use the correct field. Cc: Samuel Iglesias Gonsalvez sigles...@igalia.com Cc: Jens Taprogge

Re: [PATCH 1/3] ipack: avoid double free on device->id

On Fri, Mar 08, 2013 at 11:36:24AM -0800, Greg Kroah-Hartman wrote: [...] > If the others require this one to be applied, in order for them to apply > properly, yes, it would be great to resend. If not, I'll just skip the > first one. > They don't require the first one. You can skip it. Thanks,

Re: [PATCH 1/3] ipack: avoid double free on device-id

On Fri, Mar 08, 2013 at 11:36:24AM -0800, Greg Kroah-Hartman wrote: [...] If the others require this one to be applied, in order for them to apply properly, yes, it would be great to resend. If not, I'll just skip the first one. They don't require the first one. You can skip it. Thanks,

Re: [PATCH 1/3] ipack: avoid double free on device->id

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 03/08/2013 06:47 PM, Greg Kroah-Hartman wrote: > On Fri, Mar 08, 2013 at 09:21:45AM +0100, Samuel Iglesias > Gonsalvez wrote: >> Signed-off-by: Samuel Iglesias Gonsalvez >> --- drivers/ipack/ipack.c |1 + 1 file changed, 1 >> insertion(+)

Re: [PATCH 1/3] ipack: avoid double free on device->id

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 03/08/2013 06:47 PM, Greg Kroah-Hartman wrote: Yes, you are right. It's not possible to have it freed twice once it's in ipack_device_release(). You can skip this patch. If you want, I can resend the others accordingly. Sam -BEGIN PGP

Re: [PATCH 1/3] ipack: avoid double free on device-id

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 03/08/2013 06:47 PM, Greg Kroah-Hartman wrote: Yes, you are right. It's not possible to have it freed twice once it's in ipack_device_release(). You can skip this patch. If you want, I can resend the others accordingly. Sam -BEGIN PGP

Re: [PATCH 1/3] ipack: avoid double free on device-id

-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 03/08/2013 06:47 PM, Greg Kroah-Hartman wrote: On Fri, Mar 08, 2013 at 09:21:45AM +0100, Samuel Iglesias Gonsalvez wrote: Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com --- drivers/ipack/ipack.c |1 + 1 file changed, 1

Re: [PATCH] ipack: add missing put_device() after device_register() failed

Hello Dmitry, First of all, thanks for your comments. On 02/26/2013 11:28 PM, Dmitry Torokhov wrote: > On Tue, Feb 26, 2013 at 10:03:15AM +0100, Samuel Iglesias Gonsalvez wrote: >> put_device() must be called after device_register() fails, >> since device_register() always initializes the

Re: [PATCH] ipack: add missing put_device() after device_register() failed

Hello Dmitry, First of all, thanks for your comments. On 02/26/2013 11:28 PM, Dmitry Torokhov wrote: On Tue, Feb 26, 2013 at 10:03:15AM +0100, Samuel Iglesias Gonsalvez wrote: put_device() must be called after device_register() fails, since device_register() always initializes the refcount

Re: [PATCH] ipack: move header files to include/linux

On Fri, 2012-11-16 at 10:08 -0800, Joe Perches wrote: > On Fri, 2012-11-16 at 18:34 +0100, Samuel Iglesias Gonsalvez wrote: > > Move ipack header files to include/linux/ directory where they belong to. > > Why do these belong in include/linux? They are used for other drivers that could be in

Re: [PATCH] ipack: move header files to include/linux

On Fri, 2012-11-16 at 18:48 +0100, Samuel Iglesias Gonsálvez wrote: > On Fri, 2012-11-16 at 09:44 -0800, Greg Kroah-Hartman wrote: > > On Fri, Nov 16, 2012 at 06:34:36PM +0100, Samuel Iglesias Gonsalvez wrote: > > > Move ipack header files to include/linux/ directory

Re: [PATCH] ipack: move header files to include/linux

On Fri, 2012-11-16 at 09:44 -0800, Greg Kroah-Hartman wrote: > On Fri, Nov 16, 2012 at 06:34:36PM +0100, Samuel Iglesias Gonsalvez wrote: > > Move ipack header files to include/linux/ directory where they belong to. > > > > Signed-off-by: Samuel Iglesias Gonsalvez > > --- > >

Re: [PATCH] ipack: move header files to include/linux

On Fri, 2012-11-16 at 09:44 -0800, Greg Kroah-Hartman wrote: On Fri, Nov 16, 2012 at 06:34:36PM +0100, Samuel Iglesias Gonsalvez wrote: Move ipack header files to include/linux/ directory where they belong to. Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com ---

Re: [PATCH] ipack: move header files to include/linux

On Fri, 2012-11-16 at 18:48 +0100, Samuel Iglesias Gonsálvez wrote: On Fri, 2012-11-16 at 09:44 -0800, Greg Kroah-Hartman wrote: On Fri, Nov 16, 2012 at 06:34:36PM +0100, Samuel Iglesias Gonsalvez wrote: Move ipack header files to include/linux/ directory where they belong to. Signed

Re: [PATCH] ipack: move header files to include/linux

On Fri, 2012-11-16 at 10:08 -0800, Joe Perches wrote: On Fri, 2012-11-16 at 18:34 +0100, Samuel Iglesias Gonsalvez wrote: Move ipack header files to include/linux/ directory where they belong to. Why do these belong in include/linux? They are used for other drivers that could be in other

Re: [PATCH 3/5] staging: ipack: remove irq field in struct ipack_device.

On Thu, 2012-09-13 at 13:01 +0300, Dan Carpenter wrote: > On Thu, Sep 13, 2012 at 11:46:26AM +0200, Samuel Iglesias Gonsalvez wrote: > > From: Jens Taprogge > > > > The field irq currently is identical to the slot number. It does not seem > > to > > have any real use. The number is written to

Re: [PATCH 4/5] Staging: ipack/devices/ipoctal: acknowledge BREAK condition.

On Thu, 2012-09-13 at 13:02 +0300, Dan Carpenter wrote: > On Thu, Sep 13, 2012 at 11:46:27AM +0200, Samuel Iglesias Gonsalvez wrote: > > Clear the BREAK flag from the ISR register. > > > > Signed-off-by: Samuel Iglesias Gonsalvez > > What are the user visible effects of this bugfix? > It

Re: linux-next: manual merge of the staging tree with the tty tree

On Thu, 2012-09-13 at 16:14 +1000, Stephen Rothwell wrote: > Hi Greg, > > Today's linux-next merge of the staging tree got a conflict in > drivers/staging/ipack/devices/ipoctal.c between commit 734cc1783816 > ("TTY: use tty_port_register_device") from the tty tree and commit > 2afb41d9d30d

Re: linux-next: manual merge of the staging tree with the tty tree

On Thu, 2012-09-13 at 16:14 +1000, Stephen Rothwell wrote: Hi Greg, Today's linux-next merge of the staging tree got a conflict in drivers/staging/ipack/devices/ipoctal.c between commit 734cc1783816 (TTY: use tty_port_register_device) from the tty tree and commit 2afb41d9d30d (Staging:

Re: [PATCH 4/5] Staging: ipack/devices/ipoctal: acknowledge BREAK condition.

On Thu, 2012-09-13 at 13:02 +0300, Dan Carpenter wrote: On Thu, Sep 13, 2012 at 11:46:27AM +0200, Samuel Iglesias Gonsalvez wrote: Clear the BREAK flag from the ISR register. Signed-off-by: Samuel Iglesias Gonsalvez sigles...@igalia.com What are the user visible effects of this bugfix?

Re: [PATCH 3/5] staging: ipack: remove irq field in struct ipack_device.

On Thu, 2012-09-13 at 13:01 +0300, Dan Carpenter wrote: On Thu, Sep 13, 2012 at 11:46:26AM +0200, Samuel Iglesias Gonsalvez wrote: From: Jens Taprogge jens.tapro...@taprogge.org The field irq currently is identical to the slot number. It does not seem to have any real use. The

Re: [PATCH 03/20] Staging: ipack/bridges/tpci200: provide new callbacks to tpci200

On Wed, 2012-09-12 at 14:28 +0200, Jens Taprogge wrote: [...] > Sam, > > can you please add the endianess-aware versions back? Patch attached. > > One of the earlier uses was not correct. Done! The patch will be submitted with the next batch. Thanks, Sam signature.asc Description: This

Re: [PATCH 03/20] Staging: ipack/bridges/tpci200: provide new callbacks to tpci200

On Wed, 2012-09-12 at 14:13 +0300, Dan Carpenter wrote: > On Wed, Sep 12, 2012 at 11:28:33AM +0200, Jens Taprogge wrote: > > On Tue, Sep 11, 2012 at 11:47:02AM +0300, Dan Carpenter wrote: > > > > +static int tpci200_get_clockrate(struct ipack_device *dev) > > > > +{ > > > > + struct

Re: [PATCH 03/20] Staging: ipack/bridges/tpci200: provide new callbacks to tpci200

On Wed, 2012-09-12 at 14:13 +0300, Dan Carpenter wrote: On Wed, Sep 12, 2012 at 11:28:33AM +0200, Jens Taprogge wrote: On Tue, Sep 11, 2012 at 11:47:02AM +0300, Dan Carpenter wrote: +static int tpci200_get_clockrate(struct ipack_device *dev) +{ + struct tpci200_board *tpci200

Re: [PATCH 03/20] Staging: ipack/bridges/tpci200: provide new callbacks to tpci200

On Wed, 2012-09-12 at 14:28 +0200, Jens Taprogge wrote: [...] Sam, can you please add the endianess-aware versions back? Patch attached. One of the earlier uses was not correct. Done! The patch will be submitted with the next batch. Thanks, Sam signature.asc Description: This is a

Re: [PATCH 08/20] Staging: ipack: Switch to 8MHz operation before reading ID.

On Tue, 2012-09-11 at 13:39 +0200, Jens Taprogge wrote: > On Tue, Sep 11, 2012 at 01:31:06PM +0200, Samuel Iglesias Gonsálvez wrote: > > On Tue, 2012-09-11 at 11:48 +0300, Dan Carpenter wrote: > > > On Mon, Sep 10, 2012 at 10:51:46AM +0200, Samuel Iglesias Gonsálvez wrote:

[PATCH v2 02/20] Staging: ipack: Provide several carrier callbacks.

From: Jens Taprogge We provide callbacks to: - set/get the clockrate a module is accessed at, - get the error state of a slot, - get/reset the timeout state of a slot. Signed-off-by: Jens Taprogge Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/ipack.h | 15

[PATCH v2 04/20] Staging: ipack: Obtain supported speeds from ID ROM.

From: Jens Taprogge Signed-off-by: Jens Taprogge Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/ipack.c |6 ++ drivers/staging/ipack/ipack.h |2 ++ 2 files changed, 8 insertions(+) diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c

[PATCH v2 00/20] ipack: added callbacks and some cleanup

. Staging: ipack/bridges/tpci200: Store the irq holder in slot_irq. Samuel Iglesias Gonsálvez (10): Staging: ipack/bridges/tpci200: remove struct list_head Staging: ipack/bridges/tpci200: reorder the iounmap and pci_release_region Staging: ipack/bridges/tpci200: increment the reference

[PATCH v2 06/20] Staging: ipack: remove field driver from struct ipack_device.

From: Jens Taprogge After a successful match is found the driver field in struct device is set by the core device code. We can use this field. Signed-off-by: Jens Taprogge Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/ipack.c | 17 +++-- drivers/staging

[PATCH v2 09/20] Staging: ipack: reset previous timeouts during device registration.

From: Jens Taprogge Resetting the previous timeout we avoid to read the timeout status register and see timeout errors that don't correspond to the present state of the device. Signed-off-by: Jens Taprogge Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/ipack.c |2

[PATCH v2 08/20] Staging: ipack: Switch to 8MHz operation before reading ID.

From: Jens Taprogge Reading the ID space at 8 MHz is always supported. Most carriers will boot up in 8MHz mode. Still, play it safe and ensure we are operating at 8Mhz. Signed-off-by: Jens Taprogge Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/ipack.c | 11

[PATCH v2 07/20] Staging: ipack/bridges/tpci200: remove struct list_head

As the linked list was removed before, delete the useless struct list_head Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/bridges/tpci200.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/ipack/bridges/tpci200.h b/drivers/staging/ipack/bridges/tpci200

[PATCH v2 01/20] Staging: ipack/bridges/tpci200: Put the TPCI200 control registers into a struct.

From: Jens Taprogge This saves us from a little pointer arithmetic and cleans up the code a bit. Signed-off-by: Jens Taprogge Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/bridges/tpci200.c | 28 +++- drivers/staging/ipack/bridges/tpci200.h

[PATCH v2 03/20] Staging: ipack/bridges/tpci200: provide new callbacks to tpci200

From: Jens Taprogge Provide get_clockrate, set_clockrate, get_error, get_timeout and reset_timeout callbacks. Signed-off-by: Jens Taprogge Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/bridges/tpci200.c | 109 ++- 1 file changed, 108

[PATCH v2 10/20] Staging: ipack: check the device ID space CRC.

Taprogge Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/ipack.c | 59 - drivers/staging/ipack/ipack.h |1 + 2 files changed, 59 insertions(+), 1 deletion(-) diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack

[PATCH v2 15/20] Staging: ipack/devices/ipoctal: free the IRQ.

As the IRQ was requested by the driver, it should free it also. Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/devices/ipoctal.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/ipack/devices/ipoctal.c b/drivers/staging/ipack/devices/ipoctal.c index

[PATCH v2 12/20] Staging: ipack/bridges/tpci200: increment the reference counter of the pci_dev

As indicated in the documentation of pci_dev_get. Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/bridges/tpci200.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/ipack/bridges/tpci200.c b/drivers/staging/ipack/bridges/tpci200.c index 383571c

[PATCH v2 13/20] Staging: ipack/bridges/tpci200: fix the uninstall the ipack device

Using the call to the ipack_device_unregister() function to avoid the strange way it was doing, as the device model will take care of calling the bus's .remove function when a device is being unregistered. Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/bridges/tpci200.c

[PATCH v2 16/20] Staging: ipack: unregister devices when uninstall the carrier device.

Find the IP modules that are plugged to the carrier and unregister them. Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/ipack.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c index 26dc976

[PATCH v2 11/20] Staging: ipack/bridges/tpci200: reorder the iounmap and pci_release_region

Move iounmap and pci_release_region to tpci200_unregister(), as it is the place where the clean-up of the device is done. Also, renamed iounmap() to pci_iounmap() as the mapped region was requested from PCI bus. Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/bridges/tpci200

[PATCH v2 19/20] Staging: ipack: delete .remove_device() callback

As the IP module driver takes care of freeing its resources. Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/bridges/tpci200.c |1 - drivers/staging/ipack/ipack.h |3 --- 2 files changed, 4 deletions(-) diff --git a/drivers/staging/ipack/bridges/tpci200.c

[PATCH v2 14/20] Staging: ipack/devices/ipoctal: change exiting procedure

The ipoctal devices can be uninstalled from the ipack_driver_unregister() call as the device model calles the bus's .remove() function for each device registered by the driver and it will execute the .remove() function of the ipoctal driver. Signed-off-by: Samuel Iglesias Gonsálvez --- drivers

[PATCH v2 17/20] Staging: ipack/bridges/tpci200: delete ipack_device_unregister calls when exiting

As the ipack_bus_unregister() takes care of unregistering the devices plugged in the carrier, it is not needed to do it in the carrier driver. Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/bridges/tpci200.c |7 +-- 1 file changed, 1 insertion(+), 6 deletions

[PATCH v2 20/20] Staging: ipack/bridges/tpci200: Store the irq holder in slot_irq.

From: Jens Taprogge This way we do no longer need to keep a dangling pointer to struct ipack_device in tpci200_slot after the device has been removed. Signed-off-by: Jens Taprogge Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/bridges/tpci200.c | 19

[PATCH v2 18/20] Staging: ipack/bridges/tpci200: remove tpci200_slot_unregister

It is not needed as the IP module should free its IRQ using tpci200_free_irq callback. Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/bridges/tpci200.c | 26 +- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git a/drivers/staging/ipack

[PATCH v2 05/20] Staging: ipack: Choose the optimum bus speed by default.

From: Jens Taprogge Signed-off-by: Jens Taprogge Signed-off-by: Samuel Iglesias Gonsálvez --- drivers/staging/ipack/ipack.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack/ipack.c index c36ba9e..1ad73e5 100644 --- a/drivers

Re: [PATCH 08/20] Staging: ipack: Switch to 8MHz operation before reading ID.

On Tue, 2012-09-11 at 11:48 +0300, Dan Carpenter wrote: > On Mon, Sep 10, 2012 at 10:51:46AM +0200, Samuel Iglesias Gonsálvez wrote: > > From: Jens Taprogge > > > > Reading the ID space at 8 MHz is always supported. Most carriers will > > boot up in 8MHz mode. Still,

Re: [PATCH 20/20] Staging: ipack/bridges/tpci200: Store the irq holder in slot_irq.

On Tue, 2012-09-11 at 11:51 +0300, Dan Carpenter wrote: > The whole patchset looks good. > > Reviewed-by: Dan Carpenter > > regards, > dan carpenter Taking into account that I need to resend the patches, I can add these suggestions. Thanks for your revision, Sam signature.asc Description:

Re: [PATCH 01/20] Staging: ipack/bridges/tpci200: Put the TPCI200 control registers into a struct.

On Mon, 2012-09-10 at 11:29 -0700, Greg Kroah-Hartman wrote: > On Mon, Sep 10, 2012 at 10:51:39AM +0200, Samuel Iglesias Gonsálvez wrote: > > From: Jens Taprogge > > > > This saves us from a little pointer arithmetic and cleans up the code a bit. > > > > Signed-

Re: [PATCH 01/20] Staging: ipack/bridges/tpci200: Put the TPCI200 control registers into a struct.

On Mon, 2012-09-10 at 11:29 -0700, Greg Kroah-Hartman wrote: On Mon, Sep 10, 2012 at 10:51:39AM +0200, Samuel Iglesias Gonsálvez wrote: From: Jens Taprogge jens.tapro...@taprogge.org This saves us from a little pointer arithmetic and cleans up the code a bit. Signed-off-by: Jens

Re: [PATCH 20/20] Staging: ipack/bridges/tpci200: Store the irq holder in slot_irq.

On Tue, 2012-09-11 at 11:51 +0300, Dan Carpenter wrote: The whole patchset looks good. Reviewed-by: Dan Carpenter dan.carpen...@oracle.com regards, dan carpenter Taking into account that I need to resend the patches, I can add these suggestions. Thanks for your revision, Sam

Re: [PATCH 08/20] Staging: ipack: Switch to 8MHz operation before reading ID.

On Tue, 2012-09-11 at 11:48 +0300, Dan Carpenter wrote: On Mon, Sep 10, 2012 at 10:51:46AM +0200, Samuel Iglesias Gonsálvez wrote: From: Jens Taprogge jens.tapro...@taprogge.org Reading the ID space at 8 MHz is always supported. Most carriers will boot up in 8MHz mode. Still, play

[PATCH v2 05/20] Staging: ipack: Choose the optimum bus speed by default.

From: Jens Taprogge jens.tapro...@taprogge.org Signed-off-by: Jens Taprogge jens.tapro...@taprogge.org Signed-off-by: Samuel Iglesias Gonsálvez sigles...@igalia.com --- drivers/staging/ipack/ipack.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/ipack/ipack.c b

[PATCH v2 20/20] Staging: ipack/bridges/tpci200: Store the irq holder in slot_irq.

From: Jens Taprogge jens.tapro...@taprogge.org This way we do no longer need to keep a dangling pointer to struct ipack_device in tpci200_slot after the device has been removed. Signed-off-by: Jens Taprogge jens.tapro...@taprogge.org Signed-off-by: Samuel Iglesias Gonsálvez sigles...@igalia.com

[PATCH v2 18/20] Staging: ipack/bridges/tpci200: remove tpci200_slot_unregister

It is not needed as the IP module should free its IRQ using tpci200_free_irq callback. Signed-off-by: Samuel Iglesias Gonsálvez sigles...@igalia.com --- drivers/staging/ipack/bridges/tpci200.c | 26 +- 1 file changed, 1 insertion(+), 25 deletions(-) diff --git

[PATCH v2 17/20] Staging: ipack/bridges/tpci200: delete ipack_device_unregister calls when exiting

As the ipack_bus_unregister() takes care of unregistering the devices plugged in the carrier, it is not needed to do it in the carrier driver. Signed-off-by: Samuel Iglesias Gonsálvez sigles...@igalia.com --- drivers/staging/ipack/bridges/tpci200.c |7 +-- 1 file changed, 1 insertion

[PATCH v2 14/20] Staging: ipack/devices/ipoctal: change exiting procedure

The ipoctal devices can be uninstalled from the ipack_driver_unregister() call as the device model calles the bus's .remove() function for each device registered by the driver and it will execute the .remove() function of the ipoctal driver. Signed-off-by: Samuel Iglesias Gonsálvez sigles

[PATCH v2 19/20] Staging: ipack: delete .remove_device() callback

As the IP module driver takes care of freeing its resources. Signed-off-by: Samuel Iglesias Gonsálvez sigles...@igalia.com --- drivers/staging/ipack/bridges/tpci200.c |1 - drivers/staging/ipack/ipack.h |3 --- 2 files changed, 4 deletions(-) diff --git a/drivers/staging/ipack

[PATCH v2 11/20] Staging: ipack/bridges/tpci200: reorder the iounmap and pci_release_region

Move iounmap and pci_release_region to tpci200_unregister(), as it is the place where the clean-up of the device is done. Also, renamed iounmap() to pci_iounmap() as the mapped region was requested from PCI bus. Signed-off-by: Samuel Iglesias Gonsálvez sigles...@igalia.com --- drivers/staging

[PATCH v2 16/20] Staging: ipack: unregister devices when uninstall the carrier device.

Find the IP modules that are plugged to the carrier and unregister them. Signed-off-by: Samuel Iglesias Gonsálvez sigles...@igalia.com --- drivers/staging/ipack/ipack.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/staging/ipack/ipack.c b/drivers/staging/ipack

[PATCH v2 13/20] Staging: ipack/bridges/tpci200: fix the uninstall the ipack device

Using the call to the ipack_device_unregister() function to avoid the strange way it was doing, as the device model will take care of calling the bus's .remove function when a device is being unregistered. Signed-off-by: Samuel Iglesias Gonsálvez sigles...@igalia.com --- drivers/staging/ipack

[PATCH v2 12/20] Staging: ipack/bridges/tpci200: increment the reference counter of the pci_dev

As indicated in the documentation of pci_dev_get. Signed-off-by: Samuel Iglesias Gonsálvez sigles...@igalia.com --- drivers/staging/ipack/bridges/tpci200.c |3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/staging/ipack/bridges/tpci200.c b/drivers/staging/ipack/bridges/tpci200.c

[PATCH v2 15/20] Staging: ipack/devices/ipoctal: free the IRQ.

As the IRQ was requested by the driver, it should free it also. Signed-off-by: Samuel Iglesias Gonsálvez sigles...@igalia.com --- drivers/staging/ipack/devices/ipoctal.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/ipack/devices/ipoctal.c b/drivers/staging/ipack

[PATCH v2 10/20] Staging: ipack: check the device ID space CRC.

CRCs. Signed-off-by: Jens Taprogge jens.tapro...@taprogge.org Signed-off-by: Samuel Iglesias Gonsálvez sigles...@igalia.com --- drivers/staging/ipack/ipack.c | 59 - drivers/staging/ipack/ipack.h |1 + 2 files changed, 59 insertions(+), 1 deletion

[PATCH v2 03/20] Staging: ipack/bridges/tpci200: provide new callbacks to tpci200

From: Jens Taprogge jens.tapro...@taprogge.org Provide get_clockrate, set_clockrate, get_error, get_timeout and reset_timeout callbacks. Signed-off-by: Jens Taprogge jens.tapro...@taprogge.org Signed-off-by: Samuel Iglesias Gonsálvez sigles...@igalia.com --- drivers/staging/ipack/bridges

[PATCH v2 01/20] Staging: ipack/bridges/tpci200: Put the TPCI200 control registers into a struct.

From: Jens Taprogge jens.tapro...@taprogge.org This saves us from a little pointer arithmetic and cleans up the code a bit. Signed-off-by: Jens Taprogge jens.tapro...@taprogge.org Signed-off-by: Samuel Iglesias Gonsálvez sigles...@igalia.com --- drivers/staging/ipack/bridges/tpci200.c | 28

[PATCH v2 07/20] Staging: ipack/bridges/tpci200: remove struct list_head

As the linked list was removed before, delete the useless struct list_head Signed-off-by: Samuel Iglesias Gonsálvez sigles...@igalia.com --- drivers/staging/ipack/bridges/tpci200.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/ipack/bridges/tpci200.h b/drivers/staging

[PATCH v2 08/20] Staging: ipack: Switch to 8MHz operation before reading ID.

From: Jens Taprogge jens.tapro...@taprogge.org Reading the ID space at 8 MHz is always supported. Most carriers will boot up in 8MHz mode. Still, play it safe and ensure we are operating at 8Mhz. Signed-off-by: Jens Taprogge jens.tapro...@taprogge.org Signed-off-by: Samuel Iglesias Gonsálvez

[PATCH v2 09/20] Staging: ipack: reset previous timeouts during device registration.

From: Jens Taprogge jens.tapro...@taprogge.org Resetting the previous timeout we avoid to read the timeout status register and see timeout errors that don't correspond to the present state of the device. Signed-off-by: Jens Taprogge jens.tapro...@taprogge.org Signed-off-by: Samuel Iglesias

[PATCH v2 06/20] Staging: ipack: remove field driver from struct ipack_device.

From: Jens Taprogge jens.tapro...@taprogge.org After a successful match is found the driver field in struct device is set by the core device code. We can use this field. Signed-off-by: Jens Taprogge jens.tapro...@taprogge.org Signed-off-by: Samuel Iglesias Gonsálvez sigles...@igalia.com

[PATCH v2 00/20] ipack: added callbacks and some cleanup

. Staging: ipack/bridges/tpci200: Store the irq holder in slot_irq. Samuel Iglesias Gonsálvez (10): Staging: ipack/bridges/tpci200: remove struct list_head Staging: ipack/bridges/tpci200: reorder the iounmap and pci_release_region Staging: ipack/bridges/tpci200: increment the reference

  1   2   >