Re: [PATCH][REGRESSION] drm: kirin: Fix drm_of_find_panel_or_bridge conversion

his oneline patch fixes it and gets graphics working again. >>> >>> Cc: Rob Herring <r...@kernel.org> >>> Cc: Archit Taneja <arch...@codeaurora.org> >>> Cc: Philipp Zabel <p.za...@pengutronix.de> >>> Cc: Maxime Ripard <maxime.rip...@free

Re: [PATCH][REGRESSION] drm: kirin: Fix drm_of_find_panel_or_bridge conversion

rivers to use drm_of_find_panel_or_bridge") that was >>> recently merged, causing HDMI output to not work. >>> >>> For the kirin driver, the port value should be 1 instead of 0, >>> so this oneline patch fixes it and gets graphics working again. >>> >>> Cc:

Re: [PATCH] drm: remove writeq/readq function definitions

ne void writeq(u64 val, void __iomem *reg) > -{ > - writel(val & 0x, reg); > - writel(val >> 32, reg + 0x4UL); > -} > -#endif > +#include > > /** Current process ID */ > #define DRM_CURRENTPID task_pid_nr(current) > -- > 2.13.0 -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] drm: remove writeq/readq function definitions

mem *reg) > -{ > - writel(val & 0x, reg); > - writel(val >> 32, reg + 0x4UL); > -} > -#endif > +#include > > /** Current process ID */ > #define DRM_CURRENTPID task_pid_nr(current) > -- > 2.13.0 -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] drm/rockchip: Don't allow zero sized gem buffer

On Fri, May 26, 2017 at 10:30:09AM +0800, jeffy wrote: > Hi sean, > > On 05/25/2017 11:30 PM, Sean Paul wrote: > > On Tue, May 23, 2017 at 02:39:43PM +0800, Jeffy Chen wrote: > > > The system would crash when trying to alloc zero sized gem buffer: > > > [6.712

Re: [PATCH] drm/rockchip: Don't allow zero sized gem buffer

On Fri, May 26, 2017 at 10:30:09AM +0800, jeffy wrote: > Hi sean, > > On 05/25/2017 11:30 PM, Sean Paul wrote: > > On Tue, May 23, 2017 at 02:39:43PM +0800, Jeffy Chen wrote: > > > The system would crash when trying to alloc zero sized gem buffer: > > > [6.712

Re: [PATCH] drm/rockchip: Don't allow zero sized gem buffer

DRM_ERROR("gem buffer size is zero\n"); > + return ERR_PTR(-EINVAL); > + } > + > size = round_up(size, PAGE_SIZE); > > rk_obj = kzalloc(sizeof(*rk_obj), GFP_KERNEL); > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] drm/rockchip: Don't allow zero sized gem buffer

zero\n"); > + return ERR_PTR(-EINVAL); > + } > + > size = round_up(size, PAGE_SIZE); > > rk_obj = kzalloc(sizeof(*rk_obj), GFP_KERNEL); > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] gpu: host1x: select IOMMU_IOVA

st1x driver" > > depends on ARCH_TEGRA || (ARM && COMPILE_TEST) > > + select IOMMU_IOVA if IOMMU_SUPPORT > > help > > Driver for the NVIDIA Tegra host1x hardware. > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-tegra" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] gpu: host1x: select IOMMU_IOVA

ARCH_TEGRA || (ARM && COMPILE_TEST) > > + select IOMMU_IOVA if IOMMU_SUPPORT > > help > > Driver for the NVIDIA Tegra host1x hardware. > > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-tegra" in > the body of a message to majord...@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Sean Paul, Software Engineer, Google / Chromium OS

Re: GPU-DRM-STI: Fine-tuning for some function implementations

new contributors to get started with kernel development. I find less value in these patches if they're from someone seemingly trying to rack up patch count. Sean > > Regards, > Markus -- Sean Paul, Software Engineer, Google / Chromium OS

Re: GPU-DRM-STI: Fine-tuning for some function implementations

new contributors to get started with kernel development. I find less value in these patches if they're from someone seemingly trying to rack up patch count. Sean > > Regards, > Markus -- Sean Paul, Software Engineer, Google / Chromium OS

Re: GPU-DRM-STI: Fine-tuning for some function implementations

s. In that case, I wouldn't mind dealing with breakage since we'll benefit from their contributions in the future. With your changes, we don't have this upside. Sean > > Regards, > Markus -- Sean Paul, Software Engineer, Google / Chromium OS

Re: GPU-DRM-STI: Fine-tuning for some function implementations

s. In that case, I wouldn't mind dealing with breakage since we'll benefit from their contributions in the future. With your changes, we don't have this upside. Sean > > Regards, > Markus -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH 0/5] GPU-DRM-STI: Fine-tuning for some function implementations

drm/sti/sti_vid.c| 5 ++--- > 9 files changed, 26 insertions(+), 39 deletions(-) > > -- > 2.12.2 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH 0/5] GPU-DRM-STI: Fine-tuning for some function implementations

9 files changed, 26 insertions(+), 39 deletions(-) > > -- > 2.12.2 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] drm/rockchip: analogix_dp: Remove unused check and variables

void analogix_dp_psr_work(struct work_struct *work) > } > > spin_lock_irqsave(>psr_lock, flags); > - if (psr_state == EDP_VSC_PSR_STATE_ACTIVE) > + if (dp->psr_state == EDP_VSC_PSR_STATE_ACTIVE) > analogix_dp_enable_psr(dp->dev); > else > analogix_dp_disable_psr(dp->dev); > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] drm/rockchip: analogix_dp: Remove unused check and variables

) > } > > spin_lock_irqsave(>psr_lock, flags); > - if (psr_state == EDP_VSC_PSR_STATE_ACTIVE) > + if (dp->psr_state == EDP_VSC_PSR_STATE_ACTIVE) > analogix_dp_enable_psr(dp->dev); > else > analogix_dp_disable_psr(dp->dev); > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v2] drm/rockchip: Set line flag config register in vop_crtc_enable

> > reinit_completion(>line_flag_completion); > - vop_line_flag_irq_enable(vop, line_num); > + vop_line_flag_irq_enable(vop); > > jiffies_left = wait_for_completion_timeout(>line_flag_completion, > msecs_to_jiffies(mstimeout)); > @@ -1547,7 +1545,7 @@ int rockchip_drm_wait_line_flag(struct drm_crtc *crtc, > unsigned int line_num, > > return 0; > } > -EXPORT_SYMBOL(rockchip_drm_wait_line_flag); > +EXPORT_SYMBOL(rockchip_drm_wait_vact_end); > > static int vop_bind(struct device *dev, struct device *master, void *data) > { > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v2] drm/rockchip: Set line flag config register in vop_crtc_enable

on(>line_flag_completion); > - vop_line_flag_irq_enable(vop, line_num); > + vop_line_flag_irq_enable(vop); > > jiffies_left = wait_for_completion_timeout(>line_flag_completion, > msecs_to_jiffies(mstimeout)); > @@ -1547,7 +1545,7 @@ int rockchip_drm_wait_line_flag(struct drm_crtc *crtc, > unsigned int line_num, > > return 0; > } > -EXPORT_SYMBOL(rockchip_drm_wait_line_flag); > +EXPORT_SYMBOL(rockchip_drm_wait_vact_end); > > static int vop_bind(struct device *dev, struct device *master, void *data) > { > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] drm/rockchip: Set line flag config register in vop_crtc_enable

e_num, > > if (!crtc || !vop->is_enabled) > > return -ENODEV; > > - if (line_num > crtc->mode.vtotal || mstimeout <= 0) > > + if (mstimeout <= 0) > > return -EINVAL; > > if (vop_line_flag_irq_is_enabled(vop)) >

Re: [PATCH] drm/rockchip: Set line flag config register in vop_crtc_enable

>is_enabled) > > return -ENODEV; > > - if (line_num > crtc->mode.vtotal || mstimeout <= 0) > > + if (mstimeout <= 0) > > return -EINVAL; > > if (vop_line_flag_irq_is_enabled(vop)) > > return -EBUSY; > > reinit_completion(>line_flag_completion); > > - vop_line_flag_irq_enable(vop, line_num); > > + vop_line_flag_irq_enable(vop); > > jiffies_left = wait_for_completion_timeout(>line_flag_completion, > >msecs_to_jiffies(mstimeout)); > > @@ -1547,7 +1545,7 @@ int rockchip_drm_wait_line_flag(struct drm_crtc > > *crtc, unsigned int line_num, > > return 0; > > } > > -EXPORT_SYMBOL(rockchip_drm_wait_line_flag); > > +EXPORT_SYMBOL(rockchip_drm_wait_vact_end); > > static int vop_bind(struct device *dev, struct device *master, void *data) > > { > > > -- > Ｍark Yao > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v8 1/2] drm: Unplug drm device when unregistering it

unplugged state to prevent something like that, so let's > > reuse it here. > > > > Also drop drm_unplug_dev, because it would be unused after other changes. > > > > Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> > > Reviewed-by: Sean Paul <seanp

Re: [PATCH v8 1/2] drm: Unplug drm device when unregistering it

unplugged state to prevent something like that, so let's > > reuse it here. > > > > Also drop drm_unplug_dev, because it would be unused after other changes. > > > > Signed-off-by: Jeffy Chen > > Reviewed-by: Sean Paul > > > > --- > &

Re: [PATCH] drm/vc4: Fix refcounting of runtime PM get if it errors out.

od to me. It seems a little odd to wrap pm_runtime which is already refcounted in another refcount, but I'm really not familiar with the driver, and I'm sure there's a good reason for it. Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > > I stumbled across this error when tes

Re: [PATCH] drm/vc4: Fix refcounting of runtime PM get if it errors out.

odd to wrap pm_runtime which is already refcounted in another refcount, but I'm really not familiar with the driver, and I'm sure there's a good reason for it. Reviewed-by: Sean Paul > --- > > I stumbled across this error when testing my CMA patch with a very low > (64MB) C

Re: [PATCH v11] drm: Unplug drm device when unregistering it (v8)

h > index 0fefc3f..eb63078 100644 > --- a/include/drm/drm_drv.h > +++ b/include/drm/drm_drv.h > @@ -544,7 +544,6 @@ void drm_dev_unregister(struct drm_device *dev); > void drm_dev_ref(struct drm_device *dev); > void drm_dev_unref(struct drm_device *dev); > void drm_put_dev(struct drm_device *dev); > -void drm_unplug_dev(struct drm_device *dev); > > int drm_dev_set_unique(struct drm_device *dev, const char *name); > > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v11] drm: Unplug drm device when unregistering it (v8)

078 100644 > --- a/include/drm/drm_drv.h > +++ b/include/drm/drm_drv.h > @@ -544,7 +544,6 @@ void drm_dev_unregister(struct drm_device *dev); > void drm_dev_ref(struct drm_device *dev); > void drm_dev_unref(struct drm_device *dev); > void drm_put_dev(struct drm_device *dev); > -void drm_unplug_dev(struct drm_device *dev); > > int drm_dev_set_unique(struct drm_device *dev, const char *name); > > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v9] drm: Unplug drm device when unregistering it

*dev) > { > int ret = atomic_read(>unplugged); > diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h > index 0fefc3f..eb63078 100644 > --- a/include/drm/drm_drv.h > +++ b/include/drm/drm_drv.h > @@ -544,7 +544,6 @@ void drm_dev_unregister(struct drm_device *dev); > void drm_dev_ref(struct drm_device *dev); > void drm_dev_unref(struct drm_device *dev); > void drm_put_dev(struct drm_device *dev); > -void drm_unplug_dev(struct drm_device *dev); > > int drm_dev_set_unique(struct drm_device *dev, const char *name); > > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v9] drm: Unplug drm device when unregistering it

t ret = atomic_read(>unplugged); > diff --git a/include/drm/drm_drv.h b/include/drm/drm_drv.h > index 0fefc3f..eb63078 100644 > --- a/include/drm/drm_drv.h > +++ b/include/drm/drm_drv.h > @@ -544,7 +544,6 @@ void drm_dev_unregister(struct drm_device *dev); > void drm_dev_ref(struct drm_device *dev); > void drm_dev_unref(struct drm_device *dev); > void drm_put_dev(struct drm_device *dev); > -void drm_unplug_dev(struct drm_device *dev); > > int drm_dev_set_unique(struct drm_device *dev, const char *name); > > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] drm: Fixup hang when unregistering drm dev with open_count 0

/drm_drv.h > @@ -544,7 +544,6 @@ void drm_dev_unregister(struct drm_device *dev); > void drm_dev_ref(struct drm_device *dev); > void drm_dev_unref(struct drm_device *dev); > void drm_put_dev(struct drm_device *dev); > -void drm_unplug_dev(struct drm_device *dev); > > int drm_dev_set_unique(struct drm_device *dev, const char *name); > > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] drm: Fixup hang when unregistering drm dev with open_count 0

void drm_dev_unregister(struct drm_device *dev); > void drm_dev_ref(struct drm_device *dev); > void drm_dev_unref(struct drm_device *dev); > void drm_put_dev(struct drm_device *dev); > -void drm_unplug_dev(struct drm_device *dev); > > int drm_dev_set_unique(struct drm_device *dev, const char *name); > > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] drm/udl: Fix unaligned memory access in udl_render_hline

ating_pixel_val16 = pixel_val16; > > - *(uint16_t *)cmd = cpu_to_be16(pixel_val16); > + put_unaligned_be16(pixel_val16, cmd); > > cmd += 2; > pixel += bpp; > -- > 2.11.0 -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] drm/udl: Fix unaligned memory access in udl_render_hline

pixel_val16 = pixel_val16; > > - *(uint16_t *)cmd = cpu_to_be16(pixel_val16); > + put_unaligned_be16(pixel_val16, cmd); > > cmd += 2; > pixel += bpp; > -- > 2.11.0 -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v6 2/2] drm: Prevent release fb after cleanup mode config

e this could only result from a driver bug (or I'm not reading the code correctly). Sean > + return; > > INIT_LIST_HEAD(); > > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v6 2/2] drm: Prevent release fb after cleanup mode config

iver bug (or I'm not reading the code correctly). Sean > + return; > > INIT_LIST_HEAD(); > > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v6 1/2] drm: Unplug drm device when unregistering it

ver_features & feature) ? 1 : 0); > } > > +static inline void drm_device_set_plugged(struct drm_device *dev) > +{ > + smp_wmb(); > + atomic_set(>unplugged, 0); > +} > + > static inline void drm_device_set_unplugged(struct drm_device *dev) Instead of introducing a

Re: [PATCH v6 1/2] drm: Unplug drm device when unregistering it

t; +static inline void drm_device_set_plugged(struct drm_device *dev) > +{ > + smp_wmb(); > + atomic_set(>unplugged, 0); > +} > + > static inline void drm_device_set_unplugged(struct drm_device *dev) Instead of introducing a new function, just rename this to drm_device_set_plug_state(struct drm_device *dev, bool plugged) and call it from both plug and unplug With that nit, this is Reviewed-by: Sean Paul > { > smp_wmb(); > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v6 0/2] drm: rockchip: Fix rockchip drm unbind crash error

ing it > drm: Prevent release fb after cleanup mode config > > drivers/gpu/drm/drm_drv.c | 6 +++--- > drivers/gpu/drm/drm_framebuffer.c | 5 + > drivers/gpu/drm/udl/udl_drv.c | 2 +- > include/drm/drmP.h| 6 ++ > 4 files changed, 15 inser

Re: [PATCH v6 0/2] drm: rockchip: Fix rockchip drm unbind crash error

Prevent release fb after cleanup mode config > > drivers/gpu/drm/drm_drv.c | 6 +++--- > drivers/gpu/drm/drm_framebuffer.c | 5 + > drivers/gpu/drm/udl/udl_drv.c | 2 +- > include/drm/drmP.h| 6 ++ > 4 files changed, 15 insertions(+), 4 deletions(-

Re: [PATCH v5 00/12] drm: rockchip: Fix rockchip drm unbind crash error

msung.com>'s comments. > > Changes in v3: > Update commit message. > Address Sean Paul <seanp...@chromium.org>'s comments. > Update commit message. > Address Sean Paul <seanp...@chromium.org>'s comments. > Update commit message. > Address Daniel Vetter <d

Re: [PATCH v5 00/12] drm: rockchip: Fix rockchip drm unbind crash error

s. > > Changes in v3: > Update commit message. > Address Sean Paul 's comments. > Update commit message. > Address Sean Paul 's comments. > Update commit message. > Address Daniel Vetter 's comments. > Update commit message. > > Changes in v2: > Fix some commit me

Re: [PATCH v3 0/5] DRM OF graph clean-up

On Wed, Mar 22, 2017 at 9:26 AM, Rob Herring wrote: > I've been unhappy with the OF graph API for some time and decided to > do something about it. The problem is drivers have to do too much of the > graph parsing and walking themselves. This has led to the same pattern >

Re: [PATCH v3 0/5] DRM OF graph clean-up

On Wed, Mar 22, 2017 at 9:26 AM, Rob Herring wrote: > I've been unhappy with the OF graph API for some time and decided to > do something about it. The problem is drivers have to do too much of the > graph parsing and walking themselves. This has led to the same pattern > duplicated over and

Re: [PATCH v3 8/9] drm/rockchip: gem: Don't alloc/free gem buf when dev_private is invalid

On Thu, Apr 06, 2017 at 10:47:59AM +0800, jeffy wrote: > Hi Sean, > > On 04/06/2017 12:28 AM, Sean Paul wrote: > > On Wed, Apr 05, 2017 at 04:29:26PM +0800, Jeffy Chen wrote: > > > After unbinding drm, the userspace may still has a chance to access > > > gem buf

Re: [PATCH v3 8/9] drm/rockchip: gem: Don't alloc/free gem buf when dev_private is invalid

On Thu, Apr 06, 2017 at 10:47:59AM +0800, jeffy wrote: > Hi Sean, > > On 04/06/2017 12:28 AM, Sean Paul wrote: > > On Wed, Apr 05, 2017 at 04:29:26PM +0800, Jeffy Chen wrote: > > > After unbinding drm, the userspace may still has a chance to access > > > gem buf

Re: [PATCH v3 8/9] drm/rockchip: gem: Don't alloc/free gem buf when dev_private is invalid

rk_obj) > > static void rockchip_gem_free_buf(struct rockchip_gem_object *rk_obj) > { > + struct drm_device *drm = rk_obj->base.dev; > + > + if (!drm->dev_private) > + return; > + > if (rk_obj->pages) > rockchip_gem_free_iommu(rk_obj); > else > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v3 8/9] drm/rockchip: gem: Don't alloc/free gem buf when dev_private is invalid

ruct rockchip_gem_object *rk_obj) > { > + struct drm_device *drm = rk_obj->base.dev; > + > + if (!drm->dev_private) > + return; > + > if (rk_obj->pages) > rockchip_gem_free_iommu(rk_obj); > else > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] MAINTAINERS: Add Laurent and Andrzej as maintainers for bridge drivers

: Andrzej Hajda <a.ha...@samsung.com> Acked-by: Sean Paul <seanp...@chromium.org> > Signed-off-by: Archit Taneja <arch...@codeaurora.org> > --- > MAINTAINERS | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d

Re: [PATCH] MAINTAINERS: Add Laurent and Andrzej as maintainers for bridge drivers

On Wed, Apr 05, 2017 at 04:53:50PM +0530, Archit Taneja wrote: > Add Laurent and Andrzej as maintainers for DRM bridge chip drivers. They > actively review and contribute to bridge drivers and the bridge API. > > Cc: Laurent Pinchart > Cc: Andrzej Hajda Acked-by: Sean Paul

Re: [PATCH v2 6/9] drm/rockchip: Reoder unload sequence

> + drm_vblank_cleanup(drm_dev); > component_unbind_all(dev, drm_dev); > - rockchip_iommu_cleanup(drm_dev); > drm_mode_config_cleanup(drm_dev); > + rockchip_iommu_cleanup(drm_dev); > + > drm_dev->dev_private = NULL; > drm_dev_unregister(drm_dev); > drm_dev_unref(drm_dev); > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v2 6/9] drm/rockchip: Reoder unload sequence

component_unbind_all(dev, drm_dev); > - rockchip_iommu_cleanup(drm_dev); > drm_mode_config_cleanup(drm_dev); > + rockchip_iommu_cleanup(drm_dev); > + > drm_dev->dev_private = NULL; > drm_dev_unregister(drm_dev); > drm_dev_unref(drm_dev); > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v2 5/9] drm/rockchip: vop: Enable pm domain when resetting vop

understand with a commit message ;-) > + > ret = vop_create_crtc(vop); > if (ret) > - goto err_enable_irq; > - > - pm_runtime_enable(>dev); > + goto err_disable_pm_runtime; Do you have anything to clean up from vop_initial()? > > return 0; > > -err_enable_irq: > +err_disable_pm_runtime: > + pm_runtime_disable(>dev); > enable_irq(vop->irq); /* To balance out the disable_irq above */ > return ret; > } > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v2 5/9] drm/rockchip: vop: Enable pm domain when resetting vop

;-) > + > ret = vop_create_crtc(vop); > if (ret) > - goto err_enable_irq; > - > - pm_runtime_enable(>dev); > + goto err_disable_pm_runtime; Do you have anything to clean up from vop_initial()? > > return 0; > > -err_enable_irq: > +err_disable_pm_runtime: > + pm_runtime_disable(>dev); > enable_irq(vop->irq); /* To balance out the disable_irq above */ > return ret; > } > -- > 2.1.4 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v3 04/11] drm/sun4i: abstract the layer type

@ > +/* > + * Copyright (C) 2017 Icenowy Zheng <icen...@aosc.xyz> > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + */ > + > +#ifndef _SUNXI_LAYER_H_ > +#define _SUNXI_LAYER_H_ > + > +struct sunxi_layer_ops { > + struct drm_plane *(*get_plane)(void *layer); > +}; > + > +#endif /* _SUNXI_LAYER_H_ */ > -- > 2.12.0 > > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v3 04/11] drm/sun4i: abstract the layer type

; + * Copyright (C) 2017 Icenowy Zheng > + * > + * This program is free software; you can redistribute it and/or > + * modify it under the terms of the GNU General Public License as > + * published by the Free Software Foundation; either version 2 of > + * the License, or (at your option) any later version. > + */ > + > +#ifndef _SUNXI_LAYER_H_ > +#define _SUNXI_LAYER_H_ > + > +struct sunxi_layer_ops { > + struct drm_plane *(*get_plane)(void *layer); > +}; > + > +#endif /* _SUNXI_LAYER_H_ */ > -- > 2.12.0 > > > ___ > linux-arm-kernel mailing list > linux-arm-ker...@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property

patch to do that. > > > > > > .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 7 > > > +++ > > > 1 file changed, 7 insertions(+) > > > > Acked-by: Rob Herring <r...@kernel.org> > > I don't see this patch in linux-next, so I guess it has fallen through > the cracks somewhere. Since we have Rob's ack, can you pick this via > drm-misc? > Yeah, sorry about that. Applied to misc-next Sean > > Regards, > John -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property

> > > > .../devicetree/bindings/display/rockchip/dw_mipi_dsi_rockchip.txt | 7 > > > +++ > > > 1 file changed, 7 insertions(+) > > > > Acked-by: Rob Herring > > I don't see this patch in linux-next, so I guess it has fallen through > the cracks somewhere. Since we have Rob's ack, can you pick this via > drm-misc? > Yeah, sorry about that. Applied to misc-next Sean > > Regards, > John -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v4 0/4] RK3399 dw-mipi-dsi patches

splay/rockchip/dw_mipi_dsi_rockchip.txt | 2 +- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 42 > +++++- > 2 files changed, 35 insertions(+), 9 deletions(-) > > -- > 2.6.3 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v4 0/4] RK3399 dw-mipi-dsi patches

splay/rockchip/dw_mipi_dsi_rockchip.txt | 2 +- > drivers/gpu/drm/rockchip/dw-mipi-dsi.c | 42 > +++++- > 2 files changed, 35 insertions(+), 9 deletions(-) > > -- > 2.6.3 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v8] drm/rockchip: Refactor the component match logic.

hanks, Sean > > Signed-off-by: Jeffy Chen <jeffy.c...@rock-chips.com> > Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> > Acked-by: Mark Yao <mark@rock-chips.com> > Tested-by: Heiko Stuebner <he...@sntech.de> > > --- > > Changes in v8: > Addres

Re: [PATCH v8] drm/rockchip: Refactor the component match logic.

hanks, Sean > > Signed-off-by: Jeffy Chen > Reviewed-by: Andrzej Hajda > Acked-by: Mark Yao > Tested-by: Heiko Stuebner > > --- > > Changes in v8: > Address Sean Paul 's comments. > > Changes in v7: > Add Heiko Stuebner 's Tested-by. > > Changes in

Re: [PATCH v3 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge

: https://cgit.freedesktop.org/drm/drm-tip/tree/?h=rerere-cache Sean > if (ret) > - return -ENODEV; > + return ret; > > - return fsl_dcu_attach_endpoint(fsl_dev, ); > + if (panel) { > + fsl_dev->connector.panel = panel; > + return fsl_dcu_attach_panel(fsl_dev, panel); > + } > + > + return drm_bridge_attach(_dev->encoder, bridge, NULL); > -- > 2.10.1 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v3 4/5] drm: convert drivers to use drm_of_find_panel_or_bridge

org/drm/drm-tip/tree/?h=rerere-cache Sean > if (ret) > - return -ENODEV; > + return ret; > > - return fsl_dcu_attach_endpoint(fsl_dev, ); > + if (panel) { > + fsl_dev->connector.panel = panel; > + return fsl_dcu_attach_panel(fsl_dev, panel); > + } > + > + return drm_bridge_attach(_dev->encoder, bridge, NULL); > -- > 2.10.1 > -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v2 2/2] drm/panel: add innolux,p079zca panel driver

On Tue, Mar 21, 2017 at 01:38:31PM -0700, Brian Norris wrote: > + Thierry for real > > On Tue, Mar 21, 2017 at 03:26:35PM -0400, Sean Paul wrote: > > On Wed, Mar 15, 2017 at 03:19:13PM +0800, Chris Zhong wrote: > > > Support Innolux P079ZCA 7.85" 768x1024 TF

Re: [PATCH v2 2/2] drm/panel: add innolux,p079zca panel driver

On Tue, Mar 21, 2017 at 01:38:31PM -0700, Brian Norris wrote: > + Thierry for real > > On Tue, Mar 21, 2017 at 03:26:35PM -0400, Sean Paul wrote: > > On Wed, Mar 15, 2017 at 03:19:13PM +0800, Chris Zhong wrote: > > > Support Innolux P079ZCA 7.85" 768x1024 TF

Re: [PATCH v3 1/4] drm/rockchip/dsi: check phy_cfg_clk only for RK3399

On Tue, Mar 21, 2017 at 04:16:23PM -0400, Sean Paul wrote: > On Fri, Mar 17, 2017 at 11:54:21AM +0800, Chris Zhong wrote: > > For RK3399, the phy_cfg_clk is a required clock, if phy_cfg_clk is > > disabled, MIPI phy can not work. Let's return a error if there is no > > phy_cf

Re: [PATCH v3 1/4] drm/rockchip/dsi: check phy_cfg_clk only for RK3399

On Tue, Mar 21, 2017 at 04:16:23PM -0400, Sean Paul wrote: > On Fri, Mar 17, 2017 at 11:54:21AM +0800, Chris Zhong wrote: > > For RK3399, the phy_cfg_clk is a required clock, if phy_cfg_clk is > > disabled, MIPI phy can not work. Let's return a error if there is no > > phy_cf

Re: [PATCH v3 3/4] drm/rockchip/dsi: enable the grf clk before writing grf registers

On Fri, Mar 17, 2017 at 11:54:23AM +0800, Chris Zhong wrote: > For RK3399, the grf clk should be enabled before writing grf registers, > otherwise the register value can not be changed. > > Signed-off-by: Chris Zhong <z...@rock-chips.com> Minor nit below, with that: Revi

Re: [PATCH v3 3/4] drm/rockchip/dsi: enable the grf clk before writing grf registers

On Fri, Mar 17, 2017 at 11:54:23AM +0800, Chris Zhong wrote: > For RK3399, the grf clk should be enabled before writing grf registers, > otherwise the register value can not be changed. > > Signed-off-by: Chris Zhong Minor nit below, with that: Reviewed-by: Sean Paul > --- >

Re: [PATCH v3 2/4] dt-bindings: add the grf clock for dw-mipi-dsi

On Tue, Mar 21, 2017 at 04:17:00PM -0400, Sean Paul wrote: > On Fri, Mar 17, 2017 at 11:54:22AM +0800, Chris Zhong wrote: > > For RK3399, the grf clock should be controlled by dw-mipi-dsi driver, > > add the description for this clock. > > > > Signed-off-by: Chris

Re: [PATCH v3 2/4] dt-bindings: add the grf clock for dw-mipi-dsi

On Tue, Mar 21, 2017 at 04:17:00PM -0400, Sean Paul wrote: > On Fri, Mar 17, 2017 at 11:54:22AM +0800, Chris Zhong wrote: > > For RK3399, the grf clock should be controlled by dw-mipi-dsi driver, > > add the description for this clock. > > > > Signed-off-by: Chris Zhon

Re: [PATCH v3 4/4] drm/rockchip/dsi: correct the grf_switch_reg name

On Fri, Mar 17, 2017 at 11:54:24AM +0800, Chris Zhong wrote: > For the RK3399, the grf_switch_reg name should be RK3399_GRF_SOC_CON20, > not RK3399_GRF_SOC_CON19. > > Signed-off-by: Chris Zhong <z...@rock-chips.com> Reviewed-by: Sean Paul <seanp...@chromium.org> > -

Re: [PATCH v3 4/4] drm/rockchip/dsi: correct the grf_switch_reg name

On Fri, Mar 17, 2017 at 11:54:24AM +0800, Chris Zhong wrote: > For the RK3399, the grf_switch_reg name should be RK3399_GRF_SOC_CON20, > not RK3399_GRF_SOC_CON19. > > Signed-off-by: Chris Zhong Reviewed-by: Sean Paul > --- > > Changes in v3: None > Changes in v2: No

Re: [PATCH v3 2/4] dt-bindings: add the grf clock for dw-mipi-dsi

as defined in [2]. >For vopb,set the reg = <0> and set the reg = <1> for vopl. > -- > 2.6.3 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v3 1/4] drm/rockchip/dsi: check phy_cfg_clk only for RK3399

y_cfg_clk\n"); > } > > ret = clk_prepare_enable(dsi->pllref_clk); > -- > 2.6.3 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v3 2/4] dt-bindings: add the grf clock for dw-mipi-dsi

ined in [2]. >For vopb,set the reg = <0> and set the reg = <1> for vopl. > -- > 2.6.3 > > ___ > dri-devel mailing list > dri-de...@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Sean Paul, Software Engineer, Google / Chromium OS

Re: [PATCH v3 1/4] drm/rockchip/dsi: check phy_cfg_clk only for RK3399

RR(dsi->phy_cfg_clk); > dev_err(dev, "Unable to get phy_cfg_clk: %d\n", ret); > return ret; > } > - dsi->phy_cfg_clk = NULL; > - dev_dbg(dev, "have not phy_cfg_clk\n"); >

Re: [PATCH v2 2/2] drm/panel: add innolux,p079zca panel driver

ays use Low power mode to send commend > - add comments for all the sleep > - use DRM_DEV_ERROR instead of dev_err > Minor suggestion below. Once that's cleared up, you can add: Reviewed-by: Sean Paul <seanp...@chromium.org> Also, please add Thierry directly to your patche

Re: [PATCH v2 2/2] drm/panel: add innolux,p079zca panel driver

commend > - add comments for all the sleep > - use DRM_DEV_ERROR instead of dev_err > Minor suggestion below. Once that's cleared up, you can add: Reviewed-by: Sean Paul Also, please add Thierry directly to your patches so he sees them. > drivers/gpu/drm/panel/Kconfig

Re: [PATCH v3] drm/rockchip: Refactor the component match logic.

effy Chen <jeffy.c...@rock-chips.com> > Reviewed-by: Andrzej Hajda <a.ha...@samsung.com> Still looks good to me. If Mark doesn't object in the next 24 hours, I'll apply. Sean > > --- > > Changes in v3: > Address Andrzej Hajda <a.ha...@samsung.com>'s co

Re: [PATCH v3] drm/rockchip: Refactor the component match logic.

y Chen > Reviewed-by: Andrzej Hajda Still looks good to me. If Mark doesn't object in the next 24 hours, I'll apply. Sean > > --- > > Changes in v3: > Address Andrzej Hajda 's comments. > > Changes in v2: > Address Sean Paul 's comments. > > drivers/gpu/drm/

Re: [PATCH 2/2] drm/panel: add innolux,p079zca panel driver

On Fri, Mar 03, 2017 at 09:01:49AM +0800, Chris Zhong wrote: > Support Innolux P079ZCA 7.85" 768x1024 TFT LCD panel, it is a MIPI DSI > panel. > > Signed-off-by: Chris Zhong > --- > > drivers/gpu/drm/panel/Kconfig | 11 + > drivers/gpu/drm/panel/Makefile

Re: [PATCH 2/2] drm/panel: add innolux,p079zca panel driver

On Fri, Mar 03, 2017 at 09:01:49AM +0800, Chris Zhong wrote: > Support Innolux P079ZCA 7.85" 768x1024 TFT LCD panel, it is a MIPI DSI > panel. > > Signed-off-by: Chris Zhong > --- > > drivers/gpu/drm/panel/Kconfig | 11 + > drivers/gpu/drm/panel/Makefile| 1 +

Re: [PATCH v2] drm/rockchip: Refactor the component match logic.

On Tue, Mar 14, 2017 at 06:45:49PM +0800, Jeffy Chen wrote: > Currently we are adding all components from the dts, if one of their > drivers been disabled, we would not be able to bring up others. > > Refactor component match logic, follow exynos drm. > > Signed-off-by: Jeffy Chen

Re: [PATCH v2] drm/rockchip: Refactor the component match logic.

On Tue, Mar 14, 2017 at 06:45:49PM +0800, Jeffy Chen wrote: > Currently we are adding all components from the dts, if one of their > drivers been disabled, we would not be able to bring up others. > > Refactor component match logic, follow exynos drm. > > Signed-off-by: Jeffy Chen Thanks for

Re: [PATCH] drm/rockchip: Refactor the component match logic.

On Wed, Mar 08, 2017 at 01:58:14PM +0800, Jeffy Chen wrote: > Currently we are adding all components from the dts, if one of their > drivers been disabled, we would not be able to bring up others. > > Refactor component match logic, follow exynos drm. > > Signed-off-by: Jeffy Chen

Re: [PATCH] drm/rockchip: Refactor the component match logic.

On Wed, Mar 08, 2017 at 01:58:14PM +0800, Jeffy Chen wrote: > Currently we are adding all components from the dts, if one of their > drivers been disabled, we would not be able to bring up others. > > Refactor component match logic, follow exynos drm. > > Signed-off-by: Jeffy Chen > > --- > >

Re: [PATCH 0/3] RK3399 cdd-dp patches

On Wed, Mar 08, 2017 at 10:27:54AM +0800, Chris Zhong wrote: > Hi all > This series is to correct some mistakes in clk_get_rate and the register > address. And in order to better develop, adding more prints. > > > Chris Zhong (3): > drm/rockchip: cdn-dp: return error code when clk_get_rate

Re: [PATCH 0/3] RK3399 cdd-dp patches

On Wed, Mar 08, 2017 at 10:27:54AM +0800, Chris Zhong wrote: > Hi all > This series is to correct some mistakes in clk_get_rate and the register > address. And in order to better develop, adding more prints. > > > Chris Zhong (3): > drm/rockchip: cdn-dp: return error code when clk_get_rate

Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs

On Mon, Mar 13, 2017 at 06:09:17PM +, Emil Velikov wrote: > On 13 March 2017 at 17:00, Rob Clark wrote: > > On Mon, Mar 13, 2017 at 12:43 PM, Arnd Bergmann wrote: > >> The newly added a5xx support fails to build when debugfs is diabled: > >> > >>

Re: [RESEND PATCH] drm/msm: adreno: fix build error without debugfs

On Mon, Mar 13, 2017 at 06:09:17PM +, Emil Velikov wrote: > On 13 March 2017 at 17:00, Rob Clark wrote: > > On Mon, Mar 13, 2017 at 12:43 PM, Arnd Bergmann wrote: > >> The newly added a5xx support fails to build when debugfs is diabled: > >> > >> drivers/gpu/drm/msm/adreno/a5xx_gpu.c:849:4:

[PATCH 20/41] drm/bridge: analogix_dp: Set PD_INC_BG first when powering up edp phy

From: zain wang <w...@rock-chips.com> Following the correct power up sequence: dp_pd=ff => dp_pd=7f => wait 10us => dp_pd=00 Cc: Stéphane Marchesin <marc...@chromium.org> Signed-off-by: zain wang <w...@rock-chips.com> Signed-off-by: Sean Paul <seanp...@chromium.or

[PATCH 20/41] drm/bridge: analogix_dp: Set PD_INC_BG first when powering up edp phy

From: zain wang Following the correct power up sequence: dp_pd=ff => dp_pd=7f => wait 10us => dp_pd=00 Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by: Sean Paul --- drivers/gpu/drm/bridge/analogix/analogix_dp_reg.c | 10 -- drivers/gpu/drm/bridge

Re: [PATCH] drm/dp: Add missing description to parameter

On Tue, Mar 07, 2017 at 09:35:11PM +0100, Tomeu Vizoso wrote: > Gabriel Krisman reported these warnings when building the documentation: > > ./drivers/gpu/drm/drm_dp_helper.c:1165: warning: No description found > for parameter 'crtc' > ./drivers/gpu/drm/drm_dp_helper.c:1166: warning: No

Re: [PATCH] drm/dp: Add missing description to parameter

On Tue, Mar 07, 2017 at 09:35:11PM +0100, Tomeu Vizoso wrote: > Gabriel Krisman reported these warnings when building the documentation: > > ./drivers/gpu/drm/drm_dp_helper.c:1165: warning: No description found > for parameter 'crtc' > ./drivers/gpu/drm/drm_dp_helper.c:1166: warning: No

Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property

for his ack. Also, Reviewed-by: Sean Paul <seanp...@chromium.org> > --- > On Thu, 2 Mar 2017 13:56:46 -0800, Brian Norris wrote: > > On Fri, Feb 24, 2017 at 12:55:06PM +, John Keeping wrote: > > > + /* > > > + * Note that the reset was not defined in the ini

Re: [PATCH] dt-bindings: display: rk3288-mipi-dsi: add reset property

On Fri, Mar 03, 2017 at 11:39:45AM +, John Keeping wrote: > This reset is required in order to fully reset the internal state of the > MIPI controller. > > Signed-off-by: John Keeping I'm sorry I missed this in my review. Adding Rob Herring directly for his ack. Also, Revie

Re: [PATCH v6 0/4] drm/dp: Implement CRC debugfs API

these patches, tests in IGT such as kms_pipe_crc_basic and > kms_plane do pass on RK3288. > > In this v6, the backpointer in drm_dp_aux becomes drm_crtc instead of > drm_connector, following discussion with Sean Paul. > > Thanks, Thanks for respinning this, Tomeu. Applied to -m

Re: [PATCH v6 0/4] drm/dp: Implement CRC debugfs API

these patches, tests in IGT such as kms_pipe_crc_basic and > kms_plane do pass on RK3288. > > In this v6, the backpointer in drm_dp_aux becomes drm_crtc instead of > drm_connector, following discussion with Sean Paul. > > Thanks, Thanks for respinning this, Tomeu. Applied to -m

<    1   2   3   4   5   6   7   8   9   10   >