Re: [PATCH v5 1/3] Remove $(cc-option,-gdwarf-4) dependency from CONFIG_DEBUG_INFO_DWARF4

2021-01-15 Thread Sedat Dilek
On Fri, Jan 15, 2021 at 11:00 PM Fangrui Song wrote: > > On 2021-01-15, Nick Desaulniers wrote: > >From: Masahiro Yamada > > > >The -gdwarf-4 flag is supported by GCC 4.5+, and also by Clang. > > > >You can see it at https://godbolt.org/z/6ed1oW > > > > For gcc 4.5.3 pane,line 37:.value

Re: [PATCH v5 3/3] Kbuild: implement support for DWARF v5

2021-01-15 Thread Sedat Dilek
On Fri, Jan 15, 2021 at 10:49 PM Nick Desaulniers wrote: > > On Fri, Jan 15, 2021 at 1:46 PM Sedat Dilek wrote: > > > > On Fri, Jan 15, 2021 at 10:06 PM Nick Desaulniers > > wrote: > > > > > > DWARF v5 is the latest standard of the DWARF debug

Re: [PATCH v5 0/3] Kbuild: DWARF v5 support

2021-01-15 Thread Sedat Dilek
nts the warning spew. Maybe we'll need a v6. > En plus, I encountered breakage with GCC v10.2.1 and LLVM=1 and CONFIG_DEBUG_INFO_DWARF4. So might be good to add a "depends on !DEBUG_INFO_BTF" in this combination. I had some other small nits commented in the single patches. As request

Re: [PATCH v5 1/3] Remove $(cc-option,-gdwarf-4) dependency from CONFIG_DEBUG_INFO_DWARF4

2021-01-15 Thread Sedat Dilek
On Fri, Jan 15, 2021 at 10:06 PM Nick Desaulniers wrote: > > From: Masahiro Yamada > > The -gdwarf-4 flag is supported by GCC 4.5+, and also by Clang. > > You can see it at https://godbolt.org/z/6ed1oW > > For gcc 4.5.3 pane,line 37:.value 0x4 > For clang 10.0.1 pane, line 117:

Re: [PATCH v5 3/3] Kbuild: implement support for DWARF v5

2021-01-15 Thread Sedat Dilek
CONFIG_DEBUG_INFO_BTF is set; pahole doesn't yet > recognize the new additions to the DWARF debug info. Thanks to Sedat for > the report. > > Link: http://www.dwarfstd.org/doc/DWARF5.pdf > Reported-by: Sedat Dilek > Suggested-by: Arvind Sankar > Suggested-by: Caroline

Re: [PATCH v5 2/3] Kbuild: make DWARF version a choice

2021-01-15 Thread Sedat Dilek
On Fri, Jan 15, 2021 at 10:06 PM Nick Desaulniers wrote: > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice. Adds an > explicit CONFIG_DEBUG_INFO_DWARF2, which is the default. Does so in a > way that's forward compatible with existing configs, and makes adding > future versions more

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-15 Thread Sedat Dilek
On Fri, Jan 15, 2021 at 9:59 PM Josh Poimboeuf wrote: > > On Fri, Jan 15, 2021 at 09:19:16PM +0100, Sedat Dilek wrote: > > > > vmlinux.o: warning: objtool: balance_leaf_when_delete()+0x17d4: stack > > > > state mismatch: cfa1=7+192 cfa2=7+176 >

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-15 Thread Sedat Dilek
On Fri, Jan 15, 2021 at 8:52 PM Josh Poimboeuf wrote: > > On Thu, Jan 14, 2021 at 04:41:28PM -0800, Sami Tolvanen wrote: > > Hi Josh, > > > > On Thu, Jan 14, 2021 at 11:40 AM Josh Poimboeuf wrote: > > > > > > Add support for proper vmlinux.o validation, which will be needed for > > > Sami's

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-15 Thread Sedat Dilek
On Fri, Jan 15, 2021 at 4:30 PM Sedat Dilek wrote: > > On Fri, Jan 15, 2021 at 5:51 AM Sedat Dilek wrote: > > > > On Thu, Jan 14, 2021 at 8:40 PM Josh Poimboeuf wrote: > > > > > > Add support for proper vmlinux.o validation, which will be needed f

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-15 Thread Sedat Dilek
On Fri, Jan 15, 2021 at 5:51 AM Sedat Dilek wrote: > > On Thu, Jan 14, 2021 at 8:40 PM Josh Poimboeuf wrote: > > > > Add support for proper vmlinux.o validation, which will be needed for > > Sami's upcoming x86 LTO set. (And vmlinux validation is the future for >

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-14 Thread Sedat Dilek
On Fri, Jan 15, 2021 at 5:51 AM Sedat Dilek wrote: > > On Thu, Jan 14, 2021 at 8:40 PM Josh Poimboeuf wrote: > > > > Add support for proper vmlinux.o validation, which will be needed for > > Sami's upcoming x86 LTO set. (And vmlinux validation is the future for >

Re: [PATCH 00/21] objtool: vmlinux.o and CLANG LTO support

2021-01-14 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 8:40 PM Josh Poimboeuf wrote: > > Add support for proper vmlinux.o validation, which will be needed for > Sami's upcoming x86 LTO set. (And vmlinux validation is the future for > objtool anyway, for other reasons.) > > This isn't 100% done -- most notably, crypto still

Re: [PATCH v1.1 11/21] objtool: Move unsuffixed symbol conversion to a helper function

2021-01-14 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 9:55 PM Josh Poimboeuf wrote: > > This logic will also be needed for the CONFIG_CFI_CLANG support. > Good you fixed that in v2. I re-pulled from [1]. - Sedat - [1] https://git.kernel.org/pub/scm/linux/kernel/git/jpoimboe/linux.git/log/?h=objtool-vmlinux >

Re: [PATCH v4] kbuild: check the minimum compiler version in Kconfig

2021-01-14 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 9:41 PM Sedat Dilek wrote: > > On Thu, Jan 14, 2021 at 7:54 PM Masahiro Yamada wrote: > > > > Paul Gortmaker reported a regression in the GCC version check [1]. > > If you use GCC 4.8, the build breaks before showing the error message > > &qu

Re: [PATCH v4] kbuild: check the minimum compiler version in Kconfig

2021-01-14 Thread Sedat Dilek
[ Selfmade LLVM toolchain v11.1.0-rc1 ] dileks@iniza:~/src/linux-kernel/git$ which clang /opt/llvm-toolchain/bin/clang dileks@iniza:~/src/linux-kernel/git$ scripts/cc-version.sh clang Clang 110100 [ LLVM-12 from ] dileks@iniza:~/src/linux-kernel/git$ scripts/cc-version.sh clang-12 Clang 12 Fee

Re: [PATCH v2] kbuild: check the minimum compiler version in Kconfig

2021-01-14 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 8:55 AM Ilie Halip wrote: > > Hi Masahiro, > > > + #elif defined(__INTEL_COMPILER) > > + /* How to get the version of intel compiler? */ > > + ICC 0 0 0 > > According to Intel documentation[1], this should do the trick: > >

Re: [PATCH] Documentation/llvm: Add a section about supported architectures

2021-01-13 Thread Sedat Dilek
; LLVM and reporting issues that come about from it. > Thanks, this was overdue and is definitely helpful for users and developers. For x86 64bit: Reviewed-by: Sedat Dilek Together with "[PATCH] kbuild: check the minimum compiler version in Kconfig" this looks very good to me. /o\ - Sedat -

Re: [PATCH v4 2/3] Kbuild: make DWARF version a choice

2021-01-13 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 8:20 AM Sedat Dilek wrote: > > On Thu, Jan 14, 2021 at 12:27 AM Nick Desaulniers > wrote: > > > > Sedat, > > Thanks for testing, and congrats on https://lwn.net/Articles/839772/. > > I always appreciate you taking the time to help test m

Re: [PATCH v4 2/3] Kbuild: make DWARF version a choice

2021-01-13 Thread Sedat Dilek
15 :-). I should ask Mr. Corbet for a LWN subscription. > On Wed, Jan 13, 2021 at 1:24 PM Sedat Dilek wrote: > > > > On Wed, Jan 13, 2021 at 1:32 AM Nick Desaulniers > > wrote: > > > > > > --- a/Makefile > > > +++ b/Makefile > &g

Re: [PATCH] kbuild: check the minimum compiler version in Kconfig

2021-01-13 Thread Sedat Dilek
On Thu, Jan 14, 2021 at 5:17 AM Masahiro Yamada wrote: > > Paul Gortmaker reported a regression in the GCC version check [1]. > If you use GCC 4.8, the build breaks before showing the error message > "error Sorry, your version of GCC is too old - please use 4.9 or newer." > Hi Masahiro, This

Re: [PATCH v4 2/3] Kbuild: make DWARF version a choice

2021-01-13 Thread Sedat Dilek
On Wed, Jan 13, 2021 at 1:32 AM Nick Desaulniers wrote: > > Modifies CONFIG_DEBUG_INFO_DWARF4 to be a member of a choice. Adds an > explicit CONFIG_DEBUG_INFO_DWARF2, which is the default. Does so in a > way that's forward compatible with existing configs, and makes adding > future versions more

Re: [PATCH] bpf: Hoise pahole version checks into Kconfig

2021-01-12 Thread Sedat Dilek
ience and require pahole to be installed with an > appropriate version to select and use CONFIG_DEBUG_INFO_BTF, which is > standard for options that require a specific tools version. > > Suggested-by: Sedat Dilek > Signed-off-by: Nathan Chancellor Thanks for the patch, Nathan, Might be good to g

Re: [PATCH] mm/mremap: fix BUILD_BUG_ON() error in get_extent

2021-01-12 Thread Sedat Dilek
ith > CONFIG_UBSAN_UNSIGNED_OVERFLOW. If we want to keep the BUILD_BUG() > around, I think this is fine. Alternatively, turning it into a runtime > check would be fine too. > > Reviewed-by: Nathan Chancellor > I have this patch in my custom 5.11 queue. Feel free to add my: Te

Re: [PATCH v2] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Sedat Dilek
On Tue, Jan 12, 2021 at 6:14 AM 'Bill Wendling' via Clang Built Linux wrote: > > From: Sami Tolvanen > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > profile, the kernel is instrumented with PGO counters, a representative > workload is run, and the raw profile data

Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Sedat Dilek
On Mon, Jan 11, 2021 at 10:17 AM Bill Wendling wrote: > > On Mon, Jan 11, 2021 at 12:39 AM Sedat Dilek wrote: > > > > On Mon, Jan 11, 2021 at 9:18 AM 'Bill Wendling' via Clang Built Linux > > wrote: > > > > > > From: Sami Tolvanen > >

Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Sedat Dilek
On Mon, Jan 11, 2021 at 9:39 AM Sedat Dilek wrote: > > On Mon, Jan 11, 2021 at 9:18 AM 'Bill Wendling' via Clang Built Linux > wrote: > > > > From: Sami Tolvanen > > > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > > profi

Re: [PATCH] pgo: add clang's Profile Guided Optimization infrastructure

2021-01-11 Thread Sedat Dilek
On Mon, Jan 11, 2021 at 9:18 AM 'Bill Wendling' via Clang Built Linux wrote: > > From: Sami Tolvanen > > Enable the use of clang's Profile-Guided Optimization[1]. To generate a > profile, the kernel is instrumented with PGO counters, a representative > workload is run, and the raw profile data

Re: depmod fixes for linux-stable releases

2021-01-10 Thread Sedat Dilek
On Sun, Jan 10, 2021 at 11:19 AM Sasha Levin wrote: > > On Sat, Jan 09, 2021 at 05:23:22PM -0800, Linus Torvalds wrote: > >Ack, I think 436e980e2ed5 ("kbuild: don't hardcode depmod path") is > >stable material even if it doesn't fix a bug. > > > >Not only does the fix for that commit not make

depmod fixes for linux-stable releases

2021-01-09 Thread Sedat Dilek
Hi, I was CCed on the "depmod: handle the case of /sbin/depmod without /sbin in PATH" changes to linux-stable releases. Do you mind also pushing...? commit 436e980e2ed526832de822cbf13c317a458b78e1 kbuild: don't hardcode depmod path That was the origin for the depmod follow-up. Thanks.

Re: [PATCH v9 00/16] Add support for Clang LTO

2021-01-09 Thread Sedat Dilek
On Sat, Jan 9, 2021 at 6:06 PM Josh Poimboeuf wrote: > > On Sat, Jan 09, 2021 at 11:03:57AM -0600, Josh Poimboeuf wrote: > > On Sat, Jan 09, 2021 at 05:45:47PM +0100, Sedat Dilek wrote: > > > I tried merging with clang-cfi Git which is based on Linux v5.11-rc2+ > > >

Re: [PATCH v9 00/16] Add support for Clang LTO

2021-01-09 Thread Sedat Dilek
On Sat, Jan 9, 2021 at 6:06 PM Josh Poimboeuf wrote: > > On Sat, Jan 09, 2021 at 11:03:57AM -0600, Josh Poimboeuf wrote: > > On Sat, Jan 09, 2021 at 05:45:47PM +0100, Sedat Dilek wrote: > > > I tried merging with clang-cfi Git which is based on Linux v5.11-rc2+ > > >

Re: [PATCH v9 00/16] Add support for Clang LTO

2021-01-09 Thread Sedat Dilek
On Sat, Jan 9, 2021 at 5:33 PM Josh Poimboeuf wrote: > > > > > Did you push it (oh ah push it push it really really really good...) > > > > to your remote Git please :-). > > > > > > I thought I already pushed it pretty good ;-) do you not see it? > > > > > >

Re: [PATCH v9 00/16] Add support for Clang LTO

2021-01-09 Thread Sedat Dilek
On Sat, Jan 9, 2021 at 5:07 PM Josh Poimboeuf wrote: > > On Sat, Jan 09, 2021 at 04:46:21PM +0100, Sedat Dilek wrote: > > On Sat, Jan 9, 2021 at 4:36 PM Josh Poimboeuf wrote: > > > > > > On Sat, Jan 09, 2021 at 03:54:20PM +0100, Sedat Dilek wrote: > > >

Re: [PATCH v9 00/16] Add support for Clang LTO

2021-01-09 Thread Sedat Dilek
On Sat, Jan 9, 2021 at 4:36 PM Josh Poimboeuf wrote: > > On Sat, Jan 09, 2021 at 03:54:20PM +0100, Sedat Dilek wrote: > > I am interested in having Clang LTO (Clang-CFI) for x86-64 working and > > help with testing. > > > > I tried the Git tree mentioned in [3] &

Re: [PATCH v9 00/16] Add support for Clang LTO

2021-01-09 Thread Sedat Dilek
On Fri, Dec 11, 2020 at 7:46 PM 'Sami Tolvanen' via Clang Built Linux wrote: > > This patch series adds support for building the kernel with Clang's > Link Time Optimization (LTO). In addition to performance, the primary > motivation for LTO is to allow Clang's Control-Flow Integrity (CFI) > to

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-07 Thread Sedat Dilek
On Fri, Jan 8, 2021 at 6:30 AM Al Viro wrote: > > On Tue, Jan 05, 2021 at 11:29:11AM -0700, Jens Axboe wrote: > > Song reported a boot regression in a kvm image with 5.11-rc, and bisected > > it down to the below patch. Debugging this issue, turns out that the boot > > stalled when a task is

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-07 Thread Sedat Dilek
> > mainline. Your patch fixes my problem. I haven't done any analysis > > of the code--just testing, thus: > > > > Tested-by: Douglas Anderson > > Thanks, adding your Tested-by. > I have this in my patch-series since it appeared in [1]. Feel free to add my: Tested-by: Sedat Dilek # LLVM/Clang version 11.0.1 - Sedat - [1] https://git.kernel.dk/cgit/linux-block/log/?h=task_work - Sedat -

Re: [PATCH] powerpc: Handle .text.{hot,unlikely}.* in linker script

2021-01-04 Thread Sedat Dilek
On Mon, Jan 4, 2021 at 9:49 PM Nathan Chancellor wrote: > > Commit eff8728fe698 ("vmlinux.lds.h: Add PGO and AutoFDO input > sections") added ".text.unlikely.*" and ".text.hot.*" due to an LLVM > change [1]. > > After another LLVM change [2], these sections are seen in some PowerPC > builds,

Re: Linux 5.11-rc1

2021-01-02 Thread Sedat Dilek
> > IMHO users should not need to fix their environment. > > ( The discussion is a bit obsolete as we now have a fix. ) > > FWIW, I have no (and don't see any) problems simply appending > /sbin:/usr/sbin to the $PATH in/for the kernel's scripts. > Another workaround is to pass

Re: Linux 5.11-rc1

2021-01-02 Thread Sedat Dilek
On Sat, Jan 2, 2021 at 12:05 PM Bernd Petrovitsch wrote: > > On Sat, 2021-01-02 at 10:13 +0100, Sedat Dilek wrote: > [...] > > To be honest I wondered why there were no more reports on this. > > Perhaps I'm not the only one who has /sbin and /usr/sbin in the > $PAT

Re: Linux 5.11-rc1

2021-01-02 Thread Sedat Dilek
On Sat, Jan 2, 2021 at 8:52 AM Masahiro Yamada wrote: > > On Sat, Jan 2, 2021 at 3:55 AM Sedat Dilek wrote: > > > > On Fri, Jan 1, 2021 at 5:14 PM Pavel Machek wrote: > > > > > > Hi! > > > > > > > > > >

Re: Linux 5.11-rc1

2021-01-01 Thread Sedat Dilek
On Fri, Jan 1, 2021 at 7:55 PM Sedat Dilek wrote: > > On Fri, Jan 1, 2021 at 5:14 PM Pavel Machek wrote: > > > > Hi! > > > > > > > > > $ dpkg -L kmod | grep bin | grep depmod > > > > > /sbin/depmod > > > > > &g

Re: Linux 5.11-rc1

2021-01-01 Thread Sedat Dilek
On Fri, Jan 1, 2021 at 5:14 PM Pavel Machek wrote: > > Hi! > > > > > > > $ dpkg -L kmod | grep bin | grep depmod > > > > /sbin/depmod > > > > > > > > $ which depmod > > > > [ empty ] > > > > > > > > $ echo $PATH > > > >

Re: [PATCH v3 0/2] Kbuild: DWARF v5 support

2020-12-31 Thread Sedat Dilek
On Mon, Dec 28, 2020 at 4:15 PM Sedat Dilek wrote: > > On Sun, Dec 27, 2020 at 7:47 PM Sedat Dilek wrote: > > > > On Fri, Dec 4, 2020 at 2:13 AM 'Nick Desaulniers' via Clang Built > > Linux wrote: > > > > > > sigh...I ran a broken script to send the ser

Re: Linux 5.11-rc1

2020-12-28 Thread Sedat Dilek
On Mon, Dec 28, 2020 at 8:40 PM Linus Torvalds wrote: > > On Mon, Dec 28, 2020 at 12:04 AM Sedat Dilek wrote: > > > > > $ dpkg -L kmod | grep bin | grep depmod > > > /sbin/depmod > > > > > > $ which depmod > > > [ empty ] > > >

Re: Linux 5.11-rc1

2020-12-28 Thread Sedat Dilek
On Mon, Dec 28, 2020 at 8:45 PM Linus Torvalds wrote: > > On Mon, Dec 28, 2020 at 7:26 AM Sedat Dilek wrote: > > > > I also tested with LLVM toolchain v11.0.1-rc2 together with passing > > LLVM=1 and LLVM_IAS=1 to my make line. > > > > I had one ER

Re: Linux 5.11-rc1

2020-12-28 Thread Sedat Dilek
[ Please CC me I am not subscribed to LKML and linux-kbuild ML ] Hi Linus, I also tested with LLVM toolchain v11.0.1-rc2 together with passing LLVM=1 and LLVM_IAS=1 to my make line. I had one ERROR: error: too few operands for instruction in arch/x86/kvm/svm/sev.c The issue was reported in

Re: Linux 5.11-rc1

2020-12-28 Thread Sedat Dilek
On Mon, Dec 28, 2020 at 9:04 AM Sedat Dilek wrote: > > On Mon, Dec 28, 2020 at 8:30 AM Sedat Dilek wrote: > > > > [ Please CC me I am not subscribed to LKML and linux-kbuild ML ] > > > > Hi Linus, Hi Mashiro, > > > > thanks for the Linux v5.11-rc1 relea

Re: [PATCH v3 0/2] Kbuild: DWARF v5 support

2020-12-28 Thread Sedat Dilek
On Sun, Dec 27, 2020 at 7:47 PM Sedat Dilek wrote: > > On Fri, Dec 4, 2020 at 2:13 AM 'Nick Desaulniers' via Clang Built > Linux wrote: > > > > sigh...I ran a broken script to send the series which doesn't cc folks > > properly. > > + lkml, linux-kbuild

Re: Linux 5.11-rc1

2020-12-28 Thread Sedat Dilek
On Mon, Dec 28, 2020 at 8:30 AM Sedat Dilek wrote: > > [ Please CC me I am not subscribed to LKML and linux-kbuild ML ] > > Hi Linus, Hi Mashiro, > > thanks for the Linux v5.11-rc1 release. > > With a new release I always do my first builds with my distro's > defau

Re: Linux 5.11-rc1

2020-12-27 Thread Sedat Dilek
[ Please CC me I am not subscribed to LKML and linux-kbuild ML ] Hi Linus, Hi Mashiro, thanks for the Linux v5.11-rc1 release. With a new release I always do my first builds with my distro's default compiler and linker (GCC v10.2.1 and GNU/ld BFD v2.35.1). ( It's approx. 40% faster than LLVM

Re: [PATCH v3] x86/pci: fix the function type for check_reserved_t

2020-12-04 Thread Sedat Dilek
num e820_type values for the > > type argument, change the typedef and the unused type argument in > > is_acpi_reserved to enum e820_type to fix the type mismatch. > > > > Reported-by: Sedat Dilek > > Suggested-by: Borislav Petkov > > Signed-off-by: Sami Tolvanen > &

Re: [PATCH] Only add -fno-var-tracking-assignments workaround for old GCC versions.

2020-10-14 Thread Sedat Dilek
On Mon, Oct 12, 2020 at 9:12 PM Mark Wielaard wrote: > > Hi, > > On Mon, 2020-10-12 at 11:59 -0700, Nick Desaulniers wrote: > > On Sat, Oct 10, 2020 at 3:57 PM Ian Rogers > > wrote: > > > On Sat, Oct 10, 2020 at 3:08 PM Mark Wielaard > > > wrote: > > > > -DEBUG_CFLAGS := $(call cc-option,

Re: Missing [GIT PULL] request for

2020-10-12 Thread Sedat Dilek
On Mon, Oct 12, 2020 at 3:42 PM Ingo Molnar wrote: > > > * Sedat Dilek wrote: > > > Hi, > > > > yesterday, I saw Ingo tagged "locking-urgent-2020-10-11" in tip Git. > > > > Did you drop it or was this for Linux v5.9 final and the git-pull &g

Re: Missing [GIT PULL] request for

2020-10-12 Thread Sedat Dilek
On Mon, Oct 12, 2020 at 3:42 PM Ingo Molnar wrote: > > > * Sedat Dilek wrote: > > > Hi, > > > > yesterday, I saw Ingo tagged "locking-urgent-2020-10-11" in tip Git. > > > > Did you drop it or was this for Linux v5.9 final and the git-pull &g

Missing [GIT PULL] request for

2020-10-12 Thread Sedat Dilek
Hi, yesterday, I saw Ingo tagged "locking-urgent-2020-10-11" in tip Git. Did you drop it or was this for Linux v5.9 final and the git-pull request was simply forgotten? Just curious. Regards, - Sedat - [1]

Re: [PATCH RESEND 1/1] perf build: Allow nested externs to enable BUILD_BUG() usage

2020-10-12 Thread Sedat Dilek
On Fri, Oct 9, 2020 at 8:35 PM Vasily Gorbik wrote: > > Currently BUILD_BUG() macro is expanded to smth like the following: Two feedbacks: #1: Greg KH told me to expand abbreviated words, here "smth = something". #2: Interesting to see an ASCII-art in the signature is causing such troubles. -

Re: [PATCH v5 00/29] Add support for Clang LTO

2020-10-09 Thread Sedat Dilek
On Fri, Oct 9, 2020 at 6:13 PM 'Sami Tolvanen' via Clang Built Linux wrote: > > This patch series adds support for building x86_64 and arm64 kernels > with Clang's Link Time Optimization (LTO). > > In addition to performance, the primary motivation for LTO is > to allow Clang's Control-Flow

Re: [PATCH v2] srcu: avoid escaped section names

2020-10-05 Thread Sedat Dilek
On Mon, Oct 5, 2020 at 8:29 PM 'Nick Desaulniers' via Clang Built Linux wrote: > > On Fri, Oct 2, 2020 at 1:51 PM Paul E. McKenney wrote: > > > > On Wed, Sep 30, 2020 at 01:55:48PM -0700, Nick Desaulniers wrote: > > > On Wed, Sep 30, 2020 at 1:40 PM Paul E. McKenney > > > wrote: > > > > > > >

Re: linux tooling mailing list

2020-10-05 Thread Sedat Dilek
On Mon, Oct 5, 2020 at 7:50 PM Nick Desaulniers wrote: > > On Fri, Oct 2, 2020 at 10:37 AM Randy Dunlap wrote: > > > > On 10/2/20 10:22 AM, Segher Boessenkool wrote: > > > On Fri, Oct 02, 2020 at 02:01:13PM +0200, Sedat Dilek wrote: > > >> On Thu, Oct

Re: PROBLEM: zstd bzImage decompression fails for some x86_32 config on 5.9-rc1

2020-10-03 Thread Sedat Dilek
d into v5.9? > > > > This bug only happens when the window size is > 8 MB. A non-kernel > > workaround > > would be to compress the kernel level 19 instead of level 22, which uses an > > 8 MB window size, instead of a 128 MB window size. > > > > The reason i

Re: linux tooling mailing list

2020-10-02 Thread Sedat Dilek
On Thu, Oct 1, 2020 at 12:26 AM David Miller wrote: > > From: Nick Desaulniers > Date: Wed, 30 Sep 2020 12:29:38 -0700 > > > linux-toolcha...@vger.kernel.org > > Created. > I am subscribed, too. Will there be a(n)...? * archive (for example marc.info) * patchwork url - Sedat - [1]

Re: [PATCH] export.h: fix section name for CONFIG_TRIM_UNUSED_KSYMS for Clang

2020-09-30 Thread Sedat Dilek
Cook > Signed-off-by: Nick Desaulniers "The return of escaped section names" - soon in your cinema? Thanks Nick for catching this. Reviewed-by: Sedat Dilek - Sedat - > --- > include/linux/export.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH v2] srcu: avoid escaped section names

2020-09-30 Thread Sedat Dilek
modules") > Signed-off-by: Nick Desaulniers Puh, remember one year ago an overnight bisecting to catch the root cause for "escaped section names". The two patches I see - this here and "export.h: fix section name for CONFIG_TRIM_UNUSED_KSYMS for Clang" were new cases? Do

Re: PROBLEM: zstd bzImage decompression fails for some x86_32 config on 5.9-rc1

2020-09-28 Thread Sedat Dilek
On Mon, Sep 28, 2020 at 10:55 AM Feng Tang wrote: > > Hi Nick, > > 0day has found some kernel decomprssion failure case since 5.9-rc1 (X86_32 > build), and it could be related with ZSTD code, though initially we bisected > to some other commits. > > The error messages are: > > early

[PATCH] kbuild: explicitly specify the build id style

2020-09-24 Thread Sedat Dilek
[ Please CC me I am not subscribed to all MLs ] [ CC Sami ] Hi Bill, I have tested your patch on top of Sami's latest clang-cfi Git branch. Feel free to add... Tested-by: Sedat Dilek # LLVM toolchain version 11.0.0-rc3 on x86-64 Thanks for the patch. Regards, - Sedat -

[PATCH] mm: Fix typos in page-lock unfairness text

2020-09-20 Thread Sedat Dilek
Fix some small typos I have seen (for details see Link). Cc: Linus Torvalds Fixes: 5ef64cc8987a ("mm: allow a controlled amount of unfairness in the page lock") Link: https://marc.info/?t=15997828843=1=2 Signed-off-by: Sedat Dilek --- mm/filemap.c | 4 ++-- 1 file changed, 2

Re: [PATCH v2] objtool: ignore unreachable trap after call to noreturn functions

2020-09-19 Thread Sedat Dilek
lore.kernel.org/lkml/CAKwvOdmptEpi8fiOyWUo=aizjix+z+vhjom2bulprwsmtwl...@mail.gmail.com > Suggested-by: Nick Desaulniers > Reviewed-by: Nick Desaulniers > Tested-by: Nick Desaulniers > Reported-by: kbuild test robot > Signed-off-by: Ilie Halip > --- Tested-by: Sedat Dilek - Sedat -

Re: [PATCH v3 00/30] Add support for Clang LTO

2020-09-18 Thread Sedat Dilek
On Fri, Sep 18, 2020 at 10:14 PM 'Sami Tolvanen' via Clang Built Linux wrote: > > This patch series adds support for building x86_64 and arm64 kernels > with Clang's Link Time Optimization (LTO). > > In addition to performance, the primary motivation for LTO is > to allow Clang's Control-Flow

Re: [PATCHv3 1/1] ext4: Optimize file overwrites

2020-09-18 Thread Sedat Dilek
g - 16G AFAIK is too big here. Feel free to add... Tested-by: Sedat Dilek # Compile and boot on x86-64 Debian/unstable Thanks. - Sedat - > --- > fs/ext4/inode.c | 18 +++--- > 1 file changed, 15 insertions(+), 3 deletions(-) > > diff --git a/fs/ext4/inode.c b/fs/ext4

Re: [PATCH] vboxsf: fix comparison of signed char constant with unsigned char array elements

2020-09-16 Thread Sedat Dilek
On Wed, Sep 16, 2020 at 8:16 AM Hans de Goede wrote: > > Hi, > > On 9/15/20 6:03 PM, Colin King wrote: > > From: Colin Ian King > > > > The comparison of signed char constants with unsigned char array > > elements leads to checks that are always false. Fix this by declaring > > the

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-14 Thread Sedat Dilek
On Mon, Sep 14, 2020 at 6:29 PM Willy Tarreau wrote: > > On Mon, Sep 14, 2020 at 06:16:40PM +0200, Sedat Dilek wrote: > > On Mon, Sep 14, 2020 at 4:53 PM Amit Klein wrote: > > > > > > Hi > > > > > > Is this patch being pushed to any branch? I d

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-14 Thread Sedat Dilek
On Mon, Sep 14, 2020 at 4:53 PM Amit Klein wrote: > > Hi > > Is this patch being pushed to any branch? I don't see it deployed anywhere > (unless I'm missing something...). > It's here: [1] https://git.kernel.org/pub/scm/linux/kernel/git/wtarreau/prandom.git/log/?h=20200901-siphash-noise >

Re: [PATCH v2] x86/boot/compressed: Disable relocation relaxation

2020-09-14 Thread Sedat Dilek
On Mon, Sep 14, 2020 at 11:16 AM Ingo Molnar wrote: > > > * Ard Biesheuvel wrote: > > > On Mon, 14 Sep 2020 at 01:34, Arvind Sankar wrote: > > > > > > On Tue, Aug 25, 2020 at 10:56:52AM -0400, Arvind Sankar wrote: > > > > On Sat, Aug 15, 2020 at 01:56:49PM -0700, Nick Desaulniers wrote: > > > >

Re: [PATCH v2 00/28] Add support for Clang LTO

2020-09-04 Thread Sedat Dilek
On Fri, Sep 4, 2020 at 10:55 AM wrote: > > > Please don't nest series! > > Start a new thread for every posting. > You are right Peter, my apologies. - Sedat -

Re: [PATCH v2 00/28] Add support for Clang LTO

2020-09-04 Thread Sedat Dilek
to v2. My LLVM toolchain is version 11.0.0.0-rc2+ more precisely git 97ac9e82002d6b12831ca2c78f739cca65a4fa05. If this is OK, feel free to add my... Tested-by: Sedat Dilek - Sedat - [1] https://github.com/samitolvanen/linux/commits/clang-cfi > --- > Changes in v2: > > - Fixed -Wmissing-protot

Re: [PATCH v3 0/7] set clang minimum version to 10.0.1

2020-09-03 Thread Sedat Dilek
On Thu, Sep 3, 2020 at 12:59 AM Nick Desaulniers wrote: > > Adds a compile time #error to compiler-clang.h setting the effective > minimum supported version to clang 10.0.1. A separate patch has already > been picked up into the Documentation/ tree also confirming the version. > > Next are a

Re: [PATCH] ACPI: sysfs: copy ACPI data using io memory copying

2020-09-02 Thread Sedat Dilek
On Wed, Sep 2, 2020 at 12:30 PM Colin Ian King wrote: > > On 14/03/2020 10:23, Rafael J. Wysocki wrote: > > On Thursday, March 12, 2020 12:13:45 PM CET Colin King wrote: > >> From: Colin Ian King > >> > >> Reading ACPI data on ARM64 at a non-aligned offset from > >>

Re: [PATCH v2 2/7] Revert "kbuild: disable clang's default use of -fmerge-all-constants"

2020-09-01 Thread Sedat Dilek
329300. > Link: https://github.com/ClangBuiltLinux/linux/issues/9 > Suggested-by: Nathan Chancellor > Signed-off-by: Nick Desaulniers Reviewed-by: Sedat Dilek Tested-by: Sedat Dilek - Sedat - > --- > Makefile | 9 - > 1 file changed, 9 deletions(-) > > diff --g

Re: [PATCH 0/2] prandom_u32: make output less predictable

2020-09-01 Thread Sedat Dilek
orge Spelvin > Cc: Amit Klein > Cc: Eric Dumazet > Cc: "Jason A. Donenfeld" > Cc: Andy Lutomirski > Cc: Kees Cook > Cc: Thomas Gleixner > Cc: Peter Zijlstra > Cc: Linus Torvalds > Cc: ty...@mit.edu > Cc: Florian Westphal > Cc: Marc Plumb &

Re: [PATCH v2 0/7] set clang minimum version to 10.0.1

2020-09-01 Thread Sedat Dilek
On Tue, Sep 1, 2020 at 2:23 AM Nick Desaulniers wrote: > > Adds a compile time #error to compiler-clang.h setting the effective > minimum supported version to clang 10.0.1. A separate patch has already > been picked up into the Documentation/ tree also confirming the version. > > Next are a

Re: [PATCH v2 1/7] compiler-clang: add build check for clang 10.0.1

2020-09-01 Thread Sedat Dilek
not so subtle ways. > > Link: https://github.com/ClangBuiltLinux/linux/issues/9 > Link: https://github.com/ClangBuiltLinux/linux/issues/941 > Suggested-by: Sedat Dilek > Suggested-by: Nathan Chancellor > Suggested-by: Kees Cook > Acked-by: Marco Elver > Acked-by: Nathan Chanc

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread Sedat Dilek
On Tue, Sep 1, 2020 at 10:57 AM Willy Tarreau wrote: > > On Tue, Sep 01, 2020 at 10:46:16AM +0200, Sedat Dilek wrote: > > Will you push the updated patchset to your prandom Git - for easy fetching? > > Yeah if you want, feel free to use this one : > > https://git.

Re: [PATCH 1/2] random32: make prandom_u32() output unpredictable

2020-09-01 Thread Sedat Dilek
On Tue, Sep 1, 2020 at 10:39 AM Willy Tarreau wrote: > > On Tue, Sep 01, 2020 at 10:33:40AM +0200, Yann Ylavic wrote: > > On Tue, Sep 1, 2020 at 8:45 AM Willy Tarreau wrote: > > > > > > +/* > > > + * Generate some initially weak seeding values to allow > > > + * the prandom_u32() engine

Re: [PATCH] compiler-clang: add build check for clang 10.0.1

2020-08-27 Thread Sedat Dilek
Link: https://github.com/ClangBuiltLinux/linux/issues/9 > Link: https://github.com/ClangBuiltLinux/linux/issues/941 > Suggested-by: Sedat Dilek > Signed-off-by: Nick Desaulniers Nice to see This Is Happening! See also my other replies to Kees and Nathan comments. Acked-by: Sedat Di

Re: [PATCH] compiler-clang: add build check for clang 10.0.1

2020-08-27 Thread Sedat Dilek
On Wed, Aug 26, 2020 at 11:26 PM Nathan Chancellor wrote: > > On Wed, Aug 26, 2020 at 11:17:34PM +0200, Miguel Ojeda wrote: > > On Wed, Aug 26, 2020 at 10:14 PM Nick Desaulniers > > wrote: > > > > > > During Plumbers 2020, we voted to just support the latest release of > > > Clang for now. Add

Re: [PATCH] compiler-clang: add build check for clang 10.0.1

2020-08-27 Thread Sedat Dilek
Older clang's may work, but we will likely drop workarounds for older > > versions. > > > > Link: https://github.com/ClangBuiltLinux/linux/issues/9 > > Link: https://github.com/ClangBuiltLinux/linux/issues/941 > > Suggested-by: Sedat Dilek > > Signed-off-by: Nick Desaulnier

Re: [PATCH] Documentation: add minimum clang/llvm version

2020-08-26 Thread Sedat Dilek
On Wed, Aug 26, 2020 at 12:26 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > Based on a vote at the LLVM BoF at Plumbers 2020, we decided to start > small, supporting just one formal upstream release of LLVM for now. > > We can probably widen the support window of supported versions over

Re: [PATCH v3] lib/string.c: implement stpcpy

2020-08-26 Thread Sedat Dilek
Link: https://bugs.llvm.org/show_bug.cgi?id=47280 > Link: https://github.com/ClangBuiltLinux/linux/issues/1126 > Link: https://man7.org/linux/man-pages/man3/stpcpy.3.html > Link: https://pubs.opengroup.org/onlinepubs/9699919799/functions/stpcpy.html > Link: https://reviews.llvm.org/D85963 >

Re: [PATCH] kbuild: Simplify DEBUG_INFO Kconfig handling

2020-08-26 Thread Sedat Dilek
On Wed, Aug 26, 2020 at 3:43 PM Masahiro Yamada wrote: > > On Wed, Aug 26, 2020 at 9:04 PM Sedat Dilek wrote: > > > > Just a friendly ping. > > > > - Sedat - > > > > On Sun, Aug 16, 2020 at 2:32 PM Sedat Dilek wrote: > > > &

Re: [PATCH] kbuild: Simplify DEBUG_INFO Kconfig handling

2020-08-26 Thread Sedat Dilek
Just a friendly ping. - Sedat - On Sun, Aug 16, 2020 at 2:32 PM Sedat Dilek wrote: > > While playing with [1] I saw that the handling > of CONFIG_DEBUG_INFO can be simplified. > > [1] https://patchwork.kernel.org/patch/11716107/ > > Signed-off-by: Sedat Dilek > --- &

Re: [PATCH] x86/asm: Replace __force_order with memory clobber

2020-08-25 Thread Sedat Dilek
> > > + * with respect to writes, use a dummy memory operand. > > > */ > > > -extern unsigned long __force_order; > > > + > > > > Spurious newline? > > > > This was intentional, but I can remove it if people don't like the extra > whitespace. > > I'll wait a few days for additional review comments before sending v2. > > Thanks. Thanks for taking care and your patch. I have tested this on top of Linux v5.9-rc2 with LLVM toolchain v11.0.0-rc2 (ThinLTO). Tested-by: Sedat Dilek - Sedat -

Re: [PATCH] MAINTAINERS: add LLVM maintainers

2020-08-25 Thread Sedat Dilek
Congrats! Thanks, this was overdue and requested at ClangBuiltLinux Meetup in Zurich in February. Reviewed-by: Sedat Dilek - Sedat - > +M: Nathan Chancellor > +M: Nick Desaulniers > L: clang-built-li...@googlegroups.com > S: Supported > W: https://clangbuiltli

Re: [PATCH] x86: work around clang IAS bug referencing __force_order

2020-08-22 Thread Sedat Dilek
On Sat, Aug 22, 2020 at 11:23 AM Sedat Dilek wrote: > > On Sat, Aug 22, 2020 at 10:42 AM Segher Boessenkool > wrote: > > > > Hi Arvind, > > > > On Fri, Aug 21, 2020 at 11:55:52PM -0400, Arvind Sankar wrote: > > > Cc Segher. > > > > >

Re: [PATCH] x86: work around clang IAS bug referencing __force_order

2020-08-22 Thread Sedat Dilek
On Sat, Aug 22, 2020 at 10:42 AM Segher Boessenkool wrote: > > Hi Arvind, > > On Fri, Aug 21, 2020 at 11:55:52PM -0400, Arvind Sankar wrote: > > Cc Segher. > > > > Segher, we were looking at gcc PR82602, where IRA could reorder volatile > > asm's (reported on ARM). The fix was backported to

Re: [PATCH v2 0/9] kbuild: clang-tidy

2020-08-21 Thread Sedat Dilek
On Sat, Aug 22, 2020 at 3:06 AM 'Nick Desaulniers' via Clang Built Linux wrote: > > On Fri, Aug 21, 2020 at 12:02 PM Masahiro Yamada wrote: > > > > I improved gen_compile_commands.py, > > then rebased Nathan's v7 [1] on top of them. > > To save time, I modified the Makefile part. > > No change

Re: make defconfig (Re: + x86-defconfigs-explicitly-unset-config_64bit-in-i386_defconfig.patch added to -mm tree)

2020-08-21 Thread Sedat Dilek
On Fri, Aug 21, 2020 at 7:27 PM Randy Dunlap wrote: > > On 8/21/20 10:22 AM, Alexey Dobriyan wrote: > > On Thu, Aug 20, 2020 at 02:29:40PM -0700, a...@linux-foundation.org wrote: > >> Subject: x86/defconfigs: Explicitly unset CONFIG_64BIT in i386_defconfig > >> > >> A recent refresh of the

Re: [PATCH v2] x86/defconfigs: Explicitly unset CONFIG_64BIT in i386_defconfig

2020-08-19 Thread Sedat Dilek
[1]: *** [prepare0] Error 2 > /oe/build/tmp/work-shared/intel-core2-32/kernel-source/Makefile:185: recipe > for target '__sub-make' failed > make: *** [__sub-make] Error 2 > > Fixes: 1d0e12fd3a84 ("x86/defconfigs: Refresh defconfig files") > > Signed-off-by: Danie

[PATCH] kbuild: Simplify DEBUG_INFO Kconfig handling

2020-08-16 Thread Sedat Dilek
While playing with [1] I saw that the handling of CONFIG_DEBUG_INFO can be simplified. [1] https://patchwork.kernel.org/patch/11716107/ Signed-off-by: Sedat Dilek --- Makefile | 6 +- lib/Kconfig.debug | 10 -- 2 files changed, 9 insertions(+), 7 deletions(-) diff --git

Re: [PATCH] x86: work around clang IAS bug referencing __force_order

2020-08-16 Thread Sedat Dilek
GCC toolchain simply ignores if kaslr_64.o has __force_order means the build ends up successfully whereas LLVM toolchain and IAS breaks and the build stops and needs explicitly commit df6d4f9db79c1a5d6f48b59db35ccd1e9ff9adfc ("x86/boot/compressed: Don't declare __force_order in kaslr_64.c")

<    1   2   3   4   5   6   7   8   9   10   >