Re: [PATCH] ata: pata_rb532: Add OF support and make COMPILE_TESTable

2021-04-20 Thread Sergei Shtylyov
Hello! On 4/20/21 5:04 PM, Thomas Bogendoerfer wrote: > Add OF support for switching RB532 do device tree possible. I couldnb't parse that. :-) > By removing > the not needed asm/mach-rc32434/rb.h include the driver could be > compile tested now. I think it's a separte issue worth its

Re: [PATCH] net: ethernet: ravb: Fix release of refclk

2021-04-19 Thread Sergei Shtylyov
Hello! On 17.04.2021 16:23, Adam Ford wrote: The call to clk_disable_unprepare() can happen before priv is initialized. Mhm, how's that? :-/ This means moving clk_disable_unprepare out of out_release into a new label. Fixes: 8ef7adc6beb2("net: ethernet: ravb: Enable optional refclk")

Re: [PATCH v2] MIPS: Makefile: Replace -pg with CC_FLAGS_FTRACE

2021-04-19 Thread Sergei Shtylyov
Hello! On 19.04.2021 8:51, zhaoxiao wrote: In preparation for mips supporting ftrace built on other compiler options, let's have the mips Makefiles remove the $(CC_FLAGS_FTRACE) flags, whatever these may be, rather than assuming '-pg'. But your patch is adding 'em, not removing?

Re: [PATCH v5 net-next 10/10] dt-bindings: net: korina: Add DT bindings for IDT 79RC3243x SoCs

2021-04-17 Thread Sergei Shtylyov
On 16.04.2021 16:35, Thomas Bogendoerfer wrote: On Fri, Apr 16, 2021 at 12:29:46PM +0300, Sergei Shtylyov wrote: On 16.04.2021 11:52, Thomas Bogendoerfer wrote: Add device tree bindings for ethernet controller integrated into IDT 79RC3243x SoCs. Signed-off-by: Thomas Bogendoerfer

Re: [PATCH] usb: misc: adutux: fix whitespace coding style issue

2021-04-16 Thread Sergei Shtylyov
On 16.04.2021 11:08, Malte Deiseroth wrote: Correct missing space error ceckpatch.pl is complaining about. It's called checkpatch.pl. :-) Signed-off-by: Malte Deiseroth [...] MBR, Sergei

Re: [PATCH v5 net-next 10/10] dt-bindings: net: korina: Add DT bindings for IDT 79RC3243x SoCs

2021-04-16 Thread Sergei Shtylyov
On 16.04.2021 11:52, Thomas Bogendoerfer wrote: Add device tree bindings for ethernet controller integrated into IDT 79RC3243x SoCs. Signed-off-by: Thomas Bogendoerfer --- .../bindings/net/idt,3243x-emac.yaml | 74 +++ 1 file changed, 74 insertions(+) create mode

Re: [PATCH v4 net-next 07/10] net: korina: Add support for device tree

2021-04-16 Thread Sergei Shtylyov
Hello! On 16.04.2021 11:47, Thomas Bogendoerfer wrote: If there is no mac address passed via platform data try to get it via > device tree and fall back to a random mac address, if all fail. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/korina.c | 24 ++--

Re: [PATCH 13/15] usb: dwc2: Add exit hibernation mode before removing drive

2021-04-15 Thread Sergei Shtylyov
On 15.04.2021 8:41, Artur Petrosyan wrote: When dwc2 core is in hibernation mode loading driver again causes driver fail. Because in that mode registers are not accessible. In order to exit from hibernation checking dwc2 core power saving state in "dwc2_driver_remove()" function. If core is in

Re: [PATCH 10/15] usb: dwc2: Allow exit hibernation in urb enqueue

2021-04-15 Thread Sergei Shtylyov
On 15.04.2021 8:40, Artur Petrosyan wrote: When core is in hibernation state and an external hub is connected, upper layer sends URB enqueue request, which results in port reset issue. - Added exit from hibernation state to avoid port reset issue and process upper layer request properly.

Re: [PATCH v2 11/12] usb: dwc2: Add clock gating exiting flow by system resume

2021-04-13 Thread Sergei Shtylyov
On 13.04.2021 10:37, Artur Petrosyan wrote: If not hibernation nor partial power down are supported, s/not/neither/? port resume is done using the clock gating programming flow. Adds a new flow of exiting clock gating when PC is resumed. Signed-off-by: Artur Petrosyan --- Changes in

Re: [PATCH v2 10/12] usb: dwc2: Add clock gating entering flow by system suspend

2021-04-13 Thread Sergei Shtylyov
On 13.04.2021 10:37, Artur Petrosyan wrote: If not hibernation nor partial power down are supported, s/not/neither/? clock gating is used to save power. Adds a new flow of entering clock gating when PC is suspended. Signed-off-by: Artur Petrosyan --- Changes in v2: - None

Re: [PATCH 03/12] usb: dwc2: Allow entering clock gating from USB_SUSPEND interrupt

2021-04-13 Thread Sergei Shtylyov
On 13.04.2021 10:16, Artur Petrosyan wrote: If core doesn't support hibernation or partial power down power saving options, power can still be saved using clock gating on all the clocks. - Added entering clock gating state from USB_SUSPEND interrupt. Signed-off-by: Artur Petrosyan

Re: [PATCH 07/12] usb: dwc2: Update enter clock gating when port is suspended

2021-04-13 Thread Sergei Shtylyov
Hello! On 13.04.2021 10:17, Artur Petrosyan wrote: Updates the implementation of entering clock gating mode when core receives port suspend. Instead of setting the required bit fields of the registers inline, called the "dwc2_host_enter_clock_gating()" function. Signed-off-by: Artur Petrosyan

Re: [PATCH v1] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

2021-04-10 Thread Sergei Shtylyov
On 10.04.2021 2:42, angkery wrote: From: Junlin Yang The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'irq', so making 'irq' an int, and change the position to keep the code format. Fixes

Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

2021-04-10 Thread Sergei Shtylyov
On 10.04.2021 2:38, angkery wrote: On Fri, 9 Apr 2021 20:02:56 +0300 Sergei Shtylyov wrote: On 4/9/21 7:49 PM, Sergei Shtylyov wrote: From: Junlin Yang The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int

Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

2021-04-09 Thread Sergei Shtylyov
On 4/9/21 7:49 PM, Sergei Shtylyov wrote: >> From: Junlin Yang >> >> The return from the call to platform_get_irq() is int, it can be >> a negative error code, however this is being assigned to an unsigned >> int variable 'irq', so making 'irq' an int, and change th

Re: [PATCH] pata_ipx4xx_cf: Fix unsigned comparison with less than zero

2021-04-09 Thread Sergei Shtylyov
On 4/9/21 4:54 PM, angkery wrote: > From: Junlin Yang > > The return from the call to platform_get_irq() is int, it can be > a negative error code, however this is being assigned to an unsigned > int variable 'irq', so making 'irq' an int, and change the position to > keep the code format. > >

Re: [PATCH] MIPS: octeon: Add __raw_copy_[from|to|in]_user symbols

2021-04-09 Thread Sergei Shtylyov
Hello! On 09.04.2021 0:48, Thomas Bogendoerfer wrote: Cavium Octeon has it's own memcpy implementation and also need the change Its. :-) done in commit 04324f44cb69 ("MIPS: Remove get_fs/set_fs"). Fixes: 04324f44cb69 ("MIPS: Remove get_fs/set_fs") Reported-by: kernel test robot

Re: [PATCH 2/4] exec: remove compat_do_execve

2021-03-27 Thread Sergei Shtylyov
On 3/26/21 5:38 PM, Christoph Hellwig wrote: > Just call compat_do_execve instead. compat_do_execveat(), maybe? > Signed-off-by: Christoph Hellwig > --- > fs/exec.c | 17 + > 1 file changed, 1 insertion(+), 16 deletions(-) > > diff --git a/fs/exec.c b/fs/exec.c > index

Re: [PATCH v1] usb: dwc3: core: Add shutdown callback for dwc3

2021-03-24 Thread Sergei Shtylyov
Hello! On 23.03.2021 22:27, Sandeep Maheswaram wrote: This patch adds a shutdown callback to USB DWC core driver to ensure that it is properly shutdown in reboot/shutdown path. This is required where SMMU address translation is enabled like on SC7180 SoC and few others. If the hardware is

Re: [PATCH v1 4/6] usb: gadget: pch_udc: Move pch_udc_init() to satisfy kernel doc

2021-03-23 Thread Sergei Shtylyov
Hi! On 23.03.2021 0:11, Andy Shevchenko wrote: Kernel doc and the content described by it shouldn't be teared apart. s/teared/torn/? Otherwise validator is not happy: .../pch_udc.c:573: warning: expecting prototype for pch_udc_reconnect(). Prototype was for pch_udc_init() instead

Re: [PATCH v2 01/13] dt-bindings: usb: mtk-xhci: support property usb2-lpm-disable

2021-03-23 Thread Sergei Shtylyov
Hello! On 23.03.2021 10:02, Chunfeng Yun wrote: Add support common property usb2-lpm-disable ^ for Signed-off-by: Chunfeng Yun [...] MBR, Sergei

Re: [PATCH 07/13] usb: xhci-mtk: add support ip-sleep wakeup for mT8192

2021-03-22 Thread Sergei Shtylyov
On 22.03.2021 6:13, Chunfeng Yun wrote: Add support ip-sleep wakeup for mT8192, it's a specific revision, ^ for and not follow IPM rule. Following? Signed-off-by: Chunfeng Yun --- drivers/usb/host/xhci-mtk.c | 10 ++ 1 file changed, 10 insertions(+) diff

Re: [PATCH 10/13] usb: mtu3: support ip-sleep wakeup for MT8183

2021-03-22 Thread Sergei Shtylyov
Same comments as to the patch #6. MBR, Sergei

Re: [PATCH 06/13] usb: xhci-mtk: support ip-sleep wakeup for MT8183

2021-03-22 Thread Sergei Shtylyov
Hello! On 22.03.2021 6:13, Chunfeng Yun wrote: Add support ip-sleep wakeup for MT8183, it's similar to MT8173, ^ for and it's also a specific one, but not follow IPM rule. Following? Due to the index 2 already used by many DTS, it's better to keep it unchanged for

Re: [PATCH V3 5/5] arm64: dts: renesas: beacon kits: Setup AVB refclk

2021-03-19 Thread Sergei Shtylyov
On 18.03.2021 15:44, Adam Ford wrote: The AVB refererence clock assumes an external clock that runs reference automatically. Because the Versaclock is wired to provide the AVB refclock, the device tree needs to reference it in order for the driver to start the clock. Signed-off-by: Adam

Re: [PATCH V3 1/5] dt-bindings: net: renesas,etheravb: Add additional clocks

2021-03-18 Thread Sergei Shtylyov
ly one clock, there is no > clock-names list either. > > Update bindings to add the additional optional clock, and explicitly > name both of them. > > Signed-off-by: Adam Ford > Reviewed-by: Geert Uytterhoeven > Acked-by: Rob Herring Reviewed-by: Sergei Shtylyov [...] PS: S

Re: [PATCH 08/10] MIPS: disable CONFIG_IDE in malta*_defconfig

2021-03-18 Thread Sergei Shtylyov
On 3/18/21 7:57 AM, Christoph Hellwig wrote: > Various malta defconfigs enable CONFIG_IDE for the tc86c001 ide driver, > hich is a Toshiba plug in card that does not make much sense to use on ^ which is for > bigsur platforms. For all other ATA cards libata support is already ^ Malta. >

Re: [PATCH 07/10] MIPS: disable CONFIG_IDE in bigsur_defconfig

2021-03-18 Thread Sergei Shtylyov
Hi! On 3/18/21 7:57 AM, Christoph Hellwig wrote: > bigsur_defconfig enables CONFIG_IDE for the tc86c001 ide driver, which > is a Toshiba plug in card that does not make much sense to use on bigsur ^ for Else that doesn't make much sense. :-) > platforms. For all other ATA cards libata

Re: [PATCH] MIPS: ralink: define stubs for clk_set_parent to fix compile testing

2021-03-17 Thread Sergei Shtylyov
On 17.03.2021 12:56, Krzysztof Kozlowski wrote: [...] The Ralink MIPS platform does not use Common Clock Framework and does not define certain clock operations leading to compile test failures: /usr/bin/mips-linux-gnu-ld: drivers/usb/phy/phy-tegra-usb.o: in function

Re: [PATCH] MIPS/bpf: Enable bpf_probe_read{, str}() on MIPS again

2021-03-17 Thread Sergei Shtylyov
On 17.03.2021 10:15, Tiezhu Yang wrote: After commit 0ebeea8ca8a4 ("bpf: Restrict bpf_probe_read{, str}() only to archs where they work"), bpf_probe_read{, str}() functions were not longer No longer. available on MIPS, so there exists some errors when running bpf program: Exist.

Re: [PATCH] MIPS: ralink: define stubs for clk_set_parent to fix compile testing

2021-03-17 Thread Sergei Shtylyov
Hello! On 16.03.2021 20:57, Krzysztof Kozlowski wrote: The Ralink MIPS platform does not use Common Clock Framework and does not define certain clock operations leading to compile test failures: /usr/bin/mips-linux-gnu-ld: drivers/usb/phy/phy-tegra-usb.o: in function

Re: [PATCH V3] ata: sata_highbank: delete redundant print and fix return value

2021-03-15 Thread Sergei Shtylyov
Hello! On 15.03.2021 5:39, Wang Qing wrote: platform_get_irq() has already checked and printed the return value, the printing here is nothing special, and should corrected to < 0. Also, thhe return value should return a real error. The. It's a bad idea to mix the fix and cleanup in

Re: [PATCH 1/2] ata: delete redundant printing of return value

2021-03-13 Thread Sergei Shtylyov
Hello again. :-) Now, 2 patches to the different files shouldn't have and identical subject! And the patch subject should reflect the exact patch locus, e.g. "sata_highbank: delete redundant printing of return value". On 3/13/21 10:47 AM, Wang Qing wrote: > platform_get_irq() has already

Re: [PATCH 1/2] ata: delete redundant printing of return value

2021-03-13 Thread Sergei Shtylyov
Hello! The patch subject should reflect the exact patch locus, e.g. "ata: libahci_platform: delete redundant printing of return value". On 3/13/21 10:46 AM, Wang Qing wrote: > platform_get_irq() has already checked and printed the return value, > the printing here is nothing special, it is

Re: [PATCH] ata: Trivial spelling fixes in the file pata_ns87415.c

2021-03-12 Thread Sergei Shtylyov
Hello! For the future, the driver name should go instead (or after) the "ata: ", like this: "pata_ns87415: Trivial spelling fixes". MBR, Sergei

Re: [PATCH v4 3/7] MIPS: Loongson64: Add support for the Loongson-2K1000 to get cpu_clock_freq

2021-03-10 Thread Sergei Shtylyov
Hello! On 10.03.2021 10:56, Qing Zhang wrote: Get the fixed-clock from the CPU0 node of the device tree. Signed-off-by: Jiaxun Yang Signed-off-by: Qing Zhang Tested-by: Ming Wang --- v3-v4: Standard submission of information Add return after error arch/mips/loongson64/time.c |

Re: [PATCH v3 5/7] irqchip/loongson-liointc: irqchip add 2.0 version

2021-03-10 Thread Sergei Shtylyov
Hello! On 10.03.2021 5:26, zhangqing wrote: [...] +    if (of_device_is_compatible(node, "loongson,liointc-2.0")) { +    base = liointc_get_reg_byname(node, "main"); +    if (!base) { +    err = -ENODEV; +    goto out_free_priv; +    } +    for (i = 0; i <

Re: [PATCH] usb: typec: tcpm: turn tcpm_ams_finish into void function

2021-03-08 Thread Sergei Shtylyov
Hello! On 08.03.2021 9:21, Yang Li wrote: This function always return '0' and no callers use the return value. Returns. So make it a void function. This eliminates the following coccicheck warning: ./drivers/usb/typec/tcpm/tcpm.c:778:5-8: Unneeded variable: "ret". Return "0" on line

Re: [PATCH 03/17] usb: xhci-mtk: get the microframe boundary for ESIT

2021-03-05 Thread Sergei Shtylyov
Hello! On 05.03.2021 12:02, Chunfeng Yun wrote: Tune the boundary for FS/LS ESIT due to CS: For ISOC out-ep, the controller starts transfer data after the first SS; for others, the data is already transfered Transferred. before the last CS. Signed-off-by: Chunfeng Yun ---

Re: [PATCH] arch: mips: sibyte: Return -EFAULT if copy_to_user() fails

2021-03-01 Thread Sergei Shtylyov
Hello! On 01.03.2021 9:33, Wang Qing wrote: The copy_to_user() function returns the number of bytes remaining to be copied, but we want to return -EFAULT if the copy doesn't complete. Then 'err' is hardly a good name for that variable. :-) Signed-off-by: Wang Qing ---

Re: [PATCH 19/20] usbip: usbip_host: Manual replacement of the deprecated strlcpy() with return values

2021-02-28 Thread Sergei Shtylyov
Hello! On 22.02.2021 18:12, Romain Perier wrote: The strlcpy() reads the entire source buffer first, it is dangerous if the source buffer lenght is unbounded or possibility non NULL-terminated. Length. Possibly? It can lead to linear read overflows, crashes, etc... As recommended in

Re: [PATCH 1/2] list: Add list_is_null() to check if a list_head has been initialized

2021-02-27 Thread Sergei Shtylyov
Hello! On 27.02.2021 1:49, Laurent Pinchart wrote: From: Laurent Pinchart The new function checks if the list_head prev and next pointers are NULL, in order to see if a list_head that has been zeroed when allocated has been initialized with INIT_LIST_HEAD() or added to a list. So zeroed

Re: [PATCH 3/7] dt-bindings: misc: Add binding for R-Car DAB

2021-02-26 Thread Sergei Shtylyov
Hello! On 26.02.2021 1:51, Fabrizio Castro wrote: Document bindings for R-Car DAB hardware accelerator, currently found on the r8a77990 SoC (a.k.a. R-Car E3) and on the r8a77965 SoC (a.k.a. R-Car M3-N). Signed-off-by: Fabrizio Castro --- .../devicetree/bindings/misc/renesas,dab.yaml | 75

Re: usb: dwc3: gadget: Change runtime pm function for DWC3 runtime suspend

2021-02-14 Thread Sergei Shtylyov
Hello! On 15.02.2021 5:38, Daehwan Jung wrote: It seems pm_runtime_put calls runtime_idle callback not runtime_suspend callback. It's better to use pm_runtime_put_sync_suspend to allow DWC3 runtime suspend. Signed-off-by: Daehwan Jung --- drivers/usb/dwc3/gadget.c | 2 +- 1 file changed,

Re: [PATCH] usb: host: ehci: remove casting dma_alloc_coherent

2021-02-04 Thread Sergei Shtylyov
Hello! On 04.02.2021 10:17, Xu Wang wrote: Remove casting the values returned by dma_alloc_coherent. I'm not seeing any casting, I'm seeing a trailing space removed. Signed-off-by: Xu Wang --- drivers/usb/host/ehci-mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 02/27] x86/syscalls: fix -Wmissing-prototypes warnings from COND_SYSCALL()

2021-01-28 Thread Sergei Shtylyov
Hello! On 28.01.2021 3:50, Masahiro Yamada wrote: Building kernel/sys_ni.c with W=1 omits tons of -Wmissing-prototypes Emits? warnings. $ make W=1 kernel/sys_ni.o [ snip ] CC kernel/sys_ni.o In file included from kernel/sys_ni.c:10:

Re: [PATCH 02/27] x86/syscalls: fix -Wmissing-prototypes warnings from COND_SYSCALL()

2021-01-28 Thread Sergei Shtylyov
On 28.01.2021 10:59, Sergei Shtylyov wrote: [...] Building kernel/sys_ni.c with W=1 omits tons of -Wmissing-prototypes    Emits? warnings. $ make W=1 kernel/sys_ni.o    [ snip ]    CC  kernel/sys_ni.o In file included from kernel/sys_ni.c:10: ./arch/x86/include/asm/syscall_wrapper.h

Re: [RE-RESEND PATCH 1/4] usb: musb: Fix runtime PM race in musb_queue_resume_work

2021-01-23 Thread Sergei Shtylyov
On 1/23/21 5:24 PM, Paul Cercueil wrote: > musb_queue_resume_work() would call the provided callback if the runtime > PM status was 'active'. Otherwise, it would enqueue the request if the > hardware was still suspended (musb->is_runtime_suspended is true). > > This causes a race with the

Re: [PATCH] sh_eth: Fix power down vs. is_opened flag ordering

2021-01-18 Thread Sergei Shtylyov
untime_put_sync(), as > there is no reason to do a synchronous power down. > > Fixes: 7fa2955ff70ce453 ("sh_eth: Fix sleeping function called from invalid > context") > Signed-off-by: Geert Uytterhoeven Reviewed-by: Sergei Shtylyov [...] MBR, Sergei

Re: [PATCH V2 4/4] net: ethernet: ravb: Enable optional refclk

2021-01-16 Thread Sergei Shtylyov
Hello! On 15.01.2021 23:19, Adam Ford wrote: For devices that use a programmable clock for the avb reference clock, AVB. the driver may need to enable them. Add code to find the optional clock and enable it when available. Signed-off-by: Adam Ford [...] diff --git

Re: [PATCH next 12/15] arm64: dts: mediatek: mt8183: fix dtbs_check warning

2021-01-16 Thread Sergei Shtylyov
On 16.01.2021 12:06, Chunfeng Yun wrote: Harmonize node names, compatibles and properties. Signed-off-by: Chunfeng Yun --- arch/arm64/boot/dts/mediatek/mt8183.dtsi | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi

Re: [PATCH next 11/15] arm64: dts: mediatek: mt7622: harmonize node names and compatibles

2021-01-16 Thread Sergei Shtylyov
Hello! On 16.01.2021 12:06, Chunfeng Yun wrote: This is used to fix dtbs_check warning Signed-off-by: Chunfeng Yun --- arch/arm64/boot/dts/mediatek/mt7622.dtsi | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/mediatek/mt7622.dtsi

Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe

2021-01-14 Thread Sergei Shtylyov
On 1/12/21 2:15 PM, Sergei Shtylyov wrote: [...] >> From: Menglong Dong >> >> Coccinelle reports a redundant error print in rb532_pata_driver_probe. >> As 'platform_get_irq' already prints the error message, error print >> here is redundant and can be removed. >

Re: [PATCH 2/2] compiler.h: Include asm/rwonce.h under ARM64 and ALPHA to fix build errors

2021-01-14 Thread Sergei Shtylyov
Hello! On 13.01.2021 13:57, Tiezhu Yang wrote: When make M=samples/bpf on the Loongson 3A3000 platform which belongs to MIPS arch, there exists many similar build errors about 'asm/rwonce.h' file not found, so include it only under CONFIG_ARM64 and CONFIG_ALPHA due to it exists only in arm64

Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe

2021-01-14 Thread Sergei Shtylyov
Hello! On 13.01.2021 17:04, Menglong Dong wrote: [...] irq = platform_get_irq(pdev, 0); - if (irq <= 0) { - dev_err(>dev, "no IRQ resource found\n"); + if (irq <= 0) return -ENOENT; This still beaks the probe deferral. :-( But that's another

Re: [PATCH v7 4/7] dt-bindings: media: max9286: Document 'maxim,reverse-channel-microvolt'

2021-01-14 Thread Sergei Shtylyov
Hello! On 13.01.2021 21:55, Jacopo Mondi wrote: Document the 'reverse-channel-microvolt' vendor property in the Where is "maxim,"? bindings document of the max9286 driver. The newly introduced property allows to specifying the initial Specify? configuration of the GMSL reverse

Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe

2021-01-12 Thread Sergei Shtylyov
Hello! On 1/12/21 5:36 AM, menglong8.d...@gmail.com wrote: > From: Menglong Dong > > Coccinelle reports a redundant error print in rb532_pata_driver_probe. > As 'platform_get_irq' already prints the error message, error print > here is redundant and can be removed. > > Signed-off-by: Menglong

Re: [PATCH] usb/c67x00: Replace tasklet with work

2021-01-11 Thread Sergei Shtylyov
Hello! On 11.01.2021 7:40, Davidlohr Bueso wrote: Tasklets have long been deprecated as being too heavy on the system by running in irq context - and this is not a performance critical path. If a higher priority process wants to run, it must wait for the tasklet to finish before doing so.

Re: [PATCH 1/2] spi: rpc-if: Avoid use of C++ style comments

2020-12-30 Thread Sergei Shtylyov
On 12/30/20 5:57 PM, Lad Prabhakar wrote: > Replace C++ style comment with C style. Note that the switch to // was made following the SPI maintainer's request... > Signed-off-by: Lad Prabhakar [...] MBR, Sergei

Re: [PATCH 2/4] ARM: dts: renesas: Add fck to etheravb-rcar-gen2 clock-names list

2020-12-29 Thread Sergei Shtylyov
On 29.12.2020 0:31, Adam Ford wrote: The bindings have been updated to support two clocks, but the original clock now requires the name fck. Add a clock-names list in the device tree with fck in it. Hopefully this won't break RPM... Signed-off-by: Adam Ford [...] MBR, Sergei

Re: [PATCH 4/4] net: ethernet: ravb: Name the AVB functional clock fck

2020-12-29 Thread Sergei Shtylyov
On 29.12.2020 0:31, Adam Ford wrote: The bindings have been updated to support two clocks, but the original clock now requires the name fck to distinguish it from the other. Signed-off-by: Adam Ford Reviewed-by: Sergei Shtylyov MBR, Sergei

Re: [PATCH 1/4] dt-bindings: net: renesas,etheravb: Add additional clocks

2020-12-29 Thread Sergei Shtylyov
Hello! On 29.12.2020 0:31, Adam Ford wrote: The AVB driver assumes there is an external clock, but it could be driven by an external clock. Driver can be driven by external clock? :-) In order to enable a programmable clock, it needs to be added to the clocks list and enabled in the

Re: [PATCH v4 2/4] spi: ls7a: Add YAML schemas

2020-12-25 Thread Sergei Shtylyov
On 12/25/20 1:35 PM, Qing Zhang wrote: > Switch the DT binding to a YAML schema to enable the DT validation. > > Signed-off-by: Qing Zhang > --- > > v4: fix warnings/errors about running 'make dt_binding_check' > > --- > .../devicetree/bindings/spi/loongson,spi-ls7a.yaml | 46 >

Re: [PATCH V2 2/9] arm64: dts: renesas: beacon kit: Fix Audio Clock sources

2020-12-25 Thread Sergei Shtylyov
On 24.12.2020 20:04, Adam Ford wrote: The SoC was expecting two clock sources with different frequencies. One to support 44.1KHz and one to support 48KHz. With the newly added ability to configure the programmably clock, configure both clocks. Programmable. Assign the rcar-sound clocks

Re: [PATCH V2 5/9] arm64: dts: renesas: beacon: Cleanup USB References

2020-12-25 Thread Sergei Shtylyov
On 24.12.2020 20:04, Adam Ford wrote: The programmable versaclock is used for the usb_extal reference clock for the EHCI driver instead of a fixed-clock. Because the versaclock needs to be enabled, the clock reference needs to be added to the clocks list. For the USB3 Phy, the perferred clock

Re: [PATCH V2 8/9] arm64: dts: renesas: Introduce r8a774e1-beacon-rzg2h-kit

2020-12-25 Thread Sergei Shtylyov
On 24.12.2020 20:05, Adam Ford wrote: eacon EmebeddedWorks is introducing a new kit based on the Beacon? RZ/G2H SoC from Renesas. The SOM supports eMMC, WiFi and Bluetooth, along with a Cat-M1 cellular radio. The Baseboard has Ethernet, USB, HDMI, stereo audio in and out, along with a

Re: [PATCH v7 10/12] mfd: bd9571mwv: Use devm_regmap_add_irq_chip()

2020-12-24 Thread Sergei Shtylyov
Hello! On 24.12.2020 10:04, Yoshihiro Shimoda wrote: Use dev_regmap_add_irq_chip() to simplify the code. devm_? Signed-off-by: Yoshihiro Shimoda Acked-for-MFD-by: Lee Jones Reviewed-by: Matti Vaittinen Reviewed-by: Geert Uytterhoeven --- drivers/mfd/bd9571mwv.c | 27

Re: [PATCH v5 05/12] regulator: bd9571mwv: Add BD9574MWF support

2020-12-23 Thread Sergei Shtylyov
On 22.12.2020 14:22, Yoshihiro Shimoda wrote: Add support for BD9574MWF which is silimar chip with BD9571MWV. Similar (again)? :-) Note that we don't support voltage rails VD{09,18,25,33} by this driver on BD9574. The VD09 voltage could be read from PMIC but that is not supported by this

Re: [PATCH v5 08/12] gpio: bd9571mwv: Add BD9574MWF support

2020-12-23 Thread Sergei Shtylyov
Hello! On 22.12.2020 14:22, Yoshihiro Shimoda wrote: Add support for BD9574MWF which is silimar chip with BD9571MWV. Similar? :-) Note that BD9574MWF has additional features "RECOV_GPOUT", "FREQSEL" and "RTC_IN", but supports GPIO function only. Signed-off-by: Yoshihiro Shimoda

Re: [PATCH v1 1/8] usb: phy: tegra: Add delay after power up

2020-12-16 Thread Sergei Shtylyov
Hello! On 15.12.2020 23:21, Dmitry Osipenko wrote: The PHY hardware needs the delay of 2ms after power up, otherwise initial interrupt may be lost if USB controller is accessed before PHY is settled down. Previously this issue was masked by implicit delays, but now it pops up after squashing

Re: [RFC] ravb: Add support for optional txc_refclk

2020-12-12 Thread Sergei Shtylyov
Hello! On 12.12.2020 19:56, Adam Ford wrote: The SoC expects the txv_refclk is provided, but if it is provided by a programmable clock, there needs to be a way to get and enable this clock to operate. It needs to be optional since it's only necessary for those with programmable clocks.

Re: [PATCH v3] usb: musb: remove unused variable 'devctl'

2020-12-10 Thread Sergei Shtylyov
On 12/10/20 6:01 PM, Greg Kroah-Hartman wrote: [...] >>> From: Min Guo >>> >>> Remove unused 'devctl' variable to fix compile warnings: >>> >>> drivers/usb/musb/musbhsdma.c: In function 'dma_controller_irq': >>> drivers/usb/musb/musbhsdma.c:324:8: warning: variable 'devctl' set >>>

Re: [PATCH v2 2/4] spi: Add devicetree bindings documentation for Loongson SPI

2020-12-08 Thread Sergei Shtylyov
On 12/8/20 1:47 PM, zhangqing wrote: >>> Add spi-ls7a binding documentation. >>> >>> Signed-off-by: Qing Zhang >>> --- >>>   Documentation/devicetree/bindings/spi/spi-ls7a.txt | 31 >>> ++ >>>   1 file changed, 31 insertions(+) >>>   create mode 100644

Re: [PATCH v2 2/4] spi: Add devicetree bindings documentation for Loongson SPI

2020-12-08 Thread Sergei Shtylyov
Hello! On 08.12.2020 10:44, Qing Zhang wrote: Add spi-ls7a binding documentation. Signed-off-by: Qing Zhang --- Documentation/devicetree/bindings/spi/spi-ls7a.txt | 31 ++ 1 file changed, 31 insertions(+) create mode 100644

Re: [PATCH v2 0/5] memory: renesas-rpc-if: Trivial fixes

2020-11-26 Thread Sergei Shtylyov
On 11/26/20 10:11 PM, Lad Prabhakar wrote: > This patch series fixes trivial issues in RPC-IF driver. > > Changes for v2: > * Balanced PM in rpcif_disable_rpm > * Fixed typo in patch 4/5 > * Dropped C++ style fixes patch The part that fixed the comment style wasd good, you should\ve kept

Re: [PATCH v2 2/5] memory: renesas-rpc-if: Fix unbalanced pm_runtime_enable in rpcif_{enable,disable}_rpm

2020-11-26 Thread Sergei Shtylyov
ytterhoeven Reported by reported? :-) > Signed-off-by: Lad Prabhakar > Cc: sta...@vger.kernel.org Reviewed-by: Sergei Shtylyov [...] MBR, Sergei

Re: [PATCH 5/5] memory: renesas-rpc-if: Fix a reference leak in rpcif_probe()

2020-11-25 Thread Sergei Shtylyov
d Prabhakar > Cc: sta...@vger.kernel.org Reviewed-by: Sergei Shtylyov [...] MBR, Sergei

Re: [PATCH 3/5] memory: renesas-rpc-if: Export symbols as GPL

2020-11-25 Thread Sergei Shtylyov
On 24.11.2020 14:25, Lad Prabhakar wrote: Renesas RPC-IF driver is licensed under GPL2.0, to be in sync export the symbols as GPL. Didn't know there's a connection... Suggested-by: Pavel Machek Signed-off-by: Lad Prabhakar Reviewed-by: Sergei Shtylyov [...] MBR, Sergei

Re: [PATCH 1/5] memory: renesas-rpc-if: Return correct value to the caller of rpcif_manual_xfer()

2020-11-25 Thread Sergei Shtylyov
Signed-off-by: Lad Prabhakar Cc: sta...@vger.kernel.org Reviewed-by: Sergei Shtylyov MBR, Sergei

Re: [PATCH 4/5] memory: renesas-rpc-if: Avoid use of C++ style comments

2020-11-24 Thread Sergei Shtylyov
On 11/24/20 2:25 PM, Lad Prabhakar wrote: > Replace C++ style comment with C style. Thanks, I've overlooked this, and the header files should use C style comment, not C++. > While at it also replace the tab with a space between struct and > struct name. No connection between these 2

Re: [PATCH 0/5] memory: renesas-rpc-if: Trivial fixes

2020-11-24 Thread Sergei Shtylyov
On 11/24/20 2:34 PM, Lad, Prabhakar wrote: [...] >> This patch series fixes trivial issues in RPC-IF driver. >> >> Cheers, >> Prabhakar >> >> Lad Prabhakar (5): >> memory: renesas-rpc-if: Return correct value to the caller of >> rpcif_manual_xfer() >> memory: renesas-rpc-if: Make

Re: [PATCH 2/5] memory: renesas-rpc-if: Make rpcif_enable/disable_rpm() as static inline

2020-11-24 Thread Sergei Shtylyov
Hello! On 11/24/20 2:25 PM, Lad Prabhakar wrote: > Define rpcif_enable_rpm() and rpcif_disable_rpm() as static Not sure why I didn't do it this way myself... > inline in the header instead of exporting it. s/it/them/. > Suggested-by: Pavel Machek > Signed-off-by: Lad Prabhakar > ---

Re: [PATCH v3] usb: musb: remove unused variable 'devctl'

2020-11-24 Thread Sergei Shtylyov
On 11/24/20 12:13 PM, Sergei Shtylyov wrote: [...] >> From: Min Guo >> >> Remove unused 'devctl' variable to fix compile warnings: >> >> drivers/usb/musb/musbhsdma.c: In function 'dma_controller_irq': >> drivers/usb/musb/musbhsdma.c:3

Re: [PATCH v3] usb: musb: remove unused variable 'devctl'

2020-11-24 Thread Sergei Shtylyov
Hello! On 24.11.2020 11:49, min@mediatek.com wrote: From: Min Guo Remove unused 'devctl' variable to fix compile warnings: drivers/usb/musb/musbhsdma.c: In function 'dma_controller_irq': drivers/usb/musb/musbhsdma.c:324:8: warning: variable 'devctl' set but not used

Re: [PATCH 1/2] media: max9271: Fix GPIO enable/disable

2020-11-23 Thread Sergei Shtylyov
On 11/20/20 7:15 PM, Jacopo Mondi wrote: > Fix GPIO enable/disable operations which wrongly read the 0x0f register > to obtain the current mask of the enabled lines instead of using > the correct 0x0e register. > > Also fix access to bit 0 of the register which is marked as reserved. > > Fixes:

Re: [PATCH] usbnet: ipheth: fix connectivity with iOS 14

2020-11-20 Thread Sergei Shtylyov
Hello! On 19.11.2020 20:24, Yves-Alexis Perez wrote: Starting with iOS 14 released in September 2020, connectivity using the personal hotspot USB tethering function of iOS devices is broken. Communication between the host and the device (for example ICMP traffic or DNS resolution using the

Re: [PATCH 3/3] MIPS: KASLR: Make relocation_address can be configured

2020-11-19 Thread Sergei Shtylyov
Hello! On 19.11.2020 5:29, Jinyang He wrote: When CONFIG_RANDOMIZE_BASE is not set, determine_relocation_address() always returns a constant. It is not friendly to users if the address cannot be used. Make it can be configured at Kconfig. Make it configurable? Signed-off-by: Jinyang He

Re: [PATCH] USB: quirks: Add USB_QUIRK_DISCONNECT_SUSPEND quirk for Lenovo A630Z TIO built-in usb-audio card

2020-11-18 Thread Sergei Shtylyov
Hello! On 18.11.2020 11:56, penghao wrote: Add a USB_QUIRK_DISCONNECT_SUSPEND quirk for the Lenovo TIO built-in usb-audio. when A630Z going into S3,the system immediately wakeup 7-8 seconds later by usb-audio disconnect interrupt to avoids the issue. Seeking a better fix, we've tried a lot of

Re: [RFC PATCH] MIPS: Kconfig: Select ARCH_WANT_FRAME_POINTERS

2020-11-16 Thread Sergei Shtylyov
On 16.11.2020 12:47, Tiezhu Yang wrote: [...] Select ARCH_WANT_FRAME_POINTERS to fix the following build error under CONFIG_DEBUG_ATOMIC_SLEEP:    CC  arch/mips/kernel/signal.o {standard input}: Assembler messages: {standard input}:1775: Error: Unable to parse register name $fp

Re: [RFC PATCH] MIPS: Kconfig: Select ARCH_WANT_FRAME_POINTERS

2020-11-16 Thread Sergei Shtylyov
Hello! On 16.11.2020 8:03, Tiezhu Yang wrote: Select ARCH_WANT_FRAME_POINTERS to fix the following build error under CONFIG_DEBUG_ATOMIC_SLEEP: CC arch/mips/kernel/signal.o {standard input}: Assembler messages: {standard input}:1775: Error: Unable to parse register name $fp

Re: [PATCH 2/2] MAINTAINERS: Set myself as Goldfish RTC maintainer

2020-11-14 Thread Sergei Shtylyov
Hello! On 11/14/20 4:09 PM, Jiaxun Yang wrote: > While Gildfish platform is dusted, the RTC driver remains Goldfish. :-) > valuable for us. > > I'm volunteering to maintain goldfish RTC driver onward. > > Signed-off-by: Jiaxun Yang > Cc: Miodrag Dinic [...] MBR, Sergei

Re: [PATCH v4 8/8] [DNI] arm64: dts: renesas: eagle: Specify channel amplitude

2020-11-12 Thread Sergei Shtylyov
On 11/12/20 7:27 PM, Jacopo Mondi wrote: > Use the newly introduced 'maxim,maxim,initial-reverse-channel-mV' "maxim," repeated twice. > property to specify the initial reverse channel amplitude when the > remote serializers are not pre-programmed with noise immunity threshold > enabled. > >

Re: [PATCH resend2] sh/intc: Restore devm_ioremap() alignment

2020-11-10 Thread Sergei Shtylyov
Hello! On 11/10/20 6:49 PM, Geert Uytterhoeven wrote: > Restore alignment of the continuation of the devm_ioremap() call in It's a plain ioremap() call below, isn't it, :-) > register_intc_controller(). > > Fixes: 4bdc0d676a643140 ("remove ioremap_nocache and devm_ioremap_nocache") >

Re: [PATCH] MIPS: BMC47xx: fix kconfig dependency bug for BCM47XX_SSB

2020-11-06 Thread Sergei Shtylyov
Hello! On 04.11.2020 19:41, Necip Fazil Yildiran wrote: When BCM47XX_SSB is enabled and SSB_PCIHOST is disabled, it results in the following Kbuild warning: WARNING: unmet direct dependencies detected for SSB_B43_PCI_BRIDGE Depends on [n]: SSB [=y] && SSB_PCIHOST [=n] Selected by [y]:

Re: [PATCH AUTOSEL 4.19 08/60] MIPS: ftrace: Remove redundant #ifdef CONFIG_DYNAMIC_FTRACE

2020-10-27 Thread Sergei Shtylyov
Hello! On 27.10.2020 3:03, Sasha Levin wrote: From: Zejiang Tang [ Upstream commit 39116103a7345927fa99644d08bc0cc9d45fea6f ] There exists redundant #ifdef CONFIG_DYNAMIC_FTRACE in ftrace.c, remove it. Signed-off-by: Zejiang Tang Reviewed-by: Steven Rostedt (VMware) Signed-off-by: Thomas

Re: [PATCH net] ravb: Fix bit fields checking in ravb_hwtstamp_get()

2020-10-24 Thread Sergei Shtylyov
g eth0 > flags = 0 > tx_type = OFF > rx_filter = PTP_V2_L2_EVENT > > Correct this by converting if-else's to switch. > > Fixes: c156633f1353 ("Renesas Ethernet AVB driver proper") > Reported-by: Julia Lawall > Signed-off-by: Andrew Gabbasov Reviewed-by: Sergei Shtylyov [...] MBR, Sergei

Re: [PATCH net] ravb: Fix bit fields checking in ravb_hwtstamp_get()

2020-10-24 Thread Sergei Shtylyov
Hello! On 10/19/20 10:32 AM, Andrew Gabbasov wrote: Sorry for the delay again, I keep forgetting about the mails I' couldn't reply quickly. :-| [...] >>The patch was set to the "Changes Requested" state -- most probably >> because of this >> mail. Though unintentionally, it served to

Re: [PATCH v1] usb: dwc3: core: fix a issue about clear connect state

2020-10-18 Thread Sergei Shtylyov
Hello! On 10/18/20 4:47 PM, Dejin Zheng wrote: > According to Synopsys Programming Guide chapter 2.2 Register Resets, > it cannot reset the DCTL register by set DCTL.CSFTRST for Core Soft Reset, s/set/setting/. > if DWC3 controller as a slave device and stay connected with a usb host, >

Re: [PATCH net] ravb: Fix bit fields checking in ravb_hwtstamp_get()

2020-10-17 Thread Sergei Shtylyov
Hello! On 10/1/20 10:13 AM, Andrew Gabbasov wrote: The patch was set to the "Changes Requested" state -- most probably because of this mail. Though unintentionally, it served to throttle actions on this patch. I did only remember about this patch yesterday... :-) [...] >> In the function

  1   2   3   4   5   6   7   8   9   10   >