Hi Chris & Ulf,
I hope you find this patch for next.
Thanks,
Seungwon Jeon
On Wed, May 21, 2014, Seungwon Jeon wrote:
> On Wed, May 21, 2014, Doug Anderson wrote:
> > If we happened to get a data error at just the wrong time the dw_mmc
> > driver could get into a state w
Hi Chris Ulf,
I hope you find this patch for next.
Thanks,
Seungwon Jeon
On Wed, May 21, 2014, Seungwon Jeon wrote:
On Wed, May 21, 2014, Doug Anderson wrote:
If we happened to get a data error at just the wrong time the dw_mmc
driver could get into a state where it would never complete
mmc: dw_mmc: change to use recommended reset
procedure"
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
> ---
> Changes in v2:
> - Removed TODO
> - Set cmd to NULL before calling dw_mci_request_end()
>
> drivers/mmc/host/dw_mmc.c | 46 ++
procedure
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
---
Changes in v2:
- Removed TODO
- Set cmd to NULL before calling dw_mci_request_end()
drivers/mmc/host/dw_mmc.c | 46 ++
1 file changed, 46 insertions(+)
diff --git
...and they think something is wrong with their hardware.
>
> Remove the printouts. We'll leave it up to a higher level to report
> about errors.
Yes, your saying makes sense.
But in normal I/O, actual error information such as status below is useful,
isn't it?
Thanks,
Seungwon Jeon
>
is wrong with their hardware.
Remove the printouts. We'll leave it up to a higher level to report
about errors.
Yes, your saying makes sense.
But in normal I/O, actual error information such as status below is useful,
isn't it?
Thanks,
Seungwon Jeon
Signed-off-by: Doug Anderson diand
On Tue, April 22, 2014, Ulf Hansson wrote:
> On 22 April 2014 12:53, Seungwon Jeon wrote:
> > On Tue, April 22, 2014, Ulf Hansson wrote:
> >> On 22 April 2014 08:57, Seungwon Jeon wrote:
> >> > As commit 3957848(mmc: drop the speed mode of card's state) appl
On Tue, April 22, 2014, Ulf Hansson wrote:
> On 22 April 2014 08:57, Seungwon Jeon wrote:
> > As commit 3957848(mmc: drop the speed mode of card's state) applies,
> > this change should be followed.
> >
> > drivers/net/wireless/rsi/rsi_91x_sdio.c:288:20: error
of
function 'mmc_card_set_highspeed' [-Werror=implicit-function-declaration]
drivers/net/wireless/rsi/rsi_91x_sdio.c:306:2: error: implicit declaration of
function 'mmc_card_highspeed' [-Werror=implicit-function-declaration]
Signed-off-by: Seungwon Jeon
---
drivers/net/wireless/rsi/rsi_91x_sdio.c
of
function 'mmc_card_set_highspeed' [-Werror=implicit-function-declaration]
drivers/net/wireless/rsi/rsi_91x_sdio.c:306:2: error: implicit declaration of
function 'mmc_card_highspeed' [-Werror=implicit-function-declaration]
Signed-off-by: Seungwon Jeon tgih@samsung.com
---
drivers/net/wireless
On Tue, April 22, 2014, Ulf Hansson wrote:
On 22 April 2014 08:57, Seungwon Jeon tgih@samsung.com wrote:
As commit 3957848(mmc: drop the speed mode of card's state) applies,
this change should be followed.
drivers/net/wireless/rsi/rsi_91x_sdio.c:288:20: error:
'MMC_STATE_HIGHSPEED
On Tue, April 22, 2014, Ulf Hansson wrote:
On 22 April 2014 12:53, Seungwon Jeon tgih@samsung.com wrote:
On Tue, April 22, 2014, Ulf Hansson wrote:
On 22 April 2014 08:57, Seungwon Jeon tgih@samsung.com wrote:
As commit 3957848(mmc: drop the speed mode of card's state) applies
next-20140417 for today.
I didn't detect usage out of mmc-sub for that.
Let me fix and send a patch.
Thanks,
Seungwon Jeon
> --
> Cheers,
> Stephen Rothwells...@canb.auug.org.au
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
-declaration]
if (mmc_card_highspeed(card))
^
Caused by commit 395784826a81 (mmc: drop the speed mode of card's state).
I have used the version of the mmc tree from next-20140417 for today.
I didn't detect usage out of mmc-sub for that.
Let me fix and send a patch.
Thanks,
Seungwon Jeon
; > Reported by: Harold (SoonYeal) Yang
> > Signed-off-by: Ray Jui
> > Reviewed-by: Seungwon Jeon
> > ---
> > drivers/mmc/card/block.c |7 ---
> > 1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/mmc/card/block.c b
...@broadcom.com
Reviewed-by: Seungwon Jeon tgih@samsung.com
---
drivers/mmc/card/block.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index 1a3163f..4e8212c 100644
--- a/drivers/mmc/card/block.c
On Tue, October 29, 2013, Doug Anderson wrote
> Seungwon,
>
> On Fri, Oct 25, 2013 at 2:29 AM, Seungwon Jeon wrote:
> >> By SDIO devices, are you referring to actual SDIO cards or some
> >> implementations of dw_mmc?
> >>
> >> As far as I unders
On Tue, October 29, 2013, Doug Anderson wrote
Seungwon,
On Fri, Oct 25, 2013 at 2:29 AM, Seungwon Jeon tgih@samsung.com wrote:
By SDIO devices, are you referring to actual SDIO cards or some
implementations of dw_mmc?
As far as I understand in the CLKENA description in the generic
_flags like below.
unsigned int cmd_flags = req ? req->cmd_flags : 0;
Then, we could replace several 'if statement' without dereference.
if (req && req->cmd_flags & REQ_DISCARD) -> if (cmd_flags & REQ_DISCARD)
Just my suggestion.
Thanks,
Seungwon Jeon
> struct
On Thu, October 24, 2013, Doug Anderson wrote:
> Seungwon,
>
> On Wed, Oct 23, 2013 at 12:25 PM, Seungwon Jeon wrote:
> >> >> + if (card->type == MMC_TYPE_SDIO ||
> >> >> + card->type == MMC_TYPE_SD_COMBO) {
> > &a
On Thu, October 24, 2013, Doug Anderson wrote:
Seungwon,
On Wed, Oct 23, 2013 at 12:25 PM, Seungwon Jeon tgih@samsung.com wrote:
+ if (card-type == MMC_TYPE_SDIO ||
+ card-type == MMC_TYPE_SD_COMBO) {
card-quirks MMC_QUIRK_BROKEN_CLK_GATING
How about
;
Then, we could replace several 'if statement' without dereference.
if (req req-cmd_flags REQ_DISCARD) - if (cmd_flags REQ_DISCARD)
Just my suggestion.
Thanks,
Seungwon Jeon
struct mmc_blk_data *md = mq-data;
struct mmc_card *card = md-queue.card;
struct mmc_host *host = card
_PRV_DAT_WAIT, 0);
> >> + clk_en_a_old = mci_readl(host, CLKENA);
> >> +
> >> + if (card->type == MMC_TYPE_SDIO ||
> >> + card->type == MMC_TYPE_SD_COMBO) {
&& card->quirks
deprecated APIs.
>
> Cc: Seungwon Jeon
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.ht
: Seungwon Jeon tgih@samsung.com
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
MMC_QUIRK_BROKEN_CLK_GATING?
Some sdio device can work with gating clock.
For this, mmc_fixup_device() should be called prior to init_card() in
core(sdio.c).
I guess you found that.
Thanks,
Seungwon Jeon
+ set_bit(DW_MMC_CARD_NO_LOW_PWR, slot-flags
Hi Ray,
Thank you for information. Your analysis is right.
I also noticed same problem.
If you'd like to submit patch, not to report, please send it with regular form.
Or I could send similar patch I have.
Thanks,
Seungwon Jeon
On Wed, Oct 23, 2013, Ray Jui wrote:
Hi Seungwon/Chris,
We
Hi Ray,
Thank you for information. Your analysis is right.
I also noticed same problem.
If you'd like to submit patch, not to report, please send it with regular form.
Or I could send similar patch I have.
Thanks,
Seungwon Jeon
On Wed, Oct 23, 2013, Ray Jui wrote:
Hi Seungwon/Chris,
We
"Bus speed (slot %d) = %dHz (slot req %dHz, actual
> %dHZ"
> - " div = %d)\n", slot->id, host->bus_hz, slot->clock,
> - div ? ((host->bus_hz / div) >> 1) : host->bus_hz, div);
> +
' is different with old one as well, it should be considered.
'div' can be a good factor to compare this condition. Then 'last_printed_clock'
should reflect clock divider.
Thanks,
Seungwon Jeon
+ dev_info(slot-mmc-class_dev,
+ Bus speed (slot %d) = %dHz
On Fri, August 30, 2013, Doug Anderson wrote:
> Seungwon,
>
> On Thu, Aug 29, 2013 at 12:04 AM, Seungwon Jeon wrote:
> >> I'd really still rather honor the MMC subsystem's request. It
> >> shouldn't _hurt_ to turn the clock off when the subsystem requests it,
On Thu, August 29, 2013, Mischa Jonker wrote:
> Adapt Kconfig to include ARC in supported architectures
>
> Signed-off-by: Mischa Jonker
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
> ---
> drivers/mmc/host/Kconfig |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(
On Tuesday, August 27, 2013, Doug Anderson wrote:
> Jaehoon / Seungwon,
>
> On Mon, Aug 26, 2013 at 2:06 AM, Jaehoon Chung wrote:
> > On 08/26/2013 01:34 PM, Seungwon Jeon wrote:
> >> On Fri, August 23, 2013, Doug Anderson wrote:
> >>> Previously the dw_
On Tuesday, August 27, 2013, Doug Anderson wrote:
Jaehoon / Seungwon,
On Mon, Aug 26, 2013 at 2:06 AM, Jaehoon Chung jh80.ch...@samsung.com wrote:
On 08/26/2013 01:34 PM, Seungwon Jeon wrote:
On Fri, August 23, 2013, Doug Anderson wrote:
Previously the dw_mmc driver would ignore any
On Thu, August 29, 2013, Mischa Jonker wrote:
Adapt Kconfig to include ARC in supported architectures
Signed-off-by: Mischa Jonker mjon...@synopsys.com
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
---
drivers/mmc/host/Kconfig |2 +-
1 file changed, 1 insertion
On Fri, August 30, 2013, Doug Anderson wrote:
Seungwon,
On Thu, Aug 29, 2013 at 12:04 AM, Seungwon Jeon tgih@samsung.com wrote:
I'd really still rather honor the MMC subsystem's request. It
shouldn't _hurt_ to turn the clock off when the subsystem requests it,
Even though turning
RV_DAT_WAIT, 0);
Basically dw_mmc driver uses host's low power mode(auto clock gating)
So, how about keeping origin code rather than programming clock setting to '0'?
> + } else if (slot->clock != host->current_speed || force_clkinit) {
And then, if condition('slot->clock
clock setting to '0'?
+ } else if (slot-clock != host-current_speed || force_clkinit) {
And then, if condition('slot-clock is not zero') is added in order to allow to
set clock,
print messages which Jaehoon pointed would be solved.
Thanks,
Seungwon Jeon
div = host-bus_hz
Hi Doug,
Do you have any update for this series?
Please let me know.
Thanks,
Seungwon Jeon
On Sat, August 10, 2013, Doug Anderson wrote:
> This series of patches addresses some suspend/resume problems with
> dw_mmc on exynos platforms, espeically exynos5420. Since
> suspend/resume is
Hi Doug,
Do you have any update for this series?
Please let me know.
Thanks,
Seungwon Jeon
On Sat, August 10, 2013, Doug Anderson wrote:
This series of patches addresses some suspend/resume problems with
dw_mmc on exynos platforms, espeically exynos5420. Since
suspend/resume is not fully
silent. Origin code has stood up somewhat
long.
Did you see?
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
>
> Signed-off-by: Derek Basehore
> Reviewed-by: Doug Anderson
> ---
> drivers/mmc/host/dw_mmc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>
should probably disable the clock to the card in the suspend
> path.
In suspend, clock is gated, isn't it?
Rather, no comment looks better, if intention is not clear.
Thanks,
Seungwon Jeon
> + */
> +static int dw_mci_exynos_suspend(struct device *dev)
> +{
> +
On Sat, August 10, 2013,Doug Anderson wrote:
> Seungwon,
>
> On Fri, Aug 9, 2013 at 6:35 AM, Seungwon Jeon wrote:
> > On Wed, August 07, 2013, Doug Anderson wrote:
> >> After suspend/resume all of the dw_mmc registers are reset to
> >> defaults. We restore mos
On Sat, August 10, 2013, Doug Anderson wrote:
> Seungwon and Jaehoon,
>
> On Fri, Aug 9, 2013 at 6:32 AM, Seungwon Jeon wrote:
> > On Wed, August 07, 2013, Doug Anderson wrote:
> >> The dw_mmc driver keeps a cache of the current slot->clock in order to
> >> a
On Sat, August 10, 2013, Doug Anderson wrote:
Seungwon and Jaehoon,
On Fri, Aug 9, 2013 at 6:32 AM, Seungwon Jeon tgih@samsung.com wrote:
On Wed, August 07, 2013, Doug Anderson wrote:
The dw_mmc driver keeps a cache of the current slot-clock in order to
avoid doing a whole lot
On Sat, August 10, 2013,Doug Anderson wrote:
Seungwon,
On Fri, Aug 9, 2013 at 6:35 AM, Seungwon Jeon tgih@samsung.com wrote:
On Wed, August 07, 2013, Doug Anderson wrote:
After suspend/resume all of the dw_mmc registers are reset to
defaults. We restore most of them
is not clear.
Thanks,
Seungwon Jeon
+ */
+static int dw_mci_exynos_suspend(struct device *dev)
+{
+ struct dw_mci *host = dev_get_drvdata(dev);
+
+ return dw_mci_suspend(host);
+}
+
+static int dw_mci_exynos_resume(struct device *dev)
+{
+ struct dw_mci *host = dev_get_drvdata
. Origin code has stood up somewhat
long.
Did you see?
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
Signed-off-by: Derek Basehore dbaseh...@chromium.org
Reviewed-by: Doug Anderson diand...@chromium.org
---
drivers/mmc/host/dw_mmc.c | 4 ++--
1 file changed, 2 insertions
ff().
On seeing fields of 'mmc->ios' stored last, these values aren't proper in
resume phase.
Please check mmc_power_off() function.
In case MMC_PM_KEEP_POWER it could be kept.
Thanks,
Seungwon Jeon
>
> There doesn't seem to be any reason that I can see _not_ to set things
> up after re
_noirq = dw_mci_exynos_resume_noirq;
> + dw_mci_exynos_pmops.thaw_noirq = dw_mci_exynos_resume_noirq;
> + dw_mci_exynos_pmops.restore_noirq = dw_mci_exynos_resume_noirq;
If CONFIG_PM_SLEEP is not defined, we don't need to add it.
And also, instead of reusing dw_mci_pltfm_pmops, how about defini
of 'dw_mci_setup_bus(slot, true)'.
Eventually, this change does same?
Thanks,
Seungwon Jeon
>
> Invalidating the current_speed also means that we don't need to call:
> dw_mci_setup_bus(slot, true);
> ...to force an update of the clock in the case when the slot was left
> power
does same?
Thanks,
Seungwon Jeon
Invalidating the current_speed also means that we don't need to call:
dw_mci_setup_bus(slot, true);
...to force an update of the clock in the case when the slot was left
powered.
Signed-off-by: Doug Anderson diand...@chromium.org
---
Changes in v4: None
with dw_mci_pltfm* just now.
But specific code for exynos would be added soon.
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
of 'mmc-ios' stored last, these values aren't proper in
resume phase.
Please check mmc_power_off() function.
In case MMC_PM_KEEP_POWER it could be kept.
Thanks,
Seungwon Jeon
There doesn't seem to be any reason that I can see _not_ to set things
up after resume. Restoring this state makes
is no actual use case for that though origin Synopsys IP
supports.
Multi-slot might be not useful in terms of performance because shared bus
should be allowed.
(At least this is the way I see it, though)
As Exynos's host does so, other hosts which are introduced in Linux seems use
one card pe
.
(At least this is the way I see it, though)
As Exynos's host does so, other hosts which are introduced in Linux seems use
one card per host.
If it's really not found now, I could agree on this topic.
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
On Tue, July 30, 2013, Mark Brown wrote:
> From: Mark Brown
>
> Use regulator_get_optional() to tell the core that requests for regulators
> can fail in a real system.
>
> Signed-off-by: Mark Brown
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
--
To unsubscribe from this l
On Tue, July 30, 2013, Mark Brown wrote:
From: Mark Brown broo...@linaro.org
Use regulator_get_optional() to tell the core that requests for regulators
can fail in a real system.
Signed-off-by: Mark Brown broo...@linaro.org
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon
x_noirq now.
I feel like it is for handling quirk.
If we meet use case for that in some day, it could be added commonly.
How do you think?
Thanks,
Seungwon Jeon
>
> Signed-off-by: Doug Anderson
> Reviewed-by: James Hogan
> ---
> Changes in v3:
> - Add freeze/thaw and poweroff/res
On Thu, July 11, 2013, Doug Anderson wrote:
> Seungwon,
>
> On Wed, Jul 10, 2013 at 7:54 AM, Seungwon Jeon wrote:
> > On Wed, July 10, 2013, Doug Anderson wrote:
> >> If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up
> >> looping around forev
On Thu, July 11, 2013, Doug Anderson wrote:
Seungwon,
On Wed, Jul 10, 2013 at 7:54 AM, Seungwon Jeon tgih@samsung.com wrote:
On Wed, July 10, 2013, Doug Anderson wrote:
If the WAKEUP_INT is asserted at wakeup and not cleared, we'll end up
looping around forever. This has been seen
use case for that in some day, it could be added commonly.
How do you think?
Thanks,
Seungwon Jeon
Signed-off-by: Doug Anderson diand...@chromium.org
Reviewed-by: James Hogan james.ho...@imgtec.com
---
Changes in v3:
- Add freeze/thaw and poweroff/restore noirq entries.
Changes in v2
of any
> boards that need DW_MCI_QUIRK_IDMAC_DTO.
>
> Signed-off-by: Doug Anderson
Acked-by: Seungwon Jeon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.ker
is bit is 1 to indicate that it fired and we can
> + * clear it by writing a 1 back. Clear it to prevent interrupts from going
> off
> + * constantly.
> + */
As I know this bit is auto-cleared.
Did you find the cause of this problem?
How about your GPIO setting in sleep?
Currently, we
is data to send), but it makes the
> register dump before and after suspend clean.
>
> Signed-off-by: Doug Anderson
Acked-by: Seungwon Jeon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kerne
), but it makes the
register dump before and after suspend clean.
Signed-off-by: Doug Anderson diand...@chromium.org
Acked-by: Seungwon Jeon tgih@samsung.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
off
+ * constantly.
+ */
As I know this bit is auto-cleared.
Did you find the cause of this problem?
How about your GPIO setting in sleep?
Currently, we don't know why the problem is happened.
At least, we should make it clear.
Thanks,
Seungwon Jeon
+
+static int dw_mci_exynos_resume_noirq
that need DW_MCI_QUIRK_IDMAC_DTO.
Signed-off-by: Doug Anderson diand...@chromium.org
Acked-by: Seungwon Jeon tgih@samsung.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
On Sat, June 29, 2013, Doug Anderson wrote:
> Seungwon,
>
> On Mon, Jun 24, 2013 at 1:04 AM, Seungwon Jeon wrote:
> > This patch looks good to me. I agree above.
> > Card detection procedure of mmc subsystem will be started by mmc_start_host
> > during probe time.
On Sat, June 29, 2013, Doug Anderson wrote:
Seungwon,
On Mon, Jun 24, 2013 at 1:04 AM, Seungwon Jeon tgih@samsung.com wrote:
This patch looks good to me. I agree above.
Card detection procedure of mmc subsystem will be started by mmc_start_host
during probe time.
There is no need
Hi Jaehoon,
Do you have the same result?
Could you share the result?
Thanks,
Seungwon Jeon
On Tuesday, June 25 2013, Bing Zhao wrote:
> > I think the proposal on the table is to take Seungwon's patches
> > instead of mine. Assuming they solve your problems, I'm OK with that.
>
Hi Jaehoon,
Do you have the same result?
Could you share the result?
Thanks,
Seungwon Jeon
On Tuesday, June 25 2013, Bing Zhao wrote:
I think the proposal on the table is to take Seungwon's patches
instead of mine. Assuming they solve your problems, I'm OK with that.
I think he
If a actual detection of card is triggered during probe, similar problem may be
occurred in spite of this patch.
Thanks,
Seungwon Jeon
>
> Specifically, I found that with just the right set of printouts in my
> system that one of the three SD/MMC devices in my system was having
> troubl
of card is triggered during probe, similar problem may be
occurred in spite of this patch.
Thanks,
Seungwon Jeon
Specifically, I found that with just the right set of printouts in my
system that one of the three SD/MMC devices in my system was having
trouble probing. It would get an err -123
On Thursday, June 13, 2013, Doug Anderson wrote:
> Seungwon,
>
> On Wed, Apr 10, 2013 at 12:02 AM, Seungwon Jeon wrote:
> >> > There are two solutions we have applied.
> >>
> >> I'm a little confused. Have you already applied one or both of the
&g
On Thursday, June 13, 2013, Doug Anderson wrote:
Seungwon,
On Wed, Apr 10, 2013 at 12:02 AM, Seungwon Jeon tgih@samsung.com wrote:
There are two solutions we have applied.
I'm a little confused. Have you already applied one or both of the
solutions you list below, or are you
Looks good to me.
But this patch has a dependency on '[PATCH 2/2] mmc: dw_mmc: Add support DW
SD/MMC driver on SOCFPGA'
After that, it can be applied.(SDMMC_CMD_USE_HOLD_REG should be moved in
dw_mmc.h)
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
On 06/11/13 2013 8:31 PM Heiko Stübner
On 06/11/13 2013 8:30 PM Heiko Stübner wrote:
> In a subsquent patch probe will need to do some handling of data from
> the dt match table. So to prevent the need for forward declarations,
> move probe and remove below the match table.
>
> Signed-off-by: Heiko Stuebner
Acked-by
-by: Seungwon Jeon tgih@samsung.com
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Looks good to me.
But this patch has a dependency on '[PATCH 2/2] mmc: dw_mmc: Add support DW
SD/MMC driver on SOCFPGA'
After that, it can be applied.(SDMMC_CMD_USE_HOLD_REG should be moved in
dw_mmc.h)
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
On 06/11/13 2013 8:31
mci_rockchip_prepare_command(struct dw_mci *host, u32 *cmdr)
> +{
> + *cmdr |= SDMMC_CMD_USE_HOLD_REG;
Currently, SDMMC_CMD_USE_HOLD_REG is defined in dw_mmc-exynos.c
It should be moved to dw_mmc.h
Thanks,
Seungwon Jeon
> +}
> +
> +static const struct dw_mci_drv_data rockchip_dr
On 06/03/13 2013 7:58 AM, Heiko Stübner wrote:
> dw_mci_pltfm_remove gets exported and used by dw_mmc-exynos, so should
> not be static.
>
> Signed-off-by: Heiko Stuebner
Acked-by: Seungwon Jeon
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the line "unsubsc
On 06/03/13 2013 7:58 AM, Heiko Stübner wrote:
dw_mci_pltfm_remove gets exported and used by dw_mmc-exynos, so should
not be static.
Signed-off-by: Heiko Stuebner he...@sntech.de
Acked-by: Seungwon Jeon tgih@samsung.com
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send
|= SDMMC_CMD_USE_HOLD_REG;
Currently, SDMMC_CMD_USE_HOLD_REG is defined in dw_mmc-exynos.c
It should be moved to dw_mmc.h
Thanks,
Seungwon Jeon
+}
+
+static const struct dw_mci_drv_data rockchip_drv_data = {
+ .prepare_command= dw_mci_rockchip_prepare_command,
+};
+
int dw_mci_pltfm_register(struct
On Sunday, May 12, 2013, Dolev Raviv wrote:
Author should be identified here. (From: author...)
Except last patch of series(8/8), all of patches are not from you.
> Simplify operations with hiding mmio_base.
>
> Signed-off-by: Seungwon Jeon
> Signed-off-by: Dolev Raviv
I'm not su
On Sunday, May 12, 2013, Dolev Raviv wrote:
Author should be identified here. (From: author...)
Except last patch of series(8/8), all of patches are not from you.
Simplify operations with hiding mmio_base.
Signed-off-by: Seungwon Jeon tgih@samsung.com
Signed-off-by: Dolev Raviv dra
On Tuesday, April 16, 2013, Doug Anderson
> Seungwon,
>
> On Mon, Apr 15, 2013 at 5:14 AM, Seungwon Jeon wrote:
> >> + MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23 | MMC_CAP_SDIO_IRQ,
> >> + MMC_CAP_CMD23 | MMC_CAP_SDIO_IRQ,
> > This line for [1]
> >&
On Tuesday, April 16, 2013, Doug Anderson
Seungwon,
On Mon, Apr 15, 2013 at 5:14 AM, Seungwon Jeon tgih@samsung.com wrote:
+ MMC_CAP_8_BIT_DATA | MMC_CAP_CMD23 | MMC_CAP_SDIO_IRQ,
+ MMC_CAP_CMD23 | MMC_CAP_SDIO_IRQ,
This line for [1]
+ MMC_CAP_CMD23
23 | MMC_CAP_SDIO_IRQ,
This line for [1]
> + MMC_CAP_CMD23 | MMC_CAP_SDIO_IRQ,
> + MMC_CAP_CMD23 | MMC_CAP_SDIO_IRQ,
[1] is for mshc1. mshc1 is only used for SDIO.
As I know, The others are improper for SDIO.
Thanks,
Seungwon Jeon
> };
>
> static const struct dw_mci_dr
,
+ MMC_CAP_CMD23 | MMC_CAP_SDIO_IRQ,
[1] is for mshc1. mshc1 is only used for SDIO.
As I know, The others are improper for SDIO.
Thanks,
Seungwon Jeon
};
static const struct dw_mci_drv_data exynos_drv_data = {
--
1.8.1.3
--
To unsubscribe from this list: send the line unsubscribe linux-mmc
On Tuesday, April 09, 2013, Doug Anderson wrote:
> Seungwon,
>
> On Mon, Apr 8, 2013 at 5:17 AM, Seungwon Jeon wrote:
> > I guess Doug are debugging it with wifi, right?
>
> Yes, we're debugging it on the Samsung ARM Chromebook on a part that
> has an SDIO WiFi modul
On Tuesday, April 09, 2013, Doug Anderson wrote:
Seungwon,
On Mon, Apr 8, 2013 at 5:17 AM, Seungwon Jeon tgih@samsung.com wrote:
I guess Doug are debugging it with wifi, right?
Yes, we're debugging it on the Samsung ARM Chromebook on a part that
has an SDIO WiFi module by Marvell
transfer was stopped by the interrupt handler */
- set_bit(EVENT_XFER_COMPLETE, >pending_events);
}
+
+ set_bit(EVENT_XFER_COMPLETE, >pending_events);
}
If you have any opinion, please let me know.
Thanks,
Seungwon Jeon
>
> Best Regards,
> Ja
*/
- set_bit(EVENT_XFER_COMPLETE, host-pending_events);
}
+
+ set_bit(EVENT_XFER_COMPLETE, host-pending_events);
}
If you have any opinion, please let me know.
Thanks,
Seungwon Jeon
Best Regards,
Jaehoon Chung
On 03/27/2013 03:06 AM, Doug Anderson wrote
On Wednesday, March 27, 2013, Grant Grundler wrote:
> Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV computation.
For easily identifying, it would be good to point the commit id and subject.
> But when debugging a related issue (http://crbug.com/221828) I found
It is not easy to ca
On Wednesday, March 27, 2013, Grant Grundler wrote:
Last year Seungwon Jeon (Samsung) fixed a bug in CLKDIV computation.
For easily identifying, it would be good to point the commit id and subject.
But when debugging a related issue (http://crbug.com/221828) I found
It is not easy to catch up
On Wednesday, March 13, 2013, James Hogan wrote:
> On 13/03/13 14:20, Seungwon Jeon wrote:
> > Hi James,
> >
> > On Tuesday, March 12, 2013, James Hogan wrote:
> >> Call the setpower platform callback in response to set_ios with
> >> ios->power_mode
On Wednesday, March 13, 2013, James Hogan wrote:
On 13/03/13 14:20, Seungwon Jeon wrote:
Hi James,
On Tuesday, March 12, 2013, James Hogan wrote:
Call the setpower platform callback in response to set_ios with
ios-power_mode == MMC_POWER_UP or MMC_POWER_OFF, instead of from the
card
> of the while loop.
>
> Signed-off-by: Markos Chandras
> Cc: Seungwon Jeon
Acked-by: Seungwon Jeon
You can add my ack to other patches.
However, could you change the subject prefix to 'mmc: dw_mmc' and resend?
Thanks,
Seungwon Jeon
--
To unsubscribe from this list: send the
n't occur prior to host->data_offset being initialised.
>
> Signed-off-by: James Hogan
> Cc: Seungwon Jeon
Acked-by: Seungwon Jeon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majo
1 - 100 of 148 matches
Mail list logo
