RE: [PATCH v6 2/8] clk: clock-wizard: Add the clockwizard to clk directory

Hi Stephen, Thanks for the review. > -Original Message- > From: Stephen Boyd > Sent: Tuesday, September 22, 2020 2:52 AM > To: Shubhrajyoti Datta ; linux-...@vger.kernel.org > Cc: devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; > de...@driverdev.osuosl.org;

RE: [PATCH v6 5/8] clk: clock-wizard: Add support for fractional support

Hi , Thanks for the review. > -Original Message- > From: Stephen Boyd > Sent: Tuesday, September 22, 2020 2:48 AM > To: Shubhrajyoti Datta ; linux-...@vger.kernel.org > Cc: devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; > de...@driverdev.osuosl.org; robh...

[PATCH v6 5/8] clk: clock-wizard: Add support for fractional support

Currently the set rate granularity is to integral divisors. Add support for the fractional divisors. Only the first output0 is fractional in the hardware. Signed-off-by: Shubhrajyoti Datta --- v6: remove unnecessary typecast remove unnecessary locks use polled timeout drivers/clk/clk-xlnx

[PATCH v6 3/8] clk: clock-wizard: Fix kernel-doc warning

Update description for the clocking wizard structure Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock-wizard.c index b31524a..d6577c8

[PATCH v6 4/8] clk: clock-wizard: Add support for dynamic reconfiguration

The patch adds support for dynamic reconfiguration of clock output rate. Output clocks are registered as dividers and set rate callback function is used for dynamic reconfiguration. Based on the initial work from Chirag. Signed-off-by: Chirag Parekh Signed-off-by: Shubhrajyoti Datta --- v6

[PATCH v6 2/8] clk: clock-wizard: Add the clockwizard to clk directory

Add clocking wizard driver to clk. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/Kconfig | 9 + drivers/clk/Makefile| 1 + drivers/clk/clk-xlnx-clock-wizard.c | 338 3 files changed, 348 insertions(+) create mode

[PATCH v6 7/8] clk: clock-wizard: Update the fixed factor divisors

Update the fixed factor clock registration to register the divisors. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock

[PATCH v6 1/8] dt-bindings: add documentation of xilinx clocking wizard

Add the devicetree binding for the xilinx clocking wizard. Signed-off-by: Shubhrajyoti Datta --- v6: Fix a yaml warning .../bindings/clock/xlnx,clocking-wizard.yaml | 71 ++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock

[PATCH v6 6/8] clk: clock-wizard: Remove the hardcoding of the clock outputs

The number of output clocks are configurable in the hardware. Currently the driver registers the maximum number of outputs. Fix the same by registering only the outputs that are there. Signed-off-by: Shubhrajyoti Datta --- v4: Assign output in this patch drivers/clk/clk-xlnx-clock-wizard.c | 6

[PATCH v6 8/8] staging: clocking-wizard: Delete the driver from the staging

Delete the driver from the staging as it is in drivers/clk. Signed-off-by: Shubhrajyoti Datta Acked-by: Greg Kroah-Hartman --- drivers/staging/Kconfig| 2 - drivers/staging/Makefile | 1 - drivers/staging/clocking-wizard/Kconfig

[PATCH v6 0/8] clk: clk-wizard: clock-wizard: Driver updates

staging as suggested v4: Reorder the patches. Merge the CLK_IS_BASIC patch. Add the yaml form of binding document v5: Fix a mismerge v6: Fix the yaml warning use poll timedout [1] https://spinics.net/lists/linux-driver-devel/msg117326.html Shubhrajyoti Datta (8): dt-bindings: add documentation

Re: [PATCH V2 3/3] MAINTAINERS: add fragment for xilinx GPIO drivers

On Thu, Jul 23, 2020 at 7:37 PM Srinivas Neeli wrote: > > Added entry for xilinx GPIO drivers. > > Signed-off-by: Srinivas Neeli > --- Acked-by: : Shubhrajyoti Datta

[PATCH v5 5/8] clk: clock-wizard: Add support for fractional support

Currently the set rate granularity is to integral divisors. Add support for the fractional divisors. Only the first output0 is fractional in the hardware. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 190 +--- 1 file changed, 178

[PATCH v5 4/8] clk: clock-wizard: Add support for dynamic reconfiguration

The patch adds support for dynamic reconfiguration of clock output rate. Output clocks are registered as dividers and set rate callback function is used for dynamic reconfiguration. Based on the initial work from Chirag. Signed-off-by: Chirag Parekh Signed-off-by: Shubhrajyoti Datta

[PATCH v5 7/8] clk: clock-wizard: Update the fixed factor divisors

Update the fixed factor clock registration to register the divisors. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock

[PATCH v5 6/8] clk: clock-wizard: Remove the hardcoding of the clock outputs

The number of output clocks are configurable in the hardware. Currently the driver registers the maximum number of outputs. Fix the same by registering only the outputs that are there. Signed-off-by: Shubhrajyoti Datta --- v4: Assign output in this patch drivers/clk/clk-xlnx-clock-wizard.c | 6

[PATCH v5 3/8] clk: clock-wizard: Fix kernel-doc warning

Update description for the clocking wizard structure Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock-wizard.c index b31524a..d6577c8

[PATCH v5 8/8] staging: clocking-wizard: Delete the driver from the staging

Delete the driver from the staging as it is in drivers/clk. Signed-off-by: Shubhrajyoti Datta Acked-by: Greg Kroah-Hartman --- drivers/staging/Kconfig| 2 - drivers/staging/Makefile | 1 - drivers/staging/clocking-wizard/Kconfig

[PATCH v5 2/8] clk: clock-wizard: Add the clockwizard to clk directory

Add clocking wizard driver to clk. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/Kconfig | 9 + drivers/clk/Makefile| 1 + drivers/clk/clk-xlnx-clock-wizard.c | 338 3 files changed, 348 insertions(+) create mode

[PATCH v4 0/8] clk: clockwizard: Driver updates

form of binding document v5: Fix a mismerge Shubhrajyoti Datta (8): dt-bindings: add documentation of xilinx clocking wizard clk: clock-wizard: Add the clockwizard to clk directory clk: clock-wizard: Fix kernel-doc warning clk: clock-wizard: Add support for dynamic reconfiguration clk

[PATCH v5 1/8] dt-bindings: add documentation of xilinx clocking wizard

Add the devicetree binding for the xilinx clocking wizard. Signed-off-by: Shubhrajyoti Datta --- v4: change to yaml format .../bindings/clock/xlnx,clocking-wizard.yaml | 71 ++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH v4 5/8] clk: clock-wizard: Add support for fractional support

Currently the set rate granularity is to integral divisors. Add support for the fractional divisors. Only the first output0 is fractional in the hardware. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 192 +--- 1 file changed, 179

[PATCH v4 4/8] clk: clock-wizard: Add support for dynamic reconfiguration

The patch adds support for dynamic reconfiguration of clock output rate. Output clocks are registered as dividers and set rate callback function is used for dynamic reconfiguration. Based on the initial work from Chirag. Signed-off-by: Chirag Parekh Signed-off-by: Shubhrajyoti Datta

[PATCH v4 3/8] clk: clock-wizard: Fix kernel-doc warning

Update description for the clocking wizard structure Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock-wizard.c index b31524a..d6577c8

[PATCH v4 1/8] dt-bindings: add documentation of xilinx clocking wizard

Add the devicetree binding for the xilinx clocking wizard. Signed-off-by: Shubhrajyoti Datta --- v4: Move to yaml format .../bindings/clock/xlnx,clocking-wizard.yaml | 71 ++ 1 file changed, 71 insertions(+) create mode 100644 Documentation/devicetree/bindings/clock

[PATCH v4 7/8] clk: clock-wizard: Update the fixed factor divisors

Update the fixed factor clock registration to register the divisors. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/clk-xlnx-clock-wizard.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/clk/clk-xlnx-clock-wizard.c b/drivers/clk/clk-xlnx-clock

[PATCH v4 0/8] clk: clockwizard: Driver updates

form of binding document Shubhrajyoti Datta (8): dt-bindings: add documentation of xilinx clocking wizard clk: clock-wizard: Add the clockwizard to clk directory clk: clock-wizard: Fix kernel-doc warning clk: clock-wizard: Add support for dynamic reconfiguration clk: clock-wizard: Add

[PATCH v4 6/8] clk: clock-wizard: Remove the hardcoding of the clock outputs

The number of output clocks are configurable in the hardware. Currently the driver registers the maximum number of outputs. Fix the same by registering only the outputs that are there. Signed-off-by: Shubhrajyoti Datta --- v4: Assign output in this patch drivers/clk/clk-xlnx-clock-wizard.c | 6

[PATCH v4 8/8] staging: clocking-wizard: Delete the driver from the staging

Delete the driver from the staging as it is in drivers/clk. Signed-off-by: Shubhrajyoti Datta --- drivers/staging/Kconfig| 2 - drivers/staging/Makefile | 1 - drivers/staging/clocking-wizard/Kconfig| 10 - drivers/staging

[PATCH v4 2/8] clk: clock-wizard: Add the clockwizard to clk directory

Add clocking wizard driver to clk. Signed-off-by: Shubhrajyoti Datta --- drivers/clk/Kconfig | 9 + drivers/clk/Makefile| 1 + drivers/clk/clk-xlnx-clock-wizard.c | 338 3 files changed, 348 insertions(+) create mode

[RFC PATCHv2 1/3] dt-bindings: misc: Add dt bindings for flex noc Performance Monitor

Add dt bindings for flexnoc Performance Monitor. The flexnoc counters for read and write response and requests are supported. Signed-off-by: Shubhrajyoti Datta --- .../devicetree/bindings/misc/xlnx,flexnoc.txt | 24 ++ 1 file changed, 24 insertions(+) create mode

[RFC PATCHv2 3/3] Documentation: short descriptions for Flexnoc Performance Monitor driver

Add short documentation for FlexNoc Performance Monitor driver. Signed-off-by: Shubhrajyoti Datta --- v2: patch added Documentation/misc-devices/xilinx_flex.txt | 66 ++ 1 file changed, 66 insertions(+) create mode 100644 Documentation/misc-devices/xilinx_flex.txt

[RFC PATCHv2 2/3] misc: xilinx_flex: Add support for the flex noc Performance Monitor

Add support for the FlexNoc Performance Monitor. Adds support for various port setting and monitoring the packets transactions. It supports LPD and FPD monitoring counters for read and write transaction requests and responses. Signed-off-by: Shubhrajyoti Datta --- v2: Add a mutex to prevent race

[RFC PATCH 2/2] misc: xilinx_flex: Add support for the flex noc Performance Monitor

Add support for the FlexNoc Performance Monitor. Adds support for various port setting and monitoring the packets transactions. It supports LPD and FPD monitoring counters for read and write transaction requests and responses. Signed-off-by: Shubhrajyoti Datta --- drivers/misc/Kconfig

[RFC PATCH 1/2] dt-bindings: misc: Add dt bindings for flex noc Performance Monitor

Add dt bindings for flexnoc Performance Monitor. The flexnoc counters for read and write response and requests are supported. Signed-off-by: Shubhrajyoti Datta --- .../devicetree/bindings/misc/xlnx,flexnoc.txt | 24 ++ 1 file changed, 24 insertions(+) create mode

Re: [PATCH] serial-uartlite: Fix null-ptr-deref in ulite_exit

ep_hardirqs_off+0xb5/0x100 > ? mark_held_locks+0x1a/0x90 > ? do_syscall_64+0x14/0x2a0 > do_syscall_64+0x72/0x2a0 > entry_SYSCALL_64_after_hwframe+0x49/0xbe > > This patch fix this by moving uart_unregister_driver > to ulite_remove. > Reviewed-by: Shubhrajyoti Dat

Re: Re: [PATCH] i2c: cadence: try reset when master receive error interrupts

On Mon, Feb 18, 2019 at 12:48 PM sxau...@163.com wrote: > > Hi , Shubhrajyoti > > >Hi , > >On Sat, Feb 16, 2019 at 1:21 PM sxau...@163.com wrote: > >> > >> >Hi Sxauwsk, > >> > > >> >On Wed, Jan 30, 2019 at 3:13 PM sxauwsk wrote: > >> >> > >> >> When the adapter receive error interrupts, such as

Re: [PATCH] i2c: cadence: try reset when master receive error interrupts

Hi , On Sat, Feb 16, 2019 at 1:21 PM sxau...@163.com wrote: > > >Hi Sxauwsk, > > > >On Wed, Jan 30, 2019 at 3:13 PM sxauwsk wrote: > >> > >> When the adapter receive error interrupts, such as NACK, arbitration lost, > >> cdns_i2c_master_xfer return to the caller directly instead of resuming > >>

Re: [PATCH] i2c: cadence: try reset when master receive error interrupts

Hi Sxauwsk, On Wed, Jan 30, 2019 at 3:13 PM sxauwsk wrote: > > When the adapter receive error interrupts, such as NACK, arbitration lost, > cdns_i2c_master_xfer return to the caller directly instead of resuming > the adapter which resulted in the adapter being out of control. > > So when driver

Re: [PATCH] gpio: zynq: properly support runtime PM for GPIO used as interrupts

rly > incremented/decremented. Since we override the default hooks, we keep > the existing behavior by making sure they call gpiochip_reqres_irq() / > gpiochip_relres_irq() respectively. > > Signed-off-by: Thomas Petazzoni > --- Reviewed-by: Shubhrajyoti Datta >

Re: [PATCH 2/8] gpio: zynq: Wakeup gpio controller when it is used as IRQ controller

On Fri, Jan 11, 2019 at 8:26 PM Linus Walleij wrote: > > On Fri, Jan 11, 2019 at 1:54 PM Thomas Petazzoni > wrote: > > On Fri, 11 Jan 2019 10:54:20 +0100, Linus Walleij wrote: > > > > > My stance is that the driver is responsible of enabling and managing > > > runtime PM for its hardware

Re: [PATCH] i2c: xiic: Make the start and the byte count write atomic

Hi, On Tue, Sep 4, 2018 at 9:41 PM Wolfram Sang wrote: > > On Mon, Sep 03, 2018 at 03:11:11PM +0530, shubhrajyoti.da...@gmail.com wrote: > > From: Shubhrajyoti Datta > > > > Disable interrupts while configuring the transfer and enable them back. > > > > We ha

Re: [PATCH] i2c: xiic: Make the start and the byte count write atomic

Hi, On Tue, Sep 4, 2018 at 9:41 PM Wolfram Sang wrote: > > On Mon, Sep 03, 2018 at 03:11:11PM +0530, shubhrajyoti.da...@gmail.com wrote: > > From: Shubhrajyoti Datta > > > > Disable interrupts while configuring the transfer and enable them back. > > > > We ha

Re: [PATCH v3 2/4] drivers: firmware: xilinx: Add ZynqMP firmware driver

Hi, Thanks for the patch. A few questions below. On Thu, Jan 25, 2018 at 4:51 AM, Jolly Shah wrote: > This patch is adding communication layer with firmware. > Firmware driver provides an interface to firmware APIs. > Interface APIs can be used by any driver to

Re: [PATCH v3 2/4] drivers: firmware: xilinx: Add ZynqMP firmware driver

Hi, Thanks for the patch. A few questions below. On Thu, Jan 25, 2018 at 4:51 AM, Jolly Shah wrote: > This patch is adding communication layer with firmware. > Firmware driver provides an interface to firmware APIs. > Interface APIs can be used by any driver to communicate to > PMUFW(Platform

[PATCHv2] tty: xilinx_uartps: move to arch_initcall for earlier console

move to arch_initcall to get the console up really early, it is quite helpful for spotting early boot problems. Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.da...@xilinx.com> --- drivers/tty/serial/xilinx_uartps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drive

[PATCHv2] tty: xilinx_uartps: move to arch_initcall for earlier console

move to arch_initcall to get the console up really early, it is quite helpful for spotting early boot problems. Signed-off-by: Shubhrajyoti Datta --- drivers/tty/serial/xilinx_uartps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b

Re: [PATCH] tty: xilinx_uartps: move to arch_initcall for earlier console

... >> >> I *guess* it is to get the console up really early, simply becaus it is >> quite helpful for spotting early boot problems. > > > ok. It means no concern about the move to arch_initcall. > Shubhrajyoti: Please send v2 with changelog. Will do thanks for the review. > > Thanks, > Michal

Re: [PATCH] tty: xilinx_uartps: move to arch_initcall for earlier console

... >> >> I *guess* it is to get the console up really early, simply becaus it is >> quite helpful for spotting early boot problems. > > > ok. It means no concern about the move to arch_initcall. > Shubhrajyoti: Please send v2 with changelog. Will do thanks for the review. > > Thanks, > Michal

[PATCH] tty: xilinx_uartps: move to arch_initcall for earlier console

Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.da...@xilinx.com> --- drivers/tty/serial/xilinx_uartps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index ff1b115..a239343 100644 --- a/drive

[PATCH] tty: xilinx_uartps: move to arch_initcall for earlier console

Signed-off-by: Shubhrajyoti Datta --- drivers/tty/serial/xilinx_uartps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/xilinx_uartps.c b/drivers/tty/serial/xilinx_uartps.c index ff1b115..a239343 100644 --- a/drivers/tty/serial/xilinx_uartps.c +++ b

Re: i2c: xiic: Strange clk_prepare_enable() in xiic_i2c_remove()

On Sat, Dec 17, 2016 at 3:24 AM, Alexey Khoroshilov wrote: > Dear Shubhrajyoti, > > Looking at 36ecbcab84d0 ("i2c: xiic: Implement power management") > it is not clear why clk_prepare_enable(i2c->clk) is required in > xiic_i2c_remove()? 834 ret =

Re: i2c: xiic: Strange clk_prepare_enable() in xiic_i2c_remove()

On Sat, Dec 17, 2016 at 3:24 AM, Alexey Khoroshilov wrote: > Dear Shubhrajyoti, > > Looking at 36ecbcab84d0 ("i2c: xiic: Implement power management") > it is not clear why clk_prepare_enable(i2c->clk) is required in > xiic_i2c_remove()? 834 ret = clk_prepare_enable(i2c->clk); 835

Re: Re: Reset implementation for Zynq

Hi Iztok, On Tue, Nov 8, 2016 at 3:10 PM, wrote: > Hi Shubhrajyoti, > > By lockup state, I mean an undefined/unhandled state of the HW logic state > machine, > or something similar in the software driver. > Based on symptoms I assume it is a HW lockup. > In practice

Re: Re: Reset implementation for Zynq

Hi Iztok, On Tue, Nov 8, 2016 at 3:10 PM, wrote: > Hi Shubhrajyoti, > > By lockup state, I mean an undefined/unhandled state of the HW logic state > machine, > or something similar in the software driver. > Based on symptoms I assume it is a HW lockup. > In practice asking the driver for a

Re: Reset implementation for Zynq

On Fri, Oct 21, 2016 at 10:34 PM, Moritz Fischer wrote: > Iztok, > > On Fri, Oct 21, 2016 at 03:08:47AM -0700, iztok.je...@redpitaya.com wrote: >> Hi Moritz, >> >> I was looking at your reset implementation for Zynq: >>

Re: Reset implementation for Zynq

On Fri, Oct 21, 2016 at 10:34 PM, Moritz Fischer wrote: > Iztok, > > On Fri, Oct 21, 2016 at 03:08:47AM -0700, iztok.je...@redpitaya.com wrote: >> Hi Moritz, >> >> I was looking at your reset implementation for Zynq: >>

Re: [PATCH] gpio: Added zynq specific check for special pins on bank zero

On Tue, Sep 20, 2016 at 2:02 PM, Nava kishore Manne wrote: > From: Nava kishore Manne > > This patch adds zynq specific check for bank 0 pins 7 and 8 > are special and cannot be used as inputs Is there any such pins for zynqmp? > > Signed-off-by:

Re: [PATCH] gpio: Added zynq specific check for special pins on bank zero

On Tue, Sep 20, 2016 at 2:02 PM, Nava kishore Manne wrote: > From: Nava kishore Manne > > This patch adds zynq specific check for bank 0 pins 7 and 8 > are special and cannot be used as inputs Is there any such pins for zynqmp? > > Signed-off-by: Nava kishore Manne > --- >

Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

On Tue, May 31, 2016 at 10:45 AM, Nava kishore Manne wrote: > Hi Shubhrajyoti, > > > Thanks for the review... > >> > /** >> > + * xudc_write64 - write 64bit value to device registers >> > + * @ep: pointer to the usb device endpoint structure. >> > + * @offset:

Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

On Tue, May 31, 2016 at 10:45 AM, Nava kishore Manne wrote: > Hi Shubhrajyoti, > > > Thanks for the review... > >> > /** >> > + * xudc_write64 - write 64bit value to device registers >> > + * @ep: pointer to the usb device endpoint structure. >> > + * @offset: register offset >> > + *

Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

On Mon, May 30, 2016 at 10:16 PM, Nava kishore Manne wrote: > This patch updates the driver to support 64-bit DMA addressing. > > Signed-off-by: Nava kishore Manne > --- > Changes for v4: > -Used boolen property insted of addrwith property

Re: [PATCH v4] Axi-usb: Add support for 64-bit addressing.

On Mon, May 30, 2016 at 10:16 PM, Nava kishore Manne wrote: > This patch updates the driver to support 64-bit DMA addressing. > > Signed-off-by: Nava kishore Manne > --- > Changes for v4: > -Used boolen property insted of addrwith property in the DT > as

Re: [PATCH v9 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

> + */ > +static void zynqmp_dma_update_desc_to_ctrlr(struct zynqmp_dma_chan *chan, > + struct zynqmp_dma_desc_sw *desc) > +{ > + dma_addr_t addr; > + > + addr = desc->src_p; > + writel(addr, chan->regs + ZYNQMP_DMA_SRC_START_LSB); > +

Re: [PATCH v9 2/2] dmaengine: Add Xilinx zynqmp dma engine driver support

> + */ > +static void zynqmp_dma_update_desc_to_ctrlr(struct zynqmp_dma_chan *chan, > + struct zynqmp_dma_desc_sw *desc) > +{ > + dma_addr_t addr; > + > + addr = desc->src_p; > + writel(addr, chan->regs + ZYNQMP_DMA_SRC_START_LSB); > +

[PATCH] spi: zynqmp: disable clocks in error paths

The if pclk enable fails the refclk is not disabled. Fix the same. Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- drivers/spi/spi-zynqmp-gqspi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-g

[PATCH] spi: zynqmp: disable clocks in error paths

The if pclk enable fails the refclk is not disabled. Fix the same. Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-zynqmp-gqspi.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi-zynqmp-gqspi.c b/drivers/spi/spi-zynqmp-gqspi.c index aab9b49

Re: [PATCH v2 2/2] dmaengine: vdma: Add clock support

On Wed, Apr 20, 2016 at 5:13 PM, Kedareswara rao Appana <appana.durga@xilinx.com> wrote: > Added basic clock support. The clocks are requested at probe > and released at remove. > > Signed-off-by: Kedareswara rao Appana <appa...@xilinx.com> Reviewed-by: Sh

Re: [PATCH v2 2/2] dmaengine: vdma: Add clock support

On Wed, Apr 20, 2016 at 5:13 PM, Kedareswara rao Appana wrote: > Added basic clock support. The clocks are requested at probe > and released at remove. > > Signed-off-by: Kedareswara rao Appana Reviewed-by: Shubhrajyoti Datta

Re: [PATCH 1/2] Documentation: DT: vdma: Add clock support for vdma

On Wed, Apr 20, 2016 at 12:49 PM, Kedareswara rao Appana wrote: > This patch updates the binding doc with clock description > for vdma. > > Signed-off-by: Kedareswara rao Appana > --- > Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt

Re: [PATCH 1/2] Documentation: DT: vdma: Add clock support for vdma

On Wed, Apr 20, 2016 at 12:49 PM, Kedareswara rao Appana wrote: > This patch updates the binding doc with clock description > for vdma. > > Signed-off-by: Kedareswara rao Appana > --- > Documentation/devicetree/bindings/dma/xilinx/xilinx_vdma.txt | 6 ++ > 1 file changed, 6 insertions(+) >

Re: [PATCH] spi: cadence: mark pm functions __maybe_unused

e patch. Feel free to add my ack. Acked-by: Shubhrajyoti Datta <shubh...@xilinx.com> > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Fixes: d36ccd9f7ea4 ("spi: cadence: Runtime pm adaptation") > ---

Re: [PATCH] spi: cadence: mark pm functions __maybe_unused

h. Feel free to add my ack. Acked-by: Shubhrajyoti Datta > > Signed-off-by: Arnd Bergmann > Fixes: d36ccd9f7ea4 ("spi: cadence: Runtime pm adaptation") > ---

[PATCH] spi: cadence: Fix some checkpatch warnings

, + struct spi_transfer *transfer) CHECK: Please use a blank line after function/struct/union/enum declarations +} +static int cdns_prepare_message(struct spi_master *master, Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- drivers/spi/spi-cadence.c |6 -- 1

[PATCH] spi: cadence: Fix some checkpatch warnings

, + struct spi_transfer *transfer) CHECK: Please use a blank line after function/struct/union/enum declarations +} +static int cdns_prepare_message(struct spi_master *master, Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-cadence.c |6 -- 1 files changed, 4

[PATCH 4/7] spi: cadance: Fix the Documentation

in 'cdns_spi_chipselect' Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- drivers/spi/spi-cadence.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index 2915b25..8a6fee9 100644 --- a/drivers/spi/spi-cadence.c

[PATCH 1/7] spi: cadence: Fix a check patch warning

CHECK: Comparison to NULL could be written "!master" + if (master == NULL) Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- drivers/spi/spi-cadence.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/s

[PATCH 6/7] spi: cadence: Remove the clock enable and disable from suspend and resume

Now that the clocks are enabled and disabled per transaction , remove the clock enable and disable from resume and suspend hooks. Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- drivers/spi/spi-cadence.c | 19 --- 1 files changed, 0 insertions(+), 19 del

[PATCH 6/7] spi: cadence: Remove the clock enable and disable from suspend and resume

Now that the clocks are enabled and disabled per transaction , remove the clock enable and disable from resume and suspend hooks. Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-cadence.c | 19 --- 1 files changed, 0 insertions(+), 19 deletions(-) diff --git a/drivers

[PATCH 4/7] spi: cadance: Fix the Documentation

in 'cdns_spi_chipselect' Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-cadence.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index 2915b25..8a6fee9 100644 --- a/drivers/spi/spi-cadence.c +++ b/drivers/spi/spi

[PATCH 1/7] spi: cadence: Fix a check patch warning

CHECK: Comparison to NULL could be written "!master" + if (master == NULL) Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-cadence.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index 121a41

[PATCH 3/7] spi: cadence: Fix probe error handling

The clock disabling is missed out in some error cases at probe. Fix the same. Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- drivers/spi/spi-cadence.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cad

[PATCH 3/7] spi: cadence: Fix probe error handling

The clock disabling is missed out in some error cases at probe. Fix the same. Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-cadence.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-cadence.c b/drivers/spi/spi-cadence.c index 97a3bf6..2915b25

[PATCH 5/7] spi: cadence: Runtime pm adaptation

Currently the clocks are enabled at probe and disabled at remove. This patch moves the clock enable to the start of transaction and disables at the end. Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- drivers/spi/spi-cadence.c | 70 +

[PATCH 7/7] spi: cadence: Return the error code for cdns_spi_suspend and cdns_spi_resume

Return the error code for cdns_spi_suspend and cdns_spi_resume. Also fixes a comment where which claims that the error code is returned. Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- drivers/spi/spi-cadence.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-)

[PATCH 2/7] spi: cadence: Remove _MASK and _OFFSET suffix

Remove the _MASK and _OFFSET from the macros. It improves readability, removes some checkpatch error for exceeding 80 chars and also prevents some linebreaks. Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- drivers/spi/spi-cadence.c

[PATCH 5/7] spi: cadence: Runtime pm adaptation

Currently the clocks are enabled at probe and disabled at remove. This patch moves the clock enable to the start of transaction and disables at the end. Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-cadence.c | 70 +++- 1 files changed, 68

[PATCH 7/7] spi: cadence: Return the error code for cdns_spi_suspend and cdns_spi_resume

Return the error code for cdns_spi_suspend and cdns_spi_resume. Also fixes a comment where which claims that the error code is returned. Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-cadence.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/spi

[PATCH 2/7] spi: cadence: Remove _MASK and _OFFSET suffix

Remove the _MASK and _OFFSET from the macros. It improves readability, removes some checkpatch error for exceeding 80 chars and also prevents some linebreaks. Signed-off-by: Shubhrajyoti Datta --- drivers/spi/spi-cadence.c | 161 + 1 files changed

[PATCH] gpio: zynq: Fix the error path

pm_runtime_disable is called only in remove it is missed out in the error path. Fix the same. Signed-off-by: Shubhrajyoti Datta <shubh...@xilinx.com> --- drivers/gpio/gpio-zynq.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/gpio/gpio-zynq.c b/driver

[PATCH] gpio: zynq: Fix the error path

pm_runtime_disable is called only in remove it is missed out in the error path. Fix the same. Signed-off-by: Shubhrajyoti Datta --- drivers/gpio/gpio-zynq.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/gpio/gpio-zynq.c b/drivers/gpio/gpio-zynq.c index

Re: [PATCH 1/3] spi: spi-xilinx: Remove ISR race condition

> >> >> = >> spi: xilinx - minimize iomem reads >> >> If this IP core is accessed through bridges like PCI-e, reads are rather >> costly. Doing many reads or read-modify-writes is thus long and strenuous >> on the CPU (active waiting). >> >> The transfer workflow of

Re: [PATCH 1/3] spi: spi-xilinx: Remove ISR race condition

> >> >> = >> spi: xilinx - minimize iomem reads >> >> If this IP core is accessed through bridges like PCI-e, reads are rather >> costly. Doing many reads or read-modify-writes is thus long and strenuous >> on the CPU (active waiting). >> >> The transfer workflow of

Re: [PATCH v2] i2c: cadence: Move to sensible power management

On Tue, Nov 24, 2015 at 12:17 AM, Sören Brinkmann wrote: > On Sat, 2015-11-21 at 07:00PM +0530, Shubhrajyoti Datta wrote: >> On Thu, Oct 29, 2015 at 8:27 PM, Shubhrajyoti Datta >> wrote: >> > On Wed, Oct 28, 2015 at 9:48 PM, Sören Brinkmann >> &

Re: [PATCH v2] i2c: cadence: Move to sensible power management

On Tue, Nov 24, 2015 at 12:17 AM, Sören Brinkmann <soren.brinkm...@xilinx.com> wrote: > On Sat, 2015-11-21 at 07:00PM +0530, Shubhrajyoti Datta wrote: >> On Thu, Oct 29, 2015 at 8:27 PM, Shubhrajyoti Datta >> <shubhrajyoti.da...@gmail.com> wrote: >> > On

Re: [PATCH v2] i2c: cadence: Move to sensible power management

On Thu, Oct 29, 2015 at 8:27 PM, Shubhrajyoti Datta wrote: > On Wed, Oct 28, 2015 at 9:48 PM, Sören Brinkmann > wrote: >> Hi Shubhrajyoti, >> >> >> On Wed, 2015-10-28 at 12:56PM +0530, Shubhrajyoti Datta wrote: >>> Currently the clocks are enabled at probe

Re: [PATCH v2] i2c: cadence: Move to sensible power management

On Thu, Oct 29, 2015 at 8:27 PM, Shubhrajyoti Datta <shubhrajyoti.da...@gmail.com> wrote: > On Wed, Oct 28, 2015 at 9:48 PM, Sören Brinkmann > <soren.brinkm...@xilinx.com> wrote: >> Hi Shubhrajyoti, >> >> >> On Wed, 2015-10-28 at 12:56PM +0530, Shubhraj

Re: [PATCH v2] i2c: cadence: Move to sensible power management

On Wed, Oct 28, 2015 at 9:48 PM, Sören Brinkmann wrote: > Hi Shubhrajyoti, > > > On Wed, 2015-10-28 at 12:56PM +0530, Shubhrajyoti Datta wrote: >> Currently the clocks are enabled at probe and disabled at remove. >> Which keeps the clocks enabled even if no transaction is

Re: [PATCH v2] i2c: cadence: Move to sensible power management

On Wed, Oct 28, 2015 at 9:48 PM, Sören Brinkmann <soren.brinkm...@xilinx.com> wrote: > Hi Shubhrajyoti, > > > On Wed, 2015-10-28 at 12:56PM +0530, Shubhrajyoti Datta wrote: >> Currently the clocks are enabled at probe and disabled at remove. >> Which keeps the clocks

[PATCHv2] i2c: cadence: Enable power management

ned-off-by: Shubhrajyoti Datta --- changes since v1: update the cc list. drivers/i2c/busses/i2c-cadence.c | 74 -- 1 files changed, 47 insertions(+), 27 deletions(-) diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c index f522

  1   2   >