Re: Unknown symbols in module (iio)

a to include the kernel version in a problem report. >> >> >> On 03/05/2018 03:17 AM, Srishti Sharma wrote: >> > Hello, >> > I was trying to work with the iio dummy driver, and when I try to load >> > the iio_dummy_evgen.ko module I am getting unkno

Re: Unknown symbols in module (iio)

On Sun, Mar 18, 2018 at 4:34 PM, Jonathan Cameron wrote: > On Sat, 17 Mar 2018 13:42:24 -0700 > Randy Dunlap wrote: > >> [adding linux-iio mailing list] >> >> Hi, >> >> It's always a good idea to include the kernel version in a problem report. >>

Unknown symbols in module

Hello, I was trying to work with the iio dummy driver, and when I try to load the iio_dummy_evgen.ko module I am getting unknown symbols found in module error on running modprobe. These variables are unknown iio_bus_type irq_sim_init irq_sim_fini irq_sim_fire irq_sim_fini All of these variables

Unknown symbols in module

Hello, I was trying to work with the iio dummy driver, and when I try to load the iio_dummy_evgen.ko module I am getting unknown symbols found in module error on running modprobe. These variables are unknown iio_bus_type irq_sim_init irq_sim_fini irq_sim_fire irq_sim_fini All of these variables

[PATCH 4/4] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of the struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma <srishtis...@gmail.

[PATCH 4/4] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of the struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging

[PATCH 2/4] Staging: rtl8188eu: core: rtw_ap: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/rtl8188

[PATCH 2/4] Staging: rtl8188eu: core: rtw_ap: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188eu/cor

[PATCH 3/4] Staging: rtl8188eu: core: rtw_mlme_ext: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/rtl8188eu/co

[PATCH 3/4] Staging: rtl8188eu: core: rtw_mlme_ext: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 9 ++

[PATCH 1/4] Staging: rtl8188eu: core: rtw_xmit: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/rtl8188eu

[PATCH 1/4] Staging: rtl8188eu: core: rtw_xmit: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188eu/core/

[PATCH 0/4] Code cleanup

This patch series performs code cleanup like using list_for_each_entry_safe to make code more compact and using list_entry instead of container_of for struct list_head* variable types. Srishti Sharma (4): Staging: rtl8188eu: core: rtw_xmit: Use list_for_each_entry_safe Staging: rtl8188eu

[PATCH 0/4] Code cleanup

This patch series performs code cleanup like using list_for_each_entry_safe to make code more compact and using list_entry instead of container_of for struct list_head* variable types. Srishti Sharma (4): Staging: rtl8188eu: core: rtw_xmit: Use list_for_each_entry_safe Staging: rtl8188eu

[PATCH v2] Staging: rtl8723bs: core: rtw_cmd: Remove cast to pointer types in kfree

ree( -(P *) x ) Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2: -Do transformation left out by coccinelle -Improve commit message drivers/staging/rtl8723bs/core/rtw_cmd.c | 60 1 file changed, 30 insertions(+), 30 deletions(-) d

[PATCH v2] Staging: rtl8723bs: core: rtw_cmd: Remove cast to pointer types in kfree

ree( -(P *) x ) Signed-off-by: Srishti Sharma --- Changes in v2: -Do transformation left out by coccinelle -Improve commit message drivers/staging/rtl8723bs/core/rtw_cmd.c | 60 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/drivers/staging/rtl872

Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: core: rtw_cmd: Remove cast to pointer types in kfree

On Sun, Oct 8, 2017 at 1:36 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sun, 8 Oct 2017, Srishti Sharma wrote: > >> On Sat, Oct 7, 2017 at 11:42 PM, Julia Lawall <julia.law...@lip6.fr> wrote: >> > >> > >> > On Sat, 7 Oct 2017, S

Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: core: rtw_cmd: Remove cast to pointer types in kfree

On Sun, Oct 8, 2017 at 1:36 AM, Julia Lawall wrote: > > > On Sun, 8 Oct 2017, Srishti Sharma wrote: > >> On Sat, Oct 7, 2017 at 11:42 PM, Julia Lawall wrote: >> > >> > >> > On Sat, 7 Oct 2017, Srishti Sharma wrote: >> > >> >> T

Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: core: rtw_cmd: Remove cast to pointer types in kfree

On Sat, Oct 7, 2017 at 11:42 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sat, 7 Oct 2017, Srishti Sharma wrote: > >> The cast to pointer types in kfree is not needed and can be dropped. >> Done using the following semantic by coccinelle.

Re: [Outreachy kernel] [PATCH] Staging: rtl8723bs: core: rtw_cmd: Remove cast to pointer types in kfree

On Sat, Oct 7, 2017 at 11:42 PM, Julia Lawall wrote: > > > On Sat, 7 Oct 2017, Srishti Sharma wrote: > >> The cast to pointer types in kfree is not needed and can be dropped. >> Done using the following semantic by coccinelle. >> >> @r@ >> type T,P;

[PATCH v2] Staging: pi433: Fix the position of brace after if

lumn_end) c2 = int (p2[0].column) if l1 == l2 and c1+1 == c2: cocci.include_match(False) @r3@ position r1.p1, r1.p2; @@ if(... - )@p1 -{@p2 +) { ... } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2: -Improve commit message. drivers/staging/pi4

[PATCH v2] Staging: pi433: Fix the position of brace after if

lumn_end) c2 = int (p2[0].column) if l1 == l2 and c1+1 == c2: cocci.include_match(False) @r3@ position r1.p1, r1.p2; @@ if(... - )@p1 -{@p2 +) { ... } Signed-off-by: Srishti Sharma --- Changes in v2: -Improve commit message. drivers/staging/pi433/pi4

[PATCH] Staging: rtlwifi: phydm: Use setup_timer

t;data = d; | - l->data = d; ... - l->function = f; ) Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/rtlwifi/phydm/phydm_interface.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtlwifi/phydm/phydm_interface.c b/drive

[PATCH] Staging: rtlwifi: phydm: Use setup_timer

t;data = d; | - l->data = d; ... - l->function = f; ) Signed-off-by: Srishti Sharma --- drivers/staging/rtlwifi/phydm/phydm_interface.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/staging/rtlwifi/phydm/phydm_interface.c b/drivers/staging/r

[PATCH] Staging: pi433: Fix the position of brace after if

p1; p2 << r1.p2; @@ l1 = int (p1[0].line) l2 = int (p2[0].line) c1 = int (p1[0].column_end) c2 = int (p2[0].column) if l1 == l2 and c1+1 == c2: cocci.include_match(False) @r3@ position r1.p1, r1.p2; @@ if(... - )@p1 -{@p2 +) { ... } Signed-off-by: Srishti Sharma <srisht

[PATCH] Staging: pi433: Fix the position of brace after if

p1; p2 << r1.p2; @@ l1 = int (p1[0].line) l2 = int (p2[0].line) c1 = int (p1[0].column_end) c2 = int (p2[0].column) if l1 == l2 and c1+1 == c2: cocci.include_match(False) @r3@ position r1.p1, r1.p2; @@ if(... - )@p1 -{@p2 +) { ... } Signed-off-by: Srishti Sharma --- drivers/s

[PATCH] Staging: media: atomisp: pci: Eliminate use of typedefs for struct

occinelle.T1 = T[:-2] else: coccinelle.T1 = T print T, T1 @r2@ type r1.T; identifier p.T1; @@ - typedef struct + T1 { ... } - T ; @r3@ type r1.T; identifier p.T1; @@ - T + struct T1 Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- .../media/atomisp/pci/atomisp2/css2400/runtime/spctrl/

[PATCH] Staging: media: atomisp: pci: Eliminate use of typedefs for struct

occinelle.T1 = T[:-2] else: coccinelle.T1 = T print T, T1 @r2@ type r1.T; identifier p.T1; @@ - typedef struct + T1 { ... } - T ; @r3@ type r1.T; identifier p.T1; @@ - T + struct T1 Signed-off-by: Srishti Sharma --- .../media/atomisp/pci/atomisp2/css2400/runtime/spctrl/src/spctrl.c | 6 +++--- 1

[PATCH] Staging: rtl8723bs: core: rtw_cmd: Remove cast to pointer types in kfree

The cast to pointer types in kfree is not needed and can be dropped. Done using the following semantic by coccinelle. @r@ type T,P; T* x; @@ kfree( -(P *) x ) Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/rtl8723bs/core/rtw_cmd.

[PATCH] Staging: rtl8723bs: core: rtw_cmd: Remove cast to pointer types in kfree

The cast to pointer types in kfree is not needed and can be dropped. Done using the following semantic by coccinelle. @r@ type T,P; T* x; @@ kfree( -(P *) x ) Signed-off-by: Srishti Sharma --- drivers/staging/rtl8723bs/core/rtw_cmd.c | 58 1 file changed, 29

[PATCH v3] Staging: rtl8188eu: core: rtw_mlme_ext: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v3 -Add a blank l

[PATCH v3] Staging: rtl8188eu: core: rtw_mlme_ext: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma --- Changes in v3 -Add a blank line after declaration. Chang

[PATCH v2] Staging: rtl8188eu: core: rtw_ap: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; ... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ... } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2 -Make commit message cl

[PATCH v2] Staging: rtl8188eu: core: rtw_ap: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; ... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ... } Signed-off-by: Srishti Sharma --- Changes in v2 -Make commit message clear. -Add file name t

[PATCH v2] Staging: rtl8188eu: core: rtw_mlme_ext: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2 -Make th

[PATCH v2] Staging: rtl8188eu: core: rtw_mlme_ext: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma --- Changes in v2 -Make the commit message more clear.

[PATCH v2] Staging: rtl8188eu: core: rtw_xmit: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2 -Make comm

[PATCH v2] Staging: rtl8188eu: core: rtw_xmit: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma --- Changes in v2 -Make commit message more clear.

[PATCH v2] Staging: rtl8188eu: core: rtw_ap: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2 -Make comm

[PATCH v2] Staging: rtl8188eu: core: rtw_ap: Use list_for_each_entry_safe

list_for_each_entry_safe; @@ f(...){ +T1* tmp; <+... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma --- Changes in v2 -Make commit message more clear.

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 4, 2017 at 10:37 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Wed, 4 Oct 2017, Srishti Sharma wrote: > >> On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter <dan.carpen...@oracle.com> >> wrote: >> > On Wed, Oct 04, 2017 at 03:34:05P

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 4, 2017 at 10:37 PM, Julia Lawall wrote: > > > On Wed, 4 Oct 2017, Srishti Sharma wrote: > >> On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter >> wrote: >> > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote: >> >> Aga

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter wrote: > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote: >> Again, you have three patches on different files with the same subject >> line. You could add the file name eg rtw_ap: to the subject line to make >>

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 4, 2017 at 8:38 PM, Dan Carpenter wrote: > On Wed, Oct 04, 2017 at 03:34:05PM +0200, Julia Lawall wrote: >> Again, you have three patches on different files with the same subject >> line. You could add the file name eg rtw_ap: to the subject line to make >> them unique. >> > > And

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

gt;> > >> > > On Wed, Oct 04, 2017 at 01:58:32AM +0530, Srishti Sharma wrote: >> > > > Use list_for_each_entry_safe when the list elements may get deleted >> > > > during traversal. >> > > >> > > This patch is fine as a clea

Re: [Outreachy kernel] Re: [PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

On Wed, Oct 4, 2017 at 8:11 PM, Julia Lawall wrote: > > > On Wed, 4 Oct 2017, Dan Carpenter wrote: > >> On Wed, Oct 04, 2017 at 03:39:30PM +0200, Julia Lawall wrote: >> > >> > >> > On Wed, 4 Oct 2017, Dan Carpenter wrote: >> > >> > &

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

ile(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8 +++- 1 file changed, 3 insertions(+), 5 del

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

ile(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188eu/core/rtw_mlme_ext.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

ile(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 23 ++- 1 file changed, 6 insertions(+),

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

ile(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188eu/core/rtw_xmit.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

ile(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_ap.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-)

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

ile(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ...+> } Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188eu/core/rtw_ap.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging

[PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of the struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma <srishtis...@gmail.

[PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of the struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

; ... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ... } Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_ap.c | 22 ++ 1 file change

[PATCH] Staging: rtl8188eu: core: Use list_for_each_entry_safe

; ... -while(...) +list_for_each_entry_safe(pos,tmp,l,m) { ... -pos = container_of(l,T1,m); ... -l=e; <+... list_del_init(>m) ...+> } ... } Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188eu/core/rtw_ap.c | 22 ++ 1 file changed, 6 insertions(+), 16 deletions

Re: [PATCH 0/6] Replace container_of with list_entry

On Tue, Oct 3, 2017 at 9:44 PM, Greg KH <gre...@linuxfoundation.org> wrote: > On Sat, Sep 30, 2017 at 12:49:00PM +0530, Srishti Sharma wrote: >> Replaces instances of container_of with list_entry to >> access current list element. >> >> Srishti Sharma (6): &

Re: [PATCH 0/6] Replace container_of with list_entry

On Tue, Oct 3, 2017 at 9:44 PM, Greg KH wrote: > On Sat, Sep 30, 2017 at 12:49:00PM +0530, Srishti Sharma wrote: >> Replaces instances of container_of with list_entry to >> access current list element. >> >> Srishti Sharma (6): >> Staging: rtl8188eu: core: Use l

[PATCH 6/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of type struct list_head* use list_entry to access current list element instead of using container_of. Done by the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma <srishtis...@gmail.

[PATCH 6/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of type struct list_head* use list_entry to access current list element instead of using container_of. Done by the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188eu

[PATCH 5/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of type struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma <srishtis...@gmail.

[PATCH 5/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of type struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging

[PATCH 4/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of the type struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma <srishtis...@gmail.

[PATCH 4/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of the type struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging

[PATCH 3/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of the type struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma <srishtis...@gmail.

[PATCH 3/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of the type struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging

[PATCH 2/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of the type struct list_head use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma <srishtis...@gmail.

[PATCH 2/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of the type struct list_head use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging

[PATCH 1/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of the struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma <srishtis...@gmail.

[PATCH 1/6] Staging: rtl8188eu: core: Use list_entry instead of container_of

For variables of the struct list_head* use list_entry to access current list element instead of using container_of. Done using the following semantic patch by coccinelle. @r@ struct list_head* l; @@ -container_of +list_entry (l,...) Signed-off-by: Srishti Sharma --- drivers/staging

[PATCH 0/6] Replace container_of with list_entry

Replaces instances of container_of with list_entry to access current list element. Srishti Sharma (6): Staging: rtl8188eu: core: Use list_entry instead of container_of Staging: rtl8188eu: core: Use list_entry instead of container_of Staging: rtl8188eu: core: Use list_entry instead

[PATCH 0/6] Replace container_of with list_entry

Replaces instances of container_of with list_entry to access current list element. Srishti Sharma (6): Staging: rtl8188eu: core: Use list_entry instead of container_of Staging: rtl8188eu: core: Use list_entry instead of container_of Staging: rtl8188eu: core: Use list_entry instead

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

On Sat, Sep 30, 2017 at 11:51 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sat, 30 Sep 2017, Srishti Sharma wrote: > >> On Sat, Sep 30, 2017 at 11:36 AM, Julia Lawall <julia.law...@lip6.fr> wrote: >> > >> > >> > On Sat, 30 Sep 20

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

On Sat, Sep 30, 2017 at 11:51 AM, Julia Lawall wrote: > > > On Sat, 30 Sep 2017, Srishti Sharma wrote: > >> On Sat, Sep 30, 2017 at 11:36 AM, Julia Lawall wrote: >> > >> > >> > On Sat, 30 Sep 2017, Srishti Sharma wrote: >> > >> >

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

On Sat, Sep 30, 2017 at 11:36 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sat, 30 Sep 2017, Srishti Sharma wrote: > >> On Sat, Sep 30, 2017 at 10:35 AM, Julia Lawall <julia.law...@lip6.fr> wrote: >> > >> > >> > On Sat, 30

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

On Sat, Sep 30, 2017 at 11:36 AM, Julia Lawall wrote: > > > On Sat, 30 Sep 2017, Srishti Sharma wrote: > >> On Sat, Sep 30, 2017 at 10:35 AM, Julia Lawall wrote: >> > >> > >> > On Sat, 30 Sep 2017, Srishti Sharma wrote: >> > >> &

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

On Sat, Sep 30, 2017 at 10:35 AM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sat, 30 Sep 2017, Srishti Sharma wrote: > >> For variables of the type struct list_head* use list_entry to access >> the current list element instead of using container_of. >&g

Re: [Outreachy kernel] [PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

On Sat, Sep 30, 2017 at 10:35 AM, Julia Lawall wrote: > > > On Sat, 30 Sep 2017, Srishti Sharma wrote: > >> For variables of the type struct list_head* use list_entry to access >> the current list element instead of using container_of. >> Done using the followin

[PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

_entry ( ...) ) Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta

[PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

_entry ( ...) ) Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188eu/core/rtw_sta_mgt.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c b/drivers/staging/rtl8188eu/core/rtw_sta_mgt.c index 22cf362..f9df4ac

[PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

_entry ( ...) ) Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/rtl8188eu/core/rtw_recv.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/core/rtw_recv.c index 3fd5

[PATCH] Staging: rtl8188eu: core: Use list_entry instead of container_of

_entry ( ...) ) Signed-off-by: Srishti Sharma --- drivers/staging/rtl8188eu/core/rtw_recv.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_recv.c b/drivers/staging/rtl8188eu/core/rtw_recv.c index 3fd5f41..af59c16 100644 --- a/d

[PATCH] drm/virtio: Replace instances of reference/unreference with get/put

Replace reference/unreference with get/put as it is consistent with the kernel coding style. Done using the following semantic patch by coccinelle. @r@ expression e; @@ -drm_gem_object_unreference_unlocked(e); +drm_gem_object_put_unlocked(e); Signed-off-by: Srishti Sharma <srishtis...@gmail.

[PATCH] drm/virtio: Replace instances of reference/unreference with get/put

Replace reference/unreference with get/put as it is consistent with the kernel coding style. Done using the following semantic patch by coccinelle. @r@ expression e; @@ -drm_gem_object_unreference_unlocked(e); +drm_gem_object_put_unlocked(e); Signed-off-by: Srishti Sharma --- drivers/gpu/drm

[PATCH] drm/arm: Replace instances of drm_dev_unref with drm_dev_put.

Replace drm_dev_unref with drm_dev_put as it is more consistent with kernel coding style. Done using the following semantic patch by coccinelle. @r@ expression e; @@ -drm_dev_unref(); +drm_dev_put(); Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/gpu/drm/arm/hdlcd_drv.

[PATCH] drm/arm: Replace instances of drm_dev_unref with drm_dev_put.

Replace drm_dev_unref with drm_dev_put as it is more consistent with kernel coding style. Done using the following semantic patch by coccinelle. @r@ expression e; @@ -drm_dev_unref(); +drm_dev_put(); Signed-off-by: Srishti Sharma --- drivers/gpu/drm/arm/hdlcd_drv.c | 4 ++-- drivers/gpu/drm

[PATCH v2 2/2] Staging: dgnc: Remove unused fields in struct channel_t

Eliminate the fields that are not used and the comments associated with them. Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2: - Use the word field instead of variable. drivers/staging/dgnc/dgnc_driver.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/d

[PATCH v2 2/2] Staging: dgnc: Remove unused fields in struct channel_t

Eliminate the fields that are not used and the comments associated with them. Signed-off-by: Srishti Sharma --- Changes in v2: - Use the word field instead of variable. drivers/staging/dgnc/dgnc_driver.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/dgnc

[PATCH v2 1/2] Staging: dgnc: Remove unused fields in struct dgnc_board

Remove unused fields and comments associated with them in the structure definition. Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- Changes in v2: - Use the word field instead of variable. drivers/staging/dgnc/dgnc_driver.h | 9 - 1 file changed, 9 deletions(-) diff

[PATCH v2 1/2] Staging: dgnc: Remove unused fields in struct dgnc_board

Remove unused fields and comments associated with them in the structure definition. Signed-off-by: Srishti Sharma --- Changes in v2: - Use the word field instead of variable. drivers/staging/dgnc/dgnc_driver.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/dgnc

[PATCH v2 0/2] Remove unused fields in structure definition

Remove fields that are not used, from structure definitions , and eliminate the comments associated with them. Srishti Sharma (2): Staging: dgnc: Remove unused variables in structure definition Staging: dgnc: Remove unused variable in structure drivers/staging/dgnc/dgnc_driver.h | 15

[PATCH v2 0/2] Remove unused fields in structure definition

Remove fields that are not used, from structure definitions , and eliminate the comments associated with them. Srishti Sharma (2): Staging: dgnc: Remove unused variables in structure definition Staging: dgnc: Remove unused variable in structure drivers/staging/dgnc/dgnc_driver.h | 15

[PATCH 0/2] Remove unused variables in structure definition

This patch series attempts to remove unused variables in structure variables and the comments associated with them. Srishti Sharma (2): Staging: dgnc: Remove unused variables in structure definition Staging: dgnc: Remove unused variable in structure drivers/staging/dgnc/dgnc_driver.h | 15

[PATCH 0/2] Remove unused variables in structure definition

This patch series attempts to remove unused variables in structure variables and the comments associated with them. Srishti Sharma (2): Staging: dgnc: Remove unused variables in structure definition Staging: dgnc: Remove unused variable in structure drivers/staging/dgnc/dgnc_driver.h | 15

[PATCH 2/2] Staging: dgnc: Remove unused variable in struct channel_t

Eliminate the variables that are not used and the comments associated with them. Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/stagin

[PATCH 2/2] Staging: dgnc: Remove unused variable in struct channel_t

Eliminate the variables that are not used and the comments associated with them. Signed-off-by: Srishti Sharma --- drivers/staging/dgnc/dgnc_driver.h | 6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h index 5d2566e

[PATCH 1/2] Staging: dgnc: Remove unused variables in struct dgnc_board

Remove unused variables and comments associated with them in the structure definition. Signed-off-by: Srishti Sharma <srishtis...@gmail.com> --- drivers/staging/dgnc/dgnc_driver.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/s

[PATCH 1/2] Staging: dgnc: Remove unused variables in struct dgnc_board

Remove unused variables and comments associated with them in the structure definition. Signed-off-by: Srishti Sharma --- drivers/staging/dgnc/dgnc_driver.h | 9 - 1 file changed, 9 deletions(-) diff --git a/drivers/staging/dgnc/dgnc_driver.h b/drivers/staging/dgnc/dgnc_driver.h index

Re: [Outreachy kernel] [PATCH] Staging: dgnc: Remove unused variables from structure definition

On Sat, Sep 16, 2017 at 5:45 PM, Julia Lawall <julia.law...@lip6.fr> wrote: > > > On Sat, 16 Sep 2017, Srishti Sharma wrote: > >> On Sat, Sep 16, 2017 at 5:20 PM, Julia Lawall <julia.law...@lip6.fr> wrote: >> > >> > >> > On Sat, 16

Re: [Outreachy kernel] [PATCH] Staging: dgnc: Remove unused variables from structure definition

On Sat, Sep 16, 2017 at 5:45 PM, Julia Lawall wrote: > > > On Sat, 16 Sep 2017, Srishti Sharma wrote: > >> On Sat, Sep 16, 2017 at 5:20 PM, Julia Lawall wrote: >> > >> > >> > On Sat, 16 Sep 2017, Srishti Sharma wrote: >> > >> &

  1   2   3   >