Re: [PATCH v3 0/2] Intra-refresh period control

Hi Hans, Any comments? On 3/2/21 11:53 AM, Stanimir Varbanov wrote: > Hi, > > This series add a new intra-refresh period control for encoders. The > series is a continuation of [1]. Comments addressed: > * A typo in .rst (Hans) > * Clarified the relationship with CYCLIC_INTR

Re: [PATCH 3/3] media: venus: don't de-reference NULL pointers at IRQ time

hehab > --- > drivers/media/platform/qcom/venus/hfi_venus.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-) Acked-by: Stanimir Varbanov > > diff --git a/drivers/media/platform/qcom/venus/hfi_venus.c > b/drivers/media/platform/qcom/venus/hfi_venus.c >

Re: [PATCH 1/3] media: venus: use NULL instead of zero for pointers

++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Acked-by: Stanimir Varbanov > > diff --git a/drivers/media/platform/qcom/venus/core.c > b/drivers/media/platform/qcom/venus/core.c > index f5b88b96f5f7..4451e3c11bc0 100644 > --- a/drivers/media/platform/qcom/venus/core.c

[PATCH] venus: hfi_venus: Fix a warning in venus ISR

Fix the following smatch warning: hfi_venus.c:1100 venus_isr() warn: variable dereferenced before check 'hdev' (see line 1097) Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_venus.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH] venus: core: Fix a warning in register offsets

Fix the following sparse warnings: core.c:227:41: warning: Using plain integer as NULL pointer core.c:228:34: warning: Using plain integer as NULL pointer Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH] venus: core: Fix kerneldoc warnings

Fix kerneldoc warnings in description of venus_core and venus_inst structures Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 40 ++-- 1 file changed, 31 insertions(+), 9 deletions(-) diff --git a/drivers/media/platform/qcom/venus/core.h b

Re: linux-next: manual merge of the opp tree with the v4l-dvb tree

Hi Viresh, On 3/25/21 6:25 AM, Viresh Kumar wrote: > On 24-03-21, 16:49, Stanimir Varbanov wrote: >> Thanks Stephen! >> >> On 3/23/21 2:27 AM, Stephen Rothwell wrote: >>> Hi all, >>> >>> Today's linux-next merge of the opp tree got a conflict

Re: [PATCH v3 14/15] media: venus: Convert to use resource-managed OPP API

Hi, On 3/14/21 6:34 PM, Dmitry Osipenko wrote: > From: Yangtao Li > > Use resource-managed OPP API to simplify code. > > Signed-off-by: Yangtao Li > Signed-off-by: Dmitry Osipenko > --- > drivers/media/platform/qcom/venus/core.h | 1 - > .../media/platform/qcom/venus/pm_helpers.c|

Re: linux-next: manual merge of the opp tree with the v4l-dvb tree

Thanks Stephen! On 3/23/21 2:27 AM, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the opp tree got a conflict in: > > drivers/media/platform/qcom/venus/pm_helpers.c > > between commit: > > 08b1cf474b7f ("media: venus: core, venc, vdec: Fix probe dependency error") > >

Re: [PATCH] media: venus: Fix internal buffer size calculations for v6.

On 3/17/21 10:35 AM, Dikshita Agarwal wrote: > - Update persist buffer size for encoder to 204800. > - Update persist buffer size calculation for h264 decoder. > - h264d level 6 support needs update in internal buffer size. > update below buffers size > - h264 decoder colocated motion

[PATCH v6 4/5] docs: Document CLL and Mastering display colorimetry controls

Document Content Light Level and Mastering Display v4l2 colorimetry controls. Signed-off-by: Stanimir Varbanov Reviewed-by: Hans Verkuil --- .../media/v4l/ext-ctrls-colorimetry.rst | 71 +++ .../media/v4l/vidioc-g-ext-ctrls.rst | 8 +++ .../media/videodev2

[PATCH v6 5/5] venus: venc: Add support for CLL and Mastering display controls

Create CLL and Mastering display colour volume v4l2 controls for encoder, add handling of HDR10 PQ SEI packet payloads for v4. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 2 ++ drivers/media/platform/qcom/venus/hfi_cmds.c | 8 + .../media/platform

[PATCH v6 2/5] docs: Document colorimetry class

Add a document for ext control colorimetry class. Signed-off-by: Stanimir Varbanov Reviewed-by: Hans Verkuil --- .../userspace-api/media/v4l/common.rst| 1 + .../media/v4l/ext-ctrls-colorimetry.rst | 22 +++ .../media/v4l/vidioc-g-ext-ctrls.rst | 4

[PATCH v6 3/5] v4l: Add HDR10 static metadata controls

Introduce Content light level and Mastering display colour volume Colorimetry compound controls with relevant payload structures and validation. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-ctrls.c | 68 include/media/v4l2-ctrls.h | 4

[PATCH v6 1/5] v4l: Add new Colorimetry Class

Add Colorimetry control class for colorimetry controls Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-ctrls.c | 7 ++- include/uapi/linux/v4l2-controls.h | 4 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b

[PATCH v6 0/5] HDR10 static metadata

Hello, Changes since v5: * added Reviewed-by tags * 3/5 - added a comment (Hans) * 4/5 - drop "coded" word in documentation (Hans) regards, Stan Stanimir Varbanov (5): v4l: Add new Colorimetry Class docs: Document colorimetry class v4l: Add HDR10 static metadata contr

[PATCH v3 1/2] v4l2-ctrl: Add decoder conceal color control

Add decoder v4l2 control to set conceal color. Signed-off-by: Stanimir Varbanov Reviewed-by: Hans Verkuil --- .../media/v4l/ext-ctrls-codec.rst | 33 +++ drivers/media/v4l2-core/v4l2-ctrls.c | 9 + include/uapi/linux/v4l2-controls.h| 1

[PATCH v3 0/2] Add decoder conceal color ctrl

Hi, Changes since v2: * addressed Hans's comments 1/2 in documentation. regards, Stan Stanimir Varbanov (2): v4l2-ctrl: Add decoder conceal color control venus: vdec: Add support for conceal control .../media/v4l/ext-ctrls-codec.rst | 33 +++ drivers/media

[PATCH v3 2/2] venus: vdec: Add support for conceal control

Adds support for decoder conceal color control. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/hfi_cmds.c | 18 -- drivers/media/platform/qcom/venus/hfi_helper.h | 10 ++ drivers/media

Re: [PATCH v5 3/5] v4l: Add HDR10 static metadata controls

Hi Hans, On 3/16/21 2:16 PM, Hans Verkuil wrote: > On 09/02/2021 17:24, Stanimir Varbanov wrote: >> Introduce Content light level and Mastering display colour >> volume Colorimetry compound controls with relevant payload >> structures and validation. >> >>

Re: [PATCH] v4l2-ctrls: Fix h264 hierarchical coding type menu ctrl

Kindly ping for review. On 3/3/21 12:42 AM, Stanimir Varbanov wrote: > Add a name of the menu and fill control type. > > Signed-off-by: Stanimir Varbanov > --- > drivers/media/v4l2-core/v4l2-ctrls.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/driv

Re: [PATCH v5 0/5] HDR10 static metadata

Hans, any comments? On 2/9/21 6:24 PM, Stanimir Varbanov wrote: > Changes since v4: > * 1/5 - fixed a typo (Hans) > * 2/5 - add some mode info about new colorimetry class (Hans) > * 4/5 - correct cd/m2 -> cd/m\ :sup:`2` > - change to US spelling for color wo

Re: [PATCH v2 0/2] Add decoder conceal color ctrl

Hans, any comments ? On 3/2/21 1:44 PM, Stanimir Varbanov wrote: > Hi, > > The changes in v2 includes: > * reformat the table in documetation to define Bits for different >bit-depths of color formats. > > regards, > Stan > > Stanimir Varbanov (2): > v4l

[PATCH 3/5] venus: pm_helpers: Set opp clock name for v1

Signed-off-by: Stanimir Varbanov --- .../media/platform/qcom/venus/pm_helpers.c| 20 ++- 1 file changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/pm_helpers.c b/drivers/media/platform/qcom/venus/pm_helpers.c index 43c4e3d9e281..12f6d3ab8

[PATCH 4/5] venus: venc_ctrls: Change default header mode

It is observed that on Venus v1 the default header-mode is producing a bitstream which is not playble. Change the default header-mode to joined with 1st frame. Fixes: 002c22bd360e ("media: venus: venc: set inband mode property to FW.") Cc: sta...@vger.kernel.org # v5.12+ Signed-off-by

[PATCH 5/5] venus: hfi_cmds: Support plane-actual-info property from v1

The property is supported from v1 and upwards. So move it to set_property_1x. Fixes: 01e869e78756 ("media: venus: venc: fix handlig of S_SELECTION and G_SELECTION") Cc: sta...@vger.kernel.org # v5.12+ Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_c

[PATCH 0/5] Venus msm8916 fixes

Hello, Here are few fixes for msm8916 (Venus v1x): * Two fixes in hfi_parser * One fix related to opp_set_clk_rate * Default header-mode for encoder is changed to join-with-1st-frame * Added support for actual-plane-info for v1x too regards, Stan Stanimir Varbanov (5): venus: hfi_parser

[PATCH 1/5] venus: hfi_parser: Don't initialize parser on v1

: parser: Prepare parser for multiple invocations") Cc: sta...@vger.kernel.org # v5.10+ Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_parser.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_parser.c b/

[PATCH 2/5] venus: hfi_parser: Check for instance after hfi platform get

;) Cc: sta...@vger.kernel.org # v5.12+ Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_parser.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_parser.c b/drivers/media/platform/qcom/venus/hfi_parser.c index ce

[PATCH] v4l2-ctrls: Fix h264 hierarchical coding type menu ctrl

Add a name of the menu and fill control type. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-ctrls.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2-core/v4l2-ctrls.c index 016cf6204cbb..5d99e2294335

[PATCH v2 2/2] venus: vdec: Add support for conceal control

Adds support for decoder conceal color control. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/hfi_cmds.c | 18 -- drivers/media/platform/qcom/venus/hfi_helper.h | 10 ++ drivers/media

[PATCH v2 0/2] Add decoder conceal color ctrl

Hi, The changes in v2 includes: * reformat the table in documetation to define Bits for different bit-depths of color formats. regards, Stan Stanimir Varbanov (2): v4l2-ctrl: Add decoder conceal color control venus: vdec: Add support for conceal control .../media/v4l/ext-ctrls

[PATCH v2 1/2] v4l2-ctrl: Add decoder conceal color control

Add decoder v4l2 control to set conceal color. Signed-off-by: Stanimir Varbanov --- .../media/v4l/ext-ctrls-codec.rst | 33 +++ drivers/media/v4l2-core/v4l2-ctrls.c | 9 + include/uapi/linux/v4l2-controls.h| 1 + 3 files changed, 43

[PATCH v3 1/2] media: v4l2-ctrls: Add intra-refresh period control

Add a control to set intra-refresh period. Signed-off-by: Stanimir Varbanov --- .../userspace-api/media/v4l/ext-ctrls-codec.rst | 12 drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++ include/uapi/linux/v4l2-controls.h | 1 + 3 files changed, 15

[PATCH v3 0/2] Intra-refresh period control

-media/msg183019.html Stanimir Varbanov (2): media: v4l2-ctrls: Add intra-refresh period control venus: venc: Add support for intra-refresh period .../media/v4l/ext-ctrls-codec.rst | 12 drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus

[PATCH v3 2/2] venus: venc: Add support for intra-refresh period

Add support for intra-refresh period v4l2 control and drop cyclic intra-refresh macroblock control in the same time. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/venc.c | 28 +++ .../media

Re: [PATCH] media: venus: use contig vb2 ops

On 3/1/21 11:23 AM, Tomasz Figa wrote: > Hi Alex, Stanimir, > > On Wed, Dec 16, 2020 at 12:15 PM Tomasz Figa wrote: >> >> On Wed, Dec 16, 2020 at 4:21 AM Nicolas Dufresne >> wrote: >>> >>> Le mardi 15 décembre 2020 à 15:54 +0200, Stanimir Varba

Re: [PATCH 1/2] v4l2-ctrl: Add decoder conceal color control

On 2/16/21 10:58 AM, Hans Verkuil wrote: > On 16/02/2021 09:56, Stanimir Varbanov wrote: >> >> >> On 2/15/21 1:57 PM, Hans Verkuil wrote: >>> On 15/02/2021 12:32, Stanimir Varbanov wrote: >>>> >>>> >>>> On 2/9/21 1:05 PM, Hans

Re: [PATCH 1/2] v4l2-ctrl: Add decoder conceal color control

On 2/15/21 1:57 PM, Hans Verkuil wrote: > On 15/02/2021 12:32, Stanimir Varbanov wrote: >> >> >> On 2/9/21 1:05 PM, Hans Verkuil wrote: >>> On 09/02/2021 10:45, Stanimir Varbanov wrote: >>>> Add decoder v4l2 control to set conceal color.

Re: [PATCH 1/2] v4l2-ctrl: Add decoder conceal color control

On 2/9/21 1:05 PM, Hans Verkuil wrote: > On 09/02/2021 10:45, Stanimir Varbanov wrote: >> Add decoder v4l2 control to set conceal color. >> >> Signed-off-by: Stanimir Varbanov >> --- >> .../media/v4l/ext-ctrls-codec.rst | 20 +++

[PATCH v5 5/5] venus: venc: Add support for CLL and Mastering display controls

Create CLL and Mastering display colour volume v4l2 controls for encoder, add handling of HDR10 PQ SEI packet payloads for v4. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 2 ++ drivers/media/platform/qcom/venus/hfi_cmds.c | 8 + .../media/platform

[PATCH v5 4/5] docs: Document CLL and Mastering display colorimetry controls

Document Content Light Level and Mastering Display v4l2 colorimetry controls. Signed-off-by: Stanimir Varbanov --- .../media/v4l/ext-ctrls-colorimetry.rst | 71 +++ .../media/v4l/vidioc-g-ext-ctrls.rst | 8 +++ .../media/videodev2.h.rst.exceptions | 2

[PATCH v5 3/5] v4l: Add HDR10 static metadata controls

Introduce Content light level and Mastering display colour volume Colorimetry compound controls with relevant payload structures and validation. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-ctrls.c | 67 include/media/v4l2-ctrls.h | 4

[PATCH v5 2/5] docs: Document colorimetry class

Add a document for ext control colorimetry class. Signed-off-by: Stanimir Varbanov --- .../userspace-api/media/v4l/common.rst| 1 + .../media/v4l/ext-ctrls-colorimetry.rst | 22 +++ .../media/v4l/vidioc-g-ext-ctrls.rst | 4 3 files changed, 27

[PATCH v5 1/5] v4l: Add new Colorimetry Class

Add Colorimetry control class for colorimetry controls Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-ctrls.c | 7 ++- include/uapi/linux/v4l2-controls.h | 4 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b

[PATCH v5 0/5] HDR10 static metadata

ted p_hdr10_cll and p_hdr10_mastering in vidioc-g-ext-ctrls.rst Comments are welcome! regards, Stan Stanimir Varbanov (5): v4l: Add new Colorimetry Class docs: Document colorimetry class v4l: Add HDR10 static metadata controls docs: Document CLL and Mastering display colorime

[PATCH 2/2] venus: vdec: Add support for conceal control

Adds support for decoder conceal color control. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/hfi_cmds.c | 18 -- drivers/media/platform/qcom/venus/hfi_helper.h | 10 ++ drivers/media

[PATCH 1/2] v4l2-ctrl: Add decoder conceal color control

Add decoder v4l2 control to set conceal color. Signed-off-by: Stanimir Varbanov --- .../media/v4l/ext-ctrls-codec.rst | 20 +++ drivers/media/v4l2-core/v4l2-ctrls.c | 9 + include/uapi/linux/v4l2-controls.h| 1 + 3 files changed, 30

[PATCH 0/2] Add decoder conceal color ctrl

Hello, The first patch is adding a new control for conceal error color and the second adds support for it in the Venus decoder driver. Comments are welcome! regards, Stan Stanimir Varbanov (2): v4l2-ctrl: Add decoder conceal color control venus: vdec: Add support for conceal control

Re: [PATCH 1/2] media: venus: core: Add sdm660 DT compatible and resource struct

On 1/25/21 5:01 PM, Hans Verkuil wrote: > On 25/01/2021 15:51, AngeloGioacchino Del Regno wrote: >> Il 25/01/21 11:40, Hans Verkuil ha scritto: >>> On 18/01/2021 18:45, AngeloGioacchino Del Regno wrote: >>>> Il 18/01/21 18:21, Stanimir Varbanov ha scritto: >&

[PATCH] venus: core: Parse firmware-name DT property

to the predefined path from driver resource structure. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/firmware.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/qcom/venus/firmware.c b/drivers/media/platform/qcom/venus/firmware.c

Re: [PATCH v2 3/9] clk: qcom: Add SDM660 Multimedia Clock Controller (MMCC) driver

On 1/13/21 8:38 PM, AngeloGioacchino Del Regno wrote: > From: Martin Botka > > Add a driver for the multimedia clock controller found on SDM660 > based devices. This should allow most multimedia device drivers > to probe and control their clocks. > > Signed-off-by: Martin Botka >

Re: [PATCH v2 0/4] MFC private ctrls to std ctrls

Hans, any comments ? On 1/15/21 11:26 AM, Stanimir Varbanov wrote: > Hello, > > Changes in v2: > > * use _DEC_ instead of _DECODER_ in the name of the new controls (Hans) > * rebase on top of media master branch > > v1 can be found at [1] > > reg

[PATCH v4 4/5] docs: Document CLL and Mastering display colorimetry controls

Document Content Light Level and Mastering Display v4l2 colorimetry controls. Signed-off-by: Stanimir Varbanov --- .../media/v4l/ext-ctrls-colorimetry.rst | 71 +++ .../media/videodev2.h.rst.exceptions | 2 + 2 files changed, 73 insertions(+) diff --git

[PATCH v4 5/5] venus: venc: Add support for CLL and Mastering display controls

Create CLL and Mastering display colour volume v4l2 controls for encoder, add handling of HDR10 PQ SEI packet payloads for v4. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 2 ++ drivers/media/platform/qcom/venus/hfi_cmds.c | 8 + .../media/platform

[PATCH v4 3/5] v4l: Add HDR10 static metadata controls

Introduce Content light level and Mastering display colour volume Colorimetry compound controls with relevant payload structures and validation. Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-ctrls.c | 67 include/media/v4l2-ctrls.h | 4

[PATCH v4 1/5] v4l: Add new Colorimetry Class

Add Colorimetry control class for colorimetry controls Signed-off-by: Stanimir Varbanov --- drivers/media/v4l2-core/v4l2-ctrls.c | 5 + include/uapi/linux/v4l2-controls.h | 4 2 files changed, 9 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ctrls.c b/drivers/media/v4l2

[PATCH v4 2/5] docs: Document colorimetry class

Add a document for ext control colorimetry class. Signed-off-by: Stanimir Varbanov --- .../userspace-api/media/v4l/common.rst| 1 + .../media/v4l/ext-ctrls-colorimetry.rst | 19 +++ .../media/v4l/vidioc-g-ext-ctrls.rst | 4 3 files changed, 24

[PATCH v4 0/5] HDR10 static metadata

Hello, Changes in v4: * reorder and split patches (Hans) * fixed typos in documentation patches (Hans) v3 can be found at [1]. regards, Stan [1] https://patchwork.linuxtv.org/project/linux-media/cover/20201208145931.6187-1-stanimir.varba...@linaro.org/ Stanimir Varbanov (5): v4l: Add

[PATCH v3 0/2] AUD encoder control

/list/?series=4083 Stanimir Varbanov (2): media: v4l2-ctrls: Add control for AUD generation venus: venc: Add support for AUD NALU control .../userspace-api/media/v4l/ext-ctrls-codec.rst| 5 + drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus

[PATCH v3 1/2] media: v4l2-ctrls: Add control for AUD generation

Add a control to enable inserting of AUD NALU into encoded bitstream. Reviewed-by: Hans Verkuil Signed-off-by: Stanimir Varbanov --- Documentation/userspace-api/media/v4l/ext-ctrls-codec.rst | 5 + drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++ include/uapi/linux/v4l2

[PATCH v3 2/2] venus: venc: Add support for AUD NALU control

Add support for Access Unit Delimiter control into encoder. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/venc.c | 14 ++ drivers/media/platform/qcom/venus/venc_ctrls.c | 8 +++- 3 files

Re: [PATCH] venus: core: Fix platform driver shutdown

On 1/19/21 9:40 AM, Shawn Guo wrote: > On Mon, Dec 21, 2020 at 11:58:20AM +0200, Stanimir Varbanov wrote: >> With TZ system reboot cannot finish successfully. To fix that >> enable core clocks by runtime pm before TZ calls and disable >> clocks after that. >> >

Re: [PATCH 1/2] media: venus: core: Add sdm660 DT compatible and resource struct

static const struct venus_resources sc7180_res = { > static const struct of_device_id venus_dt_match[] = { > { .compatible = "qcom,msm8916-venus", .data = _res, }, > { .compatible = "qcom,msm8996-venus", .data = _res, }, > + { .compatible = "qcom,sdm660-venus", .data = _res, }, > { .compatible = "qcom,sdm845-venus", .data = _res, }, > { .compatible = "qcom,sdm845-venus-v2", .data = _res_v2, }, > { .compatible = "qcom,sc7180-venus", .data = _res, }, > Reviewed-by: Stanimir Varbanov -- regards, Stan [1] https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/qcom/venus-4.2

Re: [PATCH 2/2] media: dt-bindings: media: venus: Add sdm660 DT schema

On 1/17/21 9:23 PM, AngeloGioacchino Del Regno wrote: > Il 17/01/21 16:45, Rob Herring ha scritto: >> On Fri, 15 Jan 2021 19:52:52 +0100, AngeloGioacchino Del Regno wrote: >>> Add new qcom,sdm660-venus DT binding schema. >>> >>> Signed-off-by: AngeloGioacchino Del Regno >>> >>> --- >>>  

Re: [RESEND PATCH] PCI: qcom: use PHY_REFCLK_USE_PAD only for ipq8064

"PCI: qcom: Add support for tx term offset for rev 2.1.0") > Reported-by: Ilia Mirkin > Signed-off-by: Ilia Mirkin > Signed-off-by: Ansuel Smith > Cc: sta...@vger.kernel.org # v4.19+ Acked-by: Stanimir Varbanov > --- > drivers/pci/controller/dwc/pcie-qcom.c | 4

Re: [PATCH v2 1/4] media: v4l2-ctrls: Add intra-refresh period control

On 1/12/21 12:05 PM, Hans Verkuil wrote: > On 06/12/2020 11:27, Stanimir Varbanov wrote: >> Add a control to set intra-refresh period. >> >> Signed-off-by: Stanimir Varbanov >> --- >> .../userspace-api/media/v4l/ext-ctrls-codec.rst | 11 +++

[PATCH v2 3/4] s5p-mfc: Use display delay and display enable std controls

Use the standard display_delay and display_delay_enable controls, the legacy private MFC controls are kept for backward compatibility. Acked-by: Marek Szyprowski Signed-off-by: Stanimir Varbanov --- drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 16 1 file changed, 16

[PATCH v2 4/4] docs: Deprecate mfc display delay controls

Deprecate mfc private display delay and display enable controls for new clients and use the standard controls instead. Signed-off-by: Stanimir Varbanov --- .../userspace-api/media/v4l/ext-ctrls-codec.rst| 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation

[PATCH v2 2/4] venus: vdec: Add support for display delay and delay enable controls

Add support for display delay and display delay enable std controls. With this we implement decoder decode output order (decode vs display). Once firmware implement few new features the controls will be used for other use-cases. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom

[PATCH v2 1/4] v4l2-ctrl: Make display delay and display enable std controls

Make display delay and display delay enable MFC controls standard v4l controls. This will allow reuse of the controls for other decoder drivers. Also the new proposed controls are now codec agnostic because they could be used for any codec. Signed-off-by: Stanimir Varbanov --- .../userspace-api

[PATCH v2 0/4] MFC private ctrls to std ctrls

/ Stanimir Varbanov (4): v4l2-ctrl: Make display delay and display enable std controls venus: vdec: Add support for display delay and delay enable controls s5p-mfc: Use display delay and display enable std controls docs: Deprecate mfc display delay controls .../media/v4l/ext-ctrls-codec.rst

[PATCH] venus: hfi_plat: Fix warning for missing function prototype

The bufreq_enc function should be static. Reported-by: kernel test robot Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/hfi_plat_bufs_v6.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/hfi_plat_bufs_v6.c b

[PATCH v2] venus: pm_helpers: Control core power domain manually

Presently we use device_link to control core power domain. But this leads to issues because the genpd doesn't guarantee synchronous on/off for supplier devices. Switch to manually control by pmruntime calls. Tested-by: Fritz Koenig Signed-off-by: Stanimir Varbanov --- changes since v1: * drop

Re: [PATCH v4 3/3] venus: venc: Add support for frame-specific min/max qp controls

> drivers/media/platform/qcom/venus/venc.c | 21 +++-- > drivers/media/platform/qcom/venus/venc_ctrls.c | 114 > +++-- > 3 files changed, 142 insertions(+), 11 deletions(-) Acked-by: Stanimir Varbanov -- regards, Stan

Re: [PATCH v4 2/2] venus: venc : Add support for priority ID control.

edia/platform/qcom/venus/venc_ctrls.c | 9 - > 2 files changed, 10 insertions(+), 1 deletion(-) Acked-by: Stanimir Varbanov -- regards, Stan

[PATCH] venus: pm_helpers: Control core power domain manually

Presently we use device_link to control core power domain. But this leads to issues because the genpd doesn't guarantee synchronous on/off for supplier devices. Switch to manually control by pmruntime calls. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1

Re: [PATCH v2 7/8] venus: venc: Handle reset encoder state

venc_start_streaming| substantially. This patch > implements |venc_stop_streaming|, but maybe that is not needed with > the newer patch? Can this one just be dropped, or does it need > rework? > > -Fritz > > [1]: https://lore.kernel.org/patchwork/patch/1349416/ > &

Re: [PATCH v2] venus: venc: set inband mode property to FW.

On 12/16/20 8:49 AM, Dikshita Agarwal wrote: > set HFI_PROPERTY_CONFIG_VENC_SYNC_FRAME_SEQUENCE_HEADER to FW > to support inband sequence header mode. > > Signed-off-by: Dikshita Agarwal > > Changes since v1: > - added codec check > - fixed the mask while initializing the control > > --- >

Re: [PATCH] venus: venc: set IDR period to FW only for H264 & HEVC

ivers/media/platform/qcom/venus/venc.c | 23 +-- > 1 file changed, 13 insertions(+), 10 deletions(-) Reviewed-by: Stanimir Varbanov > > diff --git a/drivers/media/platform/qcom/venus/venc.c > b/drivers/media/platform/qcom/venus/venc.c > index 3a2e449..618cf92 10

[PATCH] venus: core: Fix platform driver shutdown

With TZ system reboot cannot finish successfully. To fix that enable core clocks by runtime pm before TZ calls and disable clocks after that. Fixes: 7399139be6b2 ("media: venus: core: add shutdown callback for venus") Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/ve

[PATCH v2 5/5] venus: vdec: Handle DRC after drain

-by: Fritz Koenig Signed-off-by: Stanimir Varbanov --- Changes since v2 (from Fritz): - moved state transition from vdec_event_notify to vdec_event_change. drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/vdec.c | 14 -- 2 files changed, 13 insertions

[PATCH v2 3/5] venus: helpers: Lock outside of buffer queue helper

After adding more logic in vdec buf_queue vb2 op it is not practical to have two lock/unlock for one decoder buf_queue. So move the instance lock in encoder and decoder vb2 buf_queue operations. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 11

[PATCH v2 4/5] media: venus: preserve DRC state across seeks

. Returning to the DRC state upon resume for seeking makes sure that the client will get the DRC event and will reallocate the buffers to fit the firmware's expectations. Signed-off-by: Alexandre Courbot Signed-off-by: Stanimir Varbanov --- No changes since v1. drivers/media/platform/qcom/venus

[PATCH v2 1/5] venus: vdec: Fix non reliable setting of LAST flag

. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h| 5 +-- drivers/media/platform/qcom/venus/helpers.c | 6 +++ drivers/media/platform/qcom/venus/vdec.c| 45 - 3 files changed, 33 insertions(+), 23 deletions(-) diff --git a/drivers/media

[PATCH v2 0/5] Venus dynamic resolution change fixes

regards, Stan Alexandre Courbot (1): media: venus: preserve DRC state across seeks Fritz Koenig (1): venus: vdec: Handle DRC after drain Stanimir Varbanov (3): venus: vdec: Fix non reliable setting of LAST flag venus: vdec: Make decoder return LAST flag for sufficient event venus

[PATCH v2 2/5] venus: vdec: Make decoder return LAST flag for sufficient event

This makes the decoder to behaives equally for sufficient and insufficient events. After this change the LAST buffer flag will be set when the new resolution (in dynamic-resolution-change state) is smaller then the old bitstream resolution. Signed-off-by: Stanimir Varbanov --- drivers/media

Re: [PATCH] media: venus: preserve DRC state across seeks

Hi Alex, On 12/2/20 7:34 AM, Alexandre Courbot wrote: > DRC events can happen virtually at anytime, including when we are > starting a seek. Should this happen, we must make sure to return to the > DRC state, otherwise the firmware will expect buffers of the new > resolution whereas userspace

Re: [PATCH] media: venus: use contig vb2 ops

Hi Tomasz, On 12/15/20 1:47 PM, Tomasz Figa wrote: > On Tue, Dec 15, 2020 at 8:16 PM Stanimir Varbanov > wrote: >> >> Hi, >> >> Cc: Robin >> >> On 12/14/20 2:57 PM, Alexandre Courbot wrote: >>> This driver uses the SG vb2 ops, but effective

Re: [PATCH] media: venus: use contig vb2 ops

Hi, Cc: Robin On 12/14/20 2:57 PM, Alexandre Courbot wrote: > This driver uses the SG vb2 ops, but effectively only ever accesses the > first entry of the SG table, indicating that it expects a flat layout. > Switch it to use the contiguous ops to make sure this expected invariant Under what

Re: [PATCH v4] venus: core: add support to dump FW region

ivers/media/platform/qcom/venus/firmware.c > @@ -201,6 +201,9 @@ int venus_boot(struct venus_core *core) > return -EINVAL; > } > > + core->fw.mem_size = mem_size; > + core->fw.mem_phys = mem_phys; > + > if (core->use_tz) > ret = qcom_scm_pas_auth_and_reset(VENUS_PAS_ID); > else > With those fixes: Reviewed-by: Stanimir Varbanov -- regards, Stan

Re: [PATCH v2 1/3] v4l: Add HDR10 static metadata controls

Hi Hans, On 12/7/20 11:21 AM, Hans Verkuil wrote: > On 07/12/2020 10:06, Stanimir Varbanov wrote: >> >> >> On 12/2/20 1:12 PM, Hans Verkuil wrote: >>> On 24/11/2020 00:02, Stanimir Varbanov wrote: >>>> Add Content light level and Mastering display

[PATCH v3 3/3] venus: venc: Add support for CLL and Mastering display controls

Create CLL and Mastering display colour volume v4l2 controls for encoder, add handling of HDR10 PQ SEI packet payloads for v4. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 3 ++ drivers/media/platform/qcom/venus/hfi_cmds.c | 8 + .../media/platform

[PATCH v3 2/3] docs: media: Document CLL and Mastering display

Document Content light level and Mastering display colour volume. Signed-off-by: Stanimir Varbanov --- .../userspace-api/media/v4l/common.rst| 1 + .../media/v4l/ext-ctrls-colorimetry.rst | 88 +++ 2 files changed, 89 insertions(+) create mode 100644

[PATCH v3 0/3] HDR10 static metadata

/linux-media/20201123230257.31690-1-stanimir.varba...@linaro.org/T/#mba512702aab370d4b0aa393dea54095e55d78552 Stanimir Varbanov (3): v4l: Add HDR10 static metadata controls docs: media: Document CLL and Mastering display venus: venc: Add support for CLL and Mastering display controls

[PATCH v3 1/3] v4l: Add HDR10 static metadata controls

Here we introduce a new Colorimetry control class and add Content light level and Mastering display colour volume v4l2 compound controls, relevant payload structures and validation. Signed-off-by: Stanimir Varbanov --- .../media/videodev2.h.rst.exceptions | 2 + drivers/media/v4l2

Re: [PATCH v2 1/3] v4l: Add HDR10 static metadata controls

On 12/2/20 1:12 PM, Hans Verkuil wrote: > On 24/11/2020 00:02, Stanimir Varbanov wrote: >> Add Content light level and Mastering display colour volume v4l2 >> compounf controls, relevant payload structures and validation. > > compounf -> compound > >> &g

[PATCH v2 4/4] venus: venc: Add support for AUD NALU control

Add support for Access Unit Delimiter control into encoder. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/venc.c | 14 ++ drivers/media/platform/qcom/venus/venc_ctrls.c | 8 +++- 3 files

[PATCH v2 1/4] media: v4l2-ctrls: Add intra-refresh period control

Add a control to set intra-refresh period. Signed-off-by: Stanimir Varbanov --- .../userspace-api/media/v4l/ext-ctrls-codec.rst | 11 +++ drivers/media/v4l2-core/v4l2-ctrls.c | 2 ++ include/uapi/linux/v4l2-controls.h| 1 + 3 files changed

[PATCH v2 2/4] venus: venc: Add support for intra-refresh period

Add support for intra-refresh period v4l2 control. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/core.h | 1 + drivers/media/platform/qcom/venus/venc.c | 28 +++ .../media/platform/qcom/venus/venc_ctrls.c| 9 +- 3 files changed, 37

  1   2   3   4   5   6   7   8   9   10   >