[PATCH V4 2/2] drm/vkms: Add support for virtual hardware mode

2021-04-05 Thread Sumera Priyadarsini
/igt-dev/2021-February/029355.html . The patch is based on Rodrigo Siqueira's patch(https://patchwork.freedesktop.org/patch/316851/?series=48469=3) and the ensuing review. Signed-off-by: Sumera Priyadarsini --- Changes in V3: - Refactor patchset(Melissa) Changes in V2: - Add atomic helper

[PATCH V4 1/2] drm/vkms: Refactor vkms_composer_worker() to prep for virtual_hw mode

2021-04-05 Thread Sumera Priyadarsini
virtual_hw mode. Signed-off-by: Sumera Priyadarsini --- Changes in V4: - Fix warning Changes in V3: - Refactor patchset (Melissa) Change in V2: - Add vkms_composer_common() (Daniel) --- drivers/gpu/drm/vkms/vkms_composer.c | 88 +--- drivers/gpu/drm/vkms/vkms_drv.h | 3 + 2

[PATCH V4 0/2] Add virtual hardware module

2021-04-05 Thread Sumera Priyadarsini
related to crc reads and skips tests that rely on vertical blanking. This patchset must be tested after incorporating the igt-tests patch: https://lists.freedesktop.org/archives/igt-dev/2021-February/029355.html Sumera Priyadarsini (2): drm/vkms: Refactor vkms_composer_worker() to prep

Re: [PATCH V3 1/2] drm/vkms: Refactor vkms_composer_worker() to prep for virtual_hw mode

2021-04-04 Thread Sumera Priyadarsini
git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch] > > url: > https://github.com/0day-ci/linux/commits/Sumera-Priyadarsini/Add-virtual-hardware-module/20210404-211300 > base: h

[PATCH V3 2/2] drm/vkms: Add support for virtual hardware mode

2021-04-04 Thread Sumera Priyadarsini
/igt-dev/2021-February/029355.html . The patch is based on Rodrigo Siqueira's patch(https://patchwork.freedesktop.org/patch/316851/?series=48469=3) and the ensuing review. Signed-off-by: Sumera Priyadarsini --- Changes in V3: - Refactor patchset(Melissa) Changes in V2: - Add atomic helper

[PATCH V3 1/2] drm/vkms: Refactor vkms_composer_worker() to prep for virtual_hw mode

2021-04-04 Thread Sumera Priyadarsini
virtual_hw mode. Signed-off-by: Sumera Priyadarsini --- Changes in V3: - Refactor patchset (Melissa) Change in V2: - Add vkms_composer_common() (Daniel) --- drivers/gpu/drm/vkms/vkms_composer.c | 88 +--- drivers/gpu/drm/vkms/vkms_drv.h | 3 + 2 files changed, 58

[PATCH V3 0/2] Add virtual hardware module

2021-04-04 Thread Sumera Priyadarsini
for subtests related to crc reads and skips tests that rely on vertical blanking. This patchset must be tested after incorporating the igt-tests patch: https://lists.freedesktop.org/archives/igt-dev/2021-February/029355.html Sumera Priyadarsini (2): drm/vkms: Refactor vkms_composer_worker

[PATCH V2 2/2] drm/vkms: Add crtc atomic helper functions for virtual mode

2021-03-03 Thread Sumera Priyadarsini
clearer and easier to test virtual hardware mode. Signed-off-by: Sumera Priyadarsini --- Changes in V2: - Add atomic helper functions in a separate struct for virtual hardware mode (Daniel) --- drivers/gpu/drm/vkms/vkms_crtc.c | 69 ++-- 1 file changed, 39 insertions

[PATCH V2 1/2] drm/vkms: Add support for virtual hardware mode

2021-03-03 Thread Sumera Priyadarsini
-shot implementation of crc reads so I am still working on that. The patch is based on Rodrigo Siqueira's patch(https://patchwork.freedesktop.org/patch/316851/?series=48469=3) and the ensuing review. Signed-off-by: Sumera Priyadarsini Changes in V2: - Remove spinlock across 'vkms_output->l

[PATCH V2 0/2] Add virtual hardware module

2021-03-03 Thread Sumera Priyadarsini
-February/029355.html . Sumera Priyadarsini (2): drm/vkms: Add support for virtual hardware mode drm/vkms: Add crtc atomic helper functions for virtual mode drivers/gpu/drm/vkms/vkms_composer.c | 88 +--- drivers/gpu/drm/vkms/vkms_crtc.c | 45 ++ drivers/gpu

[RFC PATCH] drm/vkms: Add support for virtual hardware mode

2021-02-24 Thread Sumera Priyadarsini
/029355.html . The patch is based on Rodrigo Siqueira's patch(https://patchwork.freedesktop.org/patch/316851/?series=48469=3) and the ensuing review. Signed-off-by: Sumera Priyadarsini --- drivers/gpu/drm/vkms/vkms_composer.c | 46 drivers/gpu/drm/vkms/vkms_crtc.c | 17

Re: [PATCH][next] drm/vkms: Fix missing kmalloc allocation failure check

2021-01-15 Thread Sumera Priyadarsini
rity: ("Dereference null return value") > Fixes: 2df7af93fdad ("drm/vkms: Add vkms_config type") > Signed-off-by: Colin Ian King Good catch, thank you! Reviewed-by: Sumera Priyadarsini > --- > drivers/gpu/drm/vkms/vkms_drv.c | 6 +- > 1 file changed, 5 in

[PATCH] drm/vblank: Fix typo in docs

2021-01-14 Thread Sumera Priyadarsini
Fix typo in intro chapter in drm_vblank.c. Change 'sacn' to 'scan'. Signed-off-by: Sumera Priyadarsini --- drivers/gpu/drm/drm_vblank.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c index d30e2f2b8f3c

[PATCH V5 3/3] drm/vkms: Add information about module options

2021-01-11 Thread Sumera Priyadarsini
Update vkms documentation to contain usage of `modinfo` command and steps to load vkms with module options enabled. Signed-off-by: Sumera Priyadarsini --- Documentation/gpu/vkms.rst | 12 1 file changed, 12 insertions(+) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu

[PATCH V5 2/3] drm/vkms: Add support for writeback module

2021-01-11 Thread Sumera Priyadarsini
Add enable_writeback feature to vkms_config as a module. Signed-off-by: Sumera Priyadarsini --- drivers/gpu/drm/vkms/vkms_drv.c| 5 + drivers/gpu/drm/vkms/vkms_drv.h| 1 + drivers/gpu/drm/vkms/vkms_output.c | 9 ++--- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git

[PATCH V5 1/3] drm/vkms: Add vkms_config type

2021-01-11 Thread Sumera Priyadarsini
functions. Modify usage of enable_cursor feature to reflect the changes in relevant files. Co-developed-by: Daniel Vetter Signed-off-by: Daniel Vetter Signed-off-by: Sumera Priyadarsini --- drivers/gpu/drm/vkms/vkms_drv.c| 40 -- drivers/gpu/drm/vkms/vkms_drv.h

[PATCH V5 0/3] Decouple config data for configfs

2021-01-11 Thread Sumera Priyadarsini
is developed by Daniel Vetter. Daniel Vetter (1): drm/vkms: Add vkms_config type Sumera Priyadarsini (3): drm/vkms: Add vkms_config type drm/vkms: Add support for writeback module drm/vkms: Add information about module options Documentation/gpu/vkms.rst | 12 drivers/gpu/drm/vkms

[PATCH V4 3/3] drm/vkms: Add information about module options

2021-01-10 Thread Sumera Priyadarsini
Update vkms documentation to contain usage of `modinfo` command and steps to load vkms with module options enabled. Signed-off-by: Sumera Priyadarsini --- Documentation/gpu/vkms.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/gpu/vkms.rst b/Documentation/gpu

[PATCH V4 2/3] drm/vkms: Add support for writeback module

2021-01-10 Thread Sumera Priyadarsini
Add enable_writeback feature to vkms_config as a module. Signed-off-by: Sumera Priyadarsini --- drivers/gpu/drm/vkms/vkms_drv.c| 5 + drivers/gpu/drm/vkms/vkms_drv.h| 1 + drivers/gpu/drm/vkms/vkms_output.c | 9 ++--- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git

[PATCH V4 1/3] drm/vkms: Add vkms_config type

2021-01-10 Thread Sumera Priyadarsini
functions. Modify usage of enable_cursor feature to reflect the changes in relevant files. Co-developed-by: Daniel Vetter Signed-off-by: Daniel Vetter Signed-off-by: Sumera Priyadarsini --- drivers/gpu/drm/vkms/vkms_drv.c| 40 -- drivers/gpu/drm/vkms/vkms_drv.h

[PATCH V4 0/3] Decouple config data for configfs

2021-01-10 Thread Sumera Priyadarsini
is developed by Daniel Vetter. Daniel Vetter (1): drm/vkms: Add vkms_config type Sumera Priyadarsini (3): drm/vkms: Add vkms_config type drm/vkms: Add support for writeback module drm/vkms: Add information about module options Documentation/gpu/vkms.rst | 10 +++ drivers/gpu/drm/vkms

[PATCH V3] drm/vkms: Decouple config data for configfs

2021-01-05 Thread Sumera Priyadarsini
functions. Modify usage of enable_cursor feature to reflect the changes in relevant files. Add enable_writeback_connector feature to vkms_config type. Co-developed-by: Daniel Vetter Signed-off-by: Daniel Vetter Signed-off-by: Sumera Priyadarsini --- Changes in v2: - add Co-developed-by tag

[PATCH V2] drm/vkms: Decouple config data for configfs

2021-01-02 Thread Sumera Priyadarsini
track of by vkms_init and vkms_exit functions. Modify usage of enable_cursor feature to reflect the changes in relevant files. Signed-off-by: Sumera Priyadarsini Co-developed-by: Daniel Vetter --- Changes in v2: - add Co-developed-by tag --- drivers/gpu/drm/vkms/vkms_drv.c| 40

[PATCH] drm/vkms: Decouple config data for configfs

2021-01-01 Thread Sumera Priyadarsini
track of by vkms_init and vkms_exit functions. Modify usage of enable_cursor feature to reflect the changes in relevant files. Signed-off-by: Sumera Priyadarsini --- drivers/gpu/drm/vkms/vkms_drv.c| 40 -- drivers/gpu/drm/vkms/vkms_drv.h| 11 +--- drivers

[PATCH v3] drm/vkms: Add setup and testing information

2020-12-09 Thread Sumera Priyadarsini
Update the vkms documentation to contain steps to: - setup the vkms driver - run tests using igt Signed-off-by: Sumera Priyadarsini ___ Changes in v2: - Change heading to title case (Daniel) - Add examples to run tests directly (Daniel) - Add examples to run subtests (Melissa) Changes

Re: [PATCH V2] drm/vkms: Add setup and testing information

2020-12-09 Thread Sumera Priyadarsini
On Wed, Dec 9, 2020 at 6:24 AM Daniel Vetter wrote: > > On Wed, Dec 09, 2020 at 02:07:35AM +0530, Sumera Priyadarsini wrote: > > Update the vkms documentation to contain steps to: > > > > - setup the vkms driver > > - run tests using igt > > &g

[PATCH V2] drm/vkms: Add setup and testing information

2020-12-08 Thread Sumera Priyadarsini
Update the vkms documentation to contain steps to: - setup the vkms driver - run tests using igt Signed-off-by: Sumera Priyadarsini ___ Changes in v2: - Change heading to title case (Daniel) - Add examples to run tests directly (Daniel) - Add examples to run subtests (Melissa

[PATCH] drm/vkms: Add setup and testing information

2020-12-03 Thread Sumera Priyadarsini
Update the vkms documentation to contain steps to: - setup the vkms driver - run tests using igt Signed-off-by: Sumera Priyadarsini --- Documentation/gpu/vkms.rst | 47 ++ 1 file changed, 47 insertions(+) diff --git a/Documentation/gpu/vkms.rst b

[PATCH v2] Documentation: Coccinelle: Improve command example for debugging patches

2020-11-25 Thread Sumera Priyadarsini
Modify Coccinelle documentation to clarify usage of make command to run coccicheck on a folder. Changes in v2: - Give example of folder instead of file - Add note Signed-off-by: Sumera Priyadarsini --- Documentation/dev-tools/coccinelle.rst | 9 - 1 file changed, 8 insertions(+), 1

[PATCH v3] scripts: coccicheck: Correct usage of make coccicheck

2020-11-24 Thread Sumera Priyadarsini
in an error. Modify coccicheck to print correct usage of make coccicheck so as to avoid the error. Signed-off-by: Sumera Priyadarsini --- Changes in v2: - Move test to only display error message Changes in v3: - Update example with latest file --- scripts/coccicheck | 12 1 file ch

[PATCH] Documentation: Coccinelle: Improve command example for debugging patches

2020-11-19 Thread Sumera Priyadarsini
Modify Coccinelle documentation to clarify usage of make command to run coccicheck on a single file. Signed-off-by: Sumera Priyadarsini --- Documentation/dev-tools/coccinelle.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/dev-tools/coccinelle.rst b

[PATCH v2] scripts: coccicheck: Correct usage of make coccicheck

2020-11-18 Thread Sumera Priyadarsini
in an error. Modify coccicheck to print correct usage of make coccicheck so as to avoid the error. Signed-off-by: Sumera Priyadarsini --- Changes in v2: - Move test to only display error message --- scripts/coccicheck | 12 1 file changed, 12 insertions(+) diff --git a/scripts/

[PATCH v2] coccinelle: locks: Add balancedlock.cocci script

2020-11-18 Thread Sumera Priyadarsini
-by: Sumera Priyadarsini --- Changes in v2(as suggested by Markus): - Modify usage of position variable - Modify comments - Add dependencies for rules --- scripts/coccinelle/locks/balancedlock.cocci | 164 1 file changed, 164 insertions(+) create mode 100644 scripts/coccinelle/locks

[PATCH] scripts: coccicheck: Correct usage of make coccicheck

2020-11-11 Thread Sumera Priyadarsini
in an error. Modify coccicheck to print correct usage of make coccicheck so as to avoid the error. Signed-off-by: Sumera Priyadarsini --- scripts/coccicheck | 12 1 file changed, 12 insertions(+) diff --git a/scripts/coccicheck b/scripts/coccicheck index 209bb0427b43..b990c8a60a94

[PATCH] coccinelle: locks: Add balancedlock.cocci script

2020-11-06 Thread Sumera Priyadarsini
-by: Sumera Priyadarsini --- scripts/coccinelle/locks/balancedlock.cocci | 162 1 file changed, 162 insertions(+) create mode 100644 scripts/coccinelle/locks/balancedlock.cocci diff --git a/scripts/coccinelle/locks/balancedlock.cocci b/scripts/coccinelle/locks/balancedlock.cocci

[Outreachy][PATCH] drm/amdgpu: use true and false for bool initialisations

2020-10-26 Thread Sumera Priyadarsini
Bool initialisation should use 'true' and 'false' values instead of 0 and 1. Modify amdgpu_amdkfd_gpuvm.c to initialise variable is_imported to false instead of 0. Issue found with Coccinelle. Signed-off-by: Sumera Priyadarsini --- drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gpuvm.c | 2 +- 1

[PATCH 5/5] gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()

2020-10-22 Thread Sumera Priyadarsini
. Signed-off-by: Sumera Priyadarsini --- drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index e5ea14774c0c..6d9901e1b4b0 100644 --- a/drivers/gpu/drm

[PATCH 4/5] gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()

2020-10-22 Thread Sumera Priyadarsini
. Signed-off-by: Sumera Priyadarsini --- drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c index d6c38e24f130..4d1d1e1b005d 100644 --- a/drivers/gpu/drm/amd

[PATCH 2/5] gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()

2020-10-22 Thread Sumera Priyadarsini
with Coccinelle. Signed-off-by: Sumera Priyadarsini --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c index f7307af76452..7eef6b20578f 100644

[PATCH 1/5] gpu: drm: amdgpu: Replace snprintf() with sysfs_emit()

2020-10-22 Thread Sumera Priyadarsini
with Coccinelle. Signed-off-by: Sumera Priyadarsini --- drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_atombios.c index 469352e2d6ec..3c19862c94c7 100644

[Outreachy kernel][PATCH 0/5] drm/amdgpu: Replace snprintf() with sysfs_emit

2020-10-22 Thread Sumera Priyadarsini
in the relevant files. Sumera Priyadarsini (5): gpu: drm: amdgpu: Replace snprintf() with sysfs_emit() gpu: drm: amdgpu: Replace snprintf() with sysfs_emit() gpu: drm: amdgpu: Replace snprintf() with sysfs_emit() gpu: drm: amdgpu: Replace snprintf() with sysfs_emit() gpu: drm: amdgpu: Replace

[Outreachy kernel][PATCH] gpu: amd: Return boolean types instead of integer values

2020-10-21 Thread Sumera Priyadarsini
Return statements for functions returning bool should use truth and false instead of 1 and 0 respectively. Modify cik_event_interrupt.c to return false instead of 0. Issue found with Coccinelle. Signed-off-by: Sumera Priyadarsini --- drivers/gpu/drm/amd/amdkfd/cik_event_interrupt.c | 4

[PATCH V3] [Cocci] coccinelle: iterators: Add for_each_child.cocci script

2020-10-15 Thread Sumera Priyadarsini
leaks caused by the absence of of_node_put() before break, goto, or, return statements which transfer control outside the loop. Signed-off-by: Sumera Priyadarsini Changes in V2: - Add options --include-headers and --no-includes - Add 'when forall` to rules for break and goto Changes in V3

[PATCH V2] [Cocci] coccinelle: iterators: Add for_each_child.cocci script

2020-10-12 Thread Sumera Priyadarsini
leaks caused by the absence of of_node_put() before break, goto, or, return statements which transfer control outside the loop. Signed-off-by: Sumera Priyadarsini Changes in V2: - Add options --include-headers and --no-includes - Add 'when forall` to rules for break and goto

[PATCH v4 3/3] Documentation: Coccinelle: Modify Parallelisation information in docs

2020-10-11 Thread Sumera Priyadarsini
This patchset modifies coccicheck to use at most one thread per core by default in machines with more than 4 hyperthreads for optimal performance. Modify documentation in coccinelle.rst to reflect the same. Signed-off-by: Sumera Priyadarsini --- Documentation/dev-tools/coccinelle.rst | 6

[PATCH v4 2/3] scripts: coccicheck: Change default condition for parallelism

2020-10-11 Thread Sumera Priyadarsini
-by: Sumera Priyadarsini --- scripts/coccicheck | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/coccicheck b/scripts/coccicheck index d67907b8a38b..209bb0427b43 100755 --- a/scripts/coccicheck +++ b/scripts/coccicheck @@ -79,7 +79,7 @@ else THREADS_PER_CORE=$(lscpu | grep

[PATCH v4 1/3] scripts: coccicheck: Add quotes to improve portability

2020-10-11 Thread Sumera Priyadarsini
use double quotes around the [:digit:] set for uniformity and better portability. Signed-off-by: Sumera Priyadarsini --- scripts/coccicheck | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/coccicheck b/scripts/coccicheck index 6789751607f5..d67907b8a38b 100755 ---

[PATCH v4 0/3] Improve Coccinelle Parallelisation

2020-10-11 Thread Sumera Priyadarsini
the same. Sumera Priyadarsini (3): scripts: coccicheck: Add quotes to improve portability scripts: coccicheck: Change default condition for parallelism Documentation: Coccinelle: Modify Parallelisation information in docs Documentation/dev-tools/coccinelle.rst | 6 -- scripts/coccicheck

[PATCH 2/2 V3] Documentation: Coccinelle: Modify parallelisation information in docs

2020-10-07 Thread Sumera Priyadarsini
This patchset modifies coccicheck to use at most one thread per core by default in machines with more than 4 hyperthreads for optimal performance. Modify documentation in coccinelle.rst to reflect the same. Signed-off-by: Sumera Priyadarsini --- Changes in V2: Update scripts/coccicheck

[PATCH 1/2 V3] scripts: coccicheck: Change default value for parallelism

2020-10-07 Thread Sumera Priyadarsini
. Signed-off-by: Sumera Priyadarsini --- Changes in V2: - Change commit message as suggested by Julia Lawall Changes in V3: - Use J/2 as optimal value for machines with more than 8 hyperthreads as well. Changes in V4: - Use J as optimal value for machines with less

[PATCH 0/2 V3] Improve Coccinelle Parallelisation

2020-10-07 Thread Sumera Priyadarsini
Coccinelle utilises all available threads to implement parallelisation. However, this results in a decrease in performance. This patchset aims to improve performance by modifying cocciccheck to use at most one thread per core by default in machines with more than 4 hyperthreads. Sumera

[PATCH 2/2 V2] Documentation: Coccinelle: Modify parallelisation information in docs

2020-10-06 Thread Sumera Priyadarsini
This patchset modifies coccicheck to use at most one thread per core by default for optimal performance. Modify documentation in coccinelle.rst to reflect the same. Signed-off-by: Sumera Priyadarsini --- Documentation/dev-tools/coccinelle.rst | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 1/2 V2] scripts: coccicheck: Change default value for parallelism

2020-10-06 Thread Sumera Priyadarsini
. The optimal J value does not exceed 6 in any of the test runs. The benchmarks are run on a machine with 6 cores, with 2 threads per core, i.e, 12 hyperthreads in all. To improve performance, modify coccicheck to use at most only one thread per core by default. Signed-off-by: Sumera Priyadarsini

[PATCH 0/2 v2] Improve Coccinelle Parallelisation

2020-10-06 Thread Sumera Priyadarsini
Coccinelle utilises all available threads to implement parallelisation. However, this results in a decrease in performance. This patchset aims to improve performance by modifying cocciccheck to use at most one thread per core by default. Sumera Priyadarsini (2): scripts: coccicheck: Change

[PATCH] scripts: coccicheck: Refactor display messages on coccinelle start up

2020-10-03 Thread Sumera Priyadarsini
Currently, coccinelle starts by printing "When using "patch" mode, carefully review the patch before submitting it." Modify coccicheck to print this message only when the user has explicitly selected "patch" or "chain" mode. Signed-off-by: Sume

[PATCH 2/2] Documentation: Coccinelle: Modify parallelisation information in docs

2020-09-24 Thread Sumera Priyadarsini
This patchset modifies coccicheck to use at most one thread per core by default for optimal performance. Modify documentation in coccinelle.rst to reflect the same. Signed-off-by: Sumera Priyadarsini --- Documentation/dev-tools/coccinelle.rst | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 1/2] scripts: coccicheck: Change default value for parallelism

2020-09-24 Thread Sumera Priyadarsini
. The optimal J value does not exceed 6 in any of the test runs. The benchmarks are run on a machine with 6 cores, with 2 threads per core, i.e, 12 hyperthreads in all. To improve performance, modify coccicheck to use at most only one thread per core by default. Signed-off-by: Sumera Priyadarsini

[PATCH 0/2] Improve Coccinelle Parallelisation

2020-09-24 Thread Sumera Priyadarsini
Coccinelle utilises all available threads to implement parallelisation. However, this results in a decrease in performance. This patchset aims to improve performance by modifying cocciccheck to use at most one thread per core by default. Sumera Priyadarsini (2): scripts: coccicheck: Change

[PATCH] [Cocci] coccinelle: iterators: Add for_each_child.cocci script

2020-09-24 Thread Sumera Priyadarsini
leaks caused by the absence of of_node_put() before break, goto, or, return statements which transfer control outside the loop. Signed-off-by: Sumera Priyadarsini --- .../coccinelle/iterators/for_each_child.cocci | 348 ++ 1 file changed, 348 insertions(+) create mode 100644

[RFC PATCH] scripts: coccicheck: Improve error feedback when coccicheck fails

2020-09-13 Thread Sumera Priyadarsini
which case, the error logs are stored in the specified debug file. Signed-off-by: Sumera Priyadarsini --- scripts/coccicheck | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/scripts/coccicheck b/scripts/coccicheck index e04d328210ac..dbeafa21f359 100755 --- a/scripts/coccic

[PATCH V3] scripts: coccicheck: Do not use shift command when rule is specified

2020-09-09 Thread Sumera Priyadarsini
in an error. Modify coccicheck to use the shift command only when number of shell arguments is not zero. Signed-off-by: Sumera Priyadarsini --- Changes in V2: - Fix spelling errors as suggested by Markus Elfring --- scripts/coccicheck | 16 +--- 1 file changed, 13 insert

[PATCH V2] scripts: coccicheck: Do not use shift command when rule is specfified

2020-09-09 Thread Sumera Priyadarsini
in an error. Modify coccicheck to use the shift command only when number of shell arguments is not zero. Signed-off-by: Sumera Priyadarsini --- Changes in V2: - Fix spelling errors as suggested by Markus Elfring --- scripts/coccicheck | 16 +--- 1 file changed, 13 insert

Re: [PATCH] scripts: coccicheck: Do not use shift command when rule is specified

2020-09-09 Thread Sumera Priyadarsini
On Wed, Sep 09, 2020 at 08:52:19AM +0200, Markus Elfring wrote: > I find it helpful to avoid typos (like the following) in the change > description. > > > > … Makfeile. … > > … Makefile. … > > > > … paasing … > > … passing … > > > > …, resuting … > > …, resulting … > > > > This patch

[PATCH] scripts: coccicheck: Do not use shift command when rule is specfified

2020-09-07 Thread Sumera Priyadarsini
n error. This patch modifies coccicheck to use the shift command only when number of shell arguments is not zero. Signed-off-by: Sumera Priyadarsini --- scripts/coccicheck | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/scripts/coccicheck b/scripts/coccichec

[PATCH] bus: arm: Add of_node_put() before break statement

2020-08-30 Thread Sumera Priyadarsini
a potential memory leak in arm-cci.c by inserting of_node_put() before a break statement. Issue found with Coccinelle. Signed-off-by: Sumera Priyadarsini --- drivers/bus/arm-cci.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bus/arm-cci.c b/drivers/bus/arm-cci.c index

[PATCH] clk: versatile: Add of_node_put() before return statement

2020-08-29 Thread Sumera Priyadarsini
a potential memory leak in clk-impd1.c by inserting of_node_put() before a return statement. Issue found with Coccinelle. Signed-off-by: Sumera Priyadarsini --- drivers/clk/versatile/clk-impd1.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/clk/versatile/clk-impd1.c b

[PATCH] bus: qcom-ebi2: Add of_node_put() before return statement

2020-08-29 Thread Sumera Priyadarsini
a potential memory leak in qcom-ebi2.c by inserting of_node_put() before a return statement. Issue found with Coccinelle. Signed-off-by: Sumera Priyadarsini --- drivers/bus/qcom-ebi2.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/bus/qcom-ebi2.c b/drivers/bus/qcom-ebi2.c

[PATCH] bus: arm-integrator-lm: Add of_node_put() before return statement

2020-08-29 Thread Sumera Priyadarsini
a potential memory leak in arm-integrator-lm.c by inserting of_node_put() before a return statement. Issue found with Coccinelle. Signed-off-by: Sumera Priyadarsini --- drivers/bus/arm-integrator-lm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/bus/arm-integrator-lm.c b/drivers/bus/arm

[PATCH V4] net: dsa: mt7530: Add of_node_put() before break and return statements

2020-08-24 Thread Sumera Priyadarsini
leak in mt7530.c by inserting of_node_put() before the break and return statements. Issue found with Coccinelle. Signed-off-by: Sumera Priyadarsini --- Changes in v2: Add another of_node_put() in for_each_child_of_node() as pointed out by Andrew. Changes in v3: - Correct syntax

[PATCH V3] net: dsa: Add of_node_put() before break and return statements

2020-08-23 Thread Sumera Priyadarsini
--- Signed-off-by: Sumera Priyadarsini Signed-off-by: Sumera Priyadarsini --- drivers/net/dsa/mt7530.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 8dcb8a49ab67..4b4701c69fe1 100644 --- a/drivers/net/dsa

[PATCH V2] net: dsa: Add of_node_put() before break statement

2020-08-23 Thread Sumera Priyadarsini
leak in mt7530.c by inserting of_node_put() before the break statement. Issue found with Coccinelle. --- Changes in v2: Add another of_node_put() in for_each_child_of_node() as pointed out by Andrew. --- Signed-off-by: Sumera Priyadarsini --- drivers/net/dsa/mt7530.c | 2 ++ 1 file

[PATCH] net: dsa: Add of_node_put() before break statement

2020-08-23 Thread Sumera Priyadarsini
leak in mt7530.c by inserting of_node_put() before the break statement. Issue found with Coccinelle. Signed-off-by: Sumera Priyadarsini --- drivers/net/dsa/mt7530.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c index 8dcb8a49ab67

[PATCH] net: ocelot: Add of_node_put() before return statement

2020-08-23 Thread Sumera Priyadarsini
a potential memory leak in felix.c by inserting of_node_put() before the return statement. Issue found with Coccinelle. Signed-off-by: Sumera Priyadarsini --- drivers/net/dsa/ocelot/felix.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/dsa/ocelot/felix.c b/drivers/net/dsa/ocelot/felix.c

[PATCH V3] scripts: coccicheck: Change default value for parallelism

2020-08-18 Thread Sumera Priyadarsini
. The optimal J value does not exceed 6 in any of the test runs. The benchmarks are run on a machine with 6 cores, with 2 threads per core, i.e, 12 hyperthreads in all. To improve performance, modify coccicheck to use at most only one thread per core by default. Signed-off-by: Sumera Priyadarsini

[PATCH] net: gianfar: Add of_node_put() before goto statement

2020-08-18 Thread Sumera Priyadarsini
memory leak in gianfar.c by inserting of_node_put() before the goto statement. Issue found with Coccinelle. Signed-off-by: Sumera Priyadarsini --- drivers/net/ethernet/freescale/gianfar.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale

[PATCH V2] scripts: coccicheck: Change default value for parallelism

2020-08-14 Thread Sumera Priyadarsini
. The optimal J value does not exceed 6 in any of the test runs. The benchmarks are run on a machine with 6 cores, with 2 threads per core, i.e, 12 hyperthreads in all. To improve performance, modify coccicheck to use at most only one thread per core by default. Signed-off-by: Sumera Priyadarsini

[PATCH] scripts: coccicheck: Change default value for parallelism

2020-08-12 Thread Sumera Priyadarsini
-by: Sumera Priyadarsini --- scripts/coccicheck | 9 + 1 file changed, 9 insertions(+) diff --git a/scripts/coccicheck b/scripts/coccicheck index e04d328210ac..dd228dcc915e 100755 --- a/scripts/coccicheck +++ b/scripts/coccicheck @@ -75,8 +75,17 @@ else OPTIONS="--dir $KBUILD_E

[PATCH v4] documentation: coccinelle: Improve command example for make C={1,2}

2020-08-10 Thread Sumera Priyadarsini
Modify coccinelle documentation to further clarify the usage of the makefile C variable by coccicheck. Signed-off-by: Sumera Priyadarsini --- Changes in v4: - Modify commit message to clarify C is a variable --- Documentation/dev-tools/coccinelle.rst | 15 +++ 1 file

[PATCH v3] documentation: coccinelle: Improve command example for make C={1,2}

2020-08-10 Thread Sumera Priyadarsini
Modify coccinelle documentation to further clarify the usage of the makefile C variable flag by coccicheck. Signed-off-by: Sumera Priyadarsini --- Changes in v3: - Remove quotes as suggested by Markus Elfring - Change in wording, and punctuation, as suggested by Julia Lawall

[PATCH v2] scripts: coccicheck: Add chain mode to list of modes

2020-08-05 Thread Sumera Priyadarsini
This patch adds chain mode to the list of available modes in coccicheck. Signed-off-by: Sumera Priyadarsini --- Changes in v2: - Change coccinelle to coccicheck as suggested by Julia Lawall. --- scripts/coccicheck | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] scripts: coccicheck: Add chain mode to list of modes

2020-08-03 Thread Sumera Priyadarsini
This patch adds chain mode to the list of available modes in coccinelle. Signed-off-by: Sumera Priyadarsini --- scripts/coccicheck | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/coccicheck b/scripts/coccicheck index e04d328210ac..6e37cf36caae 100755 --- a/scripts