Re: [RFC][PATCH 2/2] dma-buf: heaps: Fix the name used when exporting dmabufs to be the actual heap name

2021-02-08 Thread Sumit Semwal
ion with tooling, and there is > > > > the future potential where multiple heap types may be exported > > > > by the same module (but would all have the same name). > > > > > > > > So to avoid all this, set the exporter exp_name to the heap name. &g

Re: [Linaro-mm-sig] [PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-01-28 Thread Sumit Semwal
Hi Simon, On Thu, 28 Jan 2021 at 20:01, Simon Ser wrote: > > On Thursday, January 28th, 2021 at 1:03 PM, Sumit Semwal > wrote: > > > Since he didn't comment over Hridya's last clarification about the > > tracepoints to track total GPU memory allocations being orthogon

Re: [Linaro-mm-sig] [PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-01-28 Thread Sumit Semwal
On Thu, 28 Jan 2021 at 17:23, Christian König wrote: > > Am 28.01.21 um 12:00 schrieb Sumit Semwal: > > Hi Hridya, > > > > On Wed, 27 Jan 2021 at 17:36, Greg KH wrote: > >> On Tue, Jan 26, 2021 at 12:42:36PM -0800, Hridya Valsaraju wrote: > >>> This p

Re: [PATCH v3] dmabuf: Add the capability to expose DMA-BUF stats in sysfs

2021-01-28 Thread Sumit Semwal
Hi Hridya, On Wed, 27 Jan 2021 at 17:36, Greg KH wrote: > > On Tue, Jan 26, 2021 at 12:42:36PM -0800, Hridya Valsaraju wrote: > > This patch allows statistics to be enabled for each DMA-BUF in > > sysfs by enabling the config CONFIG_DMABUF_SYSFS_STATS. > > > > The following stats will be exposed

Re: [RESEND][PATCH 2/3] dma-buf: heaps: Add a WARN_ON should the vmap_cnt go negative

2021-01-21 Thread Sumit Semwal
map count more than vmap count. Is there a specific need for this in the heaps? Best, Sumit. > > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Laura Abbott > Cc: Brian Starkey > Cc: Hridya Valsaraju > Cc: Suren Baghdasaryan > Cc: Sandeep Patil > Cc: Daniel Mentz >

Re: [RESEND][PATCH 1/3] dma-buf: system_heap: Make sure to return an error if we abort

2021-01-21 Thread Sumit Semwal
nto drm-misc-next. > > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Laura Abbott > Cc: Brian Starkey > Cc: Hridya Valsaraju > Cc: Suren Baghdasaryan > Cc: Sandeep Patil > Cc: Daniel Mentz > Cc: Chris Goldsworthy > Cc: Ørjan Eide > Cc: Robin Murphy > Cc:

Re: [RESEND][PATCH 3/3] dma-buf: heaps: Rework heep allocation hooks to return struct dma_buf instead of fd

2021-01-21 Thread Sumit Semwal
handle creating the fd via > dma_buf_fd(). Thanks for the patch! LGTM, feels a lot neater now. I'll merge into drm-misc-next. > > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Laura Abbott > Cc: Brian Starkey > Cc: Hridya Valsaraju > Cc: Suren Baghdasaryan > Cc: Sand

Re: [PATCH] dma-buf: cma_heap: Fix memory leak in CMA heap

2021-01-08 Thread Sumit Semwal
ures the pagelist is also freed on release. Thanks for your patch. > > Cc: Bing Song > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Laura Abbott > Cc: Brian Starkey > Cc: Hridya Valsaraju > Cc: Suren Baghdasaryan > Cc: Sandeep Patil > Cc: Daniel Mentz > Cc: Chr

Re: [Linaro-mm-sig] [PATCH] dmabuf: fix use-after-free of dmabuf's file->f_inode

2021-01-04 Thread Sumit Semwal
Hi Charan, On Mon, 4 Jan 2021 at 17:22, Christian König wrote: > > Am 04.01.21 um 12:36 schrieb Charan Teja Reddy: > > It is observed 'use-after-free' on the dmabuf's file->f_inode with the > > race between closing the dmabuf file and reading the dmabuf's debug > > info. > > > > Consider the

Re: [PATCH] dma-buf: cma_heap: Include linux/vmalloc.h to fix build failures on MIPS

2020-12-16 Thread Sumit Semwal
'cma_heap_do_vmap': > drivers/dma-buf/heaps/cma_heap.c:195:10: error: implicit declaration of > function 'vmap' Thanks for the patch; I've merged it to drm-misc-next-fixes. > > Cc: Sumit Semwal > Cc: Liam Mark > Cc: Laura Abbott > Cc: Brian Starkey > Cc: Hridya

Re: [PATCH v5 0/7] dma-buf: Performance improvements for system heap & a system-uncached implementation

2020-11-19 Thread Sumit Semwal
u, Nov 12, 2020 at 1:32 AM Daniel Vetter wrote: > > > > > On Thu, Nov 12, 2020 at 11:09:04AM +0530, Sumit Semwal wrote: > > > > > > On Tue, 10 Nov 2020 at 09:19, John Stultz > > > > > > wrote: > > > > > > > > > > > &

Re: [PATCH v5 0/7] dma-buf: Performance improvements for system heap & a system-uncached implementation

2020-11-11 Thread Sumit Semwal
> uncached heap allocations do result in *much* improved > performance on HiKey960 as it avoids a lot of flushing and > invalidating buffers that the cpu doesn't touch often. > > Feedback on these would be great! > > thanks > -john > > New in v5: > * Added a comment

Re: [PATCH v7 1/2] dt-bindings: display: panel: Add bindings for Novatek nt36672a

2020-10-14 Thread Sumit Semwal
Hi Sam, On Thu, 15 Oct 2020 at 00:14, Sam Ravnborg wrote: > > Hi Sumit. > On Wed, Sep 02, 2020 at 12:14:06PM +0530, Sumit Semwal wrote: > > Novatek nt36672a is a display driver IC that can drive DSI panel. It > > is also present in the Tianma video mode panel,

Re: [PATCH -next] dma-buf: heaps: Remove unused variable ret

2020-09-22 Thread Sumit Semwal
eturn "0" on line 215 > > > > Signed-off-by: Zou Wei > > Acked-by: Christian König > > Going to pick this up for drm-misc-next. Thanks Christian! Fwiw, feel free to add my Acked-by: Sumit Semwal > > > --- > > drivers/dma-buf/heaps/heap-helpers.c

Re: [PATCH v7 0/2]dd support for Tianma nt36672a video mode panel

2020-09-22 Thread Sumit Semwal
Hi Sam / Theirry, On Wed, 2 Sep 2020 at 12:14, Sumit Semwal wrote: > > Some Poco F1 phones from Xiaomi have a FHD+ video mode panel based on the > Novatek NT36672A display controller; Add support for the same. This latest version (v7) had all the outstanding comments fixed, and Bjorn

Re: [PATCH 08/29] dma-buf: Avoid comma separated statements

2020-09-03 Thread Sumit Semwal
Hello Joe, On Wed, 26 Aug 2020 at 20:38, Christian König wrote: > > Am 25.08.20 um 06:56 schrieb Joe Perches: > > Use semicolons and braces. > > > > Signed-off-by: Joe Perches > > Acked-by: Christian König FWIW, Acked-by: Sumit Semwal > > > --- &

[PATCH v7 2/2] drm: panel: Add novatek nt36672a panel driver

2020-09-02 Thread Sumit Semwal
Steini helped us fix the reset sequence timing (from 10ms to 20ms), to get the bootanimation to work on Android. With current AOSP, we need to increase it to 200ms - this seems to be a safe high value to avoid a white screen occasionally. Signed-off-by: Sumit Semwal Cc: Benni Steini --- v2

[PATCH v7 1/2] dt-bindings: display: panel: Add bindings for Novatek nt36672a

2020-09-02 Thread Sumit Semwal
added for this tianma fhd video mode panel. Signed-off-by: Sumit Semwal Reviewed-by: Rob Herring --- v2: remove ports node, making port@0 directly under panel@0 node. v3: updated to replace port@0 to just 'port'. v5: renamed to novatek,nt36672a, since the binding is for the IC

[PATCH v7 0/2]dd support for Tianma nt36672a video mode panel

2020-09-02 Thread Sumit Semwal
less generic - updated the reset_gpio working to active_low - update MAINTAINERS for file name changes Sumit Semwal (2): dt-bindings: display: panel: Add bindings for Novatek nt36672a drm: panel: Add novatek nt36672a panel driver .../display/panel/novatek,nt36672a.yaml | 87 +++

[PATCH v7 2/3] mm: memory: Add access_remote_vm_locked variant

2020-09-01 Thread Sumit Semwal
was required. Signed-off-by: Sumit Semwal --- include/linux/mm.h | 2 ++ mm/memory.c| 49 -- 2 files changed, 45 insertions(+), 6 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index ca6e6a81576b..e9212c0bb5ac 100644 --- a/include

[PATCH v7 0/3] Anonymous VMA naming patches

2020-09-01 Thread Sumit Semwal
anonymous memory Sumit Semwal (1): mm: memory: Add access_remote_vm_locked variant Documentation/filesystems/proc.rst | 2 + fs/proc/task_mmu.c | 24 +- fs/userfaultfd.c | 7 +- include/linux/mm.h | 14 +- include/linux/mm_types.h | 25

[PATCH v6 0/3] Anonymous VMA naming patches

2020-09-01 Thread Sumit Semwal
, Sumit. Colin Cross (2): mm: rearrange madvise code to allow for reuse mm: add a field to store names for private anonymous memory Sumit Semwal (1): mm: memory: Add access_remote_vm_locked variant Documentation/filesystems/proc.rst | 2 + fs/proc/task_mmu.c | 24 +- fs

[PATCH v6 2/3] mm: memory: Add access_remote_vm_locked variant

2020-09-01 Thread Sumit Semwal
was required. Signed-off-by: Sumit Semwal --- include/linux/mm.h | 2 ++ mm/memory.c| 49 -- 2 files changed, 45 insertions(+), 6 deletions(-) diff --git a/include/linux/mm.h b/include/linux/mm.h index ca6e6a81576b..e9212c0bb5ac 100644 --- a/include

Re: [PATCH v5 2/2] drm: panel: Add novatek nt36672a panel driver

2020-08-31 Thread Sumit Semwal
Hi Sam, On Sun, 30 Aug 2020 at 03:01, Sam Ravnborg wrote: > > Hi Sumit. > > On Wed, Aug 26, 2020 at 09:33:08PM +0530, Sumit Semwal wrote: > > Novatek NT36672a is a generic DSI IC that drives command and video mode > > panels. Add the driver for it. > > > > Ri

[PATCH v6 1/2] dt-bindings: display: panel: Add bindings for Novatek nt36672a

2020-08-31 Thread Sumit Semwal
added for this tianma fhd video mode panel. Signed-off-by: Sumit Semwal Reviewed-by: Rob Herring --- v2: remove ports node, making port@0 directly under panel@0 node. v3: updated to replace port@0 to just 'port'. v5: renamed to novatek,nt36672a, since the binding is for the IC

[PATCH v6 2/2] drm: panel: Add novatek nt36672a panel driver

2020-08-31 Thread Sumit Semwal
Steini helped us fix the reset sequence timing (from 10ms to 20ms), to get the bootanimation to work on Android. With current AOSP, we need to increase it to 200ms - this seems to be a safe high value to avoid a white screen occasionally. Signed-off-by: Sumit Semwal Cc: Benni Steini --- v2

[PATCH v6 0/2] Add support for Tianma nt36672a video mode panel

2020-08-31 Thread Sumit Semwal
rror printing to dev_err() - removed a few unnecessary bits Sumit Semwal (2): dt-bindings: display: panel: Add bindings for Novatek nt36672a drm: panel: Add novatek nt36672a panel driver .../display/panel/novatek,nt36672a.yaml | 87 ++ MAINTAINERS

[PATCH v5 1/2] dt-bindings: display: panel: Add bindings for Novatek nt36672a

2020-08-26 Thread Sumit Semwal
added for this tianma fhd video mode panel. Signed-off-by: Sumit Semwal Reviewed-by: Rob Herring --- v2: remove ports node, making port@0 directly under panel@0 node. v3: updated to replace port@0 to just 'port'. v5: renamed to novatek,nt36672a, since the binding is for the IC

[PATCH v5 2/2] drm: panel: Add novatek nt36672a panel driver

2020-08-26 Thread Sumit Semwal
Steini helped us fix the reset sequence timing (from 10ms to 20ms), to get the bootanimation to work on Android. With current AOSP, we need to increase it to 200ms - this seems to be a safe high value to avoid a white screen occasionally. Signed-off-by: Sumit Semwal Cc: Benni Steini --- v2

[PATCH v5 0/2] Add support for Tianma nt36672a video mode panel

2020-08-26 Thread Sumit Semwal
ted changelog to add info about the generic Novatek DSI IC - corrected compatible string accordingly - removed pinctrl - used drm_panel* API for prepare/unprepare/disable/remove Sumit Semwal (2): dt-bindings: display: panel: Add bindings for Novatek nt36672a drm: panel: Add nov

Re: [RESEND PATCH 1/2] dma-buf: Fix kerneldoc of dma_buf_set_name()

2020-08-19 Thread Sumit Semwal
Hello Krzystof, On Wed, 19 Aug 2020 at 23:21, Krzysztof Kozlowski wrote: > > Fix W=1 compile warnings (invalid kerneldoc): > > drivers/dma-buf/dma-buf.c:328: warning: Function parameter or member > 'dmabuf' not described in 'dma_buf_set_name' Thanks for the patch; I will apply it to

[PATCH v5 0/2] Anonymous VMA naming patches

2020-08-19 Thread Sumit Semwal
Last version v4 of these patches was sent by Colin Cross a long time ago [1] and [2]. At the time, these patches were not merged, and it looks like they just fell off the radar since. In our efforts to run Android on mainline kernels, we realised that since past some time, this patchset is needed

Re: [PATCH v4 2/2] drm: panel: Add tianma nt36672a panel driver

2020-08-14 Thread Sumit Semwal
Hello Sam, Thanks very much for the review. On Fri, 14 Aug 2020 at 01:16, Sam Ravnborg wrote: > > Hi Sumit. > > On Tue, Aug 11, 2020 at 11:51:07PM +0530, Sumit Semwal wrote: > > Some Poco F1 phones have an LCD panel from Tianma, model nt36672a, > > with a resolution of

[PATCH v4 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

2020-08-11 Thread Sumit Semwal
The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 and 6.18 inches size. It is found in some of the Poco F1 phones. Signed-off-by: Sumit Semwal Reviewed-by: Rob Herring --- v2: remove ports node, making port@0 directly under panel@0 node. v3: updated to replace port

[PATCH v4 2/2] drm: panel: Add tianma nt36672a panel driver

2020-08-11 Thread Sumit Semwal
on Android. With current AOSP, we need to increase it to 200ms - this seems to be a safe high value to avoid a white screen occasionally. Signed-off-by: Sumit Semwal Cc: Benni Steini --- v2: increase reset sequence timing to a safe 200ms v4: Since "0425662fdf05: drm: Nuke mode->vrefresh&q

[PATCH v4 0/2] Add support for Tianma nt36672a video mode panel

2020-08-11 Thread Sumit Semwal
with just port in panel@0 node. v4: Since "0425662fdf05: drm: Nuke mode->vrefresh", we have to calculate vrefresh on demand. Update for it. Sumit Semwal (2): dt-bindings: display: panel: Add bindings for Tianma nt36672a panel drm: panel: Add tianma nt36672a panel driver .../

[RESEND PATCH v3 0/2] Add support for Tianma nt36672a video mode panel

2020-08-11 Thread Sumit Semwal
with just port in panel@0 node. [1]: Sumit Semwal (2): dt-bindings: display: panel: Add bindings for Tianma nt36672a panel drm: panel: Add tianma nt36672a panel driver .../display/panel/tianma,nt36672a.yaml| 95 ++ MAINTAINERS | 7 + drivers/gpu/drm

[RESEND PATCH v3 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

2020-08-11 Thread Sumit Semwal
The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 and 6.18 inches size. It is found in some of the Poco F1 phones. Signed-off-by: Sumit Semwal Reviewed-by: Rob Herring --- v2: remove ports node, making port@0 directly under panel@0 node. v3: updated to replace port@0

[RESEND PATCH v3 2/2] drm: panel: Add tianma nt36672a panel driver

2020-08-11 Thread Sumit Semwal
on Android. With current AOSP, we need to increase it to 200ms - this seems to be a safe high value to avoid a white screen occasionally. Signed-off-by: Sumit Semwal Cc: Benni Steini --- v2: increase reset sequence timing to a safe 200ms --- MAINTAINERS | 7

[PATCH v3 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

2020-07-27 Thread Sumit Semwal
The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 and 6.18 inches size. It is found in some of the Poco F1 phones. Signed-off-by: Sumit Semwal --- v2: remove ports node, making port@0 directly under panel@0 node. v3: updated to replace port@0 to just 'port

[PATCH v3 0/2] Add support for Tianma nt36672a video mode panel

2020-07-27 Thread Sumit Semwal
with just port in panel@0 node. [1]: Sumit Semwal (2): dt-bindings: display: panel: Add bindings for Tianma nt36672a panel drm: panel: Add tianma nt36672a panel driver .../display/panel/tianma,nt36672a.yaml| 95 ++ MAINTAINERS | 7 + drivers/gpu/drm

[PATCH v3 2/2] drm: panel: Add tianma nt36672a panel driver

2020-07-27 Thread Sumit Semwal
on Android. With current AOSP, we need to increase it to 200ms - this seems to be a safe high value to avoid a white screen occasionally. Signed-off-by: Sumit Semwal Cc: Benni Steini --- v2: increase reset sequence timing to a safe 200ms --- MAINTAINERS | 7

Re: [PATCH v2 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

2020-07-23 Thread Sumit Semwal
Hi Rob, Thanks for the review! On Thu, 23 Jul 2020 at 23:25, Rob Herring wrote: > > On Wed, Jul 22, 2020 at 11:28:15AM +0530, Sumit Semwal wrote: > > The nt36672a panel from Tianma is a FHD+ panel with a resolution of > > 1080x2246 > > and 6.18 inches size. It is foun

[PATCH v2 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

2020-07-21 Thread Sumit Semwal
The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 and 6.18 inches size. It is found in some of the Poco F1 phones. Signed-off-by: Sumit Semwal Change-Id: I401dfbfe23ff2d806c956002f45e349cb9688c16 --- v2: remove ports node, making port@0 directly under panel@0 node

[PATCH v2 2/2] drm: panel: Add tianma nt36672a panel driver

2020-07-21 Thread Sumit Semwal
on Android. With current AOSP, we need to increase it to 200ms - this seems to be a safe high value to avoid a white screen occassionally. Signed-off-by: Sumit Semwal Cc: Benni Steini Change-Id: Ib822ef12464abcb50d2e539d11b8983be87c31f2 --- v2: increase reset sequence timing to a safe 200ms

[PATCH v2 0/2] Add support for Tianma nt36672a video mode panel

2020-07-21 Thread Sumit Semwal
is here [1] --- v2: In dt-binding, removed ports node, making port@0 directly under panel@0 node. Also updated the panel_on delay to a safer 200ms as needed for latest Android. Sumit Semwal (2): dt-bindings: display: panel: Add bindings for Tianma nt36672a panel drm: panel: Add tianma

Re: [PATCH 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

2020-07-21 Thread Sumit Semwal
Hello Rob, Thanks for the review! On Tue, 21 Jul 2020 at 09:03, Rob Herring wrote: > > On Thu, Jul 16, 2020 at 09:08:57PM +0530, Sumit Semwal wrote: > > The nt36672a panel from Tianma is a FHD+ panel with a resolution of > > 1080x2246 > > and 6.18 inches size. It is foun

[PATCH 2/2] drm: panel: Add tianma nt36672a panel driver

2020-07-16 Thread Sumit Semwal
on Android. Cc: Benni Steini Signed-off-by: Sumit Semwal --- MAINTAINERS | 7 + drivers/gpu/drm/panel/Kconfig | 11 + drivers/gpu/drm/panel/Makefile| 1 + drivers/gpu/drm/panel/panel-tianma-nt36672a.c | 859 ++ 4

[PATCH 1/2] dt-bindings: display: panel: Add bindings for Tianma nt36672a panel

2020-07-16 Thread Sumit Semwal
The nt36672a panel from Tianma is a FHD+ panel with a resolution of 1080x2246 and 6.18 inches size. It is found in some of the Poco F1 phones. Signed-off-by: Sumit Semwal --- .../display/panel/tianma,nt36672a.yaml| 110 ++ 1 file changed, 110 insertions(+) create mode

[PATCH 0/2] Add support for Tianma nt36672a video mode panel

2020-07-16 Thread Sumit Semwal
is here [1] [1]: https://git.linaro.org/people/sumit.semwal/linux-dev.git/log/?h=dev/poco-panel-upstreaming Sumit Semwal (2): dt-bindings: display: panel: Add bindings for Tianma nt36672a panel drm: panel: Add tianma nt36672a panel driver .../display/panel/tianma,nt36672a.yaml| 110

[RESEND: PATCH v5 1/4] regulator: Allow regulators to verify enabled during enable()

2020-07-09 Thread Sumit Semwal
-by: Sumit Semwal --- v3: addressed minor review comments, improved kernel doc v2: Address review comments, including swapping enable_time and poll_enabled_time. --- drivers/regulator/core.c | 63 +++- include/linux/regulator/driver.h | 5 +++ 2 files changed

[RESEND PATCH v5 3/4] arm64: dts: qcom: pmi8998: Add nodes for LAB and IBB regulators

2020-07-09 Thread Sumit Semwal
From: Nisha Kumari This patch adds devicetree nodes for LAB and IBB regulators. Signed-off-by: Nisha Kumari Signed-off-by: Sumit Semwal [sumits: Updated for better compatible strings and names] --- v5: sumits: removed interrupt-names, since there is only one interrupt per node

[RESEND PATCH v5 2/4] dt-bindings: regulator: Add labibb regulator

2020-07-09 Thread Sumit Semwal
From: Nisha Kumari Adding the devicetree binding for labibb regulator. Signed-off-by: Nisha Kumari Signed-off-by: Sumit Semwal [sumits: cleanup as per review comments and update to yaml] --- v5: Addressed review comments - removed interrupt-names, changed to dual license, added

[RESEND: PATCH v5 0/4] Qualcomm labibb regulator driver

2020-07-09 Thread Sumit Semwal
Sumit Semwal (1): regulator: Allow regulators to verify enabled during enable() .../regulator/qcom-labibb-regulator.yaml | 70 +++ arch/arm64/boot/dts/qcom/pmi8998.dtsi | 12 ++ drivers/regulator/Kconfig | 10 + drivers/regulator/Makefile

[RESEND PATCH v5 4/4] regulator: qcom: Add labibb driver

2020-07-09 Thread Sumit Semwal
[sumits: reworked the driver design as per upstream review] Signed-off-by: Sumit Semwal --- v5: sumits: review comments addressed - removed dev_info about registering - removed of_get_child_by_name() - changed from using STATUS1 register to using ENABLE_CTL; this allows us

Re: [PATCH] MAINTAINERS: Add myself as DMA-buf maintainer

2020-07-01 Thread Sumit Semwal
Thanks for all the good work here, Christian! On Wed, 1 Jul 2020 at 17:20, Daniel Vetter wrote: > > On Wed, Jul 1, 2020 at 1:26 PM Christian König > wrote: > > > > As discussed on the list. > > > > Signed-off-by: Christian König > > Acked-by

[PATCH v5 1/4] regulator: Allow regulators to verify enabled during enable()

2020-06-22 Thread Sumit Semwal
-by: Sumit Semwal --- v3: addressed minor review comments, improved kernel doc v2: Address review comments, including swapping enable_time and poll_enabled_time. --- drivers/regulator/core.c | 63 +++- include/linux/regulator/driver.h | 5 +++ 2 files changed

[PATCH v5 4/4] regulator: qcom: Add labibb driver

2020-06-22 Thread Sumit Semwal
[sumits: reworked the driver design as per upstream review] Signed-off-by: Sumit Semwal --- v5: sumits: review comments addressed - removed dev_info about registering - removed of_get_child_by_name() - changed from using STATUS1 register to using ENABLE_CTL; this allows us

[PATCH v5 3/4] arm64: dts: qcom: pmi8998: Add nodes for LAB and IBB regulators

2020-06-22 Thread Sumit Semwal
From: Nisha Kumari This patch adds devicetree nodes for LAB and IBB regulators. Signed-off-by: Nisha Kumari Signed-off-by: Sumit Semwal [sumits: Updated for better compatible strings and names] --- v5: sumits: removed interrupt-names, since there is only one interrupt per node

[PATCH v5 2/4] dt-bindings: regulator: Add labibb regulator

2020-06-22 Thread Sumit Semwal
From: Nisha Kumari Adding the devicetree binding for labibb regulator. Signed-off-by: Nisha Kumari Signed-off-by: Sumit Semwal [sumits: cleanup as per review comments and update to yaml] --- v5: Addressed review comments - removed interrupt-names, changed to dual license, added

[PATCH v5 0/4] Qualcomm labibb regulator driver

2020-06-22 Thread Sumit Semwal
Sumit Semwal (1): regulator: Allow regulators to verify enabled during enable() .../regulator/qcom-labibb-regulator.yaml | 70 +++ arch/arm64/boot/dts/qcom/pmi8998.dtsi | 12 ++ drivers/regulator/Kconfig | 10 + drivers/regulator/Makefile

Re: [PATCH v2] dma-buf: Move dma_buf_release() from fops to dentry_ops

2020-06-22 Thread Sumit Semwal
Hello Charan, On Tue, 16 Jun 2020 at 19:13, Charan Teja Kalla wrote: > > Thanks Sumit for the fix. > > On 6/11/2020 5:14 PM, Sumit Semwal wrote: > > Charan Teja reported a 'use-after-free' in dmabuffs_dname [1], which > > happens if the dma_buf_release() is ca

Re: [PATCH v4 4/5] regulator: qcom: Add labibb driver

2020-06-17 Thread Sumit Semwal
On Wed, 17 Jun 2020 at 17:36, Mark Brown wrote: > > On Wed, Jun 17, 2020 at 05:27:12PM +0530, Sumit Semwal wrote: > > On Wed, 17 Jun 2020 at 17:17, Mark Brown wrote: > > > On Wed, Jun 17, 2020 at 05:12:35PM +0530, Sumit Semwal wrote: > > > > > I understand

Re: [PATCH v4 5/5] regulator: qcom: labibb: Add SC interrupt handling

2020-06-17 Thread Sumit Semwal
Hi Mark, On Tue, 2 Jun 2020 at 17:52, Mark Brown wrote: > > On Tue, Jun 02, 2020 at 03:39:24PM +0530, Sumit Semwal wrote: > > > static int qcom_labibb_regulator_enable(struct regulator_dev *rdev) > > { > > - return regulator_enable_regmap(rdev); > >

Re: [PATCH v4 4/5] regulator: qcom: Add labibb driver

2020-06-17 Thread Sumit Semwal
On Wed, 17 Jun 2020 at 17:17, Mark Brown wrote: > > On Wed, Jun 17, 2020 at 05:12:35PM +0530, Sumit Semwal wrote: > > > I understand from a pure regulators' correctness point of view, > > ENABLE_CTL should be the one checked there, so I can change the patch > > as you

Re: [PATCH v4 4/5] regulator: qcom: Add labibb driver

2020-06-17 Thread Sumit Semwal
Hello Mark, On Tue, 2 Jun 2020 at 17:55, Mark Brown wrote: > > On Tue, Jun 02, 2020 at 05:40:45PM +0530, Sumit Semwal wrote: > > On Tue, 2 Jun 2020 at 17:02, Mark Brown wrote: > > > On Tue, Jun 02, 2020 at 03:39:23PM +0530, Sumit Semwal wrote: > > > > This

Re: [PATCH v2] dma-buf: Move dma_buf_release() from fops to dentry_ops

2020-06-16 Thread Sumit Semwal
Hi Chris, On Tue, 16 Jun 2020 at 18:20, Chris Wilson wrote: > > Quoting Sumit Semwal (2020-06-16 13:42:13) > > Hello, > > > > If there are no objections to this, I will plan to merge it soon. > > I was going to suggest running it against our CI, but that

Re: [PATCH v2] dma-buf: Move dma_buf_release() from fops to dentry_ops

2020-06-16 Thread Sumit Semwal
Hello, If there are no objections to this, I will plan to merge it soon. Daniel, Chris, Chenbo? On Thu, 11 Jun 2020 at 17:14, Sumit Semwal wrote: > > Charan Teja reported a 'use-after-free' in dmabuffs_dname [1], which > happens if the dma_buf_release() is called while the

Re: [PATCH] dmabuf: use spinlock to access dmabuf->name

2020-06-16 Thread Sumit Semwal
Hi Daniel, Chris, On Thu, 11 Jun 2020 at 19:10, Charan Teja Kalla wrote: > > There exists a sleep-while-atomic bug while accessing the dmabuf->name > under mutex in the dmabuffs_dname(). This is caused from the SELinux > permissions checks on a process where it tries to validate the inherited >

[PATCH v2] dma-buf: Move dma_buf_release() from fops to dentry_ops

2020-06-11 Thread Sumit Semwal
25 ("dma-buf: add DMA_BUF_SET_NAME ioctls") Reported-by: syzbot+3643a18836bce555b...@syzkaller.appspotmail.com Cc: [5.3+] Cc: Arnd Bergmann Reported-by: Charan Teja Reddy Reviewed-by: Arnd Bergmann Signed-off-by: Sumit Semwal --- v2: per Arnd: Moved dma_buf_release() above to avo

Re: [PATCH] dma-buf: Move dma_buf_release() from fops to dentry_ops

2020-06-10 Thread Sumit Semwal
On Wed, 10 Jun 2020 at 14:57, Arnd Bergmann wrote: > > On Wed, Jun 10, 2020 at 10:33 AM Sumit Semwal wrote: > > > > Charan Teja reported a 'use-after-free' in dmabuffs_dname [1], which > > happens if the dma_buf_release() is called while the userspace is > > acc

[PATCH] dma-buf: Move dma_buf_release() from fops to dentry_ops

2020-06-10 Thread Sumit Semwal
25 ("dma-buf: add DMA_BUF_SET_NAME ioctls") Reported-by: syzbot+3643a18836bce555b...@syzkaller.appspotmail.com Cc: [5.3+] Cc: Arnd Bergmann Reported-by: Charan Teja Reddy Signed-off-by: Sumit Semwal --- drivers/dma-buf/dma-buf.c | 13 +++-- 1 file changed, 7 insertions(+), 6 de

Re: [PATCH v4 4/5] regulator: qcom: Add labibb driver

2020-06-02 Thread Sumit Semwal
Hi Mark, Thank you very much for reviewing. On Tue, 2 Jun 2020 at 17:02, Mark Brown wrote: > > On Tue, Jun 02, 2020 at 03:39:23PM +0530, Sumit Semwal wrote: > > > +static int qcom_labibb_regulator_is_enabled(struct regulator_dev *rdev) > > +{ > > + int ret;

Re: [PATCH v4 1/5] regulator: Allow regulators to verify enabled during enable()

2020-06-02 Thread Sumit Semwal
Hi Mark, Thanks for the review! On Tue, 2 Jun 2020 at 16:54, Mark Brown wrote: > > On Tue, Jun 02, 2020 at 03:39:20PM +0530, Sumit Semwal wrote: > > > + > > + if (time_remaining <= 0) { > > + rdev_err(

[PATCH v4 3/5] arm64: dts: qcom: pmi8998: Add nodes for LAB and IBB regulators

2020-06-02 Thread Sumit Semwal
From: Nisha Kumari This patch adds devicetree nodes for LAB and IBB regulators. Signed-off-by: Nisha Kumari Signed-off-by: Sumit Semwal [sumits: Updated for better compatible strings and names] -- v2: sumits: updated for better compatible string and names v3: sumits: updated interrupt-names

[PATCH v4 1/5] regulator: Allow regulators to verify enabled during enable()

2020-06-02 Thread Sumit Semwal
-by: Sumit Semwal -- v2: Address review comments, including swapping enable_time and poll_enabled_time. --- drivers/regulator/core.c | 58 +++- include/linux/regulator/driver.h | 5 +++ 2 files changed, 62 insertions(+), 1 deletion(-) diff --git a/drivers

[PATCH v4 5/5] regulator: qcom: labibb: Add SC interrupt handling

2020-06-02 Thread Sumit Semwal
, and if it doesn't get enabled, handle shutting down the panel accordingly. Signed-off-by: Nisha Kumari Signed-off-by: Sumit Semwal [sumits: updated to rework to use regmap_read_poll_timeout, handle it per regulator, add REGULATOR_EVENT_OVER_CURRENT handling

[PATCH v4 4/5] regulator: qcom: Add labibb driver

2020-06-02 Thread Sumit Semwal
Signed-off-by: Sumit Semwal [sumits: reworked to driver for more common code, using core regulator features, and using newly-added poll_enabled_time functionality from core] -- v2: sumits: reworked the driver for more common code, and addressed review comments from v1 v3: sumits

[PATCH v4 0/5] Qualcomm labibb regulator driver

2020-06-02 Thread Sumit Semwal
and IBB regulators regulator: qcom: Add labibb driver regulator: qcom: labibb: Add SC interrupt handling Sumit Semwal (1): regulator: Allow regulators to verify enabled during enable() .../regulator/qcom-labibb-regulator.yaml | 79 + arch/arm64/boot/dts/qcom/pmi8998.dtsi

[PATCH v4 2/5] dt-bindings: regulator: Add labibb regulator

2020-06-02 Thread Sumit Semwal
From: Nisha Kumari Adding the devicetree binding for labibb regulator. Signed-off-by: Nisha Kumari Signed-off-by: Sumit Semwal [sumits: cleanup as per review comments and update to yaml] -- v2: updated for better compatible string and names. v3: moved to yaml v4: fixed dt_binding_check

[PATCH v3 4/5] regulator: qcom: Add labibb driver

2020-05-28 Thread Sumit Semwal
Signed-off-by: Sumit Semwal -- v2: sumits: reworked the driver for more common code, and addressed review comments from v1 v3: sumits: addressed review comments from v2; moved to use core regulator features like enable_time, off_on_delay, and the newly added poll_enabled_time. Moved

[PATCH v3 5/5] regulator: qcom: labibb: Add SC interrupt handling

2020-05-28 Thread Sumit Semwal
, and if it doesn't get enabled, handle shutting down the panel accordingly. Signed-off-by: Nisha Kumari Signed-off-by: Sumit Semwal -- v2: sumits: reworked handling to user regmap_read_poll_timeout, and handle it per-regulator instead of clearing both lab and ibb errors on either irq

[PATCH v3 3/5] arm64: dts: qcom: pmi8998: Add nodes for LAB and IBB regulators

2020-05-28 Thread Sumit Semwal
From: Nisha Kumari This patch adds devicetree nodes for LAB and IBB regulators. Signed-off-by: Nisha Kumari Signed-off-by: Sumit Semwal -- v2: sumits: updated for better compatible string and names v3: sumits: updated interrupt-names as per review comments --- arch/arm64/boot/dts/qcom

[PATCH v3 1/5] regulator: Allow regulators to verify enabled during enable()

2020-05-28 Thread Sumit Semwal
-by: Sumit Semwal --- drivers/regulator/core.c | 28 include/linux/regulator/driver.h | 5 + 2 files changed, 33 insertions(+) diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 7486f6e4e613..06199f182114 100644 --- a/drivers/regulator

[PATCH v3 0/5] Qualcomm labibb regulator driver

2020-05-28 Thread Sumit Semwal
: labibb: Add SC interrupt handling Sumit Semwal (1): regulator: Allow regulators to verify enabled during enable() .../regulator/qcom-labibb-regulator.yaml | 63 arch/arm64/boot/dts/qcom/pmi8998.dtsi | 14 + drivers/regulator/Kconfig | 10 + drivers

[PATCH v3 2/5] dt-bindings: regulator: Add labibb regulator

2020-05-28 Thread Sumit Semwal
From: Nisha Kumari Adding the devicetree binding for labibb regulator. Signed-off-by: Nisha Kumari Signed-off-by: Sumit Semwal -- v2: updated for better compatible string and names. v3: moved to yaml --- .../regulator/qcom-labibb-regulator.yaml | 63 +++ 1 file changed

Re: [v2 3/4] regulator: qcom: Add labibb driver

2020-05-27 Thread Sumit Semwal
Hello Mark, On Thu, 14 May 2020 at 16:57, Sumit Semwal wrote: > > Hello Mark, > > Thank you for your review comments! > On Mon, 11 May 2020 at 16:09, Mark Brown wrote: > > > > On Sat, May 09, 2020 at 02:11:59AM +0530, Sumit Semwal wrote: > > > > > +

Re: [PATCH v3 1/4] dma-buf: add support for virtio exported objects

2020-05-18 Thread Sumit Semwal
Hello David, On Fri, 15 May 2020 at 19:33, Daniel Vetter wrote: > > On Fri, May 15, 2020 at 02:07:06PM +0900, David Stevens wrote: > > On Thu, May 14, 2020 at 9:30 PM Daniel Vetter wrote: > > > On Thu, May 14, 2020 at 05:19:40PM +0900, David Stevens wrote: > > > > Sorry for the duplicate reply,

Re: [v2 4/4] regulator: qcom: labibb: Add SC interrupt handling

2020-05-14 Thread Sumit Semwal
Hello Bjorn, Thanks for the review comments. On Tue, 12 May 2020 at 10:55, Bjorn Andersson wrote: > > On Fri 08 May 13:42 PDT 2020, Sumit Semwal wrote: > > > From: Nisha Kumari > > > > Add Short circuit interrupt handling and recovery for the lab and > >

Re: [v2 4/4] regulator: qcom: labibb: Add SC interrupt handling

2020-05-14 Thread Sumit Semwal
Hello Mark, Thanks for the review comments. On Mon, 11 May 2020 at 16:19, Mark Brown wrote: > > On Sat, May 09, 2020 at 02:12:00AM +0530, Sumit Semwal wrote: > > > +static irqreturn_t labibb_sc_err_handler(int irq, void *_reg) > > +{ > > + int ret, count; >

Re: [v2 1/4] dt-bindings: regulator: Add labibb regulator

2020-05-14 Thread Sumit Semwal
Hello Bjorn, Thanks for the comments! On Tue, 12 May 2020 at 07:15, Bjorn Andersson wrote: > > On Fri 08 May 13:41 PDT 2020, Sumit Semwal wrote: > > > From: Nisha Kumari > > > > Adding the devicetree binding for labibb regulator. > > > > Signed-off-by:

Re: [v2 3/4] regulator: qcom: Add labibb driver

2020-05-14 Thread Sumit Semwal
Hello Bjorn, Thanks very much for the review. On Tue, 12 May 2020 at 07:46, Bjorn Andersson wrote: > > On Fri 08 May 13:41 PDT 2020, Sumit Semwal wrote: > > > From: Nisha Kumari > > > > Qualcomm platforms have LAB(LCD AMOLED Boost)/IBB(Inverting Buck Boost) >

Re: [v2 3/4] regulator: qcom: Add labibb driver

2020-05-14 Thread Sumit Semwal
Hello Mark, Thank you for your review comments! On Mon, 11 May 2020 at 16:09, Mark Brown wrote: > > On Sat, May 09, 2020 at 02:11:59AM +0530, Sumit Semwal wrote: > > > + ret = regmap_bulk_read(reg->regmap, reg->base + > > +

Re: [PATCH v2] dma-buf: fix use-after-free in dmabuffs_dname

2020-05-13 Thread Sumit Semwal
On Wed, 13 May 2020 at 21:16, Daniel Vetter wrote: > > On Wed, May 13, 2020 at 02:51:12PM +0200, Greg KH wrote: > > On Wed, May 13, 2020 at 05:40:26PM +0530, Charan Teja Kalla wrote: > > > > > > Thank you Greg for the comments. > > > On 5/12/2020 2:22 PM, Greg KH wrote: > > > > On Fri, May 08,

[v2 3/4] regulator: qcom: Add labibb driver

2020-05-08 Thread Sumit Semwal
Signed-off-by: Sumit Semwal -- v2: sumits: reworked the driver for more common code, and addressed review comments from v1. This includes merging regulator_ops into one, and allowing for future labibb variations. --- drivers/regulator/Kconfig | 10 + drivers/regulator/Makefile

[v2 4/4] regulator: qcom: labibb: Add SC interrupt handling

2020-05-08 Thread Sumit Semwal
, and if it doesn't get enabled, handle shutting down the panel accordingly. Signed-off-by: Nisha Kumari Signed-off-by: Sumit Semwal -- v2: sumits: reworked handling to user regmap_read_poll_timeout, and handle it per-regulator instead of clearing both lab and ibb errors on either irq

[v2 0/4] Qualcomm labibb regulator driver

2020-05-08 Thread Sumit Semwal
This series adds a driver for LAB/IBB regulators found on some Qualcomm SoCs. These regulators provide positive and/or negative boost power supplies for LCD/LED display panels connected to the SoC. This series adds the support for pmi8998 PMIC found in SDM845 family of SoCs. Changes from v1: -

[v2 1/4] dt-bindings: regulator: Add labibb regulator

2020-05-08 Thread Sumit Semwal
From: Nisha Kumari Adding the devicetree binding for labibb regulator. Signed-off-by: Nisha Kumari Signed-off-by: Sumit Semwal -- v2: updated for better compatible string and names. --- .../regulator/qcom-labibb-regulator.txt | 47 +++ 1 file changed, 47 insertions

[v2 2/4] arm64: dts: qcom: pmi8998: Add nodes for LAB and IBB regulators

2020-05-08 Thread Sumit Semwal
From: Nisha Kumari This patch adds devicetree nodes for LAB and IBB regulators. Signed-off-by: Nisha Kumari Signed-off-by: Sumit Semwal -- v2: [sumits]: updated for better compatible string and names --- arch/arm64/boot/dts/qcom/pmi8998.dtsi | 16 1 file changed, 16

Re: [PATCH] dma-buf: Documentation: fix: `make htmldocs` warnings

2020-04-30 Thread Sumit Semwal
Hello Everyone, On Thu, 30 Apr 2020 at 10:07, Sam Ravnborg wrote: > > On Wed, Apr 29, 2020 at 11:27:22PM -0300, Vitor Massaru Iha wrote: > > On Wed, 2020-04-29 at 19:06 -0700, Randy Dunlap wrote: > > > On 4/29/20 6:59 PM, Vitor Massaru Iha wrote: > > > > Add missed ":" on kernel-doc function

  1   2   3   4   5   >