Re: [PATCH] net/mlx5e: allocate 'indirection_rqt' buffer dynamically

return err; } Reviewed-by: Tariq Toukan Thanks for your patch. Tariq

Re: [PATCH] net/mlx4_core: Add missed mlx4_free_cmd_mailbox()

rr(dev, "rule mirroring mailbox is null\n"); + mlx4_free_cmd_mailbox(dev, mailbox); return -EINVAL; } memcpy(mailbox->buf, fs_rule->mirr_mbox, fs_rule->mirr_mbox_size); Reviewed-by: Tariq Toukan Thanks for your patch. Tariq

Re: [PATCH v4 net-next] net: Remove redundant calls of sk_tx_queue_clear().

t message. Other than that, I think now I'm fine with the patch. Acked-by: Tariq Toukan Thanks, Tariq CC: Tariq Toukan CC: Boris Pismenny Signed-off-by: Kuniyuki Iwashima --- net/core/sock.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/net/core/sock.c

Re: [PATCH v3 net-next] net: Remove redundant calls of sk_tx_queue_clear().

-kun...@amazon.co.jp/ CC: Tariq Toukan CC: Boris Pismenny Signed-off-by: Kuniyuki Iwashima --- net/core/sock.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/net/core/sock.c b/net/core/sock.c index bbcd4b97eddd..cfbd62a5e079 100644 --- a/net/core/sock.c +

Re: [PATCH] mlx4: style: replace zero-length array with flexible-array member.

@@ -314,7 +314,7 @@ struct mlx4_en_tx_ring { struct mlx4_en_rx_desc { /* actual number of entries depends on rx ring stride */ - struct mlx4_wqe_data_seg data[0]; + struct mlx4_wqe_data_seg data[]; }; struct mlx4_en_rx_ring { Reviewed-by: Tariq Toukan Thanks.

Re: [patch 23/30] net/mlx5: Use effective interrupt affinity

_port = mlx5e_enumerate_lag_port(priv->mdev, ix); netif_napi_add(netdev, >napi, mlx5e_napi_poll, 64); Reviewed-by: Tariq Toukan Thanks.

Re: [patch 22/30] net/mlx5: Replace irq_to_desc() abuse

/mlx5/core/en.h |2 +- drivers/net/ethernet/mellanox/mlx5/core/en_main.c |2 +- drivers/net/ethernet/mellanox/mlx5/core/en_txrx.c |6 +- 3 files changed, 3 insertions(+), 7 deletions(-) Reviewed-by: Tariq Toukan Thanks.

Re: [patch 21/30] net/mlx4: Use effective interrupt affinity

must reduce the mask to the effective set, which means that checking the affinity mask itself does not really tell about the actual target CPUs. Signed-off-by: Thomas Gleixner Cc: Tariq Toukan Cc: "David S. Miller" Cc: Jakub Kicinski Cc: net...@vger.kernel.org Cc: linux-r...@vger.

Re: [patch 20/30] net/mlx4: Replace irq_to_desc() abuse

encapsulation does not mean that the kernel has no limits. Retrieve a pointer to the affinity mask itself and use that. It's still using an interface which is usually not for random drivers, but definitely less hideous than the previous hack. Signed-off-by: Thomas Gleixner Cc: Tariq Toukan Cc: "Da

Re: [PATCH 044/141] net/mlx4: Fix fall-through warnings for Clang

lop, vhcr->in_param, >out_param); + break; default: break; Reviewed-by: Tariq Toukan Thanks for your patch.

Re: [PATCH] net/mlx4: Assign boolean values to a bool variable

On 11/9/2020 9:07 AM, kaixuxia wrote: On 2020/11/8 16:20, Tariq Toukan wrote: On 11/7/2020 8:53 AM, xiakaixu1...@gmail.com wrote: From: Kaixu Xia Fix the following coccinelle warnings: Hi Kaixu, Which coccinelle version gave this warning? Hi Tariq, The version is coccinelle

Re: [PATCH] net/mlx4: Assign boolean values to a bool variable

On 11/7/2020 8:53 AM, xiakaixu1...@gmail.com wrote: From: Kaixu Xia Fix the following coccinelle warnings: Hi Kaixu, Which coccinelle version gave this warning? ./drivers/net/ethernet/mellanox/mlx4/en_rx.c:687:1-17: WARNING: Assignment of 0/1 to bool variable Reported-by: Tosk

Re: [PATCH] net/mlx4_core : remove unneeded semicolon

(enum mlx4_resource rt) case RES_FS_RULE: return "RES_FS_RULE"; case RES_XRCD: return "RES_XRCD"; default: return "Unknown resource type !!!"; - }; + } } static void rem_slave_vlans(struct mlx4_dev *dev, int slave); Reviewed-by: Tariq Toukan Thanks, Tariq

[RFC PATCH] workqueue: Add support for exposing singlethread workqueues in sysfs

Extend the workqueue API so that singlethread workqueues can be exposed in sysfs. Guarantee max_active is 1 by turning it read-only. This allows admins to control the cpumask of a workqueue, and apply the desired system cpu separation/isolation policy. Signed-off-by: Tariq Toukan --- drivers

Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value to ring_cons but not used it anymore in mlx4_en_xmit()

On 9/14/2020 11:02 PM, Jakub Kicinski wrote: On Sun, 13 Sep 2020 13:12:05 +0300 Tariq Toukan wrote: 2. When MLX4_EN_PERF_STAT is not defined, we should totally remove the local variable declaration, not only its usage. I was actually wondering about this when working on the pause stat

Re: [PATCH net-next] net: ethernet: mlx4: Avoid assigning a value to ring_cons but not used it anymore in mlx4_en_xmit()

On 9/13/2020 4:22 AM, David Miller wrote: From: Luo Jiaxing Date: Sat, 12 Sep 2020 16:08:15 +0800 We found a set but not used variable 'ring_cons' in mlx4_en_xmit(), it will cause a warning when build the kernel. And after checking the commit record of this function, we found that it was

Re: [PATCH][next] net/mlx5e: fix memory leak of tls

n -ENOMEM; tls->rx_wq = create_singlethread_workqueue("mlx5e_tls_rx"); - if (!tls->rx_wq) + if (!tls->rx_wq) { + kfree(tls); return -ENOMEM; + } priv->tls = tls; return 0; Reviewed-by: Tariq Toukan Thanks.

Re: [PATCH][next] net/tls: fix sign extension issue when left shifting u16 value

c64_set(_ctx->resync_async->req, ((u64)ntohl(seq) << 32) | -(len << 16) | RESYNC_REQ | RESYNC_REQ_ASYNC); +((u64)len << 16) | RESYNC_REQ | RESYNC_REQ_ASYNC); rx_ctx->resync_async->loglen = 0; } Reviewed-by: Tariq Toukan Thanks!

Re: [PATCH v2] net/mlx4_en: fix a memory leak bug

MLX4_QP_STATE_RST, NULL, 0, 0, rss_map->indir_qp); > mlx4_qp_remove(mdev->dev, rss_map->indir_qp); > mlx4_qp_free(mdev->dev, rss_map->indir_qp); > +qp_alloc_err: > kfree(rss_map->indir_qp); > rss_map->indir_qp = NULL; > rss_err: > Thanks for your patch. Reviewed-by: Tariq Toukan

Re: [PATCH] net/mlx4_en: fix a memory leak bug

Hi Wenwen, Thanks for your patch. On 8/12/2019 9:36 AM, Wenwen Wang wrote: > In mlx4_en_config_rss_steer(), 'rss_map->indir_qp' is allocated through > kzalloc(). After that, mlx4_qp_alloc() is invoked to configure RSS > indirection. However, if mlx4_qp_alloc() fails, the allocated >

Re: [PATCH v2] net/mlx5e: always initialize frag->last_in_page

frag = {}; > + struct mlx5e_wqe_frag_info *prev = NULL; > int i; > > next_frag.di = >wqe.di[0]; > - next_frag.offset = 0; > - prev = NULL; > > for (i = 0; i < mlx5_wq_cyc_get_size(>wqe.wq); i++) { > struct mlx5e_rq_frag_info *frag_info = >wqe.info.arr[0]; > Reviewed-by: Tariq Toukan Thanks.

Re: [PATCH] net/mlx5e: always initialize frag->last_in_page

On 7/31/2019 10:02 PM, Qian Cai wrote: > The commit 069d11465a80 ("net/mlx5e: RX, Enhance legacy Receive Queue > memory scheme") introduced an undefined behaviour below due to > "frag->last_in_page" is only initialized in > mlx5e_init_frags_partition() when, > > if (next_frag.offset +

Re: linux-next: Fixes tag needs some work in the net tree

On 7/14/2019 3:15 PM, Stephen Rothwell wrote: > Hi Tariq, > > On Sun, 14 Jul 2019 07:55:48 +0000 Tariq Toukan wrote: >> >> How do you think we should handle this? > > Dave doesn't rebase his trees, so all you can really do is learn from > it and not do it ag

Re: linux-next: Fixes tag needs some work in the net tree

On 7/12/2019 9:50 AM, Stephen Rothwell wrote: > Hi all, > > In commit > >c93dfec10f1d ("net/mlx5e: Fix compilation error in TLS code") > > Fixes tag > >Fixes: 90687e1a9a50 ("net/mlx5: Kconfig, Better organize compilation > flags") > > has these problem(s): > >- Target SHA1

Re: [PATCH] [net-next] net/mlx5e: avoid uninitialized variable use

return; > } > > skip_static_post = !memcmp(rec_seq, _be, rec_seq_sz); > Reviewed-by: Tariq Toukan Thanks!

Re: [PATCH v3 15/27] net: use zeroing allocator rather than allocator followed by memset zero

) > return -ENOMEM; > > @@ -1073,7 +1073,6 @@ static int mlx4_en_config_rss_qp(struct mlx4_en_priv > *priv, int qpn, > } > qp->event = mlx4_en_sqp_event; > > - memset(context, 0, sizeof(*context)); > mlx4_en_fill_qp_context(priv, ring->actual_size, ring->stride, 0, 0, > qpn, ring->cqn, -1, context); > context->db_rec_addr = cpu_to_be64(ring->wqres.db.dma); > Reviewed-by: Tariq Toukan

Re: [PATCH v2 15/27] net: use zeroing allocator rather than allocator followed by memset zero

mlx4_en_fill_qp_context(priv, ring->actual_size, ring->stride, 0, 0, > qpn, ring->cqn, -1, context); > context->db_rec_addr = cpu_to_be64(ring->wqres.db.dma); > For the mlx4 part: Reviewed-by: Tariq Toukan Tariq

Re: [PATCH 87/87] ethernet: mlx4: remove memset after dma_alloc_coherent

t;page_list[i].buf, 0, PAGE_SIZE); > } > > eq->eqn = mlx4_bitmap_alloc(>eq_table.bitmap); > Reviewed-by: Tariq Toukan Thanks.

Re: [PATCH 1/8] net/mlx4: use kzalloc instead of kmalloc

On 2/27/2019 8:09 AM, Robert Eshleman wrote: > This patch replaces a kmalloc/memset(,0) call with a call to kzalloc. > It also removes a memset(,0) call that always follows a *zalloc call. > > Signed-off-by: Robert Eshleman > --- > drivers/net/ethernet/mellanox/mlx4/cmd.c | 1 - >

Re: [PATCH] net/mlx4_en: fix spelling mistake: "quiting" -> "quitting"

On 2/18/2019 10:08 PM, David Miller wrote: > From: Colin King > Date: Sun, 17 Feb 2019 23:03:31 + > >> From: Colin Ian King >> >> There is a spelling mistake in a en_err error message. Fix it. >> >> Signed-off-by: Colin Ian King > > Applied, thanks Colin. > > And I agree that this

Re: [PATCH] net/mlx4_en: fix spelling mistake: "quiting" -> "quitting"

On 2/18/2019 12:25 PM, Dan Carpenter wrote: > On Mon, Feb 18, 2019 at 09:37:22AM +0000, Tariq Toukan wrote: >> >> >> On 2/18/2019 1:03 AM, Colin King wrote: >>> From: Colin Ian King >>> >>> There is a spelling mistake in a en_err error messag

Re: [PATCH] net/mlx4_en: fix spelling mistake: "quiting" -> "quitting"

> - en_err(priv, "Port: %d, invalid mac burned: %pM, quiting\n", > + en_err(priv, "Port: %d, invalid mac burned: %pM, quitting\n", > priv->port, dev->dev_addr); > err = -EINVAL; > goto out

Re: [PATCH net-next] net/mlx4: Mark expected switch fall-through

VENT_TYPE_SRQ_CATAS_ERROR: > if (mlx4_is_master(dev)) { > /* forward only to slave owning the SRQ */ > Reviewed-by: Tariq Toukan Thanks for your patch.

Re: [PATCH v2 RESEND 1/2] mm/page_alloc: free order-0 pages through PCP in page_frag_free()

w.spinics.net/lists/netdev/msg531556.html > > Reported-by: Paweł Staszewski > Analysed-by: Jesper Dangaard Brouer > Acked-by: Vlastimil Babka > Acked-by: Mel Gorman > Acked-by: Jesper Dangaard Brouer > Acked-by: Ilias Apalodimas > Tested-by: Ilias Apalodimas > Acked-by: Alexander Duyck > Acked-by: Tariq Toukan ' sign in my email tag. > Signed-off-by: Aaron Lu > ---

Re: [PATCH v2 RESEND 1/2] mm/page_alloc: free order-0 pages through PCP in page_frag_free()

w.spinics.net/lists/netdev/msg531556.html > > Reported-by: Paweł Staszewski > Analysed-by: Jesper Dangaard Brouer > Acked-by: Vlastimil Babka > Acked-by: Mel Gorman > Acked-by: Jesper Dangaard Brouer > Acked-by: Ilias Apalodimas > Tested-by: Ilias Apalodimas > Acked-by: Alexander Duyck > Acked-by: Tariq Toukan ' sign in my email tag. > Signed-off-by: Aaron Lu > ---

Re: [RFC PATCH] mm, page_alloc: double zone's batchsize

On 12/07/2018 4:55 PM, Jesper Dangaard Brouer wrote: On Thu, 12 Jul 2018 14:54:08 +0200 Michal Hocko wrote: [CC Jesper - I remember he was really concerned about the worst case latencies for highspeed network workloads.] Cc. Tariq as he have hit some networking benchmarks (around

Re: [RFC PATCH] mm, page_alloc: double zone's batchsize

On 12/07/2018 4:55 PM, Jesper Dangaard Brouer wrote: On Thu, 12 Jul 2018 14:54:08 +0200 Michal Hocko wrote: [CC Jesper - I remember he was really concerned about the worst case latencies for highspeed network workloads.] Cc. Tariq as he have hit some networking benchmarks (around

Re: WARNING and PANIC in irq_matrix_free

On 28/05/2018 1:53 PM, Thomas Gleixner wrote: On Fri, 25 May 2018, Song Liu wrote: On Wed, May 23, 2018 at 1:49 AM, Thomas Gleixner <t...@linutronix.de> wrote: On Wed, 23 May 2018, Tariq Toukan wrote: I have your patch merged into my internal branch, it prints the following: [ 4898.

Re: WARNING and PANIC in irq_matrix_free

On 28/05/2018 1:53 PM, Thomas Gleixner wrote: On Fri, 25 May 2018, Song Liu wrote: On Wed, May 23, 2018 at 1:49 AM, Thomas Gleixner wrote: On Wed, 23 May 2018, Tariq Toukan wrote: I have your patch merged into my internal branch, it prints the following: [ 4898.226258] Trying to clear

Re: [PATCH 4.16 008/161] packet: in packet_snd start writing at link layer allocation

On 24/05/2018 12:37 PM, Greg Kroah-Hartman wrote: 4.16-stable review patch. If anyone has any objections, please let me know. Please hold on with this. I think it causes some degradation. I'll report the issue on the original patch. Thanks, Tariq -- From: Willem de

Re: [PATCH 4.16 008/161] packet: in packet_snd start writing at link layer allocation

On 24/05/2018 12:37 PM, Greg Kroah-Hartman wrote: 4.16-stable review patch. If anyone has any objections, please let me know. Please hold on with this. I think it causes some degradation. I'll report the issue on the original patch. Thanks, Tariq -- From: Willem de

Re: [PATCH V4] mlx4_core: allocate ICM memory in page size chunks

icm(dev, table->icm[i], table->coherent); } - kfree(table->icm); + kvfree(table->icm); } Thanks Qing. Reviewed-by: Tariq Toukan <tar...@mellanox.com>

Re: [PATCH V4] mlx4_core: allocate ICM memory in page size chunks

); + kvfree(table->icm); } Thanks Qing. Reviewed-by: Tariq Toukan

Re: [PATCH][V2] net/mlx4: fix spelling mistake: "Inrerface" -> "Interface" and rephrase message

> --- V2: rephrase message, as helpfully suggested by Tariq Toukan --- drivers/net/ethernet/mellanox/mlx4/intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mellanox/mlx4/intf.c b/drivers/net/ethernet/mellanox/mlx4/intf.c index 2edcce98ab2d..65482f0

Re: [PATCH][V2] net/mlx4: fix spelling mistake: "Inrerface" -> "Interface" and rephrase message

On 22/05/2018 6:42 PM, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake in mlx4_dbg debug message and also change the phrasing of the message so that is is more readable Signed-off-by: Colin Ian King --- V2: rephrase message, as helpfully suggested by Tariq Toukan

Re: WARNING and PANIC in irq_matrix_free

On 19/05/2018 2:20 PM, Thomas Gleixner wrote: On Fri, 18 May 2018, Dmitry Safonov wrote: I'm not entirely sure that it's the same fault, but at least backtrace looks resembling. Yes, it's similar, but not the same issue. I'll stare are the code ... Thanks, tglx We still see the

Re: WARNING and PANIC in irq_matrix_free

On 19/05/2018 2:20 PM, Thomas Gleixner wrote: On Fri, 18 May 2018, Dmitry Safonov wrote: I'm not entirely sure that it's the same fault, but at least backtrace looks resembling. Yes, it's similar, but not the same issue. I'll stare are the code ... Thanks, tglx We still see the

Re: [PATCH v3] mlx4_core: allocate ICM memory in page size chunks

On 18/05/2018 12:45 AM, Qing Huang wrote: On 5/17/2018 2:14 PM, Eric Dumazet wrote: On 05/17/2018 01:53 PM, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter

Re: [PATCH v3] mlx4_core: allocate ICM memory in page size chunks

On 18/05/2018 12:45 AM, Qing Huang wrote: On 5/17/2018 2:14 PM, Eric Dumazet wrote: On 05/17/2018 01:53 PM, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter

Re: [PATCH] net/mlx4: fix spelling mistake: "Inrerface" -> "Interface"

On 22/05/2018 6:23 PM, Colin Ian King wrote: On 22/05/18 16:21, Tariq Toukan wrote: On 22/05/2018 11:37 AM, Colin King wrote: From: Colin Ian King <colin.k...@canonical.com> Trivial fix to spelling mistake in mlx4_dbg debug message Signed-off-by: Colin Ian King <colin.k...@cano

Re: [PATCH] net/mlx4: fix spelling mistake: "Inrerface" -> "Interface"

On 22/05/2018 6:23 PM, Colin Ian King wrote: On 22/05/18 16:21, Tariq Toukan wrote: On 22/05/2018 11:37 AM, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake in mlx4_dbg debug message Signed-off-by: Colin Ian King ---   drivers/net/ethernet/mellanox/mlx4/intf.c

Re: [PATCH] net/mlx4: fix spelling mistake: "Inrerface" -> "Interface"

On 22/05/2018 11:37 AM, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake in mlx4_dbg debug message Signed-off-by: Colin Ian King --- drivers/net/ethernet/mellanox/mlx4/intf.c | 2 +- 1 file changed, 1

Re: [PATCH] net/mlx4: fix spelling mistake: "Inrerface" -> "Interface"

On 22/05/2018 11:37 AM, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake in mlx4_dbg debug message Signed-off-by: Colin Ian King --- drivers/net/ethernet/mellanox/mlx4/intf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH V2] mlx4_core: allocate ICM memory in page size chunks

On 15/05/2018 9:53 PM, Qing Huang wrote: On 5/15/2018 2:19 AM, Tariq Toukan wrote: On 14/05/2018 7:41 PM, Qing Huang wrote: On 5/13/2018 2:00 AM, Tariq Toukan wrote: On 11/05/2018 10:23 PM, Qing Huang wrote: When a system is under memory presure (high usage with fragments

Re: [PATCH V2] mlx4_core: allocate ICM memory in page size chunks

On 15/05/2018 9:53 PM, Qing Huang wrote: On 5/15/2018 2:19 AM, Tariq Toukan wrote: On 14/05/2018 7:41 PM, Qing Huang wrote: On 5/13/2018 2:00 AM, Tariq Toukan wrote: On 11/05/2018 10:23 PM, Qing Huang wrote: When a system is under memory presure (high usage with fragments

Re: [PATCH V2] mlx4_core: allocate ICM memory in page size chunks

On 14/05/2018 7:41 PM, Qing Huang wrote: On 5/13/2018 2:00 AM, Tariq Toukan wrote: On 11/05/2018 10:23 PM, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter

Re: [PATCH V2] mlx4_core: allocate ICM memory in page size chunks

On 14/05/2018 7:41 PM, Qing Huang wrote: On 5/13/2018 2:00 AM, Tariq Toukan wrote: On 11/05/2018 10:23 PM, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter

Re: [PATCH v2] net/mlx4_core: Fix error handling in mlx4_init_port_info.

gt;port = -1; + return err; } - return err; + return 0; } static void mlx4_cleanup_port_info(struct mlx4_port_info *info) Thanks for you patch. Reviewed-by: Tariq Toukan <tar...@mellanox.com> Dave, please queue for -stable. Best, Tariq

Re: [PATCH v2] net/mlx4_core: Fix error handling in mlx4_init_port_info.

return err; } - return err; + return 0; } static void mlx4_cleanup_port_info(struct mlx4_port_info *info) Thanks for you patch. Reviewed-by: Tariq Toukan Dave, please queue for -stable. Best, Tariq

Re: [PATCH V2] mlx4_core: allocate ICM memory in page size chunks

On 11/05/2018 10:23 PM, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter slow path doing memory compact/migration ops in order to complete high order memory

Re: [PATCH V2] mlx4_core: allocate ICM memory in page size chunks

On 11/05/2018 10:23 PM, Qing Huang wrote: When a system is under memory presure (high usage with fragments), the original 256KB ICM chunk allocations will likely trigger kernel memory management to enter slow path doing memory compact/migration ops in order to complete high order memory

Re: [PATCH] net/mlx4_core: Fix error handling in mlx4_init_port_info.

On 02/05/2018 4:31 PM, Tariq Toukan wrote: On 27/04/2018 6:20 PM, Tarick Bedeir wrote: Avoid exiting the function with a lingering sysfs file (if the first call to device_create_file() fails while the second succeeds), and avoid calling devlink_port_unregister() twice. In other words

Re: [PATCH] net/mlx4_core: Fix error handling in mlx4_init_port_info.

On 02/05/2018 4:31 PM, Tariq Toukan wrote: On 27/04/2018 6:20 PM, Tarick Bedeir wrote: Avoid exiting the function with a lingering sysfs file (if the first call to device_create_file() fails while the second succeeds), and avoid calling devlink_port_unregister() twice. In other words

Re: [PATCH] net/mlx4_en: Fix an error handling path in 'mlx4_en_init_netdev()'

On 10/05/2018 5:36 PM, Tariq Toukan wrote: On 10/05/2018 5:18 PM, Dan Carpenter wrote: On Thu, May 10, 2018 at 04:38:08PM +0300, Yuval Shaia wrote: On Thu, May 10, 2018 at 09:02:26AM +0200, Christophe JAILLET wrote: If an error occurs, 'mlx4_en_destroy_netdev()' is called. It then calls

Re: [PATCH] net/mlx4_en: Fix an error handling path in 'mlx4_en_init_netdev()'

On 10/05/2018 5:36 PM, Tariq Toukan wrote: On 10/05/2018 5:18 PM, Dan Carpenter wrote: On Thu, May 10, 2018 at 04:38:08PM +0300, Yuval Shaia wrote: On Thu, May 10, 2018 at 09:02:26AM +0200, Christophe JAILLET wrote: If an error occurs, 'mlx4_en_destroy_netdev()' is called. It then calls

Re: [PATCH] net/mlx4_en: Fix an error handling path in 'mlx4_en_init_netdev()'

On 10/05/2018 5:18 PM, Dan Carpenter wrote: On Thu, May 10, 2018 at 04:38:08PM +0300, Yuval Shaia wrote: On Thu, May 10, 2018 at 09:02:26AM +0200, Christophe JAILLET wrote: If an error occurs, 'mlx4_en_destroy_netdev()' is called. It then calls 'mlx4_en_free_resources()' which does the

Re: [PATCH] net/mlx4_en: Fix an error handling path in 'mlx4_en_init_netdev()'

On 10/05/2018 5:18 PM, Dan Carpenter wrote: On Thu, May 10, 2018 at 04:38:08PM +0300, Yuval Shaia wrote: On Thu, May 10, 2018 at 09:02:26AM +0200, Christophe JAILLET wrote: If an error occurs, 'mlx4_en_destroy_netdev()' is called. It then calls 'mlx4_en_free_resources()' which does the

Re: [PATCH v2] net/mlx4_en: Fix an error handling path in 'mlx4_en_init_netdev()'

code to avoid such a case. Fixes: 67f8b1dcb9ee ("net/mlx4_en: Refactor the XDP forwarding rings scheme") Signed-off-by: Christophe JAILLET <christophe.jail...@wanadoo.fr> --- v1 -> v2 : rewrite the fix as explained by Tariq Toukan (this 2nd version may have been posted

Re: [PATCH v2] net/mlx4_en: Fix an error handling path in 'mlx4_en_init_netdev()'

code to avoid such a case. Fixes: 67f8b1dcb9ee ("net/mlx4_en: Refactor the XDP forwarding rings scheme") Signed-off-by: Christophe JAILLET --- v1 -> v2 : rewrite the fix as explained by Tariq Toukan (this 2nd version may have been posted twice, once without the v

Re: [PATCH] net/mlx4_en: Fix an error handling path in 'mlx4_en_init_netdev()'

On 08/05/2018 12:34 PM, Christophe JAILLET wrote: If the 2nd memory allocation of the loop fails, we must undo the memory allocation done so far. Fixes: 67f8b1dcb9ee ("net/mlx4_en: Refactor the XDP forwarding rings scheme") Signed-off-by: Christophe JAILLET ---

Re: [PATCH] net/mlx4_en: Fix an error handling path in 'mlx4_en_init_netdev()'

On 08/05/2018 12:34 PM, Christophe JAILLET wrote: If the 2nd memory allocation of the loop fails, we must undo the memory allocation done so far. Fixes: 67f8b1dcb9ee ("net/mlx4_en: Refactor the XDP forwarding rings scheme") Signed-off-by: Christophe JAILLET ---

Re: [PATCH] net/mlx4_core: Fix error handling in mlx4_init_port_info.

nfo(struct mlx4_dev *dev, int port) >port_attr); devlink_port_unregister(>devlink_port); info->port = -1; + return err; } - return err; + return 0; } static void mlx4_cleanup_port_info(str

Re: [PATCH] net/mlx4_core: Fix error handling in mlx4_init_port_info.

ruct mlx4_dev *dev, int port) >port_attr); devlink_port_unregister(>devlink_port); info->port = -1; + return err; } - return err; + return 0; } static void mlx4_cleanup_port_info(struct mlx4_port_info *info) Acked-by: Tariq Toukan Thanks Tarick.

Re: [PATCH] net/mlx4_en: Fix a memory leak in case of error in 'mlx4_en_init_netdev()'

On 12/03/2018 12:45 AM, Christophe JAILLET wrote: If 'kzalloc' fails, we must free some memory before returning. Fixes: 67f8b1dcb9ee ("net/mlx4_en: Refactor the XDP forwarding rings scheme") Signed-off-by: Christophe JAILLET ---

Re: [PATCH] net/mlx4_en: Fix a memory leak in case of error in 'mlx4_en_init_netdev()'

On 12/03/2018 12:45 AM, Christophe JAILLET wrote: If 'kzalloc' fails, we must free some memory before returning. Fixes: 67f8b1dcb9ee ("net/mlx4_en: Refactor the XDP forwarding rings scheme") Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/mellanox/mlx4/en_netdev.c | 2 +- 1

Re: WARNING and PANIC in irq_matrix_free

On 22/02/2018 11:38 PM, Thomas Gleixner wrote: On Wed, 21 Feb 2018, Tariq Toukan wrote: On 20/02/2018 8:18 PM, Thomas Gleixner wrote: On Tue, 20 Feb 2018, Thomas Gleixner wrote: On Tue, 20 Feb 2018, Tariq Toukan wrote: Is there CPU hotplugging in play? No. Ok. I'll come back to you

Re: WARNING and PANIC in irq_matrix_free

On 22/02/2018 11:38 PM, Thomas Gleixner wrote: On Wed, 21 Feb 2018, Tariq Toukan wrote: On 20/02/2018 8:18 PM, Thomas Gleixner wrote: On Tue, 20 Feb 2018, Thomas Gleixner wrote: On Tue, 20 Feb 2018, Tariq Toukan wrote: Is there CPU hotplugging in play? No. Ok. I'll come back to you

Re: WARNING and PANIC in irq_matrix_free

On 20/02/2018 8:18 PM, Thomas Gleixner wrote: On Tue, 20 Feb 2018, Thomas Gleixner wrote: On Tue, 20 Feb 2018, Tariq Toukan wrote: Is there CPU hotplugging in play? No. I'll come back to you tomorrow with a plan how to debug that after staring into the code some more. Do you have

Re: WARNING and PANIC in irq_matrix_free

On 20/02/2018 8:18 PM, Thomas Gleixner wrote: On Tue, 20 Feb 2018, Thomas Gleixner wrote: On Tue, 20 Feb 2018, Tariq Toukan wrote: Is there CPU hotplugging in play? No. I'll come back to you tomorrow with a plan how to debug that after staring into the code some more. Do you have

WARNING and PANIC in irq_matrix_free

Hi Thomas, We started seeing new issues in our net-device daily regression tests. They are related to patch [1] introduced in kernel 4.15-rc1. We frequently see a warning in dmesg [2]. Repro is not consistent, we tried to narrow it down to a smaller run but couldn't. In addition, sometimes

WARNING and PANIC in irq_matrix_free

Hi Thomas, We started seeing new issues in our net-device daily regression tests. They are related to patch [1] introduced in kernel 4.15-rc1. We frequently see a warning in dmesg [2]. Repro is not consistent, we tried to narrow it down to a smaller run but couldn't. In addition, sometimes

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

On 25/01/2018 8:25 AM, jianchao.wang wrote: Hi Eric Thanks for you kindly response and suggestion. That's really appreciated. Jianchao On 01/25/2018 11:55 AM, Eric Dumazet wrote: On Thu, 2018-01-25 at 11:27 +0800, jianchao.wang wrote: Hi Tariq On 01/22/2018 10:12 AM, jianchao.wang wrote:

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

On 25/01/2018 8:25 AM, jianchao.wang wrote: Hi Eric Thanks for you kindly response and suggestion. That's really appreciated. Jianchao On 01/25/2018 11:55 AM, Eric Dumazet wrote: On Thu, 2018-01-25 at 11:27 +0800, jianchao.wang wrote: Hi Tariq On 01/22/2018 10:12 AM, jianchao.wang wrote:

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

On 21/01/2018 11:31 AM, Tariq Toukan wrote: On 19/01/2018 5:49 PM, Eric Dumazet wrote: On Fri, 2018-01-19 at 23:16 +0800, jianchao.wang wrote: Hi Tariq Very sad that the crash was reproduced again after applied the patch. Memory barriers vary for different Archs, can you please share

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

On 21/01/2018 11:31 AM, Tariq Toukan wrote: On 19/01/2018 5:49 PM, Eric Dumazet wrote: On Fri, 2018-01-19 at 23:16 +0800, jianchao.wang wrote: Hi Tariq Very sad that the crash was reproduced again after applied the patch. Memory barriers vary for different Archs, can you please share

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

cumentation/DMA-API.txt for more information on consistent memory. On 01/15/2018 01:50 PM, jianchao.wang wrote: Hi Tariq Thanks for your kindly response. On 01/14/2018 05:47 PM, Tariq Toukan wrote: Thanks Jianchao for your patch. And Thank you guys for your reviews, much appreciated. I was off-work o

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

cumentation/DMA-API.txt for more information on consistent memory. On 01/15/2018 01:50 PM, jianchao.wang wrote: Hi Tariq Thanks for your kindly response. On 01/14/2018 05:47 PM, Tariq Toukan wrote: Thanks Jianchao for your patch. And Thank you guys for your reviews, much appreciated. I was off-work o

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

Thanks Jianchao for your patch. And Thank you guys for your reviews, much appreciated. I was off-work on Friday and Saturday. On 14/01/2018 4:40 AM, jianchao.wang wrote: Dear all Thanks for the kindly response and reviewing. That's really appreciated. On 01/13/2018 12:46 AM, Eric Dumazet

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

Thanks Jianchao for your patch. And Thank you guys for your reviews, much appreciated. I was off-work on Friday and Saturday. On 14/01/2018 4:40 AM, jianchao.wang wrote: Dear all Thanks for the kindly response and reviewing. That's really appreciated. On 01/13/2018 12:46 AM, Eric Dumazet

Re: [PATCH net-next V2 2/2] tuntap: XDP transmission

On 04/01/2018 5:14 AM, Jason Wang wrote: This patch implements XDP transmission for TAP. Since we can't create new queues for TAP during XDP set, exist ptr_ring was reused for queuing XDP buffers. To differ xdp_buff from sk_buff, TUN_XDP_FLAG (0x1UL) was encoded into lowest bit of xpd_buff

Re: [PATCH net-next V2 2/2] tuntap: XDP transmission

On 04/01/2018 5:14 AM, Jason Wang wrote: This patch implements XDP transmission for TAP. Since we can't create new queues for TAP during XDP set, exist ptr_ring was reused for queuing XDP buffers. To differ xdp_buff from sk_buff, TUN_XDP_FLAG (0x1UL) was encoded into lowest bit of xpd_buff

Re: [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions

ed-off-by: Markus Elfring <elfr...@users.sourceforge.net> --- Acked-by: Tariq Toukan <tar...@mellanox.com> Thanks.

Re: [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions

-by: Tariq Toukan Thanks.

Re: ethernet: mlx4: Delete an error message for a failed memory allocation in five functions

On 03/01/2018 4:22 PM, SF Markus Elfring wrote: I don't really accept this claim... Short informative strings worth the tiny space they consume. There can be different opinions for their usefulness. In addition, some out-of-memory errors are recoverable, even though their backtrace is

Re: ethernet: mlx4: Delete an error message for a failed memory allocation in five functions

On 03/01/2018 4:22 PM, SF Markus Elfring wrote: I don't really accept this claim... Short informative strings worth the tiny space they consume. There can be different opinions for their usefulness. In addition, some out-of-memory errors are recoverable, even though their backtrace is

Re: [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions

On 03/01/2018 10:06 AM, Julia Lawall wrote: On Wed, 3 Jan 2018, Tariq Toukan wrote: On 01/01/2018 10:46 PM, SF Markus Elfring wrote: From: Markus Elfring <elfr...@users.sourceforge.net> Date: Mon, 1 Jan 2018 21:42:27 +0100 Omit an extra message for a memory allocation f

Re: [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions

On 03/01/2018 10:06 AM, Julia Lawall wrote: On Wed, 3 Jan 2018, Tariq Toukan wrote: On 01/01/2018 10:46 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Mon, 1 Jan 2018 21:42:27 +0100 Omit an extra message for a memory allocation failure in these functions. This issue

Re: [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions

On 01/01/2018 10:46 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Mon, 1 Jan 2018 21:42:27 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by:

Re: [PATCH] ethernet: mlx4: Delete an error message for a failed memory allocation in five functions

On 01/01/2018 10:46 PM, SF Markus Elfring wrote: From: Markus Elfring Date: Mon, 1 Jan 2018 21:42:27 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- Is this an

Re: [PATCH] kobject: fix suppressing modalias in uevents delivered over netlink

On 31/12/2017 12:39 PM, Greg Kroah-Hartman wrote: On Sun, Dec 31, 2017 at 12:28:02PM +0200, Tariq Toukan wrote: On 21/12/2017 7:13 AM, Dmitry Torokhov wrote: Greg, can you please schedule my patch in for 4.15? We must have it in, otherwise there will be a major degradation (many

  1   2   >