Christoph Hellwig wrote:
The current readdir implementation deadlocks on a btree buffers locks
because nfsd calls back into ->lookup from the filldir callback. The
only short-term fix for this is to revert to the old inefficient
double-buffering scheme.
Probably why Steve did this: :)
Christoph Hellwig wrote:
The current readdir implementation deadlocks on a btree buffers locks
because nfsd calls back into -lookup from the filldir callback. The
only short-term fix for this is to revert to the old inefficient
double-buffering scheme.
Probably why Steve did this: :)
Linus Torvalds wrote:
On Mon, 1 Oct 2007, Tim Shimmin wrote:
Lachlan's description:
This fix is for a problem that has been in XFS since day one.
[XFS] Avoid replaying inode buffer initialisation log items if on-disk
version is newer.
...
Why wasn't this in the commit logs?
Linus Torvalds wrote:
On Mon, 1 Oct 2007, Tim Shimmin wrote:
Lachlan's description:
This fix is for a problem that has been in XFS since day one.
[XFS] Avoid replaying inode buffer initialisation log items if on-disk
version is newer.
...
Why wasn't this in the commit logs?
Hi Linus,
We have a few XFS fixes for 2.6.23 (meant to do this earlier).
They have been in sgi dev tree and mm tree for a while.
Please pull from the for-linus branch:
git pull git://oss.sgi.com:8090/xfs/xfs-2.6.git for-linus
With shortlog:
-
Christoph Hellwig (4):
Hi Linus,
We have a few XFS fixes for 2.6.23 (meant to do this earlier).
They have been in sgi dev tree and mm tree for a while.
Please pull from the for-linus branch:
git pull git://oss.sgi.com:8090/xfs/xfs-2.6.git for-linus
With shortlog:
-
Christoph Hellwig (4):
Jeff Layton wrote:
On Tue, 21 Aug 2007 17:21:28 -0400
Josef Sipek <[EMAIL PROTECTED]> wrote:
On Tue, Aug 21, 2007 at 07:35:51AM -0400, Jeff Layton wrote:
On Tue, 21 Aug 2007 15:35:08 +1000
Timothy Shimmin <[EMAIL PROTECTED]> wrote:
Jeff Layton wrote:
This should fix all of the
Jeff Layton wrote:
On Tue, 21 Aug 2007 17:21:28 -0400
Josef Sipek [EMAIL PROTECTED] wrote:
On Tue, Aug 21, 2007 at 07:35:51AM -0400, Jeff Layton wrote:
On Tue, 21 Aug 2007 15:35:08 +1000
Timothy Shimmin [EMAIL PROTECTED] wrote:
Jeff Layton wrote:
This should fix all of the filesystems
Jeff Layton wrote:
This should fix all of the filesystems in the mainline kernels to handle
ATTR_KILL_SUID and ATTR_KILL_SGID correctly. For most of them, this is
just a matter of making sure that they call generic_attrkill early in
the setattr inode op.
Signed-off-by: Jeff Layton <[EMAIL
Jeff Layton wrote:
This should fix all of the filesystems in the mainline kernels to handle
ATTR_KILL_SUID and ATTR_KILL_SGID correctly. For most of them, this is
just a matter of making sure that they call generic_attrkill early in
the setattr inode op.
Signed-off-by: Jeff Layton [EMAIL
Linus Torvalds wrote:
On Fri, 20 Jul 2007, Tim Shimmin wrote:
Please pull from the for-linus branch:
git pull git://oss.sgi.com:8090/xfs/xfs-2.6.git for-linus
Ok, this got some conflicts with Nick's VM fault patches, but I fixed them
up since they looked trivial, and pushed out the
Linus Torvalds wrote:
On Fri, 20 Jul 2007, Tim Shimmin wrote:
Please pull from the for-linus branch:
git pull git://oss.sgi.com:8090/xfs/xfs-2.6.git for-linus
Ok, this got some conflicts with Nick's VM fault patches, but I fixed them
up since they looked trivial, and pushed out the
Amit K. Arora wrote:
FA_FL_NO_MTIME 0x10 /* keep same mtime (default change on size, data change) */
FA_FL_NO_CTIME 0x20 /* keep same ctime (default change on size, data change) */
NACK to these aswell. If i_size changes c/mtime need updates, if the size
doesn't chamge they don't. No need
Amit K. Arora wrote:
FA_FL_NO_MTIME 0x10 /* keep same mtime (default change on size, data change) */
FA_FL_NO_CTIME 0x20 /* keep same ctime (default change on size, data change) */
NACK to these aswell. If i_size changes c/mtime need updates, if the size
doesn't chamge they don't. No need
David Chinner wrote:
On Sun, Jul 01, 2007 at 01:16:51AM +0200, Jesper Juhl wrote:
(this is back from May 16 2007, resending since it doesn't look like
the patch ever made it in anywhere)
http://oss.sgi.com/cgi-bin/cvsweb.cgi/linux-2.6-xfs/fs/xfs/xfs_vnodeops.c.diff?r1=1.698;r2=1.699;f=h
Will
David Chinner wrote:
On Sun, Jul 01, 2007 at 01:16:51AM +0200, Jesper Juhl wrote:
(this is back from May 16 2007, resending since it doesn't look like
the patch ever made it in anywhere)
http://oss.sgi.com/cgi-bin/cvsweb.cgi/linux-2.6-xfs/fs/xfs/xfs_vnodeops.c.diff?r1=1.698;r2=1.699;f=h
Will
Hi,
--On 28 May 2007 12:45:59 PM +1000 David Chinner <[EMAIL PROTECTED]> wrote:
On Mon, May 28, 2007 at 11:30:32AM +1000, Neil Brown wrote:
Thanks everyone for your input. There was some very valuable
observations in the various emails.
I will try to pull most of it together and bring out
Hi,
--On 28 May 2007 12:45:59 PM +1000 David Chinner [EMAIL PROTECTED] wrote:
On Mon, May 28, 2007 at 11:30:32AM +1000, Neil Brown wrote:
Thanks everyone for your input. There was some very valuable
observations in the various emails.
I will try to pull most of it together and bring out
There's a couple of different ways I can see to fix the problem -
the first is to not reference the buffer in xlog_iodone() after
running the callbacks that may trigger it being freed. I'd prfer to
see if this fixes the problem before having to do more invasive
surgery. Can you try the patch
There's a couple of different ways I can see to fix the problem -
the first is to not reference the buffer in xlog_iodone() after
running the callbacks that may trigger it being freed. I'd prfer to
see if this fixes the problem before having to do more invasive
surgery. Can you try the patch
Hi,
--On 9 March 2007 12:55:11 PM +0100 Christoph Hellwig <[EMAIL PROTECTED]> wrote:
Ed Cashin found a bug in the error handling code for the case where
a page allocation fails. Here's the updated version:
Index: linux-2.6/fs/xfs/linux-2.6/xfs_buf.c
Hi,
--On 9 March 2007 12:55:11 PM +0100 Christoph Hellwig [EMAIL PROTECTED] wrote:
Ed Cashin found a bug in the error handling code for the case where
a page allocation fails. Here's the updated version:
Index: linux-2.6/fs/xfs/linux-2.6/xfs_buf.c
Thanks for the report, Linda.
This and other lockdep reports are on our todo/bug list
and I've added this one.
(Nathan looked at some of these lock related changes I believe and we still have
a pending patch of his to go thru)
--Tim
--On 18 February 2007 1:38:45 PM -0800 Linda Walsh <[EMAIL
Hi Adrian,
--On 20 February 2007 1:07:47 AM +0100 Adrian Bunk <[EMAIL PROTECTED]> wrote:
xfs_buftarg_list became global for no good reason.
That's true. I'll make the change for git if Dave has no objections.
It happened because in the SGI tree we want it global for use in kdb by
Hi Adrian,
--On 20 February 2007 1:07:47 AM +0100 Adrian Bunk [EMAIL PROTECTED] wrote:
xfs_buftarg_list became global for no good reason.
That's true. I'll make the change for git if Dave has no objections.
It happened because in the SGI tree we want it global for use in kdb by
xfsidbg.o,
Thanks for the report, Linda.
This and other lockdep reports are on our todo/bug list
and I've added this one.
(Nathan looked at some of these lock related changes I believe and we still have
a pending patch of his to go thru)
--Tim
--On 18 February 2007 1:38:45 PM -0800 Linda Walsh [EMAIL
26 matches
Mail list logo
