Re: [PATCH v2 0/3] Add RPMPD support for MSM8974

2024-02-13 Thread Ulf Hansson
On Sat, 10 Feb 2024 at 17:39, Luca Weiss wrote: > > Add driver support for the RPM power domains found on the different > MSM8974 devices. > > Devicetree integration will come at a later point since also some > mostly remoteproc drivers need to be adjusted. > > Also the MX power domains on this

Re: [PATCH v3 0/5] PM: domains: Add helpers for multi PM domains to avoid open-coding

2024-02-07 Thread Ulf Hansson
On Tue, 30 Jan 2024 at 13:39, Ulf Hansson wrote: > > Rafael, my plan is queue up this series via my pmdomain tree. Please let me > know > if you see any issues with that, especially around patch1. > > Updates in v3: > - Added tested-by, reviewed-by and suggested-by t

[PATCH v3 5/5] media: venus: Convert to dev_pm_domain_attach|detach_list() for vcodec

2024-01-30 Thread Ulf Hansson
O'Donoghue Signed-off-by: Ulf Hansson --- Changes in v3: - None. Changes in v2: - Added reviewed-by and tested-by tags. --- drivers/media/platform/qcom/venus/core.c | 12 +++-- drivers/media/platform/qcom/venus/core.h | 7 ++- .../media/platform/qcom/venus

[PATCH v3 4/5] remoteproc: qcom_q6v5_adsp: Convert to dev_pm_domain_attach|detach_list()

2024-01-30 Thread Ulf Hansson
that an already attached single PM domain is the correct one. Cc: Mathieu Poirier Cc: Bjorn Andersson Cc: Konrad Dybcio Cc: Signed-off-by: Ulf Hansson --- Changes in v3: - None. Changes in v2: - None. --- drivers/remoteproc/qcom_q6v5_adsp.c | 160 +--- 1

[PATCH v3 3/5] remoteproc: imx_rproc: Convert to dev_pm_domain_attach|detach_list()

2024-01-30 Thread Ulf Hansson
Signed-off-by: Ulf Hansson --- Changes in v3: - Added reviewed-by and tested-by tags. Changes in v2: - None. --- drivers/remoteproc/imx_rproc.c | 73 +- 1 file changed, 9 insertions(+), 64 deletions(-) diff --git a/drivers/remoteproc/imx_rproc.c

[PATCH v3 2/5] remoteproc: imx_dsp_rproc: Convert to dev_pm_domain_attach|detach_list()

2024-01-30 Thread Ulf Hansson
Signed-off-by: Ulf Hansson --- Changes in v3: - Added reviewed-by and tested-by tags. Changes in v2: - None. --- drivers/remoteproc/imx_dsp_rproc.c | 82 -- 1 file changed, 9 insertions(+), 73 deletions(-) diff --git a/drivers/remoteproc

[PATCH v3 1/5] PM: domains: Add helper functions to attach/detach multiple PM domains

2024-01-30 Thread Ulf Hansson
uliana Prodan Signed-off-by: Ulf Hansson --- Changes in v3: - Added suggested-by and tested-by tags. Changes in v2: - Fix NULL pointer bug pointed out by Nikunj. --- drivers/base/power/common.c | 134 include/linux/pm_domain.h | 38 +++

[PATCH v3 0/5] PM: domains: Add helpers for multi PM domains to avoid open-coding

2024-01-30 Thread Ulf Hansson
up I am striving to make the dev_pm_opp_attach_genpd() redundant. Instead I think we should move towards using dev_pm_opp_set_config()->_opp_set_required_devs(), which would allow us to use the helpers that $subject series is adding. Kind regards Ulf Hansson Ulf Hansson (5): PM: domains: Add helper

Re: [PATCH v2 0/5] PM: domains: Add helpers for multi PM domains to avoid open-coding

2024-01-26 Thread Ulf Hansson
On Fri, 5 Jan 2024 at 17:01, Ulf Hansson wrote: > > Updates in v2: > - Ccing Daniel Baluta and Iuliana Prodan the NXP remoteproc patches to > requests help with testing. > - Fixed NULL pointer bug in patch1, pointed out by Nikunj. > - Added so

Re: [PATCH v2 3/5] remoteproc: imx_rproc: Convert to dev_pm_domain_attach|detach_list()

2024-01-23 Thread Ulf Hansson
On Tue, 23 Jan 2024 at 02:27, Mathieu Poirier wrote: > > On Mon, Jan 22, 2024 at 01:02:08PM -0700, Mathieu Poirier wrote: > > On Mon, 22 Jan 2024 at 10:51, Iuliana Prodan wrote: > > > > > > On 1/5/2024 6:01 PM, Ulf Hansson wrote: > > > > Let's avoid the

Re: [PATCH v2 0/5] PM: domains: Add helpers for multi PM domains to avoid open-coding

2024-01-12 Thread Ulf Hansson
On Mon, 8 Jan 2024 at 09:44, Daniel Baluta wrote: > > On Fri, Jan 5, 2024 at 6:02 PM Ulf Hansson wrote: > > > > Updates in v2: > > - Ccing Daniel Baluta and Iuliana Prodan the NXP remoteproc patches > > to > > requests help with testing.

[PATCH v2 5/5] media: venus: Convert to dev_pm_domain_attach|detach_list() for vcodec

2024-01-05 Thread Ulf Hansson
-by: Bryan O'Donoghue Reviewed-by: Bryan O'Donoghue Signed-off-by: Ulf Hansson --- Changes in v2: - Added tags Bryan's tags. --- drivers/media/platform/qcom/venus/core.c | 12 +++-- drivers/media/platform/qcom/venus/core.h | 7 ++- .../media/platform/qcom/venus/pm_helpers

[PATCH v2 4/5] remoteproc: qcom_q6v5_adsp: Convert to dev_pm_domain_attach|detach_list()

2024-01-05 Thread Ulf Hansson
that an already attached single PM domain is the correct one. Cc: Mathieu Poirier Cc: Bjorn Andersson Cc: Konrad Dybcio Cc: Signed-off-by: Ulf Hansson --- Changes in v2: - None. Kind regards Ulf Hansson --- drivers/remoteproc/qcom_q6v5_adsp.c | 160 +--- 1 file

[PATCH v2 3/5] remoteproc: imx_rproc: Convert to dev_pm_domain_attach|detach_list()

2024-01-05 Thread Ulf Hansson
Let's avoid the boilerplate code to manage the multiple PM domain case, by converting into using dev_pm_domain_attach|detach_list(). Cc: Mathieu Poirier Cc: Bjorn Andersson Cc: Shawn Guo Cc: Sascha Hauer Cc: Iuliana Prodan Cc: Daniel Baluta Cc: Signed-off-by: Ulf Hansson --- Changes

[PATCH v2 2/5] remoteproc: imx_dsp_rproc: Convert to dev_pm_domain_attach|detach_list()

2024-01-05 Thread Ulf Hansson
Let's avoid the boilerplate code to manage the multiple PM domain case, by converting into using dev_pm_domain_attach|detach_list(). Cc: Mathieu Poirier Cc: Bjorn Andersson Cc: Shawn Guo Cc: Sascha Hauer Cc: Iuliana Prodan Cc: Daniel Baluta Cc: Signed-off-by: Ulf Hansson --- Changes

[PATCH v2 1/5] PM: domains: Add helper functions to attach/detach multiple PM domains

2024-01-05 Thread Ulf Hansson
helper functions, dev_pm_domain_attach|detach_list(), that driver can use instead of the open-coding. Note that, it seems reasonable to limit the support for these helpers to DT based platforms, at it's the only valid use case for now. Signed-off-by: Ulf Hansson --- Changes in v2: - Fix NULL p

[PATCH v2 0/5] PM: domains: Add helpers for multi PM domains to avoid open-coding

2024-01-05 Thread Ulf Hansson
Note 3) For OPP integration, as a follow up I am striving to make the dev_pm_opp_attach_genpd() redundant. Instead I think we should move towards using dev_pm_opp_set_config()->_opp_set_required_devs(), which would allow us to use the helpers that $subject series is adding. Kind regards Ulf Hansson Ul

Re: [PATCH 1/5] PM: domains: Add helper functions to attach/detach multiple PM domains

2024-01-03 Thread Ulf Hansson
On Fri, 29 Dec 2023 at 21:21, Nikunj Kela wrote: > > > On 12/28/2023 3:41 AM, Ulf Hansson wrote: > > Attaching/detaching of a device to multiple PM domains has started to > > become a common operation for many drivers, typically during ->probe() and > > ->remov

Re: [PATCH 3/5] remoteproc: imx_rproc: Convert to dev_pm_domain_attach|detach_list()

2024-01-03 Thread Ulf Hansson
On Tue, 2 Jan 2024 at 19:41, Mathieu Poirier wrote: > > Hi Ulf, > > I'm in agreement with the modifications done to imx_rproc.c and > imx_dsp_rproc.c. > There is one thing I am ambivalent on, please see below. > > On Thu, Dec 28, 2023 at 12:41:55PM +0100, Ulf Hansso

[PATCH 5/5] media: venus: Convert to dev_pm_domain_attach|detach_list() for vcodec

2023-12-28 Thread Ulf Hansson
Let's avoid some of the boilerplate code to manage the vcodec PM domains, by converting into using dev_pm_domain_attach|detach_list(). Cc: Mauro Carvalho Chehab Cc: Stanimir Varbanov Cc: Vikash Garodia Cc: "Bryan O'Donoghue" Cc: Bjorn Andersson Cc: Konrad Dybcio Cc: Signed-o

[PATCH 4/5] remoteproc: qcom_q6v5_adsp: Convert to dev_pm_domain_attach|detach_list()

2023-12-28 Thread Ulf Hansson
that an already attached single PM domain is the correct one. Cc: Mathieu Poirier Cc: Bjorn Andersson Cc: Konrad Dybcio Cc: Signed-off-by: Ulf Hansson --- drivers/remoteproc/qcom_q6v5_adsp.c | 160 +--- 1 file changed, 73 insertions(+), 87 deletions(-) diff --git

[PATCH 3/5] remoteproc: imx_rproc: Convert to dev_pm_domain_attach|detach_list()

2023-12-28 Thread Ulf Hansson
Let's avoid the boilerplate code to manage the multiple PM domain case, by converting into using dev_pm_domain_attach|detach_list(). Cc: Mathieu Poirier Cc: Bjorn Andersson Cc: Shawn Guo Cc: Sascha Hauer Cc: Signed-off-by: Ulf Hansson --- drivers/remoteproc/imx_rproc.c | 73

[PATCH 2/5] remoteproc: imx_dsp_rproc: Convert to dev_pm_domain_attach|detach_list()

2023-12-28 Thread Ulf Hansson
Let's avoid the boilerplate code to manage the multiple PM domain case, by converting into using dev_pm_domain_attach|detach_list(). Cc: Mathieu Poirier Cc: Bjorn Andersson Cc: Shawn Guo Cc: Sascha Hauer Cc: Signed-off-by: Ulf Hansson --- drivers/remoteproc/imx_dsp_rproc.c | 82

[PATCH 1/5] PM: domains: Add helper functions to attach/detach multiple PM domains

2023-12-28 Thread Ulf Hansson
helper functions, dev_pm_domain_attach|detach_list(), that driver can use instead of the open-coding. Note that, it seems reasonable to limit the support for these helpers to DT based platforms, at it's the only valid use case for now. Signed-off-by: Ulf Hansson --- drivers/base/power/common.c

[PATCH 0/5] PM: domains: Add helpers for multi PM domains to avoid open-coding

2023-12-28 Thread Ulf Hansson
hat $subject series is adding. Kind regards Ulf Hansson Ulf Hansson (5): PM: domains: Add helper functions to attach/detach multiple PM domains remoteproc: imx_dsp_rproc: Convert to dev_pm_domain_attach|detach_list() remoteproc: imx_rproc: Convert to dev_pm_domain_attach|detach_

Re: [PATCH] dt-bindings: correct white-spaces in examples

2023-11-28 Thread Ulf Hansson
On Fri, 24 Nov 2023 at 10:21, Krzysztof Kozlowski wrote: > > Use only one and exactly one space around '=' in DTS example. > > Signed-off-by: Krzysztof Kozlowski Acked-by: Ulf Hansson # For MMC Kind regards Uffe > > --- > > Merging idea: Rob's DT. > Should appl

Re: [PATCH 2/2] net: mwifiex: add support for the SD8777 chipset

2023-11-02 Thread Ulf Hansson
le this support by adding the necessary information based > on the downstream code. > > Signed-off-by: Karel Balej Acked-by: Ulf Hansson # For MMC Kind regards Uffe > --- > drivers/net/wireless/marvell/mwifiex/Kconfig | 4 ++-- > drivers/net/wireless/marvell/mwifiex/sdio.c |

Re: [PATCH v1 1/6] mmc: core: Correct descriptions in mmc_of_parse()

2021-04-19 Thread Ulf Hansson
On Mon, 19 Apr 2021 at 13:24, Andy Shevchenko wrote: > > Since it has been converted to use device property API, the function > and field descriptions become outdated. Correct them. > > Fixes: 73a47a9bb3e2 ("mmc: core: Use device_property_read instead of > of_property_read") > Signed-off-by:

Re: [PATCH] mmc: core: Move eMMC cache flushing to a new bus_ops callback

2021-04-19 Thread Ulf Hansson
ward to add the SD specific parts, > > as subsequent changes are about to show. > > > > Signed-off-by: Ulf Hansson > Reviewed-by: Avri Altman Thanks! Patch applied for next. Kind regards Uffe

Re: [PATCH v2 1/2] mmc: block: Issue flush only if allowed

2021-04-19 Thread Ulf Hansson
On Sun, 18 Apr 2021 at 08:00, Avri Altman wrote: > > The cache may be flushed to the nonvolatile storage by writing to > FLUSH_CACHE byte (EXT_CSD byte [32]). When in command queueing mode, the > cache may be flushed by issuing a CMDQ_TASK_ DEV_MGMT (CMD48) with a > FLUSH_CACHE op-code. Either

[PATCH] mmc: core: Move eMMC cache flushing to a new bus_ops callback

2021-04-19 Thread Ulf Hansson
To prepare to add internal cache management for SD cards, let's start by moving the eMMC specific code into a new ->flush_cache() bus_ops callback. In this way, it becomes more straight-forward to add the SD specific parts, as subsequent changes are about to show. Signed-off-by: Ulf Hans

Re: [PATCH] mmc: core: Don't allocate IDA for OF aliases

2021-04-16 Thread Ulf Hansson
On Fri, 16 Apr 2021 at 19:50, Stephen Boyd wrote: > > Quoting Ulf Hansson (2021-04-16 00:17:10) > > On Thu, 15 Apr 2021 at 21:29, Stephen Boyd wrote: > > > > > > > > > Don't think so. The device (with the kobject inside) is removed, and >

Re: [PATCH v2] mmc: meson-gx: replace WARN_ONCE with dev_warn_once about scatterlist size alignment in block mode

2021-04-16 Thread Ulf Hansson
On Fri, 16 Apr 2021 at 11:43, Neil Armstrong wrote: > > Since commit e085b51c74cc ("mmc: meson-gx: check for scatterlist size > alignment in block mode"), > support for SDIO SD_IO_RW_EXTENDED transferts are properly filtered but some > driver > like brcmfmac still gives a block sg buffer size

Re: [PATCH] mmc: core: Don't allocate IDA for OF aliases

2021-04-16 Thread Ulf Hansson
On Thu, 15 Apr 2021 at 21:29, Stephen Boyd wrote: > > Quoting Ulf Hansson (2021-04-15 01:56:12) > > On Tue, 13 Apr 2021 at 02:36, Stephen Boyd wrote: > > > > > > - err = ida_simple_get(_host_ida, min_idx, max_idx, GFP_KERNEL); > > > - if (err

Re: [RFC PATCH v3 5/8] cpuidle: Factor-out power domain related code from PSCI domain driver

2021-04-15 Thread Ulf Hansson
L(dev)) > - return; > - > - dev_pm_domain_detach(dev, false); > -} > diff --git a/drivers/cpuidle/cpuidle-psci.h b/drivers/cpuidle/cpuidle-psci.h > index d8e925e84c27..70de1e3c00af 100644 > --- a/drivers/cpuidle/cpuidle-psci.h > +++ b/drivers/cpuidle

Re: [PATCH v3] Re-submit of the erase command addition plus removal of MMC_IOC_MULTI_CMD ifndef for erase. Author=Kimito Sakata

2021-04-15 Thread Ulf Hansson
+ Avri On Fri, 2 Apr 2021 at 01:02, wrote: > > From: Kimito Sakata > > Signed-off-by: Kimito Sakata This looks okay to me, but I have looped in Avri who might have some comments. Kind regards Uffe > --- > mmc.c | 8 > mmc.h | 13 +- > mmc_cmds.c | 129

Re: [PATCH v2 2/3] mmc: sdhci-s3c: correct kerneldoc of sdhci_s3c_drv_data

2021-04-15 Thread Ulf Hansson
On Thu, 15 Apr 2021 at 10:44, Krzysztof Kozlowski wrote: > > Correct the name of sdhci_s3c_drv_data structure in kerneldoc: > > drivers/mmc/host/sdhci-s3c.c:143: warning: > expecting prototype for struct sdhci_s3c_driver_data. Prototype was for > struct sdhci_s3c_drv_data instead > >

Re: [PATCH v2 1/3] mmc: sdhci-s3c: simplify getting of_device_id match data

2021-04-15 Thread Ulf Hansson
On Thu, 15 Apr 2021 at 10:44, Krzysztof Kozlowski wrote: > > Use of_device_get_match_data() to make the code slightly smaller and to > remove the of_device_id table forward declaration. > > Signed-off-by: Krzysztof Kozlowski Applied for next, thanks! Kind regards Uffe > > --- > > Changes

Re: [PATCH v2 3/3] mmc: sdhci-s3c: constify uses of driver/match data

2021-04-15 Thread Ulf Hansson
On Thu, 15 Apr 2021 at 10:44, Krzysztof Kozlowski wrote: > > The driver data (struct sdhci_s3c_drv_data) stored in of_device_id > table is allocated as const and used only in const-way. Skip > unnecessary const-away casts and convert all users to work with pointer > to const. This is both more

Re: [PATCH v1 0/2] Let sanitize not retry in case of timeout/failure

2021-04-15 Thread Ulf Hansson
On Wed, 14 Apr 2021 at 23:22, Bean Huo wrote: > > From: Bean Huo > > > Bean Huo (2): > mmc: core: Add a retries parameter to __mmc_switch function > mmc: core: Let sanitize not retry in case of timeout/failure > > drivers/mmc/core/mmc.c | 22 +++--- >

Re: [PATCH] mmc: sdhci-pci-gli: Enlarge ASPM L1 entry delay of GL975x

2021-04-15 Thread Ulf Hansson
On Thu, 15 Apr 2021 at 05:23, Ben Chuang wrote: > > GL975x enters ASPM L1 state after a short idle in default. > Enlarge the idle period to 7.9us for improving the R/W performance. > > Signed-off-by: Ben Chuang Applied for next, thanks! Kind regards Uffe > --- >

Re: [PATCH] memstick: r592: remove unused variable

2021-04-15 Thread Ulf Hansson
On Wed, 14 Apr 2021 at 04:21, Jiapeng Chong wrote: > > Fix the following clang warning: > > drivers/memstick/host/r592.c:363:6: warning: variable ‘len’ set but not > used [-Wunused-but-set-variable]. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Chong Applied for next, thanks! Kind

Re: [PATCH] mmc: meson-gx: remove useless warning about scatterlist size alignment in block mode

2021-04-15 Thread Ulf Hansson
On Wed, 14 Apr 2021 at 12:00, Neil Armstrong wrote: > > Since commit e085b51c74cc ("mmc: meson-gx: check for scatterlist size > alignment in block mode"), > support for SDIO SD_IO_RW_EXTENDED transferts are properly filtered but some > driver > like brcmfmac still gives a block sg buffer size

Re: [PATCH] mmc: core: Don't allocate IDA for OF aliases

2021-04-15 Thread Ulf Hansson
On Tue, 13 Apr 2021 at 02:36, Stephen Boyd wrote: > > There's a chance that the IDA allocated in mmc_alloc_host() is not freed > for some time because it's freed as part of a class' release function > (see mmc_host_classdev_release() where the IDA is freed). If another > thread is holding a

Re: [PATCH v5 08/24] wfx: add bus_sdio.c

2021-04-12 Thread Ulf Hansson
On Wed, 7 Apr 2021 at 14:00, Kalle Valo wrote: > > Ulf Hansson writes: > > >> If I follow what has been done in other drivers I would write something > >> like: > >> > >> static int wfx_sdio_suspend(struct device *dev) > >> { > &

Re: [PATCH -next] mmc: sdhci-st: Remove unnecessary error log

2021-04-12 Thread Ulf Hansson
On Fri, 9 Apr 2021 at 04:28, Laibin Qiu wrote: > > devm_ioremap_resource() has recorded error log, so it's > unnecessary to record log again. > > Reported-by: Hulk Robot > Signed-off-by: Laibin Qiu Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-st.c | 4 +--- >

Re: [PATCH -next] mmc: owl-mmc: Remove unnecessary error log

2021-04-12 Thread Ulf Hansson
On Fri, 9 Apr 2021 at 04:24, Laibin Qiu wrote: > > devm_ioremap_resource() has recorded error log, so it's > unnecessary to record log again. > > Reported-by: Hulk Robot > Signed-off-by: Laibin Qiu Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/owl-mmc.c | 1 - > 1

Re: [PATCH -next] mmc: sdhci-msm: Remove unnecessary error log

2021-04-12 Thread Ulf Hansson
On Fri, 9 Apr 2021 at 03:44, Jia Yang wrote: > > devm_ioremap_resource() has recorded error log, so it's > unnecessary to record log again. > > Reported-by: Hulk Robot > Signed-off-by: Jia Yang Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-msm.c | 8 ++-- >

Re: [RESEND, PATCH] mmc: sdhci-pci-gli: Improve GL9763E L1 entry delay to increase battery life

2021-04-12 Thread Ulf Hansson
On Wed, 7 Apr 2021 at 11:35, Ben Chuang wrote: > > From: Ben Chuang > > For GL9763E, although there is the best performance at the maximum delay. > Change the value to 20us in order to have better power consumption. > This change may reduce the maximum performance by 10%. > > Signed-off-by: Ben

Re: [PATCH 1/3] dt-bindings: mmc: iproc-sdhci: Convert to json-schema

2021-04-12 Thread Ulf Hansson
On Tue, 6 Apr 2021 at 12:48, Nicolas Saenz Julienne wrote: > > Convert the brcm,iproc-sdhci binding to DT schema format using json-schema > > Signed-off-by: Nicolas Saenz Julienne Applied for next, thanks! (I guess patch2 and patch3 needs a re-spin?) Kind regards Uffe > > --- > >

Re: [PATCH] mmc: moxart: Remove unused variable 'dma_time' and 'pio_time'

2021-04-12 Thread Ulf Hansson
On Fri, 2 Apr 2021 at 11:53, Yang Li wrote: > > Fixes the following W=1 kernel build warning(s): > > drivers/mmc/host/moxart-mmc.c:257:7: warning: variable ‘dma_time’ set > but not used > drivers/mmc/host/moxart-mmc.c:395:7: warning: variable ‘pio_time’ set > but not used > > Reported-by: Abaci

Re: [PATCH v3 1/2] mmc: core: Pass down user specified timeout value to sanitize

2021-04-12 Thread Ulf Hansson
On Fri, 2 Apr 2021 at 11:24, Bean Huo wrote: > > From: Bean Huo > > As the density increases, the 4-minute timeout value for > sanitize is no longer feasible. At the same time, devices > of different densities have different timeout values, and it is > difficult to obtain a unified standard

Re: [PATCH v3 2/2] mmc: core: Let sanitize not retry in case of timeout/failure

2021-04-12 Thread Ulf Hansson
On Fri, 2 Apr 2021 at 11:24, Bean Huo wrote: > > From: Bean Huo > > Not any commands need to retry in case of timeout/failure. > Currently, the sanitize command is issued by the IOCTL interface, > and once its timeouts, the user normally decides to retry or not . > Just blindly retry three times

Re: [PATCH] mmc: add quirk to disable eMMC cache for Micron eMMC v5.0 cards

2021-04-12 Thread Ulf Hansson
+ Bean Huo, Luca Porzio On Thu, 8 Apr 2021 at 19:59, Scott Branden wrote: > > From: Vladimir Olovyannikov > > In certain rare combination of operations, Micron eMMC v5.0 cards > may experience data errors if internal cache is enabled. > This may lead to eMMC related data errors. > Introduce a

Re: [PATCH v1 1/2] dt-bindings: mmc: sdhci-of-aspeed: Add power-gpio and power-switch-gpio

2021-04-12 Thread Ulf Hansson
On Thu, 8 Apr 2021 at 03:52, Steven Lee wrote: > > AST2600-A2 EVB provides the reference design for enabling SD bus power > and toggling SD bus signal voltage by GPIO pins. > Add the definition and example for power-gpio and power-switch-gpio > properties. > > In the reference design, GPIOV0 of

Re: [PATCH v2 1/2] mmc: core: Let sanitize timeout readable/writable via sysfs

2021-04-01 Thread Ulf Hansson
On Thu, 1 Apr 2021 at 15:29, Bean Huo wrote: > > From: Bean Huo > > As the density increases, the 4-minute timeout value for > sanitize is no longer feasible. At the same time, devices > of different densities have different timeout values, and it is > difficult to obtain a unified standard

Re: [PATCH] mmc: dw_mmc-k3: use the correct HiSilicon copyright

2021-03-31 Thread Ulf Hansson
On Tue, 30 Mar 2021 at 16:27, fanghao (A) wrote: > > > > On 2021/3/30 18:38, Ulf Hansson wrote: > > On Tue, 30 Mar 2021 at 08:43, Hao Fang wrote: > >> > >> s/Hisilicon/HiSilicon/g. > >> It should use capital S, according to > >> https://w

Re: [PATCH 0/4] mmc: core: Preparations to support SD UHS-II cards

2021-03-31 Thread Ulf Hansson
On Wed, 31 Mar 2021 at 12:26, ReniusChen[陳建宏] wrote: > > Hi Ulf, > > > I'm currently trying to take over and refactor the task refer to your series. > And there hasn't been much progress recently because I'm busy with other work. Alright, thanks for sharing the update. Don't hesitate to ping me

Re: [PATCH 0/4] mmc: core: Preparations to support SD UHS-II cards

2021-03-31 Thread Ulf Hansson
Hi Ben, Renius, On Thu, 25 Feb 2021 at 18:04, Ulf Hansson wrote: > > A series [1] that has been collaborative worked upon by Takahiro Akashi > (Linaro) and Ben Chuang (Genesys Logic) is targeting to add SD UHS-II support > to the mmc subsystem. > > Throughout the re

Re: [External] : Re: [PATCH v2] mmc-utils: Add eMMC erase command support

2021-03-31 Thread Ulf Hansson
On Tue, 30 Mar 2021 at 23:36, wrote: > > > > On 3/30/2021 6:39 AM, Ulf Hansson wrote: > > On Wed, 24 Mar 2021 at 17:45, Bean Huo wrote: > >> From: Kimito Sakata > >> > >> we have been using this erase feature for a while, but it is > >> st

Re: [PATCH v2] mmc-utils: Add eMMC erase command support

2021-03-30 Thread Ulf Hansson
On Wed, 24 Mar 2021 at 17:45, Bean Huo wrote: > > From: Kimito Sakata > > we have been using this erase feature for a while, but it is > still not merged into the upstream mmc-utils. Especially, for > the customer, every time when they update the mmc-utils, they > should re-install this patch

Re: [PATCH] mmc: sdhci-brcmstb: Remove CQE quirk

2021-03-30 Thread Ulf Hansson
On Thu, 25 Mar 2021 at 20:28, Al Cooper wrote: > > Remove the CQHCI_QUIRK_SHORT_TXFR_DESC_SZ quirk because the > latest chips have this fixed and earlier chips have other > CQE problems that prevent the feature from being enabled. > > Signed-off-by: Al Cooper Applied for next, thanks! Kind

Re: [PATCH] mmc: dw_mmc-k3: use the correct HiSilicon copyright

2021-03-30 Thread Ulf Hansson
On Tue, 30 Mar 2021 at 08:43, Hao Fang wrote: > > s/Hisilicon/HiSilicon/g. > It should use capital S, according to > https://www.hisilicon.com/en/terms-of-use. > > Signed-off-by: Hao Fang > --- > drivers/mmc/host/dw_mmc-k3.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH v2 05/13] mmc: sdhci-cadence: Add Pensando Elba SoC support

2021-03-30 Thread Ulf Hansson
+ Masahiro Yamada (main author of the driver) On Mon, 29 Mar 2021 at 03:59, Brad Larson wrote: > > Add support for Pensando Elba SoC which explicitly controls > byte-lane enables on writes. Refactor to allow platform > specific write ops. > > Signed-off-by: Brad Larson > --- >

Re: [PATCH] mmc: sdhci: replace mmc->parent with mmc_dev() for consistency

2021-03-24 Thread Ulf Hansson
On Wed, 24 Mar 2021 at 08:50, Jisheng Zhang wrote: > > As pointed out by Ulf, "both "mmc->parent" and mmc_dev(mmc) are being > used in the entire c-file". Convert all the mmc->parent usage in all > sdhci host driver to mmc_dev() for consistency. >

Re: [PATCH] mmc: sdhci-of-dwcmshc: set MMC_CAP_WAIT_WHILE_BUSY

2021-03-24 Thread Ulf Hansson
On Wed, 24 Mar 2021 at 08:47, Jisheng Zhang wrote: > > The host supports HW busy detection of the device busy signaling over > dat0 line. Set MMC_CAP_wAIT_WHILE_BUSY host capability. > > Signed-off-by: Jisheng Zhang Applied for next, thanks! Kind regards Uffe > --- >

Re: [PATCH v3] mmc: sdhci-of-dwcmshc: add ACPI support for BlueField-3 SoC

2021-03-24 Thread Ulf Hansson
On Mon, 22 Mar 2021 at 23:47, Liming Sun wrote: > > This commit adds ACPI support in the sdhci-of-dwcmshc driver for > BlueField-3 SoC. It has changes to only use the clock hierarchy > for Deviec Tree since the clk is not supported by ACPI. Instead, > ACPI can define 'clock-frequency' which is

Re: [PATCH v5 08/24] wfx: add bus_sdio.c

2021-03-23 Thread Ulf Hansson
On Tue, 23 Mar 2021 at 18:53, Jérôme Pouiller wrote: > > On Tuesday 23 March 2021 15:11:56 CET Ulf Hansson wrote: > > On Mon, 22 Mar 2021 at 18:14, Jérôme Pouiller > > wrote: > > > On Monday 22 March 2021 13:20:35 CET Ulf Hansson wrote: > > > > On Mon

Re: [PATCH v5 08/24] wfx: add bus_sdio.c

2021-03-23 Thread Ulf Hansson
On Mon, 22 Mar 2021 at 18:14, Jérôme Pouiller wrote: > > Hello Ulf, > > On Monday 22 March 2021 13:20:35 CET Ulf Hansson wrote: > > On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller > > wrote: > > > > > > From: Jérôme Pouiller > > > > > >

Re: [PATCH] mmc: core: Mark mmc_host device with pm_runtime_no_callbacks

2021-03-23 Thread Ulf Hansson
m_runtime_no_callbacks will solve the issue. > Thanks. > Huanlin Ke Thanks for sharing more details! I have to admit, that this sounds quite weird to me. I wonder if this is a problem that deserves to be fixed in the runtime PM core Let me have a closer look a get back to you agai

Re: [PATCH v5 08/24] wfx: add bus_sdio.c

2021-03-22 Thread Ulf Hansson
On Mon, 15 Mar 2021 at 14:25, Jerome Pouiller wrote: > > From: Jérôme Pouiller > > Signed-off-by: Jérôme Pouiller > --- > drivers/net/wireless/silabs/wfx/bus_sdio.c | 259 + > 1 file changed, 259 insertions(+) > create mode 100644 drivers/net/wireless/silabs/wfx/bus_sdio.c

Re: [PATCH] mmc: core: Mark mmc_host device with pm_runtime_no_callbacks

2021-03-22 Thread Ulf Hansson
On Sat, 20 Mar 2021 at 05:57, kehuanlin wrote: > > The rpm_resume() will call parent's resume callback recursively. > Since mmc_host has no its own pm_runtime callbacks, the mmc devices > may fail to resume (-ENOSYS in rpm_callback) sometimes. Mark mmc_host > device with pm_runtime_no_callbacks

Re: [PATCH v2] mmc: sdhci-of-dwcmshc: add ACPI support for BlueField-3 SoC

2021-03-22 Thread Ulf Hansson
On Fri, 19 Mar 2021 at 21:23, Liming Sun wrote: > > Uffe, > > Can I confirm whether you meant the 'master' branch or some other branch? > I did a rebase of master and didn't see Shawn Lin's changes in the > sdhci-of-dwcmshc.c git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next [...]

Re: [PATCH v2] mmc: sdhci-of-dwcmshc: add ACPI support for BlueField-3 SoC

2021-03-19 Thread Ulf Hansson
On Wed, 17 Mar 2021 at 00:20, Liming Sun wrote: > > This commit adds ACPI support in the sdhci-of-dwcmshc driver for > BlueField-3 SoC. It has changes to only use the clock hierarchy > for Deviec Tree since the clk is not supported by ACPI. Instead, > ACPI can define 'clock-frequency' which is

Re: [PATCH v2 4/8] dt-bindings: mmc: Add compatible for Mediatek MT8195

2021-03-19 Thread Ulf Hansson
On Fri, 19 Mar 2021 at 03:36, Seiya Wang wrote: > > This commit adds dt-binding documentation of mmc for Mediatek MT8195 SoC > Platform. > > Signed-off-by: Seiya Wang Applied for next, thanks! Kind regards Uffe > --- > Documentation/devicetree/bindings/mmc/mtk-sd.yaml | 1 + > 1 file

Re: [PATCH v1 1/2] mmc: cavium: Use '"%s...", __func__' to print function name

2021-03-19 Thread Ulf Hansson
On Fri, 19 Mar 2021 at 13:14, Bean Huo wrote: > > From: Bean Huo > > Use preferred way '"%s...", __func__' to print function name. > > Signed-off-by: Bean Huo Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/cavium.c | 3 +-- > 1 file changed, 1 insertion(+), 2

Re: [PATCH v1 2/2] mmc: cavium: Remove redundant if-statement checkup

2021-03-19 Thread Ulf Hansson
On Fri, 19 Mar 2021 at 13:14, Bean Huo wrote: > > From: Bean Huo > > Currently, we have two ways to issue multiple-block read/write the > command to the eMMC. One is by normal IO request path fs->block->mmc. > Another one is that we can issue multiple-block read/write through > MMC ioctl

Re: [PATCH v1 1/2] Revert "PM: runtime: Update device status before letting suppliers suspend"

2021-03-19 Thread Ulf Hansson
9f76464 ("PM: runtime: Update device status before letting > suppliers suspend") > Link: > https://lore.kernel.org/linux-pm/24dfb6fc-5d54-6ee2-9195-26428b7ec...@intel.com/ > Reported by: Adrian Hunter > Cc: 4.10+ # 4.10+ > Signed-off-by: Rafael J. Wysocki Review

Re: [PATCH v1 2/2] PM: runtime: Defer suspending suppliers

2021-03-19 Thread Ulf Hansson
th the > handling of the device's parent. > > Link: > https://lore.kernel.org/linux-pm/capdykfqm06kdw_p8wxsm4dijdbho4bb6t4k50uqqvr1_cos...@mail.gmail.com/ > Fixes: 21d5c57b3726 ("PM / runtime: Use device links") > Reported-by: elaine.zhang > Diagnosed-by: Ulf Hansson >

Re: [PATCH] firmware: imx: scu-pd: Update comments for single global power domain

2021-03-19 Thread Ulf Hansson
On Fri, 19 Mar 2021 at 04:31, Aisheng Dong wrote: > > Hi Ulf, > > > From: Ulf Hansson > > Sent: Wednesday, March 17, 2021 5:31 PM > > > > Since the introduction of the PM domain support for the scu-pd, the genpd > > framework has been continuously im

[PATCH] firmware: imx: scu-pd: Update comments for single global power domain

2021-03-17 Thread Ulf Hansson
the missing pieces. Signed-off-by: Ulf Hansson --- drivers/firmware/imx/scu-pd.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/drivers/firmware/imx/scu-pd.c b/drivers/firmware/imx/scu-pd.c index 08533ee67626..6e178a63442d 100644 --- a/drivers/firmware/imx/scu-pd.c +++ b

[GIT PULL] MMC fixes for v5.12-rc3

2021-03-12 Thread Ulf Hansson
Hi Linus, Here's a PR with a couple of MMC fixes intended for v5.12-rc3. Details about the highlights are as usual found in the signed tag. Please pull this in! Kind regards Ulf Hansson The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05

Re: [PATCH v2 01/14] opp: Add devres wrapper for dev_pm_opp_set_clkname

2021-03-12 Thread Ulf Hansson
On Fri, 12 Mar 2021 at 06:33, Viresh Kumar wrote: > > On 11-03-21, 22:20, Dmitry Osipenko wrote: > > +struct opp_table *devm_pm_opp_set_clkname(struct device *dev, const char > > *name) > > +{ > > + struct opp_table *opp_table; > > + int err; > > + > > + opp_table =

Re: linux-next: Signed-off-by missing for commit in the mmc tree

2021-03-11 Thread Ulf Hansson
On Tue, 9 Mar 2021 at 22:15, Stephen Rothwell wrote: > > Hi all, > > Commit > > a7856f326331 ("mmc: dw_mmc: simplify optional reset handling") > > is missing a Signed-off-by from its committer. Taken care of, thanks for reporting! > > -- > Cheers, > Stephen Rothwell Kind regards Uffe

Re: [PATCH] mmc: sdhci-pci: Avoid comma separated statements

2021-03-11 Thread Ulf Hansson
On Thu, 11 Mar 2021 at 11:14, Jisheng Zhang wrote: > > Use semicolons. > > Signed-off-by: Jisheng Zhang Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-pci-core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] mmc: sdhci: Use "mmc" directly rather than "host->mmc"

2021-03-11 Thread Ulf Hansson
On Thu, 11 Mar 2021 at 10:40, Jisheng Zhang wrote: > > Clean up the code to use the "mmc" directly instead of "host->mmc". > If the code sits in hot code path, this clean up also brings trvial > performance improvement. Take the sdhci_post_req() for example: > > before the patch: > ... >

Re: [PATCH] mmc: sdio: fix a typo in the comment of SDIO_SD_REV_3_00

2021-03-11 Thread Ulf Hansson
On Thu, 11 Mar 2021 at 10:42, Jisheng Zhang wrote: > > I believe "Spev" is typo, should be "Spec". > > Signed-off-by: Jisheng Zhang Applied for next, thanks! Kind regards Uffe > --- > include/linux/mmc/sdio.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] mmc: sdhci: Use "mmc" directly rather than "host->mmc"

2021-03-11 Thread Ulf Hansson
On Thu, 11 Mar 2021 at 10:40, Jisheng Zhang wrote: > > Clean up the code to use the "mmc" directly instead of "host->mmc". > If the code sits in hot code path, this clean up also brings trvial > performance improvement. Take the sdhci_post_req() for example: > > before the patch: > ... >

[PATCH] mmc: core: Fix hanging on I/O during system suspend for removable cards

2021-03-10 Thread Ulf Hansson
ase. Reported-by: Kiwoong Kim Cc: sta...@vger.kernel.org Signed-off-by: Ulf Hansson --- drivers/mmc/core/core.c | 74 drivers/mmc/core/core.h | 8 - drivers/mmc/core/host.c | 40 -- drivers/mmc/core/sdio.c | 28 +++ incl

Re: [PATCH] mmc: via-sdmmc: remove unneeded variable 'ret'

2021-03-09 Thread Ulf Hansson
On Tue, 9 Mar 2021 at 07:48, Yang Li wrote: > > Fix the following coccicheck warning: > ./drivers/mmc/host/via-sdmmc.c:1274:5-8: Unneeded variable: "ret". > Return "0" on line 1295 > > Reported-by: Abaci Robot > Signed-off-by: Yang Li Applied for next, thanks! Kind regards Uffe > --- >

Re: [PATCH] memstick: core: fix error return code of mspro_block_resume()

2021-03-09 Thread Ulf Hansson
On Fri, 5 Mar 2021 at 03:14, Jia-Ju Bai wrote: > > When mspro_block_init_card() fails, no error return code of > mspro_block_resume() is assigned. > To fix this bug, rc is assigned with the return value of > mspro_block_init_card(), and then rc is checked. > > Reported-by: TOTE Robot >

Re: [BUG] memstick: core: missing error return code in msb_resume()

2021-03-09 Thread Ulf Hansson
On Fri, 5 Mar 2021 at 03:45, Jia-Ju Bai wrote: > > My static analysis tool reports that no error return code is assigned in > error handling code of msb_resume(). > However, many other drivers assign error return code in xxx_resume(), > such as sky2_resume() and e1000_resume(). > I wonder whether

Re: [RFC 0/2] sdhci-iproc CMD timeouts

2021-03-09 Thread Ulf Hansson
On Thu, 25 Feb 2021 at 10:53, Nicolas Saenz Julienne wrote: > > I'm seeing a rather odd behavior from sdhci-iproc's integration in BCM2711 > (Raspberry Pi 4's SoC), and would appreciate some opinions. > > The controller will timeout on SDHCI CMDs under the following conditions: > > - No SD card

[PATCH] PM: domains: Don't runtime resume devices at genpd_prepare()

2021-03-04 Thread Ulf Hansson
to re-configure it for a system wakeup, may still call pm_runtime_get_sync(), for example, to do this. Signed-off-by: Ulf Hansson --- drivers/base/power/domain.c | 36 1 file changed, 36 deletions(-) diff --git a/drivers/base/power/domain.c b/drivers/base

Re: [PATCH V2] mmc: sdhci: Check for reset prior to DMA address unmap

2021-03-04 Thread Ulf Hansson
On Thu, 4 Mar 2021 at 16:16, wrote: > > On 2021-03-04 19:19, Ulf Hansson wrote: > > On Wed, 3 Mar 2021 at 09:32, Pradeep P V K > > wrote: > >> > >> From: Pradeep P V K > >> > >> For data read commands, SDHC may initiate data transfers e

Re: [PATCH] mmc: Try power cycling card if command request times out

2021-03-04 Thread Ulf Hansson
On Thu, 4 Mar 2021 at 15:59, Marten Lindahl wrote: > > On Thu, Mar 04, 2021 at 03:06:54PM +0100, Ulf Hansson wrote: > > On Thu, 4 Mar 2021 at 14:48, Marten Lindahl wrote: > > > > > > Hi Ulf! My apologies for the delay. > > > > > > On Tue, Mar

Re: [PATCH] mmc: Try power cycling card if command request times out

2021-03-04 Thread Ulf Hansson
On Thu, 4 Mar 2021 at 14:48, Marten Lindahl wrote: > > Hi Ulf! My apologies for the delay. > > On Tue, Mar 02, 2021 at 09:45:02AM +0100, Ulf Hansson wrote: > > On Mon, 1 Mar 2021 at 22:59, Marten Lindahl wrote: > > > > > > Hi Ulf! > > > > > >

Re: [PATCH v2 1/1] mmc: cqhci: fix random crash when remove mmc module

2021-03-04 Thread Ulf Hansson
On Wed, 3 Mar 2021 at 18:42, Frank Li wrote: > > [ 6684.493350] Unable to handle kernel paging request at virtual address > 800011c5b0f0 > [ 6684.498531] mmc0: card 0001 removed > [ 6684.501556] Mem abort info: > [ 6684.509681] ESR = 0x9647 > [ 6684.512786] EC = 0x25: DABT (current

Re: [PATCH V2] mmc: sdhci: Check for reset prior to DMA address unmap

2021-03-04 Thread Ulf Hansson
On Wed, 3 Mar 2021 at 09:32, Pradeep P V K wrote: > > From: Pradeep P V K > > For data read commands, SDHC may initiate data transfers even before it > completely process the command response. In case command itself fails, > driver un-maps the memory associated with data transfer but this memory

Re: [RFC PATCH 1/5] rpmb: add Replay Protected Memory Block (RPMB) subsystem

2021-03-03 Thread Ulf Hansson
bout. The eventual userspace ioctl interface will aim to be > similarly generic. This is an RFC to follow up on: > > Subject: RPMB user space ABI > Date: Thu, 11 Feb 2021 14:07:00 + > Message-ID: <87mtwashi4@linaro.org>] > > Signed-off-by: Alex Bennée > Cc: T

  1   2   3   4   5   6   7   8   9   10   >