On Monday 19 September 2016 01:16 PM, Peter Chen wrote:
On Mon, Sep 19, 2016 at 01:09:10PM +0530, Vaibhav Hiremath wrote:
On Friday 09 September 2016 02:17 PM, Ulf Hansson wrote:
[...]
We had an agreement that keep mmc's pwrseq framework unchanging.
Unless Ulf and rob both agree to change
On Monday 19 September 2016 01:16 PM, Peter Chen wrote:
On Mon, Sep 19, 2016 at 01:09:10PM +0530, Vaibhav Hiremath wrote:
On Friday 09 September 2016 02:17 PM, Ulf Hansson wrote:
[...]
We had an agreement that keep mmc's pwrseq framework unchanging.
Unless Ulf and rob both agree to change
On Friday 09 September 2016 02:17 PM, Ulf Hansson wrote:
[...]
We had an agreement that keep mmc's pwrseq framework unchanging.
Unless Ulf and rob both agree to change.
Why 2 separate approach for same problem ?
And I see this as possible duplication of code/functionality :)
How the new
On Friday 09 September 2016 02:17 PM, Ulf Hansson wrote:
[...]
We had an agreement that keep mmc's pwrseq framework unchanging.
Unless Ulf and rob both agree to change.
Why 2 separate approach for same problem ?
And I see this as possible duplication of code/functionality :)
How the new
a
On Friday 02 September 2016 06:40 AM, Peter Chen wrote:
On Wed, Aug 31, 2016 at 10:28:20PM +0530, Vaibhav Hiremath wrote:
On Wednesday 31 August 2016 03:22 PM, Peter Chen wrote:
On Wed, Aug 31, 2016 at 01:46:30PM +0530, Vaibhav Hiremath wrote:
On Monday 29 August 2016 04:40 PM, Peter Chen
a
On Friday 02 September 2016 06:40 AM, Peter Chen wrote:
On Wed, Aug 31, 2016 at 10:28:20PM +0530, Vaibhav Hiremath wrote:
On Wednesday 31 August 2016 03:22 PM, Peter Chen wrote:
On Wed, Aug 31, 2016 at 01:46:30PM +0530, Vaibhav Hiremath wrote:
On Monday 29 August 2016 04:40 PM, Peter Chen
On Friday 02 September 2016 06:30 AM, Peter Chen wrote:
On Thu, Sep 01, 2016 at 01:33:22PM +0530, Vaibhav Hiremath wrote:
On Monday 15 August 2016 02:43 PM, Peter Chen wrote:
Add binding doc for generic power sequence library.
Signed-off-by: Peter Chen <peter.c...@nxp.com>
On Friday 02 September 2016 06:30 AM, Peter Chen wrote:
On Thu, Sep 01, 2016 at 01:33:22PM +0530, Vaibhav Hiremath wrote:
On Monday 15 August 2016 02:43 PM, Peter Chen wrote:
Add binding doc for generic power sequence library.
Signed-off-by: Peter Chen
Acked-by: Philipp Zabel
Acked
On Monday 15 August 2016 02:43 PM, Peter Chen wrote:
We have an well-known problem that the device needs to do some power
sequence before it can be recognized by related host, the typical
example like hard-wired mmc devices and usb devices.
This power sequence is hard to be described at
On Monday 15 August 2016 02:43 PM, Peter Chen wrote:
We have an well-known problem that the device needs to do some power
sequence before it can be recognized by related host, the typical
example like hard-wired mmc devices and usb devices.
This power sequence is hard to be described at
On Monday 15 August 2016 02:43 PM, Peter Chen wrote:
Add binding doc for generic power sequence library.
Signed-off-by: Peter Chen
Acked-by: Philipp Zabel
Acked-by: Rob Herring
---
.../bindings/power/pwrseq/pwrseq-generic.txt
On Monday 15 August 2016 02:43 PM, Peter Chen wrote:
Add binding doc for generic power sequence library.
Signed-off-by: Peter Chen
Acked-by: Philipp Zabel
Acked-by: Rob Herring
---
.../bindings/power/pwrseq/pwrseq-generic.txt | 48 ++
1 file changed, 48
On Monday 15 August 2016 02:43 PM, Peter Chen wrote:
Some hard-wired USB devices need to do power sequence to let the
device work normally, the typical power sequence like: enable USB
PHY clock, toggle reset pin, etc. But current Linux USB driver
lacks of such code to do it, it may cause some
On Monday 15 August 2016 02:43 PM, Peter Chen wrote:
Some hard-wired USB devices need to do power sequence to let the
device work normally, the typical power sequence like: enable USB
PHY clock, toggle reset pin, etc. But current Linux USB driver
lacks of such code to do it, it may cause some
On Wednesday 31 August 2016 03:22 PM, Peter Chen wrote:
On Wed, Aug 31, 2016 at 01:46:30PM +0530, Vaibhav Hiremath wrote:
On Monday 29 August 2016 04:40 PM, Peter Chen wrote:
On Wed, Aug 24, 2016 at 04:53:35PM +0800, Peter Chen wrote:
On Tue, Aug 23, 2016 at 04:02:48PM +0530, Vaibhav
On Wednesday 31 August 2016 03:22 PM, Peter Chen wrote:
On Wed, Aug 31, 2016 at 01:46:30PM +0530, Vaibhav Hiremath wrote:
On Monday 29 August 2016 04:40 PM, Peter Chen wrote:
On Wed, Aug 24, 2016 at 04:53:35PM +0800, Peter Chen wrote:
On Tue, Aug 23, 2016 at 04:02:48PM +0530, Vaibhav
On Monday 29 August 2016 04:40 PM, Peter Chen wrote:
On Wed, Aug 24, 2016 at 04:53:35PM +0800, Peter Chen wrote:
On Tue, Aug 23, 2016 at 04:02:48PM +0530, Vaibhav Hiremath wrote:
On Monday 15 August 2016 02:43 PM, Peter Chen wrote:
Hi all,
This is a follow-up for my last power sequence
On Monday 29 August 2016 04:40 PM, Peter Chen wrote:
On Wed, Aug 24, 2016 at 04:53:35PM +0800, Peter Chen wrote:
On Tue, Aug 23, 2016 at 04:02:48PM +0530, Vaibhav Hiremath wrote:
On Monday 15 August 2016 02:43 PM, Peter Chen wrote:
Hi all,
This is a follow-up for my last power sequence
On Monday 15 August 2016 02:43 PM, Peter Chen wrote:
Hi all,
This is a follow-up for my last power sequence framework patch set [1].
According to Rob Herring and Ulf Hansson's comments[2], I use a generic
power sequence library for parsing the power sequence elements on DT,
and implement
On Monday 15 August 2016 02:43 PM, Peter Chen wrote:
Hi all,
This is a follow-up for my last power sequence framework patch set [1].
According to Rob Herring and Ulf Hansson's comments[2], I use a generic
power sequence library for parsing the power sequence elements on DT,
and implement
On Monday 15 August 2016 06:33 PM, Peter Chen wrote:
On Mon, Aug 15, 2016 at 11:31:10AM -0700, Vaibhav Hiremath wrote:
In case of HUB devices connected to USB ports, we may not have DT
node representing it inside USB, and when devices connected to hub
gets enumerated, call
On Monday 15 August 2016 06:33 PM, Peter Chen wrote:
On Mon, Aug 15, 2016 at 11:31:10AM -0700, Vaibhav Hiremath wrote:
In case of HUB devices connected to USB ports, we may not have DT
node representing it inside USB, and when devices connected to hub
gets enumerated, call
On Monday 15 August 2016 11:41 AM, Greg KH wrote:
On Mon, Aug 15, 2016 at 11:31:10AM -0700, Vaibhav Hiremath wrote:
In case of HUB devices connected to USB ports, we may not have DT
node representing it inside USB, and when devices connected to hub
gets enumerated, call
On Monday 15 August 2016 11:41 AM, Greg KH wrote:
On Mon, Aug 15, 2016 at 11:31:10AM -0700, Vaibhav Hiremath wrote:
In case of HUB devices connected to USB ports, we may not have DT
node representing it inside USB, and when devices connected to hub
gets enumerated, call
-> Call to usb_of_get_child_node() leads to NULL
pointer dereference as parent->dev.of_node = NULL,
as USB HUB DTS node may be empty.
Fix this NULL pointer dereference by adding check for pointer
device_node inside usb_of_get_child_node() fn.
Signed-off-by: Vaibhav Hiremath
-> Call to usb_of_get_child_node() leads to NULL
pointer dereference as parent->dev.of_node = NULL,
as USB HUB DTS node may be empty.
Fix this NULL pointer dereference by adding check for pointer
device_node inside usb_of_get_child_node() fn.
Signed-off-by: Vaibhav Hiremath
---
On Thursday 17 March 2016 03:48 PM, Linus Walleij wrote:
On Mon, Feb 22, 2016 at 1:14 PM, Geert Uytterhoeven
wrote:
On the Renesas Salvator-X development board, 3 GPIO pins are connected to both
push buttons and LEDs.
Not exactly related to buttons and leds,
but
On Thursday 17 March 2016 03:48 PM, Linus Walleij wrote:
On Mon, Feb 22, 2016 at 1:14 PM, Geert Uytterhoeven
wrote:
On the Renesas Salvator-X development board, 3 GPIO pins are connected to both
push buttons and LEDs.
Not exactly related to buttons and leds,
but recently I came across
On Tuesday 15 September 2015 05:58 PM, Ulf Hansson wrote:
On 7 September 2015 at 13:31, Vaibhav Hiremath
wrote:
Trivial patch-series, which fixes the tabbing issue in the driver,
uses the BIT macro for bit fields and prints notice on -EPROBE_DEFER
in sdhci_add_host() function on regulator
On Tuesday 15 September 2015 05:58 PM, Ulf Hansson wrote:
On 7 September 2015 at 13:31, Vaibhav Hiremath
<vaibhav.hirem...@linaro.org> wrote:
Trivial patch-series, which fixes the tabbing issue in the driver,
uses the BIT macro for bit fields and prints notice on -EPROBE
On Monday 14 September 2015 06:11 PM, Vaibhav Hiremath wrote:
On Monday 14 September 2015 04:04 PM, Ulf Hansson wrote:
On 14 September 2015 at 11:42, Vaibhav Hiremath
wrote:
On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote:
[...]
Could this be implemented by regulator API
On Monday 14 September 2015 04:04 PM, Ulf Hansson wrote:
On 14 September 2015 at 11:42, Vaibhav Hiremath
wrote:
On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote:
[...]
Could this be implemented by regulator API? From patch set 3/3, the
pxa1928
voltage_switch hook is to operate
On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote:
[...]
Could this be implemented by regulator API? From patch set 3/3, the
pxa1928
voltage_switch hook is to operate the IO pad registers, this seems not
belong
to the SDHC IP core.
Not quite sure whether regulator would be right
On Monday 14 September 2015 04:04 PM, Ulf Hansson wrote:
On 14 September 2015 at 11:42, Vaibhav Hiremath
<vaibhav.hirem...@linaro.org> wrote:
On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote:
[...]
Could this be implemented by regulator API? From patch set 3/3, the
p
On Monday 14 September 2015 06:11 PM, Vaibhav Hiremath wrote:
On Monday 14 September 2015 04:04 PM, Ulf Hansson wrote:
On 14 September 2015 at 11:42, Vaibhav Hiremath
<vaibhav.hirem...@linaro.org> wrote:
On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote:
[...]
On Monday 14 September 2015 03:00 PM, Ulf Hansson wrote:
[...]
Could this be implemented by regulator API? From patch set 3/3, the
pxa1928
voltage_switch hook is to operate the IO pad registers, this seems not
belong
to the SDHC IP core.
Not quite sure whether regulator would be right
On Saturday 12 September 2015 12:36 AM, Wolfram Sang wrote:
On Mon, Aug 24, 2015 at 11:29:36AM +0530, Vaibhav Hiremath wrote:
TWSI_ILCR & TWSI_IWCR registers are used to adjust clock rate
of standard & fast mode in pxa910/988; so this patch adds these two new
entries to "struct p
On Saturday 12 September 2015 12:23 AM, Wolfram Sang wrote:
On Mon, Aug 24, 2015 at 11:29:35AM +0530, Vaibhav Hiremath wrote:
From: Yi Zhang
Enable i2c module/unit before transmission and disable when it
finishes.
why?
It's because the i2c bus may be disturbed if the slave device
On Saturday 12 September 2015 12:23 AM, Wolfram Sang wrote:
On Mon, Aug 24, 2015 at 11:29:35AM +0530, Vaibhav Hiremath wrote:
From: Yi Zhang <yizh...@marvell.com>
Enable i2c module/unit before transmission and disable when it
finishes.
why?
It's because the i2c bus may be dis
On Saturday 12 September 2015 12:36 AM, Wolfram Sang wrote:
On Mon, Aug 24, 2015 at 11:29:36AM +0530, Vaibhav Hiremath wrote:
TWSI_ILCR & TWSI_IWCR registers are used to adjust clock rate
of standard & fast mode in pxa910/988; so this patch adds these two new
entries to "struct p
On Wednesday 09 September 2015 05:19 AM, Rob Herring wrote:
On 09/07/2015 06:18 AM, Vaibhav Hiremath wrote:
With support for pxa1928 family of devices , this patch
updates the binding document with compatible property
of "marvell,pxav3-1928-sdhci".
Signed-off-by: Vaibha
On Wednesday 09 September 2015 05:19 AM, Rob Herring wrote:
On 09/07/2015 06:18 AM, Vaibhav Hiremath wrote:
With support for pxa1928 family of devices , this patch
updates the binding document with compatible property
of "marvell,pxav3-1928-sdhci".
Signed-off-by: Vaibha
On Tuesday 08 September 2015 08:12 PM, Linus Walleij wrote:
On Mon, Sep 7, 2015 at 1:18 PM, Vaibhav Hiremath
wrote:
Different bus clock may need different pin setting.
For example, fast bus clock like 208Mhz need pin drive fast
while slow bus clock prefer pin drive slow to guarantee
signal
On Tuesday 08 September 2015 03:34 PM, Jisheng Zhang wrote:
On Tue, 8 Sep 2015 15:32:34 +0530
Vaibhav Hiremath wrote:
On Tuesday 08 September 2015 03:22 PM, Jisheng Zhang wrote:
On Tue, 8 Sep 2015 15:04:41 +0530
Vaibhav Hiremath wrote:
static const struct sdhci_ops
On Tuesday 08 September 2015 03:22 PM, Jisheng Zhang wrote:
On Tue, 8 Sep 2015 15:04:41 +0530
Vaibhav Hiremath wrote:
On Tuesday 08 September 2015 12:22 PM, Jisheng Zhang wrote:
On Mon, 7 Sep 2015 16:48:38 +0530
Vaibhav Hiremath wrote:
Different bus clock may need different pin
On Tuesday 08 September 2015 12:24 PM, Jisheng Zhang wrote:
On Mon, 7 Sep 2015 16:48:38 +0530
Vaibhav Hiremath wrote:
Different bus clock may need different pin setting.
For example, fast bus clock like 208Mhz need pin drive fast
while slow bus clock prefer pin drive slow to guarantee
On Tuesday 08 September 2015 12:23 PM, Jisheng Zhang wrote:
On Mon, 7 Sep 2015 16:48:39 +0530
Vaibhav Hiremath wrote:
From: Kevin Liu
IN case of MMC HS200 mode, current code does not enable
SD_CE_ATA_2.MMC_HS200 & SD_CE_ATA_2.MMC_CARD bit configurations.
So this patch updates the a
On Tuesday 08 September 2015 12:22 PM, Jisheng Zhang wrote:
On Mon, 7 Sep 2015 16:48:38 +0530
Vaibhav Hiremath wrote:
Different bus clock may need different pin setting.
For example, fast bus clock like 208Mhz need pin drive fast
while slow bus clock prefer pin drive slow to guarantee
On Tuesday 08 September 2015 12:22 PM, Jisheng Zhang wrote:
On Mon, 7 Sep 2015 16:48:38 +0530
Vaibhav Hiremath <vaibhav.hirem...@linaro.org> wrote:
Different bus clock may need different pin setting.
For example, fast bus clock like 208Mhz need pin drive fast
while slow bus clock pref
On Tuesday 08 September 2015 12:23 PM, Jisheng Zhang wrote:
On Mon, 7 Sep 2015 16:48:39 +0530
Vaibhav Hiremath <vaibhav.hirem...@linaro.org> wrote:
From: Kevin Liu <kl...@marvell.com>
IN case of MMC HS200 mode, current code does not enable
SD_CE_ATA_2.MMC_HS200 & SD_CE_AT
On Tuesday 08 September 2015 03:22 PM, Jisheng Zhang wrote:
On Tue, 8 Sep 2015 15:04:41 +0530
Vaibhav Hiremath <vaibhav.hirem...@linaro.org> wrote:
On Tuesday 08 September 2015 12:22 PM, Jisheng Zhang wrote:
On Mon, 7 Sep 2015 16:48:38 +0530
Vaibhav Hiremath <vaibhav.hirem...@l
On Tuesday 08 September 2015 03:34 PM, Jisheng Zhang wrote:
On Tue, 8 Sep 2015 15:32:34 +0530
Vaibhav Hiremath <vaibhav.hirem...@linaro.org> wrote:
On Tuesday 08 September 2015 03:22 PM, Jisheng Zhang wrote:
On Tue, 8 Sep 2015 15:04:41 +0530
Vaibhav Hiremath <vaibhav.hirem...@l
On Tuesday 08 September 2015 12:24 PM, Jisheng Zhang wrote:
On Mon, 7 Sep 2015 16:48:38 +0530
Vaibhav Hiremath <vaibhav.hirem...@linaro.org> wrote:
Different bus clock may need different pin setting.
For example, fast bus clock like 208Mhz need pin drive fast
while slow bus clock pref
On Tuesday 08 September 2015 08:12 PM, Linus Walleij wrote:
On Mon, Sep 7, 2015 at 1:18 PM, Vaibhav Hiremath
<vaibhav.hirem...@linaro.org> wrote:
Different bus clock may need different pin setting.
For example, fast bus clock like 208Mhz need pin drive fast
while slow bus clock pref
On Monday 07 September 2015 05:26 PM, Jisheng Zhang wrote:
On Mon, 7 Sep 2015 17:01:09 +0530
Vaibhav Hiremath wrote:
There were some coding style issues where spaces have been used instead
of tabs, for example, in macro definitions, alignment of function
declarations/definitions, etc
This patch adds kernel notice/message to sdhci_host_add() fn on
-EPROBE_DEFER.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 1dbe932..37a5cd5 100644
There were some coding style issues where spaces have been used instead
of tabs, for example, in macro definitions, alignment of function
declarations/definitions, etc...
This patch fixes all such occurrences in the code.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pxav3.c | 46
age patch into new one.
- changed error to kernel notice for EPROBE_DEFER in sdhci_add_host()
Note: This patch-series should get merged before another series -
[PATCH-v2 0/7] mmc: sdhci-pxav3: Enable support for PXA1928 SDCHI controller
Vaibhav Hiremath (3):
mmc: sdhci-pxav3: Fix tabbing is
Instead of using shift operation use BIT macro for bit field
definitions.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pxav3.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
index 7a07177
more differences, which would be added
as and when respective feature gets added to the driver.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pxav3.c | 62 ++
1 file changed, 51 insertions(+), 11 deletions(-)
diff --git a/drivers/mmc/host/sdhci
speed.
And selection of pin state is done based on timing mode.
Signed-off-by: Vaibhav Hiremath
Signed-off-by: Kevin Liu
---
drivers/mmc/host/sdhci-pxav3.c | 45 +-
1 file changed, 44 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pxav3
With support for pxa1928 family of devices , this patch
updates the binding document with compatible property
of "marvell,pxav3-1928-sdhci".
Signed-off-by: Vaibhav Hiremath
---
Documentation/devicetree/bindings/mmc/sdhci-pxa.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
(SDHCI_QUIRK2_MUST_SET_SDHCI_BUS_POWER),
which make sure that ->set_power() sets these fields.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pltfm.c | 3 +++
drivers/mmc/host/sdhci.c | 3 ++-
drivers/mmc/host/sdhci.h | 2 ++
3 files changed, 7 insertions(+), 1 deletion(-)
d
From: Kevin Liu
IN case of MMC HS200 mode, current code does not enable
SD_CE_ATA_2.MMC_HS200 & SD_CE_ATA_2.MMC_CARD bit configurations.
So this patch updates the above bit fields correctly.
Signed-off-by: Tim Wang
Signed-off-by: Kevin Liu
Signed-off-by: Vaibhav Hiremath
---
Card power is dependent on bus power, without that card
wouldn't respond (No CARD_INT). So this patch enables the
quirk SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pltfm.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
controller/platform
specific clock configuration needs to be executed.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pxav3.c | 46 +-
1 file changed, 45 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdh
ix HS200 mode support
Vaibhav Hiremath (6):
mmc: sdhci-pxav3: Enable pxa1928 device support
mmc: sdhci-pxav3: binding: Add pxa1928 compatible support
mmc: sdhci-pxav3: Add platform specific set_clock ops
mmc: sdhci-pxav3: Add pinctl setting according to bus clock
mmc: sdhci: add new quir
On Friday 04 September 2015 09:02 PM, Vaibhav Hiremath wrote:
PXA1928 SDHCI controller has few differences, for example,
PXAxxxPXA1928
=====
SDCLK_DELAY field 0x10A
On Friday 04 September 2015 09:02 PM, Vaibhav Hiremath wrote:
PXA1928 SDHCI controller has few differences, for example,
PXAxxxPXA1928
=====
SDCLK_DELAY field 0x10A
ix HS200 mode support
Vaibhav Hiremath (6):
mmc: sdhci-pxav3: Enable pxa1928 device support
mmc: sdhci-pxav3: binding: Add pxa1928 compatible support
mmc: sdhci-pxav3: Add platform specific set_clock ops
mmc: sdhci-pxav3: Add pinctl setting according to bus clock
mmc: sdhci: add new quir
speed.
And selection of pin state is done based on timing mode.
Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org>
Signed-off-by: Kevin Liu <kl...@marvell.com>
---
drivers/mmc/host/sdhci-pxav3.c | 45 +-
1 file changed, 44 inse
With support for pxa1928 family of devices , this patch
updates the binding document with compatible property
of "marvell,pxav3-1928-sdhci".
Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org>
---
Documentation/devicetree/bindings/mmc/sdhci-pxa.txt | 2 +-
1 file chan
more differences, which would be added
as and when respective feature gets added to the driver.
Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org>
---
drivers/mmc/host/sdhci-pxav3.c | 62 ++
1 file changed, 51 insertions(+), 11 deletions(-)
On Monday 07 September 2015 05:26 PM, Jisheng Zhang wrote:
On Mon, 7 Sep 2015 17:01:09 +0530
Vaibhav Hiremath <vaibhav.hirem...@linaro.org> wrote:
There were some coding style issues where spaces have been used instead
of tabs, for example, in macro definitions, alignment of fu
Instead of using shift operation use BIT macro for bit field
definitions.
Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org>
---
drivers/mmc/host/sdhci-pxav3.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mm
age patch into new one.
- changed error to kernel notice for EPROBE_DEFER in sdhci_add_host()
Note: This patch-series should get merged before another series -
[PATCH-v2 0/7] mmc: sdhci-pxav3: Enable support for PXA1928 SDCHI controller
Vaibhav Hiremath (3):
mmc: sdhci-pxav3: Fix tabbing is
y: Kevin Liu <kl...@marvell.com>
Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org>
---
Note: Unfortunately I do not have access to any other datasheets
which uses sdhci-pxav3 driver, so quite not sure whether this would
break any existing platform, probably NOT, as I do not see an
(SDHCI_QUIRK2_MUST_SET_SDHCI_BUS_POWER),
which make sure that ->set_power() sets these fields.
Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org>
---
drivers/mmc/host/sdhci-pltfm.c | 3 +++
drivers/mmc/host/sdhci.c | 3 ++-
drivers/mmc/host/sdhci.h | 2 ++
3 files c
Card power is dependent on bus power, without that card
wouldn't respond (No CARD_INT). So this patch enables the
quirk SDHCI_QUIRK2_CARD_ON_NEEDS_BUS_ON.
Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org>
---
drivers/mmc/host/sdhci-pltfm.c | 3 ++-
1 file changed, 2 insertions
controller/platform
specific clock configuration needs to be executed.
Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org>
---
drivers/mmc/host/sdhci-pxav3.c | 46 +-
1 file changed, 45 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host
There were some coding style issues where spaces have been used instead
of tabs, for example, in macro definitions, alignment of function
declarations/definitions, etc...
This patch fixes all such occurrences in the code.
Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org>
---
d
This patch adds kernel notice/message to sdhci_host_add() fn on
-EPROBE_DEFER.
Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org>
---
drivers/mmc/host/sdhci.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/s
(SDHCI_QUIRK2_MUST_SET_SDHCI_BUS_POWER),
which make sure that ->set_power() sets these fields.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pltfm.c | 3 +++
drivers/mmc/host/sdhci.c | 3 ++-
drivers/mmc/host/sdhci.h | 2 ++
3 files changed, 7 insertions(+), 1 deletion(-)
d
speed.
And selection of pin state is done based on timing mode.
Signed-off-by: Vaibhav Hiremath
Signed-off-by: Kevin Liu
---
drivers/mmc/host/sdhci-pxav3.c | 45 +-
1 file changed, 44 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pxav3
From: Kevin Liu
IN case of MMC HS200 mode, current code does not enable
SD_CE_ATA_2.MMC_HS200 & SD_CE_ATA_2.MMC_CARD bit configurations.
So this patch updates the above bit fields correctly.
Signed-off-by: Tim Wang
Signed-off-by: Kevin Liu
Signed-off-by: Vaibhav Hiremath
---
more differences, which would be added
as and when respective feature gets added to the driver.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pxav3.c | 62 ++
1 file changed, 51 insertions(+), 11 deletions(-)
diff --git a/drivers/mmc/host/sdhci
controller/platform
specific clock configuration needs to be executed.
Signed-off-by: Vaibhav Hiremath
---
drivers/mmc/host/sdhci-pxav3.c | 46 +-
1 file changed, 45 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdh
(1):
mmc: sdhci-pxav3: Fix HS200 mode support
Vaibhav Hiremath (4):
mmc: sdhci-pxav3: Enable pxa1928 device support
mmc: sdhci-pxav3: Add platform specific set_clock ops
mmc: sdhci-pxav3: Add pinctl setting according to bus clock
mmc: sdhci: add new quirk for setting BUS_POWER &
(SDHCI_QUIRK2_MUST_SET_SDHCI_BUS_POWER),
which make sure that ->set_power() sets these fields.
Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org>
---
drivers/mmc/host/sdhci-pltfm.c | 3 +++
drivers/mmc/host/sdhci.c | 3 ++-
drivers/mmc/host/sdhci.h | 2 ++
3 files c
speed.
And selection of pin state is done based on timing mode.
Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org>
Signed-off-by: Kevin Liu <kl...@marvell.com>
---
drivers/mmc/host/sdhci-pxav3.c | 45 +-
1 file changed, 44 inse
y: Kevin Liu <kl...@marvell.com>
Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org>
---
Note: Unfortunately I do not have access to any other datasheets
which uses sdhci-pxav3 driver, so quite not sure whether this would
break any existing platform, probably NOT, as I do not see an
controller/platform
specific clock configuration needs to be executed.
Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org>
---
drivers/mmc/host/sdhci-pxav3.c | 46 +-
1 file changed, 45 insertions(+), 1 deletion(-)
diff --git a/drivers/mmc/host
more differences, which would be added
as and when respective feature gets added to the driver.
Signed-off-by: Vaibhav Hiremath <vaibhav.hirem...@linaro.org>
---
drivers/mmc/host/sdhci-pxav3.c | 62 ++
1 file changed, 51 insertions(+), 11 deletions(-)
(1):
mmc: sdhci-pxav3: Fix HS200 mode support
Vaibhav Hiremath (4):
mmc: sdhci-pxav3: Enable pxa1928 device support
mmc: sdhci-pxav3: Add platform specific set_clock ops
mmc: sdhci-pxav3: Add pinctl setting according to bus clock
mmc: sdhci: add new quirk for setting BUS_POWER &
On Wednesday 02 September 2015 07:21 PM, Shawn Lin wrote:
On 2015/9/2 3:32, Vaibhav Hiremath wrote:
In case PXA1928 family of devices, there is device/controller specific
configuration to control voltage/power on the IO pins.
This patch implements and enables the sdhci_ops->voltage_swi
On Wednesday 02 September 2015 07:21 PM, Shawn Lin wrote:
On 2015/9/2 3:32, Vaibhav Hiremath wrote:
In case PXA1928 family of devices, there is device/controller specific
configuration to control voltage/power on the IO pins.
This patch implements and enables the sdhci_ops->voltage_swi
On Wednesday 02 September 2015 08:37 PM, Joe Perches wrote:
On Wed, 2015-09-02 at 18:37 +0530, Vaibhav Hiremath wrote:
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote:
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
Return value would give clear information about
On Wednesday 02 September 2015 07:21 PM, Shawn Lin wrote:
On 2015/9/2 3:32, Vaibhav Hiremath wrote:
In case PXA1928 family of devices, there is device/controller specific
configuration to control voltage/power on the IO pins.
This patch implements and enables the sdhci_ops->voltage_swi
On Wednesday 02 September 2015 02:07 AM, Joe Perches wrote:
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
Return value would give clear information about the actual root-cause
of the failure.
diff --git a/drivers/mmc/host/sdhci-pxav3.c b/drivers/mmc/host/sdhci-pxav3.c
@@ -455,7
On Wednesday 02 September 2015 02:01 AM, Joe Perches wrote:
On Wed, 2015-09-02 at 00:54 +0530, Vaibhav Hiremath wrote:
There were some coding style issues where spaces have been used instead
of tabs, for example, in macro definitions, alignment of function
declarations/definitions, etc
1 - 100 of 612 matches
Mail list logo