Re: [PATCH] fs/quota.c build fix (Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded)

2007-06-21 Thread Vasily Tarasov
On Wed, 2007-06-20 at 20:45 +0200, Michal Piotrowski wrote: > [EMAIL PROTECTED] pisze: > > The mm snapshot broken-out-2007-06-20-10-12.tar.gz has been uploaded to > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-06-20-10-12.tar.gz > > it was my fault, sorry.

Re: [PATCH] fs/quota.c build fix (Re: mm snapshot broken-out-2007-06-20-10-12.tar.gz uploaded)

2007-06-21 Thread Vasily Tarasov
On Wed, 2007-06-20 at 20:45 +0200, Michal Piotrowski wrote: [EMAIL PROTECTED] pisze: The mm snapshot broken-out-2007-06-20-10-12.tar.gz has been uploaded to ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/mm/broken-out-2007-06-20-10-12.tar.gz it was my fault, sorry. Thank you

[PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-18 Thread Vasily Tarasov
From: Vasily Tarasov <[EMAIL PROTECTED]> This patch should be applied after Arnd Bergmann's patch, that intoduces new compat types: http://lkml.org/lkml/2007/6/15/98 OpenVZ Linux kernel team has discovered the problem with 32bit quota tools working on 64bit architectures. In 2.6.10

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-18 Thread Vasily Tarasov
On Fri, 2007-06-15 at 17:24 +0200, Arnd Bergmann wrote: > On Friday 15 June 2007, Vasily Tarasov wrote: > > I just noticed that we can not avoid the addition of packed attribute. > > Look, for example: > > > > struct if_dqblk { > > __u64 dqb_bhardlimit;

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-18 Thread Vasily Tarasov
On Fri, 2007-06-15 at 17:24 +0200, Arnd Bergmann wrote: On Friday 15 June 2007, Vasily Tarasov wrote: I just noticed that we can not avoid the addition of packed attribute. Look, for example: struct if_dqblk { __u64 dqb_bhardlimit; __u64 dqb_bsoftlimit

[PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-18 Thread Vasily Tarasov
From: Vasily Tarasov [EMAIL PROTECTED] This patch should be applied after Arnd Bergmann's patch, that intoduces new compat types: http://lkml.org/lkml/2007/6/15/98 OpenVZ Linux kernel team has discovered the problem with 32bit quota tools working on 64bit architectures. In 2.6.10 kernel

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
On Fri, 2007-06-15 at 12:43 +0200, Arnd Bergmann wrote: > On Friday 15 June 2007, Mikael Pettersson wrote: > > > --- linux-2.6.22-rc4-fixed/fs/quota.c.orig2007-06-14 > > > 15:55:26.0 +0400 > > > +++ linux-2.6.22-rc4-fixed/fs/quota.c 2007-06-14 19:50:13.0 +0400 > > ... > > >

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
On Fri, 2007-06-15 at 12:43 +0200, Arnd Bergmann wrote: > On Friday 15 June 2007, Mikael Pettersson wrote: > > > --- linux-2.6.22-rc4-fixed/fs/quota.c.orig2007-06-14 > > > 15:55:26.0 +0400 > > > +++ linux-2.6.22-rc4-fixed/fs/quota.c 2007-06-14 19:50:13.0 +0400 > > ... > > >

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
15 Jun 2007 13:01:48 +0400, Vasily Tarasov wrote: > > OpenVZ Linux kernel team has discovered the problem > > with 32bit quota tools working on 64bit architectures. > > In 2.6.10 kernel sys32_quotactl() function was replaced by sys_quotactl() > > with > > the comment &

[PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
From: Vasily Tarasov <[EMAIL PROTECTED]> OpenVZ Linux kernel team has discovered the problem with 32bit quota tools working on 64bit architectures. In 2.6.10 kernel sys32_quotactl() function was replaced by sys_quotactl() with the comment "sys_quotactl seems to be 32/64bit cl

[PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
From: Vasily Tarasov <[EMAIL PROTECTED]> OpenVZ Linux kernel team has discovered the problem with 32bit quota tools working on 64bit architectures. In 2.6.10 kernel sys32_quotactl() function was replaced by sys_quotactl() with the comment "sys_quotactl seems to be 32/64bit cl

[PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
From: Vasily Tarasov [EMAIL PROTECTED] OpenVZ Linux kernel team has discovered the problem with 32bit quota tools working on 64bit architectures. In 2.6.10 kernel sys32_quotactl() function was replaced by sys_quotactl() with the comment sys_quotactl seems to be 32/64bit clean, enable

[PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
From: Vasily Tarasov [EMAIL PROTECTED] OpenVZ Linux kernel team has discovered the problem with 32bit quota tools working on 64bit architectures. In 2.6.10 kernel sys32_quotactl() function was replaced by sys_quotactl() with the comment sys_quotactl seems to be 32/64bit clean, enable

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
2007 13:01:48 +0400, Vasily Tarasov wrote: OpenVZ Linux kernel team has discovered the problem with 32bit quota tools working on 64bit architectures. In 2.6.10 kernel sys32_quotactl() function was replaced by sys_quotactl() with the comment sys_quotactl seems to be 32/64bit clean

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
On Fri, 2007-06-15 at 12:43 +0200, Arnd Bergmann wrote: On Friday 15 June 2007, Mikael Pettersson wrote: --- linux-2.6.22-rc4-fixed/fs/quota.c.orig2007-06-14 15:55:26.0 +0400 +++ linux-2.6.22-rc4-fixed/fs/quota.c 2007-06-14 19:50:13.0 +0400 ... +#if

Re: [PATCH] diskquota: 32bit quota tools on 64bit architectures

2007-06-15 Thread Vasily Tarasov
On Fri, 2007-06-15 at 12:43 +0200, Arnd Bergmann wrote: On Friday 15 June 2007, Mikael Pettersson wrote: --- linux-2.6.22-rc4-fixed/fs/quota.c.orig2007-06-14 15:55:26.0 +0400 +++ linux-2.6.22-rc4-fixed/fs/quota.c 2007-06-14 19:50:13.0 +0400 ... +#if

Re: [PATCH] cfq: get rid of cfqq hash

2007-04-25 Thread Vasily Tarasov
>> @@ -1806,7 +1765,11 @@ static int cfq_may_queue(request_queue_t >> * so just lookup a possibly existing queue, or return 'may queue' >> * if that fails >> */ >> -cfqq = cfq_find_cfq_hash(cfqd, key, tsk->ioprio); >> +cic = cfq_get_io_context_noalloc(cfqd, tsk); >> +

Re: [PATCH] cfq: get rid of cfqq hash

2007-04-25 Thread Vasily Tarasov
From: Vasily Tarasov <[EMAIL PROTECTED]> >> -if (key != CFQ_KEY_ASYNC) >> +if (!is_sync) >> cfq_mark_cfqq_idle_window(cfqq); >> +else >> +cfq_mark_cfqq_sync(cfqq); > >

Re: [PATCH] cfq: get rid of cfqq hash

2007-04-25 Thread Vasily Tarasov
From: Vasily Tarasov [EMAIL PROTECTED] -if (key != CFQ_KEY_ASYNC) +if (!is_sync) cfq_mark_cfqq_idle_window(cfqq); +else +cfq_mark_cfqq_sync(cfqq); Woops, should be if (is_sync

Re: [PATCH] cfq: get rid of cfqq hash

2007-04-25 Thread Vasily Tarasov
@@ -1806,7 +1765,11 @@ static int cfq_may_queue(request_queue_t * so just lookup a possibly existing queue, or return 'may queue' * if that fails */ -cfqq = cfq_find_cfq_hash(cfqd, key, tsk-ioprio); +cic = cfq_get_io_context_noalloc(cfqd, tsk); +if (!cic) +

[PATCH] cfq: get rid of cfqq hash

2007-04-24 Thread Vasily Tarasov
From: Vasily Tarasov <[EMAIL PROTECTED]> cfq hash is no more necessary. We always can get cfqq from io context. cfq_get_io_context_noalloc() function is introduced, because we don't want to allocate cic on merging and checking may_queue. In order to identify sync queue we've used ha

Re: [PATCH] cfq: get rid of cfqq hash

2007-04-24 Thread Vasily Tarasov
>> From: Vasily Tarasov <[EMAIL PROTECTED]> >> >> cfq hash is no more necessary. We always can get cfqq from io context. >> cfq_get_io_context_noalloc() function is introduced, because we don't want >> to >> allocate cic on merging and checking may_queue

[PATCH] cfq: get rid of cfqq hash

2007-04-24 Thread Vasily Tarasov
From: Vasily Tarasov <[EMAIL PROTECTED]> cfq hash is no more necessary. We always can get cfqq from io context. cfq_get_io_context_noalloc() function is introduced, because we don't want to allocate cic on merging and checking may_queue. In order to identify sync queue we've used ha

[PATCH] cfq: get rid of cfqq hash

2007-04-24 Thread Vasily Tarasov
From: Vasily Tarasov [EMAIL PROTECTED] cfq hash is no more necessary. We always can get cfqq from io context. cfq_get_io_context_noalloc() function is introduced, because we don't want to allocate cic on merging and checking may_queue. In order to identify sync queue we've used hash key

Re: [PATCH] cfq: get rid of cfqq hash

2007-04-24 Thread Vasily Tarasov
From: Vasily Tarasov [EMAIL PROTECTED] cfq hash is no more necessary. We always can get cfqq from io context. cfq_get_io_context_noalloc() function is introduced, because we don't want to allocate cic on merging and checking may_queue. In order to identify sync queue we've used hash key

[PATCH] cfq: get rid of cfqq hash

2007-04-24 Thread Vasily Tarasov
From: Vasily Tarasov [EMAIL PROTECTED] cfq hash is no more necessary. We always can get cfqq from io context. cfq_get_io_context_noalloc() function is introduced, because we don't want to allocate cic on merging and checking may_queue. In order to identify sync queue we've used hash key

[PATCH] block: blk_max_pfn is somtimes wrong

2007-02-08 Thread Vasily Tarasov
max_pfn. And the same for blk_max_low_pfn. The patch also cleanses some checks related with bounce_pfn. Signed-off-by: Vasily Tarasov <[EMAIL PROTECTED]> --- --- ./block/ll_rw_blk.c.max_pfn 2007-01-10 03:35:11.0 +0300 +++ ./block/ll_rw_blk.c 2007-02-08 14:42:48.0 +0300

[PATCH] block: blk_max_pfn is somtimes wrong

2007-02-08 Thread Vasily Tarasov
for blk_max_low_pfn. The patch also cleanses some checks related with bounce_pfn. Signed-off-by: Vasily Tarasov [EMAIL PROTECTED] --- --- ./block/ll_rw_blk.c.max_pfn 2007-01-10 03:35:11.0 +0300 +++ ./block/ll_rw_blk.c 2007-02-08 14:42:48.0 +0300 @@ -1221,7 +1221,7 @@ void blk_recount_segments

[PATCH] cfq: wrong sync writes detection

2006-12-11 Thread Vasily Tarasov
false return task->pid; return CFQ_KEY_ASYNC; } The following patch fixes the bug by adding sync parameter, wich is obtained through bio_sync macros. Signed-off-by: Vasily Tarasov <[EMAIL PROTECTED]> -- --- ./block/cfq-iosched.c.syncwrite 2006-09-20 07:42:06.

[PATCH] cfq: wrong sync writes detection

2006-12-11 Thread Vasily Tarasov
return task-pid; return CFQ_KEY_ASYNC; } The following patch fixes the bug by adding sync parameter, wich is obtained through bio_sync macros. Signed-off-by: Vasily Tarasov [EMAIL PROTECTED] -- --- ./block/cfq-iosched.c.syncwrite 2006-09-20 07:42:06.0 +0400

[PATCH] mounstats NULL pointer dereference

2006-11-18 Thread Vasily Tarasov
SS:ESP 0068:f4105eb4 The problem is that task->nsproxy can be equal NULL for some time during task exit. This patch fixes the BUG. Signed-off-by: Vasily Tarasov <[EMAIL PROTECTED]> -- --- ./fs/proc/base.c.mountstatsfix 2006-11-18 02:43:48.0 +0300 +++ ./fs/proc/base.c2

[PATCH] mounstats NULL pointer dereference

2006-11-18 Thread Vasily Tarasov
b0 01 86 83 a0 04 00 00 f0 ff 4b EIP: [c01a6b70] mountstats_open+0x70/0xf0 SS:ESP 0068:f4105eb4 The problem is that task-nsproxy can be equal NULL for some time during task exit. This patch fixes the BUG. Signed-off-by: Vasily Tarasov [EMAIL PROTECTED] -- --- ./fs/proc/base.c.mountstatsfix