On Thu, 16 Jul 2020 at 16:24, Lukasz Luba wrote:
>
> Hi Peter,
>
> Thank you for summarizing this. I've put my comments below.
>
> On 7/16/20 12:56 PM, Peter Zijlstra wrote:
> > On Tue, Jul 14, 2020 at 12:06:53PM +0530, Viresh Kumar wrote:
> >> /**
> >> + * get_load() - get current load for a
On Fri, 10 Jul 2020 at 21:59, Patrick Bellasi
wrote:
>
>
> On Fri, Jul 10, 2020 at 15:21:48 +0200, Vincent Guittot
> wrote...
>
> > Hi Patrick,
>
> Hi Vincent,
>
> [...]
>
> >> > C) Existing control paths
> >>
> >> Assuming:
s,
> Valentin
>
> [1]: https://lkml.kernel.org/r/20200603173150.gb1...@shell.armlinux.org.uk
>
> Revisions
> =
>
> v1 -> v2
>
>
> o Remove cpufreq_cooling.c weak function; use #define stub in sched/topology.h
> (Vincent)
Looks good to me.
Reviewed-b
PUs and running tasks on heterogenous
system.
We can't simply ensure that task_h_load() returns at least one because it
would imply to handle underflow in other places.
Signed-off-by: Vincent Guittot
Reviewed-by: Valentin Schneider
Reviewed-by: Dietmar Eggemann
Tested-by: Dietmar Eggemann
Cc: # v
Hi Patrick,
On Tue, 23 Jun 2020 at 09:49, Patrick Bellasi
wrote:
>
>
> On Tue, Jun 23, 2020 at 09:29:03 +0200, Patrick Bellasi
> wrote...
>
> > .:: Scheduler Wakeup Path Requirements Collection Template
> > ==
> >
> > A) Name
>
> Runtime
On Fri, 10 Jul 2020 at 14:08, Tao Zhou wrote:
>
> Hi Vincent,
>
> Sorry for this so late reply.
>
> On Tue, Jun 30, 2020 at 04:22:10PM +0200, Vincent Guittot wrote:
> > Hi Tao,
> >
> > On Tue, 30 Jun 2020 at 11:41, Tao Zhou wrote:
> > >
> > &
PUs and running tasks on heterogenous
system.
We can't simply ensure that task_h_load() returns at least one because it
would imply to handle underflow in other places.
Signed-off-by: Vincent Guittot
Reviewed-by: Valentin Schneider
Reviewed-by: Dietmar Eggemann
Tested-by: Dietmar Eggemann
Cc: # v
On Thu, 9 Jul 2020 at 15:34, Dietmar Eggemann wrote:
>
> On 08/07/2020 11:47, Vincent Guittot wrote:
> > On Wed, 8 Jul 2020 at 11:45, Dietmar Eggemann
> > wrote:
> >>
> >> On 02/07/2020 16:42, Vincent Guittot wrote:
> >>> task_h_load() can re
On Thu, 9 Jul 2020 at 15:06, Valentin Schneider
wrote:
>
>
> On 02/07/20 15:42, Vincent Guittot wrote:
> > task_h_load() can return 0 in some situations like running stress-ng
> > mmapfork, which forks thousands of threads, in a sched group on a 224 cores
> > syste
On Wed, 8 Jul 2020 at 11:45, Dietmar Eggemann wrote:
>
> On 02/07/2020 16:42, Vincent Guittot wrote:
> > task_h_load() can return 0 in some situations like running stress-ng
> > mmapfork, which forks thousands of threads, in a sched group on a 224 cores
> > system. The loa
On Thu, 2 Jul 2020 at 18:28, Vincent Guittot wrote:
>
> On Thu, 2 Jul 2020 at 18:11, Valentin Schneider
> wrote:
> >
> >
> > On 02/07/20 15:42, Vincent Guittot wrote:
> > > task_h_load() can return 0 in some situations like running stress-ng
> > &g
On Mon, 6 Jul 2020 at 12:41, Qais Yousef wrote:
>
> On 07/03/20 14:09, Vincent Guittot wrote:
> > I have run the perf bench sched pipe that have have already run
> > previously with this v6 and the results are similar to my previous
> > tests:
> > The impact i
On Sun, 5 Jul 2020 at 16:19, Valentin Schneider
wrote:
>
>
> Sorry for getting back to this only now;
>
> On 22/06/20 09:37, Vincent Guittot wrote:
> > On Sun, 21 Jun 2020 at 00:28, Valentin Schneider
> > wrote:
> >> On 20/06/20 18:49, Ionela Voinescu wrote:
Hi Peter,
On Thu, 2 Jul 2020 at 14:52, Peter Zijlstra wrote:
>
>
> Dave hit the problem fixed by commit:
>
> b6e13e85829f ("sched/core: Fix ttwu() race")
>
> and failed to understand much of the code involved. Per his request a
> few comments to (hopefully) clarify things.
>
> Requested-by:
* Fix sparse warning reported by the test robot.
>
> * Add an extra commit about using static_branch_likely() instead of
> static_branch_unlikely().
>
> Thanks
>
> --
> Qais Yousef
>
> Cc: Juri Lelli
> Cc: Vincent Guittot
> Cc: Dietmar Eggemann
On Thu, 2 Jul 2020 at 18:11, Valentin Schneider
wrote:
>
>
> On 02/07/20 15:42, Vincent Guittot wrote:
> > task_h_load() can return 0 in some situations like running stress-ng
> > mmapfork, which forks thousands of threads, in a sched group on a 224 cores
> > syste
PUs and running tasks on heterogenous
system.
We can't simply ensure that task_h_load() returns at least one because it
would imply to handle underrun in other places.
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 18 +-
1 file changed, 17 insertions(+), 1 deletion(-)
d
On Thu, 2 Jul 2020 at 15:29, Mel Gorman wrote:
>
> On Thu, Jul 02, 2020 at 11:27:52AM +0200, Dietmar Eggemann wrote:
> > On 17/06/2020 16:52, Peter Puhov wrote:
> > > On Wed, 17 Jun 2020 at 06:50, Valentin Schneider
> > > wrote:
> > >>
> > >>
> > >> On 16/06/20 17:48, peter.pu...@linaro.org
On Wed, 1 Jul 2020 at 12:07, Zijun Hu wrote:
>
> sched_entity @se not static @left should be compared
> to pick up @cfs_rq->next.
Could you elaborate why ?
left is the leftmost sched_entity and the one that should be used.
se != left means that left should be skipped after a yield and the
next
Hi Tao,
On Tue, 30 Jun 2020 at 11:41, Tao Zhou wrote:
>
> Hi,
>
> On Tue, Jun 30, 2020 at 09:43:11AM +0200, Vincent Guittot wrote:
> > Hi Tao,
> >
> > Le lundi 15 juin 2020 à 16:14:01 (+0800), Xing Zhengjun a écrit :
> > >
> > >
> > > On 6
Hi Tao,
Le lundi 15 juin 2020 à 16:14:01 (+0800), Xing Zhengjun a écrit :
>
>
> On 6/15/2020 1:18 PM, Tao Zhou wrote:
...
> I apply the patch based on v5.7, the regression still existed.
Could you try the patch below ? This patch is not a real fix because it
impacts performance of others
On Thu, 25 Jun 2020 at 12:42, Holger Hoffstätte
wrote:
>
> On 2020-06-25 11:56, Vincent Guittot wrote:
> > On Thu, 25 Jun 2020 at 11:24, Holger Hoffstätte
> > wrote:
> >>
> >> On 2020-06-24 17:44, Vincent Guittot wrote:
> >>> Some performanc
The following commit has been merged into the sched/urgent branch of tip:
Commit-ID: 68f7b5cc835de7d5b6c7696533c126018171e793
Gitweb:
https://git.kernel.org/tip/68f7b5cc835de7d5b6c7696533c126018171e793
Author:Vincent Guittot
AuthorDate:Wed, 24 Jun 2020 17:44:22 +02:00
On Thu, 25 Jun 2020 at 11:24, Holger Hoffstätte
wrote:
>
> On 2020-06-24 17:44, Vincent Guittot wrote:
> > Some performance regression on reaim benchmark have been raised with
> >commit 070f5e860ee2 ("sched/fair: Take into account runnable_avg to
> > classif
On Wed, 24 Jun 2020 at 18:32, Valentin Schneider
wrote:
>
>
> On 24/06/20 16:44, Vincent Guittot wrote:
> > Some performance regression on reaim benchmark have been raised with
> > commit 070f5e860ee2 ("sched/fair: Take into account runnable_avg to
> > clas
avg to classify
group")
Reported-by: kernel test robot
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 0424a0af5f87..45e467bf42fc 100644
--- a/kernel/sched/fair.c
+++ b
Hi Pavan,
On Wed, 24 Jun 2020 at 13:42, Pavan Kondeti wrote:
>
> Hi Vincent/Peter,
>
> in load_balance(), we derive env->loop_max based on rq->nr_running.
> When the busiest rq has both RT and CFS tasks, we do more loops in
> detach_tasks(). Is there any reason for not using
>
On Fri, 19 Jun 2020 at 09:15, Vincent Guittot
wrote:
>
> On Fri, 19 Jun 2020 at 06:55, Xing Zhengjun
> wrote:
> > On 6/17/2020 10:57 PM, Vincent Guittot wrote:
> > > Le mercredi 17 juin 2020 à 08:30:21 (+0800), Xing Zhengjun a écrit :
>
> ...
>
> >
On Tue, 23 Jun 2020 at 19:40, Dietmar Eggemann wrote:
>
> On 19/06/2020 19:20, Qais Yousef wrote> This series attempts to address the
> report that uclamp logic could be expensive
> > sometimes and shows a regression in netperf UDP_STREAM under certain
> > conditions.
> >
> > The first patch is
Hi Qais,
On Tue, 23 Jun 2020 at 17:44, Qais Yousef wrote:
>
> Hi Vincent
>
> On 06/11/20 14:01, Vincent Guittot wrote:
> > On Thu, 11 Jun 2020 at 12:24, Qais Yousef wrote:
>
> [...]
>
> > > > Strange because I have been able to trace them.
> > >
On Sun, 21 Jun 2020 at 00:28, Valentin Schneider
wrote:
>
>
> On 20/06/20 18:49, Ionela Voinescu wrote:
> > Hi Vincent,
> >
> > On Thursday 18 Jun 2020 at 17:03:24 (+0200), Vincent Guittot wrote:
> >> On Sun, 14 Jun 2020 at 03:10, Valentin Schneider
>
On Sat, 20 Jun 2020 at 19:49, Ionela Voinescu wrote:
>
> Hi Vincent,
>
> On Thursday 18 Jun 2020 at 17:03:24 (+0200), Vincent Guittot wrote:
> > On Sun, 14 Jun 2020 at 03:10, Valentin Schneider
> > wrote:
> [..]
> > > diff --git a/drivers/thermal/cpufre
On Fri, 19 Jun 2020 at 06:55, Xing Zhengjun
wrote:
> On 6/17/2020 10:57 PM, Vincent Guittot wrote:
> > Le mercredi 17 juin 2020 à 08:30:21 (+0800), Xing Zhengjun a écrit :
...
> > OK. So the regression disappears when the conditions on runnable_avg are
> > removed.
>
On Sun, 14 Jun 2020 at 03:10, Valentin Schneider
wrote:
>
> The following commit:
>
> 14533a16c46d ("thermal/cpu-cooling, sched/core: Move the
> arch_set_thermal_pressure() API to generic scheduler code")
>
> moved the definition of arch_set_thermal_pressure() to sched/core.c, but
> kept its
On Thu, 18 Jun 2020 at 04:45, Xing Zhengjun
wrote:
>
>
>
> >>
> >> This bench forks a new thread for each and every new step. But a newly
> >> forked
> >> threads start with a load_avg and a runnable_avg set to max whereas the
> >> threads
> >> are running shortly before exiting. This makes
Le mercredi 17 juin 2020 à 16:57:25 (+0200), Vincent Guittot a écrit :
> Le mercredi 17 juin 2020 à 08:30:21 (+0800), Xing Zhengjun a écrit :
> >
> >
> > On 6/16/2020 2:54 PM, Vincent Guittot wrote:
> > >
> > > Hi Xing,
> > >
> > >
Le mercredi 17 juin 2020 à 08:30:21 (+0800), Xing Zhengjun a écrit :
>
>
> On 6/16/2020 2:54 PM, Vincent Guittot wrote:
> >
> > Hi Xing,
> >
> > Le mardi 16 juin 2020 à 11:17:16 (+0800), Xing Zhengjun a écrit :
> > >
> > >
> > >
When encountering throttled cfs_rq, dequeue_throttle label can ensure
> se not to be NULL, and rq->nr_running remains unchanged, so we can also
> skip the early balance check.
>
> Signed-off-by: Peng Wang
Reviewed-by: Vincent Guittot
> ---
> kernel/sched/fair.c | 6 +++--
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 87e867b4269f29dac8190bca13912d08163a277f
Gitweb:
https://git.kernel.org/tip/87e867b4269f29dac8190bca13912d08163a277f
Author:Vincent Guittot
AuthorDate:Fri, 12 Jun 2020 17:47:03 +02:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 3ea2f097b17e13a8280f1f9386c331b326a3dbef
Gitweb:
https://git.kernel.org/tip/3ea2f097b17e13a8280f1f9386c331b326a3dbef
Author:Vincent Guittot
AuthorDate:Tue, 09 Jun 2020 14:37:48 +02:00
Hi Xing,
Le mardi 16 juin 2020 à 11:17:16 (+0800), Xing Zhengjun a écrit :
>
>
> On 6/15/2020 4:10 PM, Vincent Guittot wrote:
> > Hi Xing,
> >
> > Le lundi 15 juin 2020 à 15:26:59 (+0800), Xing Zhengjun a écrit :
> > >
> > >
&
On Mon, 15 Jun 2020 at 16:20, Peng Wang wrote:
>
> While looking at enqueue_task_fair and dequeue_task_fair, it occurred
> to me that dequeue_task_fair can also be optimized as Vincent described
> in commit 7d148be69e3a ("sched/fair: Optimize enqueue_task_fair()").
good point
>
>
Hi Xing,
Le lundi 15 juin 2020 à 15:26:59 (+0800), Xing Zhengjun a écrit :
>
>
> On 6/12/2020 7:06 PM, Hillf Danton wrote:
> >
> > On Fri, 12 Jun 2020 14:36:49 +0800 Xing Zhengjun wrote:
...
> > --- a/kernel/sched/fair.c
> > +++ b/kernel/sched/fair.c
> > @@ -8215,12 +8215,8 @@
Factorize in a single place the calculation of the divider to be used to
to compute *_avg from *_sum value
Suggested-by: Dietmar Eggemann
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 32 ++--
kernel/sched/pelt.c | 2 +-
kernel/sched/pelt.h | 5 +
3
On Fri, 12 Jun 2020 at 13:06, Hillf Danton wrote:
>
>
> On Fri, 12 Jun 2020 14:36:49 +0800 Xing Zhengjun wrote:
> > Hi Vincent,
> >
> >We test the regression still existed in v5.7, do you have time to
> > look at it? Thanks.
> >
> >
> >
Le vendredi 12 juin 2020 à 14:36:49 (+0800), Xing Zhengjun a écrit :
> Hi Vincent,
>
> We test the regression still existed in v5.7, do you have time to look at
> it? Thanks.
>
>
The commit 070f5e860ee2 moveis some cases from the state "group has spare
capacity" to
to the state "group is
Hi Xing
On Fri, 12 Jun 2020 at 08:36, Xing Zhengjun
wrote:
>
> Hi Vincent,
>
>We test the regression still existed in v5.7, do you have time to
> look at it? Thanks.
I'm going to have a look
Vincent
>
>
>
On Thu, 11 Jun 2020 at 12:24, Qais Yousef wrote:
>
> On 06/09/20 19:10, Vincent Guittot wrote:
> > On Mon, 8 Jun 2020 at 14:31, Qais Yousef wrote:
> > >
> > > On 06/04/20 14:14, Vincent Guittot wrote:
> > >
> > > [...]
> > >
> > >
On Mon, 8 Jun 2020 at 14:31, Qais Yousef wrote:
>
> On 06/04/20 14:14, Vincent Guittot wrote:
>
> [...]
>
> > I have tried your patch and I don't see any difference compared to
> > previous tests. Let me give you more details of my setup:
> > I create 3 levels of
143e1e28cb40 ("sched: Rework sched_domain topology definition")
> Signed-off-by: Peng Liu
Reviewed-by: Vincent Guittot
> ---
> kernel/sched/topology.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/sched/topology.c b/kernel/sched/top
H Qais,
Sorry for the late reply.
On Fri, 5 Jun 2020 at 12:45, Qais Yousef wrote:
>
> On 06/04/20 14:14, Vincent Guittot wrote:
> > I have tried your patch and I don't see any difference compared to
> > previous tests. Let me give you more details of my setup:
> > I cr
e in order to address remaining
ilb.
Reported-by: Peng Liu
Signed-off-by: Vincent Guittot
---
- Changes v2:
- use jiffies instead of incrementing nohz.next_balance to be sure of the
value. The change slipped out of the previous version.
kernel/sched/fair.c | 23 ++-
1 file c
e in order to address remaining
ilb.
Reported-by: Peng Liu
Signed-off-by: Vincent Guittot
---
I haven't added another patch to kick ilb in case of abort because benchmarks
haven't seen any benefit or some slow decrease of perfomance.
kernel/sched/fair.c | 23 ++-
1 file c
On Thu, 4 Jun 2020 at 10:57, Mel Gorman wrote:
>
> On Wed, Jun 03, 2020 at 07:06:18PM +0200, Vincent Guittot wrote:
> > > still exists, just the gap becomes smaller -
> > > release run1run2
> > > v5.44.324.3 <-- little
On Thu, 4 Jun 2020 at 17:38, Valentin Schneider
wrote:
>
>
> On 04/06/20 14:05, Thara Gopinath wrote:
> > On Thu, 4 Jun 2020 at 06:56, Valentin Schneider
> >>
> >> Right, s/defconfig/arch kconfig/ or somesuch.
> >>
> >
> > CPU_FREQ_THERMAL also has to be enabled for this to be effective.
> >
On Wed, 3 Jun 2020 at 18:52, Qais Yousef wrote:
>
> On 06/03/20 16:59, Vincent Guittot wrote:
> > When I want to stress the fast path i usually use "perf bench sched pipe -T
> > "
> > The tip/sched/core on my arm octo core gives the following results for
>
On Wed, 3 Jun 2020 at 21:59, Russell King - ARM Linux admin
wrote:
>
> On Wed, Jun 03, 2020 at 09:24:56PM +0200, Vincent Guittot wrote:
> > On Wed, 3 Jun 2020 at 20:45, Russell King - ARM Linux admin
> > wrote:
> > > It's a start. I'm still wondering
On Wed, 3 Jun 2020 at 20:45, Russell King - ARM Linux admin
wrote:
>
> On Wed, Jun 03, 2020 at 07:00:26PM +0100, Valentin Schneider wrote:
> >
> > On 03/06/20 18:31, Russell King - ARM Linux admin wrote:
> > > Hi,
> > >
> > > A new kernel configuration option ("SCHED_THERMAL_PRESSURE") was
> > >
Hi Oliver,
On Tue, 2 Jun 2020 at 16:11, Oliver Sang wrote:
>
> On Tue, Jun 02, 2020 at 01:23:19PM +0800, Oliver Sang wrote:
> > On Fri, May 29, 2020 at 07:26:01PM +0200, Vincent Guittot wrote:
> > > On Mon, 25 May 2020 at 10:02, Vincent Guittot
> > > wrote:
&g
On Wed, 3 Jun 2020 at 12:10, Mel Gorman wrote:
>
> On Wed, Jun 03, 2020 at 10:29:22AM +0200, Patrick Bellasi wrote:
> >
> > Hi Dietmar,
> > thanks for sharing these numbers.
> >
> > On Tue, Jun 02, 2020 at 18:46:00 +0200, Dietmar Eggemann
> > wrote...
> >
> > [...]
> >
> > > I ran these tests
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Vincent Guittot
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 5c4a559d0dae..7158d4e3c855 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -8039,7 +8039,7 @@ static inl
>
> Signed-off-by: Dietmar Eggemann
Reviewed-by: Vincent Guittot
> ---
> kernel/sched/pelt.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/kernel/sched/pelt.c b/kernel/sched/pelt.c
> index b4b1ff96642f..dea5567e4f72 100644
> --- a/kernel/sched/pelt.c
> +++ b/k
On Wed, 3 Jun 2020 at 09:34, Benjamin GAIGNARD wrote:
>
>
>
> On 6/2/20 3:35 PM, Valentin Schneider wrote:
> > On 02/06/20 12:37, Benjamin GAIGNARD wrote:
> >> On 6/2/20 11:31 AM, Valentin Schneider wrote:
> @@ -99,6 +100,8 @@ enum state {
>
> #define OVERRUN_ERROR_THRESHOLD 3
>
On Mon, 25 May 2020 at 10:02, Vincent Guittot
wrote:
>
> On Thu, 21 May 2020 at 10:28, Oliver Sang wrote:
> >
> > On Wed, May 20, 2020 at 03:04:48PM +0200, Vincent Guittot wrote:
> > > On Thu, 14 May 2020 at 19:09, Vincent Guittot
> > > wrote:
> > >
On Thu, 14 May 2020 at 11:26, john mathew wrote:
>
> From: John Mathew
>
> Add documentation for
> -scheduler overview
> -scheduler state transtion
> -CFS overview
> -scheduler data structs
>
> Add rst for scheduler APIs and modify sched/core.c
> to add kernel-doc comments.
>
> Suggested-by:
On Wed, 27 May 2020 at 13:17, Benjamin GAIGNARD
wrote:
>
>
>
> On 5/27/20 12:09 PM, Valentin Schneider wrote:
> > Hi Benjamin,
> >
> > On 26/05/20 16:16, Benjamin Gaignard wrote:
> >> A first round [1] of discussions and suggestions have already be done on
> >> this series but without found a
On Wed, 27 May 2020 at 13:28, Frederic Weisbecker wrote:
>
> On Wed, May 27, 2020 at 12:23:23PM +0200, Vincent Guittot wrote:
> > > -static void nohz_csd_func(void *info)
> > > -{
> > > - struct rq *rq = info;
> > > + flags = atomic_f
alization.
>
> Rework the nohz_idle_balance() trigger so that the release is in the
> IPI callback and thus guarantees the required serialization for the
> CSD.
>
> Fixes: 90b5363acd47 ("sched: Clean up scheduler_ipi()")
> Reported-by: Qian Cai
> Signed-off-by: Peter Zij
On Thu, 21 May 2020 at 10:28, Oliver Sang wrote:
>
> On Wed, May 20, 2020 at 03:04:48PM +0200, Vincent Guittot wrote:
> > On Thu, 14 May 2020 at 19:09, Vincent Guittot
> > wrote:
> > >
> > > Hi Oliver,
> > >
> > > On Thu, 14 May 2020 at 16:0
The following commit has been merged into the sched/urgent branch of tip:
Commit-ID: 39f23ce07b9355d05a64ae303ce20d1c4b92b957
Gitweb:
https://git.kernel.org/tip/39f23ce07b9355d05a64ae303ce20d1c4b92b957
Author:Vincent Guittot
AuthorDate:Wed, 13 May 2020 15:55:28 +02:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 95d685935a2edf209fc68f52494ede4a382a6c2b
Gitweb:
https://git.kernel.org/tip/95d685935a2edf209fc68f52494ede4a382a6c2b
Author:Vincent Guittot
AuthorDate:Wed, 06 May 2020 17:53:01 +02:00
The following commit has been merged into the sched/core branch of tip:
Commit-ID: 7d148be69e3a0eaa9d029a3c51b545e322116a99
Gitweb:
https://git.kernel.org/tip/7d148be69e3a0eaa9d029a3c51b545e322116a99
Author:Vincent Guittot
AuthorDate:Wed, 13 May 2020 15:55:02 +02:00
On Tue, 19 May 2020 at 12:28, Dietmar Eggemann wrote:
>
> On 06/05/2020 17:53, Vincent Guittot wrote:
>
> [...]
>
> > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> > index 02f323b85b6d..df3923a65162 100644
> > --- a/kernel/sched/fair.c
> > ++
On Wed, 13 May 2020 at 17:51, Tao Zhou wrote:
>
> Hi Vincent,
>
> Sorry for the duplicate.
>
> On Wed, May 13, 2020 at 03:55:02PM +0200, Vincent Guittot wrote:
> > enqueue_task_fair jumps to enqueue_throttle label when cfs_rq_of(se) is
> > throttled which means that
and
add an optimization in the last for_each_sched_entity loop.
Reported-by Tao Zhou
Reviewed-by: Phil Auld
Signed-off-by: Vincent Guittot
---
v3 changes:
- remove the unused enqueue variable
kernel/sched/fair.c | 42 ++
1 file changed, 30 insertions
Signed-off-by: Vincent Guittot
---
v3 changes:
- updated commit message
- removed an extra }
kernel/sched/fair.c | 39 +++
1 file changed, 19 insertions(+), 20 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 9a58874ef104
On Wed, 13 May 2020 at 15:18, Phil Auld wrote:
>
> On Wed, May 13, 2020 at 03:15:53PM +0200 Vincent Guittot wrote:
> > On Wed, 13 May 2020 at 15:13, Phil Auld wrote:
> > >
> > > On Wed, May 13, 2020 at 03:10:28PM +0200 Vincent Guittot wrote:
> > > > On W
On Wed, 13 May 2020 at 15:13, Phil Auld wrote:
>
> On Wed, May 13, 2020 at 03:10:28PM +0200 Vincent Guittot wrote:
> > On Wed, 13 May 2020 at 14:45, Phil Auld wrote:
> > >
> > > Hi Vincent,
> > >
> > > On Wed, May 13, 2020 at 02:33:35PM +0200
On Wed, 13 May 2020 at 14:45, Phil Auld wrote:
>
> Hi Vincent,
>
> On Wed, May 13, 2020 at 02:33:35PM +0200 Vincent Guittot wrote:
> > enqueue_task_fair jumps to enqueue_throttle label when cfs_rq_of(se) is
> > throttled which means that se can't be NULL and we can
On Wed, 13 May 2020 at 14:56, Phil Auld wrote:
>
> Hi Vincent,
>
> On Wed, May 13, 2020 at 02:34:22PM +0200 Vincent Guittot wrote:
> > Although not exactly identical, unthrottle_cfs_rq() and enqueue_task_fair()
> > are quite close and follow the same sequence
and
add an optimization in the last for_each_sched_entity loop.
Reported-by Tao Zhou
Reviewed-by: Phil Auld
Signed-off-by: Vincent Guittot
---
v2 changes:
- Remove useless if statement
kernel/sched/fair.c | 41 ++---
1 file changed, 30 insertions(+), 11
enqueue_task_fair jumps to enqueue_throttle label when cfs_rq_of(se) is
throttled which means that se can't be NULL and we can skip the test.
Reviewed-by: Phil Auld
Signed-off-by: Vincent Guittot
---
v2 changes:
- Remove useless if statement
kernel/sched/fair.c | 39
On Tue, 12 May 2020 at 20:59, wrote:
>
> Vincent Guittot writes:
>
> > Although not exactly identical, unthrottle_cfs_rq() and enqueue_task_fair()
> > are quite close and follow the same sequence for enqueuing an entity in the
> > cfs hierarchy. Modify unthrottle_cfs_r
s needed because se no longer points to the sched_entity which broke
> out of the first loop.
>
> Address this by calling leaf_add_rq_list if there are throttled parents while
> doing the second for_each_sched_entity loop.
>
Fixes: fe61468b2cb (sched/fair: Fix enqueue_task_fair warn
enqueue_task_fair() jumps to enqueue_throttle when cfs_rq_of(se) is
throttled, which means that se can't be NULL and we can skip the test.
Signed-off-by: Vincent Guittot
---
kernel/sched/fair.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/sched/fair.c b/kernel
On Mon, 11 May 2020 at 17:13, Tao Zhou wrote:
>
> Hi Vincent,
>
> On Mon, May 11, 2020 at 10:36:43AM +0200, Vincent Guittot wrote:
> > Hi Tao,
> >
> > On Fri, 8 May 2020 at 18:58, Tao Zhou wrote:
> > >
> > > On Fri, May 08, 2020 at 05:27:44PM +02
and
add an optimization in the last for_each_sched_entity loop.
Fixes: fe61468b2cb (sched/fair: Fix enqueue_task_fair warning)
Reported-by Tao Zhou
Signed-off-by: Vincent Guittot
---
This path applies on top of 20200507203612.gf19...@lorien.usersys.redhat.com
and fixes similar problem
On Mon, 11 May 2020 at 19:02, Dietmar Eggemann wrote:
>
> On 11/05/2020 14:12, Vincent Guittot wrote:
> > On Mon, 11 May 2020 at 12:39, Dietmar Eggemann
> > wrote:
> >>
> >> On 11/05/2020 11:36, Vincent Guittot wrote:
> >>> On Mon, 11 M
On Mon, 11 May 2020 at 12:39, Dietmar Eggemann wrote:
>
> On 11/05/2020 11:36, Vincent Guittot wrote:
> > On Mon, 11 May 2020 at 10:40, Dietmar Eggemann
> > wrote:
> >>
> >> On 08/05/2020 19:02, Tao Zhou wrote:
> >>> On Fri, May 08, 2020 at 05:27:
On Mon, 11 May 2020 at 10:40, Dietmar Eggemann wrote:
>
> On 08/05/2020 19:02, Tao Zhou wrote:
> > On Fri, May 08, 2020 at 05:27:44PM +0200, Vincent Guittot wrote:
> >> On Fri, 8 May 2020 at 17:12, Tao Zhou wrote:
> >>>
> >>> Hi Phil,
> >>
Hi Tao,
On Fri, 8 May 2020 at 18:58, Tao Zhou wrote:
>
> On Fri, May 08, 2020 at 05:27:44PM +0200, Vincent Guittot wrote:
> > On Fri, 8 May 2020 at 17:12, Tao Zhou wrote:
> > >
> > > Hi Phil,
> > >
> > > On Thu, May 07, 2020 at 04:36:12PM
On Fri, 8 May 2020 at 15:01, Peng Liu wrote:
>
> On Tue, May 05, 2020 at 04:27:11PM +0200, Vincent Guittot wrote:
> > Le mardi 05 mai 2020 à 21:40:56 (+0800), Peng Liu a écrit :
> >
>
> [...]
>
> >
> > Your proposal below looks quite complex. IMO, one soluti
ist if there are throttled parents
> > while
> > doing the second for_each_sched_entity loop.
>
> Thanks for your trace imformation and explanation. I
> truely have learned from this and that.
>
> s/leaf_add_rq_list/list_add_leaf_cfs_rq/
>
> >
> > Suggested-by: Vi
On Thu, 7 May 2020 at 20:04, Phil Auld wrote:
>
> Hi Vincent,
>
> On Thu, May 07, 2020 at 05:06:29PM +0200 Vincent Guittot wrote:
> > Hi Phil,
> >
> > On Wed, 6 May 2020 at 20:05, Phil Auld wrote:
> > >
> > > Hi Vincent,
> > >
> > &g
Hi Phil,
On Wed, 6 May 2020 at 20:05, Phil Auld wrote:
>
> Hi Vincent,
>
> Thanks for taking a look. More below...
>
> On Wed, May 06, 2020 at 06:36:45PM +0200 Vincent Guittot wrote:
> > Hi Phil,
> >
> > - reply to all this time
> >
> &g
On Thu, 7 May 2020 at 14:41, Peng Liu wrote:
>
> On Wed, May 06, 2020 at 05:02:56PM +0100, Valentin Schneider wrote:
> >
> > On 06/05/20 14:45, Vincent Guittot wrote:
> > >> But then we may skip an update if we goto abort, no? Imagine we have just
> > >
On Wed, 6 May 2020 at 18:03, Valentin Schneider
wrote:
>
>
> On 06/05/20 14:45, Vincent Guittot wrote:
> >> But then we may skip an update if we goto abort, no? Imagine we have just
> >> NOHZ_STATS_KICK, so we don't call any rebalance_domains(), and then as we
> &
on ?
> what is needed because se does not point to the sched_entity which broke out
> of the first loop.
>
> Address this issue by saving the se pointer when the first loop exits and
> resetting it before doing the fix up, if needed.
>
> Signed-off-by: Phil Auld
> Cc: Peter Z
. In fact,
we must keep them sync in order to stay also synced with others entities
and group entities that are already attached to the cfs_rq.
Signed-off-by: Vincent Guittot
---
I have added update_tg_cfs_load() because there is no reason that we don't
sync load_avg with load_sum even
On Wed, 6 May 2020 at 12:29, Valentin Schneider
wrote:
>
>
> On 05/05/20 15:27, Vincent Guittot wrote:
> > So I would be in favor of something as simple as :
> >
> > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> > index 04098d678f3b..e028bc1c4744 100
401 - 500 of 3961 matches
Mail list logo
