On Tue, Mar 24, 2015 at 05:18:14PM +0100, Ingo Molnar wrote:
>
> * Vivek Goyal wrote:
>
> > > Yet the actual bug is in that commit, 'crash_kexec_post_notifiers'
> > > was clearly not a no-op in the default case, against expectations.
> >
> > Hi Ingo,
>
On Tue, Mar 24, 2015 at 08:11:29AM +0100, Ingo Molnar wrote:
>
> * Masami Hiramatsu wrote:
>
> > (2015/03/23 16:19), Ingo Molnar wrote:
> > >
> > > * Baoquan He wrote:
> > >
> > >> CC more people ...
> > >>
> > >> On 03/07/15 at 01:31am, "Hatayama, Daisuke/畑山 大輔" wrote:
> > >>> The commit
On Tue, Mar 24, 2015 at 05:27:10AM -0500, Eric W. Biederman wrote:
> Ingo Molnar writes:
>
> > * Masami Hiramatsu wrote:
> >
> >> >
> >> > f06e5153f4ae ("kernel/panic.c: add "crash_kexec_post_notifiers" option
> >> > for kdump after panic_notifers")
> >> >
> >> > Was that crash_kexec() was
On Tue, Mar 24, 2015 at 05:27:10AM -0500, Eric W. Biederman wrote:
Ingo Molnar mi...@kernel.org writes:
* Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote:
f06e5153f4ae (kernel/panic.c: add crash_kexec_post_notifiers option
for kdump after panic_notifers)
Was that
On Tue, Mar 24, 2015 at 08:11:29AM +0100, Ingo Molnar wrote:
* Masami Hiramatsu masami.hiramatsu...@hitachi.com wrote:
(2015/03/23 16:19), Ingo Molnar wrote:
* Baoquan He b...@redhat.com wrote:
CC more people ...
On 03/07/15 at 01:31am, Hatayama, Daisuke/畑山 大輔 wrote:
On Tue, Mar 24, 2015 at 05:18:14PM +0100, Ingo Molnar wrote:
* Vivek Goyal vgo...@redhat.com wrote:
Yet the actual bug is in that commit, 'crash_kexec_post_notifiers'
was clearly not a no-op in the default case, against expectations.
Hi Ingo,
I did a quick test and in default
s
> ...
>
> If it crashed due to some hardware failure, there's literally an
> infinite amount of failure modes that may or may not be impacted by
> kexec crash-time handling ordering. We don't want to put a zillion
> such flags into the kernel proper just to allow the perturba
On Mon, Mar 23, 2015 at 02:50:46PM +0100, Ingo Molnar wrote:
>
> * Vivek Goyal wrote:
>
> > On Mon, Mar 23, 2015 at 08:19:43AM +0100, Ingo Molnar wrote:
> > >
> > > * Baoquan He wrote:
> > >
> > > > CC more people ...
> > > >
On Mon, Mar 23, 2015 at 08:19:43AM +0100, Ingo Molnar wrote:
>
> * Baoquan He wrote:
>
> > CC more people ...
> >
> > On 03/07/15 at 01:31am, "Hatayama, Daisuke/畑山 大輔" wrote:
> > > The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced
> > > "crash_kexec_post_notifiers" kernel boot
On Mon, Mar 23, 2015 at 08:19:43AM +0100, Ingo Molnar wrote:
* Baoquan He b...@redhat.com wrote:
CC more people ...
On 03/07/15 at 01:31am, Hatayama, Daisuke/畑山 大輔 wrote:
The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced
crash_kexec_post_notifiers kernel boot option,
On Mon, Mar 23, 2015 at 02:50:46PM +0100, Ingo Molnar wrote:
* Vivek Goyal vgo...@redhat.com wrote:
On Mon, Mar 23, 2015 at 08:19:43AM +0100, Ingo Molnar wrote:
* Baoquan He b...@redhat.com wrote:
CC more people ...
On 03/07/15 at 01:31am, Hatayama, Daisuke/畑山 大輔
crash_kexec_post_notifiers is specified on command
line. I have not tried running any notifiers. So.
Tested-by: Vivek Goyal vgo...@redhat.com
Acked-by: Vivek Goyal vgo...@redhat.com
This should be a general fix and not a replacement for the patch
in question in this mail thread.
Thanks
Vivek
diff
On Fri, Mar 13, 2015 at 02:04:37PM +0100, Borislav Petkov wrote:
> From: Borislav Petkov
>
> Make it much simpler without losing the gist of what it says.
>
> Signed-off-by: Borislav Petkov
> Cc: Thomas Gleixner
> Cc: Ingo Molnar
> Cc: "H. Peter Anvin"
>
. Peter Anvin h...@zytor.com
Cc: Andrew Morton a...@linux-foundation.org
Cc: Vivek Goyal vgo...@redhat.com
---
arch/x86/Kconfig | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
index 8f829ffb9003..8db84b0e5bbd 100644
xec_post_notifiers" in the condition of kexec_should_crash().
>
> Also, put a comment in kexec_should_crash() to explain not obvious
> things on this patch.
>
> Signed-off-by: HATAYAMA Daisuke
> Acked-by: Baoquan He
> Tested-by: Hidehiro Kawai
> Reviewed-by: Masami Hira
good to me.
Acked-by: Vivek Goyal vgo...@redhat.com
Thanks
Vivek
---
include/linux/kernel.h | 3 +++
kernel/kexec.c | 11 +++
kernel/panic.c | 2 +-
3 files changed, 15 insertions(+), 1 deletion(-)
diff --git a/include/linux/kernel.h b/include/linux/kernel.h
On Thu, Mar 05, 2015 at 05:19:30PM -0500, Vivek Goyal wrote:
> On Wed, Mar 04, 2015 at 05:56:48PM +0900, HATAYAMA Daisuke wrote:
> > The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced
> > "crash_kexec_post_notifiers" kernel boot option, which toggles
&
On Wed, Mar 04, 2015 at 05:56:48PM +0900, HATAYAMA Daisuke wrote:
> The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced
> "crash_kexec_post_notifiers" kernel boot option, which toggles
> wheather panic() calls crash_kexec() before or after panic_notifiers
> and dump kmsg.
>
> The
On Thu, Mar 05, 2015 at 05:19:30PM -0500, Vivek Goyal wrote:
On Wed, Mar 04, 2015 at 05:56:48PM +0900, HATAYAMA Daisuke wrote:
The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced
crash_kexec_post_notifiers kernel boot option, which toggles
wheather panic() calls crash_kexec
On Wed, Mar 04, 2015 at 05:56:48PM +0900, HATAYAMA Daisuke wrote:
The commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45 introduced
crash_kexec_post_notifiers kernel boot option, which toggles
wheather panic() calls crash_kexec() before or after panic_notifiers
and dump kmsg.
The problem is
s error using existing fallback oom_cfqq.
>
> Signed-off-by: Konstantin Khlebnikov
> ---
> block/cfq-iosched.c |7 ++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
Looks good to me. Thanks for the patch.
Acked-by: Vivek Goyal
Vivek
>
> diff --git a/block/cfq-io
-by: Konstantin Khlebnikov khlebni...@yandex-team.ru
---
block/cfq-iosched.c |7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
Looks good to me. Thanks for the patch.
Acked-by: Vivek Goyal vgo...@redhat.com
Vivek
diff --git a/block/cfq-iosched.c b/block/cfq-iosched.c
index 6f2751d
On Wed, Jan 28, 2015 at 10:10:59PM +, Scot Doyle wrote:
> On Wed, 28 Jan 2015, Vivek Goyal wrote:
> > On Wed, Jan 28, 2015 at 09:14:03PM +, Scot Doyle wrote:
> > > On Wed, 28 Jan 2015, Vivek Goyal wrote:
> > > > On Wed, Jan 28, 2015 at 04:49:34PM +01
On Wed, Jan 28, 2015 at 09:14:03PM +, Scot Doyle wrote:
> On Wed, 28 Jan 2015, Vivek Goyal wrote:
> > On Wed, Jan 28, 2015 at 04:49:34PM +0100, Michael Kerrisk (man-pages) wrote:
> > > Hello Vivek,
> > >
> > > >> I've made various adjustments
On Wed, Jan 28, 2015 at 09:04:38AM +0100, Michael Kerrisk (man-pages) wrote:
Hi Michael,
[..]
> >> * the number of bytes copied from userspace is min(bufsz, memsz)
> >
> > Yes. bufsz can not be more than memsz. There is a check to validate
> > this in kernel.
> >
> > result = -EINVAL;
> >
On Wed, Jan 28, 2015 at 04:49:34PM +0100, Michael Kerrisk (man-pages) wrote:
> [Dropping Andi into CC, which I should have done to start with, since
> he wrote the original page, and might also have some comments]
>
> Hello Vivek,
>
> >> I've made various adjustments to the page in the light of
On Wed, Jan 28, 2015 at 09:04:38AM +0100, Michael Kerrisk (man-pages) wrote:
Hi Michael,
[..]
* the number of bytes copied from userspace is min(bufsz, memsz)
Yes. bufsz can not be more than memsz. There is a check to validate
this in kernel.
result = -EINVAL;
for (i = 0;
On Wed, Jan 28, 2015 at 04:49:34PM +0100, Michael Kerrisk (man-pages) wrote:
[Dropping Andi into CC, which I should have done to start with, since
he wrote the original page, and might also have some comments]
Hello Vivek,
I've made various adjustments to the page in the light of your
On Wed, Jan 28, 2015 at 10:10:59PM +, Scot Doyle wrote:
On Wed, 28 Jan 2015, Vivek Goyal wrote:
On Wed, Jan 28, 2015 at 09:14:03PM +, Scot Doyle wrote:
On Wed, 28 Jan 2015, Vivek Goyal wrote:
On Wed, Jan 28, 2015 at 04:49:34PM +0100, Michael Kerrisk (man-pages)
wrote
On Wed, Jan 28, 2015 at 09:14:03PM +, Scot Doyle wrote:
On Wed, 28 Jan 2015, Vivek Goyal wrote:
On Wed, Jan 28, 2015 at 04:49:34PM +0100, Michael Kerrisk (man-pages) wrote:
Hello Vivek,
I've made various adjustments to the page in the light of your comments
above. Thanks
On Fri, Jan 16, 2015 at 02:30:25PM +0100, Michael Kerrisk (man-pages) wrote:
[..]
>
Hi Michael,
Please find my responses below. Sorry, I got stuck in other work and
forgot about this thread.
> So, returning to the kexeec_segment structure:
>
>struct kexec_segment {
>
On Fri, Jan 16, 2015 at 02:30:25PM +0100, Michael Kerrisk (man-pages) wrote:
[..]
Hi Michael,
Please find my responses below. Sorry, I got stuck in other work and
forgot about this thread.
So, returning to the kexeec_segment structure:
struct kexec_segment {
On Wed, Jan 07, 2015 at 10:17:56PM +0100, Michael Kerrisk (man-pages) wrote:
[..]
> >> .BR KEXEC_ON_CRASH " (since Linux 2.6.13)"
> >> Execute the new kernel automatically on a system crash.
> >> .\" FIXME Explain in more detail how KEXEC_ON_CRASH is actually used
>
> I wasn't expecting that you
On Mon, Jan 12, 2015 at 05:06:46PM +0100, Joerg Roedel wrote:
> On Mon, Jan 12, 2015 at 10:29:19AM -0500, Vivek Goyal wrote:
> > Kdump has the notion of backup region. Where certain parts of old kernels
> > memory can be moved to a different location (first 640K on x86 as of n
On Mon, Jan 12, 2015 at 04:22:08PM +0100, Joerg Roedel wrote:
> On Mon, Jan 12, 2015 at 03:06:20PM +0800, Li, Zhen-Hua wrote:
> > +
> > +#ifdef CONFIG_CRASH_DUMP
> > +
> > +/*
> > + * Fix Crashdump failure caused by leftover DMA through a hardware IOMMU
> > + *
> > + * Fixes the crashdump kernel
On Mon, Jan 12, 2015 at 04:22:08PM +0100, Joerg Roedel wrote:
On Mon, Jan 12, 2015 at 03:06:20PM +0800, Li, Zhen-Hua wrote:
+
+#ifdef CONFIG_CRASH_DUMP
+
+/*
+ * Fix Crashdump failure caused by leftover DMA through a hardware IOMMU
+ *
+ * Fixes the crashdump kernel to deal with an
On Mon, Jan 12, 2015 at 05:06:46PM +0100, Joerg Roedel wrote:
On Mon, Jan 12, 2015 at 10:29:19AM -0500, Vivek Goyal wrote:
Kdump has the notion of backup region. Where certain parts of old kernels
memory can be moved to a different location (first 640K on x86 as of now)
and new kernel can
On Wed, Jan 07, 2015 at 10:17:56PM +0100, Michael Kerrisk (man-pages) wrote:
[..]
.BR KEXEC_ON_CRASH (since Linux 2.6.13)
Execute the new kernel automatically on a system crash.
.\ FIXME Explain in more detail how KEXEC_ON_CRASH is actually used
I wasn't expecting that you would respond
On Fri, Jan 02, 2015 at 12:48:51PM -0600, Eric W. Biederman wrote:
> Alexander Kuleshov writes:
>
> > Signed-off-by: Alexander Kuleshov
> Acked-by: "Eric W. Biederman"
[ CC akpm ]
Simple fix.
Acked-by: Vivek Goyal
Thanks
Vivek
>
> > ---
> > kern
On Fri, Jan 02, 2015 at 12:48:51PM -0600, Eric W. Biederman wrote:
Alexander Kuleshov kuleshovm...@gmail.com writes:
Signed-off-by: Alexander Kuleshov kuleshovm...@gmail.com
Acked-by: Eric W. Biederman ebied...@xmission.com
[ CC akpm ]
Simple fix.
Acked-by: Vivek Goyal vgo...@redhat.com
On Wed, Nov 26, 2014 at 02:17:09PM +, David Howells wrote:
>
> Here's a set of patches that does the following:
>
I compiled the kernel with these patches and booted into this kernel
without any issues.
FWIW,
Tested-by: Vivek Goyal
Thanks
Vivek
> (1) Extracts both parts
On Wed, Nov 26, 2014 at 02:17:09PM +, David Howells wrote:
Here's a set of patches that does the following:
I compiled the kernel with these patches and booted into this kernel
without any issues.
FWIW,
Tested-by: Vivek Goyal vgo...@redhat.com
Thanks
Vivek
(1) Extracts both parts
On Thu, Nov 20, 2014 at 04:54:14PM +, David Howells wrote:
[..]
> @@ -215,21 +219,42 @@ static int pkcs7_verify_sig_chain(struct pkcs7_message
> *pkcs7,
> /* Look through the X.509 certificates in the PKCS#7 message's
>* list to see if the next one is there.
>
On Thu, Nov 20, 2014 at 04:54:03PM +, David Howells wrote:
[..]
> diff --git a/crypto/asymmetric_keys/x509_parser.h
> b/crypto/asymmetric_keys/x509_parser.h
> index 3dfe6b5d6f0b..223b72344060 100644
> --- a/crypto/asymmetric_keys/x509_parser.h
> +++ b/crypto/asymmetric_keys/x509_parser.h
>
On Thu, Nov 20, 2014 at 04:54:03PM +, David Howells wrote:
[..]
diff --git a/crypto/asymmetric_keys/x509_parser.h
b/crypto/asymmetric_keys/x509_parser.h
index 3dfe6b5d6f0b..223b72344060 100644
--- a/crypto/asymmetric_keys/x509_parser.h
+++ b/crypto/asymmetric_keys/x509_parser.h
@@
On Thu, Nov 20, 2014 at 04:54:14PM +, David Howells wrote:
[..]
@@ -215,21 +219,42 @@ static int pkcs7_verify_sig_chain(struct pkcs7_message
*pkcs7,
/* Look through the X.509 certificates in the PKCS#7 message's
* list to see if the next one is there.
Tejun Heo
> Cc: Jens Axboe
> Cc: Vivek Goyal
> ---
> block/bio.c | 24 +++-
> include/linux/bio.h |3 +++
> 2 files changed, 26 insertions(+), 1 deletion(-)
>
> --- a/block/bio.c
> +++ b/block/bio.c
> @@ -1981,6 +1981,
s associated with an online css for every subsystem except
> while the css_set update is propagating, task_get_css() retries till
> css_tryget_online() succeeds.
>
> This is a cleanup and shouldn't lead to noticeable behavior changes.
>
> Signed-off-by: Tejun Heo
> Cc: Li Zefan
&g
On Mon, Nov 17, 2014 at 04:13:57PM -0500, Tejun Heo wrote:
[..]
> --- a/include/linux/blkdev.h
> +++ b/include/linux/blkdev.h
> @@ -1408,6 +1408,9 @@ int kblockd_schedule_delayed_work(struct
> int kblockd_schedule_delayed_work_on(int cpu, struct delayed_work *dwork,
> unsigned long delay);
>
>
On Mon, Nov 17, 2014 at 04:13:21PM -0500, Tejun Heo wrote:
> cgroup aware writeback support will require exposing some of blkcg
> details. In preprataion, move block/blk-cgroup.h to
> include/linux/blk-cgroup.h. This patch is pure file move.
>
> Signed-off-by: Tejun Heo
&g
On Thu, Nov 20, 2014 at 11:10:55AM -0500, Dave Jones wrote:
> On Wed, Nov 19, 2014 at 11:28:06AM -0500, Vivek Goyal wrote:
>
> > I am wondering may be in some cases we panic in second kernel and sit
> > there. Probably we should append a kernel command line automatically
>
On Thu, Nov 20, 2014 at 11:10:55AM -0500, Dave Jones wrote:
> On Wed, Nov 19, 2014 at 11:28:06AM -0500, Vivek Goyal wrote:
>
> > I am wondering may be in some cases we panic in second kernel and sit
> > there. Probably we should append a kernel command line automatically
>
On Thu, Nov 20, 2014 at 11:10:55AM -0500, Dave Jones wrote:
On Wed, Nov 19, 2014 at 11:28:06AM -0500, Vivek Goyal wrote:
I am wondering may be in some cases we panic in second kernel and sit
there. Probably we should append a kernel command line automatically
say panic=1 so
On Thu, Nov 20, 2014 at 11:10:55AM -0500, Dave Jones wrote:
On Wed, Nov 19, 2014 at 11:28:06AM -0500, Vivek Goyal wrote:
I am wondering may be in some cases we panic in second kernel and sit
there. Probably we should append a kernel command line automatically
say panic=1 so
Goyal vgo...@redhat.com
Acked-by: Vivek Goyal vgo...@redhat.com
Thanks
Vivek
---
Hello, Jens.
These four are misc prep patches on blkcg for cgroup writeback
support.
Thanks.
block/blk-cgroup.c |2
block/blk-cgroup.h | 603
On Mon, Nov 17, 2014 at 04:13:57PM -0500, Tejun Heo wrote:
[..]
--- a/include/linux/blkdev.h
+++ b/include/linux/blkdev.h
@@ -1408,6 +1408,9 @@ int kblockd_schedule_delayed_work(struct
int kblockd_schedule_delayed_work_on(int cpu, struct delayed_work *dwork,
unsigned long delay);
ax...@kernel.dk
Cc: Vivek Goyal vgo...@redhat.com
Looks good to me.
Acked-by: Vivek Goyal vgo...@redhat.com
Vivek
---
Hello,
This one can be routed through either cgroup or block tree but I think
it'd be easier to route this through block as there will be more block
changes in the area
...@kernel.dk
Cc: Vivek Goyal vgo...@redhat.com
---
block/bio.c | 24 +++-
include/linux/bio.h |3 +++
2 files changed, 26 insertions(+), 1 deletion(-)
--- a/block/bio.c
+++ b/block/bio.c
@@ -1981,6 +1981,28 @@ struct bio_set *bioset_create_nobvec(uns
On Wed, Nov 19, 2014 at 10:38:52AM -0500, Dave Jones wrote:
> On Wed, Nov 19, 2014 at 10:03:33AM -0500, Vivek Goyal wrote:
>
> > Not being able to capture the dump I can understand but having wedged
> > the machine so that it does not reboot after dump failure sounds bad.
On Wed, Nov 19, 2014 at 09:41:05AM -0500, Don Zickus wrote:
> On Tue, Nov 18, 2014 at 05:02:54PM -0500, Dave Jones wrote:
> > On Tue, Nov 18, 2014 at 04:55:40PM -0500, Don Zickus wrote:
> >
> > > > So here we mangle CPU3 in and lose the backtrace for cpu0, which might
> > > > be the real
On Wed, Nov 19, 2014 at 09:41:05AM -0500, Don Zickus wrote:
On Tue, Nov 18, 2014 at 05:02:54PM -0500, Dave Jones wrote:
On Tue, Nov 18, 2014 at 04:55:40PM -0500, Don Zickus wrote:
So here we mangle CPU3 in and lose the backtrace for cpu0, which might
be the real interesting one
On Wed, Nov 19, 2014 at 10:38:52AM -0500, Dave Jones wrote:
On Wed, Nov 19, 2014 at 10:03:33AM -0500, Vivek Goyal wrote:
Not being able to capture the dump I can understand but having wedged
the machine so that it does not reboot after dump failure sounds bad.
So you could not get
On Fri, Nov 14, 2014 at 10:31:33AM +0900, HATAYAMA Daisuke wrote:
> From: Vivek Goyal
> Subject: Re: [PATCH] kdump, x86: report actual value of phys_base in
> VMCOREINFO
> Date: Thu, 13 Nov 2014 09:25:48 -0500
>
> > On Thu, Nov 13, 2014 at 05:30:21PM +0900, HA
On Fri, Nov 14, 2014 at 10:31:33AM +0900, HATAYAMA Daisuke wrote:
From: Vivek Goyal vgo...@redhat.com
Subject: Re: [PATCH] kdump, x86: report actual value of phys_base in
VMCOREINFO
Date: Thu, 13 Nov 2014 09:25:48 -0500
On Thu, Nov 13, 2014 at 05:30:21PM +0900, HATAYAMA, Daisuke wrote
On Thu, Nov 13, 2014 at 05:30:21PM +0900, HATAYAMA, Daisuke wrote:
>
>
> (2014/11/13 17:06), Petr Tesarik wrote:
> >On Thu, 13 Nov 2014 09:17:09 +0900 (JST)
> >HATAYAMA Daisuke wrote:
> >
> >>From: Vivek Goyal
> >>Subject: Re: [PATCH]
On Thu, Nov 13, 2014 at 05:30:21PM +0900, HATAYAMA, Daisuke wrote:
(2014/11/13 17:06), Petr Tesarik wrote:
On Thu, 13 Nov 2014 09:17:09 +0900 (JST)
HATAYAMA Daisuke d.hatay...@jp.fujitsu.com wrote:
From: Vivek Goyal vgo...@redhat.com
Subject: Re: [PATCH] kdump, x86: report actual value
On Wed, Nov 12, 2014 at 03:40:42PM +0900, HATAYAMA Daisuke wrote:
> Currently, VMCOREINFO note information reports the virtual address of
> phys_base that is assigned to symbol phys_base. But this doesn't make
> sense because to refer to value of the phys_base, it's necessary to
> get the value of
On Wed, Nov 12, 2014 at 03:40:42PM +0900, HATAYAMA Daisuke wrote:
Currently, VMCOREINFO note information reports the virtual address of
phys_base that is assigned to symbol phys_base. But this doesn't make
sense because to refer to value of the phys_base, it's necessary to
get the value of
On Sun, Nov 09, 2014 at 08:17:49PM +0100, Michael Kerrisk (man-pages) wrote:
> Hello Vivek (and all),
>
> Thanks for the kexec_file_load() patch [for the kexec_load(2) man page]
> that you quite some time ago sent. I have merged it and done some
> substantial editing as well. Could you please
On Sun, Nov 09, 2014 at 08:17:49PM +0100, Michael Kerrisk (man-pages) wrote:
Hello Vivek (and all),
Thanks for the kexec_file_load() patch [for the kexec_load(2) man page]
that you quite some time ago sent. I have merged it and done some
substantial editing as well. Could you please take a
On Thu, Nov 06, 2014 at 01:57:36PM -0800, David Rientjes wrote:
[..]
> You see that doing
>
> if (panic_on_warn) {
> panic_on_warn = 0;
> panic(...);
> }
>
> is racy, I hope. If two threads WARN() at the same time, then there's
> nothing preventing a
On Thu, Nov 06, 2014 at 01:57:36PM -0800, David Rientjes wrote:
[..]
You see that doing
if (panic_on_warn) {
panic_on_warn = 0;
panic(...);
}
is racy, I hope. If two threads WARN() at the same time, then there's
nothing preventing a double
On Fri, Oct 31, 2014 at 12:18:54PM -0700, Aditya Kali wrote:
[..]
> fs/kernfs/dir.c | 194
> ++-
> fs/kernfs/mount.c| 48 ++
> fs/proc/namespaces.c | 1 +
> include/linux/cgroup.h | 41
On Fri, Oct 31, 2014 at 12:18:54PM -0700, Aditya Kali wrote:
[..]
fs/kernfs/dir.c | 194
++-
fs/kernfs/mount.c| 48 ++
fs/proc/namespaces.c | 1 +
include/linux/cgroup.h | 41 -
On Mon, Nov 03, 2014 at 09:32:23AM -0500, Prarit Bhargava wrote:
[..]
> +
> +static int __init panic_on_warn_setup(char *s)
> +{
> + /* Enabling this on a kdump kernel could cause a bogus panic. */
> + if (!is_kdump_kernel())
> + panic_on_warn = 1;
I think it would be better
On Mon, Nov 03, 2014 at 08:32:42AM -0500, Prarit Bhargava wrote:
>
>
> On 10/30/2014 09:58 PM, Hedi Berriche wrote:
> > On Thu, Oct 30, 2014 at 17:06 Prarit Bhargava wrote:
> > | There have been several times where I have had to rebuild a kernel to
> > | cause a panic when hitting a WARN() in
On Mon, Nov 03, 2014 at 08:32:42AM -0500, Prarit Bhargava wrote:
On 10/30/2014 09:58 PM, Hedi Berriche wrote:
On Thu, Oct 30, 2014 at 17:06 Prarit Bhargava wrote:
| There have been several times where I have had to rebuild a kernel to
| cause a panic when hitting a WARN() in the code in
On Mon, Nov 03, 2014 at 09:32:23AM -0500, Prarit Bhargava wrote:
[..]
+
+static int __init panic_on_warn_setup(char *s)
+{
+ /* Enabling this on a kdump kernel could cause a bogus panic. */
+ if (!is_kdump_kernel())
+ panic_on_warn = 1;
I think it would be better if we
On Fri, Oct 31, 2014 at 10:42:51AM -0700, Andi Kleen wrote:
> > > +void __puthex(unsigned long value)
> > > +{
> > > + char alpha[2] = "0";
> > > + int bits;
> > > + unsigned char byte;
> >
> > what is 'byte' for? (unused)
>
> Well the whole function is unused. We don't normally add unused
On Fri, Oct 31, 2014 at 10:42:51AM -0700, Andi Kleen wrote:
+void __puthex(unsigned long value)
+{
+ char alpha[2] = 0;
+ int bits;
+ unsigned char byte;
what is 'byte' for? (unused)
Well the whole function is unused. We don't normally add unused functions
to the code
On Tue, Oct 28, 2014 at 05:44:25AM -0700, Andi Kleen wrote:
> > > I suppose ... but that would mean I would have to explain to an end user
> > > the
> > > elaborate process of enabling kdb, inserting a break point, etc. The
> > > whole
> > > purpose of this is to let an end user panic on WARN()
On Tue, Oct 28, 2014 at 08:22:16AM -0400, Prarit Bhargava wrote:
>
>
> On 10/28/2014 08:16 AM, Andi Kleen wrote:
> > On Fri, Oct 24, 2014 at 08:53:27AM -0400, Prarit Bhargava wrote:
> >> There have been several times where I have had to rebuild a kernel to
> >> cause a panic when hitting a
On Tue, Oct 28, 2014 at 08:22:16AM -0400, Prarit Bhargava wrote:
On 10/28/2014 08:16 AM, Andi Kleen wrote:
On Fri, Oct 24, 2014 at 08:53:27AM -0400, Prarit Bhargava wrote:
There have been several times where I have had to rebuild a kernel to
cause a panic when hitting a WARN() in the
On Tue, Oct 28, 2014 at 05:44:25AM -0700, Andi Kleen wrote:
I suppose ... but that would mean I would have to explain to an end user
the
elaborate process of enabling kdb, inserting a break point, etc. The
whole
purpose of this is to let an end user panic on WARN() easily.
_of_node
> >> decl")).
> >>
> >> Remove the "weak" attribute from the declarations so we always prefer a
> >> non-weak definition over the weak one, independent of link order.
> >>
> >> Fixes: be8a8d069e50 ("vmcore: introduce ELF header
memory feature)
Fixes: 9cb218131de1 (vmcore: introduce remap_oldmem_pfn_range())
Signed-off-by: Bjorn Helgaas bhelg...@google.com
CC: Michael Holzheu holz...@linux.vnet.ibm.com
CC: Vivek Goyal vgo...@redhat.com
Looks good to me.
Acked-by: Vivek Goyal vgo...@redhat.com
Thanks
Vivek
On Wed, Oct 15, 2014 at 11:37:01AM +0800, Baoquan He wrote:
> On 10/14/14 at 08:49am, Vivek Goyal wrote:
> > On Mon, Oct 13, 2014 at 01:22:42PM -0400, Vivek Goyal wrote:
> > > On Mon, Oct 13, 2014 at 08:43:00AM -0700, H. Peter Anvin wrote:
> > > > On 10/13/20
On Wed, Oct 15, 2014 at 10:14:31AM +0800, WANG Chao wrote:
> On 10/14/14 at 05:52pm, Vivek Goyal wrote:
> > On Tue, Oct 14, 2014 at 12:46:58PM +0800, WANG Chao wrote:
> > > Supress this unnecessary message during kernel re-build
> > > (CONFIG_KEXEC_FILE=y):
>
On Wed, Oct 15, 2014 at 10:14:31AM +0800, WANG Chao wrote:
On 10/14/14 at 05:52pm, Vivek Goyal wrote:
On Tue, Oct 14, 2014 at 12:46:58PM +0800, WANG Chao wrote:
Supress this unnecessary message during kernel re-build
(CONFIG_KEXEC_FILE=y):
make[1]: `arch/x86/purgatory/kexec
On Wed, Oct 15, 2014 at 11:37:01AM +0800, Baoquan He wrote:
On 10/14/14 at 08:49am, Vivek Goyal wrote:
On Mon, Oct 13, 2014 at 01:22:42PM -0400, Vivek Goyal wrote:
On Mon, Oct 13, 2014 at 08:43:00AM -0700, H. Peter Anvin wrote:
On 10/13/2014 08:19 AM, Vivek Goyal wrote
On Tue, Oct 14, 2014 at 12:46:58PM +0800, WANG Chao wrote:
> Supress this unnecessary message during kernel re-build
> (CONFIG_KEXEC_FILE=y):
>
> make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.
>
> Signed-off-by: WANG Chao
> ---
> arch/x86/purgatory/Makefile | 1 +
> 1 file
On Mon, Oct 13, 2014 at 01:22:42PM -0400, Vivek Goyal wrote:
> On Mon, Oct 13, 2014 at 08:43:00AM -0700, H. Peter Anvin wrote:
> > On 10/13/2014 08:19 AM, Vivek Goyal wrote:
> > >>>
> > >>> This really shouldn't have happened this way on x86-64. It has to
On Tue, Oct 14, 2014 at 12:46:58PM +0800, WANG Chao wrote:
Supress this unnecessary message during kernel re-build
(CONFIG_KEXEC_FILE=y):
make[1]: `arch/x86/purgatory/kexec-purgatory.c' is up to date.
Signed-off-by: WANG Chao chaow...@redhat.com
---
arch/x86/purgatory/Makefile | 1 +
1
On Mon, Oct 13, 2014 at 01:22:42PM -0400, Vivek Goyal wrote:
On Mon, Oct 13, 2014 at 08:43:00AM -0700, H. Peter Anvin wrote:
On 10/13/2014 08:19 AM, Vivek Goyal wrote:
This really shouldn't have happened this way on x86-64. It has to
happen
this way on i386, but I worry
On Mon, Oct 13, 2014 at 08:43:00AM -0700, H. Peter Anvin wrote:
> On 10/13/2014 08:19 AM, Vivek Goyal wrote:
> >>>
> >>> This really shouldn't have happened this way on x86-64. It has to happen
> >>> this way on i386, but I worry that this may be a serious
On Mon, Oct 13, 2014 at 08:52:57AM -0400, Vivek Goyal wrote:
> On Sat, Oct 11, 2014 at 03:34:29AM -0700, H. Peter Anvin wrote:
> > On 10/10/2014 08:14 PM, Baoquan He wrote:
> > >On 10/08/14 at 03:27pm, Vivek Goyal wrote:
> > >>On Wed, Oct 08, 2014 at 08:09:59
On Sat, Oct 11, 2014 at 03:34:29AM -0700, H. Peter Anvin wrote:
> On 10/10/2014 08:14 PM, Baoquan He wrote:
> >On 10/08/14 at 03:27pm, Vivek Goyal wrote:
> >>On Wed, Oct 08, 2014 at 08:09:59AM -0700, H. Peter Anvin wrote:
> >
> >>>Sorry... this m
gt; \# arch/x86/purgatory/purgatory.ro
>
> Add a .gitignore to block these files.
>
> Cc: x...@kernel.org
> Cc: Vivek Goyal
> Signed-off-by: Prarit Bhargava
[ CC akpm ]
Thanks Prarit.
Acked-by: Vivek Goyal
Vivek
> ---
> arch/x86/purgatory/.gitignore |2 ++
>
/purgatory.ro
Add a .gitignore to block these files.
Cc: x...@kernel.org
Cc: Vivek Goyal vgo...@redhat.com
Signed-off-by: Prarit Bhargava pra...@redhat.com
[ CC akpm ]
Thanks Prarit.
Acked-by: Vivek Goyal vgo...@redhat.com
Vivek
---
arch/x86/purgatory/.gitignore |2 ++
1 file changed, 2
On Sat, Oct 11, 2014 at 03:34:29AM -0700, H. Peter Anvin wrote:
On 10/10/2014 08:14 PM, Baoquan He wrote:
On 10/08/14 at 03:27pm, Vivek Goyal wrote:
On Wed, Oct 08, 2014 at 08:09:59AM -0700, H. Peter Anvin wrote:
Sorry... this makes no sense.
For x86-64, there is no direct connection
801 - 900 of 3703 matches
Mail list logo
