Re: [PATCH 00/18] drivers: Remove oprofile and dcookies

ndicates there are no or less users. Users > (if any) should switch to oprofile 1.x or the perf tool. No need to > carry kernel support any longer with us. > > So time to get rid of it. For the whole series: > > Acked-by: Robert Richter The oprofile daemon that used the

Re: [PATCH] dcookies: Make dcookies depend on CONFIG_OPROFILE

oprofile" program doesn't actually use the > legacy kernel code any more, and hasn't for a long time. > > But I might be wrong. Adding William Cohen to the cc, since he seems > to still maintain it to make sure it builds etc. > > Linus > Hi, Yes, current OProfile c

Re: perf tools:Is there any tools to found out the max latency by irq or cpu idle

l it would be interesting to look at the two raw values used to compute the delta to better diagnose what is going on. -Will > > -Original Message- > From: William Cohen [mailto:wco...@redhat.com] > Sent: 2019年4月12日 22:06 > To: Linhaifeng ; linux-perf-us...@vger.kernel.or

Re: perf tools:Is there any tools to found out the max latency by irq or cpu idle

On 4/11/19 8:57 PM, Linhaifeng wrote: > Hi, > I have a single thread application like this: > > While (1) { >     start = rdtsc(); >     sqrt (1024);  > 　　end = rdtsc(); > 　　cycles = end – start; > 　　printf("cycles: %d-%02d-%02d %02d:%02d:%02d: %lu\n", > 　　1900+timeinfo->tm_year,

[PATCH] arm64/stacktrace: Export save_stack_trace_regs()

. This is similar to the ARM64 export of save_stack_trace_tsk() added in git commit e27c7fa015d6. Signed-off-by: William Cohen --- arch/arm64/kernel/stacktrace.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index 1a29f2695ff2..d908b5e9e949

[tip:perf/core] perf vendor events intel: Fix Load_Miss_Real_Latency on CLX

Commit-ID: 2d08f87fe7a2e4d74dc8b0eb645737d83dd932a9 Gitweb: https://git.kernel.org/tip/2d08f87fe7a2e4d74dc8b0eb645737d83dd932a9 Author: William Cohen AuthorDate: Tue, 29 Jan 2019 12:05:36 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Wed, 6 Feb 2019 10:00:40 -0300 perf vendor

[PATCH] perf vendor events intel: Fix Load_Miss_Real_Latency on CLX

Fix incorrect event names for the Load_Miss_Real_Latency metric for Cascadelake server in the same manner as commit 91b2b97025 for SKL/SKX. Signed-off-by: William Cohen --- tools/perf/pmu-events/arch/x86/cascadelakex/clx-metrics.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] ARM: kprobes: Fix false positive with FORTIFY_SOURCE

the runtime checks. Instead, > we can just cast the label (as done with the size calculations earlier) > to avoid the problem. > > Reported-by: William Cohen > Fixes: 6974f0c4555e ("include/linux/string.h: add the option of fortified > string.h functions") > Cc: sta...

Re: [PATCH] ARM: kprobes: Fix false positive with FORTIFY_SOURCE

the runtime checks. Instead, > we can just cast the label (as done with the size calculations earlier) > to avoid the problem. > > Reported-by: William Cohen > Fixes: 6974f0c4555e ("include/linux/string.h: add the option of fortified > string.h functions") > Cc: sta...

Re: [PATCH] AMD perf PMU events for AMD Family 17h.

On 08/23/2018 10:31 AM, Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 23, 2018 at 01:21:45PM +0200, Martin Liška escreveu: >> May I please ping this. > > I was waiting for someone to give some ack, perhaps Will Cohen can take > a brief look and provide that? Will? > > Thanks, > > - Arnaldo >

Re: [PATCH] AMD perf PMU events for AMD Family 17h.

On 08/23/2018 10:31 AM, Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 23, 2018 at 01:21:45PM +0200, Martin Liška escreveu: >> May I please ping this. > > I was waiting for someone to give some ack, perhaps Will Cohen can take > a brief look and provide that? Will? > > Thanks, > > - Arnaldo >

Re: [PATCH] Check jvmti_agent snprintf return value to avoid build failures with GCC-8.1.1

On 07/10/2018 06:58 PM, Jiri Olsa wrote: > On Tue, Jul 10, 2018 at 02:27:16PM -0400, William Cohen wrote: >> Newer versions of GCC perform static analysis to determine whether >> string truncation is possible with functions such as snprintf and >> provide a warning if t

Re: [PATCH] Check jvmti_agent snprintf return value to avoid build failures with GCC-8.1.1

On 07/10/2018 06:58 PM, Jiri Olsa wrote: > On Tue, Jul 10, 2018 at 02:27:16PM -0400, William Cohen wrote: >> Newer versions of GCC perform static analysis to determine whether >> string truncation is possible with functions such as snprintf and >> provide a warning if t

[PATCH] Check jvmti_agent snprintf return value to avoid build failures with GCC-8.1.1

-8.1.1 in Fedora 28 this causes the build to fail. The return value of the snprint is now checked to ensure snprintf produced a NULL-terminated string. If the string for the path is invalid, the code does attempt to use the string. Signed-off-by: William Cohen --- tools/perf/jvmti/jvmti_agent.c | 7

[PATCH] Check jvmti_agent snprintf return value to avoid build failures with GCC-8.1.1

-8.1.1 in Fedora 28 this causes the build to fail. The return value of the snprint is now checked to ensure snprintf produced a NULL-terminated string. If the string for the path is invalid, the code does attempt to use the string. Signed-off-by: William Cohen --- tools/perf/jvmti/jvmti_agent.c | 7

[tip:perf/urgent] perf vendor events intel: Remove duplicated entry for westmereep-dp in mapfile.csv

Commit-ID: ea9032fa2e4e91ae15facff5b7c4b2a84c1e40af Gitweb: https://git.kernel.org/tip/ea9032fa2e4e91ae15facff5b7c4b2a84c1e40af Author: William Cohen <wco...@redhat.com> AuthorDate: Thu, 3 May 2018 15:50:32 -0400 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Commit

[tip:perf/urgent] perf vendor events intel: Remove duplicated entry for westmereep-dp in mapfile.csv

Commit-ID: ea9032fa2e4e91ae15facff5b7c4b2a84c1e40af Gitweb: https://git.kernel.org/tip/ea9032fa2e4e91ae15facff5b7c4b2a84c1e40af Author: William Cohen AuthorDate: Thu, 3 May 2018 15:50:32 -0400 Committer: Arnaldo Carvalho de Melo CommitDate: Mon, 7 May 2018 15:23:45 -0300 perf vendor

[PATCH] Remove duplicated entry for westmereep-dp in mapfile.csv

Signed-off-by: William Cohen <wco...@redhat.com> --- tools/perf/pmu-events/arch/x86/mapfile.csv | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/perf/pmu-events/arch/x86/mapfile.csv b/tools/perf/pmu-events/arch/x86/mapfile.csv index 93656f2fd53a..7e3cce3bcf3b 100644 --- a/tools/pe

[PATCH] Remove duplicated entry for westmereep-dp in mapfile.csv

Signed-off-by: William Cohen --- tools/perf/pmu-events/arch/x86/mapfile.csv | 1 - 1 file changed, 1 deletion(-) diff --git a/tools/perf/pmu-events/arch/x86/mapfile.csv b/tools/perf/pmu-events/arch/x86/mapfile.csv index 93656f2fd53a..7e3cce3bcf3b 100644 --- a/tools/perf/pmu-events/arch/x86

[PATCH] Move handling of the MIDR Variant and Revision bits into the mapfile.csv file

versions of silicon, special case maps can be added to mapsfile.csv before the general case to handle them. Signed-off-by: William Cohen <wco...@redhat.com> --- tools/perf/arch/arm64/util/header.c | 7 --- tools/perf/pmu-events/arch/arm64/mapfile.csv | 12 +++- 2 files chan

[PATCH] Move handling of the MIDR Variant and Revision bits into the mapfile.csv file

versions of silicon, special case maps can be added to mapsfile.csv before the general case to handle them. Signed-off-by: William Cohen --- tools/perf/arch/arm64/util/header.c | 7 --- tools/perf/pmu-events/arch/arm64/mapfile.csv | 12 +++- 2 files changed, 7 insertions(+), 12

Re: [PATCH] perf vendor events arm64: Enable JSON events for ThunderX2 B0

On 03/15/2018 12:47 PM, John Garry wrote: > On 15/03/2018 15:53, William Cohen wrote: >> On 03/07/2018 11:14 PM, Ganapatrao Kulkarni wrote: >>> On Thu, Mar 8, 2018 at 12:01 AM, William Cohen <wco...@redhat.com> wrote: >>>> On 03/07/2018 12:35 PM, Ganapatrao

Re: [PATCH] perf vendor events arm64: Enable JSON events for ThunderX2 B0

On 03/15/2018 12:47 PM, John Garry wrote: > On 15/03/2018 15:53, William Cohen wrote: >> On 03/07/2018 11:14 PM, Ganapatrao Kulkarni wrote: >>> On Thu, Mar 8, 2018 at 12:01 AM, William Cohen wrote: >>>> On 03/07/2018 12:35 PM, Ganapatrao Kulkarni wrote: >>&

Re: [PATCH] perf vendor events arm64: Enable JSON events for ThunderX2 B0

On 03/07/2018 11:14 PM, Ganapatrao Kulkarni wrote: > On Thu, Mar 8, 2018 at 12:01 AM, William Cohen <wco...@redhat.com> wrote: >> On 03/07/2018 12:35 PM, Ganapatrao Kulkarni wrote: >>> Hi Will Cohen, >>> >>> On Wed, Mar 7, 2018 at 8:08 PM, Arnaldo Ca

Re: [PATCH] perf vendor events arm64: Enable JSON events for ThunderX2 B0

On 03/07/2018 11:14 PM, Ganapatrao Kulkarni wrote: > On Thu, Mar 8, 2018 at 12:01 AM, William Cohen wrote: >> On 03/07/2018 12:35 PM, Ganapatrao Kulkarni wrote: >>> Hi Will Cohen, >>> >>> On Wed, Mar 7, 2018 at 8:08 PM, Arnaldo Carvalho de Melo >>> w

Re: [PATCH] perf vendor events arm64: Enable JSON events for ThunderX2 B0

On 03/07/2018 12:35 PM, Ganapatrao Kulkarni wrote: > Hi Will Cohen, > > On Wed, Mar 7, 2018 at 8:08 PM, Arnaldo Carvalho de Melo > <a...@kernel.org> wrote: >> Em Wed, Mar 07, 2018 at 09:32:05AM -0500, William Cohen escreveu: >>> On 03/07/2018 06

Re: [PATCH] perf vendor events arm64: Enable JSON events for ThunderX2 B0

On 03/07/2018 12:35 PM, Ganapatrao Kulkarni wrote: > Hi Will Cohen, > > On Wed, Mar 7, 2018 at 8:08 PM, Arnaldo Carvalho de Melo > wrote: >> Em Wed, Mar 07, 2018 at 09:32:05AM -0500, William Cohen escreveu: >>> On 03/07/2018 06:08 AM, Ganapatrao Kulkarni wrote

Re: [PATCH] perf vendor events arm64: Enable JSON events for ThunderX2 B0

On 03/07/2018 10:25 AM, John Garry wrote: > On 07/03/2018 14:38, Arnaldo Carvalho de Melo wrote: >> Em Wed, Mar 07, 2018 at 09:32:05AM -0500, William Cohen escreveu: >>> On 03/07/2018 06:08 AM, Ganapatrao Kulkarni wrote: >>>> There is MIDR change on ThunderX2

Re: [PATCH] perf vendor events arm64: Enable JSON events for ThunderX2 B0

On 03/07/2018 10:25 AM, John Garry wrote: > On 07/03/2018 14:38, Arnaldo Carvalho de Melo wrote: >> Em Wed, Mar 07, 2018 at 09:32:05AM -0500, William Cohen escreveu: >>> On 03/07/2018 06:08 AM, Ganapatrao Kulkarni wrote: >>>> There is MIDR change on ThunderX2

Re: [PATCH] perf vendor events arm64: Enable JSON events for ThunderX2 B0

On 03/07/2018 06:08 AM, Ganapatrao Kulkarni wrote: > There is MIDR change on ThunderX2 B0, adding an entry to mapfile > to enable JSON events for B0. > > Signed-off-by: Ganapatrao Kulkarni > --- > tools/perf/pmu-events/arch/arm64/mapfile.csv | 1 + > 1 file

Re: [PATCH] perf vendor events arm64: Enable JSON events for ThunderX2 B0

On 03/07/2018 06:08 AM, Ganapatrao Kulkarni wrote: > There is MIDR change on ThunderX2 B0, adding an entry to mapfile > to enable JSON events for B0. > > Signed-off-by: Ganapatrao Kulkarni > --- > tools/perf/pmu-events/arch/arm64/mapfile.csv | 1 + > 1 file changed, 1 insertion(+) > > diff

Re: [PATCH v2 00/11] perf events patches for improved ARM64 support

On 03/05/2018 06:24 AM, John Garry wrote: >>> I am seeing issue(log below) with this patchset on our platfrom. >>> i have tried using your v2 branch [1] >>> >>> root@borg-1>perf_acme>> ./perf --version >>> perf version 4.16.rc1.g087f7ca >>> root@borg-1>perf_acme>> ./perf stat -e bus_access_rd

Re: [PATCH v2 00/11] perf events patches for improved ARM64 support

On 03/05/2018 06:24 AM, John Garry wrote: >>> I am seeing issue(log below) with this patchset on our platfrom. >>> i have tried using your v2 branch [1] >>> >>> root@borg-1>perf_acme>> ./perf --version >>> perf version 4.16.rc1.g087f7ca >>> root@borg-1>perf_acme>> ./perf stat -e bus_access_rd

Re: [PATCH v2 00/11] perf events patches for improved ARM64 support

On 03/02/2018 11:35 AM, Ganapatrao Kulkarni wrote: > Hi John, > > On Fri, Mar 2, 2018 at 9:35 PM, William Cohen <wco...@redhat.com> wrote: >> On 03/02/2018 03:24 AM, John Garry wrote: >>> On 27/02/2018 09:50, Jiri Olsa wrote: >>>> On Sat, Feb 24,

Re: [PATCH v2 00/11] perf events patches for improved ARM64 support

On 03/02/2018 11:35 AM, Ganapatrao Kulkarni wrote: > Hi John, > > On Fri, Mar 2, 2018 at 9:35 PM, William Cohen wrote: >> On 03/02/2018 03:24 AM, John Garry wrote: >>> On 27/02/2018 09:50, Jiri Olsa wrote: >>>> On Sat, Feb 24, 2018 at 12:05:21AM +0800, John G

Re: [PATCH v2 00/11] perf events patches for improved ARM64 support

On 03/02/2018 03:24 AM, John Garry wrote: > On 27/02/2018 09:50, Jiri Olsa wrote: >> On Sat, Feb 24, 2018 at 12:05:21AM +0800, John Garry wrote: >>> This patchset adds support for some perf events features, >>> targeted at ARM64, implemented in a generic fashion. >>> >>> The two main features are

Re: [PATCH v2 00/11] perf events patches for improved ARM64 support

On 03/02/2018 03:24 AM, John Garry wrote: > On 27/02/2018 09:50, Jiri Olsa wrote: >> On Sat, Feb 24, 2018 at 12:05:21AM +0800, John Garry wrote: >>> This patchset adds support for some perf events features, >>> targeted at ARM64, implemented in a generic fashion. >>> >>> The two main features are

[tip:perf/urgent] perf vendor events aarch64: Add JSON metrics for ARM Cortex-A53 Processor

Commit-ID: 0b7c1528fb741803396da68a9d8d285ff7db731c Gitweb: https://git.kernel.org/tip/0b7c1528fb741803396da68a9d8d285ff7db731c Author: William Cohen <wco...@redhat.com> AuthorDate: Tue, 30 Jan 2018 22:28:13 -0500 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> CommitD

[tip:perf/urgent] perf vendor events aarch64: Add JSON metrics for ARM Cortex-A53 Processor

Commit-ID: 0b7c1528fb741803396da68a9d8d285ff7db731c Gitweb: https://git.kernel.org/tip/0b7c1528fb741803396da68a9d8d285ff7db731c Author: William Cohen AuthorDate: Tue, 30 Jan 2018 22:28:13 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Thu, 15 Feb 2018 09:49:44 -0300 perf vendor

[tip:perf/urgent] perf vendor events aarch64: Add JSON metrics for ARM Cortex-A53 Processor

Commit-ID: 109def8f4b73a508de947a33c5965f3aa568aee1 Gitweb: https://git.kernel.org/tip/109def8f4b73a508de947a33c5965f3aa568aee1 Author: William Cohen <wco...@redhat.com> AuthorDate: Tue, 30 Jan 2018 22:28:13 -0500 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Commit

[tip:perf/urgent] perf vendor events aarch64: Add JSON metrics for ARM Cortex-A53 Processor

Commit-ID: 109def8f4b73a508de947a33c5965f3aa568aee1 Gitweb: https://git.kernel.org/tip/109def8f4b73a508de947a33c5965f3aa568aee1 Author: William Cohen AuthorDate: Tue, 30 Jan 2018 22:28:13 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 6 Feb 2018 10:11:49 -0300 perf vendor

Re: [PATCH] perf vendor events aarch64: Add JSON metrics for ARM Cortex-A53 Processor

On 02/01/2018 03:51 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Feb 01, 2018 at 10:12:59AM -0500, William Cohen escreveu: >> On 02/01/2018 09:43 AM, Arnaldo Carvalho de Melo wrote: >>> Em Tue, Jan 30, 2018 at 10:28:13PM -0500, William Cohen escreveu: >>>> Add J

Re: [PATCH] perf vendor events aarch64: Add JSON metrics for ARM Cortex-A53 Processor

On 02/01/2018 03:51 PM, Arnaldo Carvalho de Melo wrote: > Em Thu, Feb 01, 2018 at 10:12:59AM -0500, William Cohen escreveu: >> On 02/01/2018 09:43 AM, Arnaldo Carvalho de Melo wrote: >>> Em Tue, Jan 30, 2018 at 10:28:13PM -0500, William Cohen escreveu: >>>> Add J

Re: [PATCH] perf vendor events aarch64: Add JSON metrics for ARM Cortex-A53 Processor

On 02/01/2018 09:43 AM, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 30, 2018 at 10:28:13PM -0500, William Cohen escreveu: >> Add JSON metrics for ARM Cortex-A53 Processor > > Hi Will, would it be possible to you include an URL for the document > that served as a referen

Re: [PATCH] perf vendor events aarch64: Add JSON metrics for ARM Cortex-A53 Processor

On 02/01/2018 09:43 AM, Arnaldo Carvalho de Melo wrote: > Em Tue, Jan 30, 2018 at 10:28:13PM -0500, William Cohen escreveu: >> Add JSON metrics for ARM Cortex-A53 Processor > > Hi Will, would it be possible to you include an URL for the document > that served as a referen

[PATCH] perf vendor events aarch64: Add JSON metrics for ARM Cortex-A53 Processor

Add JSON metrics for ARM Cortex-A53 Processor Signed-off-by: William Cohen <wco...@redhat.com> --- .../pmu-events/arch/arm64/cortex-a53/branch.json | 27 +++ .../perf/pmu-events/arch/arm64/cortex-a53/bus.json | 22 + .../pmu-events/arch/arm64/cortex-a53/cache.json

[PATCH] perf vendor events aarch64: Add JSON metrics for ARM Cortex-A53 Processor

Add JSON metrics for ARM Cortex-A53 Processor Signed-off-by: William Cohen --- .../pmu-events/arch/arm64/cortex-a53/branch.json | 27 +++ .../perf/pmu-events/arch/arm64/cortex-a53/bus.json | 22 + .../pmu-events/arch/arm64/cortex-a53/cache.json| 27 +++ .../pmu

[tip:perf/core] perf vendor events: Use more flexible pattern matching for CPU identification for mapfile.csv

Commit-ID: fbc2844e84038ce3687d203ac80b66194e9f21e6 Gitweb: https://git.kernel.org/tip/fbc2844e84038ce3687d203ac80b66194e9f21e6 Author: William Cohen <wco...@redhat.com> AuthorDate: Mon, 4 Dec 2017 09:57:28 -0500 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> Commit

[tip:perf/core] perf vendor events: Use more flexible pattern matching for CPU identification for mapfile.csv

Commit-ID: fbc2844e84038ce3687d203ac80b66194e9f21e6 Gitweb: https://git.kernel.org/tip/fbc2844e84038ce3687d203ac80b66194e9f21e6 Author: William Cohen AuthorDate: Mon, 4 Dec 2017 09:57:28 -0500 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 5 Dec 2017 15:43:55 -0300 perf vendor

Re: [RFC PATCH 0/5] perf events patches for improved ARM64 support

On 12/05/2017 11:13 AM, John Garry wrote: > This patchset adds support for some perf events features, > targeted at ARM64, implemented in a generic fashion. > > The two main features are as follows: > - support for arch/vendor/platform pmu events directory structure > - support for parsing

Re: [RFC PATCH 0/5] perf events patches for improved ARM64 support

On 12/05/2017 11:13 AM, John Garry wrote: > This patchset adds support for some perf events features, > targeted at ARM64, implemented in a generic fashion. > > The two main features are as follows: > - support for arch/vendor/platform pmu events directory structure > - support for parsing

[PATCH v4] Use more flexible pattern matching for CPU identification for mapfile.csv

to be made for some particular versions, they can be placed earlier in the mapfile.csv file before the more general matches. Signed-off-by: William Cohen <wco...@redhat.com> --- tools/perf/pmu-events/arch/powerpc/mapfile.csv | 12 ++-- tools/perf/pmu-events/arch/x86/mapfile.csv

[PATCH v4] Use more flexible pattern matching for CPU identification for mapfile.csv

to be made for some particular versions, they can be placed earlier in the mapfile.csv file before the more general matches. Signed-off-by: William Cohen --- tools/perf/pmu-events/arch/powerpc/mapfile.csv | 12 ++-- tools/perf/pmu-events/arch/x86/mapfile.csv | 5 +--- tools/perf/pmu-events

Re: [PATCH] Use more flexible pattern matching for CPU identification for mapfile.csv

On 11/23/2017 01:06 AM, Ravi Bangoria wrote: > Hi William, > > On 11/23/2017 12:56 AM, Arnaldo Carvalho de Melo wrote: >> Em Wed, Nov 22, 2017 at 11:08:49AM -0500, William Cohen escreveu: >>> The powerpc cpuid information includes chip revision information. >>&g

Re: [PATCH] Use more flexible pattern matching for CPU identification for mapfile.csv

On 11/23/2017 01:06 AM, Ravi Bangoria wrote: > Hi William, > > On 11/23/2017 12:56 AM, Arnaldo Carvalho de Melo wrote: >> Em Wed, Nov 22, 2017 at 11:08:49AM -0500, William Cohen escreveu: >>> The powerpc cpuid information includes chip revision information. >>&g

Re: [PATCH v15 00/10] arm64: Add kernel probes (kprobes) support

simulation support >> arm64: Add kernel return probes support (kretprobes) >> kprobes: Add arm64 case in kprobe example module >> >> William Cohen (1): >> arm64: Add trampoline code for kretprobes > > I applied these patches on top of the arm64 for-next/

Re: [PATCH v15 00/10] arm64: Add kernel probes (kprobes) support

simulation support >> arm64: Add kernel return probes support (kretprobes) >> kprobes: Add arm64 case in kprobe example module >> >> William Cohen (1): >> arm64: Add trampoline code for kretprobes > > I applied these patches on top of the arm64 for-next/

Re: [PATCH] s390/oprofile: Remove deprecated create_workqueue

On 06/13/2016 12:29 PM, Robert Richter wrote: > Heiko, > > On 09.06.16 11:00:56, Heiko Carstens wrote: >> However I'm wondering if we shouldn't simply remove at least the s390 >> specific hwswampler code from the oprofile module. This would still leave >> the common code timer based sampling mode

Re: [PATCH] s390/oprofile: Remove deprecated create_workqueue

On 06/13/2016 12:29 PM, Robert Richter wrote: > Heiko, > > On 09.06.16 11:00:56, Heiko Carstens wrote: >> However I'm wondering if we shouldn't simply remove at least the s390 >> specific hwswampler code from the oprofile module. This would still leave >> the common code timer based sampling mode

Re: [PATCH v10 7/9] arm64: Add trampoline code for kretprobes

On 03/01/2016 01:19 PM, Marc Zyngier wrote: > On 01/03/16 02:57, David Long wrote: >> From: William Cohen <wco...@redhat.com> >> >> The trampoline code is used by kretprobes to capture a return from a probed >> function. This is done by saving the registers, call

Re: [PATCH v10 7/9] arm64: Add trampoline code for kretprobes

On 03/01/2016 01:19 PM, Marc Zyngier wrote: > On 01/03/16 02:57, David Long wrote: >> From: William Cohen >> >> The trampoline code is used by kretprobes to capture a return from a probed >> function. This is done by saving the registers, calling the handler, and

Re: [RFC] kprobe'ing conditionally executed instructions

On 12/12/2015 12:56 AM, David Long wrote: > On 12/11/2015 11:09 AM, William Cohen wrote: >> On 12/11/2015 12:05 AM, David Long wrote: >>> There is a moderate amount of code already in kprobes on ARM and the >>> current ARMv8 patch to deal with conditional exe

Re: [RFC] kprobe'ing conditionally executed instructions

On 12/12/2015 12:56 AM, David Long wrote: > On 12/11/2015 11:09 AM, William Cohen wrote: >> On 12/11/2015 12:05 AM, David Long wrote: >>> There is a moderate amount of code already in kprobes on ARM and the >>> current ARMv8 patch to deal with conditional exe

Re: [RFC] kprobe'ing conditionally executed instructions

On 12/11/2015 12:05 AM, David Long wrote: > There is a moderate amount of code already in kprobes on ARM and the current > ARMv8 patch to deal with conditional execution of instructions. One aspect of > how this is handled is that instructions that fail their predicate and are > not

Re: [RFC] kprobe'ing conditionally executed instructions

On 12/11/2015 12:05 AM, David Long wrote: > There is a moderate amount of code already in kprobes on ARM and the current > ARMv8 patch to deal with conditional execution of instructions. One aspect of > how this is handled is that instructions that fail their predicate and are > not

Re: [RFC PATCH V2 00/10] ARM64: Uprobe support added

On 08/03/2015 09:45 AM, David Long wrote: > On 08/03/15 09:43, David Long wrote: >> On 08/03/15 07:09, Will Deacon wrote: >>> On Thu, Jun 18, 2015 at 04:58:47AM +0100, Pratyush Anand wrote: These patches have been prepared on top of ARM64 kprobe v7 patches [1]. Keeping as RFC, because

Re: [RFC PATCH V2 00/10] ARM64: Uprobe support added

On 08/03/2015 09:45 AM, David Long wrote: On 08/03/15 09:43, David Long wrote: On 08/03/15 07:09, Will Deacon wrote: On Thu, Jun 18, 2015 at 04:58:47AM +0100, Pratyush Anand wrote: These patches have been prepared on top of ARM64 kprobe v7 patches [1]. Keeping as RFC, because kprobe-v7 still

Re: [PATCH 1/2] arm64: Blacklist non-kprobe-able symbols

On 07/06/2015 07:37 AM, Masami Hiramatsu wrote: > On 2015/07/06 18:03, Will Deacon wrote: >> On Mon, Jul 06, 2015 at 06:03:21AM +0100, Pratyush Anand wrote: >>> Add all function symbols which are called from do_debug_exception under >>> NOKPROBE_SYMBOL, as they can not kprobed. >> >> It's a shame

Re: [PATCH 1/2] arm64: Blacklist non-kprobe-able symbols

On 07/06/2015 07:37 AM, Masami Hiramatsu wrote: On 2015/07/06 18:03, Will Deacon wrote: On Mon, Jul 06, 2015 at 06:03:21AM +0100, Pratyush Anand wrote: Add all function symbols which are called from do_debug_exception under NOKPROBE_SYMBOL, as they can not kprobed. It's a shame this has to

Re: [PATCH v7 5/7] arm64: Add trampoline code for kretprobes

On 06/30/2015 07:04 AM, Steve Capper wrote: > On 29 June 2015 at 19:16, William Cohen wrote: >> On 06/29/2015 01:25 PM, Steve Capper wrote: >>> On 15 June 2015 at 20:07, David Long wrote: >>>> From: William Cohen >>>> >>>> The trampoli

Re: [PATCH v7 5/7] arm64: Add trampoline code for kretprobes

On 06/30/2015 07:04 AM, Steve Capper wrote: On 29 June 2015 at 19:16, William Cohen wco...@redhat.com wrote: On 06/29/2015 01:25 PM, Steve Capper wrote: On 15 June 2015 at 20:07, David Long dave.l...@linaro.org wrote: From: William Cohen wco...@redhat.com The trampoline code is used

Re: [PATCH v7 5/7] arm64: Add trampoline code for kretprobes

On 06/29/2015 01:25 PM, Steve Capper wrote: > On 15 June 2015 at 20:07, David Long wrote: >> From: William Cohen >> >> The trampoline code is used by kretprobes to capture a return from a probed >> function. This is done by saving the registers, calling th

Re: [PATCH v7 5/7] arm64: Add trampoline code for kretprobes

On 06/29/2015 01:25 PM, Steve Capper wrote: On 15 June 2015 at 20:07, David Long dave.l...@linaro.org wrote: From: William Cohen wco...@redhat.com The trampoline code is used by kretprobes to capture a return from a probed function. This is done by saving the registers, calling the handler

Re: [PATCH v7 5/7] arm64: Add trampoline code for kretprobes

On 06/15/2015 03:07 PM, David Long wrote: > From: William Cohen > > The trampoline code is used by kretprobes to capture a return from a probed > function. This is done by saving the registers, calling the handler, and > restoring the registers. The code then returns to th

Re: [PATCH v7 5/7] arm64: Add trampoline code for kretprobes

On 06/15/2015 03:07 PM, David Long wrote: From: William Cohen wco...@redhat.com The trampoline code is used by kretprobes to capture a return from a probed function. This is done by saving the registers, calling the handler, and restoring the registers. The code then returns to the roginal

Re: [PATCH v6 3/6] arm64: Kprobes with single stepping support

with kprobed functions being called in the kprobe handlers showed that situation was handled appropriately. There is proposed fix to address the issue with the trampoline, the attached patch. This is modeled after the way that the x86 handles the kretprobe. The trampoline directly save and rest

Re: [PATCH v6 3/6] arm64: Kprobes with single stepping support

: William Cohen wco...@redhat.com Date: Tue, 19 May 2015 10:03:30 -0400 Subject: [PATCH] Avoid using kprobe in the arm64 kretprobe trampoline The aarch64 exception handling does not allow nesting of debug exceptions. Using a kprobe in the kretprobe trampoline can cause problems if any of the functions

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 05/13/2015 03:58 PM, David Long wrote: > On 05/13/15 11:41, William Cohen wrote: >> On 05/13/2015 05:22 AM, Masami Hiramatsu wrote: >>> On 2015/05/12 21:48, William Cohen wrote: >> >>>> Hi Dave, >>>> >>>> In some of the previous

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 05/13/2015 05:22 AM, Masami Hiramatsu wrote: > On 2015/05/12 21:48, William Cohen wrote: >> Hi Dave, >> >> In some of the previous diagnostic output it looked like things would go >> wrong >> in the entry.S when the D bit was cleared and the debug interru

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 05/13/2015 03:58 PM, David Long wrote: On 05/13/15 11:41, William Cohen wrote: On 05/13/2015 05:22 AM, Masami Hiramatsu wrote: On 2015/05/12 21:48, William Cohen wrote: Hi Dave, In some of the previous diagnostic output it looked like things would go wrong in the entry.S when the D

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 05/13/2015 05:22 AM, Masami Hiramatsu wrote: On 2015/05/12 21:48, William Cohen wrote: Hi Dave, In some of the previous diagnostic output it looked like things would go wrong in the entry.S when the D bit was cleared and the debug interrupts were unmasksed. I wonder if some

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 05/12/2015 01:54 AM, David Long wrote: > On 05/05/15 11:48, Will Deacon wrote: >> On Tue, May 05, 2015 at 06:14:51AM +0100, David Long wrote: >>> On 05/01/15 21:44, William Cohen wrote: >>>> Dave Long and I did some additional experimentation to better >>&g

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 05/12/2015 01:54 AM, David Long wrote: On 05/05/15 11:48, Will Deacon wrote: On Tue, May 05, 2015 at 06:14:51AM +0100, David Long wrote: On 05/01/15 21:44, William Cohen wrote: Dave Long and I did some additional experimentation to better understand what is condition causes the kernel

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 05/05/2015 05:02 PM, William Cohen wrote: > On 05/05/2015 11:48 AM, Will Deacon wrote: >> On Tue, May 05, 2015 at 06:14:51AM +0100, David Long wrote: >>> On 05/01/15 21:44, William Cohen wrote: >>>> Dave Long and I did some additional experimentation to better >

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 05/05/2015 11:48 AM, Will Deacon wrote: > On Tue, May 05, 2015 at 06:14:51AM +0100, David Long wrote: >> On 05/01/15 21:44, William Cohen wrote: >>> Dave Long and I did some additional experimentation to better >>> understand what is condition causes t

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 05/05/2015 11:48 AM, Will Deacon wrote: > On Tue, May 05, 2015 at 06:14:51AM +0100, David Long wrote: >> On 05/01/15 21:44, William Cohen wrote: >>> Dave Long and I did some additional experimentation to better >>> understand what is condition causes t

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 05/05/2015 05:02 PM, William Cohen wrote: On 05/05/2015 11:48 AM, Will Deacon wrote: On Tue, May 05, 2015 at 06:14:51AM +0100, David Long wrote: On 05/01/15 21:44, William Cohen wrote: Dave Long and I did some additional experimentation to better understand what is condition causes

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 05/05/2015 11:48 AM, Will Deacon wrote: On Tue, May 05, 2015 at 06:14:51AM +0100, David Long wrote: On 05/01/15 21:44, William Cohen wrote: Dave Long and I did some additional experimentation to better understand what is condition causes the kernel to sometimes spew: Unexpected kernel

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 05/05/2015 11:48 AM, Will Deacon wrote: On Tue, May 05, 2015 at 06:14:51AM +0100, David Long wrote: On 05/01/15 21:44, William Cohen wrote: Dave Long and I did some additional experimentation to better understand what is condition causes the kernel to sometimes spew: Unexpected kernel

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 04/29/2015 06:23 AM, Will Deacon wrote: > On Tue, Apr 28, 2015 at 03:58:21AM +0100, William Cohen wrote: >> Hi All, > > Hi Will, > >> I have been experimenting with the patches for arm64 kprobes support. >> On occasion the kernel gets stuck in a loop printing ou

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 04/29/2015 06:23 AM, Will Deacon wrote: On Tue, Apr 28, 2015 at 03:58:21AM +0100, William Cohen wrote: Hi All, Hi Will, I have been experimenting with the patches for arm64 kprobes support. On occasion the kernel gets stuck in a loop printing output: Unexpected kernel single-step

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

Hi All, I have been experimenting with the patches for arm64 kprobes support. On occasion the kernel gets stuck in a loop printing output: Unexpected kernel single-step exception at EL1 This message by itself is not that enlighten. I added the attached patch to get some additional

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

Hi All, I have been experimenting with the patches for arm64 kprobes support. On occasion the kernel gets stuck in a loop printing output: Unexpected kernel single-step exception at EL1 This message by itself is not that enlighten. I added the attached patch to get some additional

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 04/21/2015 07:42 AM, Masami Hiramatsu wrote: > (2015/04/21 5:19), David Long wrote: >> From: "David A. Long" >> >> This patchset is heavily based on Sandeepa Prabhu's ARM v8 kprobes patches, >> first seen in October 2013. This version attempts to address concerns raised >> by >> reviewers and

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 04/21/2015 07:42 AM, Masami Hiramatsu wrote: (2015/04/21 5:19), David Long wrote: From: David A. Long dave.l...@linaro.org This patchset is heavily based on Sandeepa Prabhu's ARM v8 kprobes patches, first seen in October 2013. This version attempts to address concerns raised by

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 04/21/2015 07:42 AM, Masami Hiramatsu wrote: > (2015/04/21 5:19), David Long wrote: >> From: "David A. Long" >> >> This patchset is heavily based on Sandeepa Prabhu's ARM v8 kprobes patches, >> first seen in October 2013. This version attempts to address concerns raised >> by >> reviewers and

Re: [PATCH v6 0/6] arm64: Add kernel probes (kprobes) support

On 04/21/2015 07:42 AM, Masami Hiramatsu wrote: (2015/04/21 5:19), David Long wrote: From: David A. Long dave.l...@linaro.org This patchset is heavily based on Sandeepa Prabhu's ARM v8 kprobes patches, first seen in October 2013. This version attempts to address concerns raised by

Re: Perf event operation with hotplug cpus and cgroups

On 03/20/2015 04:20 PM, Peter Zijlstra wrote: > On Fri, Mar 20, 2015 at 03:41:54PM -0400, William Cohen wrote: >> >> There isn't any desire to aggregate the different cgroup data >> together. The desired grouping is measurements per cgroup, kind of >> like the pid scopin

Re: Perf event operation with hotplug cpus and cgroups

On 03/20/2015 04:20 PM, Peter Zijlstra wrote: On Fri, Mar 20, 2015 at 03:41:54PM -0400, William Cohen wrote: There isn't any desire to aggregate the different cgroup data together. The desired grouping is measurements per cgroup, kind of like the pid scoping for perf but for a cgroup

Re: Perf event operation with hotplug cpus and cgroups

On 03/20/2015 03:22 PM, Peter Zijlstra wrote: > On Fri, Mar 20, 2015 at 03:10:39PM -0400, William Cohen wrote: >> cgroup monitoring >> >> The cgroup monitoring is built on the perf event per cpu monitoring. >> If the cgroup is not pinned to a particular set of pro

  1   2   >