Re: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-08 Thread Xu Yilun
On Fri, Apr 09, 2021 at 12:02:47PM +0800, Wu, Hao wrote: > > > > > > > > > + > > > > > > > > > +static void dfl_spi_altera_remove(struct dfl_device *dfl_dev) > > > > > > > > > +{ > > > > > > > > > +struct dfl_altera_spi *aspi = dev_get_drvdata(_dev->dev); > > > > > > > > > + > > > > > > > > >

Re: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-08 Thread Xu Yilun
On Thu, Apr 08, 2021 at 11:53:06AM -0700, Moritz Fischer wrote: > On Thu, Apr 08, 2021 at 09:20:19AM +, Wu, Hao wrote: > > > On Thu, Apr 08, 2021 at 03:30:15PM +0800, Wu, Hao wrote: > > > > > > On Mon, 5 Apr 2021, Moritz Fischer wrote: > > > > > > > > > > > > > Hi Matthew, > > > > > > > > > >

Re: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-08 Thread Xu Yilun
On Thu, Apr 08, 2021 at 05:20:19PM +0800, Wu, Hao wrote: > > On Thu, Apr 08, 2021 at 03:30:15PM +0800, Wu, Hao wrote: > > > > > On Mon, 5 Apr 2021, Moritz Fischer wrote: > > > > > > > > > > > Hi Matthew, > > > > > > > > > > > > On Mon, Apr 05, 2021 at 04:53:00PM -0700, > > > >

Re: [PATCH 2/3] fpga: dfl: Add DFL bus driver for Altera SPI Master

2021-04-08 Thread Xu Yilun
On Thu, Apr 08, 2021 at 03:30:15PM +0800, Wu, Hao wrote: > > > On Mon, 5 Apr 2021, Moritz Fischer wrote: > > > > > > > Hi Matthew, > > > > > > > > On Mon, Apr 05, 2021 at 04:53:00PM -0700, > > matthew.gerl...@linux.intel.com wrote: > > > > > From: Matthew Gerlach > > > > > > > > > > This patch

Re: [PATCH 3/3] hwmon: intel-m10-bmc-hwmon: add sensor support of Intel D5005 card

2021-04-05 Thread Xu Yilun
On Mon, Apr 05, 2021 at 04:53:01PM -0700, matthew.gerl...@linux.intel.com wrote: > From: Matthew Gerlach > > Like the Intel N3000 card, the Intel D5005 has a MAX10 based > BMC. This commit adds support for the D5005 sensors that are > monitored by the MAX10 BMC. > > Signed-off-by: Matthew

Re: [PATCH v12 0/2] UIO support for dfl devices

2021-03-24 Thread Xu Yilun
and go with next pull request? Thanks, Yilun On Mon, Mar 08, 2021 at 09:59:34AM +0800, Xu Yilun wrote: > This patchset supports some dfl device drivers written in userspace. > > There are some Q about why UIO driver is needed in v11: > > >From Greg: > Why are you saying th

Re: [PATCH v12 0/2] UIO support for dfl devices

2021-03-15 Thread Xu Yilun
Hi Greg: I listed below some answers from Moritz and Yilun from previous mails for your question. Do you have more comments? Thanks in advance, Yilun On Mon, Mar 08, 2021 at 09:59:34AM +0800, Xu Yilun wrote: > This patchset supports some dfl device drivers written in usersp

[PATCH v4 1/4] mfd: intel-m10-bmc: Fix the register access range

2021-03-10 Thread Xu Yilun
This patch fixes the max register address of MAX 10 BMC. The range 0x2000 ~ 0x20fc are for control registers of the QSPI flash controller, which are not accessible to host. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix Acked-for-MFD-by: Lee Jones --- v2: no change. v3: no change

[PATCH v4 0/4] Some improvement for Intel MAX 10 MFD drivers

2021-03-10 Thread Xu Yilun
Rix as the reviewer for intel-m10-bmc mfd driver and the subdev drivers. - Rebased to 5.12-rc1 Main changes from v3: - Improve the comments for valid version check. Matthew Gerlach (1): mfd: intel-m10-bmc: Add access table configuration to the regmap Xu Yilun (3): mfd: intel-m10-bmc: Fix

[PATCH v4 2/4] mfd: intel-m10-bmc: Simplify the legacy version reg definition

2021-03-10 Thread Xu Yilun
The version register is the only one in the legacy I/O space to be accessed, so it is not necessary to define the legacy base & version register offset. A direct definition of the legacy version register address would be fine. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix --- v3: no ch

[PATCH v4 3/4] mfd: intel-m10-bmc: Add access table configuration to the regmap

2021-03-10 Thread Xu Yilun
From: Matthew Gerlach This patch adds access tables to the MAX 10 BMC regmap. This prevents the host from accessing the unwanted I/O space. It also filters out the invalid outputs when reading the regmap debugfs interface. Signed-off-by: Matthew Gerlach Signed-off-by: Xu Yilun Reviewed

[PATCH v4 4/4] MAINTAINERS: Add entry for Intel MAX 10 mfd driver

2021-03-10 Thread Xu Yilun
This patch adds maintainer info for Intel MAX 10 mfd driver. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix Acked-for-MFD-by: Lee Jones --- v3: Add Tom Rix as the reviewer. v4: Add Lee's Acked-by, no other change. --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git

Re: [PATCH v3 2/4] mfd: intel-m10-bmc: Simplify the legacy version reg definition

2021-03-10 Thread Xu Yilun
On Wed, Mar 10, 2021 at 09:16:25AM +, Lee Jones wrote: > On Mon, 01 Mar 2021, Xu Yilun wrote: > > > The version register is the only one in the legacy I/O space to be > > accessed, so it is not necessary to define the legacy base & version > > register

Re: [PATCH v3 0/4] Some improvement for Intel MAX 10 MFD drivers

2021-03-08 Thread Xu Yilun
On Mon, Mar 08, 2021 at 09:01:24AM +, Lee Jones wrote: > On Mon, 08 Mar 2021, Xu Yilun wrote: > > > Hi Lee: > > > > Could you please help on review this patchset? They are some > > improvements for intel-m10-bmc MFD driver. > > Please don't send conte

Re: [PATCH v3 0/4] Some improvement for Intel MAX 10 MFD drivers

2021-03-07 Thread Xu Yilun
Hi Lee: Could you please help on review this patchset? They are some improvements for intel-m10-bmc MFD driver. Thanks, Yilun On Mon, Mar 01, 2021 at 01:59:41PM +0800, Xu Yilun wrote: > This patchset is some improvements for intel-m10-bmc and its subdevs. > > Main changes from v1

[PATCH v12 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-03-07 Thread Xu Yilun
This patch adds description for UIO support for dfl devices on DFL bus. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix Reviewed-by: Wu Hao --- v2: no doc in v1, add it for v2. v3: some documentation fixes. v4: documentation change since the driver matching is changed. v5: no change. v6: improve

[PATCH v12 0/2] UIO support for dfl devices

2021-03-07 Thread Xu Yilun
e Feature List) bus device to userspace, a DFL driver for UIO is needed to bind to it. See the original message in: https://lore.kernel.org/linux-fpga/ydvq8ao8v3nhl...@epycbox.lan/T/#m91b303fd61485644353fad1e1e9c11d528844684 Xu Yilun (2): uio: uio_dfl: add userspace i/o driver for DFL bus

[PATCH v12 1/2] uio: uio_dfl: add userspace i/o driver for DFL bus

2021-03-07 Thread Xu Yilun
This patch supports the DFL drivers be written in userspace. This is realized by exposing the userspace I/O device interfaces. The driver now only binds the ether group feature, which has no irq. So the irq support is not implemented yet. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix --- v9

[PATCH v3 4/4] MAINTAINERS: Add entry for Intel MAX 10 mfd driver

2021-02-28 Thread Xu Yilun
This patch adds maintainer info for Intel MAX 10 mfd driver. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix --- v3: Add Tom Rix as the reviewer. --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b58a469..ab31c01 100644

[PATCH v3 3/4] mfd: intel-m10-bmc: Add access table configuration to the regmap

2021-02-28 Thread Xu Yilun
From: Matthew Gerlach This patch adds access tables to the MAX 10 BMC regmap. This prevents the host from accessing the unwanted I/O space. It also filters out the invalid outputs when reading the regmap debugfs interface. Signed-off-by: Matthew Gerlach Signed-off-by: Xu Yilun Reviewed

[PATCH v3 1/4] mfd: intel-m10-bmc: Fix the register access range

2021-02-28 Thread Xu Yilun
This patch fixes the max register address of MAX 10 BMC. The range 0x2000 ~ 0x20fc are for control registers of the QSPI flash controller, which are not accessible to host. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix --- v2: no change. v3: no change, rebased to 5.12-rc1 --- include

[PATCH v3 0/4] Some improvement for Intel MAX 10 MFD drivers

2021-02-28 Thread Xu Yilun
Rix as the reviewer for intel-m10-bmc mfd driver and the subdev drivers. - Rebased to 5.12-rc1 Matthew Gerlach (1): mfd: intel-m10-bmc: Add access table configuration to the regmap Xu Yilun (3): mfd: intel-m10-bmc: Fix the register access range mfd: intel-m10-bmc: Simplify the legacy

[PATCH v3 2/4] mfd: intel-m10-bmc: Simplify the legacy version reg definition

2021-02-28 Thread Xu Yilun
The version register is the only one in the legacy I/O space to be accessed, so it is not necessary to define the legacy base & version register offset. A direct definition of the legacy version register address would be fine. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix --- v3: no ch

Re: [RESEND PATCH v11 1/2] uio: uio_dfl: add userspace i/o driver for DFL bus

2021-02-27 Thread Xu Yilun
On Sat, Feb 27, 2021 at 04:42:55PM +0100, Greg KH wrote: > On Sat, Feb 27, 2021 at 11:27:03PM +0800, Xu Yilun wrote: > > This patch supports the DFL drivers be written in userspace. This is > > realized by exposing the userspace I/O device interfaces. > > > > The driv

[RESEND PATCH v11 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-02-27 Thread Xu Yilun
This patch adds description for UIO support for dfl devices on DFL bus. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix Reviewed-by: Wu Hao --- v2: no doc in v1, add it for v2. v3: some documentation fixes. v4: documentation change since the driver matching is changed. v5: no change. v6: improve

[RESEND PATCH v11 1/2] uio: uio_dfl: add userspace i/o driver for DFL bus

2021-02-27 Thread Xu Yilun
This patch supports the DFL drivers be written in userspace. This is realized by exposing the userspace I/O device interfaces. The driver now only binds the ether group feature, which has no irq. So the irq support is not implemented yet. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix --- v9

[RESEND PATCH v11 0/2] UIO support for dfl devices

2021-02-27 Thread Xu Yilun
header, add detailed path for opae uio example in Kconfig. Main changes from v10: - add description in doc that interrupt support is not implemented yet. Xu Yilun (2): uio: uio_dfl: add userspace i/o driver for DFL bus Documentation: fpga: dfl: Add description for DFL UIO s

Re: [PATCH v11 0/2] UIO support for dfl devices

2021-02-27 Thread Xu Yilun
Hi Greg: On Fri, Feb 26, 2021 at 07:40:56AM +0100, Greg KH wrote: > On Fri, Feb 26, 2021 at 09:22:37AM +0800, Xu Yilun wrote: > > On Mon, Feb 22, 2021 at 10:56:45AM -0800, Tom Rix wrote: > > > Yilun, > > > > > > Is there anything outstanding or remaining

Re: [PATCH v11 0/2] UIO support for dfl devices

2021-02-25 Thread Xu Yilun
) for pdev creation. > > > > Main changes from v7: > > - some doc fixes. > > > > Main changes from v8: > > - switch to add a uio driver in drivers/uio > > > > Main changes from v9: > > - add this source file in MAINTAINERS > > - improve the Kcon

[PATCH v11 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-02-03 Thread Xu Yilun
This patch adds description for UIO support for dfl devices on DFL bus. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix Reviewed-by: Wu Hao --- v2: no doc in v1, add it for v2. v3: some documentation fixes. v4: documentation change since the driver matching is changed. v5: no change. v6: improve

[PATCH v11 1/2] uio: uio_dfl: add userspace i/o driver for DFL bus

2021-02-03 Thread Xu Yilun
This patch supports the DFL drivers be written in userspace. This is realized by exposing the userspace I/O device interfaces. The driver now only binds the ether group feature, which has no irq. So the irq support is not implemented yet. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix --- v9

[PATCH v11 0/2] UIO support for dfl devices

2021-02-03 Thread Xu Yilun
header, add detailed path for opae uio example in Kconfig. Main changes from v10: - add description in doc that interrupt support is not implemented yet. Xu Yilun (2): uio: uio_dfl: add userspace i/o driver for DFL bus Documentation: fpga: dfl: Add description for DFL UIO s

Re: [PATCH v10 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-02-01 Thread Xu Yilun
On Mon, Feb 01, 2021 at 08:59:06PM +0800, Wu, Hao wrote: > > Subject: [PATCH v10 2/2] Documentation: fpga: dfl: Add description for DFL > > UIO > > support > > > > This patch adds description for UIO support for dfl devices on DFL > > bus. > > > > S

[PATCH v10 0/2] UIO support for dfl devices

2021-01-31 Thread Xu Yilun
tive Kconfig header, add detailed path for opae uio example in Kconfig. Xu Yilun (2): uio: uio_dfl: add userspace i/o driver for DFL bus Documentation: fpga: dfl: Add description for DFL UIO support Documentation/fpga/dfl.rst | 23 MAINTAINERS| 1 + drivers/uio/K

[PATCH v10 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-01-31 Thread Xu Yilun
This patch adds description for UIO support for dfl devices on DFL bus. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix --- v2: no doc in v1, add it for v2. v3: some documentation fixes. v4: documentation change since the driver matching is changed. v5: no change. v6: improve the title

[PATCH v10 1/2] uio: uio_dfl: add userspace i/o driver for DFL bus

2021-01-31 Thread Xu Yilun
This patch supports the DFL drivers be written in userspace. This is realized by exposing the userspace I/O device interfaces. The driver now only binds the ether group feature, which has no irq. So the irq support is not implemented yet. Signed-off-by: Xu Yilun --- v9: switch to add a uio

Re: [PATCH v2 4/4] MAINTAINERS: Add entry for Intel MAX 10 mfd driver

2021-01-26 Thread Xu Yilun
On Tue, Jan 26, 2021 at 07:06:17AM -0800, Tom Rix wrote: > > On 1/25/21 10:50 PM, Xu Yilun wrote: > > This patch adds maintainer info for Intel MAX 10 mfd driver. > > > > Signed-off-by: Xu Yilun > > --- > > MAINTAINERS | 9 + > > 1 file c

[PATCH v9 0/2] UIO support for dfl devices

2021-01-26 Thread Xu Yilun
mprovement. Main changes from v6: - use platform_device_register_resndata() for pdev creation. Main changes from v7: - some doc fixes. Main changes from v9: - switch to add a uio driver in drivers/uio Xu Yilun (2): uio: uio_dfl: add userspace i/o driver for DFL bus Documentation: fpga: dfl: Add description

[PATCH v9 1/2] uio: uio_dfl: add userspace i/o driver for DFL bus

2021-01-26 Thread Xu Yilun
This patch supports the DFL drivers be written in userspace. This is realized by exposing the userspace I/O device interfaces. The driver now only binds the ether group feature, which has no irq. So the irq support is not implemented yet. Signed-off-by: Xu Yilun --- v9: switch to add a uio

[PATCH v2 1/4] mfd: intel-m10-bmc: Fix the register access range

2021-01-26 Thread Xu Yilun
This patch fixes the max register address of MAX 10 BMC. The range 0x2000 ~ 0x20fc are for control registers of the QSPI flash controller, which are not accessible to host. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix --- v2: no change. --- include/linux/mfd/intel-m10-bmc.h | 2 +- 1

[PATCH v2 0/4] Some improvement for Intel MAX 10 MFD drivers

2021-01-26 Thread Xu Yilun
: intel-m10-bmc: Add access table configuration to the regmap Xu Yilun (3): mfd: intel-m10-bmc: Fix the register access range mfd: intel-m10-bmc: Simplify the legacy version reg definition MAINTAINERS: Add entry for Intel MAX 10 mfd driver MAINTAINERS | 9

[PATCH v2 3/4] mfd: intel-m10-bmc: Add access table configuration to the regmap

2021-01-26 Thread Xu Yilun
From: Matthew Gerlach This patch adds access tables to the MAX 10 BMC regmap. This prevents the host from accessing the unwanted I/O space. It also filters out the invalid outputs when reading the regmap debugfs interface. Signed-off-by: Matthew Gerlach Signed-off-by: Xu Yilun --- v2

[PATCH v2 4/4] MAINTAINERS: Add entry for Intel MAX 10 mfd driver

2021-01-26 Thread Xu Yilun
This patch adds maintainer info for Intel MAX 10 mfd driver. Signed-off-by: Xu Yilun --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5aa18cb..10985d3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -9132,6 +9132,15 @@ F: include

[PATCH v2 2/4] mfd: intel-m10-bmc: Simplify the legacy version reg definition

2021-01-26 Thread Xu Yilun
The version register is the only one in the legacy I/O space to be accessed, so it is not necessary to define the legacy base & version register offset. A direct definition of the legacy version register address would be fine. Signed-off-by: Xu Yilun --- drivers/mfd/intel-m10-bmc.c

Re: [PATCH v9 1/2] uio: uio_dfl: add userspace i/o driver for DFL bus

2021-01-26 Thread Xu Yilun
On Mon, Jan 25, 2021 at 06:22:55PM -0800, Moritz Fischer wrote: > On Mon, Jan 25, 2021 at 11:00:38AM -0800, Tom Rix wrote: > > > > On 1/25/21 12:49 AM, Xu Yilun wrote: > > > This patch supports the DFL drivers be written in userspace. This is > > > realized by

Re: [PATCH v9 1/2] uio: uio_dfl: add userspace i/o driver for DFL bus

2021-01-26 Thread Xu Yilun
On Mon, Jan 25, 2021 at 11:00:38AM -0800, Tom Rix wrote: > > On 1/25/21 12:49 AM, Xu Yilun wrote: > > This patch supports the DFL drivers be written in userspace. This is > > realized by exposing the userspace I/O device interfaces. > > > > The driver now only binds

[PATCH v9 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-01-25 Thread Xu Yilun
This patch adds description for UIO support for dfl devices on DFL bus. Signed-off-by: Xu Yilun --- v2: no doc in v1, add it for v2. v3: some documentation fixes. v4: documentation change since the driver matching is changed. v5: no change. v6: improve the title of the userspace driver support

Re: [PATCH v6 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2021-01-21 Thread Xu Yilun
0100, Greg KH wrote: > > >> On Wed, Jan 13, 2021 at 09:54:07AM +0800, Xu Yilun wrote: > > >>> This patch supports the DFL drivers be written in userspace. This is > > >>> realized by exposing the userspace I/O device interfaces. > > >>> > >

Re: [PATCH 2/2] mfd: intel-m10-bmc: add access table configuration to the regmap

2021-01-21 Thread Xu Yilun
On Thu, Jan 21, 2021 at 05:19:56AM -0800, Tom Rix wrote: > > On 1/21/21 12:05 AM, Xu Yilun wrote: > > On Wed, Jan 20, 2021 at 07:32:53AM -0800, Tom Rix wrote: > >> On 1/19/21 6:34 PM, Xu Yilun wrote: > >>> From: Matthew Gerlach > >>> > >>&g

[PATCH v8 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-01-21 Thread Xu Yilun
This patch adds description for UIO support for dfl devices on DFL bus. Signed-off-by: Xu Yilun --- v2: no doc in v1, add it for v2. v3: some documentation fixes. v4: documentation change since the driver matching is changed. v5: no change. v6: improve the title of the userspace driver support

[PATCH v8 0/2] UIO support for dfl devices

2021-01-21 Thread Xu Yilun
in changes from v4: - refactor the irq handling code. Main changes from v5: - fix the res[] zero initialization issue. - improve the return code for probe(). - some doc improvement. Main changes from v6: - use platform_device_register_resndata() for pdev creation. Main changes from v7: - some doc fix

[PATCH v8 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2021-01-21 Thread Xu Yilun
provide support to userspace access to kernel interrupts and memory locations. The driver now supports the ether group feature. To support a new DFL feature been directly accessed via UIO, its feature id should be added to the driver's id_table. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix Acked

Re: [PATCH 2/2] mfd: intel-m10-bmc: add access table configuration to the regmap

2021-01-21 Thread Xu Yilun
On Wed, Jan 20, 2021 at 07:32:53AM -0800, Tom Rix wrote: > > On 1/19/21 6:34 PM, Xu Yilun wrote: > > From: Matthew Gerlach > > > > This patch adds access tables to the MAX 10 BMC regmap. This prevents > > the host from accessing the unwanted I/O space. It also filte

Re: [PATCH] spi: altera: Fix memory leak on error path

2021-01-20 Thread Xu Yilun
On Wed, Jan 20, 2021 at 12:26:35AM -0800, Pan Bian wrote: > Release master that have been previously allocated if the number of > chipselect is invalid. > > Fixes: 8e04187c1bc7 ("spi: altera: add SPI core parameters support via > platform data.") > Signed-off-by: Pan Bian > --- >

[PATCH 2/2] mfd: intel-m10-bmc: add access table configuration to the regmap

2021-01-19 Thread Xu Yilun
From: Matthew Gerlach This patch adds access tables to the MAX 10 BMC regmap. This prevents the host from accessing the unwanted I/O space. It also filters out the invalid outputs when reading the regmap debugfs interface. Signed-off-by: Matthew Gerlach Signed-off-by: Xu Yilun --- drivers

Re: [PATCH v7 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-01-19 Thread Xu Yilun
On Tue, Jan 19, 2021 at 07:12:24PM -0800, Randy Dunlap wrote: > Doc suggestions: > > On 1/19/21 6:43 PM, Xu Yilun wrote: > > This patch adds description for UIO support for dfl devices on DFL > > bus. > > > > Signed-off-by: Xu Yilun > > --- > >

[PATCH v7 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-01-19 Thread Xu Yilun
This patch adds description for UIO support for dfl devices on DFL bus. Signed-off-by: Xu Yilun --- v2: no doc in v1, add it for v2. v3: some documentation fixes. v4: documentation change since the driver matching is changed. v5: no change. v6: improve the title of the userspace driver support

[PATCH v7 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2021-01-19 Thread Xu Yilun
provide support to userspace access to kernel interrupts and memory locations. The driver now supports the ether group feature. To support a new DFL feature been directly accessed via UIO, its feature id should be added to the driver's id_table. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix Acked

[PATCH v7 0/2] UIO support for dfl devices

2021-01-19 Thread Xu Yilun
in changes from v4: - refactor the irq handling code. Main changes from v5: - fix the res[] zero initialization issue. - improve the return code for probe(). - some doc improvement. Main changes from v6: - use platform_device_register_resndata() for pdev creation. Xu Yilun (2): fpga: dfl: add th

[PATCH 1/2] mfd: intel-m10-bmc: fix the register access range

2021-01-19 Thread Xu Yilun
This patch fixes the max register address of MAX 10 BMC. The range 0x2000 ~ 0x20fc are for control registers of the QSPI flash controller, which are not accessible to host. Signed-off-by: Xu Yilun --- include/linux/mfd/intel-m10-bmc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [PATCH v6 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-01-17 Thread Xu Yilun
On Sat, Jan 16, 2021 at 07:57:48PM -0800, Moritz Fischer wrote: > Hi Xu, > > On Wed, Jan 13, 2021 at 09:54:08AM +0800, Xu Yilun wrote: > > This patch adds description for UIO support for dfl devices on DFL > > bus. > > > > Signed-off-by: Xu Yilun > >

Re: [PATCH v6 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2021-01-17 Thread Xu Yilun
On Sat, Jan 16, 2021 at 07:56:08PM -0800, Moritz Fischer wrote: > Hi Xu, > > On Wed, Jan 13, 2021 at 09:54:07AM +0800, Xu Yilun wrote: > > This patch supports the DFL drivers be written in userspace. This is > > realized by exposing the userspace I/O device interfaces

[PATCH v6 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-01-12 Thread Xu Yilun
This patch adds description for UIO support for dfl devices on DFL bus. Signed-off-by: Xu Yilun --- v2: no doc in v1, add it for v2. v3: some documentation fixes. v4: documentation change since the driver matching is changed. v5: no change. v6: improve the title of the userspace driver support

[PATCH v6 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2021-01-12 Thread Xu Yilun
provide support to userspace access to kernel interrupts and memory locations. The driver now supports the ether group feature. To support a new DFL feature been directly accessed via UIO, its feature id should be added to the driver's id_table. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix Acked

[PATCH v6 0/2] UIO support for dfl devices

2021-01-12 Thread Xu Yilun
in changes from v4: - refactor the irq handling code. Main changes from v5: - fix the res[] zero initialization issue. - improve the return code for probe(). - some doc improvement. Xu Yilun (2): fpga: dfl: add the userspace I/O device support for DFL devices Documentation: fpga: dfl: Add d

Re: [PATCH v5 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2021-01-11 Thread Xu Yilun
On Mon, Jan 11, 2021 at 06:59:10AM -0800, Tom Rix wrote: > > On 1/10/21 10:16 PM, Xu Yilun wrote: > > On Sun, Jan 10, 2021 at 12:11:17PM -0800, Moritz Fischer wrote: > >> On Sat, Jan 02, 2021 at 11:13:01AM +0800, Xu Yilun wrote: > >>> This patch supports the DF

Re: [PATCH v5 0/2] UIO support for dfl devices

2021-01-10 Thread Xu Yilun
On Sun, Jan 10, 2021 at 11:58:44AM -0800, Moritz Fischer wrote: > Hi Xu, > > On Sat, Jan 02, 2021 at 11:13:00AM +0800, Xu Yilun wrote: > > This patchset supports some dfl device drivers written in userspace. > > > > In the patchset v1, the "driver_override&q

Re: [PATCH v5 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2021-01-10 Thread Xu Yilun
On Sun, Jan 10, 2021 at 12:11:17PM -0800, Moritz Fischer wrote: > On Sat, Jan 02, 2021 at 11:13:01AM +0800, Xu Yilun wrote: > > This patch supports the DFL drivers be written in userspace. This is > > realized by exposing the userspace I/O device interfaces. > > >

Re: [RESEND PATCH 2/2] misc: add support for retimers interfaces on Intel MAX 10 BMC

2021-01-07 Thread Xu Yilun
On Thu, Jan 07, 2021 at 03:51:38PM +0100, Andrew Lunn wrote: > On Thu, Jan 07, 2021 at 10:26:12AM +0100, Greg KH wrote: > > On Thu, Jan 07, 2021 at 02:07:08PM +0800, Xu Yilun wrote: > > > This driver supports the ethernet retimers (C827) for the Intel PAC > > > (Pro

Re: [RESEND PATCH 2/2] misc: add support for retimers interfaces on Intel MAX 10 BMC

2021-01-07 Thread Xu Yilun
On Thu, Jan 07, 2021 at 10:26:12AM +0100, Greg KH wrote: > On Thu, Jan 07, 2021 at 02:07:08PM +0800, Xu Yilun wrote: > > This driver supports the ethernet retimers (C827) for the Intel PAC > > (Programmable Acceleration Card) N3000, which is a FPGA based Smart NIC. > > &

[RESEND PATCH 2/2] misc: add support for retimers interfaces on Intel MAX 10 BMC

2021-01-06 Thread Xu Yilun
10 BMC firmware. They are configured in 4 ports 10G/25G retimer mode. Host could query their link states and firmware version information via retimer interfaces (Shared registers) on Intel MAX 10 BMC. The driver creates sysfs interfaces for users to query these information. Signed-off-by: Xu Yilun

[RESEND PATCH 0/2] Add retimer interfaces support for Intel MAX 10 BMC

2021-01-06 Thread Xu Yilun
https://github.com/OPAE/opae-sdk/ Generally it facilitate the development on all the DFL (Device Feature List) based FPGA Cards, including the management of static region & dynamic region reprogramming, accelerators accessing and the board specific peripherals. Xu Yilun (2): mfd: intel-m10-bm

[RESEND PATCH 1/2] mfd: intel-m10-bmc: specify the retimer sub devices

2021-01-06 Thread Xu Yilun
query them via retimer interfaces (shared registers) on the BMC. The 2 retimers have identical register interfaces in different register addresses or fields, so it is better we define 2 retimer devices and handle them with the same driver. Signed-off-by: Xu Yilun --- drivers/mfd/intel-m10-bmc.c

Re: [PATCH 1/2] mfd: intel-m10-bmc: specify the retimer sub devices

2021-01-06 Thread Xu Yilun
On Wed, Jan 06, 2021 at 08:23:30AM +, Lee Jones wrote: > On Wed, 06 Jan 2021, Xu Yilun wrote: > > > The patch specifies the 2 retimer sub devices and their resources in the > > parent driver's mfd_cell. It also adds the register definition of the > > retimer sub devic

Re: [PATCH 2/2] misc: add support for retimers interfaces on Intel MAX 10 BMC

2021-01-06 Thread Xu Yilun
On Wed, Jan 06, 2021 at 10:06:14AM +0100, Greg KH wrote: > On Wed, Jan 06, 2021 at 04:53:29PM +0800, Xu Yilun wrote: > > On Wed, Jan 06, 2021 at 08:56:42AM +0100, Greg KH wrote: > > > On Wed, Jan 06, 2021 at 03:36:07PM +0800, Xu Yilun wrote: > > > > This driver suppor

Re: [PATCH 2/2] misc: add support for retimers interfaces on Intel MAX 10 BMC

2021-01-06 Thread Xu Yilun
On Wed, Jan 06, 2021 at 08:56:42AM +0100, Greg KH wrote: > On Wed, Jan 06, 2021 at 03:36:07PM +0800, Xu Yilun wrote: > > This driver supports the ethernet retimers (C827) for the Intel PAC > > (Programmable Acceleration Card) N3000, which is a FPGA based Smart NIC. > > &

[PATCH 2/2] misc: add support for retimers interfaces on Intel MAX 10 BMC

2021-01-05 Thread Xu Yilun
10 BMC firmware. They are configured in 4 ports 10G/25G retimer mode. Host could query their link states and firmware version information via retimer interfaces (Shared registers) on Intel MAX 10 BMC. The driver creates sysfs interfaces for users to query these information. Signed-off-by: Xu Yilun

[PATCH 1/2] mfd: intel-m10-bmc: specify the retimer sub devices

2021-01-05 Thread Xu Yilun
query them via retimer interfaces (shared registers) on the BMC. The 2 retimers have identical register interfaces in different register addresses or fields, so it is better we define 2 retimer devices and handle them with the same driver. Signed-off-by: Xu Yilun --- drivers/mfd/intel-m10-bmc.c

[PATCH 0/2] Add retimer interfaces support for Intel MAX 10 BMC

2021-01-05 Thread Xu Yilun
version information via retimer interfaces (Shared registers) on the BMC. The driver creates sysfs interfaces for users to query these information. Xu Yilun (2): mfd: intel-m10-bmc: specify the retimer sub devices misc: add support for retimers interfaces on Intel MAX 10 BMC .../ABI/testing

Re: [PATCH v5 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-01-04 Thread Xu Yilun
On Mon, Jan 04, 2021 at 09:19:24AM -0800, Russ Weight wrote: > > > On 1/1/21 7:13 PM, Xu Yilun wrote: > > This patch adds description for UIO support for dfl devices on DFL > > bus. > > > > Signed-off-by: Xu Yilun > > --- > > v2: no doc in v1, ad

Re: [PATCH v5 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-01-03 Thread Xu Yilun
On Mon, Jan 04, 2021 at 12:24:05PM +0800, Wu, Hao wrote: > > Subject: [PATCH v5 2/2] Documentation: fpga: dfl: Add description for DFL > > UIO support > > > > This patch adds description for UIO support for dfl devices on DFL > > bus. > > > > Signed-off-

Re: [PATCH v5 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2021-01-03 Thread Xu Yilun
memory locations. > > > > The driver now supports the ether group feature. To support a new DFL > > feature been directly accessed via UIO, its feature id should be added to > > the driver's id_table. > > > > Signed-off-by: Xu Yilun > > Reviewed-by: Tom R

[PATCH v3] spi: fix the divide by 0 error when calculating xfer waiting time

2021-01-03 Thread Xu Yilun
The xfer waiting time is the result of xfer->len / xfer->speed_hz. This patch makes the assumption of 100khz xfer speed if the xfer->speed_hz is not assigned and stays 0. This avoids the divide by 0 issue and ensures a reasonable tolerant waiting time. Signed-off-by: Xu Yilun --

Re: [PATCH v2] spi: fix the divide by 0 error when calculating xfer waiting time

2021-01-03 Thread Xu Yilun
On Sat, Jan 02, 2021 at 11:11:14AM -0300, Fabio Estevam wrote: > On Sat, Jan 2, 2021 at 12:07 AM Xu Yilun wrote: > > > > The xfer waiting time is the result of xfer->len / xfer->speed_hz. This > > patch makes the assumption of 1khz xfer speed if the xfer->speed_h

[PATCH v5 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2021-01-01 Thread Xu Yilun
provide support to userspace access to kernel interrupts and memory locations. The driver now supports the ether group feature. To support a new DFL feature been directly accessed via UIO, its feature id should be added to the driver's id_table. Signed-off-by: Xu Yilun Reviewed-by: Tom Rix --- v2

[PATCH v5 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2021-01-01 Thread Xu Yilun
This patch adds description for UIO support for dfl devices on DFL bus. Signed-off-by: Xu Yilun --- v2: no doc in v1, add it for v2. v3: some documentation fixes. v4: documentation change since the driver matching is changed. v5: no change. --- Documentation/fpga/dfl.rst | 24

[PATCH v5 0/2] UIO support for dfl devices

2021-01-01 Thread Xu Yilun
in changes from v4: - refactor the irq handling code. Xu Yilun (2): fpga: dfl: add the userspace I/O device support for DFL devices Documentation: fpga: dfl: Add description for DFL UIO support Documentation/fpga/dfl.rst | 24 drivers/fpga/Kconfig| 10 + drivers/fpga/

[PATCH v2] spi: fix the divide by 0 error when calculating xfer waiting time

2021-01-01 Thread Xu Yilun
The xfer waiting time is the result of xfer->len / xfer->speed_hz. This patch makes the assumption of 1khz xfer speed if the xfer->speed_hz is not assigned and stays 0. This avoids the divide by 0 issue and ensures a reasonable tolerant waiting time. Signed-off-by: Xu Yilun --

Re: [PATCH 2/2] spi: fix the divide by 0 error when calculating xfer waiting time

2020-12-30 Thread Xu Yilun
On Wed, Dec 30, 2020 at 01:46:44PM +, Mark Brown wrote: > On Wed, Dec 30, 2020 at 10:24:20AM +0800, Xu Yilun wrote: > > On Tue, Dec 29, 2020 at 01:13:08PM +, Mark Brown wrote: > > > > Does this still apply with current code? There have been some fixes in > >

Re: [PATCH v4 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2020-12-29 Thread Xu Yilun
On Tue, Dec 29, 2020 at 06:37:37AM -0800, Tom Rix wrote: > > On 12/28/20 6:42 PM, Xu Yilun wrote: > > This patch supports the DFL drivers be written in userspace. This is > > realized by exposing the userspace I/O device interfaces. > > > > The driver leverage

Re: [PATCH 2/2] spi: fix the divide by 0 error when calculating xfer waiting time

2020-12-29 Thread Xu Yilun
On Tue, Dec 29, 2020 at 01:13:08PM +, Mark Brown wrote: > On Tue, Dec 29, 2020 at 01:27:42PM +0800, Xu Yilun wrote: > > The xfer waiting time is the result of xfer->len / xfer->speed_hz, but > > when the following patch is merged, > > > > commit 9326e4f1e5d

[PATCH 2/2] spi: fix the divide by 0 error when calculating xfer waiting time

2020-12-28 Thread Xu Yilun
d ensures a reasonable tolerant waiting time. Signed-off-by: Xu Yilun --- drivers/spi/spi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi.c b/drivers/spi/spi.c index 51d7c00..2f3c2c9 100644 --- a/drivers/spi/spi.c +++ b/drivers/spi/spi.c @@ -1109,6

[PATCH 1/2] spi: altera: fix return value for altera_spi_txrx()

2020-12-28 Thread Xu Yilun
transfer is finished, return 1 when transfer is still in progress. Signed-off-by: Xu Yilun --- drivers/spi/spi-altera.c | 26 ++ 1 file changed, 14 insertions(+), 12 deletions(-) diff --git a/drivers/spi/spi-altera.c b/drivers/spi/spi-altera.c index 809bfff..cbc4c28 100644

[PATCH 0/2] fix the issue when xfer by spi-altera

2020-12-28 Thread Xu Yilun
tolerant waiting time in a generic way. Xu Yilun (2): spi: altera: fix return value for altera_spi_txrx() spi: fix the divide by 0 error when calculating xfer waiting time drivers/spi/spi-altera.c | 26 ++ drivers/spi/spi.c| 4 +++- 2 files changed, 17 inser

[PATCH v4 2/2] Documentation: fpga: dfl: Add description for DFL UIO support

2020-12-28 Thread Xu Yilun
This patch adds description for UIO support for dfl devices on DFL bus. Signed-off-by: Xu Yilun --- v2: no doc in v1, add it for v2. v3: some documentation fixes. v4: documentation change since the driver matching is changed. --- Documentation/fpga/dfl.rst | 24 1 file

[PATCH v4 1/2] fpga: dfl: add the userspace I/O device support for DFL devices

2020-12-28 Thread Xu Yilun
provide support to userspace access to kernel interrupts and memory locations. The driver now supports the ether group feature. To support a new DFL feature been directly accessed via UIO, its feature id should be added to the driver's id_table. Signed-off-by: Xu Yilun --- v2: switch to the new

[PATCH v4 0/2] UIO support for dfl devices

2020-12-28 Thread Xu Yilun
the match ops changes in dfl.c to an independent patch. - move the declarations needed for dfl-uio-pdev from include/linux/dfl.h to driver/fpga/dfl.h - some minor fixes. Main changes from v3: - switch to specifying each matching device in the driver's id_table. - refactor the irq handling code.

[PATCH v14 6/6] memory: dfl-emif: add the DFL EMIF private feature driver

2020-12-28 Thread Xu Yilun
is to be reprogrammed. This gives users a reliable method to prevent potential data leakage. Signed-off-by: Xu Yilun Signed-off-by: Russ Weight Reviewed-by: Tom Rix Acked-by: Krzysztof Kozlowski --- v2: Adjust the position of this driver in Kconfig. Improves the name of the Kconfig option. Change

[PATCH v14 5/6] fpga: dfl: add support for N3000 Nios private feature

2020-12-28 Thread Xu Yilun
SPI work. [m...@kernel.org: Fixed up MAINTAINERS file to include added ABI doc] Signed-off-by: Xu Yilun Signed-off-by: Wu Hao Signed-off-by: Matthew Gerlach Signed-off-by: Russ Weight Signed-off-by: YueHaibing Reviewed-by: Tom Rix --- v3: add the doc for this driver minor fixes

[PATCH v14 4/6] fpga: dfl: move dfl bus related APIs to include/linux/dfl.h

2020-12-28 Thread Xu Yilun
to match filename] Signed-off-by: Xu Yilun Reviewed-by: Tom Rix Acked-by: Wu Hao Signed-off-by: Moritz Fischer --- v2: updated the MAINTAINERS under FPGA DFL DRIVERS improve the comments rename the dfl-bus.h to dfl.h v3: rebase the patch for previous changes v9: rebase the patch for bus

  1   2   3   4   5   >