Re: [PATCH 3/3] rtc: s5m: Make register configuration per S2MPS device to remove exceptions

Hi Krysztof, On Tue, Dec 29, 2015 at 5:53 PM, Krzysztof Kozlowski wrote: > Before updating time and alarm the driver must set appropriate mask in > UDR register. For that purpose the driver uses common register > configuration and a lot of exceptions per device in the code. The > exceptions are

Re: [PATCH 3/3] rtc: s5m: Make register configuration per S2MPS device to remove exceptions

Hi Krysztof, On Tue, Dec 29, 2015 at 5:53 PM, Krzysztof Kozlowski wrote: > Before updating time and alarm the driver must set appropriate mask in > UDR register. For that purpose the driver uses common register > configuration and a lot of exceptions per device in the

[PATCH v2] thermal: cpu_cooling: Update always cpufreq policy with thermal constraints

required, otherwise its causing an issue while increasing max_freq in normal scenerio as it restores max_freq with policy->user_policy.max which is old (smaller) value. Signed-off-by: Yadwinder Singh Brar --- changes since v1: - Updated commit message as suggested by Eduardo Valentin - fixed an issue

RE: [PATCH] thermal: cpu_cooling: Update always cpufreq policy with thermal constraints

Hello Eduardo Valentin, On Thursday, November 06, 2014 1:19 PM, Eduardo Valentin wrote: > Hello Yadwinder, > > On Thu, Nov 06, 2014 at 04:26:27PM +0530, Yadwinder Singh Brar wrote: > > Hello Eduardo Valentin, > > > > On Thursday, November 06, 2014 2:17 AM, Eduardo

RE: [PATCH] thermal: cpu_cooling: Update always cpufreq policy with thermal constraints

Hello Eduardo Valentin, On Thursday, November 06, 2014 1:19 PM, Eduardo Valentin wrote: Hello Yadwinder, On Thu, Nov 06, 2014 at 04:26:27PM +0530, Yadwinder Singh Brar wrote: Hello Eduardo Valentin, On Thursday, November 06, 2014 2:17 AM, Eduardo Valentin wrote: Hello Yadwinder

[PATCH v2] thermal: cpu_cooling: Update always cpufreq policy with thermal constraints

its causing an issue while increasing max_freq in normal scenerio as it restores max_freq with policy-user_policy.max which is old (smaller) value. Signed-off-by: Yadwinder Singh Brar yadi.b...@samsung.com --- changes since v1: - Updated commit message as suggested by Eduardo Valentin - fixed

RE: [PATCH] thermal: cpu_cooling: Update always cpufreq policy with thermal constraints

Hello Eduardo Valentin, On Thursday, November 06, 2014 2:17 AM, Eduardo Valentin wrote: > Hello Yadwinder, > > On Wed, Nov 05, 2014 at 05:46:25PM +0530, Yadwinder Singh Brar wrote: > > Existing code updates cupfreq policy only while executing > > cpufreq_apply_cooling(

RE: [PATCH] thermal: cpu_cooling: Update always cpufreq policy with thermal constraints

Hello Eduardo Valentin, On Thursday, November 06, 2014 2:17 AM, Eduardo Valentin wrote: Hello Yadwinder, On Wed, Nov 05, 2014 at 05:46:25PM +0530, Yadwinder Singh Brar wrote: Existing code updates cupfreq policy only while executing cpufreq_apply_cooling() function (i.e. when

[PATCH] thermal: cpu_cooling: Update always cpufreq policy with thermal constraints

. Signed-off-by: Yadwinder Singh Brar --- drivers/thermal/cpu_cooling.c | 37 - 1 files changed, 20 insertions(+), 17 deletions(-) diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index 1ab0018..5546278 100644 --- a/drivers/thermal

[PATCH] thermal: cpu_cooling: Update always cpufreq policy with thermal constraints

. Signed-off-by: Yadwinder Singh Brar yadi.b...@samsung.com --- drivers/thermal/cpu_cooling.c | 37 - 1 files changed, 20 insertions(+), 17 deletions(-) diff --git a/drivers/thermal/cpu_cooling.c b/drivers/thermal/cpu_cooling.c index 1ab0018..5546278 100644

Re: [PATCH v5 05/14] clk: Add generic driver for Maxim PMIC clocks

erted to use a generic driver to consolidate code > and avoid duplication. > > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Krzysztof Kozlowski > --- > > Changes since v4: > - Return recalc 0 if clock isn't enabled in Suggested by Yadwinder Singh > Brar. > It

Re: [PATCH v2] clk: s2mps11: Fix double free corruption during driver unbind

c0010324 c0010328 6013 > [ 31.212402] [] (__irq_svc) from [] > (arch_cpu_idle+0x28/0x30) > [ 31.219783] [] (arch_cpu_idle) from [] > (cpu_startup_entry+0x2c4/0x3f0) > [ 31.228027] [] (cpu_startup_entry) from [<400086c4>] (0x400086c4) > [ 31.234968] ---[ end

Re: [PATCH v2] clk: s2mps11: Fix double free corruption during driver unbind

) Cc: sta...@vger.kernel.org Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Changes since v1: 1. Allocate memory for clk_lookup with clkdev_alloc() instead of kzalloc(). Suggested by Yadwinder Singh Brar. --- Reviewed-by: Yadwinder Singh Brar yadi.b...@samsung.com Regards

Re: [PATCH v5 05/14] clk: Add generic driver for Maxim PMIC clocks

by Yadwinder Singh Brar. It seems you didn't implement or posted same patch again :) . Changes since v3: - Add current copyright information. Suggested by Krzysztof Kozlowski - Do a single allocation for struct max_gen_clk. Suggested by Krzysztof Kozlowski - Add EXPORT_SYMBOL

Re: [PATCH] clk: s2mps11: Fix double free corruption during driver unbind

Hi Krzystof, On Fri, Jun 27, 2014 at 4:04 PM, Krzysztof Kozlowski wrote: > After unbinding the driver memory was corrupted by double free of > clk_lookup structure. This lead to OOPS when re-binding the driver > again. > > The driver allocated memory for 'clk_lookup' with devm_kzalloc. During >

Re: [PATCH] clk: s2mps11: Fix double free corruption during driver unbind

Hi Krzystof, On Fri, Jun 27, 2014 at 4:04 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: After unbinding the driver memory was corrupted by double free of clk_lookup structure. This lead to OOPS when re-binding the driver again. The driver allocated memory for 'clk_lookup' with

Re: [PATCH v4 05/14] clk: Add generic driver for Maxim PMIC clocks

Hi Javier, Sorry for jumping in late, but just one concern mentioned inline. [ .. ] > + > +static unsigned long max_gen_recalc_rate(struct clk_hw *hw, > +unsigned long parent_rate) > +{ > + return 32768; > +} Isn't more safer(correct), if it check

Re: [PATCH v4 05/14] clk: Add generic driver for Maxim PMIC clocks

Hi Javier, Sorry for jumping in late, but just one concern mentioned inline. [ .. ] + +static unsigned long max_gen_recalc_rate(struct clk_hw *hw, +unsigned long parent_rate) +{ + return 32768; +} Isn't more safer(correct), if it check and

Re: [PATCH 2/3] regulator: s2mps11: Merge S2MPA01 driver

On Tue, May 27, 2014 at 1:26 PM, Krzysztof Kozlowski wrote: > On wto, 2014-05-27 at 12:00 +0530, Yadwinder Singh Brar wrote: >> On Mon, May 26, 2014 at 6:50 PM, Krzysztof Kozlowski >> wrote: >> > Add S2MPA01 support to the s2mps11 regulator driver. This obsoletes th

Re: [PATCH 2/3] regulator: s2mps11: Merge S2MPA01 driver

On Mon, May 26, 2014 at 6:50 PM, Krzysztof Kozlowski wrote: > Add S2MPA01 support to the s2mps11 regulator driver. This obsoletes the > s2mpa01 regulator driver. > > Signed-off-by: Krzysztof Kozlowski > @@ -216,30 +250,20 @@ static int s2mps11_set_ramp_delay(struct regulator_dev > *rdev, int

Re: [PATCH 1/3] regulator: s2mps11: Refactor setting ramp delay

Hi Krzysztof, On Mon, May 26, 2014 at 6:50 PM, Krzysztof Kozlowski wrote: > Prepare for merging the s2mpa01 regulator driver into s2mps11 by: > 1. Adding common id for buck regulators. > 2. Splitting shared ramp delay settings to match S2MPA01. > 3. Adding a configuration of registers for

Re: [PATCH 1/3] regulator: s2mps11: Refactor setting ramp delay

Hi Krzysztof, On Mon, May 26, 2014 at 6:50 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Prepare for merging the s2mpa01 regulator driver into s2mps11 by: 1. Adding common id for buck regulators. 2. Splitting shared ramp delay settings to match S2MPA01. 3. Adding a configuration of

Re: [PATCH 2/3] regulator: s2mps11: Merge S2MPA01 driver

On Mon, May 26, 2014 at 6:50 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Add S2MPA01 support to the s2mps11 regulator driver. This obsoletes the s2mpa01 regulator driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com @@ -216,30 +250,20 @@ static int

Re: [PATCH 2/3] regulator: s2mps11: Merge S2MPA01 driver

On Tue, May 27, 2014 at 1:26 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: On wto, 2014-05-27 at 12:00 +0530, Yadwinder Singh Brar wrote: On Mon, May 26, 2014 at 6:50 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: Add S2MPA01 support to the s2mps11 regulator driver

Re: [PATCH 1/3] clk: s2mps11: Add support for S2MPS14 clocks

On Mon, Mar 10, 2014 at 6:04 PM, Krzysztof Kozlowski wrote: > This patch adds support for S2MPS14 PMIC clocks (BT and AP) to the > s2mps11 clock driver. > > Signed-off-by: Krzysztof Kozlowski > --- Reviewed-by: Yadwinder Singh Brar Just a trivial thing, Kconfig description can

Re: [PATCH 1/3] clk: s2mps11: Add support for S2MPS14 clocks

On Mon, Mar 10, 2014 at 6:04 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: This patch adds support for S2MPS14 PMIC clocks (BT and AP) to the s2mps11 clock driver. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com --- Reviewed-by: Yadwinder Singh Brar yadi.b...@samsung.com

Re: [PATCH v2 09/14] regulator: s2mps11: Add support for S2MPS14 regulators

gt; Cc: Mark Brown > Cc: Liam Girdwood > --- Reviewed-by: Yadwinder Singh Brar Regards, Yadwinder > drivers/regulator/s2mps11.c | 252 > --- > 1 file changed, 191 insertions(+), 61 deletions(-) > > diff --git a/drivers/regulator/

Re: [PATCH v2 07/14] regulator: s2mps11: Copy supported regulators from initconst

pies 5 kB on 32-bit ARM, for S2MPS14 will occupy 3 kB). > > Signed-off-by: Krzysztof Kozlowski > Signed-off-by: Chanwoo Choi > Cc: Mark Brown > Cc: Liam Girdwood > Cc: Yadwinder Singh Brar > --- Just observed one trivial thing that in this patch, spacing is not prov

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

Hi, On Thu, Feb 13, 2014 at 2:44 PM, Krzysztof Kozlowski wrote: > S2MPS11/S2MPS14 regulators support different modes of operation: > - Always off; > - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN); > - Always on; > This is very similar to S5M8767 regulator driver which also supports >

Re: [PATCH v2 11/14] regulator: s2mps11: Add opmode for S2MPS14 regulators

Hi, On Thu, Feb 13, 2014 at 2:44 PM, Krzysztof Kozlowski k.kozlow...@samsung.com wrote: S2MPS11/S2MPS14 regulators support different modes of operation: - Always off; - On/Off controlled by pin/GPIO (PWREN/LDOEN/EMMCEN); - Always on; This is very similar to S5M8767 regulator driver which

Re: [PATCH v2 07/14] regulator: s2mps11: Copy supported regulators from initconst

will occupy 3 kB). Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Signed-off-by: Chanwoo Choi cw00.c...@samsung.com Cc: Mark Brown broo...@kernel.org Cc: Liam Girdwood lgirdw...@gmail.com Cc: Yadwinder Singh Brar yadi.bra...@gmail.com --- Just observed one trivial thing

Re: [PATCH v2 09/14] regulator: s2mps11: Add support for S2MPS14 regulators

k.kozlow...@samsung.com Cc: Mark Brown broo...@kernel.org Cc: Liam Girdwood lgirdw...@gmail.com --- Reviewed-by: Yadwinder Singh Brar yadi.b...@samsung.com Regards, Yadwinder drivers/regulator/s2mps11.c | 252 --- 1 file changed, 191 insertions(+), 61

Re: [PATCH 07/14] regulator: s2mps11: Choose number of supported regulators during probe

Hi, > > + dev_type = platform_get_device_id(pdev)->driver_data; > + switch (dev_type) { > + case S2MPS11X: > + s2mps11->rdev_num = ARRAY_SIZE(s2mps11_regulators); > + regulators = s2mps11_regulators; How about creating and passing copy of

Re: [PATCH 07/14] regulator: s2mps11: Choose number of supported regulators during probe

Hi, + dev_type = platform_get_device_id(pdev)-driver_data; + switch (dev_type) { + case S2MPS11X: + s2mps11-rdev_num = ARRAY_SIZE(s2mps11_regulators); + regulators = s2mps11_regulators; How about creating and passing copy of s2mps11_regulators

Re: [RFC v2 1/4] power: asv: Add common ASV support for Samsung SoCs

Hi Tomasz, Sorry for being late. On Sun, Dec 15, 2013 at 10:51 PM, Tomasz Figa wrote: > On Sunday 15 of December 2013 22:30:13 Yadwinder Singh Brar wrote: > [snip] >> >> + >> >> + return NULL; >> >> +} >> >> + >>

Re: [RFC v2 1/4] power: asv: Add common ASV support for Samsung SoCs

Hi Tomasz, Sorry for being late. On Sun, Dec 15, 2013 at 10:51 PM, Tomasz Figa tomasz.f...@gmail.com wrote: On Sunday 15 of December 2013 22:30:13 Yadwinder Singh Brar wrote: [snip] + + return NULL; +} + +unsigned int asv_get_volt(enum asv_type_id target_type

Re: [RFC v2 1/4] power: asv: Add common ASV support for Samsung SoCs

Hi Tomasz, Thanks for your thorough review and nice suggestions. [snip] >> +} >> + >> +static struct asv_member *asv_get_mem(enum asv_type_id asv_type) > > I don't really like this enum based look-up. It's hard to define an enum > that covers any possible existing and future platforms that would

Re: [RFC v2 1/4] power: asv: Add common ASV support for Samsung SoCs

Hi Abhilash, [ ... ] >> + * @nr_dvfs_level: Number of dvfs levels supported by member. >> + * @dvfs_table: Table containing supported ASV freqs and corresponding >> volts. >> + * @asv_grp: ASV group of member. >> + * @flags: ASV flags > What are the ASV flags you had in mind ? Right now we

Re: [RFC v2 1/4] power: asv: Add common ASV support for Samsung SoCs

Hi Abhilash, [ ... ] + * @nr_dvfs_level: Number of dvfs levels supported by member. + * @dvfs_table: Table containing supported ASV freqs and corresponding volts. + * @asv_grp: ASV group of member. + * @flags: ASV flags What are the ASV flags you had in mind ? Right now we don't have any,

Re: [RFC v2 1/4] power: asv: Add common ASV support for Samsung SoCs

Hi Tomasz, Thanks for your thorough review and nice suggestions. [snip] +} + +static struct asv_member *asv_get_mem(enum asv_type_id asv_type) I don't really like this enum based look-up. It's hard to define an enum that covers any possible existing and future platforms that would not be

Re: [RFC 0/4] Add basic support for ASV

[adding Sachin] Hi Tomasz, On Fri, Nov 15, 2013 at 12:06 AM, Tomasz Figa wrote: > Hi Yadwinder, > > On Monday 11 of November 2013 23:27:08 Yadwinder Singh Brar wrote: >> gentle ping for suggestions/reviews .. > > Hmm, I must have somehow missed this series when you orign

Re: [RFC 0/4] Add basic support for ASV

Hi MyungJoo, Thanks for your review. On Wed, Nov 13, 2013 at 11:33 AM, MyungJoo Ham wrote: > On Mon, Nov 11, 2013 at 11:27 PM, Yadwinder Singh Brar > wrote: >> gentle ping for suggestions/reviews .. >> >> >> On Wed, Sep 11, 2013 at 8:14 PM, Yadwinder Singh B

Re: [RFC 0/4] Add basic support for ASV

Hi MyungJoo, Thanks for your review. On Wed, Nov 13, 2013 at 11:33 AM, MyungJoo Ham myungjoo@samsung.com wrote: On Mon, Nov 11, 2013 at 11:27 PM, Yadwinder Singh Brar yadi.bra...@gmail.com wrote: gentle ping for suggestions/reviews .. On Wed, Sep 11, 2013 at 8:14 PM, Yadwinder Singh

Re: [RFC 0/4] Add basic support for ASV

[adding Sachin] Hi Tomasz, On Fri, Nov 15, 2013 at 12:06 AM, Tomasz Figa tomasz.f...@gmail.com wrote: Hi Yadwinder, On Monday 11 of November 2013 23:27:08 Yadwinder Singh Brar wrote: gentle ping for suggestions/reviews .. Hmm, I must have somehow missed this series when you orignally sent

Re: [RFC 0/4] Add basic support for ASV

gentle ping for suggestions/reviews .. On Wed, Sep 11, 2013 at 8:14 PM, Yadwinder Singh Brar wrote: > This series is to add basic common infrastructure for ASV. > Basically ASV is a technique used on samsung SoCs, which provides the > recommended supply voltage for dvfs of arm

Re: [PATCH 2/4] clk: clk-s2mps11: Add support for clocks in S5M8767 MFD

On Thu, Oct 31, 2013 at 3:48 PM, Tushar Behera wrote: > Since clock operation within S2MPS11 and S5M8767 are similar, we can > support both the devices within a single driver. > > Signed-off-by: Tushar Behera > CC: Yadwinder Singh Brar > CC: Mike Turquette > --- Reviewe

Re: [PATCH 1/4] clk: clk-s2mps11: Refactor for including support for other MFD clocks

st duplicate driver altogether. > > Signed-off-by: Tushar Behera > CC: Yadwinder Singh Brar > CC: Mike Turquette > --- Reviewed-by: Yadwinder Singh Brar Regards, Yadwinder > drivers/clk/clk-s2mps11.c | 20 > 1 file changed, 16 insertions(+), 4 dele

Re: [PATCH 1/4] clk: clk-s2mps11: Refactor for including support for other MFD clocks

an almost duplicate driver altogether. Signed-off-by: Tushar Behera tushar.beh...@linaro.org CC: Yadwinder Singh Brar yadi.b...@samsung.com CC: Mike Turquette mturque...@linaro.org --- Reviewed-by: Yadwinder Singh Brar yadi.b...@samsung.com Regards, Yadwinder drivers/clk/clk-s2mps11.c

Re: [PATCH 2/4] clk: clk-s2mps11: Add support for clocks in S5M8767 MFD

On Thu, Oct 31, 2013 at 3:48 PM, Tushar Behera tushar.beh...@linaro.org wrote: Since clock operation within S2MPS11 and S5M8767 are similar, we can support both the devices within a single driver. Signed-off-by: Tushar Behera tushar.beh...@linaro.org CC: Yadwinder Singh Brar yadi.b

Re: [RFC 0/4] Add basic support for ASV

gentle ping for suggestions/reviews .. On Wed, Sep 11, 2013 at 8:14 PM, Yadwinder Singh Brar yadi.b...@samsung.com wrote: This series is to add basic common infrastructure for ASV. Basically ASV is a technique used on samsung SoCs, which provides the recommended supply voltage for dvfs

Re: [PATCH v2 0/2] cpufreq: exynos: Fixes for v3.12

framework to set APLL clock > rate > Just as a fix for 3.12, these patches looks OK to me. Reviewed-by: Yadwinder Singh Brar Regards, Yadwinder > drivers/cpufreq/exynos4210-cpufreq.c | 67 - > drivers/cpufreq/exynos4x12-cpufreq.c | 69 > +++

Re: [PATCH v2 0/2] cpufreq: exynos: Fixes for v3.12

rate Just as a fix for 3.12, these patches looks OK to me. Reviewed-by: Yadwinder Singh Brar yadi.b...@samsung.com Regards, Yadwinder drivers/cpufreq/exynos4210-cpufreq.c | 67 - drivers/cpufreq/exynos4x12-cpufreq.c | 69

Re: [PATCH 2/3] clk: samsung: Add clock driver for s5pc100

Hi Tomasz, On Thu, Sep 26, 2013 at 7:30 PM, Tomasz Figa wrote: > Hi Yadwinder, > > I haven't reviewed this series yet, but let me clarify some things from > your comments. > > On Thursday 26 of September 2013 17:38:58 Yadwinder Singh Brar wrote: >> > + >> &g

Re: [PATCH 2/3] clk: samsung: Add clock driver for s5pc100

Hi Tomasz, On Thu, Sep 26, 2013 at 7:30 PM, Tomasz Figa t.f...@samsung.com wrote: Hi Yadwinder, I haven't reviewed this series yet, but let me clarify some things from your comments. On Thursday 26 of September 2013 17:38:58 Yadwinder Singh Brar wrote: + +/* Helper macros to define

Re: [PATCH 2/3] clk: samsung: Add clock driver for s5pc100

Hi Mateusz, After a quick view, just few things regarding coding styles. [...] > +#defineGENERAL_STATUS 0x0104 > +#defineCAM_MUX_SEL 0x0300 > +#defineMIXER_OUT_SEL 0x0304 > +#defineLPMP3_MODE_SEL 0x0308 > +#define

Re: [PATCH 1/2] cpufreq: exynos4x12: Use the common clock framework to set APLL clock rate

Hi Tomasz, >> On Wed, Sep 25, 2013 at 4:52 PM, Lukasz Majewski >> wrote: >> > In the exynos4x12_set_apll() function, the APLL frequency is set with >> > direct register manipulation. >> > >> > Such approach is not allowed in the common clock framework. The frequency >> > is changed, but the

Re: [PATCH 1/2] cpufreq: exynos4x12: Use the common clock framework to set APLL clock rate

Hi Tomasz, On Wed, Sep 25, 2013 at 4:52 PM, Lukasz Majewski l.majew...@samsung.com wrote: In the exynos4x12_set_apll() function, the APLL frequency is set with direct register manipulation. Such approach is not allowed in the common clock framework. The frequency is changed, but the

Re: [PATCH 2/3] clk: samsung: Add clock driver for s5pc100

Hi Mateusz, After a quick view, just few things regarding coding styles. [...] +#defineGENERAL_STATUS 0x0104 +#defineCAM_MUX_SEL 0x0300 +#defineMIXER_OUT_SEL 0x0304 +#defineLPMP3_MODE_SEL 0x0308 +#define MIPI_PHY_CON0

Re: [PATCH 1/2] cpufreq: exynos4x12: Use the common clock framework to set APLL clock rate

Hi Lukasz, On Wed, Sep 25, 2013 at 4:52 PM, Lukasz Majewski wrote: > In the exynos4x12_set_apll() function, the APLL frequency is set with > direct register manipulation. > > Such approach is not allowed in the common clock framework. The frequency > is changed, but the corresponding clock value

Re: [PATCH 1/2] cpufreq: exynos4x12: Use the common clock framework to set APLL clock rate

Hi Lukasz, On Wed, Sep 25, 2013 at 4:52 PM, Lukasz Majewski l.majew...@samsung.com wrote: In the exynos4x12_set_apll() function, the APLL frequency is set with direct register manipulation. Such approach is not allowed in the common clock framework. The frequency is changed, but the

[RFC 4/4] arm: exynos5: Register static platform device for ASV.

Since ASV is not a hardware controller so we cann't add device tree node for it. This patch registers a static platform device exynos ASV. Signed-off-by: Yadwinder Singh Brar --- arch/arm/mach-exynos/mach-exynos5-dt.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[RFC 1/4] power: asv: Add common ASV support for samsung SoCs

This patch introduces a common ASV(Adaptive Supply Voltage) basic framework for samsung SoCs. It provides common APIs (to be called by users to get ASV values or init opp_table) and an interface for SoC specific drivers to register ASV members(instances). Signed-off-by: Yadwinder Singh Brar

[RFC 3/4] power: asv: Add support for exynos5250

This patch adds basic support (only for ARM ASV) for exynos5250 chips which have fused ASV group. Signed-off-by: Yadwinder Singh Brar --- drivers/power/asv/Makefile |2 +- drivers/power/asv/exynos-asv.c |9 +++ drivers/power/asv/exynos-asv.h |1 + drivers/power/asv

[RFC 2/4] power: asv: Add a common asv driver for exynos SoCs.

This patch adds a common platform driver to register ASV members for exynos SoCs. Signed-off-by: Yadwinder Singh Brar --- drivers/power/asv/Kconfig | 13 +++ drivers/power/asv/Makefile |1 + drivers/power/asv/exynos-asv.c | 72

[RFC 0/4] Add basic support for ASV

ions. Thanks Yadwinder Singh Brar (4): power: asv: Add common ASV support for samsung SoCs power: asv: Add a common asv driver for exynos SoCs. power: asv: Add support for exynos5250 arm: exynos5: Register static platform device for ASV. arch/arm/mach-exynos/mach-exynos5-dt.c |

[RFC 0/4] Add basic support for ASV

. Thanks Yadwinder Singh Brar (4): power: asv: Add common ASV support for samsung SoCs power: asv: Add a common asv driver for exynos SoCs. power: asv: Add support for exynos5250 arm: exynos5: Register static platform device for ASV. arch/arm/mach-exynos/mach-exynos5-dt.c |3

[RFC 2/4] power: asv: Add a common asv driver for exynos SoCs.

This patch adds a common platform driver to register ASV members for exynos SoCs. Signed-off-by: Yadwinder Singh Brar yadi.b...@samsung.com --- drivers/power/asv/Kconfig | 13 +++ drivers/power/asv/Makefile |1 + drivers/power/asv/exynos-asv.c | 72

[RFC 3/4] power: asv: Add support for exynos5250

This patch adds basic support (only for ARM ASV) for exynos5250 chips which have fused ASV group. Signed-off-by: Yadwinder Singh Brar yadi.b...@samsung.com --- drivers/power/asv/Makefile |2 +- drivers/power/asv/exynos-asv.c |9 +++ drivers/power/asv/exynos-asv.h |1

[RFC 4/4] arm: exynos5: Register static platform device for ASV.

Since ASV is not a hardware controller so we cann't add device tree node for it. This patch registers a static platform device exynos ASV. Signed-off-by: Yadwinder Singh Brar yadi.b...@samsung.com --- arch/arm/mach-exynos/mach-exynos5-dt.c |3 +++ 1 files changed, 3 insertions(+), 0

[RFC 1/4] power: asv: Add common ASV support for samsung SoCs

This patch introduces a common ASV(Adaptive Supply Voltage) basic framework for samsung SoCs. It provides common APIs (to be called by users to get ASV values or init opp_table) and an interface for SoC specific drivers to register ASV members(instances). Signed-off-by: Yadwinder Singh Brar

Re: [PATCH 1/3] clk: s2mps11: Add support for s2mps11

Hi Mike, On Tue, Aug 6, 2013 at 4:53 AM, Mike Turquette wrote: > Quoting Yadwinder Singh Brar (2013-07-07 04:44:20) >> This patch adds support to register three(AP/CP/BT) buffered 32.768 KHz >> outputs of mfd-s2mps11 with common clock framework. >> >> Signed-o

Re: [PATCH 1/3] clk: s2mps11: Add support for s2mps11

Hi Mike, On Tue, Aug 6, 2013 at 4:53 AM, Mike Turquette mturque...@linaro.org wrote: Quoting Yadwinder Singh Brar (2013-07-07 04:44:20) This patch adds support to register three(AP/CP/BT) buffered 32.768 KHz outputs of mfd-s2mps11 with common clock framework. Signed-off-by: Yadwinder Singh

Re: [PATCH 1/3] clk: s2mps11: Add support for s2mps11

Gentle ping ... Any review comments? On Sun, Jul 7, 2013 at 5:14 PM, Yadwinder Singh Brar wrote: > This patch adds support to register three(AP/CP/BT) buffered 32.768 KHz > outputs of mfd-s2mps11 with common clock framework. > > Signed-off-by: Yadwinder Singh Brar > --- > d

Re: [PATCH 1/3] clk: s2mps11: Add support for s2mps11

Gentle ping ... Any review comments? On Sun, Jul 7, 2013 at 5:14 PM, Yadwinder Singh Brar yadi.b...@samsung.com wrote: This patch adds support to register three(AP/CP/BT) buffered 32.768 KHz outputs of mfd-s2mps11 with common clock framework. Signed-off-by: Yadwinder Singh Brar yadi.b

[PATCH 0/3] Add clk driver to register s2mps11 clocks

This series adds support to register three(AP/CP/BT) buffered 32.768 KHz outputs of mfd-s2mps11 with common clock framework and removes clocks from regulators list. Yadwinder Singh Brar (3): clk: s2mps11: Add support for s2mps11 mfd: sec: Add clock cell for s2mps11 mfd: s2mps11: Remove

[PATCH 1/3] clk: s2mps11: Add support for s2mps11

This patch adds support to register three(AP/CP/BT) buffered 32.768 KHz outputs of mfd-s2mps11 with common clock framework. Signed-off-by: Yadwinder Singh Brar --- drivers/clk/Kconfig |6 + drivers/clk/Makefile |1 + drivers/clk/clk-s2mps11.c | 273

[PATCH 2/3] mfd: sec: Add clock cell for s2mps11

This patch adds clock to list of mfd cells for s2mps11 and DT documentation for clock part. Signed-off-by: Yadwinder Singh Brar --- Documentation/devicetree/bindings/mfd/s2mps11.txt | 20 drivers/mfd/sec-core.c|4 +++- 2 files changed, 23

[PATCH 3/3] mfd: s2mps11: Remove clocks from regulators list

Since these are fixed rate clocks which are registered with common clock framework so remove these from list of regulators which were unnecessarily incrementing the count(S2MPS11_REGULATOR_MAX) of regulators. Signed-off-by: Yadwinder Singh Brar --- include/linux/mfd/samsung/s2mps11.h |6

[PATCH] regulator: s2mps11: Add linux/of.h header

This patch adds linux/of.h required to fix an error and warning reported by kbuild test robot for some x86 config file. Signed-off-by: Yadwinder Singh Brar --- drivers/regulator/s2mps11.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/regulator/s2mps11.c b

[PATCH] regulator: s2mps11: Add linux/of.h header

This patch adds linux/of.h required to fix an error and warning reported by kbuild test robot for some x86 config file. Signed-off-by: Yadwinder Singh Brar yadi.b...@samsung.com --- drivers/regulator/s2mps11.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers

[PATCH 3/3] mfd: s2mps11: Remove clocks from regulators list

Since these are fixed rate clocks which are registered with common clock framework so remove these from list of regulators which were unnecessarily incrementing the count(S2MPS11_REGULATOR_MAX) of regulators. Signed-off-by: Yadwinder Singh Brar yadi.b...@samsung.com --- include/linux/mfd/samsung

[PATCH 2/3] mfd: sec: Add clock cell for s2mps11

This patch adds clock to list of mfd cells for s2mps11 and DT documentation for clock part. Signed-off-by: Yadwinder Singh Brar yadi.b...@samsung.com --- Documentation/devicetree/bindings/mfd/s2mps11.txt | 20 drivers/mfd/sec-core.c|4

[PATCH 1/3] clk: s2mps11: Add support for s2mps11

This patch adds support to register three(AP/CP/BT) buffered 32.768 KHz outputs of mfd-s2mps11 with common clock framework. Signed-off-by: Yadwinder Singh Brar yadi.b...@samsung.com --- drivers/clk/Kconfig |6 + drivers/clk/Makefile |1 + drivers/clk/clk-s2mps11.c | 273

[PATCH 0/3] Add clk driver to register s2mps11 clocks

This series adds support to register three(AP/CP/BT) buffered 32.768 KHz outputs of mfd-s2mps11 with common clock framework and removes clocks from regulators list. Yadwinder Singh Brar (3): clk: s2mps11: Add support for s2mps11 mfd: sec: Add clock cell for s2mps11 mfd: s2mps11: Remove

Re: [v2 PATCH 6/6] mfd: s2mps11: Add device tree support

On Mon, Jul 8, 2013 at 6:58 PM, Mark Brown wrote: > On Sat, Jun 29, 2013 at 06:21:20PM +0530, Yadwinder Singh Brar wrote: >> This patch adds DT compatible string for s2mps11 and binding documentation. >> >> Signed-off-by: Yadwinder Singh Brar > > Reviewed-by: Ma

[v2 PATCH 2/6] regulator: s2mps11: Implement set_ramp_rate callback for bucks

Implementing set_ramp_rate() and using standard constraints for getting ramp_delay and ramp_disable, instead of getting it as s2mps11 specific data through platform data, makes driver more compliant with framework and reduces the complexity for adding DT support. Signed-off-by: Yadwinder Singh

[v2 PATCH 3/6] regulator: s2mps11: Add DT support

This patch adds DT support for parsing regulators constraints for parent(mfd) node and moves some common intialising code out of loop while registering. Signed-off-by: Yadwinder Singh Brar --- drivers/regulator/s2mps11.c | 48 +- 1 files changed, 37

[v2 PATCH 1/6] regulator: core: Add support for disabling ramp delay

delay is disabled in constraints. Signed-off-by: Yadwinder Singh Brar --- .../devicetree/bindings/regulator/regulator.txt|2 ++ drivers/regulator/core.c |6 -- drivers/regulator/of_regulator.c | 12 +--- include/linux/regulator

[v2 PATCH 6/6] mfd: s2mps11: Add device tree support

This patch adds DT compatible string for s2mps11 and binding documentation. Signed-off-by: Yadwinder Singh Brar --- Documentation/devicetree/bindings/mfd/s2mps11.txt | 89 + drivers/mfd/sec-core.c|3 + 2 files changed, 92 insertions(+), 0

[v2 PATCH 4/6] regulator: s2mps11: Convert driver completely to use set_ramp_delay callback

Since now we have ramp_delay and ramp_disable as standard regulator constraints and DT part using it so this patch removes legacy part i.e. getting ramp_delayxx and ramp_enable from pdata since it can be passed as standard regulator constraints. Signed-off-by: Yadwinder Singh Brar --- drivers

[v2 PATCH 0/6] Add DT support for s2mps11

o make driver simple and in more compliance with framework. - Modified Documentation accordingly. - Fixed some NITs pointed by Sachin. It also includes a patch to remove some redundant checks in _regulator_do_set_voltage(). Yadwinder Singh Brar (6): regulator: core: Add support for disabling ramp

[v2 PATCH 5/6] regulator: core: Remove redundant checks

r >= 0) and it will true if it got intialised properly. so we don't need to check again _regulator_is_enabled(rdev) && rdev->desc->ops->set_voltage_time_sel before calling set_voltage_time_sel(). Signed-off-by: Yadwinder Singh Brar --- drivers/regulator/core.c |5 ++--- 1 file

[v2 PATCH 0/6] Add DT support for s2mps11

simple and in more compliance with framework. - Modified Documentation accordingly. - Fixed some NITs pointed by Sachin. It also includes a patch to remove some redundant checks in _regulator_do_set_voltage(). Yadwinder Singh Brar (6): regulator: core: Add support for disabling ramp delay

[v2 PATCH 4/6] regulator: s2mps11: Convert driver completely to use set_ramp_delay callback

Since now we have ramp_delay and ramp_disable as standard regulator constraints and DT part using it so this patch removes legacy part i.e. getting ramp_delayxx and ramp_enable from pdata since it can be passed as standard regulator constraints. Signed-off-by: Yadwinder Singh Brar yadi.b

[v2 PATCH 5/6] regulator: core: Remove redundant checks

properly. so we don't need to check again _regulator_is_enabled(rdev) rdev-desc-ops-set_voltage_time_sel before calling set_voltage_time_sel(). Signed-off-by: Yadwinder Singh Brar yadi.b...@samsung.com --- drivers/regulator/core.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff

[v2 PATCH 6/6] mfd: s2mps11: Add device tree support

This patch adds DT compatible string for s2mps11 and binding documentation. Signed-off-by: Yadwinder Singh Brar yadi.b...@samsung.com --- Documentation/devicetree/bindings/mfd/s2mps11.txt | 89 + drivers/mfd/sec-core.c|3 + 2 files changed

[v2 PATCH 1/6] regulator: core: Add support for disabling ramp delay

delay is disabled in constraints. Signed-off-by: Yadwinder Singh Brar yadi.b...@samsung.com --- .../devicetree/bindings/regulator/regulator.txt|2 ++ drivers/regulator/core.c |6 -- drivers/regulator/of_regulator.c | 12

[v2 PATCH 3/6] regulator: s2mps11: Add DT support

This patch adds DT support for parsing regulators constraints for parent(mfd) node and moves some common intialising code out of loop while registering. Signed-off-by: Yadwinder Singh Brar yadi.b...@samsung.com --- drivers/regulator/s2mps11.c | 48 +- 1

[v2 PATCH 2/6] regulator: s2mps11: Implement set_ramp_rate callback for bucks

Implementing set_ramp_rate() and using standard constraints for getting ramp_delay and ramp_disable, instead of getting it as s2mps11 specific data through platform data, makes driver more compliant with framework and reduces the complexity for adding DT support. Signed-off-by: Yadwinder Singh

Re: [v2 PATCH 6/6] mfd: s2mps11: Add device tree support

On Mon, Jul 8, 2013 at 6:58 PM, Mark Brown broo...@kernel.org wrote: On Sat, Jun 29, 2013 at 06:21:20PM +0530, Yadwinder Singh Brar wrote: This patch adds DT compatible string for s2mps11 and binding documentation. Signed-off-by: Yadwinder Singh Brar yadi.b...@samsung.com Reviewed-by: Mark

  1   2   >