[PATCH v2 1/3] checkpatch: add Kconfig 'default n' test

If a Kconfig config option doesn't specify 'default', the default will be n. Adding 'default n' is unnecessary. Add a test to warn about this. Signed-off-by: Yingjoe Chen --- Change in v2: - Change according to Joe Perches' suggestion scripts/checkpatch.pl | 7 +++ 1 file changed, 7

Re: [PATCH 1/3] checkpatch: add Kconfig 'default n' test

On Thu, 2016-04-21 at 10:16 -0700, Joe Perches wrote: > On Thu, 2016-04-21 at 21:28 +0800, Yingjoe Chen wrote: > > If a Kconfig config option doesn't specify 'default', the default > > will be n. Adding 'default n' is unnecessary. > > > > Add a test to warn abou

Re: [PATCH 1/3] checkpatch: add Kconfig 'default n' test

On Thu, 2016-04-21 at 10:16 -0700, Joe Perches wrote: > On Thu, 2016-04-21 at 21:28 +0800, Yingjoe Chen wrote: > > If a Kconfig config option doesn't specify 'default', the default > > will be n. Adding 'default n' is unnecessary. > > > > Add a test to warn abou

Re: [PATCH 2/3] checkpatch: testing more config for Kconfig help text

On Thu, 2016-04-21 at 10:06 -0700, Joe Perches wrote: > On Thu, 2016-04-21 at 21:28 +0800, Yingjoe Chen wrote: > > Current help text check only check a config option if it is followed > > by another config. > > Adding check for help text if the next entry is menuconfig,

Re: [PATCH 2/3] checkpatch: testing more config for Kconfig help text

On Thu, 2016-04-21 at 10:06 -0700, Joe Perches wrote: > On Thu, 2016-04-21 at 21:28 +0800, Yingjoe Chen wrote: > > Current help text check only check a config option if it is followed > > by another config. > > Adding check for help text if the next entry is menuconfig,

Re: [PATCH 3/3] checkpatch: relax Kconfig help text line number threshold

On Thu, 2016-04-21 at 10:39 -0700, Andi Kleen wrote: > On Thu, Apr 21, 2016 at 10:00:07AM -0700, Joe Perches wrote: > > On Thu, 2016-04-21 at 21:28 +0800, Yingjoe Chen wrote: > > > Current threshold is too strict and many upstream patch doesn't pass > > > this test. Rela

Re: [PATCH 3/3] checkpatch: relax Kconfig help text line number threshold

On Thu, 2016-04-21 at 10:39 -0700, Andi Kleen wrote: > On Thu, Apr 21, 2016 at 10:00:07AM -0700, Joe Perches wrote: > > On Thu, 2016-04-21 at 21:28 +0800, Yingjoe Chen wrote: > > > Current threshold is too strict and many upstream patch doesn't pass > > > this test. Rela

[PATCH 2/3] checkpatch: testing more config for Kconfig help text

Current help text check only check a config option if it is followed by another config. Adding check for help text if the next entry is menuconfig, choice/ endchoice, comment, menu/endmenu, if/endif, source or end of file. Signed-off-by: Yingjoe Chen <yingjoe.c...@mediatek.com> --- s

[PATCH 2/3] checkpatch: testing more config for Kconfig help text

Current help text check only check a config option if it is followed by another config. Adding check for help text if the next entry is menuconfig, choice/ endchoice, comment, menu/endmenu, if/endif, source or end of file. Signed-off-by: Yingjoe Chen --- scripts/checkpatch.pl | 11

[PATCH 3/3] checkpatch: relax Kconfig help text line number threshold

Current threshold is too strict and many upstream patch doesn't pass this test. Relax it. Signed-off-by: Yingjoe Chen <yingjoe.c...@mediatek.com> --- In v4.6-rc1, 171 new config options was added, and 87 of those options have < 4 lines and 24 options have only 1 line. After th

[PATCH 3/3] checkpatch: relax Kconfig help text line number threshold

Current threshold is too strict and many upstream patch doesn't pass this test. Relax it. Signed-off-by: Yingjoe Chen --- In v4.6-rc1, 171 new config options was added, and 87 of those options have < 4 lines and 24 options have only 1 line. After this change, checkpatch only raise warning w

[PATCH 1/3] checkpatch: add Kconfig 'default n' test

If a Kconfig config option doesn't specify 'default', the default will be n. Adding 'default n' is unnecessary. Add a test to warn about this. Signed-off-by: Yingjoe Chen <yingjoe.c...@mediatek.com> --- scripts/checkpatch.pl | 7 +++ 1 file changed, 7 insertions(+) diff --git a/s

[PATCH 1/3] checkpatch: add Kconfig 'default n' test

If a Kconfig config option doesn't specify 'default', the default will be n. Adding 'default n' is unnecessary. Add a test to warn about this. Signed-off-by: Yingjoe Chen --- scripts/checkpatch.pl | 7 +++ 1 file changed, 7 insertions(+) diff --git a/scripts/checkpatch.pl b/scripts

Re: [PATCH v6 3/4] soc: mediatek: Add MT2701 power dt-bindings

On Fri, 2016-04-15 at 10:02 +0800, James Liao wrote: > Hi Yingjoe, > > On Thu, 2016-04-14 at 18:56 +0800, Yingjoe Chen wrote: > > On Thu, 2016-04-14 at 16:16 +0800, James Liao wrote: > > > From: Shunli Wang <shunli.w...@mediatek.com> > > >

Re: [PATCH v6 3/4] soc: mediatek: Add MT2701 power dt-bindings

On Fri, 2016-04-15 at 10:02 +0800, James Liao wrote: > Hi Yingjoe, > > On Thu, 2016-04-14 at 18:56 +0800, Yingjoe Chen wrote: > > On Thu, 2016-04-14 at 16:16 +0800, James Liao wrote: > > > From: Shunli Wang > > > > > > Add power dt-bindings for MT270

Re: [alsa-devel] [RFC PATCH v2 1/5] ASoC: Mediatek: Refine mt8173 driver

On Thu, 2016-04-14 at 20:14 +0800, Garlic Tseng wrote: > Move mt8173 driver to another folder. > > The software control sequence of mt2701 is very different from that of mt8173, > so this patch moves mt8173 code to another folder. > > > Signed-off-by: Garlic Tseng >

Re: [alsa-devel] [RFC PATCH v2 1/5] ASoC: Mediatek: Refine mt8173 driver

On Thu, 2016-04-14 at 20:14 +0800, Garlic Tseng wrote: > Move mt8173 driver to another folder. > > The software control sequence of mt2701 is very different from that of mt8173, > so this patch moves mt8173 code to another folder. > > > Signed-off-by: Garlic Tseng > --- >

Re: [alsa-devel] [RFC PATCH v2 5/5] ASoC: mediatek: Add mt2701-cs42448 driver and config option.

On Thu, 2016-04-14 at 20:14 +0800, Garlic Tseng wrote: > Add machine driver and config option for MT2701. > > Signed-off-by: Garlic Tseng > --- > sound/soc/mediatek/Kconfig | 21 ++ > sound/soc/mediatek/Makefile| 3 + >

Re: [alsa-devel] [RFC PATCH v2 5/5] ASoC: mediatek: Add mt2701-cs42448 driver and config option.

On Thu, 2016-04-14 at 20:14 +0800, Garlic Tseng wrote: > Add machine driver and config option for MT2701. > > Signed-off-by: Garlic Tseng > --- > sound/soc/mediatek/Kconfig | 21 ++ > sound/soc/mediatek/Makefile| 3 + > sound/soc/mediatek/mt2701/Makefile

Re: [PATCH v6 3/4] soc: mediatek: Add MT2701 power dt-bindings

On Thu, 2016-04-14 at 16:16 +0800, James Liao wrote: > From: Shunli Wang > > Add power dt-bindings for MT2701. > > Signed-off-by: Shunli Wang > Signed-off-by: James Liao > Acked-by: Rob Herring >

Re: [PATCH v6 3/4] soc: mediatek: Add MT2701 power dt-bindings

On Thu, 2016-04-14 at 16:16 +0800, James Liao wrote: > From: Shunli Wang > > Add power dt-bindings for MT2701. > > Signed-off-by: Shunli Wang > Signed-off-by: James Liao > Acked-by: Rob Herring > Reviewed-by: Kevin Hilman > --- > .../devicetree/bindings/soc/mediatek/scpsys.txt| 12

[PATCH v2] pinctrl: mediatek: correct debounce time unit in mtk_gpio_set_debounce

the debounce time array name to "debounce_time" for readability. Signed-off-by: Yingjoe Chen <yingjoe.c...@mediatek.com> --- This was based on v4.6-rc1 Change since v1: - Improve commit message. - Change dbnc_arr name to debounce_time --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c

[PATCH v2] pinctrl: mediatek: correct debounce time unit in mtk_gpio_set_debounce

the debounce time array name to "debounce_time" for readability. Signed-off-by: Yingjoe Chen --- This was based on v4.6-rc1 Change since v1: - Improve commit message. - Change dbnc_arr name to debounce_time --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 9 + 1 file changed, 5

Re: [PATCH] pinctrl: mediatek: correct debounce time unit in mtk_gpio_set_debounce

Daniel, Thanks for your review. On Fri, 2016-04-01 at 22:28 +0800, Daniel Kurtz wrote: > Hi Yingjoe, > > On Fri, Apr 1, 2016 at 9:51 PM, Yingjoe Chen <yingjoe.c...@mediatek.com> > wrote: > > The debounce time unit for gpio_chip.set_debounce is us but > > mtk_gpi

Re: [PATCH] pinctrl: mediatek: correct debounce time unit in mtk_gpio_set_debounce

Daniel, Thanks for your review. On Fri, 2016-04-01 at 22:28 +0800, Daniel Kurtz wrote: > Hi Yingjoe, > > On Fri, Apr 1, 2016 at 9:51 PM, Yingjoe Chen > wrote: > > The debounce time unit for gpio_chip.set_debounce is us but > > mtk_gpio_set_debounce regard it as ms.

[PATCH] pinctrl: mediatek: correct debounce time unit in mtk_gpio_set_debounce

The debounce time unit for gpio_chip.set_debounce is us but mtk_gpio_set_debounce regard it as ms. Fix this by correct debounce time array dbnc_arr so it can find correct debounce setting. Signed-off-by: Yingjoe Chen <yingjoe.c...@mediatek.com> --- drivers/pinctrl/mediatek/pinctrl-mtk-co

[PATCH] pinctrl: mediatek: correct debounce time unit in mtk_gpio_set_debounce

The debounce time unit for gpio_chip.set_debounce is us but mtk_gpio_set_debounce regard it as ms. Fix this by correct debounce time array dbnc_arr so it can find correct debounce setting. Signed-off-by: Yingjoe Chen --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 3 ++- 1 file changed, 2

Re: [PATCH] mfd: mt6397: irq domain should initialize before mfd_add_devices()

On Thu, 2016-03-31 at 11:08 +0200, John Crispin wrote: > > On 31/03/2016 04:32, Yingjoe Chen wrote: > > On Thu, 2016-03-31 at 09:40 +0800, Henry Chen wrote: > >> On Wed, 2016-03-30 at 11:18 +0200, John Crispin wrote: > >>> Hi, > >>> > >>

Re: [PATCH] mfd: mt6397: irq domain should initialize before mfd_add_devices()

On Thu, 2016-03-31 at 11:08 +0200, John Crispin wrote: > > On 31/03/2016 04:32, Yingjoe Chen wrote: > > On Thu, 2016-03-31 at 09:40 +0800, Henry Chen wrote: > >> On Wed, 2016-03-30 at 11:18 +0200, John Crispin wrote: > >>> Hi, > >>> > >>

Re: [PATCH] mfd: mt6397: irq domain should initialize before mfd_add_devices()

On Thu, 2016-03-31 at 09:40 +0800, Henry Chen wrote: > On Wed, 2016-03-30 at 11:18 +0200, John Crispin wrote: > > Hi, > > > > small nitpick inline > > > > On 30/03/2016 09:25, Henry Chen wrote: > > > Some sub driver like RTC module need irq domain from parent to create > > > irq mapping when

Re: [PATCH] mfd: mt6397: irq domain should initialize before mfd_add_devices()

On Thu, 2016-03-31 at 09:40 +0800, Henry Chen wrote: > On Wed, 2016-03-30 at 11:18 +0200, John Crispin wrote: > > Hi, > > > > small nitpick inline > > > > On 30/03/2016 09:25, Henry Chen wrote: > > > Some sub driver like RTC module need irq domain from parent to create > > > irq mapping when

Re: [PATCH 1/2] iommu/io-pgtable: Add MTK 4GB mode in Short-descriptor

On Wed, 2016-03-02 at 12:31 +, Robin Murphy wrote: > Hi Yong, > > On 23/02/16 23:02, Yong Wu wrote: > > Mediatek extend bit9 in the lvl1 and lvl2 pgtable descriptor of the > > Short-descriptor as the 4GB mode in which the dram size will be > > over 4GB. > > > > We add a special quirk for this

Re: [PATCH 1/2] iommu/io-pgtable: Add MTK 4GB mode in Short-descriptor

On Wed, 2016-03-02 at 12:31 +, Robin Murphy wrote: > Hi Yong, > > On 23/02/16 23:02, Yong Wu wrote: > > Mediatek extend bit9 in the lvl1 and lvl2 pgtable descriptor of the > > Short-descriptor as the 4GB mode in which the dram size will be > > over 4GB. > > > > We add a special quirk for this

Re: [PATCH 1/2] pinctrl: mediatek: fix direction control issue

On Thu, 2016-02-11 at 18:07 -0800, Hongzhou Yang wrote: > On Fri, 2016-02-05 at 14:52 +0100, Linus Walleij wrote: > > On Thu, Feb 4, 2016 at 4:03 AM, Hongzhou Yang > > wrote: > > > On Wed, 2016-02-03 at 09:24 +0800, Biao Huang wrote: > > >> Since input-enable/disable

Re: [PATCH 1/2] pinctrl: mediatek: fix direction control issue

On Thu, 2016-02-11 at 18:07 -0800, Hongzhou Yang wrote: > On Fri, 2016-02-05 at 14:52 +0100, Linus Walleij wrote: > > On Thu, Feb 4, 2016 at 4:03 AM, Hongzhou Yang > > wrote: > > > On Wed, 2016-02-03 at 09:24 +0800, Biao Huang wrote: > > >> Since input-enable/disable and

Re: [PATCH v3 4/5] pinctrl: mediatek: Add Pinctrl/GPIO/EINT driver for mt2701

On Thu, 2016-02-04 at 14:48 +0100, Matthias Brugger wrote: > > On 28/12/15 09:07, Yingjoe Chen wrote: > > On Mon, 2015-12-28 at 15:09 +0800, Biao Huang wrote: > >> Add mt2701 support using mediatek common pinctrl driver. > >> MT2701 have some special pins need an ex

Re: [PATCH v3 4/5] pinctrl: mediatek: Add Pinctrl/GPIO/EINT driver for mt2701

On Thu, 2016-02-04 at 14:48 +0100, Matthias Brugger wrote: > > On 28/12/15 09:07, Yingjoe Chen wrote: > > On Mon, 2015-12-28 at 15:09 +0800, Biao Huang wrote: > >> Add mt2701 support using mediatek common pinctrl driver. > >> MT2701 have some special pins need an ex

Re: [PATCH v6] i2c: mt8173: add 4GB mode support in i2c driver.

e() for support 4g mode. > --- > drivers/i2c/busses/i2c-mt65xx.c | 42 > + > 1 file changed, 42 insertions(+) Looks good to me, Thanks. Reviewed-by: Yingjoe Chen Joe.C

Re: [PATCH v6] i2c: mt8173: add 4GB mode support in i2c driver.

nline function mtk_i2c_set_4g_mode() for support 4g mode. > --- > drivers/i2c/busses/i2c-mt65xx.c | 42 > + > 1 file changed, 42 insertions(+) Looks good to me, Thanks. Reviewed-by: Yingjoe Chen <yingjoe.c...@mediatek.com> Joe.C

Re: [PATCH v3] i2c: mt8173: add 4GB mode support in i2c driver.

On Fri, 2016-01-29 at 09:35 +0800, Liguo Zhang wrote: > If 4GB mode is enable, we should add 4gb mode support in i2c driver. nit: enabled However, after looking at it longer, the commit message doesn't make much sense to me. > Set 4GB mode register to support 4GB mode. > > Signed-off-by: Liguo

Re: [PATCH v3] i2c: mt8173: add 4GB mode support in i2c driver.

On Fri, 2016-01-29 at 09:35 +0800, Liguo Zhang wrote: > If 4GB mode is enable, we should add 4gb mode support in i2c driver. nit: enabled However, after looking at it longer, the commit message doesn't make much sense to me. > Set 4GB mode register to support 4GB mode. > > Signed-off-by: Liguo

Re: [PATCH V3 08/11] soc: mediatek: PMIC wrap: remove pwrap_is_mt8135() and pwrap_is_mt8173()

On Mon, 2016-01-25 at 10:53 +0100, John Crispin wrote: > With ore SoCs being added the list of helper functions like these would > grow. While at it also add a new flag "bridge" and use that insted of > pwrap_is_mt8173() where appropriate. typos? s/ore/more/ s/insted/instead/ I think you mean

Re: [PATCH V3 06/11] soc: mediatek: PMIC wrap:: SPI_WRITE needs a different bitmask for MT2701/7623

nit for the subject: soc: mediatek: PMIC wrap:: SPI_WRITE needs a different bitmask for MT2701/7623 ^^ extra : here. Otherwise the patch looks good to me. Joe.C On Mon, 2016-01-25 at 10:53 +0100, John Crispin wrote: > MT2701 and MT7623 use a different bitmask for the

Re: [PATCH V3 09/11] soc: mediatek: PMIC wrap: add a slave specific struct

Hi John, Thanks for preparing the patch. On Mon, 2016-01-25 at 10:53 +0100, John Crispin wrote: > This patch adds a new struct pwrap_slv_type that we use to store the slave > specific data. The patch adds 2 new helper functions to access the dew > registers. The slave type is looked up via

Re: [PATCH V3 09/11] soc: mediatek: PMIC wrap: add a slave specific struct

Hi John, Thanks for preparing the patch. On Mon, 2016-01-25 at 10:53 +0100, John Crispin wrote: > This patch adds a new struct pwrap_slv_type that we use to store the slave > specific data. The patch adds 2 new helper functions to access the dew > registers. The slave type is looked up via

Re: [PATCH V3 08/11] soc: mediatek: PMIC wrap: remove pwrap_is_mt8135() and pwrap_is_mt8173()

On Mon, 2016-01-25 at 10:53 +0100, John Crispin wrote: > With ore SoCs being added the list of helper functions like these would > grow. While at it also add a new flag "bridge" and use that insted of > pwrap_is_mt8173() where appropriate. typos? s/ore/more/ s/insted/instead/ I think you mean

Re: [PATCH V3 06/11] soc: mediatek: PMIC wrap:: SPI_WRITE needs a different bitmask for MT2701/7623

nit for the subject: soc: mediatek: PMIC wrap:: SPI_WRITE needs a different bitmask for MT2701/7623 ^^ extra : here. Otherwise the patch looks good to me. Joe.C On Mon, 2016-01-25 at 10:53 +0100, John Crispin wrote: > MT2701 and MT7623 use a different bitmask for the

Re: [PATCH v3 1/6] clk: mediatek: Refine the makefile to support multiple clock drivers

On Thu, 2016-01-21 at 10:28 +0800, Yingjoe Chen wrote: > On Tue, 2016-01-12 at 16:31 +0800, James Liao wrote: > > Add a Kconfig to define clock configuration for each SoC, and > > modify the Makefile to build drivers that only selected in config. > > > > Signed-off-by:

Re: [PATCH v3 1/6] clk: mediatek: Refine the makefile to support multiple clock drivers

On Tue, 2016-01-12 at 16:31 +0800, James Liao wrote: > Add a Kconfig to define clock configuration for each SoC, and > modify the Makefile to build drivers that only selected in config. > > Signed-off-by: Shunli Wang > Signed-off-by: James Liao > --- > drivers/clk/Kconfig | 1 + >

Re: [PATCH v3 1/6] clk: mediatek: Refine the makefile to support multiple clock drivers

On Thu, 2016-01-21 at 10:28 +0800, Yingjoe Chen wrote: > On Tue, 2016-01-12 at 16:31 +0800, James Liao wrote: > > Add a Kconfig to define clock configuration for each SoC, and > > modify the Makefile to build drivers that only selected in config. > > > > Signed-of

Re: [PATCH v3 1/6] clk: mediatek: Refine the makefile to support multiple clock drivers

On Tue, 2016-01-12 at 16:31 +0800, James Liao wrote: > Add a Kconfig to define clock configuration for each SoC, and > modify the Makefile to build drivers that only selected in config. > > Signed-off-by: Shunli Wang > Signed-off-by: James Liao

Re: [PATCH v3 4/5] pinctrl: mediatek: Add Pinctrl/GPIO/EINT driver for mt2701

On Mon, 2015-12-28 at 15:09 +0800, Biao Huang wrote: > Add mt2701 support using mediatek common pinctrl driver. > MT2701 have some special pins need an extra setting register > than other ICs, so adding this support to common code. > > Signed-off-by: Biao Huang > Acke

Re: [PATCH v3 4/5] pinctrl: mediatek: Add Pinctrl/GPIO/EINT driver for mt2701

iatek.com> > Acked-by: Yingjoe Chen <yingjoe.c...@mediatek.com> <...> > + > +static struct platform_driver mtk_pinctrl_driver = { > + .probe = mt2701_pinctrl_probe, > + .driver = { > + .name = "mediatek-mt2701-pinctrl", > +

Re: [PATCH] regulator: mt6397: convert to arch_initcall

On Wed, 2015-12-23 at 12:00 +, Mark Brown wrote: > On Wed, Dec 23, 2015 at 06:16:08PM +0800, Henry Chen wrote: > > Please fix your mail client to word wrap within paragraphs at something > substantially less than 80 columns. Doing this makes your messages much > easier to read and reply to.

Re: [PATCH] regulator: mt6397: convert to arch_initcall

On Wed, 2015-12-23 at 12:00 +, Mark Brown wrote: > On Wed, Dec 23, 2015 at 06:16:08PM +0800, Henry Chen wrote: > > Please fix your mail client to word wrap within paragraphs at something > substantially less than 80 columns. Doing this makes your messages much > easier to read and reply to.

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

ly this now won't cause any problem either, unless someone think we should stink to current orders. So I think we could apply this now: Acked-by: Yingjoe Chen Joe.C -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to ma

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

397 pinctrl changes in this patch won't work as expect. Apply this now won't cause any problem either, unless someone think we should stink to current orders. So I think we could apply this now: Acked-by: Yingjoe Chen <yingjoe.c...@mediatek.com> Joe.C -- To unsubscribe from this list: send

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Mon, 2015-12-21 at 14:51 +0800, Daniel Kurtz wrote: > On Fri, Dec 18, 2015 at 11:06 PM, Yingjoe Chen > wrote: > > On Fri, 2015-12-18 at 12:21 +0800, Daniel Kurtz wrote: > >> Move pinctrl initialization earlier in boot so that real devices can find > >> their p

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Mon, 2015-12-21 at 14:51 +0800, Daniel Kurtz wrote: > On Fri, Dec 18, 2015 at 11:06 PM, Yingjoe Chen > <yingjoe.c...@mediatek.com> wrote: > > On Fri, 2015-12-18 at 12:21 +0800, Daniel Kurtz wrote: > >> Move pinctrl initialization earlier in boot so that real devices

Re: [PATCH v2 4/5] pinctrl: mediatek: Add Pinctrl/GPIO/EINT driver for mt2701

12 +- > drivers/pinctrl/mediatek/pinctrl-mtk-mt2701.h | 2323 > + > 6 files changed, 2945 insertions(+), 1 deletion(-) > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mt2701.c > create mode 100644 drivers/pinctrl/mediatek/pinctrl-mtk-mt2701.h This patch

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Fri, 2015-12-18 at 12:21 +0800, Daniel Kurtz wrote: > Move pinctrl initialization earlier in boot so that real devices can find > their pctldev without probe deferring. > > Signed-off-by: Daniel Kurtz > --- > drivers/pinctrl/mediatek/pinctrl-mt6397.c | 2 +- >

Re: [PATCH] pinctrl: mediatek: convert to arch_initcall

On Fri, 2015-12-18 at 12:21 +0800, Daniel Kurtz wrote: > Move pinctrl initialization earlier in boot so that real devices can find > their pctldev without probe deferring. > > Signed-off-by: Daniel Kurtz > --- > drivers/pinctrl/mediatek/pinctrl-mt6397.c | 2 +- >

Re: [PATCH v2 4/5] pinctrl: mediatek: Add Pinctrl/GPIO/EINT driver for mt2701

atek/pinctrl-mtk-mt2701.h This patch looks good to me. Thanks Acked-by: Yingjoe Chen <yingjoe.c...@mediatek.com> Joe.C > > diff --git a/drivers/pinctrl/mediatek/Kconfig > b/drivers/pinctrl/mediatek/Kconfig > index 02f6f92..13e9939 100644 > --- a/drivers/pinctrl/mediatek

[PATCH] pinctrl: update document for pinconf_generic_parse_dt_config

The returned configs from pinconf_generic_parse_dt_config() is duplicated from original. Make it clear it must be freed when no longer necessary. Signed-off-by: Yingjoe Chen --- It seems memleak in pinctrl-mtk-common.c[1] is not alone. After a quick glance I notice similar issues in drivers

Re: [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node

On Wed, 2015-11-25 at 11:50 +0100, Matthias Brugger wrote: > > On 18/11/15 04:30, Bayi Cheng wrote: > > Add Mediatek nor flash node > > > > Signed-off-by: Bayi Cheng > > Acked-by: Brian Norris > > --- > > arch/arm64/boot/dts/mediatek/mt8173.dtsi | 18 +- > > 1 file changed,

[PATCH] pinctrl: update document for pinconf_generic_parse_dt_config

The returned configs from pinconf_generic_parse_dt_config() is duplicated from original. Make it clear it must be freed when no longer necessary. Signed-off-by: Yingjoe Chen <yingjoe.c...@mediatek.com> --- It seems memleak in pinctrl-mtk-common.c[1] is not alone. After a quick glance I

Re: [PATCH v8 2/2] arm64: dts: mt8173: Add nor flash node

On Wed, 2015-11-25 at 11:50 +0100, Matthias Brugger wrote: > > On 18/11/15 04:30, Bayi Cheng wrote: > > Add Mediatek nor flash node > > > > Signed-off-by: Bayi Cheng > > Acked-by: Brian Norris > > --- > >

Re: [PATCH] pinctrl: mediatek: fix a memleak when do dt maps.

leak issue. > According to Yingjoe's comment, add return checek for > pinconf_generic_parse_dt_config. Reviewed-by: Yingjoe Chen Joe.C > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 27 > - > 1 file changed, 17 insertions(+), 10 deletions(-) > > diff

Re: [PATCH] pinctrl: mediatek: fix a memleak when do dt maps.

On Mon, 2015-11-16 at 20:22 -0800, Hongzhou Yang wrote: > configs will kmemdup to dup_configs in pictrl util function. > So configs need to be freed. > > Signed-off-by: Hongzhou Yang > --- > Fix a memleak issue. > > drivers/pinctrl/mediatek/pinctrl-mtk-common.c | 24 ++--

Re: [PATCH] pinctrl: mediatek: fix a memleak when do dt maps.

On Mon, 2015-11-16 at 20:22 -0800, Hongzhou Yang wrote: > configs will kmemdup to dup_configs in pictrl util function. > So configs need to be freed. > > Signed-off-by: Hongzhou Yang > --- > Fix a memleak issue. > > drivers/pinctrl/mediatek/pinctrl-mtk-common.c |

Re: [PATCH] pinctrl: mediatek: fix a memleak when do dt maps.

Reviewed-by: Matthias Brugger <matthias@gmail.com> > --- > Fix a memleak issue. > According to Yingjoe's comment, add return checek for > pinconf_generic_parse_dt_config. Reviewed-by: Yingjoe Chen <yingjoe.c...@mediatek.com> Joe.C > drivers/pinctrl/mediatek/pinc

Re: [PATCH v2 1/2] i2c: mediatek: add i2c first write then read optimization

On Mon, 2015-11-09 at 16:25 +0200, Andy Shevchenko wrote: > On Mon, Nov 9, 2015 at 7:43 AM, Liguo Zhang wrote: > > For platform with auto restart support, between every transfer, > > i2c controller will trigger an interrupt and SW need to handle > > it to start new transfer. When doing

Re: [PATCH v2 1/2] i2c: mediatek: add i2c first write then read optimization

On Mon, 2015-11-09 at 16:25 +0200, Andy Shevchenko wrote: > On Mon, Nov 9, 2015 at 7:43 AM, Liguo Zhang wrote: > > For platform with auto restart support, between every transfer, > > i2c controller will trigger an interrupt and SW need to handle > > it to start new

Re: [PATCH v5 4/5] ARM: dts: mt8135: enable basic SMP bringup for mt8135

On Mon, 2015-10-26 at 09:56 +0900, Kevin Hilman wrote: > Hello, > > On Sat, Oct 3, 2015 at 12:19 AM, Yingjoe Chen > wrote: > > Add arch timer node to enable arch-timer support. MT8135 firmware > > doesn't correctly setup arch-timer frequency and CNTVOFF, add >

Re: [PATCH v5 4/5] ARM: dts: mt8135: enable basic SMP bringup for mt8135

On Mon, 2015-10-26 at 09:56 +0900, Kevin Hilman wrote: > Hello, > > On Sat, Oct 3, 2015 at 12:19 AM, Yingjoe Chen <yingjoe.c...@mediatek.com> > wrote: > > Add arch timer node to enable arch-timer support. MT8135 firmware > > doesn't correctly setup arch-ti

[PATCH v5 4/5] ARM: dts: mt8135: enable basic SMP bringup for mt8135

Add arch timer node to enable arch-timer support. MT8135 firmware doesn't correctly setup arch-timer frequency and CNTVOFF, add properties to workaround this. This also set cpu enable-method to enable SMP. Signed-off-by: Yingjoe Chen --- arch/arm/boot/dts/mt8135.dtsi | 27

[PATCH v5 5/5] ARM: dts: mt8127: enable basic SMP bringup for mt8127

Add arch timer node to enable arch-timer support. MT8127 firmware doesn't correctly setup arch-timer frequency and CNTVOFF, add properties to workaround this. This also set cpu enable-method to enable SMP. Signed-off-by: Yingjoe Chen --- arch/arm/boot/dts/mt8127.dtsi | 27

[PATCH v5 3/5] ARM: mediatek: add smp bringup code

Add support for booting secondary CPUs on mt6589, mt8127 and mt8135. Signed-off-by: Yingjoe Chen --- arch/arm/mach-mediatek/Makefile | 3 + arch/arm/mach-mediatek/platsmp.c | 141 +++ 2 files changed, 144 insertions(+) create mode 100644 arch/arm/mach

[PATCH v5 2/5] devicetree: bindings: add new SMP enable method Mediatek SoC

This commit add new cpu enable method "mediatek,mt65xx-smp" and "mediatek,mt81xx-tz-smp". Acked-by: Rob Herring Signed-off-by: Yingjoe Chen --- Documentation/devicetree/bindings/arm/cpus.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bind

[PATCH v5 1/5] ARM: mediatek: enable gpt6 on boot up to make arch timer working

From: Matthias Brugger We enable GTP6 which ungates the arch timer clock. In the future this should be done in the bootloader. Signed-off-by: Matthias Brugger Signed-off-by: Yingjoe Chen --- arch/arm/mach-mediatek/mediatek.c | 27 +++ 1 file changed, 27 insertions

[PATCH v5 0/5] Add SMP bringup support for mt65xx socs

tp://lists.infradead.org/pipermail/linux-mediatek/2015-September/002377.html Matthias Brugger (1): ARM: mediatek: enable gpt6 on boot up to make arch timer working Yingjoe Chen (4): devicetree: bindings: add new SMP enable method Mediatek SoC ARM: mediatek: add smp bringup code ARM: dts

[PATCH v4 1/3] dt-bindings: add more MediaTek SoC to mtk-timer binding

Add compatible string for mt8127, mt8135 and mt8173 and sort the list. Signed-off-by: Yingjoe Chen --- Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Documentation/devicetree/bindings/timer/mediatek,mtk

[PATCH v4 2/3] arm64: mediatek: enable MTK_TIMER

Enable MTK_TIMER for MediaTek plaform, which will be used as tick broadcast device and schedule clock. Signed-off-by: Yingjoe Chen --- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/Kconfig.platforms b/arch/arm64/Kconfig.platforms index 23800a1

[PATCH v4 3/3] arm64: dts: mt8173: add timer node

From: Daniel Kurtz Add device node to enable GPT timer. Signed-off-by: Daniel Kurtz Signed-off-by: Eddie Huang Signed-off-by: Yingjoe Chen --- arch/arm64/boot/dts/mediatek/mt8173.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/mt8173.dtsi b

[PATCH v4 0/3] add GPT timer support for mt8173

-mediatek/2015-August/002069.html [3] http://lists.infradead.org/pipermail/linux-mediatek/2015-September/002301.html [4] http://lists.infradead.org/pipermail/linux-mediatek/2015-July/001544.html Daniel Kurtz (1): arm64: dts: mt8173: add timer node Yingjoe Chen (2): dt-bindings: add more

Re: [PATCH v4 0/3] add GPT timer support for mt8173

On Fri, 2015-10-02 at 23:05 +0800, Yingjoe Chen wrote: > This is based on v4.3-rc1 + clockevents-4.4[1] and James's mediatek-clk > tree[2]. > > Changes compare to previous version[3]: > - Add more MediaTek SoC to mtk-timer binding > - Update commit message to better de

Re: [PATCH 2/2] arm64: dts: mt8173: add timer node

On Thu, 2015-10-01 at 16:32 +0100, Sudeep Holla wrote: > > On 01/10/15 15:33, Yingjoe Chen wrote: > > On Thu, 2015-09-17 at 17:13 +0100, Sudeep Holla wrote: > >> > > [...] > > >> > >> I think your are confusing the system counter with arch timers

Re: [PATCH 2/2] arm64: dts: mt8173: add timer node

On Thu, 2015-10-01 at 16:32 +0100, Sudeep Holla wrote: > > On 01/10/15 15:33, Yingjoe Chen wrote: > > On Thu, 2015-09-17 at 17:13 +0100, Sudeep Holla wrote: > >> > > [...] > > >> > >> I think your are confusing the system counter with arch timers

[PATCH v4 1/3] dt-bindings: add more MediaTek SoC to mtk-timer binding

Add compatible string for mt8127, mt8135 and mt8173 and sort the list. Signed-off-by: Yingjoe Chen <yingjoe.c...@mediatek.com> --- Documentation/devicetree/bindings/timer/mediatek,mtk-timer.txt | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Documentation/devi

[PATCH v5 4/5] ARM: dts: mt8135: enable basic SMP bringup for mt8135

Add arch timer node to enable arch-timer support. MT8135 firmware doesn't correctly setup arch-timer frequency and CNTVOFF, add properties to workaround this. This also set cpu enable-method to enable SMP. Signed-off-by: Yingjoe Chen <yingjoe.c...@mediatek.com> --- arch/arm/boot/dts/mt813

[PATCH v4 3/3] arm64: dts: mt8173: add timer node

From: Daniel Kurtz <djku...@chromium.org> Add device node to enable GPT timer. Signed-off-by: Daniel Kurtz <djku...@chromium.org> Signed-off-by: Eddie Huang <eddie.hu...@mediatek.com> Signed-off-by: Yingjoe Chen <yingjoe.c...@mediatek.com> --- arch/arm64/boot/dts/

[PATCH v4 2/3] arm64: mediatek: enable MTK_TIMER

Enable MTK_TIMER for MediaTek plaform, which will be used as tick broadcast device and schedule clock. Signed-off-by: Yingjoe Chen <yingjoe.c...@mediatek.com> --- arch/arm64/Kconfig.platforms | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/Kconfig.platforms b/arch

[PATCH v4 0/3] add GPT timer support for mt8173

-mediatek/2015-August/002069.html [3] http://lists.infradead.org/pipermail/linux-mediatek/2015-September/002301.html [4] http://lists.infradead.org/pipermail/linux-mediatek/2015-July/001544.html Daniel Kurtz (1): arm64: dts: mt8173: add timer node Yingjoe Chen (2): dt-bindings: add more

[PATCH v5 3/5] ARM: mediatek: add smp bringup code

Add support for booting secondary CPUs on mt6589, mt8127 and mt8135. Signed-off-by: Yingjoe Chen <yingjoe.c...@mediatek.com> --- arch/arm/mach-mediatek/Makefile | 3 + arch/arm/mach-mediatek/platsmp.c | 141 +++ 2 files changed, 144 insertions(+)

[PATCH v5 5/5] ARM: dts: mt8127: enable basic SMP bringup for mt8127

Add arch timer node to enable arch-timer support. MT8127 firmware doesn't correctly setup arch-timer frequency and CNTVOFF, add properties to workaround this. This also set cpu enable-method to enable SMP. Signed-off-by: Yingjoe Chen <yingjoe.c...@mediatek.com> --- arch/arm/boot/dts/mt812

[PATCH v5 0/5] Add SMP bringup support for mt65xx socs

tp://lists.infradead.org/pipermail/linux-mediatek/2015-September/002377.html Matthias Brugger (1): ARM: mediatek: enable gpt6 on boot up to make arch timer working Yingjoe Chen (4): devicetree: bindings: add new SMP enable method Mediatek SoC ARM: mediatek: add smp bringup code ARM: dts

Re: [PATCH v4 0/3] add GPT timer support for mt8173

On Fri, 2015-10-02 at 23:05 +0800, Yingjoe Chen wrote: > This is based on v4.3-rc1 + clockevents-4.4[1] and James's mediatek-clk > tree[2]. > > Changes compare to previous version[3]: > - Add more MediaTek SoC to mtk-timer binding > - Update commit message to better de

[PATCH v5 1/5] ARM: mediatek: enable gpt6 on boot up to make arch timer working

From: Matthias Brugger <matthias@gmail.com> We enable GTP6 which ungates the arch timer clock. In the future this should be done in the bootloader. Signed-off-by: Matthias Brugger <matthias@gmail.com> Signed-off-by: Yingjoe Chen <yingjoe.c...@mediatek.com> --- arch

[PATCH v5 2/5] devicetree: bindings: add new SMP enable method Mediatek SoC

This commit add new cpu enable method "mediatek,mt65xx-smp" and "mediatek,mt81xx-tz-smp". Acked-by: Rob Herring <r...@kernel.org> Signed-off-by: Yingjoe Chen <yingjoe.c...@mediatek.com> --- Documentation/devicetree/bindings/arm/cpus.txt | 2 ++ 1 file chan

Re: [PATCH 2/2] arm64: dts: mt8173: add timer node

On Thu, 2015-09-17 at 17:41 +0100, Mark Rutland wrote: > On Thu, Sep 17, 2015 at 03:56:56PM +0100, Yingjoe Chen wrote: > > On Thu, 2015-09-17 at 14:51 +0100, Sudeep Holla wrote: > > > > > > On 16/09/15 03:04, Yingjoe Chen wrote: > > > > From: Daniel

<    1   2   3   4   5   6   7   >