[PATCH] pinctrl: mediatek: Adjust mt8173 pinctrl kconfig

2015-03-09 Thread Yingjoe Chen
build when COMPILE_TEST is enabled. Signed-off-by: Yingjoe Chen yingjoe.c...@mediatek.com --- drivers/pinctrl/mediatek/Kconfig | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/mediatek/Kconfig b/drivers/pinctrl/mediatek/Kconfig index 49b8649..0e3a002

Re: [PATCH 1/5] soc: mediatek: Add SMI driver

2015-03-08 Thread Yingjoe Chen
On Fri, 2015-03-06 at 18:48 +0800, yong...@mediatek.com wrote: > From: Yong Wu > > This patch add SMI(Smart Multimedia Interface) driver. This driver is > responsible to enable/disable iommu and control the clocks of each > local arbiter. > > Signed-off-by: Yong Wu > --- >

Re: [PATCH 1/5] soc: mediatek: Add SMI driver

2015-03-08 Thread Yingjoe Chen
On Fri, 2015-03-06 at 18:48 +0800, yong...@mediatek.com wrote: From: Yong Wu yong...@mediatek.com This patch add SMI(Smart Multimedia Interface) driver. This driver is responsible to enable/disable iommu and control the clocks of each local arbiter. Signed-off-by: Yong Wu

[PATCH 1/2] arm64: mediatek: Select PINCTRL for Mediatek platform

2015-03-05 Thread Yingjoe Chen
? -- MediaTek SoC expect to work with a pinctrl driver. Select PINCTRL if ARCH_MEDIATEK is selected. Signed-off-by: Yingjoe Chen --- arch/arm64/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index e627ead..a2ddd3f 100644

[PATCH 2/2] pinctrl: mediatek: Adjust mt8173 pinctrl kconfig

2015-03-05 Thread Yingjoe Chen
. Adjust mt8173 pinctrl kconfig entry so user can manually select it. Also make PINCTRL_MT8135 build when COMPILE_TEST is enabled. Signed-off-by: Yingjoe Chen --- drivers/pinctrl/mediatek/Kconfig | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/mediatek

[PATCH 2/2] pinctrl: mediatek: Adjust mt8173 pinctrl kconfig

2015-03-05 Thread Yingjoe Chen
. Adjust mt8173 pinctrl kconfig entry so user can manually select it. Also make PINCTRL_MT8135 build when COMPILE_TEST is enabled. Signed-off-by: Yingjoe Chen yingjoe.c...@mediatek.com --- drivers/pinctrl/mediatek/Kconfig | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCH 1/2] arm64: mediatek: Select PINCTRL for Mediatek platform

2015-03-05 Thread Yingjoe Chen
? -- MediaTek SoC expect to work with a pinctrl driver. Select PINCTRL if ARCH_MEDIATEK is selected. Signed-off-by: Yingjoe Chen yingjoe.c...@mediatek.com --- arch/arm64/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index

Re: [PATCH 1/3] arm64: mediatek: Add config option for mt8173.

2015-03-04 Thread Yingjoe Chen
On Wed, 2015-03-04 at 10:53 +0100, Arnd Bergmann wrote: > On Wednesday 04 March 2015 10:31:07 Yingjoe Chen wrote: > > Hi, > > > > Since we support devicetree, we don't need MACH_* to build a working > > kernel. This is true even for our v7 soc. We intend to use it to re

Re: [PATCH 1/3] arm64: mediatek: Add config option for mt8173.

2015-03-04 Thread Yingjoe Chen
On Wed, 2015-03-04 at 10:53 +0100, Arnd Bergmann wrote: On Wednesday 04 March 2015 10:31:07 Yingjoe Chen wrote: Hi, Since we support devicetree, we don't need MACH_* to build a working kernel. This is true even for our v7 soc. We intend to use it to reduce numbers of drivers in product

Re: [PATCH 1/3] arm64: mediatek: Add config option for mt8173.

2015-03-03 Thread Yingjoe Chen
On Wed, 2015-02-25 at 11:11 +, Catalin Marinas wrote: > On Wed, Feb 25, 2015 at 11:51:57AM +0100, Arnd Bergmann wrote: > > On Wednesday 25 February 2015 17:07:22 Yingjoe Chen wrote: > > > On Tue, 2015-01-27 at 15:13 +0800, Hongzhou Yang wrote: > >

Re: [PATCH 1/3] arm64: mediatek: Add config option for mt8173.

2015-03-03 Thread Yingjoe Chen
On Wed, 2015-02-25 at 11:11 +, Catalin Marinas wrote: On Wed, Feb 25, 2015 at 11:51:57AM +0100, Arnd Bergmann wrote: On Wednesday 25 February 2015 17:07:22 Yingjoe Chen wrote: On Tue, 2015-01-27 at 15:13 +0800, Hongzhou Yang wrote: From: Hongzhou Yang hongzhou.y...@mediatek.com

Re: [PATCH 1/3] arm64: mediatek: Add config option for mt8173.

2015-02-25 Thread Yingjoe Chen
On Tue, 2015-01-27 at 15:13 +0800, Hongzhou Yang wrote: > From: Hongzhou Yang > > The upcoming MTK pinctrl driver have a big pin table for each SoC, > and we don't want to bloat the kernel binary if we don't need it. > Add config options so we can build for one SoC only. > > Signed-off-by:

Re: [PATCH 1/3] arm64: mediatek: Add config option for mt8173.

2015-02-25 Thread Yingjoe Chen
On Tue, 2015-01-27 at 15:13 +0800, Hongzhou Yang wrote: From: Hongzhou Yang hongzhou.y...@mediatek.com The upcoming MTK pinctrl driver have a big pin table for each SoC, and we don't want to bloat the kernel binary if we don't need it. Add config options so we can build for one SoC only.

[PATCH] arm64: mm: remove unused functions and variable protoypes

2015-02-24 Thread Yingjoe Chen
The functions __cpu_flush_user_tlb_range and __cpu_flush_kern_tlb_range were removed in commit fa48e6f780 'arm64: mm: Optimise tlb flush logic where we have >4K granule'. Global variable cpu_tlb was never used in arm64. Remove them. Signed-off-by: Yingjoe Chen --- arch/arm64/include/

[PATCH] arm64: mm: remove unused functions and variable protoypes

2015-02-24 Thread Yingjoe Chen
The functions __cpu_flush_user_tlb_range and __cpu_flush_kern_tlb_range were removed in commit fa48e6f780 'arm64: mm: Optimise tlb flush logic where we have 4K granule'. Global variable cpu_tlb was never used in arm64. Remove them. Signed-off-by: Yingjoe Chen yingjoe.c...@mediatek.com --- arch

Re: [PATCH 1/7] pinctrl: mediatek: emulate GPIO interrupt on both-edges

2015-02-10 Thread Yingjoe Chen
On Tue, 2015-02-10 at 09:40 +0100, Uwe Kleine-König wrote: > Hello, > > On Tue, Jan 27, 2015 at 02:15:26PM +0800, Chaotian Jing wrote: > > From: Yingjoe Chen > > > > MTK EINT does not support generating interrupt on both edges. > > Emulate this by changi

Re: [PATCH 1/7] pinctrl: mediatek: emulate GPIO interrupt on both-edges

2015-02-10 Thread Yingjoe Chen
On Tue, 2015-02-10 at 09:40 +0100, Uwe Kleine-König wrote: Hello, On Tue, Jan 27, 2015 at 02:15:26PM +0800, Chaotian Jing wrote: From: Yingjoe Chen yingjoe.c...@mediatek.com MTK EINT does not support generating interrupt on both edges. Emulate this by changing edge polarity while

Re: Recommendations for a new MFD device driver?

2015-02-06 Thread Yingjoe Chen
On Fri, 2015-02-06 at 11:54 +, Mark Brown wrote: > On Fri, Feb 06, 2015 at 11:10:06AM +0100, Sascha Hauer wrote: > > > 1) Put it into the RTC device driver. > > 2) Put it into the .resource field of struct mfd_cell > > 3) Put it into the device tree using standard reg, interrupt properties

Re: Recommendations for a new MFD device driver?

2015-02-06 Thread Yingjoe Chen
On Fri, 2015-02-06 at 11:54 +, Mark Brown wrote: On Fri, Feb 06, 2015 at 11:10:06AM +0100, Sascha Hauer wrote: 1) Put it into the RTC device driver. 2) Put it into the .resource field of struct mfd_cell 3) Put it into the device tree using standard reg, interrupt properties and

Re: [patch] irqchip: mtk-sysirq: fix an error code

2015-02-04 Thread Yingjoe Chen
t;mtk_sysirq: unable to map sysirq register\n"); > - ret = PTR_ERR(chip_data->intpol_base); > + ret = -ENOMEM; > goto out_free; > } > Dan, Thanks for catching this. Acked-by: Yingjoe Chen I changed to use ioremap(), and remem

Re: [patch] irqchip: mtk-sysirq: fix an error code

2015-02-04 Thread Yingjoe Chen
-intpol_base); + ret = -ENOMEM; goto out_free; } Dan, Thanks for catching this. Acked-by: Yingjoe Chen yingjoe.c...@mediatek.com I changed to use ioremap(), and remember to change the null pointer check but not the return type. Sorry for the mistake. Joe.C

Re: [PATCH v5 1/5] ARM: mediatek: Add config options for mediatek SoCs.

2015-01-27 Thread Yingjoe Chen
Hi, On Tue, 2015-01-27 at 11:16 +0100, Paul Bolle wrote: > Joe, > > On Thu, 2015-01-22 at 13:54 +0100, Matthias Brugger wrote: > > 2015-01-21 6:28 GMT+01:00 Hongzhou Yang : > > > From: Yingjoe Chen > > > > > > The upcoming MTK pinctrl driver have a big

Re: [PATCH v5 1/5] ARM: mediatek: Add config options for mediatek SoCs.

2015-01-27 Thread Yingjoe Chen
Hi, On Tue, 2015-01-27 at 11:16 +0100, Paul Bolle wrote: Joe, On Thu, 2015-01-22 at 13:54 +0100, Matthias Brugger wrote: 2015-01-21 6:28 GMT+01:00 Hongzhou Yang hongzhou.y...@mediatek.com: From: Yingjoe Chen yingjoe.c...@mediatek.com The upcoming MTK pinctrl driver have a big pin

[tip:irq/core] irqchip: mtk-sysirq: Get irq number from register resource size

2015-01-26 Thread tip-bot for Yingjoe Chen
Commit-ID: cdb647a772e9def47594ff8ce7acf47f4d257b2e Gitweb: http://git.kernel.org/tip/cdb647a772e9def47594ff8ce7acf47f4d257b2e Author: Yingjoe Chen AuthorDate: Mon, 12 Jan 2015 17:14:31 +0800 Committer: Thomas Gleixner CommitDate: Mon, 26 Jan 2015 11:38:22 +0100 irqchip: mtk-sysirq

[tip:irq/core] irqchip: mtk-sysirq: Get irq number from register resource size

2015-01-26 Thread tip-bot for Yingjoe Chen
Commit-ID: cdb647a772e9def47594ff8ce7acf47f4d257b2e Gitweb: http://git.kernel.org/tip/cdb647a772e9def47594ff8ce7acf47f4d257b2e Author: Yingjoe Chen yingjoe.c...@mediatek.com AuthorDate: Mon, 12 Jan 2015 17:14:31 +0800 Committer: Thomas Gleixner t...@linutronix.de CommitDate: Mon, 26 Jan

Re: [PATCH v4 2/2] I2C: mediatek: Add driver for MediaTek I2C controller

2015-01-21 Thread Yingjoe Chen
Hi, On Wed, 2015-01-21 at 16:31 +0100, Uwe Kleine-König wrote: > Hello, > > On Wed, Jan 21, 2015 at 08:49:40PM +0800, Yingjoe Chen wrote: > > On Wed, 2015-01-21 at 09:15 +0100, Uwe Kleine-König wrote: <...> > > > > > > > +static int m

Re: [PATCH v4 2/2] I2C: mediatek: Add driver for MediaTek I2C controller

2015-01-21 Thread Yingjoe Chen
On Wed, 2015-01-21 at 09:15 +0100, Uwe Kleine-König wrote: > Hello, > > On Wed, Jan 21, 2015 at 02:30:09PM +0800, Yingjoe Chen wrote: > > On Wed, 2015-01-21 at 11:13 +0800, Eddie Huang wrote: > > <...> > > > > > + ret = -EIN

Re: [PATCH v4 2/2] I2C: mediatek: Add driver for MediaTek I2C controller

2015-01-21 Thread Yingjoe Chen
Hi, On Wed, 2015-01-21 at 16:31 +0100, Uwe Kleine-König wrote: Hello, On Wed, Jan 21, 2015 at 08:49:40PM +0800, Yingjoe Chen wrote: On Wed, 2015-01-21 at 09:15 +0100, Uwe Kleine-König wrote: ... +static int mtk_i2c_remove(struct platform_device *pdev) +{ + struct

Re: [PATCH v4 2/2] I2C: mediatek: Add driver for MediaTek I2C controller

2015-01-21 Thread Yingjoe Chen
On Wed, 2015-01-21 at 09:15 +0100, Uwe Kleine-König wrote: Hello, On Wed, Jan 21, 2015 at 02:30:09PM +0800, Yingjoe Chen wrote: On Wed, 2015-01-21 at 11:13 +0800, Eddie Huang wrote: ... + ret = -EINVAL; + goto err_exit

Re: [PATCH v4 2/2] I2C: mediatek: Add driver for MediaTek I2C controller

2015-01-20 Thread Yingjoe Chen
Hi Uwe, Thanks for your review, On Wed, 2015-01-21 at 11:13 +0800, Eddie Huang wrote: <...> > > > + ret = -EINVAL; > > > + goto err_exit; > > > + } > > > + > > > + if (msgs->buf == NULL) { > > > + dev_dbg(i2c->dev, " data buffer is NULL.\n"); > > > + ret =

Re: [PATCH v5 0/5] Add Mediatek SoC Pinctrl/GPIO/EINT driver for MT8135.

2015-01-20 Thread Yingjoe Chen
On Wed, 2015-01-21 at 13:28 +0800, Hongzhou Yang wrote: > This is v5 of add Mediatek SoC Pinctrl/GPIO/EINT driver for MT8135. > It is based on Joe.C' basic device tree support. > See > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/296093.html Hi, A little correction. I just

Re: [PATCH 2/8] soc: Add MediaTek pericfg controller support

2015-01-20 Thread Yingjoe Chen
On Tue, 2015-01-20 at 10:47 +0100, Sascha Hauer wrote: <...> > diff --git a/drivers/soc/mediatek/mtk-pericfg.c > b/drivers/soc/mediatek/mtk-pericfg.c > index b7ee902..aa9a7eb 100644 > --- a/drivers/soc/mediatek/mtk-pericfg.c > +++ b/drivers/soc/mediatek/mtk-pericfg.c > @@ -1,6 +1,5 @@ > /* > *

Re: [PATCH 2/8] soc: Add MediaTek pericfg controller support

2015-01-20 Thread Yingjoe Chen
On Tue, 2015-01-20 at 10:47 +0100, Sascha Hauer wrote: ... diff --git a/drivers/soc/mediatek/mtk-pericfg.c b/drivers/soc/mediatek/mtk-pericfg.c index b7ee902..aa9a7eb 100644 --- a/drivers/soc/mediatek/mtk-pericfg.c +++ b/drivers/soc/mediatek/mtk-pericfg.c @@ -1,6 +1,5 @@ /* * Copyright

Re: [PATCH v5 0/5] Add Mediatek SoC Pinctrl/GPIO/EINT driver for MT8135.

2015-01-20 Thread Yingjoe Chen
On Wed, 2015-01-21 at 13:28 +0800, Hongzhou Yang wrote: This is v5 of add Mediatek SoC Pinctrl/GPIO/EINT driver for MT8135. It is based on Joe.C' basic device tree support. See http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/296093.html Hi, A little correction. I just

Re: [PATCH v4 2/2] I2C: mediatek: Add driver for MediaTek I2C controller

2015-01-20 Thread Yingjoe Chen
Hi Uwe, Thanks for your review, On Wed, 2015-01-21 at 11:13 +0800, Eddie Huang wrote: ... + ret = -EINVAL; + goto err_exit; + } + + if (msgs-buf == NULL) { + dev_dbg(i2c-dev, data buffer is NULL.\n); + ret = -EINVAL; + goto

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-16 Thread Yingjoe Chen
On Fri, 2015-01-16 at 10:53 +0100, Linus Walleij wrote: > On Tue, Jan 13, 2015 at 5:16 PM, Sascha Hauer wrote: > > On Tue, Jan 13, 2015 at 11:05:22AM +0100, Linus Walleij wrote: > > >> > You often talk about ambiguities. Could you give an example what > >> > ambiguities you mean? > >> > >> What

Re: [RFC 01/11] i2c: add quirk structure to describe adapter flaws

2015-01-16 Thread Yingjoe Chen
On Fri, 2015-01-09 at 18:21 +0100, Wolfram Sang wrote: > The number of I2C adapters which are not fully I2C compatible is rising, > sadly. Drivers usually do handle the flaws, still the user receives only > some errno for a transfer which normally can be expected to work. This > patch introduces a

Re: [RFC 01/11] i2c: add quirk structure to describe adapter flaws

2015-01-16 Thread Yingjoe Chen
On Fri, 2015-01-09 at 18:21 +0100, Wolfram Sang wrote: The number of I2C adapters which are not fully I2C compatible is rising, sadly. Drivers usually do handle the flaws, still the user receives only some errno for a transfer which normally can be expected to work. This patch introduces a

Re: [PATCH v3 2/3] dt-bindings: Add pinctrl bindings for mt65xx/mt81xx.

2015-01-16 Thread Yingjoe Chen
On Fri, 2015-01-16 at 10:53 +0100, Linus Walleij wrote: On Tue, Jan 13, 2015 at 5:16 PM, Sascha Hauer s.ha...@pengutronix.de wrote: On Tue, Jan 13, 2015 at 11:05:22AM +0100, Linus Walleij wrote: You often talk about ambiguities. Could you give an example what ambiguities you mean?

Re: [PATCH v4 4/5] ARM: mediatek: Add EINT support to MTK pinctrl driver.

2015-01-15 Thread Yingjoe Chen
On Thu, 2015-01-15 at 18:30 +0100, Linus Walleij wrote: > On Wed, Jan 14, 2015 at 3:32 AM, Yingjoe Chen > wrote: > > > Let's me describe my problem more clearly. On our SoC, if a pin support > > interrupt it will have 2 different numbers for it. For examples, here

Re: [PATCH v4 4/5] ARM: mediatek: Add EINT support to MTK pinctrl driver.

2015-01-15 Thread Yingjoe Chen
On Thu, 2015-01-15 at 18:30 +0100, Linus Walleij wrote: On Wed, Jan 14, 2015 at 3:32 AM, Yingjoe Chen yingjoe.c...@mediatek.com wrote: Let's me describe my problem more clearly. On our SoC, if a pin support interrupt it will have 2 different numbers for it. For examples, here's

Re: [PATCH v4 1/5] ARM: mediatek: Add config options for mediatek SoCs.

2015-01-13 Thread Yingjoe Chen
On Tue, 2015-01-13 at 10:43 +0100, Linus Walleij wrote: > On Wed, Dec 17, 2014 at 12:34 AM, Hongzhou Yang > wrote: > > > From: Yingjoe Chen > > > > The upcoming MTK pinctrl driver have a big pin table for each SoC > > and we don't want to bloat the kernel bi

Re: [PATCH v4 4/5] ARM: mediatek: Add EINT support to MTK pinctrl driver.

2015-01-13 Thread Yingjoe Chen
On Tue, 2015-01-13 at 14:24 +0100, Linus Walleij wrote: > On Tue, Jan 6, 2015 at 10:16 AM, Yingjoe Chen > wrote: > > On Wed, 2014-12-17 at 17:09 +0800, Yingjoe Chen wrote: > >> On Wed, 2014-12-17 at 07:34 +0800, Hongzhou Yang wrote: > >> > From: Maoguang Me

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2015-01-13 Thread Yingjoe Chen
On Tue, 2015-01-13 at 10:57 +0100, Wolfram Sang wrote: > On Tue, Jan 06, 2015 at 02:37:53PM +0100, Wolfram Sang wrote: > > > > > We've started upstream work for MT8173[1]. > > > > > > We've fixed these issues for new SoC, and we believe it is fully I2C > > > compatible now. We'll add mt8173

Re: [PATCH v4 4/5] ARM: mediatek: Add EINT support to MTK pinctrl driver.

2015-01-13 Thread Yingjoe Chen
On Tue, 2015-01-13 at 14:24 +0100, Linus Walleij wrote: On Tue, Jan 6, 2015 at 10:16 AM, Yingjoe Chen yingjoe.c...@mediatek.com wrote: On Wed, 2014-12-17 at 17:09 +0800, Yingjoe Chen wrote: On Wed, 2014-12-17 at 07:34 +0800, Hongzhou Yang wrote: From: Maoguang Meng maoguang.m

Re: [PATCH v4 1/5] ARM: mediatek: Add config options for mediatek SoCs.

2015-01-13 Thread Yingjoe Chen
On Tue, 2015-01-13 at 10:43 +0100, Linus Walleij wrote: On Wed, Dec 17, 2014 at 12:34 AM, Hongzhou Yang hongzhou.y...@mediatek.com wrote: From: Yingjoe Chen yingjoe.c...@mediatek.com The upcoming MTK pinctrl driver have a big pin table for each SoC and we don't want to bloat the kernel

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2015-01-13 Thread Yingjoe Chen
On Tue, 2015-01-13 at 10:57 +0100, Wolfram Sang wrote: On Tue, Jan 06, 2015 at 02:37:53PM +0100, Wolfram Sang wrote: We've started upstream work for MT8173[1]. We've fixed these issues for new SoC, and we believe it is fully I2C compatible now. We'll add mt8173 support to this

Re: [PATCH] pinctrl: pass -DDEBUG in subdirs

2015-01-09 Thread Yingjoe Chen
On Fri, 2015-01-09 at 10:41 +0100, Linus Walleij wrote: > When drivers are compiled in subdirectories the -DDEBUG flag need > to be passed in the individual Makefiles. Hi, It will be easy to forget adding this when adding new subdirectories. Can we do this instead? diff --git

Re: [PATCH] pinctrl: pass -DDEBUG in subdirs

2015-01-09 Thread Yingjoe Chen
On Fri, 2015-01-09 at 10:41 +0100, Linus Walleij wrote: When drivers are compiled in subdirectories the -DDEBUG flag need to be passed in the individual Makefiles. Hi, It will be easy to forget adding this when adding new subdirectories. Can we do this instead? diff --git

Re: [PATCH v4 4/5] ARM: mediatek: Add EINT support to MTK pinctrl driver.

2015-01-06 Thread Yingjoe Chen
On Wed, 2014-12-17 at 17:09 +0800, Yingjoe Chen wrote: > On Wed, 2014-12-17 at 07:34 +0800, Hongzhou Yang wrote: > > From: Maoguang Meng > > > > MTK SoC support external interrupt(EINT) from most SoC pins. > > Add EINT support to pinctrl driver. > > > > S

Re: [PATCH v4 4/5] ARM: mediatek: Add EINT support to MTK pinctrl driver.

2015-01-06 Thread Yingjoe Chen
On Wed, 2014-12-17 at 17:09 +0800, Yingjoe Chen wrote: On Wed, 2014-12-17 at 07:34 +0800, Hongzhou Yang wrote: From: Maoguang Meng maoguang.m...@mediatek.com MTK SoC support external interrupt(EINT) from most SoC pins. Add EINT support to pinctrl driver. Signed-off-by: Maoguang Meng

Re: [PATCH v8 3/4] ARM: mediatek: Add sysirq in mt6589/mt8135/mt8127 dtsi

2014-12-24 Thread Yingjoe Chen
Hi Matthias, On Tue, 2014-11-25 at 16:04 +0800, Yingjoe Chen wrote: > Add sysirq settings for mt6589/mt8135/mt8127 > This also correct timer interrupt flag. The old setting works > because boot loader already set polarity for timer interrupt. > Without intpol support, the setting was

Re: [PATCH v8 3/4] ARM: mediatek: Add sysirq in mt6589/mt8135/mt8127 dtsi

2014-12-24 Thread Yingjoe Chen
Hi Matthias, On Tue, 2014-11-25 at 16:04 +0800, Yingjoe Chen wrote: Add sysirq settings for mt6589/mt8135/mt8127 This also correct timer interrupt flag. The old setting works because boot loader already set polarity for timer interrupt. Without intpol support, the setting was not changed so

Re: [PATCH v4 4/5] ARM: mediatek: Add EINT support to MTK pinctrl driver.

2014-12-17 Thread Yingjoe Chen
On Wed, 2014-12-17 at 07:34 +0800, Hongzhou Yang wrote: > From: Maoguang Meng > > MTK SoC support external interrupt(EINT) from most SoC pins. > Add EINT support to pinctrl driver. > > Signed-off-by: Maoguang Meng > Signed-off-by: Hongzhou Yang Hi Linus, This patch add EINT support to the

Re: [PATCH v4 4/5] ARM: mediatek: Add EINT support to MTK pinctrl driver.

2014-12-17 Thread Yingjoe Chen
On Wed, 2014-12-17 at 07:34 +0800, Hongzhou Yang wrote: From: Maoguang Meng maoguang.m...@mediatek.com MTK SoC support external interrupt(EINT) from most SoC pins. Add EINT support to pinctrl driver. Signed-off-by: Maoguang Meng maoguang.m...@mediatek.com Signed-off-by: Hongzhou Yang

[PATCH v3] irqchip: mtk-sysirq: Use IS_ERR() instead of NULL pointer check

2014-12-12 Thread Yingjoe Chen
(). Reported-by: Beniamino Galvani Signed-off-by: Yingjoe Chen --- drivers/irqchip/irq-mtk-sysirq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c index 7e342df..0b0d2c0 100644 --- a/drivers/irqchip/irq-mtk

[PATCH v3] irqchip: mtk-sysirq: Use IS_ERR() instead of NULL pointer check

2014-12-12 Thread Yingjoe Chen
(). Reported-by: Beniamino Galvani b.galv...@gmail.com Signed-off-by: Yingjoe Chen yingjoe.c...@mediatek.com --- drivers/irqchip/irq-mtk-sysirq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c index 7e342df

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2014-12-11 Thread Yingjoe Chen
On Thu, 2014-11-27 at 17:45 +0100, Wolfram Sang wrote: > > > I think there are now 3 drivers in my queue which are not fully I2C > > > compatible but more supporting the very minimum to, say, read an eeprom. > > > I am not feeling well to allow them to use I2C_FUNC_I2C. So, I want to > > > think

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2014-12-11 Thread Yingjoe Chen
On Thu, 2014-11-27 at 17:45 +0100, Wolfram Sang wrote: I think there are now 3 drivers in my queue which are not fully I2C compatible but more supporting the very minimum to, say, read an eeprom. I am not feeling well to allow them to use I2C_FUNC_I2C. So, I want to think about ways

Re: [PATCH 2/4] irqchip: mediatek: Add support for mt8173

2014-12-10 Thread Yingjoe Chen
Hi Arnd, On Wed, 2014-12-10 at 12:00 +0100, Arnd Bergmann wrote: > On Wednesday 10 December 2014 18:50:00 Eddie Huang wrote: > > From: Yingjoe Chen > > > > MT8173 intpol have 32 more irq pins, add support to it. > > > > Signed-off-by: Yingjoe Che

Re: [PATCH 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile

2014-12-10 Thread Yingjoe Chen
Hi, On Wed, 2014-12-10 at 18:50 +0800, Eddie Huang wrote: <...> > diff --git a/arch/arm64/boot/dts/mt8173-evb.dts > b/arch/arm64/boot/dts/mt8173-evb.dts > new file mode 100644 > index 000..adf26dd > --- /dev/null > +++ b/arch/arm64/boot/dts/mt8173-evb.dts <...> > + timer { > +

Re: [PATCH v2] irqchip: mediatek: Use IS_ERR() instead of NULL pointer check

2014-12-10 Thread Yingjoe Chen
On Wed, 2014-12-10 at 07:53 -0500, Jason Cooper wrote: > On Wed, Dec 10, 2014 at 01:14:43PM +0100, Beniamino Galvani wrote: > > On Wed, Dec 10, 2014 at 05:55:02PM +0800, Yingjoe Chen wrote: > > > Beniamino reported a kernel oops caused by an invalid DT file for the > &

[PATCH v2] irqchip: mediatek: Use IS_ERR() instead of NULL pointer check

2014-12-10 Thread Yingjoe Chen
value passes the NULL pointer check and causes a kernel panic when dereferenced. Use IS_ERR() and return the error value via PTR_ERR(). Reported-and-tested-by: Beniamino Galvani Signed-off-by: Yingjoe Chen --- drivers/irqchip/irq-mtk-sysirq.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH v5] clocksource: arch_timer: Fix code to use physical timers when requested

2014-12-10 Thread Yingjoe Chen
ut not > the timer, use use the physical timer as it makes it easier for KVM). > > So the patch below, on top of linux-next, should solve the BUG(): Thanks for detail explanation and the patch. I tested it on my platform and it did solve the issue. So, Tested-by: Yingjoe Chen Joe.C --

Re: [PATCH v5] clocksource: arch_timer: Fix code to use physical timers when requested

2014-12-10 Thread Yingjoe Chen
the physical timer as it makes it easier for KVM). So the patch below, on top of linux-next, should solve the BUG(): Thanks for detail explanation and the patch. I tested it on my platform and it did solve the issue. So, Tested-by: Yingjoe Chen yingjoe.c...@mediatek.com Joe.C -- To unsubscribe from

[PATCH v2] irqchip: mediatek: Use IS_ERR() instead of NULL pointer check

2014-12-10 Thread Yingjoe Chen
value passes the NULL pointer check and causes a kernel panic when dereferenced. Use IS_ERR() and return the error value via PTR_ERR(). Reported-and-tested-by: Beniamino Galvani b.galv...@gmail.com Signed-off-by: Yingjoe Chen yingjoe.c...@mediatek.com --- drivers/irqchip/irq-mtk-sysirq.c | 4

Re: [PATCH v2] irqchip: mediatek: Use IS_ERR() instead of NULL pointer check

2014-12-10 Thread Yingjoe Chen
On Wed, 2014-12-10 at 07:53 -0500, Jason Cooper wrote: On Wed, Dec 10, 2014 at 01:14:43PM +0100, Beniamino Galvani wrote: On Wed, Dec 10, 2014 at 05:55:02PM +0800, Yingjoe Chen wrote: Beniamino reported a kernel oops caused by an invalid DT file for the mediatek interrupt polarity

Re: [PATCH 3/4] arm64: dts: Add mediatek MT8173 SoC and evaluation board dts and Makefile

2014-12-10 Thread Yingjoe Chen
Hi, On Wed, 2014-12-10 at 18:50 +0800, Eddie Huang wrote: ... diff --git a/arch/arm64/boot/dts/mt8173-evb.dts b/arch/arm64/boot/dts/mt8173-evb.dts new file mode 100644 index 000..adf26dd --- /dev/null +++ b/arch/arm64/boot/dts/mt8173-evb.dts ... + timer { +

Re: [PATCH 2/4] irqchip: mediatek: Add support for mt8173

2014-12-10 Thread Yingjoe Chen
Hi Arnd, On Wed, 2014-12-10 at 12:00 +0100, Arnd Bergmann wrote: On Wednesday 10 December 2014 18:50:00 Eddie Huang wrote: From: Yingjoe Chen yingjoe.c...@mediatek.com MT8173 intpol have 32 more irq pins, add support to it. Signed-off-by: Yingjoe Chen yingjoe.c...@mediatek.com

Re: [PATCH v5] clocksource: arch_timer: Fix code to use physical timers when requested

2014-12-08 Thread Yingjoe Chen
On Mon, 2014-12-08 at 16:21 +, Catalin Marinas wrote: > On Fri, Dec 05, 2014 at 10:41:04AM +0000, Yingjoe Chen wrote: > > On Sun, 2014-11-23 at 23:02 -0800, Sonny Rao wrote: > > > This is a bug fix for using physical arch timers when > > > the arch_timer_u

Re: [PATCH] irqchip: mediatek: Fix error return code detection

2014-12-08 Thread Yingjoe Chen
On Mon, 2014-12-08 at 21:30 +0100, Thomas Gleixner wrote: > On Mon, 8 Dec 2014, Yingjoe Chen wrote: > > > This fix an error handling bug reported by Beniamino, this is based on > > mtk intpol patches [1] > > > > Joe.C > > > > http://lists.infradead.or

[PATCH] irqchip: mediatek: Fix error return code detection

2014-12-08 Thread Yingjoe Chen
in mtk_sysirq_of_init() to correctly handle this. Signed-off-by: Yingjoe Chen --- drivers/irqchip/irq-mtk-sysirq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c index 7e342df..0b0d2c0 100644

[PATCH] irqchip: mediatek: Fix error return code detection

2014-12-08 Thread Yingjoe Chen
in mtk_sysirq_of_init() to correctly handle this. Signed-off-by: Yingjoe Chen yingjoe.c...@mediatek.com --- drivers/irqchip/irq-mtk-sysirq.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-mtk-sysirq.c b/drivers/irqchip/irq-mtk-sysirq.c index 7e342df

Re: [PATCH] irqchip: mediatek: Fix error return code detection

2014-12-08 Thread Yingjoe Chen
On Mon, 2014-12-08 at 21:30 +0100, Thomas Gleixner wrote: On Mon, 8 Dec 2014, Yingjoe Chen wrote: This fix an error handling bug reported by Beniamino, this is based on mtk intpol patches [1] Joe.C http://lists.infradead.org/pipermail/linux-arm-kernel/2014-November/305808.html

Re: [PATCH v5] clocksource: arch_timer: Fix code to use physical timers when requested

2014-12-08 Thread Yingjoe Chen
On Mon, 2014-12-08 at 16:21 +, Catalin Marinas wrote: On Fri, Dec 05, 2014 at 10:41:04AM +, Yingjoe Chen wrote: On Sun, 2014-11-23 at 23:02 -0800, Sonny Rao wrote: This is a bug fix for using physical arch timers when the arch_timer_use_virtual boolean is false. It restores

Re: [PATCH v5] clocksource: arch_timer: Fix code to use physical timers when requested

2014-12-05 Thread Yingjoe Chen
On Sun, 2014-11-23 at 23:02 -0800, Sonny Rao wrote: > This is a bug fix for using physical arch timers when > the arch_timer_use_virtual boolean is false. It restores the > arch_counter_get_cntpct() function after removal in > > 0d651e4e "clocksource: arch_timer: use virtual counters" > > We

Re: [PATCH v5] clocksource: arch_timer: Fix code to use physical timers when requested

2014-12-05 Thread Yingjoe Chen
On Sun, 2014-11-23 at 23:02 -0800, Sonny Rao wrote: This is a bug fix for using physical arch timers when the arch_timer_use_virtual boolean is false. It restores the arch_counter_get_cntpct() function after removal in 0d651e4e clocksource: arch_timer: use virtual counters We need this

Re: [PATCH v8 2/4] ARM: mediatek: Add sysirq interrupt polarity support

2014-12-01 Thread Yingjoe Chen
On Sat, 2014-11-29 at 18:40 +0100, Beniamino Galvani wrote: > On Tue, Nov 25, 2014 at 04:04:20PM +0800, Yingjoe Chen wrote: > > Mediatek SoCs have interrupt polarity support in sysirq which > > allows to invert polarity for given interrupt. Add this support > > using

Re: [PATCH v8 2/4] ARM: mediatek: Add sysirq interrupt polarity support

2014-12-01 Thread Yingjoe Chen
On Sat, 2014-11-29 at 18:40 +0100, Beniamino Galvani wrote: On Tue, Nov 25, 2014 at 04:04:20PM +0800, Yingjoe Chen wrote: Mediatek SoCs have interrupt polarity support in sysirq which allows to invert polarity for given interrupt. Add this support using hierarchy irq domain

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-27 Thread Yingjoe Chen
Hi, On Mon, 2014-11-24 at 13:15 +0100, Wolfram Sang wrote: > Hi, > > some very high level remarks: > > On Mon, Nov 24, 2014 at 05:38:46PM +0800, Xudong Chen wrote: > > This series is the third version of Mediatek SoCs I2C controller common > > bus driver. > > Compared to the second version, >

Re: [PATCH v8 3/4] ARM: mediatek: Add sysirq in mt6589/mt8135/mt8127 dtsi

2014-11-27 Thread Yingjoe Chen
On Tue, 2014-11-25 at 16:04 +0800, Yingjoe Chen wrote: > Add sysirq settings for mt6589/mt8135/mt8127 > This also correct timer interrupt flag. The old setting works > because boot loader already set polarity for timer interrupt. > Without intpol support, the setting was not changed

Re: [PATCH v8 3/4] ARM: mediatek: Add sysirq in mt6589/mt8135/mt8127 dtsi

2014-11-27 Thread Yingjoe Chen
On Tue, 2014-11-25 at 16:04 +0800, Yingjoe Chen wrote: Add sysirq settings for mt6589/mt8135/mt8127 This also correct timer interrupt flag. The old setting works because boot loader already set polarity for timer interrupt. Without intpol support, the setting was not changed so gic can get

Re: [PATCH v3 0/2] ARM: mediatek: Add driver for Mediatek I2C controller

2014-11-27 Thread Yingjoe Chen
Hi, On Mon, 2014-11-24 at 13:15 +0100, Wolfram Sang wrote: Hi, some very high level remarks: On Mon, Nov 24, 2014 at 05:38:46PM +0800, Xudong Chen wrote: This series is the third version of Mediatek SoCs I2C controller common bus driver. Compared to the second version, 1. Add

Re: [PATCH v4] clocksource: arch_timer: Allow the device tree to specify uninitialized timer registers

2014-11-26 Thread Yingjoe Chen
Hi, On Wed, 2014-11-26 at 08:14 -0800, Doug Anderson wrote: > Yingjoe, > > On Wed, Nov 26, 2014 at 6:41 AM, Yingjoe Chen > wrote: > > Sorry for the (very) late reply. > > I just realize today MT8135 need this and the other patch [1] to boot > > SMP correc

Re: [PATCH v4] clocksource: arch_timer: Allow the device tree to specify uninitialized timer registers

2014-11-26 Thread Yingjoe Chen
On Wed, 2014-10-08 at 15:33 +0800, Sonny Rao wrote: > From: Doug Anderson > > Some 32-bit (ARMv7) systems are architected like this: > > * The firmware doesn't know and doesn't care about hypervisor mode and > we don't want to add the complexity of hypervisor there. > > * The firmware isn't

Re: [PATCH v4] clocksource: arch_timer: Allow the device tree to specify uninitialized timer registers

2014-11-26 Thread Yingjoe Chen
On Wed, 2014-10-08 at 15:33 +0800, Sonny Rao wrote: From: Doug Anderson diand...@chromium.org Some 32-bit (ARMv7) systems are architected like this: * The firmware doesn't know and doesn't care about hypervisor mode and we don't want to add the complexity of hypervisor there. * The

Re: [PATCH v4] clocksource: arch_timer: Allow the device tree to specify uninitialized timer registers

2014-11-26 Thread Yingjoe Chen
Hi, On Wed, 2014-11-26 at 08:14 -0800, Doug Anderson wrote: Yingjoe, On Wed, Nov 26, 2014 at 6:41 AM, Yingjoe Chen yingjoe.c...@mediatek.com wrote: Sorry for the (very) late reply. I just realize today MT8135 need this and the other patch [1] to boot SMP correctly. I've applied both

[PATCH v8 1/4] irqchip: gic: Support hierarchy irq domain.

2014-11-25 Thread Yingjoe Chen
Add support to use gic as a parent for stacked irq domain. Signed-off-by: Yingjoe Chen --- drivers/irqchip/Kconfig | 1 + drivers/irqchip/irq-gic.c | 77 --- 2 files changed, 54 insertions(+), 24 deletions(-) diff --git a/drivers/irqchip/Kconfig b

[PATCH v8 3/4] ARM: mediatek: Add sysirq in mt6589/mt8135/mt8127 dtsi

2014-11-25 Thread Yingjoe Chen
Add sysirq settings for mt6589/mt8135/mt8127 This also correct timer interrupt flag. The old setting works because boot loader already set polarity for timer interrupt. Without intpol support, the setting was not changed so gic can get the irq correctly. Signed-off-by: Yingjoe Chen --- arch/arm

[PATCH v8 2/4] ARM: mediatek: Add sysirq interrupt polarity support

2014-11-25 Thread Yingjoe Chen
Mediatek SoCs have interrupt polarity support in sysirq which allows to invert polarity for given interrupt. Add this support using hierarchy irq domain. Signed-off-by: Yingjoe Chen --- drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-mtk-sysirq.c | 163

[PATCH v8 4/4] dt-bindings: add bindings for mediatek sysirq

2014-11-25 Thread Yingjoe Chen
Add binding documentation for Mediatek SoC SYSIRQ. Signed-off-by: Yingjoe Chen --- .../bindings/arm/mediatek/mediatek,sysirq.txt | 28 ++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/mediatek/mediatek,sysirq.txt diff --git

[PATCH v8 0/4] ARM: mediatek: Add support for interrupt polarity

2014-11-25 Thread Yingjoe Chen
-October/298161.html [4] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/296911.html [5] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/293766.html Yingjoe Chen (4): irqchip: gic: Support hierarchy irq domain. ARM: mediatek: Add sysirq interrupt polarity

[PATCH v8 0/4] ARM: mediatek: Add support for interrupt polarity

2014-11-25 Thread Yingjoe Chen
/298161.html [4] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/296911.html [5] http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/293766.html Yingjoe Chen (4): irqchip: gic: Support hierarchy irq domain. ARM: mediatek: Add sysirq interrupt polarity support

[PATCH v8 4/4] dt-bindings: add bindings for mediatek sysirq

2014-11-25 Thread Yingjoe Chen
Add binding documentation for Mediatek SoC SYSIRQ. Signed-off-by: Yingjoe Chen yingjoe.c...@mediatek.com --- .../bindings/arm/mediatek/mediatek,sysirq.txt | 28 ++ 1 file changed, 28 insertions(+) create mode 100644 Documentation/devicetree/bindings/arm/mediatek

[PATCH v8 1/4] irqchip: gic: Support hierarchy irq domain.

2014-11-25 Thread Yingjoe Chen
Add support to use gic as a parent for stacked irq domain. Signed-off-by: Yingjoe Chen yingjoe.c...@mediatek.com --- drivers/irqchip/Kconfig | 1 + drivers/irqchip/irq-gic.c | 77 --- 2 files changed, 54 insertions(+), 24 deletions(-) diff --git

[PATCH v8 3/4] ARM: mediatek: Add sysirq in mt6589/mt8135/mt8127 dtsi

2014-11-25 Thread Yingjoe Chen
Add sysirq settings for mt6589/mt8135/mt8127 This also correct timer interrupt flag. The old setting works because boot loader already set polarity for timer interrupt. Without intpol support, the setting was not changed so gic can get the irq correctly. Signed-off-by: Yingjoe Chen yingjoe.c

[PATCH v8 2/4] ARM: mediatek: Add sysirq interrupt polarity support

2014-11-25 Thread Yingjoe Chen
Mediatek SoCs have interrupt polarity support in sysirq which allows to invert polarity for given interrupt. Add this support using hierarchy irq domain. Signed-off-by: Yingjoe Chen yingjoe.c...@mediatek.com --- drivers/irqchip/Makefile | 1 + drivers/irqchip/irq-mtk-sysirq.c | 163

[tip:irq/irqdomain] genirq: Add more helper functions to support stacked irq_chip

2014-11-24 Thread tip-bot for Yingjoe Chen
Commit-ID: 56e8abab615e0c5858cfb9fa0015a44641762b9d Gitweb: http://git.kernel.org/tip/56e8abab615e0c5858cfb9fa0015a44641762b9d Author: Yingjoe Chen AuthorDate: Thu, 13 Nov 2014 23:37:05 +0800 Committer: Thomas Gleixner CommitDate: Sun, 23 Nov 2014 13:01:46 +0100 genirq: Add more

Re: [PATCH v7 4/4] dt-bindings: add bindings for mediatek sysirq

2014-11-24 Thread Yingjoe Chen
Hi Mark, On Wed, 2014-11-19 at 18:07 +, Mark Rutland wrote: > On Wed, Nov 19, 2014 at 02:14:11PM +0000, Yingjoe Chen wrote: > > Add binding documentation for Mediatek SoC SYSIRQ. > > > > Signed-off-by: Yingjoe Chen > > --- > > .../bindings/arm/media

Re: [PATCH v7 4/4] dt-bindings: add bindings for mediatek sysirq

2014-11-24 Thread Yingjoe Chen
Hi Mark, On Wed, 2014-11-19 at 18:07 +, Mark Rutland wrote: On Wed, Nov 19, 2014 at 02:14:11PM +, Yingjoe Chen wrote: Add binding documentation for Mediatek SoC SYSIRQ. Signed-off-by: Yingjoe Chen yingjoe.c...@mediatek.com --- .../bindings/arm/mediatek/mediatek,sysirq.txt

<    1   2   3   4   5   6   7   >