[tip: perf/core] perf/x86/rapl: Add support for Intel Alder Lake

2021-04-20 Thread tip-bot2 for Zhang Rui
The following commit has been merged into the perf/core branch of tip: Commit-ID: 6a5f4386798d81f7f413e93c87e2b6de7439beea Gitweb: https://git.kernel.org/tip/6a5f4386798d81f7f413e93c87e2b6de7439beea Author:Zhang Rui AuthorDate:Mon, 12 Apr 2021 07:31:05 -07:00 Committer

Re: [PATCH] tools/power/x86/turbostat: Fix TCC offset bit mask

2021-04-11 Thread Zhang Rui
On Sat, 2021-03-13 at 07:16 -0800, Doug Smythies wrote: > On Fri, Mar 12, 2021 at 2:16 PM Len Brown wrote: > > > > Doug, > > The offset works for control. > > > > However, it is erroneous to use it for reporting of the actual > > temperature, like I did in turbostat. > > Agreed. > I have been

Re: [PATCH v2 04/15] ACPI: table: replace __attribute__((packed)) by __packed

2021-03-31 Thread Zhang Rui
On Tue, 2021-03-30 at 08:14 +, David Laight wrote: > From: Zhang Rui > > Sent: 30 March 2021 09:00 > > To: Xiaofei Tan ; David Laight < > > david.lai...@aculab.com>; r...@rjwysocki.net; > > l...@kernel.org; bhelg...@google.com > > Cc: linux-a...@vger.k

Re: [PATCH v2 04/15] ACPI: table: replace __attribute__((packed)) by __packed

2021-03-30 Thread Zhang Rui
On Tue, 2021-03-30 at 15:31 +0800, Zhang Rui wrote: > On Tue, 2021-03-30 at 10:23 +0800, Xiaofei Tan wrote: > > Hi David, > > > > On 2021/3/29 18:09, David Laight wrote: > > > From: Xiaofei Tan > > > > Sent: 27 March 2021 07:46 > > > >

Re: [PATCH v2 04/15] ACPI: table: replace __attribute__((packed)) by __packed

2021-03-30 Thread Zhang Rui
On Tue, 2021-03-30 at 10:23 +0800, Xiaofei Tan wrote: > Hi David, > > On 2021/3/29 18:09, David Laight wrote: > > From: Xiaofei Tan > > > Sent: 27 March 2021 07:46 > > > > > > Replace __attribute__((packed)) by __packed following the > > > advice of checkpatch.pl. > > > > > > Signed-off-by:

[tip: perf/core] perf/x86/rapl: Add msr mask support

2021-02-10 Thread tip-bot2 for Zhang Rui
The following commit has been merged into the perf/core branch of tip: Commit-ID: ffb20c2e52e8709b5fc9951e8863e31efb1f2cba Gitweb: https://git.kernel.org/tip/ffb20c2e52e8709b5fc9951e8863e31efb1f2cba Author:Zhang Rui AuthorDate:Fri, 05 Feb 2021 00:18:14 +08:00 Committer

[tip: perf/core] perf/x86/rapl: Only check lower 32bits for RAPL energy counters

2021-02-10 Thread tip-bot2 for Zhang Rui
The following commit has been merged into the perf/core branch of tip: Commit-ID: b6f78d3fba7f605f673185d7292d84af7576fdc1 Gitweb: https://git.kernel.org/tip/b6f78d3fba7f605f673185d7292d84af7576fdc1 Author:Zhang Rui AuthorDate:Fri, 05 Feb 2021 00:18:15 +08:00 Committer

[tip: perf/core] perf/x86/rapl: Fix psys-energy event on Intel SPR platform

2021-02-10 Thread tip-bot2 for Zhang Rui
The following commit has been merged into the perf/core branch of tip: Commit-ID: 838342a6d6b7ecc475dc052d4a405c4ffb3ad1b5 Gitweb: https://git.kernel.org/tip/838342a6d6b7ecc475dc052d4a405c4ffb3ad1b5 Author:Zhang Rui AuthorDate:Fri, 05 Feb 2021 00:18:16 +08:00 Committer

[PATCH V2 1/3] perf/x86/rapl: Add msr mask support

2021-02-04 Thread Zhang Rui
mask field in struct perf_msr to allow probing certain bits of a MSR. This change is transparent to the current perf_msr_probe() users. Signed-off-by: Zhang Rui Reviewed-by: Andi Kleen --- arch/x86/events/probe.c | 5 - arch/x86/events/probe.h | 7 --- 2 files changed, 8 insertions

[PATCH V2 2/3] perf/x86/rapl: Only check lower 32bits for RAPL energy counters

2021-02-04 Thread Zhang Rui
32bits only for these ENERGY_COUTNER MSRs, to make sure the RAPL PMU events are not added erroneously when higher 32bits contain non-zero value. Signed-off-by: Zhang Rui Reviewed-by: Andi Kleen --- arch/x86/events/rapl.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff

[PATCH V2 3/3] perf/x86/rapl: Fix psys-energy event on Intel SPR platform

2021-02-04 Thread Zhang Rui
MSR on Intel SPR is package scope, this is not a problem because there is only one die in each package on SPR. Signed-off-by: Zhang Rui Reviewed-by: Andi Kleen --- arch/x86/events/rapl.c | 21 + 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/arch/x86/events

Re: [PATCH 3/3] perf/x86/rapl: Fix psys-energy event on Intel SPR platform

2021-02-04 Thread Zhang Rui
Hi, Peter, On Wed, 2021-02-03 at 15:47 +0100, Peter Zijlstra wrote: > FWIW, your email is malformed, please wrap at 78 chars. > > On Mon, Jan 25, 2021 at 06:11:14AM +0000, Zhang, Rui wrote: > > In short, the current code does not allow RAPL energy counter to > > return 0.

RE: [PATCH 3/3] perf/x86/rapl: Fix psys-energy event on Intel SPR platform

2021-02-03 Thread Zhang, Rui
Hi, Peter, > -Original Message- > From: Zhang, Rui > Sent: Monday, January 25, 2021 2:11 PM > To: 'Peter Zijlstra' > Cc: 'mi...@redhat.com' ; 'a...@kernel.org' > ; 'mark.rutl...@arm.com' ; > 'alexander.shish...@linux.intel.com' ; > 'jo...@redhat.com' ; 'namhy..

Re: [PATCH -next] ACPI: tables: Mark acpi_init_fpdt with static keyword

2021-01-28 Thread Zhang Rui
Hi, Wei, Thanks for the patch. Given that there are a couple of things need to be fixed in the orignal patch, I'd prefer to refresh the patch with all the fixes included https://patchwork.kernel.org/project/linux-acpi/patch/20210129061548.13448-1-rui.zh...@intel.com/ what do you think?

Re: [PATCH -next] acpi: fpdt: drop errant comma in pr_info()

2021-01-28 Thread Zhang Rui
t; > Fixes: 208757d71098 ("ACPI: tables: introduce support for FPDT > table") > Signed-off-by: Randy Dunlap > Cc: "Rafael J. Wysocki" > Cc: Rafael J. Wysocki > Cc: Len Brown > Cc: linux-a...@vger.kernel.org > Cc: Zhang Rui > --- > drivers/acpi/

Re: [PATCH -next] acpi: fpdt: drop errant comma in pr_info()

2021-01-28 Thread Zhang Rui
On Thu, 2021-01-28 at 15:56 -0800, Joe Perches wrote: > On Thu, 2021-01-28 at 15:25 -0800, Randy Dunlap wrote: > > Drop a mistaken comma in the pr_info() args to prevent the > > build warning. > > > > ../drivers/acpi/acpi_fpdt.c: In function 'acpi_init_fpdt': > >

Re: [PATCH v2 2/2] thermal: Move therm_throt there from x86/mce

2021-01-27 Thread Zhang Rui
er > stub was the one used before therm_throt assigns a new one. > > Requested-by: Peter Zijlstra > Signed-off-by: Borislav Petkov Acked-by: Zhang Rui thanks, rui > --- > arch/x86/Kconfig | 4 --- > arch/x86/include/asm/irq.h

Re: linux-next: build warning after merge of the pm tree

2021-01-26 Thread Zhang Rui
oduce support for FPDT table"), which includes all these fixes? thanks, rui >From 2b8ed148351875b4bf227602a97edba12d08af7e Mon Sep 17 00:00:00 2001 From: Zhang Rui Date: Wed, 27 Jan 2021 11:33:33 +0800 Subject: [PATCH] ACPI: FPDT: fix build warning Fix a build warning, In file included f

Re: [PATCH v2 2/2] thermal: Move therm_throt there from x86/mce

2021-01-25 Thread Zhang Rui
Hi, Borislav, Thanks for the patch. CC Srinivas. On Mon, 2021-01-25 at 14:05 +0100, Borislav Petkov wrote: > From: Borislav Petkov > > This functionality has nothing to do with MCE, move it to the thermal > framework and untangle it from MCE. > Agreed. just one question, there are many

RE: [PATCH 3/3] perf/x86/rapl: Fix psys-energy event on Intel SPR platform

2021-01-24 Thread Zhang, Rui
Hi, Peter, > -Original Message- > From: Zhang, Rui > Sent: Sunday, January 17, 2021 10:34 PM > To: 'Peter Zijlstra' > Cc: mi...@redhat.com; a...@kernel.org; mark.rutl...@arm.com; > alexander.shish...@linux.intel.com; jo...@redhat.com; > namhy...@kernel.org; linux-k

RE: [PATCH 0/2] thermal: Replace thermal_notify_framework with thermal_zone_device_update

2021-01-19 Thread Zhang, Rui
the comments in the previous discussion, like doc cleanup? Thanks, rui > -Original Message- > From: Thara Gopinath > Sent: Tuesday, January 19, 2021 10:06 PM > To: Zhang, Rui ; daniel.lezc...@linaro.org; > kv...@codeaurora.org; da...@davemloft.net; k...@kernel.org; Coelho,

RE: [PATCH v2] thermal/core: Make cooling device state change private

2021-01-18 Thread Zhang, Rui
> -Original Message- > From: Daniel Lezcano > Sent: Tuesday, January 19, 2021 1:38 AM > To: daniel.lezc...@linaro.org; Zhang, Rui > Cc: Guenter Roeck ; Kamil Debski ; > Bartlomiej Zolnierkiewicz ; Jean Delvare > ; Neil Armstrong ; Amit > Kucheria ; open

RE: [PATCH 2/3] perf/x86/rapl: Fix energy counter detection

2021-01-17 Thread Zhang, Rui
> -Original Message- > From: Peter Zijlstra > Sent: Saturday, January 16, 2021 8:48 PM > To: Zhang, Rui > Cc: mi...@redhat.com; a...@kernel.org; mark.rutl...@arm.com; > alexander.shish...@linux.intel.com; jo...@redhat.com; > namhy...@kernel.org; linux-kern

RE: [PATCH 3/3] perf/x86/rapl: Fix psys-energy event on Intel SPR platform

2021-01-17 Thread Zhang, Rui
Hi, Peter, > -Original Message- > From: Peter Zijlstra > Sent: Saturday, January 16, 2021 8:50 PM > To: Zhang, Rui > Cc: mi...@redhat.com; a...@kernel.org; mark.rutl...@arm.com; > alexander.shish...@linux.intel.com; jo...@redhat.com; > namhy...@kernel.org; linux-k

RE: [PATCH 2/3] perf/x86/rapl: Fix energy counter detection

2021-01-16 Thread Zhang, Rui
> -Original Message- > From: Peter Zijlstra > Sent: Saturday, January 16, 2021 4:03 AM > To: Zhang, Rui > Cc: mi...@redhat.com; a...@kernel.org; mark.rutl...@arm.com; > alexander.shish...@linux.intel.com; jo...@redhat.com; > namhy...@kernel.org; linux-kern

[PATCH 3/3] perf/x86/rapl: Fix psys-energy event on Intel SPR platform

2021-01-15 Thread Zhang Rui
changes, we always probe the psys-energy event on Intel SPR platform. Difference is that the event counter returns 0 when the Psys RAPL Domain is disabled by BIOS, or the Psys master package is offlined. Signed-off-by: Zhang Rui Reviewed-by: Andi Kleen --- arch/x86/events/rapl.c | 21

[PATCH 1/3] perf/x86/rapl: Add msr mask support

2021-01-15 Thread Zhang Rui
mask field in struct perf_msr to allow probing certain bits of a MSR. This change is transparent to the current perf_msr_probe() users. Signed-off-by: Zhang Rui Reviewed-by: Andi Kleen --- arch/x86/events/probe.c | 5 - arch/x86/events/probe.h | 7 --- 2 files changed, 8 insertions

[PATCH 2/3] perf/x86/rapl: Fix energy counter detection

2021-01-15 Thread Zhang Rui
In the RAPL ENERGY_COUNTER MSR, only the lower 32bits represent the energy counter, and the higher 32bits are reserved. Add the MSR mask for these MSRs to fix a problem that the RAPL PMU events are added erroneously when higher 32bits contain non-zero value. Signed-off-by: Zhang Rui Reviewed

RE: [PATCH 4/6] acpi/drivers/thermal: Remove TRIPS_NONE cooling device binding

2021-01-06 Thread Zhang, Rui
platform with _TZP implemented, and it was almost 10 years ago. So, I think it is safe to remove this piece of code. > -Original Message- > From: Daniel Lezcano > Sent: Tuesday, January 05, 2021 11:44 PM > To: Zhang, Rui > Cc: mj...@codon.org.uk; linux...@vger.kernel.or

Re: [PATCH] x86/PCI: Convert force_disable_hpet() to standard quirk

2020-12-01 Thread Zhang Rui
counter as watchdog, like the patch below, which I didn't sent out for upstream. >From cf9ce0ecab8851a3745edcad92e072022af3dbd9 Mon Sep 17 00:00:00 2001 From: Zhang Rui Date: Fri, 19 Jun 2020 22:03:23 +0800 Subject: [RFC PATCH] time/clocksource: do not use refined-jiffies as watchdog On IA platf

Re: [PATCH] thermal: Fix NULL pointer dereference issue

2020-11-17 Thread Zhang Rui
On Tue, 2020-11-17 at 09:57 +0100, Daniel Lezcano wrote: > On 17/11/2020 08:18, Zhang Rui wrote: > > On Mon, 2020-11-16 at 21:59 +0530, Mukesh Ojha wrote: > > > Cooling stats variable inside > > > thermal_cooling_device_stats_update() > > > can get NULL. We sh

Re: [PATCH] thermal: Fix NULL pointer dereference issue

2020-11-16 Thread Zhang Rui
On Mon, 2020-11-16 at 21:59 +0530, Mukesh Ojha wrote: > Cooling stats variable inside thermal_cooling_device_stats_update() > can get NULL. We should add a NULL check on stat inside for sanity. > > Signed-off-by: Mukesh Ojha > --- > drivers/thermal/thermal_sysfs.c | 3 +++ > 1 file changed, 3

Re: [PATCH] thermal: Fix slab-out-of-bounds in thermal_cooling_device_stats_update()

2020-11-16 Thread Zhang Rui
On Tue, 2020-09-15 at 13:58 +0800, zhuguangqin...@gmail.com wrote: > From: zhuguangqing > > In function thermal_cooling_device_stats_update(), if the input > parameter > new_state is greater or equal to stats->max_states, then it will > cause > slab-out-of-bounds error when execute the code as

Re: [PATCH v3 3/4] powercap: Add AMD Fam17h RAPL support

2020-11-01 Thread Zhang Rui
On Tue, 2020-10-27 at 07:23 +, Victor Ding wrote: > This patch enables AMD Fam17h RAPL support for the power capping > framework. The support is as per AMD Fam17h Model31h (Zen2) and > model 00-ffh (Zen1) PPR. > > Tested by comparing the results of following two sysfs entries and > the >

Re: [PATCH v2 2/4] cpufreq: intel_pstate: Avoid missing HWP max updates in passive mode

2020-10-27 Thread Zhang Rui
e register is different from the new one including > the limits, so if neither the target P-state value nor the max limit > changes, the register write will still be avoided). > > Fixes: f6ebbcf08f37 ("cpufreq: intel_pstate: Implement passive mode > with HWP enabled") > Re

Re: [PATCH v2 4/4] cpufreq: schedutil: Always call drvier if need_freq_update is set

2020-10-27 Thread Zhang Rui
; potentially affected drivers) and make sugov_update_next_freq() > check need_freq_update and continue when it is set regardless of > whether or not the new target frequency is equal to the old one. > > Fixes: f6ebbcf08f37 ("cpufreq: intel_pstate: Implement passive mode > with H

Re: [PATCH v2 3/4] powercap: Add AMD Fam17h RAPL support

2020-10-08 Thread Zhang Rui
On Wed, 2020-10-07 at 11:14 -0500, Kim Phillips wrote: > From: Victor Ding > > This patch enables AMD Fam17h RAPL support for the power capping > framework. The support is as per AMD Fam17h Model31h (Zen2) and > model 00-ffh (Zen1) PPR. > > Tested by comparing the results of following two sysfs

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Zhang Rui
On Wed, 2020-08-26 at 19:00 +0200, Rafael J. Wysocki wrote: > On Wed, Aug 26, 2020 at 6:46 PM Guilhem Lettron > wrote: > > > > I've done more tests, maybe it can give you more hints. > > I don't see that much differences between both (with and without > > patches) in this cases. > > OK, thanks!

Re: [PATCH] intel_idle: Add ICL support

2020-08-26 Thread Zhang Rui
On Wed, 2020-08-26 at 15:32 +0200, Guilhem Lettron wrote: > On Wed, 26 Aug 2020 at 15:18, Artem Bityutskiy > wrote: > > > > On Wed, 2020-08-26 at 16:16 +0300, Artem Bityutskiy wrote: > > > Just get a reasonably new turbostat (it is part of the kernel > > > tree, you > > > can compile it

[tip: perf/urgent] perf/x86/rapl: Fix missing psys sysfs attributes

2020-08-14 Thread tip-bot2 for Zhang Rui
The following commit has been merged into the perf/urgent branch of tip: Commit-ID: 4bb5fcb97a5df0bbc0a27e0252b1e7ce140a8431 Gitweb: https://git.kernel.org/tip/4bb5fcb97a5df0bbc0a27e0252b1e7ce140a8431 Author:Zhang Rui AuthorDate:Tue, 11 Aug 2020 23:31:47 +08:00 Committer

[tip: perf/urgent] perf/x86/rapl: Support multiple RAPL unit quirks

2020-08-14 Thread tip-bot2 for Zhang Rui
The following commit has been merged into the perf/urgent branch of tip: Commit-ID: 74f41adab0f4a61857833e1b6fa8e9ad12c251b6 Gitweb: https://git.kernel.org/tip/74f41adab0f4a61857833e1b6fa8e9ad12c251b6 Author:Zhang Rui AuthorDate:Tue, 11 Aug 2020 23:31:48 +08:00 Committer

[tip: perf/urgent] perf/x86/rapl: Add support for Intel SPR platform

2020-08-14 Thread tip-bot2 for Zhang Rui
The following commit has been merged into the perf/urgent branch of tip: Commit-ID: bcfd218b66790243ef303c1b35ce59f786ded225 Gitweb: https://git.kernel.org/tip/bcfd218b66790243ef303c1b35ce59f786ded225 Author:Zhang Rui AuthorDate:Tue, 11 Aug 2020 23:31:49 +08:00 Committer

Re: [PATCH v2 2/3] perf/x86/rapl: Support multiple rapl unit quirks

2020-08-11 Thread Zhang Rui
Hi, Thanks for reviewing. On Tue, 2020-08-11 at 11:19 -0700, Joe Perches wrote: > On Tue, 2020-08-11 at 23:31 +0800, Zhang Rui wrote: > > There will be more platforms with different fixed energy units. > > Enhance the code to support different rapl unit quirks for > > di

[PATCH v2 0/3] perf/x86/rapl: Add Intel SapphireRapids support

2020-08-11 Thread Zhang Rui
Hi, all, This patch set adds rapl perf event support for Intel SapphireRapids platform. Patch 1/3 fixes a regression that Psys RAPL Domain sysfs I/F is missing. Patch 2/3 introduces support for different energy unit quirks. Patch 3/3 introduces support for Intel SapphireRapids platform, which

[PATCH v2 3/3] perf/x86/rapl: Add support for Intel SPR platform

2020-08-11 Thread Zhang Rui
Intel SPR platform uses fixed 16 bit energy unit for DRAM RAPL domain, and fixed 0 bit energy unit for Psys RAPL domain. After this, on SPR platform the energy counters appear in perf list. Signed-off-by: Zhang Rui Reviewed-by: Kan Liang Acked-by: Len Brown --- arch/x86/events/rapl.c | 20

[PATCH v2 2/3] perf/x86/rapl: Support multiple rapl unit quirks

2020-08-11 Thread Zhang Rui
There will be more platforms with different fixed energy units. Enhance the code to support different rapl unit quirks for different platforms. Signed-off-by: Zhang Rui Reviewed-by: Kan Liang Reviewed-by: Len Brown --- arch/x86/events/rapl.c | 24 +++- 1 file changed, 15

[PATCH v2 1/3] perf/x86/rapl: Fix missing psys sysfs attributes

2020-08-11 Thread Zhang Rui
This fixes a problem introduced by commit 5fb5273a905c ("perf/x86/rapl: Use new MSR detection interface") that perf event sysfs attributes for psys RAPL domain are missing. Fixes: 5fb5273a905c ("perf/x86/rapl: Use new MSR detection interface") Signed-off-by: Zhang Rui Re

Re: [GIT PULL] thermal for v5.9-rc1

2020-08-04 Thread Zhang Rui
Hi, Linus, On Mon, 2020-08-03 at 20:26 -0700, Linus Torvalds wrote: > On Mon, Aug 3, 2020 at 2:44 PM Daniel Lezcano < > daniel.lezc...@linaro.org> wrote: > > > > ssh://g...@gitolite.kernel.org/pub/scm/linux/kernel/git/thermal/linux.git > > tags/thermal-v5.9-rc1 > > This was all rebased just an

Re: [PATCH 1/3] perf/x86/rapl: Fix missing psys sysfs attributes

2020-07-28 Thread Zhang Rui
On Fri, 2020-07-17 at 10:33 +0200, Jiri Olsa wrote: > On Thu, Jul 16, 2020 at 11:18:57PM +0800, Zhang Rui wrote: > > This fixes a problem introduced by > > commit 5fb5273a905c ("perf/x86/rapl: Use new MSR detection > > interface") > > that perf event

Re: [PATCH] thermal: core: Add thermal zone enable/disable notification

2020-07-28 Thread Zhang Rui
On Tue, 2020-07-28 at 01:10 +0200, Daniel Lezcano wrote: > Now the calls to enable/disable a thermal zone are centralized in a > call to a function, we can add in these the corresponding netlink > notifications. > > Signed-off-by: Daniel Lezcano Acked-by: Zhang Rui > ---

[PATCH 3/3] perf/x86/rapl: Add support for Intel SPR platform

2020-07-16 Thread Zhang Rui
Intel SPR platform uses fixed 16 bit energy unit for DRAM RAPL domain, and fixed 0 bit energy unit for Psys RAPL domain. After this, on SPR platform the energy counters appear in perf list. Signed-off-by: Zhang Rui Reviewed-by: Kan Liang Acked-by: Len Brown --- arch/x86/events/rapl.c | 20

[PATCH 1/3] perf/x86/rapl: Fix missing psys sysfs attributes

2020-07-16 Thread Zhang Rui
This fixes a problem introduced by commit 5fb5273a905c ("perf/x86/rapl: Use new MSR detection interface") that perf event sysfs attributes for psys RAPL domain are missing. Fixes: 5fb5273a905c ("perf/x86/rapl: Use new MSR detection interface") Signed-off-by: Zhang Rui Re

[PATCH 2/3] perf/x86/rapl: Support multiple rapl unit quirks

2020-07-16 Thread Zhang Rui
There will be more platforms with different fixed energy units. Enhance the code to support different rapl unit quirks for different platforms. Signed-off-by: Zhang Rui Reviewed-by: Kan Liang Reviewed-by: Len Brown --- arch/x86/events/rapl.c | 24 +++- 1 file changed, 15

Re: [RFC PATCH 3/4] thermal:core:Add genetlink notifications for monitoring falling temperature

2020-07-15 Thread Zhang Rui
On Fri, 2020-07-10 at 09:51 -0400, Thara Gopinath wrote: > Add notification calls for trip type THERMAL_TRIP_COLD when > temperature > crosses the trip point in either direction. > > Signed-off-by: Thara Gopinath > --- > drivers/thermal/thermal_core.c | 21 +++-- > 1 file

Re: [RFC PATCH 4/4] thermal: Modify thermal governors to do nothing for "cold" trip points

2020-07-15 Thread Zhang Rui
On Fri, 2020-07-10 at 09:51 -0400, Thara Gopinath wrote: > For now, thermal governors do not support monitoring of falling > temperature. Hence, in case of calls to the governor for trip points > marked > as cold, return doing nothing. > > Signed-off-by: Thara Gopinath > --- >

Re: [RFC PATCH 0/4] thermal: Introduce support for monitoring falling temperature

2020-07-15 Thread Zhang Rui
Hi, Thara, On Tue, 2020-07-14 at 17:39 -0400, Thara Gopinath wrote: > > > > > For example, to support this, we can > > either > > introduce both "cold" trip points and "warming devices", and > > introduce > > new logic in thermal framework and governors to handle them, > > Or > > introduce

Re: [RFC PATCH 0/4] thermal: Introduce support for monitoring falling temperature

2020-07-14 Thread Zhang Rui
On Mon, 2020-07-13 at 17:03 +0200, Daniel Lezcano wrote: > On 10/07/2020 15:51, Thara Gopinath wrote: > > Thermal framework today supports monitoring for rising temperatures > > and > > subsequently initiating cooling action in case of a thermal trip > > point > > being crossed. There are

Re: [PATCH v4 3/4] thermal: core: genetlink support for events/cmd/sampling

2020-07-06 Thread Zhang Rui
nly without the > thermal zone temperature sampling. > > Also, a list of commands to discover the thermal setup is added and > can be extended when needed. > > Reviewed-by: Amit Kucheria > Signed-off-by: Daniel Lezcano Acked-by: Zhang Rui > --- > v4: > - Removed

Re: [PATCH v4 4/4] thermal: core: Add notifications call in the framework

2020-07-06 Thread Zhang Rui
gt; Reviewed-by: Amit Kucheria > Signed-off-by: Daniel Lezcano Acked-by: Zhang Rui > --- > v4: > - Fixed missing static declaration, reported by kbuild-bot > - Removed max state notification > --- > drivers/thermal/thermal_core.c| 21 +

Re: [PATCH v4 2/4] thermal: core: Get thermal zone by id

2020-07-06 Thread Zhang Rui
the message. Passing an integer is more efficient > than passing an entire string. > > This change provides a function returning back a thermal zone pointer > corresponding to the identifier passed as parameter. > > Signed-off-by: Daniel Lezcano > Reviewed-by: Am

Re: [PATCH v3 3/4] thermal: core: genetlink support for events/cmd/sampling

2020-07-05 Thread Zhang Rui
On Fri, 2020-07-03 at 10:53 +0200, Daniel Lezcano wrote: > Initially the thermal framework had a very simple notification > mechanism to send generic netlink messages to the userspace. > > The notification function was never called from anywhere and the > corresponding dead code was removed. It

Re: [PATCH v2 1/5] thermal: core: Add helpers to browse the cdev, tz and governor list

2020-07-02 Thread Zhang Rui
On Wed, 2020-07-01 at 11:50 +0200, Daniel Lezcano wrote: > On 01/07/2020 09:57, Zhang Rui wrote: > > [ ... ] > > > > Do you want to move them out? > > > > Then no. I don't have any objection of removing thermal_helper.c, > > so > > you can just leave

Re: [PATCH v2 1/5] thermal: core: Add helpers to browse the cdev, tz and governor list

2020-07-01 Thread Zhang Rui
On Wed, 2020-07-01 at 09:35 +0200, Daniel Lezcano wrote: > On 30/06/2020 17:09, Zhang Rui wrote: > > Hi, Daniel, > > > > seems that you forgot to cc linux-pm mailing list. > > > > On Tue, 2020-06-30 at 17:16 +0530, Amit Kucheria wrote: > > > On T

Re: [PATCH v2 4/5] thermal: core: genetlink support for events/cmd/sampling

2020-07-01 Thread Zhang Rui
Hi, Daniel, On Tue, 2020-06-30 at 20:32 +0200, Daniel Lezcano wrote: > Hi Zhang, > > thanks for taking the time to review > > > On 30/06/2020 18:12, Zhang Rui wrote: > > [ ... ] > > > > +int thermal_notify_tz_enable(int tz_id); > >

Re: [PATCH v2 4/5] thermal: core: genetlink support for events/cmd/sampling

2020-06-30 Thread Zhang Rui
On Thu, 2020-06-25 at 16:45 +0200, Daniel Lezcano wrote: > Initially the thermal framework had a very simple notification > mechanism to send generic netlink messages to the userspace. > > The notification function was never called from anywhere and the > corresponding dead code was removed. It

Re: [PATCH v2 2/5] thermal: core: Get thermal zone by id

2020-06-30 Thread Zhang Rui
On Thu, 2020-06-25 at 16:45 +0200, Daniel Lezcano wrote: > The next patch will introduce the generic netlink protocol to handle > events, sampling and command from the thermal framework. In order to > deal with the thermal zone, it uses its unique identifier to > characterize it in the message.

Re: [PATCH v2 1/5] thermal: core: Add helpers to browse the cdev, tz and governor list

2020-06-30 Thread Zhang Rui
Hi, Daniel, seems that you forgot to cc linux-pm mailing list. On Tue, 2020-06-30 at 17:16 +0530, Amit Kucheria wrote: > On Thu, Jun 25, 2020 at 8:15 PM Daniel Lezcano > wrote: > > > > The cdev, tz and governor list, as well as their respective locks > > are > > statically defined in the

Re: [PATCH V2 1/3] thermal/int340x_thermal: Export GDDV

2020-05-29 Thread Zhang Rui
On Fri, 2020-05-29 at 00:00 -0600, Pandruvada, Srinivas wrote: > On Mon, 2020-05-18 at 23:18 +, Pandruvada, Srinivas wrote: > > On Mon, 2020-04-13 at 19:09 -0700, Matthew Garrett wrote: > > > From: Matthew Garrett > > > > > > Implementing DPTF properly requires making use of firmware- > > >

Re: [GIT PULL] Thermal management updates for v5.4-rc1

2019-09-28 Thread Zhang Rui
. Sorry to bring this trouble. thanks, rui On Fri, 2019-09-27 at 11:34 -0700, Linus Torvalds wrote: > On Fri, Sep 27, 2019 at 6:08 AM Zhang Rui > wrote: > > > > One thing to mention is that, all the patches have been tested in > > linux-next for weeks, but there is a co

[GIT PULL] Thermal management updates for v5.4-rc1

2019-09-27 Thread Zhang Rui
Yue Hu (1): thermal/drivers/core: Use put_device() if device_register() fails Zhang Rui (2): Merge branches 'thermal-soc-misc' and 'thermal-soc-qoriq' into thermal-soc Merge branches 'thermal-core', 'thermal-intel' and 'thermal-soc' into for-5.4 .../devicetree/bindings/the

Re: [PATCH] thermal: qoriq: add thermal monitor unit version 2 support

2019-09-23 Thread Zhang Rui
On Mon, 2019-09-23 at 09:24 +, Andy Tang wrote: > Hi Rui, Edubezval, > > Would you please review this patch? > CC Anson Huang. I'd prefer all the qoriq thermal patches go through his review first. thanks, rui > BR, > Andy > > > -Original Message- > > From: Andy Tang > > Sent:

Re: [PATCH 1/5] thermal: Initialize thermal subsystem earlier

2019-09-19 Thread Zhang Rui
On Tue, 2019-09-17 at 14:48 +0530, Amit Kucheria wrote: > On Tue, Sep 17, 2019 at 1:30 AM Daniel Lezcano > wrote: > > > > On 12/09/2019 00:32, Amit Kucheria wrote: > > > From: Lina Iyer > > > > > > Now that the thermal framework is built-in, in order to > > > facilitate > > > thermal

Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-28 Thread Zhang Rui
On Thu, 2019-08-29 at 02:49 +, Anson Huang wrote: > Hi, Rui > > > > On Wed, 2019-08-28 at 08:51 +, Anson Huang wrote: > > > > Hi, Rui > > > > > > > > > On Tue, 2019-08-27 at 12:41 +, Leonard Crestez wrote: > > > > > > On 27.08.2019 04:51, Anson Huang wrote: > > > > > > > > In an

Re: [PATCH] thermal: armada: Fix -Wshift-negative-value

2019-08-28 Thread Zhang Rui
On Wed, 2019-08-28 at 11:49 -0700, Nick Desaulniers wrote: > On Wed, Aug 28, 2019 at 1:53 AM Zhang Rui > wrote: > > > > On Mon, 2019-08-19 at 10:21 +0200, Miquel Raynal wrote: > > > Hello, > > > > > > Daniel Lezcano wrote on Thu, 15 Aug > > &

Re: [PATCH] drivers: thermal: qcom: tsens: Fix memory leak from qfprom read

2019-08-28 Thread Zhang Rui
On Fri, 2019-08-23 at 17:29 +0530, Amit Kucheria wrote: > On Fri, Aug 23, 2019 at 3:08 PM Srinivas Kandagatla > wrote: > > > > memory returned as part of nvmem_read via qfprom_read should be > > freed by the consumer once done. > > Existing code is not doing it so fix it. > > > > Below memory

Re: [PATCH v7 4/4] thermal: cpu_cooling: Migrate to using the EM framework

2019-08-28 Thread Zhang Rui
On Mon, 2019-08-12 at 09:42 +0100, Quentin Perret wrote: > The newly introduced Energy Model framework manages power cost tables > in > a generic way. Moreover, it supports several types of models since > the > tables can come from DT or firmware (through SCMI) for example. On > the > other hand,

Re: [PATCH v5 09/18] thermal: sun8i: rework for ths calibrate func

2019-08-28 Thread Zhang Rui
On Sat, 2019-08-10 at 05:28 +, Yangtao Li wrote: > Here, we do something to prepare for the subsequent > support of multiple platforms. > > 1) rename sun50i_ths_calibrate to sun8i_ths_calibrate, because >this function should be suitable for all platforms now. > > 2) introduce calibrate

Re: [PATCH v5 03/18] thermal: fix indentation in makefile

2019-08-28 Thread Zhang Rui
On Sat, 2019-08-10 at 05:28 +, Yangtao Li wrote: > To unify code style. > > Signed-off-by: Yangtao Li the later patches in this series does not change Makefile. So this seems to be a cleanup patch independent of this patch set. It's better to remove this patch from this patch series.

Re: [PATCH] thermal: rcar_gen3_thermal: Use devm_add_action_or_reset() helper

2019-08-28 Thread Zhang Rui
On Wed, 2019-07-31 at 20:44 +0200, Niklas Söderlund wrote: > Hi Geert, > > Thanks for your work. > > On 2019-07-31 14:50:53 +0200, Geert Uytterhoeven wrote: > > Use the devm_add_action_or_reset() helper instead of open-coding > > the > > same operations. > > > > Signed-off-by: Geert

Re: [PATCH] thermal: mediatek: add suspend/resume callback

2019-08-28 Thread Zhang Rui
On Tue, 2019-07-02 at 17:16 +0800, michael@mediatek.com wrote: > From: Louis Yu > > Add suspend/resume callback to disable/enable Mediatek thermal sensor > respectively. Since thermal power domain is off in suspend, thermal > driver > needs re-initialization during resume. > >

Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-28 Thread Zhang Rui
On Wed, 2019-08-28 at 08:51 +, Anson Huang wrote: > Hi, Rui > > > On Tue, 2019-08-27 at 12:41 +, Leonard Crestez wrote: > > > On 27.08.2019 04:51, Anson Huang wrote: > > > > > In an earlier series the CLK_IS_CRITICAL flags was removed > > > > > from > > > > > the TMU clock so if the

Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-28 Thread Zhang Rui
On Wed, 2019-08-28 at 08:49 +, Anson Huang wrote: > Hi, Rui > > > On Wed, 2019-08-28 at 16:32 +0800, Zhang Rui wrote: > > > On Tue, 2019-08-27 at 12:41 +, Leonard Crestez wrote: > > > > On 27.08.2019 04:51, Anson Huang wrote: > > > > >

Re: [PATCH] thermal: armada: Fix -Wshift-negative-value

2019-08-28 Thread Zhang Rui
On Mon, 2019-08-19 at 10:21 +0200, Miquel Raynal wrote: > Hello, > > Daniel Lezcano wrote on Thu, 15 Aug 2019 > 01:06:21 +0200: > > > On 15/08/2019 00:12, Nick Desaulniers wrote: > > > On Tue, Aug 13, 2019 at 10:28 AM 'Nathan Huckleberry' via Clang > > > Built > > > Linux wrote: > > > > > >

Re: [PATCH] thermal: rcar_gen3_thermal: Fix Wshift-negative-value

2019-08-28 Thread Zhang Rui
On Fri, 2019-06-14 at 12:52 +0200, Daniel Lezcano wrote: > Hi Nathan, > > On 13/06/2019 23:12, Nathan Huckleberry wrote: > > Clang produces the following warning > > > > vers/thermal/rcar_gen3_thermal.c:147:33: warning: shifting a > > negative > > signed value is undefined

Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-28 Thread Zhang Rui
On Wed, 2019-08-28 at 16:32 +0800, Zhang Rui wrote: > On Tue, 2019-08-27 at 12:41 +, Leonard Crestez wrote: > > On 27.08.2019 04:51, Anson Huang wrote: > > > > In an earlier series the CLK_IS_CRITICAL flags was removed from > > > > the TMU > > >

Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-28 Thread Zhang Rui
On Tue, 2019-08-27 at 12:41 +, Leonard Crestez wrote: > On 27.08.2019 04:51, Anson Huang wrote: > > > In an earlier series the CLK_IS_CRITICAL flags was removed from > > > the TMU > > > clock so if the thermal driver doesn't explicitly enable it the > > > system will hang > > > on probe. This

Re: [PATCH V3 1/5] thermal: qoriq: Add clock operations

2019-08-26 Thread Zhang Rui
On Tue, 2019-08-27 at 01:51 +, Anson Huang wrote: > > On 7/30/2019 5:31 AM, anson.hu...@nxp.com wrote: > > > From: Anson Huang > > > > > > Some platforms like i.MX8MQ has clock control for this module, > > > need to > > > add clock operations to make sure the driver is working properly. > >

Re: [PATCH][V2] drivers: thermal: processor_thermal_device: fix missing bitwise-or operators

2019-08-19 Thread Zhang Rui
On Mon, 2019-07-29 at 14:09 -0700, Srinivas Pandruvada wrote: > On Mon, 2019-07-29 at 13:03 +0100, Colin King wrote: > > From: Colin Ian King > > > > The variable val is having the top 8 bits cleared and then the > > variable is being > > re-assinged and setting just the top 8 bits. I believe

Re: [PATCH] int340X/processor_thermal_device: Fix proc_thermal_rapl_remove()

2019-07-23 Thread Zhang Rui
r_thermal_device: add support > > for MMIO RAPL") > > Signed-off-by: Rafael J. Wysocki Acked-by: Zhang Rui > Any comments? > > If not, I'll queue this up along with the other RAPL-related fix > (https://patchwork.kernel.org/patch/11050999/). > > > > > --

[GIT PULL] Thermal management updates for v5.3-rc1

2019-07-17 Thread Zhang Rui
processor_thermal_device driver to re-evaluate power limits after resume. (Srinivas Pandruvada, Zhang Rui) thanks, rui Daniel Lezcano (2):   thermal/drivers/core: Add init section table for self- encapsulation   thermal/drivers/core

Re: [PATCH] drivers: thermal: processor_thermal: mark pm function __maybe_unused

2019-07-10 Thread Zhang Rui
st like the patch below, what do you think? thanks, rui >From 6c395f66e98c895cf3ebf87c0b2fc63b6a57a196 Mon Sep 17 00:00:00 2001 From: Zhang Rui Date: Tue, 9 Jul 2019 21:19:12 +0800 Subject: [PATCH] drivers: thermal: processor_thermal_device: Fix build warning As a system sleep callback, pr

Re: [PATCH 1/2] thermal/drivers/core: Add init section table for self-encapsulation

2019-06-27 Thread Zhang Rui
On 一, 2019-06-24 at 09:32 +0200, Daniel Lezcano wrote: > Any chance this patch gets merged for v5.4? > > Thanks >   -- Daniel > have you run compile test for the patch? I got the following errors when compiling. In file included from drivers/thermal/fair_share.c:16:0:

[PATCH] perf/rapl: restart perf rapl counter after resume

2019-06-17 Thread Zhang Rui
>From b74a74f953f4c34818a58831b6eb468b42b17c62 Mon Sep 17 00:00:00 2001 From: Zhang Rui Date: Tue, 23 Apr 2019 16:26:50 +0800 Subject: [PATCH] perf/rapl: restart perf rapl counter after resume After S3 suspend/resume, "perf stat -I 1000 -e power/energy-pkg/ -a" reports an

Re: [RFC PATCH] ACPI / processors: allow a processor device _UID to be a string

2019-06-11 Thread Zhang Rui
On 二, 2019-06-11 at 17:11 +0100, Sudeep Holla wrote: > On Tue, Jun 11, 2019 at 10:03:15AM -0600, Al Stone wrote: > > > > On 6/11/19 6:53 AM, Sudeep Holla wrote: > > > > > > On Mon, Jun 10, 2019 at 02:07:34PM -0600, Al Stone wrote: > > > > > > > > In the ACPI specification, section 6.1.12, a

Re: 5.2-rc2: low framerate in flightgear, cpu not running at full speed, thermal related?

2019-06-09 Thread Zhang Rui
On 日, 2019-06-09 at 14:12 +0200, Pavel Machek wrote: > Hi! > > > > > > > > > When I start flightgear, I get framerates around 20 fps and cpu > > > at > > > 3GHz: > > > > > > pavel@duo:~/bt$ cat /proc/cpuinfo  | grep MHz > > > cpu MHz : 3027.471 > > > cpu MHz   :

RE: mainline/master boot bisection: v5.2-rc1-165-g54dee406374c on rk3288-veyron-jaq

2019-05-23 Thread Zhang, Rui
labora.com; matthew.h...@linaro.org; khil...@baylibre.com; > Daniel Lezcano ; Heiko Stuebner > ; linux...@vger.kernel.org; linux- > ker...@vger.kernel.org; linux-rockc...@lists.infradead.org; Zhang, Rui > ; linux-arm-ker...@lists.infradead.org > Subject: Re: mainline/master boot b

[tip:x86/topology] hwmon/coretemp: Support multi-die/package

2019-05-23 Thread tip-bot for Zhang Rui
Commit-ID: cfcd82e632882372db960b50782a439a8ba56c09 Gitweb: https://git.kernel.org/tip/cfcd82e632882372db960b50782a439a8ba56c09 Author: Zhang Rui AuthorDate: Mon, 13 May 2019 13:58:54 -0400 Committer: Thomas Gleixner CommitDate: Thu, 23 May 2019 10:08:33 +0200 hwmon/coretemp: Support

[tip:x86/topology] powercap/intel_rapl: Update RAPL domain name and debug messages

2019-05-23 Thread tip-bot for Zhang Rui
Commit-ID: 9ea7612c46586d9eacfd517e73ff76ef294feca0 Gitweb: https://git.kernel.org/tip/9ea7612c46586d9eacfd517e73ff76ef294feca0 Author: Zhang Rui AuthorDate: Mon, 13 May 2019 13:58:53 -0400 Committer: Thomas Gleixner CommitDate: Thu, 23 May 2019 10:08:33 +0200 powercap/intel_rapl

[tip:x86/topology] thermal/x86_pkg_temp_thermal: Support multi-die/package

2019-05-23 Thread tip-bot for Zhang Rui
Commit-ID: 724adec33c2491f26f739f285ddca25fca226e48 Gitweb: https://git.kernel.org/tip/724adec33c2491f26f739f285ddca25fca226e48 Author: Zhang Rui AuthorDate: Mon, 13 May 2019 13:58:52 -0400 Committer: Thomas Gleixner CommitDate: Thu, 23 May 2019 10:08:33 +0200 thermal

[tip:x86/topology] powercap/intel_rapl: Support multi-die/package

2019-05-23 Thread tip-bot for Zhang Rui
Commit-ID: 32fb480e0a2cf1f71e4174d6477198c94dbc746c Gitweb: https://git.kernel.org/tip/32fb480e0a2cf1f71e4174d6477198c94dbc746c Author: Zhang Rui AuthorDate: Mon, 13 May 2019 13:58:51 -0400 Committer: Thomas Gleixner CommitDate: Thu, 23 May 2019 10:08:32 +0200 powercap/intel_rapl

  1   2   3   4   5   6   7   8   9   10   >