[PATCH 1/1] wlcore: Fix memory leak in case wl12xx_fetch_firmware failure

2018-12-18 Thread Zumeng Chen
<7e1d425a>] process_one_work+0x284/0x42c [<55f9432e>] worker_thread+0x2fc/0x48c [] kthread+0x148/0x160 [<63144b13>] ret_from_fork+0x14/0x2c [< (null)>] (null) [<1f6e7715>] 0x Signed-off-by: Zumeng Chen --- drivers/net/wireless/ti/wlcore/main.c |

[PATCH 1/1 v2] Bluetooth: make the balance of judgement condition to fix a false report

2018-11-14 Thread Zumeng Chen
); And hci_get_cmd_complete will bt_dev_err out when HCI_EV_CMD_STATUS, so a lot of asymmetric conditions are triggered. Since both of them are the entry into hci_get_cmd_complete, we'd better get STATUS into judge the false out there. Signed-off-by: Zumeng Chen --- v2: remove redundant braces and adjust

[PATCH 1/1 v2] Bluetooth: make the balance of judgement condition to fix a false report

2018-11-14 Thread Zumeng Chen
); And hci_get_cmd_complete will bt_dev_err out when HCI_EV_CMD_STATUS, so a lot of asymmetric conditions are triggered. Since both of them are the entry into hci_get_cmd_complete, we'd better get STATUS into judge the false out there. Signed-off-by: Zumeng Chen --- v2: remove redundant braces and adjust

[PATCH 1/1] Bluetooth: make the balance of judgement condition to fix a false report

2018-11-07 Thread Zumeng Chen
); And hci_get_cmd_complete will bt_dev_err out when HCI_EV_CMD_STATUS, so a lot of asymmetric conditions are triggered. Since both of them are the entry into hci_get_cmd_complete, we'd better get STATUS into judge the false out there. Signed-off-by: Zumeng Chen --- Hi expert, This issue existed whether

[PATCH 1/1] Bluetooth: make the balance of judgement condition to fix a false report

2018-11-07 Thread Zumeng Chen
); And hci_get_cmd_complete will bt_dev_err out when HCI_EV_CMD_STATUS, so a lot of asymmetric conditions are triggered. Since both of them are the entry into hci_get_cmd_complete, we'd better get STATUS into judge the false out there. Signed-off-by: Zumeng Chen --- Hi expert, This issue existed whether

[PATCH] mfd: ti_am335x_tscadc: Fix struct clk memory leak

2018-07-03 Thread Zumeng Chen
r_register+0xb0/0xf0 [] __platform_driver_register+0x40/0x54 Signed-off-by: Zumeng Chen --- drivers/mfd/ti_am335x_tscadc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c index 47012c0..7a30546 100644 ---

[PATCH] mfd: ti_am335x_tscadc: Fix struct clk memory leak

2018-07-03 Thread Zumeng Chen
r_register+0xb0/0xf0 [] __platform_driver_register+0x40/0x54 Signed-off-by: Zumeng Chen --- drivers/mfd/ti_am335x_tscadc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/mfd/ti_am335x_tscadc.c b/drivers/mfd/ti_am335x_tscadc.c index 47012c0..7a30546 100644 ---

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-05-04 Thread Zumeng Chen
On 05/03/2018 01:04 PM, Michael Chan wrote: On Wed, May 2, 2018 at 5:30 PM, Zumeng Chen <zumeng.c...@gmail.com> wrote: On 2018年05月03日 01:32, Michael Chan wrote: On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen <zumeng.c...@gmail.com> wrote: On 2018年05月02日 13:12, Michael Chan wrote: O

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-05-04 Thread Zumeng Chen
On 05/03/2018 01:04 PM, Michael Chan wrote: On Wed, May 2, 2018 at 5:30 PM, Zumeng Chen wrote: On 2018年05月03日 01:32, Michael Chan wrote: On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen wrote: On 2018年05月02日 13:12, Michael Chan wrote: On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen wrote: diff

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-05-02 Thread Zumeng Chen
On 2018年05月03日 01:32, Michael Chan wrote: On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen <zumeng.c...@gmail.com> wrote: On 2018年05月02日 13:12, Michael Chan wrote: On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen <zumeng.c...@gmail.com> wrote: diff --git a/drivers/net/ethernet/broadcom/tg3

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-05-02 Thread Zumeng Chen
On 2018年05月03日 01:32, Michael Chan wrote: On Wed, May 2, 2018 at 3:27 AM, Zumeng Chen wrote: On 2018年05月02日 13:12, Michael Chan wrote: On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen wrote: diff --git a/drivers/net/ethernet/broadcom/tg3.h b/drivers/net/ethernet/broadcom/tg3.h index 3b5e98e

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-05-02 Thread Zumeng Chen
On 2018年05月02日 13:12, Michael Chan wrote: On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen <zumeng.c...@gmail.com> wrote: diff --git a/drivers/net/ethernet/broadcom/tg3.h b/drivers/net/ethernet/broadcom/tg3.h index 3b5e98e..c61d83c 100644 --- a/drivers/net/ethernet/broadcom/tg3.h +++ b/drive

Re: [v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-05-02 Thread Zumeng Chen
On 2018年05月02日 13:12, Michael Chan wrote: On Tue, May 1, 2018 at 5:42 PM, Zumeng Chen wrote: diff --git a/drivers/net/ethernet/broadcom/tg3.h b/drivers/net/ethernet/broadcom/tg3.h index 3b5e98e..c61d83c 100644 --- a/drivers/net/ethernet/broadcom/tg3.h +++ b/drivers/net/ethernet/broadcom/tg3

[v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-05-01 Thread Zumeng Chen
From: Zumeng Chen <zumeng.c...@windriver.com> Reading hw_stats will get the actual data after a sucessfull tg3_reset_hw, which actually after tg3_timer_start, so TG3_FLAG_HALT is introduced to tell tg3_get_stats64 when hw_stats is ready to read. It will be set after having done mem

[v2 PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-05-01 Thread Zumeng Chen
From: Zumeng Chen Reading hw_stats will get the actual data after a sucessfull tg3_reset_hw, which actually after tg3_timer_start, so TG3_FLAG_HALT is introduced to tell tg3_get_stats64 when hw_stats is ready to read. It will be set after having done memset(tp->hw_stats, 0) in tg3_h

Re: [PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-04-29 Thread Zumeng Chen
On 2018年04月29日 02:36, Michael Chan wrote: On Fri, Apr 27, 2018 at 8:15 PM, Zumeng Chen <zumeng.c...@gmail.com> wrote: diff --git a/drivers/net/ethernet/broadcom/tg3.h b/drivers/net/ethernet/broadcom/tg3.h index 3b5e98e..6727d93 100644 --- a/drivers/net/ethernet/broadcom/tg3.h +++ b/d

Re: [PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-04-29 Thread Zumeng Chen
On 2018年04月29日 02:36, Michael Chan wrote: On Fri, Apr 27, 2018 at 8:15 PM, Zumeng Chen wrote: diff --git a/drivers/net/ethernet/broadcom/tg3.h b/drivers/net/ethernet/broadcom/tg3.h index 3b5e98e..6727d93 100644 --- a/drivers/net/ethernet/broadcom/tg3.h +++ b/drivers/net/ethernet/broadcom/tg3

[PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-04-27 Thread Zumeng Chen
400bf3 a8c27bfd d65f03c0 d503201f (d421) ---[ end trace e214990b7cc445ce ]--- Kernel panic - not syncing: Fatal exception in interrupt Signed-off-by: Zumeng Chen <zumeng.c...@gmail.com> --- drivers/net/ethernet/broadcom/tg3.c | 13 - drivers/net/ethernet/broadcom/tg3.h | 1

[PATCH 1/1] tg3: fix meaningless hw_stats reading after tg3_halt memset 0 hw_stats

2018-04-27 Thread Zumeng Chen
400bf3 a8c27bfd d65f03c0 d503201f (d421) ---[ end trace e214990b7cc445ce ]--- Kernel panic - not syncing: Fatal exception in interrupt Signed-off-by: Zumeng Chen --- drivers/net/ethernet/broadcom/tg3.c | 13 - drivers/net/ethernet/broadcom/tg3.h | 1 + 2 files changed, 9 i

Re: [PATCH] cpufreq: ti-cpufreq: Fix couple of minor issues in probe()

2018-03-26 Thread Zumeng Chen
g the devres managed API for allocating the opp_data variable, and simplifying the get_cpu_device() failure return path. Fixes: 05829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when failure") Cc: Zumeng Chen <zumeng.c...@gmail.com> Acked, I'm aware of the false-postive one, this is good to fi

Re: [PATCH] cpufreq: ti-cpufreq: Fix couple of minor issues in probe()

2018-03-26 Thread Zumeng Chen
g the devres managed API for allocating the opp_data variable, and simplifying the get_cpu_device() failure return path. Fixes: 05829d9431df ("cpufreq: ti-cpufreq: kfree opp_data when failure") Cc: Zumeng Chen Acked, I'm aware of the false-postive one, this is good to fix both one, thanks~ Cheer

Re: [PATCH 1/1] gianfar: fix a flooded alignment reports because of padding issue.

2017-12-04 Thread Zumeng Chen
On 12/05/2017 12:06 AM, Claudiu Manoil wrote: -Original Message- From: Zumeng Chen [mailto:zumeng.c...@gmail.com] Sent: Monday, December 04, 2017 5:22 AM To: net...@vger.kernel.org; linux-kernel@vger.kernel.org Cc: Claudiu Manoil <claudiu.man...@nxp.com>; da...@davemloft.net S

Re: [PATCH 1/1] gianfar: fix a flooded alignment reports because of padding issue.

2017-12-04 Thread Zumeng Chen
On 12/05/2017 12:06 AM, Claudiu Manoil wrote: -Original Message- From: Zumeng Chen [mailto:zumeng.c...@gmail.com] Sent: Monday, December 04, 2017 5:22 AM To: net...@vger.kernel.org; linux-kernel@vger.kernel.org Cc: Claudiu Manoil ; da...@davemloft.net Subject: [PATCH 1/1] gianfar: fix

Re: [PATCH 1/1] gianfar: fix a flooded alignment reports because of padding issue.

2017-12-04 Thread Zumeng Chen
On 12/05/2017 12:06 AM, Claudiu Manoil wrote: -Original Message- From: Zumeng Chen [mailto:zumeng.c...@gmail.com] Sent: Monday, December 04, 2017 5:22 AM To: net...@vger.kernel.org; linux-kernel@vger.kernel.org Cc: Claudiu Manoil <claudiu.man...@nxp.com>; da...@davemloft.net S

Re: [PATCH 1/1] gianfar: fix a flooded alignment reports because of padding issue.

2017-12-04 Thread Zumeng Chen
On 12/05/2017 12:06 AM, Claudiu Manoil wrote: -Original Message- From: Zumeng Chen [mailto:zumeng.c...@gmail.com] Sent: Monday, December 04, 2017 5:22 AM To: net...@vger.kernel.org; linux-kernel@vger.kernel.org Cc: Claudiu Manoil ; da...@davemloft.net Subject: [PATCH 1/1] gianfar: fix

[PATCH 1/1] gianfar: fix a flooded alignment reports because of padding issue.

2017-12-03 Thread Zumeng Chen
0805e8>] (irq_thread+0x16c/0x244) [<800805e8>] (irq_thread) from [<8004e490>] (kthread+0xe8/0x104) [<8004e490>] (kthread) from [<8000fda8>] (ret_from_fork+0x14/0x2c) Signed-off-by: Zumeng Chen <zumeng.c...@gmail.com> --- Hi, This patch has been seen in arm and validated

[PATCH 1/1] gianfar: fix a flooded alignment reports because of padding issue.

2017-12-03 Thread Zumeng Chen
0805e8>] (irq_thread+0x16c/0x244) [<800805e8>] (irq_thread) from [<8004e490>] (kthread+0xe8/0x104) [<8004e490>] (kthread) from [<8000fda8>] (ret_from_fork+0x14/0x2c) Signed-off-by: Zumeng Chen --- Hi, This patch has been seen in arm and validated, and compile, boot, an

[PATCH ] mm/backing-dev.c: remove a null kfree and fix a false kmemleak in backing-dev

2017-09-27 Thread Zumeng Chen
annel+0x88/0x9c [] scsi_scan_host_selected+0x118/0x130 [] do_scsi_scan_host+0xa0/0xa4 [] scsi_scan_host+0x170/0x1b4 wb_congested allocates memory for congested when wb_congested_get_create, and release it when exit or failure by wb_congested_put. Signed-off-by: Zumeng Chen <zumeng.c

[PATCH ] mm/backing-dev.c: remove a null kfree and fix a false kmemleak in backing-dev

2017-09-27 Thread Zumeng Chen
annel+0x88/0x9c [] scsi_scan_host_selected+0x118/0x130 [] do_scsi_scan_host+0xa0/0xa4 [] scsi_scan_host+0x170/0x1b4 wb_congested allocates memory for congested when wb_congested_get_create, and release it when exit or failure by wb_congested_put. Signed-off-by: Zumeng Chen --- mm/backing

[PATCH v2 1/1] net: macb: ensure ordering write to re-enable RX smoothly

2016-11-28 Thread Zumeng Chen
When a hardware issue happened as described by inline comments, the register write pattern looks like the following: + wmb(); There might be a memory barrier between these two write operations, so add wmb to ensure an flip from 0 to 1 for NCR. Signed-off-by: Zumeng Chen <zumen

[PATCH v2 1/1] net: macb: ensure ordering write to re-enable RX smoothly

2016-11-28 Thread Zumeng Chen
When a hardware issue happened as described by inline comments, the register write pattern looks like the following: + wmb(); There might be a memory barrier between these two write operations, so add wmb to ensure an flip from 0 to 1 for NCR. Signed-off-by: Zumeng Chen --- V2 changes: Add

Re: [PATCH 1/1] net: macb: ensure ordering write to re-enable RX smoothly

2016-11-28 Thread Zumeng Chen
On 2016年11月28日 17:22, Nicolas Ferre wrote: Le 28/11/2016 à 08:57, Zumeng Chen a écrit : When a hardware issue happened as described by inline comments, the register write pattern looks like the following: + wmb(); There might be a memory barrier between these two write operations

Re: [PATCH 1/1] net: macb: ensure ordering write to re-enable RX smoothly

2016-11-28 Thread Zumeng Chen
On 2016年11月28日 17:22, Nicolas Ferre wrote: Le 28/11/2016 à 08:57, Zumeng Chen a écrit : When a hardware issue happened as described by inline comments, the register write pattern looks like the following: + wmb(); There might be a memory barrier between these two write operations

[PATCH 1/1] net: macb: ensure ordering write to re-enable RX smoothly

2016-11-27 Thread Zumeng Chen
When a hardware issue happened as described by inline comments, the register write pattern looks like the following: + wmb(); There might be a memory barrier between these two write operations, so add wmb to ensure an flip from 0 to 1 for NCR. Signed-off-by: Zumeng Chen <zumen

[PATCH 1/1] net: macb: ensure ordering write to re-enable RX smoothly

2016-11-27 Thread Zumeng Chen
When a hardware issue happened as described by inline comments, the register write pattern looks like the following: + wmb(); There might be a memory barrier between these two write operations, so add wmb to ensure an flip from 0 to 1 for NCR. Signed-off-by: Zumeng Chen --- drivers

Re: BUG: perf error on syscalls for powerpc64.

2015-07-17 Thread Zumeng Chen
On 2015年07月17日 09:59, Ian Munsie wrote: Excerpts from Sukadev Bhattiprolu's message of 2015-07-17 11:51:04 +1000: Are you seeing this on big-endian or little-endian system? IIRC, I saw the opposite behavior on an LE system a few months ago. i.e. without 1028ccf5, 'perf listf|grep syscall'

Re: BUG: perf error on syscalls for powerpc64.

2015-07-17 Thread Zumeng Chen
On 2015年07月17日 09:59, Ian Munsie wrote: Excerpts from Sukadev Bhattiprolu's message of 2015-07-17 11:51:04 +1000: Are you seeing this on big-endian or little-endian system? IIRC, I saw the opposite behavior on an LE system a few months ago. i.e. without 1028ccf5, 'perf listf|grep syscall'

Re: BUG: perf error on syscalls for powerpc64.

2015-07-16 Thread Zumeng Chen
On 2015年07月17日 09:51, Sukadev Bhattiprolu wrote: Zumeng Chen [zumeng.c...@gmail.com] wrote: | 3. What I have seen in 3.14.x kernel, | == | And so far, no more difference to 4.x kernel from me about this part if | I'm right. | | *) With 1028ccf5 | | perf list|grep -i syscall

Re: BUG: perf error on syscalls for powerpc64.

2015-07-16 Thread Zumeng Chen
On 2015年07月17日 12:07, Michael Ellerman wrote: On Fri, 2015-07-17 at 09:27 +0800, Zumeng Chen wrote: On 2015年07月16日 17:04, Michael Ellerman wrote: On Thu, 2015-07-16 at 13:57 +0800, Zumeng Chen wrote: Hi All, 1028ccf5 did a change for sys_call_table from a pointer to an array of unsigned long

Re: BUG: perf error on syscalls for powerpc64.

2015-07-16 Thread Zumeng Chen
On 2015年07月16日 17:04, Michael Ellerman wrote: > On Thu, 2015-07-16 at 13:57 +0800, Zumeng Chen wrote: >> Hi All, >> >> 1028ccf5 did a change for sys_call_table from a pointer to an array of >> unsigned long, I think it's not proper, here is my reason: >> >

Re: BUG: perf error on syscalls for powerpc64.

2015-07-16 Thread Zumeng Chen
On 2015年07月17日 12:07, Michael Ellerman wrote: On Fri, 2015-07-17 at 09:27 +0800, Zumeng Chen wrote: On 2015年07月16日 17:04, Michael Ellerman wrote: On Thu, 2015-07-16 at 13:57 +0800, Zumeng Chen wrote: Hi All, 1028ccf5 did a change for sys_call_table from a pointer to an array of unsigned long

Re: BUG: perf error on syscalls for powerpc64.

2015-07-16 Thread Zumeng Chen
On 2015年07月17日 09:51, Sukadev Bhattiprolu wrote: Zumeng Chen [zumeng.c...@gmail.com] wrote: | 3. What I have seen in 3.14.x kernel, | == | And so far, no more difference to 4.x kernel from me about this part if | I'm right. | | *) With 1028ccf5 | | perf list|grep -i syscall

Re: BUG: perf error on syscalls for powerpc64.

2015-07-16 Thread Zumeng Chen
On 2015年07月16日 17:04, Michael Ellerman wrote: On Thu, 2015-07-16 at 13:57 +0800, Zumeng Chen wrote: Hi All, 1028ccf5 did a change for sys_call_table from a pointer to an array of unsigned long, I think it's not proper, here is my reason: sys_call_table defined as a label in assembler should

BUG: perf error on syscalls for powerpc64.

2015-07-15 Thread Zumeng Chen
Hi All, 1028ccf5 did a change for sys_call_table from a pointer to an array of unsigned long, I think it's not proper, here is my reason: sys_call_table defined as a label in assembler should be pointer array rather than an array as described in 1028ccf5. If we defined it as an array, then

BUG: perf error on syscalls for powerpc64.

2015-07-15 Thread Zumeng Chen
Hi All, 1028ccf5 did a change for sys_call_table from a pointer to an array of unsigned long, I think it's not proper, here is my reason: sys_call_table defined as a label in assembler should be pointer array rather than an array as described in 1028ccf5. If we defined it as an array, then