[v2 PATCH] net: ethernet: mtk-star-emac: fix wrong unmap in RX handling

ot;) Acked-by: Bartosz Golaszewski Signed-off-by: Biao Huang --- drivers/net/ethernet/mediatek/mtk_star_emac.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c index a8

[v2 PATCH 0/1] net: ethernet: mtk-star-emac: fix wrong unmap in RX handling

V2: update the comment for unmapping the old skb Biao Huang (1): net: ethernet: mtk-star-emac: fix wrong unmap in RX handling drivers/net/ethernet/mediatek/mtk_star_emac.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.25.1

[PATCH] net: ethernet: mtk-star-emac: fix wrong unmap in RX handling

dling") Signed-off-by: Biao Huang --- drivers/net/ethernet/mediatek/mtk_star_emac.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c index a8641a407c06..96d2891f1675 100644 --- a/d

Re: [PATCH] net: stmmac: Fix RX Coalesce IOC always true issue

On Tue, 2020-06-09 at 14:20 +, Jose Abreu wrote: > From: Biao Huang > Date: Jun/09/2020, 10:41:33 (UTC+00:00) > > > - rx_q->rx_count_frames += priv->rx_coal_frames; > > - if (rx_q->rx_count_frames > priv->rx_coal_frames) > > +

[PATCH] net: stmmac: Fix RX Coalesce IOC always true issue

Currently rx_count_frames in stmmac_rx_refill always 0, which leads to use_rx_wd false, and IOC bit of rx_desc3 true forever. Fix it. Fixes: 6fa9d691b91ac ("net: stmmac: Prevent divide-by-zero") Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 3 +

[v2, PATCH] net: stmmac: disable/enable ptp_ref_clk in suspend/resume flow

disable ptp_ref_clk in suspend flow, and enable it in resume flow. Fixes: f573c0b9c4e0 ("stmmac: move stmmac_clk, pclk, clk_ptp_ref and stmmac_rst to platform structure") Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 12 1 file

[v2, PATCH 0/1] net: stmmac: disable/enable ptp_ref_clk in suspend/resume flow

changes in v2: 1. add Fixes in commit message 2. replace clk_disable/clk_enable with clk_disable_unprepare/clk_prepare_enable to ensure the source pll can be closed/open in suspend/resume for power saving. Biao Huang (1): net: stmmac: disable/enable ptp_ref_clk

Re: [PATCH] net: stmmac: disable/enable ptp_ref_clk in suspend/resume flow

Appreciate your comments! On Thu, 2019-10-10 at 16:01 -0700, Jakub Kicinski wrote: > On Wed, 9 Oct 2019 16:56:49 +0800, Biao Huang wrote: > > disable ptp_ref_clk in suspend flow, and enable it in resume flow. > > > > Signed-off-by: Biao Huang > > --- > > dr

[PATCH] net: stmmac: disable/enable ptp_ref_clk in suspend/resume flow

disable ptp_ref_clk in suspend flow, and enable it in resume flow. Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac

[RESEND,PATCH] net: stmmac: dwmac-mediatek: fix wrong delay value issue when resume back

mt2712_delay_stage2ps() to mt2712_set_delay() to recovery the original mac_delay value. Signed-off-by: Biao Huang --- .../ethernet/stmicro/stmmac/dwmac-mediatek.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c b/drivers/net

[PATCH] net: stmmac: dwmac-mediatek: fix wrong delay value issue when resume back

mt2712_delay_ps2stage() to mt2712_set_delay() to recovery the original mac_delay value. Signed-off-by: Biao Huang --- .../ethernet/stmicro/stmmac/dwmac-mediatek.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c b/drivers/net

[v2,PATCH 0/1] arm64: dts: mt2712: add ethernet device node

v2: add properties to default/sleep pinctrl-state node. Biao Huang (1): arm64: dts: mt2712: add ethernet device node arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 74 + arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 65 ++ 2 files changed, 139 insertions

[v2,PATCH] arm64: dts: mt2712: add ethernet device node

This patch add device node for mt2712 ethernet. Signed-off-by: Biao Huang --- arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 74 + arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 65 ++ 2 files changed, 139 insertions(+) diff --git a/arch/arm64/boot/dts

[PATCH] arm64: dts: mt2712: add ethernet device node

This patch add device node for mt2712 ethernet. Signed-off-by: Biao Huang --- arch/arm64/boot/dts/mediatek/mt2712-evb.dts | 69 + arch/arm64/boot/dts/mediatek/mt2712e.dtsi | 65 +++ 2 files changed, 134 insertions(+) diff --git a/arch/arm64/boot/dts

[PATCH 2/2 net-next] net: stmmac: add support for hash table size 128/256 in dwmac4

UC0 7. MC Filter0 8. UC Filter0 9. Flow Control 0 Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/common.h | 7 +-- drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 4 +- .../net

[PATCH 1/2 net-next] net: stmmac: dwmac4: mac address array boudary violation issue

The mac address array size is GMAC_MAX_PERFECT_ADDRESSES, so the 'reg' should be less than it, or will affect other registers. Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet

[PATCH 0/2 net-next] fix out-of-boundary issue and add taller hash table support

Fix mac address out-of-boundary issue in net-next tree. and resend the patch which was discussed in https://lore.kernel.org/patchwork/patch/1082117 but with no further progress. Biao Huang (2): net: stmmac: dwmac4: mac address array boudary violation issue net: stmmac: add support for hash

Re: [v7, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

Dear David, Jose, any comments about this patch? Thanks Biao On Thu, 2019-05-30 at 17:30 +0800, Biao Huang wrote: > 1. get hash table size in hw feature reigster, and add support > for taller hash table(128/256) in dwmac4. > 2. only clear GMAC_PACKET_FILTER bits used in this

RE: [v2, PATCH 3/4] net: stmmac: modify default value of tx-frames

On Mon, 2019-06-03 at 11:40 +, Jose Abreu wrote: > From: Biao Huang > > > the default value of tx-frames is 25, it's too late when > > passing tstamp to stack, then the ptp4l will fail: > > > > ptp4l -i eth0 -f gPTP.cfg -m > > ptp4l: selected /dev

[v2, PATCH 1/4] net: stmmac: dwmac-mediatek: enable Ethernet power domain

add Ethernet power on/off operations in init/exit flow. Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c b/drivers/net/ethernet/stmicro/stmmac

[v2, PATCH 4/4] net: stmmac: dwmac4: fix flow control issue

Current dwmac4_flow_ctrl will not clear GMAC_RX_FLOW_CTRL_RFE/GMAC_RX_FLOW_CTRL_RFE bits, so MAC hw will keep flow control on although expecting flow control off by ethtool. Add codes to fix it. Fixes: 477286b53f55 ("stmmac: add GMAC4 core support") Signed-off-by: Biao Huang --- d

[v2, PATCH 2/4] net: stmmac: dwmac-mediatek: disable rx watchdog

disable rx watchdog for dwmac-mediatek, then the hw will issue a rx interrupt once receiving a packet, so the responding time for rx path will be reduced. Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c |1 + 1 file changed, 1 insertion(+) diff --git

[v2, PATCH 0/4] complete dwmac-mediatek driver and fix flow control issue

once being enabled. Biao Huang (4): net: stmmac: dwmac-mediatek: enable Ethernet power

[v2, PATCH 3/4] net: stmmac: modify default value of tx-frames

pass when changing the tx-frames from 25 to 1 with ethtool -C option. It should be fine to set tx-frames default value to 1, so ptp4l will pass by default. Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/common.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH 3/4] net: stmmac: modify default value of tx-frames

Hi Andrew, On Thu, 2019-05-30 at 14:58 +0200, Andrew Lunn wrote: > On Thu, May 30, 2019 at 04:54:43PM +0800, Biao Huang wrote: > > the default value of tx-frames is 25, it's too late when > > passing tstamp to stack, then the ptp4l will fail: > > > > ptp4l -i et

[RESEND, PATCH 2/4] net: stmmac: dwmac-mediatek: disable rx watchdog

disable rx watchdog for dwmac-mediatek, then the hw will issue a rx interrupt once receiving a packet, so the responding time for rx path will be reduced. Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c |1 + 1 file changed, 1 insertion(+) diff --git

[RESEND, PATCH 1/4] net: stmmac: dwmac-mediatek: enable Ethernet power domain

add Ethernet power on/off operations in init/exit flow. Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c b/drivers/net

[RESEND, PATCH 3/4] net: stmmac: modify default value of tx-frames

pass when changing the tx-frames from 25 to 1 with ethtool -C option. It should be fine to set tx-frames default value to 1, so ptp4l will pass by default. Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/common.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[RESEND, PATCH 4/4] net: stmmac: dwmac4: fix flow control issue

Current dwmac4_flow_ctrl will not clear GMAC_RX_FLOW_CTRL_RFE/GMAC_RX_FLOW_CTRL_RFE bits, so MAC hw will keep flow control on although expecting flow control off by ethtool. Add codes to fix it. Fixes: 477286b53f55 ("stmmac: add GMAC4 core support") Signed-off-by: Biao Huang --- d

[RESEND, PATCH 0/4] complete dwmac-mediatek driver and fix flow control issue

control won't be disabled any more once being enabled. Biao Huang (4): net: stmmac

[v7, PATCH] add some features in stmmac

mac device for dwmac4. Biao Huang (1): net: stmmac: add support for hash table size 128/256

[v7, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

UC0 7. MC Filter0 8. UC Filter0 9. Flow Control 0 Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/common.h |7 +-- drivers/net/ethernet/stmicro/stmmac/dwmac4.h |4

[v6, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

UC0 7. MC Filter0 8. UC Filter0 9. Flow Control 0 Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/common.h |7 +-- drivers/net/ethernet/stmicro/stmmac/dwmac4.h |4

[v6, PATCH] add some features in stmmac

ze 128/256 2. add mdio clause 45 access from mac device for dwmac4. Biao Huang (1): net: stmmac: add support for hash table size 128/256

[PATCH 2/4] net: stmmac: dwmac-mediatek: disable rx watchdog

disable rx watchdog for dwmac-mediatek, then the hw will issue a rx interrupt once receiving a packet, so the responding time for rx path will be reduced. Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c |1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 1/4] net: stmmac: dwmac-mediatek: enable Ethernet power domain

add Ethernet power on/off operations in init/exit flow. Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.c b/drivers/net

[PATCH 0/4] complete dwmac-mediatek driver and fix flow control issue

. Biao Huang (4): net: stmmac: dwmac-mediatek: enable Ethernet power domain

[PATCH 3/4] net: stmmac: modify default value of tx-frames

pass when changing the tx-frames from 25 to 1 with ethtool -C option. It should be fine to set tx-frames default value to 1, so ptp4l will pass by default. Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/common.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 4/4] net: stmmac: dwmac4: fix flow control issue

Current dwmac4_flow_ctrl will not clear GMAC_RX_FLOW_CTRL_RFE/GMAC_RX_FLOW_CTRL_RFE bits, so MAC hw will keep flow control on although expecting flow control off by ethtool. Add codes to fix it. Fixes: 477286b53f55 ("stmmac: add GMAC4 core support") Signed-off-by: Biao Huang --- d

RE: [v5, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

. On Wed, 2019-05-29 at 10:30 +0000, Jose Abreu wrote: > From: Biao Huang > Date: Wed, May 29, 2019 at 10:31:08 > > > 1. get hash table size in hw feature reigster, and add support > > for taller hash table(128/256) in dwmac4. > > 2. only clear GMAC_PACKET_FILTER bits use

RE: [v5, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

UC Filter0 9. Flow Control 0 Is v5 OK? Should I resend a v6? On Wed, 2019-05-29 at 10:30 +, Jose Abreu wrote: > From: Biao Huang > Date: Wed, May 29, 2019 at 10:31:08 > > > 1. get hash table size in hw feature reigster, and add su

[v5, PATCH] add some features in stmmac

dd support for hash table size 128/256 2. add mdio clause 45 access from mac device for dwmac4. Biao Huang (1):

[v5, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

7. MC Filter0 8. UC Filter0 9. Flow Control 1 Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/common.h |7 +-- drivers/net/ethernet/stmicro/stmmac/dwmac4.h |4 +- drivers/net/ethernet

[v4, PATCH] add some features in stmmac

for dwmac4. Biao Huang (1): net: stmmac: add support for hash table size 128/256 in dwmac4

[v4, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

1. get hash table size in hw feature reigster, and add support for taller hash table(128/256) in dwmac4. 2. only clear GMAC_PACKET_FILTER bits used in this function, to avoid side effect to functions of other bits. Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/common.h

Re: [v3, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

Dear David, On Mon, 2019-05-27 at 10:08 -0700, David Miller wrote: > From: Biao Huang > Date: Mon, 27 May 2019 11:14:27 +0800 > > > diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c > > b/drivers/net/ethernet/stmicro/stmmac/dwmac4_core.c > > in

[v3, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

1. get hash table size in hw feature reigster, and add support for taller hash table(128/256) in dwmac4. 2. only clear GMAC_PACKET_FILTER bits used in this function, to avoid side effect to functions of other bits. Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/common.h

[v3, PATCH] add some features in stmmac

. Biao Huang (1): net: stmmac: add support for hash table size 128/256 in dwmac4

RE: [v2, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

Seems I should modify this patch base on "https://patchwork.ozlabs.org/project/netdev/list/?series=109699; On Fri, 2019-05-24 at 09:24 +, Jose Abreu wrote: > From: biao huang > Date: Fri, May 24, 2019 at 09:31:44 > > > On Fri, 2019-05-24 at 08:24 +, Jose Abreu wro

Re: [PATCH net-next v2 1/5] net: stmmac: enable clause 45 mdio support

Hi Weifeng, clause45 mdio access with this patch test pass on our platform, thanks! On Thu, 2019-05-23 at 23:32 +0800, Voon Weifeng wrote: > From: Kweh Hock Leong > > DWMAC4 is capable to support clause 45 mdio communication. > This patch enable the feature on stmmac_mdio_write() and >

RE: [v2, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

On Fri, 2019-05-24 at 08:24 +, Jose Abreu wrote: > From: biao huang > Date: Fri, May 24, 2019 at 07:33:37 > > > any comments about this patch? > > Can you please test your series on top of this one [1] and let me know > the output of : > # ethtool -t eth0 "

Re: [v2, PATCH] net: stmmac: add support for hash table size 128/256 in dwmac4

Dear All, any comments about this patch? Thanks. On Tue, 2019-05-14 at 11:00 +0800, Biao Huang wrote: > 1. get hash table size in hw feature reigster, and add support > for taller hash table(128/256) in dwmac4. > 2. only clear PR/HMC/PM bits of GMAC_PACKET_FILTER, to avoid >

[v4, PATCH 1/3] net: stmmac: update rx tail pointer register to fix rx dma hang issue.

to the rx channel, so packets can be received continually Fixes: 54139cf3bb33 ("net: stmmac: adding multiple buffers for rx") Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/stmi

[v4, PATCH 0/3] fix some bugs in stmmac

: modify csr_clk value to fix mdio read/write fail issue for dwmac-mediatek Biao Huang (3): net

[v4, PATCH 2/3] net: stmmac: fix csr_clk can't be zero issue

lock input") Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/stmmac_main.c |6 +++--- .../net/ethernet/stmicro/stmmac/stmmac_platform.c |5 - 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/driv

[v4, PATCH 3/3] net: stmmac: dwmac-mediatek: modify csr_clk value to fix mdio read/write fail

1. the frequency of csr clock is 66.5MHz, so the csr_clk value should be 0 other than 5. 2. the csr_clk can be got from device tree, so remove initialization here. Fixes: 9992f37e346b ("stmmac: dwmac-mediatek: add support for mt2712") Signed-off-by: Biao Huang --- .../net/ethern

[PATCH 0/6] fix some bugs and add some features in stmmac

: 1. modify csr_clk value to fix mdio read/write fail issue for dwmac-mediatek. Biao Huang (6

[v3, PATCH 0/2] add ethernet binding and modify ethernet driver for mt2712

/2018/12/14/53 1. ethernet binding file move to this series. 2. remove fine tune property in device tree 3. remove fine tune flow in ethernet driver 4. set rgmii timing according to the value in device tree, and don't care whether phy insert internal delay or not. Biao Huang (2): net-next: dt

[v3, PATCH 2/2] net-next: stmmac: dwmac-mediatek: remove fine-tune property

1. remove fine-tune property and related setting to simplify the timing adjustment flow. 2. set timing value according to the value from device tree, and will not care whether PHY insert internal delay. Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 71

[v3, PATCH 1/2] net-next: dt-binding: dwmac-mediatek: remove fine-tune property

remove fine-tune property in device tree, modify the corresponding description in dt-binding. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 31 +++- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/Documentation/devicetree

[v2, PATCH 2/2] net-next: stmmac: dwmac-mediatek: remove fine-tune property

1. remove fine-tune property and related setting to simplify the timing adjustment flow. 2. set timing value according to the value from device tree, and will not care whether PHY insert internal delay. Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 71

[v2, PATCH 1/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

The commit adds the device tree binding documentation for the MediaTek DWMAC found on MediaTek MT2712. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 78 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree

[v2, PATCH 0/2] add ethernet binding and modify ethernet driver for mt2712

fine tune property in device tree 3. remove fine tune flow in ethernet driver 4. set rgmii timing according to the value in device tree, and don't care whether phy insert internal delay or not. Biao Huang (2): dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC net

[PATCH 2/2] net-next: stmmac: dwmac-mediatek: remove fine-tune property

1. remove fine-tune property and related setting to simplify the timing adjustment flow. 2. set timing value according to the value from device tree, and will not care whether PHY insert internal delay. Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 71

[PATCH 0/2] add ethernet binding and modify ethernet driver for mt2712

in device tree, and don't care whether phy insert internal delay or not. Biao Huang (2): dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC net-next: stmmac: dwmac-mediatek: remove fine-tune property .../devicetree/bindings/net/mediatek-dwmac.txt | 78

[PATCH 1/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

The commit adds the device tree binding documentation for the MediaTek DWMAC found on MediaTek MT2712. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 78 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree

Re: [v7, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

Dear Florian, Thanks for your comments. On Thu, 2018-12-13 at 21:11 -0800, Florian Fainelli wrote: > Le 12/13/18 à 7:01 PM, biao huang a écrit : > > Dear Andrew, > > Thanks for your comments. > > > > On Thu, 2018-12-13 at 13:33 +0100, Andrew Lunn wrote: >

Re: [v7, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

Dear Andrew, Thanks for your comments. On Thu, 2018-12-13 at 13:33 +0100, Andrew Lunn wrote: > Hi Biao > > > + case PHY_INTERFACE_MODE_RGMII: > > + /* the PHY is not responsible for inserting any internal > > +* delay by itself in PHY_INTERFACE_MODE_RGMII case, >

Re: [v7, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

Dear Andrew, Thanks for your comments. On Thu, 2018-12-13 at 13:36 +0100, Andrew Lunn wrote: > > +- mediatek,rx-delay-ps: RX clock delay macro value. Default is 0. > > + It should be defined for rgmii/rgmii-txid/mii/rmii interface. > > +Both delay properties need to be a multiple of 170

Re: [v7, PATCH 0/2] add Ethernet driver support for mt2712

Dear All, Sorry, I misunderstood David's reply mail in v6 series, please ignore v7 series. Dear David, I send you another follow-up patch to fix up build warning, please check it. Thanks! On Thu, 2018-12-13 at 09:56 +0800, Biao Huang wrote: > Changes in v7: > Add MODULE_L

[PATCH] net-next: stmmac: dwmac-mediatek: add module license info

Add MODULE_LICENSE info to fix this: WARNING: modpost: missing MODULE_LICENSE() in drivers/net/ethernet/stmicro/stmmac/dwmac-mediatek.o Signed-off-by: Biao Huang --- .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c |5 + 1 file changed, 5 insertions(+) diff --git a/drivers/net

[v7, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

The commit adds the device tree binding documentation for the MediaTek DWMAC found on MediaTek MT2712. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 87 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree

[v7, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

Add Ethernet support for MediaTek SoCs from the mt2712 family Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/Kconfig|8 + drivers/net/ethernet/stmicro/stmmac/Makefile |1 + .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 413 3

[v7, PATCH 0/2] add Ethernet driver support for mt2712

Changes in v7: Add MODULE_LICENSE info in driver. Biao Huang (2): net:stmmac: dwmac-mediatek: add support for mt2712 dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC .../devicetree/bindings/net/mediatek-dwmac.txt | 87 + drivers/net/ethernet/stmicro

[v6, PATCH 0/2] add Ethernet driver support for mt2712

Changes in v6: modifications according to comments from Rob/Andrew/Sean: 1. use delay_ps instead of delay stage. 2. add comments in driver to avoid confusion. 2. rewrite set_delay function. 3. modify binding document for properties: tx-delay-ps/rx-delay-ps/pericfg etc. Biao Huang (2

[v6, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

The commit adds the device tree binding documentation for the MediaTek DWMAC found on MediaTek MT2712. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 87 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree

[v6, PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

Add Ethernet support for MediaTek SoCs from the mt2712 family Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/Kconfig|8 + drivers/net/ethernet/stmicro/stmmac/Makefile |1 + .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 408 3

Re: [v3, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

Hi Rob, Thanks for your comments. On Sat, 2018-11-17 at 22:56 +0800, Rob Herring wrote: > On Fri, Nov 16, 2018 at 05:18:46PM +0800, Biao Huang wrote: > > The commit adds the device tree binding documentation for the MediaTek DWMAC > > found on MediaTek MT2712. >

Re: [v3, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

Hi Rob, Thanks for your comments. On Sat, 2018-11-17 at 22:56 +0800, Rob Herring wrote: > On Fri, Nov 16, 2018 at 05:18:46PM +0800, Biao Huang wrote: > > The commit adds the device tree binding documentation for the MediaTek DWMAC > > found on MediaTek MT2712. >

[v3, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

The commit adds the device tree binding documentation for the MediaTek DWMAC found on MediaTek MT2712. Change-Id: I3728666bf65927164bd82fa8dddb90df8270bd44 Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 77 1 file changed, 77 insertions

[v3, PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

The commit adds the device tree binding documentation for the MediaTek DWMAC found on MediaTek MT2712. Change-Id: I3728666bf65927164bd82fa8dddb90df8270bd44 Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 77 1 file changed, 77 insertions

Re: [v2, PATCH 0/2] add Ethernet driver support for mt2712

On Mon, 2018-10-29 at 11:04 +0800, Biao Huang wrote: > The mt2712 Ethernet IP is from Synopsys, so extend stmmac to support mt2712. > sorry, I forgot to add detail descriptions for these patches. changes in v2: --since STMMAC driver applied to most Synopsys ip Ethernet, I add dwmac-medi

Re: [v2, PATCH 0/2] add Ethernet driver support for mt2712

On Mon, 2018-10-29 at 11:04 +0800, Biao Huang wrote: > The mt2712 Ethernet IP is from Synopsys, so extend stmmac to support mt2712. > sorry, I forgot to add detail descriptions for these patches. changes in v2: --since STMMAC driver applied to most Synopsys ip Ethernet, I add dwmac-medi

[v2, PATCH 0/2] add Ethernet driver support for mt2712

The mt2712 Ethernet IP is from Synopsys, so extend stmmac to support mt2712.

[v2, PATCH 0/2] add Ethernet driver support for mt2712

The mt2712 Ethernet IP is from Synopsys, so extend stmmac to support mt2712.

[PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

The commit adds the device tree binding documentation for the MediaTek DWMAC found on MediaTek MT2712. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 49 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree

[PATCH 2/2] dt-binding: mediatek-dwmac: add binding document for MediaTek MT2712 DWMAC

The commit adds the device tree binding documentation for the MediaTek DWMAC found on MediaTek MT2712. Signed-off-by: Biao Huang --- .../devicetree/bindings/net/mediatek-dwmac.txt | 49 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree

[PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

Add Ethernet support for MediaTek SoCs from the mt2712 family Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/Kconfig|8 + drivers/net/ethernet/stmicro/stmmac/Makefile |1 + .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 364 3

[PATCH 1/2] net:stmmac: dwmac-mediatek: add support for mt2712

Add Ethernet support for MediaTek SoCs from the mt2712 family Signed-off-by: Biao Huang --- drivers/net/ethernet/stmicro/stmmac/Kconfig|8 + drivers/net/ethernet/stmicro/stmmac/Makefile |1 + .../net/ethernet/stmicro/stmmac/dwmac-mediatek.c | 364 3

[RESEND PATCH 2/2] arm: dts: Add pinctrl/GPIO/EINT node for mt2701

Add pinctrl and GPIO node to mt2701.dtsi Signed-off-by: Biao Huang <biao.hu...@mediatek.com> Acked-by: Linus Walleij <linus.wall...@linaro.org> --- This patch has been reverted in 7aec2fd74add9c4a61d77f51c805b4f7592956da We have checked it can build pass in kernel-4.6 rc1 --- arch/

[RESEND PATCH 0/2] pinctrl: mediatek: add pinctrl/GPIO/EINT driver for mt2701

Biao Huang (1): arm: dts: Add pinctrl/GPIO/EINT node for mt2701 Erin Lo (1): ARM: mediatek: Add MT2701 config options for mediatek SoCs. arch/arm/boot/dts/mt2701.dtsi | 19 +++ arch/arm/mach-mediatek/Kconfig |4 2 files changed, 23 insertions(+) -- 1.7.9.5

[RESEND PATCH 2/2] arm: dts: Add pinctrl/GPIO/EINT node for mt2701

Add pinctrl and GPIO node to mt2701.dtsi Signed-off-by: Biao Huang Acked-by: Linus Walleij --- This patch has been reverted in 7aec2fd74add9c4a61d77f51c805b4f7592956da We have checked it can build pass in kernel-4.6 rc1 --- arch/arm/boot/dts/mt2701.dtsi | 19 +++ 1 file

[RESEND PATCH 0/2] pinctrl: mediatek: add pinctrl/GPIO/EINT driver for mt2701

Biao Huang (1): arm: dts: Add pinctrl/GPIO/EINT node for mt2701 Erin Lo (1): ARM: mediatek: Add MT2701 config options for mediatek SoCs. arch/arm/boot/dts/mt2701.dtsi | 19 +++ arch/arm/mach-mediatek/Kconfig |4 2 files changed, 23 insertions(+) -- 1.7.9.5

[RESEND PATCH 1/2] ARM: mediatek: Add MT2701 config options for mediatek SoCs.

From: Erin Lo The upcoming MTK pinctrl driver have a big pin table for each SoC and we don't want to bloat the kernel binary if we don't need it. Add config options so we can build for one SoC only. Add MT2701. Signed-off-by: Erin Lo Acked-by: Linus

[RESEND PATCH 1/2] ARM: mediatek: Add MT2701 config options for mediatek SoCs.

From: Erin Lo The upcoming MTK pinctrl driver have a big pin table for each SoC and we don't want to bloat the kernel binary if we don't need it. Add config options so we can build for one SoC only. Add MT2701. Signed-off-by: Erin Lo Acked-by: Linus Walleij --- arch/arm/mach-mediatek/Kconfig

[PATCH 0/2] pinctrl: mediatek: add setting for gpio and eint

1. add input-enable setting in gpio_request_enable. 2. add input-enable and direction setting for eint resources. Biao Huang (2): pinctrl: mediatek: add input-enable setting in gpio_request_enable pinctrl: mediatek: add input-enable and direction setting for eint resources drivers

[PATCH 0/2] pinctrl: mediatek: add setting for gpio and eint

1. add input-enable setting in gpio_request_enable. 2. add input-enable and direction setting for eint resources. Biao Huang (2): pinctrl: mediatek: add input-enable setting in gpio_request_enable pinctrl: mediatek: add input-enable and direction setting for eint resources drivers

[PATCH 2/2] pinctrl: mediatek: add input-enable and direction setting for eint resources

need call GPIO API any more when pin for eint usage. Signed-off-by: Biao Huang <biao.hu...@mediatek.com> --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinct

[PATCH 1/2] pinctrl: mediatek: add input-enable setting in gpio_request_enable

Since input-disable cuts off input signal of gpio, add input-enable setting in .gpio_request_enable implementation to ensure gpio function well Signed-off-by: Biao Huang <biao.hu...@mediatek.com> --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c |1 + 1 file changed, 1 insertion(+)

[PATCH 2/2] pinctrl: mediatek: add input-enable and direction setting for eint resources

need call GPIO API any more when pin for eint usage. Signed-off-by: Biao Huang --- drivers/pinctrl/mediatek/pinctrl-mtk-common.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/pinctrl/mediatek/pinctrl-mtk-common.c b/drivers/pinctrl/mediatek/pinctrl-mtk-common.c index 578897a

  1   2   >