Re: [PATCH] backlight: lm3630: remove ret = -EIO of lm3630_backlight_register()

2013-02-17 Thread gshark
2013년 02월 04일 09:14, Jingoo Han 쓴 글: There is no need to return -EIO, because backlight_device_register() already returns correct error values. Signed-off-by: Jingoo Han --- drivers/video/backlight/lm3630_bl.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] backlight: lm3630: remove ret = -EIO of lm3630_backlight_register()

2013-02-17 Thread gshark
2013년 02월 04일 09:14, Jingoo Han 쓴 글: There is no need to return -EIO, because backlight_device_register() already returns correct error values. Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/video/backlight/lm3630_bl.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH] regulator: lp8755: Don't show unrelated messags in lp8755_probe error paths

2013-01-16 Thread gshark
2013년 01월 12일 15:58, Axel Lin 쓴 글: Signed-off-by: Axel Lin --- drivers/regulator/lp8755.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/regulator/lp8755.c b/drivers/regulator/lp8755.c index decb3ad..8c3f3f2 100644 ---

Re: [PATCH] regulator: lp8755: Don't show unrelated messags in lp8755_probe error paths

2013-01-16 Thread gshark
2013년 01월 12일 15:58, Axel Lin 쓴 글: Signed-off-by: Axel Linaxel@ingics.com --- drivers/regulator/lp8755.c | 19 ++- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/drivers/regulator/lp8755.c b/drivers/regulator/lp8755.c index decb3ad..8c3f3f2 100644 ---

Re: [PATCH] regulator: lp8755: Fix mask for pchip->mphase

2012-12-25 Thread gshark
2012년 12월 26일 11:12, Axel Lin 쓴 글: According to lp8755.h: enum lp8755_mphase_config { MPHASE_CONF0, MPHASE_CONF1, MPHASE_CONF2, MPHASE_CONF3, MPHASE_CONF4, MPHASE_CONF5, MPHASE_CONF6, MPHASE_CONF7, MPHASE_CONF8,

Re: [PATCH] regulator: lp8755: Fix lp8755_regulator_init unwind code

2012-12-25 Thread gshark
2012년 12월 25일 11:06, Axel Lin 쓴 글: This patch also includes below cleanups: Show correct regulator id in dev_err. Remove __devexit_p. Signed-off-by: Axel Lin --- drivers/regulator/lp8755.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] regulator: lp8755: Fix lp8755_regulator_init unwind code

2012-12-25 Thread gshark
2012년 12월 25일 11:06, Axel Lin 쓴 글: This patch also includes below cleanups: Show correct regulator id in dev_err. Remove __devexit_p. Signed-off-by: Axel Linaxel@ingics.com --- drivers/regulator/lp8755.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git

Re: [PATCH] regulator: lp8755: Fix mask for pchip-mphase

2012-12-25 Thread gshark
2012년 12월 26일 11:12, Axel Lin 쓴 글: According to lp8755.h: enum lp8755_mphase_config { MPHASE_CONF0, MPHASE_CONF1, MPHASE_CONF2, MPHASE_CONF3, MPHASE_CONF4, MPHASE_CONF5, MPHASE_CONF6, MPHASE_CONF7, MPHASE_CONF8,

Re: [PATCH] backlight: lm3639_bl: Fix up world writable sysfs file

2012-10-29 Thread gshark
2012년 10월 29일 17:38, Axel Lin 쓴 글: We don't need the sysfs file to be world writable or group writable. This file is write-only, change it to S_IWUSR (0200). Signed-off-by: Axel Lin --- drivers/video/backlight/lm3639_bl.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH] backlight: lm3639_bl: Fix up world writable sysfs file

2012-10-29 Thread gshark
2012년 10월 29일 17:38, Axel Lin 쓴 글: We don't need the sysfs file to be world writable or group writable. This file is write-only, change it to S_IWUSR (0200). Signed-off-by: Axel Lin axel@ingics.com --- drivers/video/backlight/lm3639_bl.c |2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] backlight: lm3639: Return proper error in lm3639_bled_mode_store error paths

2012-10-11 Thread gshark
2012년 10월 11일 14:11, Axel Lin 쓴 글: Signed-off-by: Axel Lin --- drivers/video/backlight/lm3639_bl.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c index c6915c6..585949b 100644 ---

Re: [PATCH] backlight: lm3639: Return proper error in lm3639_bled_mode_store error paths

2012-10-11 Thread gshark
2012년 10월 11일 14:11, Axel Lin 쓴 글: Signed-off-by: Axel Lin axel@ingics.com --- drivers/video/backlight/lm3639_bl.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/backlight/lm3639_bl.c b/drivers/video/backlight/lm3639_bl.c index c6915c6..585949b

Re: [PATCH] leds: lm3642: Use regmap_update_bits() in lm3642_chip_init()

2012-09-23 Thread gshark
2012년 09월 22일 15:40, Axel Lin 쓴 글: Use regmap_update_bits() to replace regmap_read() + regmap_write(). With this patch, we only show the error message when regmap_update_bits() fails. Looks good..You're right. Thank you Alex. Signed-off-by: Axel Lin Acked-by: G.Shark Jeong ---

Re: [PATCH] leds: lm3642: Use regmap_update_bits() in lm3642_chip_init()

2012-09-23 Thread gshark
2012년 09월 22일 15:40, Axel Lin 쓴 글: Use regmap_update_bits() to replace regmap_read() + regmap_write(). With this patch, we only show the error message when regmap_update_bits() fails. Looks good..You're right. Thank you Alex. Signed-off-by: Axel Lin axel@ingics.com Acked-by:

Re: [PATCH 2/2] backlight: add new lm3639 backlight driver

2012-09-10 Thread gshark
LM3639 has not only pins for backlihgt but also pins for LEDs. So it uses functions in led_class and led_core file. When I see your config file, "randconig", you set CONFIG_NEW_LEDS=y but you didn't set CONFIG_LEDS_CLASS. We need to set CONFIG_NEW_LEDS and CONFIG_LEDS_CLASS both to compile

Re: [PATCH 2/2] backlight: add new lm3639 backlight driver

2012-09-10 Thread gshark
LM3639 has not only pins for backlihgt but also pins for LEDs. So it uses functions in led_class and led_core file. When I see your config file, randconig, you set CONFIG_NEW_LEDS=y but you didn't set CONFIG_LEDS_CLASS. We need to set CONFIG_NEW_LEDS and CONFIG_LEDS_CLASS both to compile it.

Re: mmotm 2012-09-06-16-46 uploaded (drivers/video/backlight/lm3639_bl)

2012-09-09 Thread gshark
Hi Randy. LM3630/9 have the pins for led so these depend on BACKLIGHT_CLASS_DEVICE and I2C. So we need to set LEDS_CLASS and NEW_LEDS. I will put these two into driver/video/backlight/Kconfig file and patch it so that you don't need to do it. 2012년 09월 08일 09:39, Randy Dunlap 쓴 글: On

Re: mmotm 2012-09-06-16-46 uploaded (drivers/video/backlight/lm3639_bl)

2012-09-09 Thread gshark
Hi Randy. LM3630/9 have the pins for led so these depend on BACKLIGHT_CLASS_DEVICE and I2C. So we need to set LEDS_CLASS and NEW_LEDS. I will put these two into driver/video/backlight/Kconfig file and patch it so that you don't need to do it. 2012년 09월 08일 09:39, Randy Dunlap 쓴 글: On