Re: [PATCH] security: smack: Add support automatic Smack labeling

2015-09-01 Thread jonghwa3 . lee
On 2015년 08월 31일 22:59, Lukasz Pawelczyk wrote: > On pon, 2015-08-31 at 15:13 +0900, jonghwa3@samsung.com wrote: >> A rule is defined for a process, 'process A', in smack rule table. >> >> ... >> Process Adevice::Aarwx- >> ... >> >> The object 'device::A' will be used to a device node

Re: [PATCH] security: smack: Add support automatic Smack labeling

2015-09-01 Thread jonghwa3 . lee
On 2015년 08월 31일 22:59, Lukasz Pawelczyk wrote: > On pon, 2015-08-31 at 15:13 +0900, jonghwa3@samsung.com wrote: >> A rule is defined for a process, 'process A', in smack rule table. >> >> ... >> Process Adevice::Aarwx- >> ... >> >> The object 'device::A' will be used to a device node

Re: [PATCH] security: smack: Add support automatic Smack labeling

2015-08-31 Thread jonghwa3 . lee
On 2015년 08월 29일 02:32, Casey Schaufler wrote: > On 8/26/2015 6:58 PM, Jonghwa Lee wrote: >> Current Smack object's label is always given by userspace. >> So there might be a certain gap between the time of file creation >> and the time of applying actual label. And because of the time gap, >> it

Re: [PATCH] security: smack: Add support automatic Smack labeling

2015-08-31 Thread jonghwa3 . lee
On 2015년 08월 29일 02:32, Casey Schaufler wrote: > On 8/26/2015 6:58 PM, Jonghwa Lee wrote: >> Current Smack object's label is always given by userspace. >> So there might be a certain gap between the time of file creation >> and the time of applying actual label. And because of the time gap, >> it

Re: [RFC 2/4] power: core: Add generic interface to get battery specification.

2015-03-09 Thread jonghwa3 . lee
Hi, 2015년 03월 06일 20:16에 Oliver Neukum 이(가) 쓴 글: >> + >> +/* Check if same data is existed */ >> +list_for_each_entry(battery, _battery_info_list, entry) >> +if (!strcmp(battery->info->name, info->name)) >> +return -EEXIST; >> + >> +battery =

Re: [RFC 2/4] power: core: Add generic interface to get battery specification.

2015-03-09 Thread jonghwa3 . lee
Hi, 2015년 03월 06일 20:16에 Oliver Neukum 이(가) 쓴 글: + +/* Check if same data is existed */ +list_for_each_entry(battery, psy_battery_info_list, entry) +if (!strcmp(battery-info-name, info-name)) +return -EEXIST; + +battery = kzalloc(sizeof(*battery),

Re: [PATCH V3 08/11] power: charger-manager: Make chraging decision focusing on battery status.

2014-12-21 Thread jonghwa3 . lee
On 2014년 12월 20일 09:24, Pavel Machek wrote: > Subject: charging. > (snip..) >> --- a/include/linux/power/charger-manager.h >> +++ b/include/linux/power/charger-manager.h >> @@ -220,6 +220,7 @@ struct charger_desc { >> * saved status of battery before entering suspend-to-RAM >> *

Re: [PATCH V3 11/11] power: charger-manager: Support to change polling rate in runtime.

2014-12-21 Thread jonghwa3 . lee
On 2014년 12월 20일 09:29, Pavel Machek wrote: > >> Add 'polling_ms' sysfs node to change charger-manager's monitoring rate >> in runtime. It can set only bigger than 2 jiffies (for 200 HZ system it >> is 10 msecs.) as it's allowed for minimum poling rate in previous. > > New sysfs filesneed

Re: [PATCH V3 11/11] power: charger-manager: Support to change polling rate in runtime.

2014-12-21 Thread jonghwa3 . lee
On 2014년 12월 20일 09:29, Pavel Machek wrote: Add 'polling_ms' sysfs node to change charger-manager's monitoring rate in runtime. It can set only bigger than 2 jiffies (for 200 HZ system it is 10 msecs.) as it's allowed for minimum poling rate in previous. New sysfs filesneed documentation.

Re: [PATCH V3 08/11] power: charger-manager: Make chraging decision focusing on battery status.

2014-12-21 Thread jonghwa3 . lee
On 2014년 12월 20일 09:24, Pavel Machek wrote: Subject: charging. (snip..) --- a/include/linux/power/charger-manager.h +++ b/include/linux/power/charger-manager.h @@ -220,6 +220,7 @@ struct charger_desc { * saved status of battery before entering suspend-to-RAM *

Re: [PATCH RESEND V2 0/10] Improve charger manager driver for optimized operation.

2014-12-19 Thread jonghwa3 . lee
On 2014년 12월 19일 11:47, Jonghwa Lee wrote: > After charger manager's initially introduced, it has kept its codes without > any > big change. However, the charger manager working operation isn't optimized and > it also has unused codes and non-generic interface. This series tries to make >

Re: [PATCH RESEND v2 03/10] power: charger-manager: Remove deprecated function, cm_notify_event().

2014-12-19 Thread jonghwa3 . lee
On 2014년 12월 19일 16:52, MyungJoo Ham wrote: >> >> cm_notify_event() is introduced to get event associated with battery status >> externally, but no one had been used. Moreover it makes charger manager >> driver more complicated. This patch tries to drop the function and all data >> related to

Re: [PATCH RESEND v2 02/10] power: charger-manager: Use power_supply_changed() not private uevent.

2014-12-19 Thread jonghwa3 . lee
On 2014년 12월 19일 16:41, MyungJoo Ham wrote: >> >> Whenever battery status is changed, charger manager tries to trigger uevent >> through private interface. This patch modifies it to use >> power_supply_changed() >> since it belongs to power supply subsystem. >> >> Signed-off-by: Jonghwa Lee

Re: [PATCH RESEND v2 02/10] power: charger-manager: Use power_supply_changed() not private uevent.

2014-12-19 Thread jonghwa3 . lee
On 2014년 12월 19일 16:41, MyungJoo Ham wrote: Whenever battery status is changed, charger manager tries to trigger uevent through private interface. This patch modifies it to use power_supply_changed() since it belongs to power supply subsystem. Signed-off-by: Jonghwa Lee

Re: [PATCH RESEND v2 03/10] power: charger-manager: Remove deprecated function, cm_notify_event().

2014-12-19 Thread jonghwa3 . lee
On 2014년 12월 19일 16:52, MyungJoo Ham wrote: cm_notify_event() is introduced to get event associated with battery status externally, but no one had been used. Moreover it makes charger manager driver more complicated. This patch tries to drop the function and all data related to simplify

Re: [PATCH RESEND V2 0/10] Improve charger manager driver for optimized operation.

2014-12-19 Thread jonghwa3 . lee
On 2014년 12월 19일 11:47, Jonghwa Lee wrote: After charger manager's initially introduced, it has kept its codes without any big change. However, the charger manager working operation isn't optimized and it also has unused codes and non-generic interface. This series tries to make charger

Re: [PATCH] soc: samsung: pmu: split up SoC specific PMU data

2014-12-02 Thread jonghwa3 . lee
On 2014년 12월 01일 01:16, Pankaj Dubey wrote: > This patch splits up exynos-pmu.c file, and moves PMU configuration data > and functions handing those data into SoC specific PMU files, keeping > driver structure and common functionality into exynos-pmu.c. > > At the same time it also separates

Re: [PATCH] soc: samsung: pmu: split up SoC specific PMU data

2014-12-02 Thread jonghwa3 . lee
On 2014년 12월 01일 01:16, Pankaj Dubey wrote: This patch splits up exynos-pmu.c file, and moves PMU configuration data and functions handing those data into SoC specific PMU files, keeping driver structure and common functionality into exynos-pmu.c. At the same time it also separates

Re: [PATCH 2/3] power: core: Add variables related temperature to power_supply_info.

2014-11-10 Thread jonghwa3 . lee
On 2014년 11월 10일 20:16, Tc, Jenny wrote: >> @@ -241,6 +241,8 @@ struct power_supply_info { >> int charge_empty_design; >> int energy_full_design; >> int energy_empty_design; >> +int temperature_max; >> +int temperature_min; >> int use_for_apm; >> }; > > > The CC,CV

Re: [PATCH 2/3] power: core: Add variables related temperature to power_supply_info.

2014-11-10 Thread jonghwa3 . lee
On 2014년 11월 10일 20:16, Tc, Jenny wrote: @@ -241,6 +241,8 @@ struct power_supply_info { int charge_empty_design; int energy_full_design; int energy_empty_design; +int temperature_max; +int temperature_min; int use_for_apm; }; The CC,CV and restart

Re: [PATCH 1/3] power: core: Add generic interface to get battery specification.

2014-11-09 Thread jonghwa3 . lee
On 2014년 11월 08일 19:13, Tc, Jenny wrote: >> +ATOMIC_NOTIFIER_HEAD(psy_battery_info_notifier); > > Isn't it good to reuse the existing power_supply_notifier for this? > >> +enum battery_info_notifier_events { >> +PSY_BATT_INFO_REGISTERED, >> +PSY_BATT_INFO_UNREGISTERED, >> +}; > > If

Re: [PATCH 1/3] power: core: Add generic interface to get battery specification.

2014-11-09 Thread jonghwa3 . lee
On 2014년 11월 08일 19:13, Tc, Jenny wrote: +ATOMIC_NOTIFIER_HEAD(psy_battery_info_notifier); Isn't it good to reuse the existing power_supply_notifier for this? +enum battery_info_notifier_events { +PSY_BATT_INFO_REGISTERED, +PSY_BATT_INFO_UNREGISTERED, +}; If we use the

Re: [PATCH 01/10] power: charger-manager: Use thermal subsystem interface only to get temperature.

2014-10-30 Thread jonghwa3 . lee
Hi, On 2014년 10월 30일 22:11, Krzysztof Kozłowski wrote: > On 30.10.2014 13:43, Jonghwa Lee wrote: >> It drops the way of using power_supply interface to reference battery's >> temperature. Then it tries to use thermal subsystem's only. This makes driver >> more simple and also can remove

Re: [PATCH 01/10] power: charger-manager: Use thermal subsystem interface only to get temperature.

2014-10-30 Thread jonghwa3 . lee
Hi, On 2014년 10월 30일 22:11, Krzysztof Kozłowski wrote: On 30.10.2014 13:43, Jonghwa Lee wrote: It drops the way of using power_supply interface to reference battery's temperature. Then it tries to use thermal subsystem's only. This makes driver more simple and also can remove ifdeferies.

Re: [PATCH 0/8] power_supply: Add API for safe access of get_property-like function attrs

2014-10-14 Thread jonghwa3 . lee
Hi, On 2014년 10월 14일 21:20, Krzysztof Kozlowski wrote: > Hi, > > > After fixing issue with referencing old power supply after driver > unbind in charger manager [1] I noticed that the race condition in such > case may still exist. It would be harder to trigger but still possible. > > The race

Re: [PATCH 0/8] power_supply: Add API for safe access of get_property-like function attrs

2014-10-14 Thread jonghwa3 . lee
Hi, On 2014년 10월 14일 21:20, Krzysztof Kozlowski wrote: Hi, After fixing issue with referencing old power supply after driver unbind in charger manager [1] I noticed that the race condition in such case may still exist. It would be harder to trigger but still possible. The race is

Re: [PATCH] power: charger-manager: Avoid recursive thermal get_temp call

2014-10-07 Thread jonghwa3 . lee
On 2014년 10월 07일 21:50, Krzysztof Kozlowski wrote: > On wto, 2014-10-07 at 19:18 +0900, jonghwa3@samsung.com wrote: >> On 2014년 10월 07일 16:13, Krzysztof Kozlowski wrote: >> >>> >>> On wto, 2014-10-07 at 11:20 +0900, jonghwa3@samsung.com wrote: Hi, On 2014년 10월 07일 01:00,

Re: [PATCH] power: charger-manager: Avoid recursive thermal get_temp call

2014-10-07 Thread jonghwa3 . lee
On 2014년 10월 07일 16:13, Krzysztof Kozlowski wrote: > > On wto, 2014-10-07 at 11:20 +0900, jonghwa3@samsung.com wrote: >> Hi, >> On 2014년 10월 07일 01:00, Krzysztof Kozlowski wrote: >> >>> The charger manager supports POWER_SUPPLY_PROP_TEMP property and acts >>> as a thermal zone if any of

Re: [PATCH] power: charger-manager: Avoid recursive thermal get_temp call

2014-10-07 Thread jonghwa3 . lee
On 2014년 10월 07일 16:13, Krzysztof Kozlowski wrote: On wto, 2014-10-07 at 11:20 +0900, jonghwa3@samsung.com wrote: Hi, On 2014년 10월 07일 01:00, Krzysztof Kozlowski wrote: The charger manager supports POWER_SUPPLY_PROP_TEMP property and acts as a thermal zone if any of these conditions

Re: [PATCH] power: charger-manager: Avoid recursive thermal get_temp call

2014-10-07 Thread jonghwa3 . lee
On 2014년 10월 07일 21:50, Krzysztof Kozlowski wrote: On wto, 2014-10-07 at 19:18 +0900, jonghwa3@samsung.com wrote: On 2014년 10월 07일 16:13, Krzysztof Kozlowski wrote: On wto, 2014-10-07 at 11:20 +0900, jonghwa3@samsung.com wrote: Hi, On 2014년 10월 07일 01:00, Krzysztof Kozlowski wrote:

Re: [PATCH] power: charger-manager: Avoid recursive thermal get_temp call

2014-10-06 Thread jonghwa3 . lee
Hi, On 2014년 10월 07일 01:00, Krzysztof Kozlowski wrote: > The charger manager supports POWER_SUPPLY_PROP_TEMP property and acts > as a thermal zone if any of these conditions match: > 1. Fuel gauge used by charger manager supports POWER_SUPPLY_PROP_TEMP. > 2. 'cm-thermal-zone' property is present

Re: [PATCH] power: charger-manager: Avoid recursive thermal get_temp call

2014-10-06 Thread jonghwa3 . lee
Hi, On 2014년 10월 07일 01:00, Krzysztof Kozlowski wrote: The charger manager supports POWER_SUPPLY_PROP_TEMP property and acts as a thermal zone if any of these conditions match: 1. Fuel gauge used by charger manager supports POWER_SUPPLY_PROP_TEMP. 2. 'cm-thermal-zone' property is present in

Re: [RESEND PATCH] arm: exynos: Allow rtc alarm and tick wakeup irq for exynos3250.

2014-09-17 Thread jonghwa3 . lee
On 2014년 09월 17일 17:53, Vikas Sajjan wrote: > Hi, > > On Wed, Sep 17, 2014 at 8:52 AM, Jonghwa Lee wrote: >> Add rtc alarm and tick irq to wakeup sources in exynos3250. >> >> Signed-off-by: Jonghwa Lee >> Acked-by : Chanwoo choi >> --- >> arch/arm/mach-exynos/pm.c |9 - >> 1 file

Re: [PATCH v3] hwmon: ntc_thermistor: Add ntc thermistor to thermal subsystem as a sensor.

2014-09-17 Thread jonghwa3 . lee
On 2014년 09월 18일 00:48, Guenter Roeck wrote: > On Wed, Sep 17, 2014 at 02:54:37PM +0900, Jonghwa Lee wrote: >> To get more comprehensive and integrated thermal management, it adds ntc >> thermistor to thermal framework as a thermal sensor. It's governed thermal >> susbsystem only if it is

Re: [PATCH v3] hwmon: ntc_thermistor: Add ntc thermistor to thermal subsystem as a sensor.

2014-09-17 Thread jonghwa3 . lee
On 2014년 09월 18일 00:48, Guenter Roeck wrote: On Wed, Sep 17, 2014 at 02:54:37PM +0900, Jonghwa Lee wrote: To get more comprehensive and integrated thermal management, it adds ntc thermistor to thermal framework as a thermal sensor. It's governed thermal susbsystem only if it is described in

Re: [RESEND PATCH] arm: exynos: Allow rtc alarm and tick wakeup irq for exynos3250.

2014-09-17 Thread jonghwa3 . lee
On 2014년 09월 17일 17:53, Vikas Sajjan wrote: Hi, On Wed, Sep 17, 2014 at 8:52 AM, Jonghwa Lee jonghwa3@samsung.com wrote: Add rtc alarm and tick irq to wakeup sources in exynos3250. Signed-off-by: Jonghwa Lee jonghwa3@samsung.com Acked-by : Chanwoo choi cw00.c...@samsung.com ---

Re: [PATCH RESEND v2] hwmon: ntc_thermistor: Add ntc thermistor to thermal subsystem as a sensor.

2014-09-16 Thread jonghwa3 . lee
On 2014년 09월 17일 13:09, Guenter Roeck wrote: > On 09/16/2014 07:41 PM, Jonghwa Lee wrote: >> To get more comprehensive and integrated thermal management, it adds ntc >> thermistor to thermal framework as a thermal sensor. It's governed thermal >> susbsystem only if it is described in DT node.

Re: [PATCH RESEND v2] hwmon: ntc_thermistor: Add ntc thermistor to thermal subsystem as a sensor.

2014-09-16 Thread jonghwa3 . lee
On 2014년 09월 17일 13:09, Guenter Roeck wrote: On 09/16/2014 07:41 PM, Jonghwa Lee wrote: To get more comprehensive and integrated thermal management, it adds ntc thermistor to thermal framework as a thermal sensor. It's governed thermal susbsystem only if it is described in DT node. Otherwise,

Re: [PATCH] extcon: max77693: Fix a bug occured at changing ADC debounce time.

2014-09-03 Thread jonghwa3 . lee
On 2014년 09월 03일 14:55, Chanwoo Choi wrote: > On 09/03/2014 02:50 PM, Jonghwa Lee wrote: >> When it writes some value other than 0 to BTLDset and JIGset, muic device >> will be reset automatically. And it happens during updating ADC debounce >> time, >> because it shares same register. To update

Re: [PATCH] extcon: max77693: Fix a bug occured at changing ADC debounce time.

2014-09-03 Thread jonghwa3 . lee
On 2014년 09월 03일 14:55, Chanwoo Choi wrote: On 09/03/2014 02:50 PM, Jonghwa Lee wrote: When it writes some value other than 0 to BTLDset and JIGset, muic device will be reset automatically. And it happens during updating ADC debounce time, because it shares same register. To update ADC

Re: [RFC PATCH] PM: Domain: Add flag to assure that device's runtime pm callback is called at once.

2014-06-11 Thread jonghwa3 . lee
Hi Ulf, On 2014년 06월 11일 17:27, Ulf Hansson wrote: > On 11 June 2014 02:33, Jonghwa Lee wrote: >> When device uses generic pm domain, its own runtime suspend callback will be >> executed only when all devices in the same domain are suspended. However, >> some >> device needs sychronized runtime

Re: [RFC PATCH] PM: Domain: Add flag to assure that device's runtime pm callback is called at once.

2014-06-11 Thread jonghwa3 . lee
Hi Ulf, On 2014년 06월 11일 17:27, Ulf Hansson wrote: On 11 June 2014 02:33, Jonghwa Lee jonghwa3@samsung.com wrote: When device uses generic pm domain, its own runtime suspend callback will be executed only when all devices in the same domain are suspended. However, some device needs

Re: [PATCH] clocksource: exynos4: Fix wrong bit operation in exynos4_mct_write()

2014-02-04 Thread jonghwa3 . lee
On 2014년 02월 04일 22:01, Kyungmin Park wrote: > > > On Tuesday, February 4, 2014, Jonghwa Lee > wrote: > > There was a faulty bit operation during checking offset in > exynos4_mct_write(). > This patch fixes it correctly. > > What's the issue? What's

Re: [PATCH] clocksource: exynos4: Fix wrong bit operation in exynos4_mct_write()

2014-02-04 Thread jonghwa3 . lee
On 2014년 02월 04일 22:01, Kyungmin Park wrote: On Tuesday, February 4, 2014, Jonghwa Lee jonghwa3@samsung.com mailto:jonghwa3@samsung.com wrote: There was a faulty bit operation during checking offset in exynos4_mct_write(). This patch fixes it correctly. What's the

Re: [PATCH] max17042: Fix build errors caused by missing REGMAP_I2C config

2013-11-24 Thread jonghwa3 . lee
On 2013년 11월 24일 19:41, Austin Boyle wrote: > max17042 now uses regmap interface but does not enable config option. This > patch fixes the following build errors: > > drivers/power/max17042_battery.c:661:15: error: variable > ‘max17042_regmap_config’ has initializer but incomplete type >

Re: [PATCH] max17042: Fix build errors caused by missing REGMAP_I2C config

2013-11-24 Thread jonghwa3 . lee
On 2013년 11월 24일 19:41, Austin Boyle wrote: max17042 now uses regmap interface but does not enable config option. This patch fixes the following build errors: drivers/power/max17042_battery.c:661:15: error: variable ‘max17042_regmap_config’ has initializer but incomplete type

Re: [PATCH] drivers/rtc/rtc-max77686.c: Fix wrong register

2013-08-13 Thread jonghwa3 . lee
On 2013년 08월 13일 22:37, Sangjung Woo wrote: > Fix to read the wrong register when cheching whether the RTC timer has > reached or not. > > Signed-off-by: Sangjung Woo > Signed-off-by: Myugnjoo Ham > Reviewed-by: Jonghwa Lee > --- > drivers/rtc/rtc-max77686.c |2 +- > 1 file changed, 1

Re: [PATCH] drivers/rtc/rtc-max77686.c: Fix wrong register

2013-08-13 Thread jonghwa3 . lee
On 2013년 08월 13일 22:37, Sangjung Woo wrote: Fix to read the wrong register when cheching whether the RTC timer has reached or not. Signed-off-by: Sangjung Woo sangjung@samsung.com Signed-off-by: Myugnjoo Ham myungjoo@samsung.com Reviewed-by: Jonghwa Lee jonghwa3@samsung.com

Re: [PATCH] regulator: max77693: Remove NULL test for rmatch[i].init_data

2013-06-30 Thread jonghwa3 . lee
On 2013년 06월 30일 01:33, Axel Lin wrote: > The implementation in of_regulator_match() already ensures match->init_data is > not NULL for all matched cases if the return value of of_regulator_match() > > 0. > > Thus remove NULL test for rmatch[i].init_data. > > This patch also fixes the

Re: [PATCH] regulator: max77693: Fix trivial typo

2013-06-30 Thread jonghwa3 . lee
On 2013년 06월 29일 12:37, Axel Lin wrote: > Fix trivial typo in the equation to check upper bound of current setting. > > Signed-off-by: Axel Lin > --- > drivers/regulator/max77693.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/regulator/max77693.c

Re: [PATCH] regulator: max77693: Fix trivial typo

2013-06-30 Thread jonghwa3 . lee
On 2013년 06월 29일 12:37, Axel Lin wrote: Fix trivial typo in the equation to check upper bound of current setting. Signed-off-by: Axel Lin axel@ingics.com --- drivers/regulator/max77693.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/regulator/max77693.c

Re: [PATCH] regulator: max77693: Remove NULL test for rmatch[i].init_data

2013-06-30 Thread jonghwa3 . lee
On 2013년 06월 30일 01:33, Axel Lin wrote: The implementation in of_regulator_match() already ensures match-init_data is not NULL for all matched cases if the return value of of_regulator_match() 0. Thus remove NULL test for rmatch[i].init_data. This patch also fixes the condition for

Re: [PATCH 2/2] power: charger-manager: Fix a bug when it unregisters notifier block of extcon.

2013-06-25 Thread jonghwa3 . lee
Hi, On 2013년 06월 25일 22:34, Chanwoo Choi wrote: > On Tue, Jun 25, 2013 at 2:02 PM, Jonghwa Lee > wrote: > > This patch prevents NULL pointer error cauesed by unregistering > unregistered > exton notifier block. At the probing time of charger manager, it

Re: [PATCH 2/2] power: charger-manager: Fix a bug when it unregisters notifier block of extcon.

2013-06-25 Thread jonghwa3 . lee
Hi, On 2013년 06월 25일 22:34, Chanwoo Choi wrote: On Tue, Jun 25, 2013 at 2:02 PM, Jonghwa Lee jonghwa3@samsung.com mailto:jonghwa3@samsung.com wrote: This patch prevents NULL pointer error cauesed by unregistering unregistered exton notifier block. At the probing time of

Re: [PATCH 1/2] power: charger-manager: regulator_get() never returns NULL.

2013-06-24 Thread jonghwa3 . lee
On 2013년 06월 25일 14:07, Sachin Kamat wrote: > On 25 June 2013 10:32, Jonghwa Lee wrote: >> This patch fixes return value checking of regulator_get() in charger-manager >> driver. The API, regulator_get(), returns ERR_PTR() when it fails to get >> regulator with given name, not NULL. >> >>

Re: [PATCH 1/2] power: charger-manager: regulator_get() never returns NULL.

2013-06-24 Thread jonghwa3 . lee
On 2013년 06월 25일 14:07, Sachin Kamat wrote: On 25 June 2013 10:32, Jonghwa Lee jonghwa3@samsung.com wrote: This patch fixes return value checking of regulator_get() in charger-manager driver. The API, regulator_get(), returns ERR_PTR() when it fails to get regulator with given name, not

Re: [PATCH] regulator: max77693: Add max77693 regualtor driver.

2013-06-23 Thread jonghwa3 . lee
Hi, On 2013년 06월 22일 00:19, Mark Brown wrote: > On Thu, Jun 20, 2013 at 04:03:26PM +0900, Jonghwa Lee wrote: >> This patch adds new regulator driver to support max77693 chip's regulators. >> max77693 has two linear voltage regulators and one current regulator which >> can be controlled through

Re: [PATCH] regulator: max77693: Add max77693 regualtor driver.

2013-06-23 Thread jonghwa3 . lee
Hi, On 2013년 06월 22일 00:19, Mark Brown wrote: On Thu, Jun 20, 2013 at 04:03:26PM +0900, Jonghwa Lee wrote: This patch adds new regulator driver to support max77693 chip's regulators. max77693 has two linear voltage regulators and one current regulator which can be controlled through I2C bus.

Re: [PATCH V5 00/30] thermal: exynos: Add thermal driver for exynos5440

2013-06-11 Thread jonghwa3 . lee
On 2013년 06월 11일 21:53, Amit Daniel Kachhap wrote: > Most of the changes in this version is as per suggestion from Jonghwa Lee. I > have retained one to one mapping of platform data with TMU instances as the > TMU's are different devices. In exynos5440 soc there is some register > sharing across

Re: [PATCH V5 00/30] thermal: exynos: Add thermal driver for exynos5440

2013-06-11 Thread jonghwa3 . lee
On 2013년 06월 11일 21:53, Amit Daniel Kachhap wrote: Most of the changes in this version is as per suggestion from Jonghwa Lee. I have retained one to one mapping of platform data with TMU instances as the TMU's are different devices. In exynos5440 soc there is some register sharing across

Re: [PATCH 3/3] Thermal:core: Handle trips focused on current trip point only.

2013-05-20 Thread jonghwa3 . lee
On 2013년 05월 21일 01:00, Zhang, Rui wrote: > > >> -Original Message- >> From: Jonghwa Lee [mailto:jonghwa3@samsung.com] >> Sent: Saturday, May 18, 2013 5:51 PM >> To: linux...@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org; Zhang, Rui; Eduardo Valentin; Amit >> Dinel Kachhap;

Re: [PATCH 2/3] Thermal: core: Modify temp_crit_show() to use proper callback function.

2013-05-20 Thread jonghwa3 . lee
On 2013년 05월 21일 00:57, Zhang, Rui wrote: > > >> -Original Message- >> From: Jonghwa Lee [mailto:jonghwa3@samsung.com] >> Sent: Saturday, May 18, 2013 5:51 PM >> To: linux...@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org; Zhang, Rui; Eduardo Valentin; Amit >> Dinel Kachhap;

Re: [PATCH 2/3] Thermal: core: Modify temp_crit_show() to use proper callback function.

2013-05-20 Thread jonghwa3 . lee
On 2013년 05월 21일 00:57, Zhang, Rui wrote: -Original Message- From: Jonghwa Lee [mailto:jonghwa3@samsung.com] Sent: Saturday, May 18, 2013 5:51 PM To: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org; Zhang, Rui; Eduardo Valentin; Amit Dinel Kachhap; Jonghwa Lee;

Re: [PATCH 3/3] Thermal:core: Handle trips focused on current trip point only.

2013-05-20 Thread jonghwa3 . lee
On 2013년 05월 21일 01:00, Zhang, Rui wrote: -Original Message- From: Jonghwa Lee [mailto:jonghwa3@samsung.com] Sent: Saturday, May 18, 2013 5:51 PM To: linux...@vger.kernel.org Cc: linux-kernel@vger.kernel.org; Zhang, Rui; Eduardo Valentin; Amit Dinel Kachhap; Jonghwa Lee;

Re: [PATCH V4 22/30] thermal: exynos: Add support for exynos5440 TMU sensor.

2013-05-17 Thread jonghwa3 . lee
On 2013년 05월 14일 18:58, Amit Daniel Kachhap wrote: > This patch modifies TMU controller to add changes needed to work with > exynos5440 platform. This sensor registers 3 instance of the tmu controller > with the thermal zone and hence reports 3 temperature output. This controller > supports upto

Re: [PATCH V4 16/30] thermal: exynos: Make the zone handling dependent on trip count

2013-05-17 Thread jonghwa3 . lee
On 2013년 05월 14일 18:58, Amit Daniel Kachhap wrote: > This code simplifies the zone handling to use the trip count passed > by the TMU driver. This also helps in adding more zone support. > > Acked-by: Kukjin Kim > Signed-off-by: Amit Daniel Kachhap > --- >

Re: [PATCH V4 10/30] thermal: exynos: Support thermal tripping

2013-05-17 Thread jonghwa3 . lee
Hi, Amit On 2013년 05월 14일 18:58, Amit Daniel Kachhap wrote: > TMU urgently sends active-high signal (thermal trip) to PMU, and thermal > tripping by hardware logic. Thermal tripping means that PMU cuts off the > whole power of SoC by controlling external voltage regulator. > > Acked-by: Kukjin

Re: [PATCH V4 10/30] thermal: exynos: Support thermal tripping

2013-05-17 Thread jonghwa3 . lee
Hi, Amit On 2013년 05월 14일 18:58, Amit Daniel Kachhap wrote: TMU urgently sends active-high signal (thermal trip) to PMU, and thermal tripping by hardware logic. Thermal tripping means that PMU cuts off the whole power of SoC by controlling external voltage regulator. Acked-by: Kukjin Kim

Re: [PATCH V4 16/30] thermal: exynos: Make the zone handling dependent on trip count

2013-05-17 Thread jonghwa3 . lee
On 2013년 05월 14일 18:58, Amit Daniel Kachhap wrote: This code simplifies the zone handling to use the trip count passed by the TMU driver. This also helps in adding more zone support. Acked-by: Kukjin Kim kgene@samsung.com Signed-off-by: Amit Daniel Kachhap amit.dan...@samsung.com ---

Re: [PATCH V4 22/30] thermal: exynos: Add support for exynos5440 TMU sensor.

2013-05-17 Thread jonghwa3 . lee
On 2013년 05월 14일 18:58, Amit Daniel Kachhap wrote: This patch modifies TMU controller to add changes needed to work with exynos5440 platform. This sensor registers 3 instance of the tmu controller with the thermal zone and hence reports 3 temperature output. This controller supports upto five

Re: [RFC PATCH 0/2] cpufreq: Introduce LAB cpufreq governor.

2013-04-09 Thread jonghwa3 . lee
Hi, sorry for my late reply. I just want to add comment to assist Lukasz's. I put my comments below of Lukasz's. On 2013년 04월 09일 19:37, Lukasz Majewski wrote: > Hi Viresh, > > First of all I'd like to apologize for a late response. > Please find my comments below. > >> On Mon, Apr 1, 2013 at

Re: [RFC PATCH 0/2] cpufreq: Introduce LAB cpufreq governor.

2013-04-09 Thread jonghwa3 . lee
Hi, sorry for my late reply. I just want to add comment to assist Lukasz's. I put my comments below of Lukasz's. On 2013년 04월 09일 19:37, Lukasz Majewski wrote: Hi Viresh, First of all I'd like to apologize for a late response. Please find my comments below. On Mon, Apr 1, 2013 at 1:54

Re: [RFC PATCH 1/2] cpuidle: Add idle enter/exit time stamp for notifying current idle state.

2013-04-03 Thread jonghwa3 . lee
On 2013년 04월 02일 20:18, Daniel Lezcano wrote: > On 04/02/2013 01:07 PM, jonghwa3@samsung.com wrote: >> On 2013년 04월 02일 19:08, Daniel Lezcano wrote: >> >>> On 04/02/2013 11:37 AM, jonghwa3@samsung.com wrote: On 2013년 04월 02일 16:34, Daniel Lezcano wrote: > On 04/02/2013 08:17

Re: [RFC PATCH 1/2] cpuidle: Add idle enter/exit time stamp for notifying current idle state.

2013-04-03 Thread jonghwa3 . lee
On 2013년 04월 02일 20:18, Daniel Lezcano wrote: On 04/02/2013 01:07 PM, jonghwa3@samsung.com wrote: On 2013년 04월 02일 19:08, Daniel Lezcano wrote: On 04/02/2013 11:37 AM, jonghwa3@samsung.com wrote: On 2013년 04월 02일 16:34, Daniel Lezcano wrote: On 04/02/2013 08:17 AM,

Re: [RFC PATCH 1/2] cpuidle: Add idle enter/exit time stamp for notifying current idle state.

2013-04-02 Thread jonghwa3 . lee
On 2013년 04월 02일 19:08, Daniel Lezcano wrote: > On 04/02/2013 11:37 AM, jonghwa3@samsung.com wrote: >> On 2013년 04월 02일 16:34, Daniel Lezcano wrote: >> >>> On 04/02/2013 08:17 AM, jonghwa3@samsung.com wrote: On 2013년 04월 02일 14:00, Daniel Lezcano wrote: > On 04/01/2013 10:24

Re: [RFC PATCH 1/2] cpuidle: Add idle enter/exit time stamp for notifying current idle state.

2013-04-02 Thread jonghwa3 . lee
On 2013년 04월 02일 16:34, Daniel Lezcano wrote: > On 04/02/2013 08:17 AM, jonghwa3@samsung.com wrote: >> On 2013년 04월 02일 14:00, Daniel Lezcano wrote: >> >>> On 04/01/2013 10:24 AM, Jonghwa Lee wrote: This patch adds idle state time stamp to cpuidle device structure to notify its

Re: [RFC PATCH 1/2] cpuidle: Add idle enter/exit time stamp for notifying current idle state.

2013-04-02 Thread jonghwa3 . lee
On 2013년 04월 02일 14:00, Daniel Lezcano wrote: > On 04/01/2013 10:24 AM, Jonghwa Lee wrote: >> This patch adds idle state time stamp to cpuidle device structure to >> notify its current idle state. If last enter time is newer than last >> exit time, then it means that the core is in idle now. >>

Re: [RFC PATCH 1/2] cpuidle: Add idle enter/exit time stamp for notifying current idle state.

2013-04-02 Thread jonghwa3 . lee
On 2013년 04월 02일 14:00, Daniel Lezcano wrote: On 04/01/2013 10:24 AM, Jonghwa Lee wrote: This patch adds idle state time stamp to cpuidle device structure to notify its current idle state. If last enter time is newer than last exit time, then it means that the core is in idle now.

Re: [RFC PATCH 1/2] cpuidle: Add idle enter/exit time stamp for notifying current idle state.

2013-04-02 Thread jonghwa3 . lee
On 2013년 04월 02일 16:34, Daniel Lezcano wrote: On 04/02/2013 08:17 AM, jonghwa3@samsung.com wrote: On 2013년 04월 02일 14:00, Daniel Lezcano wrote: On 04/01/2013 10:24 AM, Jonghwa Lee wrote: This patch adds idle state time stamp to cpuidle device structure to notify its current idle state.

Re: [RFC PATCH 1/2] cpuidle: Add idle enter/exit time stamp for notifying current idle state.

2013-04-02 Thread jonghwa3 . lee
On 2013년 04월 02일 19:08, Daniel Lezcano wrote: On 04/02/2013 11:37 AM, jonghwa3@samsung.com wrote: On 2013년 04월 02일 16:34, Daniel Lezcano wrote: On 04/02/2013 08:17 AM, jonghwa3@samsung.com wrote: On 2013년 04월 02일 14:00, Daniel Lezcano wrote: On 04/01/2013 10:24 AM, Jonghwa Lee

Re: [PATCH v2] rtc: max8997: Add driver for max8997 rtc.

2013-02-07 Thread jonghwa3 . lee
On 2013년 02월 08일 06:44, Andrew Morton wrote: > On Thu, 07 Feb 2013 20:01:27 +0900 > Jonghwa Lee wrote: > >> This patch adds rtc driver for Maxim 8997 multifunction chip. >> Max8997 has rtc module in it. and it can be used for timekeeping >> clock and system alarm. It provide various operational

Re: [PATCH v2] rtc: max8997: Add driver for max8997 rtc.

2013-02-07 Thread jonghwa3 . lee
On 2013년 02월 08일 06:44, Andrew Morton wrote: On Thu, 07 Feb 2013 20:01:27 +0900 Jonghwa Lee jonghwa3@samsung.com wrote: This patch adds rtc driver for Maxim 8997 multifunction chip. Max8997 has rtc module in it. and it can be used for timekeeping clock and system alarm. It provide

Re: [PATCH] rtc: max8997: Add driver for max8997 rtc.

2013-02-06 Thread jonghwa3 . lee
On 2013년 02월 07일 13:14, devendra.aaru wrote: > Hello, > > On Wed, Feb 6, 2013 at 4:53 PM, Jonghwa Lee wrote: >> This patch adds rtc driver for Maxim 8997 multifunction chip. >> Max8997 has rtc module in it. and it can be used for timekeeping >> clock and system alarm. It provide various

Re: [PATCH] rtc: max8997: Add driver for max8997 rtc.

2013-02-06 Thread jonghwa3 . lee
On 2013년 02월 07일 11:28, Andrew Morton wrote: > On Thu, 07 Feb 2013 10:43:23 +0900 jonghwa3@samsung.com wrote: > >>> The best way of handling this sort of thing is for the driver to probe >>> the hardware, work out its capabilities and "do the right thing". >>> >>> The second best way is to

Re: [PATCH] rtc: max8997: Add driver for max8997 rtc.

2013-02-06 Thread jonghwa3 . lee
On 2013년 02월 07일 06:06, Andrew Morton wrote: > On Wed, 06 Feb 2013 20:23:05 +0900 > Jonghwa Lee wrote: > >> This patch adds rtc driver for Maxim 8997 multifunction chip. >> Max8997 has rtc module in it. and it can be used for timekeeping >> clock and system alarm. It provide various operational

Re: [PATCH] rtc: Modify leap year test for more simpler way

2013-02-06 Thread jonghwa3 . lee
On 2013년 02월 07일 03:11, Stephen Warren wrote: > On 02/06/2013 06:00 AM, Haojian Zhuang wrote: >> On Wed, Feb 6, 2013 at 8:43 PM, wrote: >>> On 2013년 02월 06일 20:42, Venu Byravarasu wrote: By definition, leap year is one, which is a divisible by 4 & 400, excluding multiples of 100s.

Re: [PATCH] rtc: Modify leap year test for more simpler way

2013-02-06 Thread jonghwa3 . lee
On 2013년 02월 06일 20:42, Venu Byravarasu wrote: > By definition, leap year is one, which is a divisible by 4 & 400, excluding > multiples of 100s. > Hence I feel this patch is not correct. No, I think you might misunderstood the it's meaning. The former code checks whether if it is multiple of 4

Re: [PATCH] rtc: Modify leap year test for more simpler way

2013-02-06 Thread jonghwa3 . lee
On 2013년 02월 06일 20:42, Venu Byravarasu wrote: > By definition, leap year is one, which is a divisible by 4 & 400, excluding > multiples of 100s. > Hence I feel this patch is not correct. No, I think you might misunderstood the it's meaning. The former code checks whether if it is multiple of 4

Re: [PATCH] rtc: Modify leap year test for more simpler way

2013-02-06 Thread jonghwa3 . lee
On 2013년 02월 06일 20:42, Venu Byravarasu wrote: By definition, leap year is one, which is a divisible by 4 400, excluding multiples of 100s. Hence I feel this patch is not correct. No, I think you might misunderstood the it's meaning. The former code checks whether if it is multiple of 4 or

Re: [PATCH] rtc: Modify leap year test for more simpler way

2013-02-06 Thread jonghwa3 . lee
On 2013년 02월 06일 20:42, Venu Byravarasu wrote: By definition, leap year is one, which is a divisible by 4 400, excluding multiples of 100s. Hence I feel this patch is not correct. No, I think you might misunderstood the it's meaning. The former code checks whether if it is multiple of 4 or

Re: [PATCH] rtc: Modify leap year test for more simpler way

2013-02-06 Thread jonghwa3 . lee
On 2013년 02월 07일 03:11, Stephen Warren wrote: On 02/06/2013 06:00 AM, Haojian Zhuang wrote: On Wed, Feb 6, 2013 at 8:43 PM, jonghwa3@samsung.com wrote: On 2013년 02월 06일 20:42, Venu Byravarasu wrote: By definition, leap year is one, which is a divisible by 4 400, excluding multiples of

Re: [PATCH] rtc: max8997: Add driver for max8997 rtc.

2013-02-06 Thread jonghwa3 . lee
On 2013년 02월 07일 06:06, Andrew Morton wrote: On Wed, 06 Feb 2013 20:23:05 +0900 Jonghwa Lee jonghwa3@samsung.com wrote: This patch adds rtc driver for Maxim 8997 multifunction chip. Max8997 has rtc module in it. and it can be used for timekeeping clock and system alarm. It provide

Re: [PATCH] rtc: max8997: Add driver for max8997 rtc.

2013-02-06 Thread jonghwa3 . lee
On 2013년 02월 07일 11:28, Andrew Morton wrote: On Thu, 07 Feb 2013 10:43:23 +0900 jonghwa3@samsung.com wrote: The best way of handling this sort of thing is for the driver to probe the hardware, work out its capabilities and do the right thing. The second best way is to require that the

Re: [PATCH] rtc: max8997: Add driver for max8997 rtc.

2013-02-06 Thread jonghwa3 . lee
On 2013년 02월 07일 13:14, devendra.aaru wrote: Hello, On Wed, Feb 6, 2013 at 4:53 PM, Jonghwa Lee jonghwa3@samsung.com wrote: This patch adds rtc driver for Maxim 8997 multifunction chip. Max8997 has rtc module in it. and it can be used for timekeeping clock and system alarm. It provide

Re: [rtc-linux] [RESEND PATCH] RTC: MAX77686: Add Maxim 77686 driver

2012-12-19 Thread jonghwa3 . lee
Hi, Andrew, On 2012년 12월 19일 09:30, Andrew Morton wrote: > On Wed, 28 Nov 2012 15:50:57 +0900 > Jonghwa Lee wrote: > >> Add driver for support max77686 rtc. >> MAX77686 rtc support smpl and wtsr mode. It has two alarm register >> which can be used for alarming to wake system up. This drvier uses

Re: [rtc-linux] [RESEND PATCH] RTC: MAX77686: Add Maxim 77686 driver

2012-12-19 Thread jonghwa3 . lee
Hi, Andrew, On 2012년 12월 19일 09:30, Andrew Morton wrote: On Wed, 28 Nov 2012 15:50:57 +0900 Jonghwa Lee jonghwa3@samsung.com wrote: Add driver for support max77686 rtc. MAX77686 rtc support smpl and wtsr mode. It has two alarm register which can be used for alarming to wake system up.

Re: [PATCH v3 2/2] therma: exynos: Supports thermal tripping

2012-11-22 Thread jonghwa3 . lee
it can use 3rd thermal trigger level in both SOC group. And it will activate as THERMAL TRIP in exynos4x12,5250 and as just 3rd Trigger levels in exynos4210. I do not just emphasize the use of Trigger_level3_en, but I recommend you to support 3rd trigger level in exynos4210 either. Thanks, Jonghwa.

Re: [PATCH v3 2/2] therma: exynos: Supports thermal tripping

2012-11-22 Thread jonghwa3 . lee
: Wednesday, November 21, 2012 1:02 PM To: Kyungmin Park Cc: Jonghwan Choi; jonghwa3.lee; open list; Amit Daniel Kachhap; Zhang Rui; Sachin Kamat Subject: Re: [PATCH v3 2/2] therma: exynos: Supports thermal tripping Hi, On 2012년 11월 20일 10:40, Kyungmin Park wrote: On 11/20/12, Jonghwan Choi

Re: [PATCH v3 2/2] therma: exynos: Supports thermal tripping

2012-11-20 Thread jonghwa3 . lee
Hi, On 2012년 11월 20일 10:40, Kyungmin Park wrote: > On 11/20/12, Jonghwan Choi wrote: >> TMU urgently sends active-high signal (thermal trip) to PMU, >> and thermal tripping by hardware logic i.e PMU is performed. >> Thermal tripping means that PMU cut off the whole power of SoC >> by controlling

Re: [PATCH v4] Thermal: exynos: Add sysfs node supporting exynos's emulation mode.

2012-11-20 Thread jonghwa3 . lee
On 2012년 11월 21일 11:00, Zhang Rui wrote: > On Thu, 2012-11-08 at 14:54 +0530, Amit Kachhap wrote: >> Hi Jonghwa Lee, >> >> I tested this patch and it looks good. I have some minor comments below, >> >> Reviewed-by: Amit Daniel Kachhap >> > Hi, Lee, > > I suppose there should be an updated version

  1   2   >