Re: [RFC][PATCH v2] drm: kirin: Add a mutex to avoid fb initialization race

2017-02-24 Thread liuxinliang
On 2017/2/25 9:39, liuxinliang wrote: Hi John, The patch seems good to me, except one minus comment. Maybe change fb_lock to fbdev_lock would be better. Thanks, -xinliang On 2017/2/25 9:25, John Stultz wrote: In some cases I've been seeing a race where two framebuffers would be initialized

Re: [RFC][PATCH v2] drm: kirin: Add a mutex to avoid fb initialization race

2017-02-24 Thread liuxinliang
On 2017/2/25 9:39, liuxinliang wrote: Hi John, The patch seems good to me, except one minus comment. Maybe change fb_lock to fbdev_lock would be better. Thanks, -xinliang On 2017/2/25 9:25, John Stultz wrote: In some cases I've been seeing a race where two framebuffers would be initialized

Re: [RFC][PATCH v2] drm: kirin: Add a mutex to avoid fb initialization race

2017-02-24 Thread liuxinliang
Hi John, The patch seems good to me, except one minus comment. Maybe change fb_lock to fbdev_lock would be better. Thanks, -xinliang On 2017/2/25 9:25, John Stultz wrote: In some cases I've been seeing a race where two framebuffers would be initialized, as kirin_fbdev_output_poll_changed()

Re: [RFC][PATCH v2] drm: kirin: Add a mutex to avoid fb initialization race

2017-02-24 Thread liuxinliang
Hi John, The patch seems good to me, except one minus comment. Maybe change fb_lock to fbdev_lock would be better. Thanks, -xinliang On 2017/2/25 9:25, John Stultz wrote: In some cases I've been seeing a race where two framebuffers would be initialized, as kirin_fbdev_output_poll_changed()

Re: [RFC][PATCH] drm: kirin: Add a mutex to avoid fb initialization race

2017-02-24 Thread liuxinliang
On 2017/2/25 5:33, John Stultz wrote: On Thu, Feb 23, 2017 at 5:55 PM, liuxinliang <z.liuxinli...@hisilicon.com> wrote: Hi John, On 2017/2/23 8:56, John Stultz wrote: In some cases I've been seeing a race where two framebuffers would be initialized, as kirin_fbdev_output_poll_c

Re: [RFC][PATCH] drm: kirin: Add a mutex to avoid fb initialization race

2017-02-24 Thread liuxinliang
On 2017/2/25 5:33, John Stultz wrote: On Thu, Feb 23, 2017 at 5:55 PM, liuxinliang wrote: Hi John, On 2017/2/23 8:56, John Stultz wrote: In some cases I've been seeing a race where two framebuffers would be initialized, as kirin_fbdev_output_poll_changed() might get called quickly

Re: [RFC][PATCH] drm: kirin: Add a mutex to avoid fb initialization race

2017-02-23 Thread liuxinliang
Hi John, On 2017/2/23 8:56, John Stultz wrote: In some cases I've been seeing a race where two framebuffers would be initialized, as kirin_fbdev_output_poll_changed() might get called quickly in succession, resulting in the fb initialization happening twice. This could cause the system I

Re: [RFC][PATCH] drm: kirin: Add a mutex to avoid fb initialization race

2017-02-23 Thread liuxinliang
Hi John, On 2017/2/23 8:56, John Stultz wrote: In some cases I've been seeing a race where two framebuffers would be initialized, as kirin_fbdev_output_poll_changed() might get called quickly in succession, resulting in the fb initialization happening twice. This could cause the system I

Re: [PATCH 0/2] serial: 8250_dw: Add ACPI support for uart on Hisilicon Hip05 soc

2016-06-29 Thread liuxinliang
Hi, On 2016/6/29 20:52, Andy Shevchenko wrote: On Tue, 2016-06-28 at 11:17 +0800, Kefeng Wang wrote: Make dw8250_set_termios() as the default set_termios callback for 8250 dw uart, correct me if I am wrong. Then add ACPI support for uart on Hisilicon Hip05 soc, be careful that it is not 16500

Re: [PATCH 0/2] serial: 8250_dw: Add ACPI support for uart on Hisilicon Hip05 soc

2016-06-29 Thread liuxinliang
Hi, On 2016/6/29 20:52, Andy Shevchenko wrote: On Tue, 2016-06-28 at 11:17 +0800, Kefeng Wang wrote: Make dw8250_set_termios() as the default set_termios callback for 8250 dw uart, correct me if I am wrong. Then add ACPI support for uart on Hisilicon Hip05 soc, be careful that it is not 16500