Re: [PATCH V5 1/3] scsi: ufs: Serialize eh_work with system PM events and async scan

2020-12-02 Thread nguyenb
On 2020-12-02 00:24, Can Guo wrote: Serialize eh_work with system PM events and async scan to make sure eh_work does not run in parallel with them. Reviewed-by: Asutosh Das Reviewed-by: Hongwu Su Signed-off-by: Can Guo --- drivers/scsi/ufs/ufshcd.c | 64

Re: [PATCH v2] scsi: ufs: Remove pre-defined initial voltage values of device powers

2020-12-02 Thread nguyenb
On 2020-11-30 22:51, Stanley Chu wrote: UFS specficication allows different VCC configurations for UFS devices, for example, (1). 2.70V - 3.60V (Activated by default in UFS core driver) (2). 1.70V - 1.95V (Activated if "vcc-supply-1p8" is declared in

Re: [RFC PATCH v1] scsi: ufs: Remove pre-defined initial VCC voltage values

2020-12-01 Thread nguyenb
t;>>>> @@ -133,15 +133,7 @@ static int ufshcd_populate_vreg(struct device *dev, const char *name, >>>>>vreg->max_uA = 0; >>>>>} >>>>> - if (!strcmp(name, "vcc")) { >>>>> - if (of_prop

Re: [PATCH v3 3/3] scsi: ufs: Print host regs in IRQ handler when AH8 error happens

2020-11-24 Thread nguyenb
On 2020-11-16 23:04, Can Guo wrote: When AH8 error happens, all the regs and states are dumped in err handler. Sometime we need to look into host regs right after AH8 error happens, which is before leaving the IRQ handler. Signed-off-by: Can Guo --- drivers/scsi/ufs/ufshcd.c | 3 ++- 1 file

Re: [PATCH v1 1/1] scsi: ufshcd: Properly set the device Icc Level

2020-10-26 Thread nguyenb
On 2020-08-31 18:19, Bao D. Nguyen wrote: UFS version 3.0 and later devices require Vcc and Vccq power supplies with Vccq2 being optional. While earlier UFS version 2.0 and 2.1 devices, the Vcc and Vccq2 are required with Vccq being optional. Check the required power supplies used by the device

Re: [PATCH v1 1/1] scsi: ufshcd: Properly set the device Icc Level

2020-09-28 Thread nguyenb
On 2020-08-31 18:19, Bao D. Nguyen wrote: UFS version 3.0 and later devices require Vcc and Vccq power supplies with Vccq2 being optional. While earlier UFS version 2.0 and 2.1 devices, the Vcc and Vccq2 are required with Vccq being optional. Check the required power supplies used by the device

Re: [PATCH v1 1/2] scsi: dt-bindings: ufs: Add vcc-voltage-level for UFS

2020-09-23 Thread nguyenb
On 2020-09-21 17:36, Bjorn Andersson wrote: On Mon 21 Sep 19:22 CDT 2020, nguy...@codeaurora.org wrote: On 2020-09-18 12:01, Rob Herring wrote: > On Tue, Sep 15, 2020 at 2:10 AM wrote: > > > > On 2020-09-14 11:35, Rob Herring wrote: > > > On Mon, Aug 31, 2020 at 11:00:47PM -0700, Bao D.

Re: [PATCH v1 1/2] scsi: dt-bindings: ufs: Add vcc-voltage-level for UFS

2020-09-21 Thread nguyenb
On 2020-09-18 12:01, Rob Herring wrote: On Tue, Sep 15, 2020 at 2:10 AM wrote: On 2020-09-14 11:35, Rob Herring wrote: > On Mon, Aug 31, 2020 at 11:00:47PM -0700, Bao D. Nguyen wrote: >> UFS's specifications supports a range of Vcc operating >> voltage levels. Add documentation for the UFS's

Re: [PATCH v1 1/1] scsi: ufshcd: Properly set the device Icc Level

2020-09-16 Thread nguyenb
On 2020-09-15 06:37, Bjorn Andersson wrote: On Tue 15 Sep 03:49 CDT 2020, nguy...@codeaurora.org wrote: On 2020-09-14 19:54, Bjorn Andersson wrote: > On Tue 01 Sep 01:19 UTC 2020, Bao D. Nguyen wrote: > > > UFS version 3.0 and later devices require Vcc and Vccq power supplies > > with Vccq2

Re: [PATCH v1 1/2] scsi: dt-bindings: ufs: Add vcc-voltage-level for UFS

2020-09-15 Thread nguyenb
On 2020-09-15 06:43, Bjorn Andersson wrote: On Tue 15 Sep 03:14 CDT 2020, nguy...@codeaurora.org wrote: On 2020-09-14 21:41, Bjorn Andersson wrote: > On Tue 01 Sep 01:00 CDT 2020, Bao D. Nguyen wrote: > > > UFS's specifications supports a range of Vcc operating > > voltage levels. Add

Re: [PATCH v1 1/1] scsi: ufshcd: Properly set the device Icc Level

2020-09-15 Thread nguyenb
On 2020-09-14 19:54, Bjorn Andersson wrote: On Tue 01 Sep 01:19 UTC 2020, Bao D. Nguyen wrote: UFS version 3.0 and later devices require Vcc and Vccq power supplies with Vccq2 being optional. While earlier UFS version 2.0 and 2.1 devices, the Vcc and Vccq2 are required with Vccq being

Re: [PATCH v1 1/2] scsi: dt-bindings: ufs: Add vcc-voltage-level for UFS

2020-09-15 Thread nguyenb
On 2020-09-14 11:35, Rob Herring wrote: On Mon, Aug 31, 2020 at 11:00:47PM -0700, Bao D. Nguyen wrote: UFS's specifications supports a range of Vcc operating voltage levels. Add documentation for the UFS's Vcc voltage levels setting. Signed-off-by: Can Guo Signed-off-by: Asutosh Das

Re: [PATCH v1 1/2] scsi: dt-bindings: ufs: Add vcc-voltage-level for UFS

2020-09-15 Thread nguyenb
On 2020-09-14 21:41, Bjorn Andersson wrote: On Tue 01 Sep 01:00 CDT 2020, Bao D. Nguyen wrote: UFS's specifications supports a range of Vcc operating voltage levels. Add documentation for the UFS's Vcc voltage levels setting. Signed-off-by: Can Guo Signed-off-by: Asutosh Das Signed-off-by:

Re: [PATCH v1 2/2] scsi: ufs: Support reading UFS's Vcc voltage from device tree

2020-09-14 Thread nguyenb
On 2020-09-13 02:37, Avri Altman wrote: The UFS specifications supports a range of Vcc operating voltage from 2.4-3.6V depending on the device and manufacturers. Allows selecting the UFS Vcc voltage level by setting the UFS's entry vcc-voltage-level in the device tree. If UFS's

Re: [PATCH v1 1/1] scsi: ufshcd: Properly set the device Icc Level

2020-09-14 Thread nguyenb
On 2020-09-10 03:02, Avri Altman wrote: On 2020-08-31 18:19, Bao D. Nguyen wrote: > UFS version 3.0 and later devices require Vcc and Vccq power supplies > with Vccq2 being optional. While earlier UFS version 2.0 and 2.1 > devices, the Vcc and Vccq2 are required with Vccq being optional. >

Re: [PATCH v1 1/2] scsi: dt-bindings: ufs: Add vcc-voltage-level for UFS

2020-09-14 Thread nguyenb
On 2020-09-13 02:35, Avri Altman wrote: UFS's specifications supports a range of Vcc operating voltage levels. Add documentation for the UFS's Vcc voltage levels setting. Signed-off-by: Can Guo Signed-off-by: Asutosh Das Signed-off-by: Bao D. Nguyen ---

Re: [PATCH v1 1/1] scsi: ufshcd: Properly set the device Icc Level

2020-09-09 Thread nguyenb
On 2020-08-31 18:19, Bao D. Nguyen wrote: UFS version 3.0 and later devices require Vcc and Vccq power supplies with Vccq2 being optional. While earlier UFS version 2.0 and 2.1 devices, the Vcc and Vccq2 are required with Vccq being optional. Check the required power supplies used by the device

Re: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer

2020-08-31 Thread nguyenb
On 2020-08-29 00:32, Avri Altman wrote: The zero value Auto-Hibernate Timer is a valid setting, and it indicates the Auto-Hibernate feature being disabled. Correctly Right. So " ufshcd_auto_hibern8_enable" is no longer an appropriate name. Maybe ufshcd_auto_hibern8_set instead? Thanks for

Re: [PATCH v1 1/1] scsi: ufshcd: Allow zero value setting to Auto-Hibernate Timer

2020-08-31 Thread nguyenb
On 2020-08-28 20:13, Bart Van Assche wrote: On 2020-08-28 18:05, Bao D. Nguyen wrote: static ssize_t auto_hibern8_show(struct device *dev, struct device_attribute *attr, char *buf) { + u32 ahit; struct ufs_hba *hba = dev_get_drvdata(dev);