We need to do signed arithmetic if we expect condition
`if (bytes < 0)` to be possible
Found by Linux Verification Center (linuxtesting.org) with SVACE
Fixes: 06a8fc78367d ("VSOCK: Introduce virtio_vsock_common.ko")
Signed-off-by: Nikolay Kuratov
---
V1 -> V2: Added Fix
We need to do signed arithmetic if we expect condition
`if (bytes < 0)` to be possible
Found by Linux Verification Center (linuxtesting.org) with SVACE
Signed-off-by: Nikolay Kuratov
---
net/vmw_vsock/virtio_transport_common.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
;
> Signed-off-by: Wan Jiabing
Reviewed-by: Nikolay Borisov
ce *br_dev, struct
> net_device *dev,
> if (!br_vlan_should_use(v))
> continue;
>
> - br_vlan_replay_one(nb, dev, , extack);
> + err = br_vlan_replay_one(nb, dev, , extack);
> if (err)
> return err;
> }
>
Thanks,
Acked-by: Nikolay Aleksandrov
hanged, 83 insertions(+)
>
Same comments about the const qualifiers as the other patches.
The code looks good to me otherwise.
Acked-by: Nikolay Aleksandrov
> diff --git a/include/linux/if_bridge.h b/include/linux/if_bridge.h
> index b564c4486a45..2cc35038a8ca 100644
> --- a/include/li
notify and the newly added br_mdb_queue_one in how the switchdev
> mdb object is created, so a helper was created.
>
> Suggested-by: Ido Schimmel
> Signed-off-by: Vladimir Oltean
> ---
> include/linux/if_bridge.h | 9 +++
> include/net/switchdev.h | 1 +
> net/bridge/br_
me (dst == NULL). The code itself is correct and the alternative
to take only 1 net_device and act based on its type would add another
step to the process per-port which also doesn't sound good...
There are a few minor const nits below too, again if there is another version
please take care of them,
f_bridge.h | 6 ++
> net/bridge/br_stp.c | 13 +
> 2 files changed, 19 insertions(+)
>
The patch is mostly fine, there are a few minor nits (const qualifiers). If
there
is another version of the patch-set please add them, either way:
Acked-by: Nikolay Aleksa
e, such that drivers can synchronize to it when they may have missed
> switchdev events.
>
> Signed-off-by: Vladimir Oltean
> Reviewed-by: Florian Fainelli
> Reviewed-by: Tobias Waldekranz
> ---
> include/linux/if_bridge.h | 6 ++
> net/bridge/br_stp.c | 14 ++
> 2 files changed, 20 insertions(+)
>
Acked-by: Nikolay Aleksandrov
On 22/03/2021 18:56, Vladimir Oltean wrote:
> On Mon, Mar 22, 2021 at 06:35:10PM +0200, Nikolay Aleksandrov wrote:
>>> + hlist_for_each_entry(mp, >mdb_list, mdb_node) {
>>
>> You cannot walk over these lists without the multicast lock or RCU. RTNL is
>> not
&g
On 21/03/2021 00:34, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> Currently this simple setup:
>
> ip link add br0 type bridge vlan_filtering 1
> ip link add bond0 type bond
> ip link set bond0 master br0
> ip link set swp0 master bond0
>
> will not work because the bridge has created
On 21/03/2021 00:34, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> When a DSA port joins a LAG that already had an FDB entry pointing to it:
>
> ip link set bond0 master br0
> bridge fdb add dev bond0 00:01:02:03:04:05 master static
> ip link set swp0 master bond0
>
> the DSA port will
On 21/03/2021 00:34, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> I have udhcpcd in my system and this is configured to bring interfaces
> up as soon as they are created.
>
> I create a bridge as follows:
>
> ip link add br0 type bridge
>
> As soon as I create the bridge and udhcpcd
On 21/03/2021 00:34, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> The objective of this series is to make LAG uppers on top of switchdev
> ports work regardless of which order we link interfaces to their masters
> (first make the port join the LAG, then the LAG join the bridge, or the
>
On 17.03.21 г. 0:46 ч., Victor Erminpour wrote:
> Calling cc-option will use KBUILD_CFLAGS, which when lazy setting
> subdir-ccflags-y produces the following build error:
>
> scripts/Makefile.lib:10: *** Recursive variable `KBUILD_CFLAGS' \
> references itself (eventually). Stop.
>
>
On 9.03.21 г. 10:49 ч., kernel test robot wrote:
>
>
> Greeting,
>
> FYI, we noticed the following commit (built with gcc-9):
>
> commit: 5297199a8bca12b8b96afcbf2341605efb6005de ("btrfs: remove inode number
> cache feature")
>
warning:
warning: symbol 'i' shadows an earlier one
Signed-off-by: Nikolay Kyx
---
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
b/drivers/staging/rtl8192e/rtl8192e
Hi Laurent,
Thank you for the review.
I think that if we drop the unneeded parentheses here, we need to drop
them everywhere in the file for consistency, even in places checkpatch.pl
doesn't warn about. It'll increase patch size without actual usefullness
gain, as for me. I am very (very) novice
This patch fixes the following checkpatch.pl check:
CHECK: Macro argument 'i' may be better as '(i)' to avoid precedence issues
in file iss_regs.h
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
drivers/staging/media
This patch fixes the following checkpatch.pl warning:
WARNING: line length of 124 exceeds 100 columns
in file kpc2000_i2c.c
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested by Greg KH
v3
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
in files kpc2000_i2c.c kpc2000_spi.c
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested
This patch fixes the following checkpatch.pl warning:
WARNING: Avoid multiple line dereference
in file ipu3-css.c
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Removed second part of patch which fixes non-existent
I can't find any change in struct imgu_fw_info layout after this patch.
But warning is strange, because declarations don't actually end here.
So I think this warning should be suppressed to reduce noise
in checkpatch.pl output.
This patch fixes the following checkpatch.pl warning:
WARNING: Missing a blank line after declarations
in file ipu3-css-fw.h
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
drivers/staging/media/ipu3/ipu3-css-fw.h | 1
This patch fixes the following checkpatch.pl warning:
WARNING: Avoid multiple line dereference
in file ipu3-css.c
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
drivers/staging/media/ipu3/ipu3-css.c | 14
This patch fixes the following checkpatch.pl warning:
WARNING: line length of 124 exceeds 100 columns
in file kpc2000_i2c.c
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested by Greg KH
v3
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
in files kpc2000_i2c.c kpc2000_spi.c
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
in file fwserial.c
Signed-off-by: Nikolay Kyx
---
Additionally some style warnings remain valid here and could be fixed by
another patch.
v2: Edited changelog, as suggested by Greg KH
v3
This patch fixes the following checkpatch.pl check:
CHECK: Alignment should match open parenthesis
in file fwserial.c
Additionally some style warnings remain valid here and could be fixed by
another patch.
Signed-off-by: Nikolay Kyx
---
v2: Edited changelog, as suggested by Greg KH
-by: Nikolay Kyx
---
v2: Edited changelog, as suggested by Greg KH
drivers/staging/kpc2000/kpc2000_i2c.c | 6 --
drivers/staging/kpc2000/kpc2000_spi.c | 2 +-
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c
b/drivers/staging/kpc2000/kpc2000_i2c.c
kpc2000_i2c.c:
fix WARNING: line length of 124 exceeds 100 columns
fix CHECK: Alignment should match open parenthesis
kpc2000_spi.c:
fix CHECK: Alignment should match open parenthesis
Signed-off-by: Nikolay Kyx
---
drivers/staging/kpc2000/kpc2000_i2c.c | 6 --
drivers/staging/kpc2000
fwserial.c:
fix CHECK: Alignment should match open parenthesis
Signed-off-by: Nikolay Kyx
---
drivers/staging/fwserial/fwserial.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/fwserial/fwserial.c
b/drivers/staging/fwserial/fwserial.c
index
t_flag if already
> populated.
>
> net/bridge/br_netlink.c | 9 +
> net/bridge/br_private.h | 6 --
> net/bridge/br_switchdev.c | 13 +++--
> net/bridge/br_sysfs_if.c | 7 +--
> 4 files changed, 21 insertions(+), 14 deletions(-)
>
Acked-by: Nikolay Aleksandrov
lude/net/switchdev.h | 6 --
> net/dsa/slave.c | 3 ++-
> net/switchdev/switchdev.c | 11 ++++---
> 8 files changed, 24 insertions(+), 11 deletions(-)
>
Reviewed-by: Nikolay Aleksandrov
ch is new.
>
> Changes in v2:
> Patch is new.
>
> net/bridge/br_netlink.c | 109 --
> net/bridge/br_switchdev.c | 6 ++-
> 2 files changed, 39 insertions(+), 76 deletions(-)
>
LGTM, thanks!
Acked-by: Nikolay Aleksandrov
On 10/02/2021 14:01, Vladimir Oltean wrote:
> On Wed, Feb 10, 2021 at 01:05:57PM +0200, Nikolay Aleksandrov wrote:
>> On 10/02/2021 13:01, Vladimir Oltean wrote:
>>> On Wed, Feb 10, 2021 at 12:52:33PM +0200, Nikolay Aleksandrov wrote:
>>>> On 10/02/2021 12:45, V
On 10/02/2021 13:01, Vladimir Oltean wrote:
> On Wed, Feb 10, 2021 at 12:52:33PM +0200, Nikolay Aleksandrov wrote:
>> On 10/02/2021 12:45, Vladimir Oltean wrote:
>>> Hi Nikolay,
>>>
>>> On Wed, Feb 10, 2021 at 12:31:43PM +0200, Nikolay Aleksandrov wrote:
>
On 10/02/2021 12:45, Vladimir Oltean wrote:
> Hi Nikolay,
>
> On Wed, Feb 10, 2021 at 12:31:43PM +0200, Nikolay Aleksandrov wrote:
>> Hi Vladimir,
>> Let's take a step back for a moment and discuss the bridge unlock/lock
>> sequences
>> that come with this se
On 10/02/2021 11:14, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> The initial goal of this series was to have better support for
> standalone ports mode and multiple bridges on the DSA drivers like
> ocelot/felix and sja1105. Proper support for standalone mode requires
> disabling address
On 10/02/2021 11:14, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> Since we would like br_switchdev_set_port_flag to not use an atomic
> notifier, it should be called from outside spinlock context.
>
> We can temporarily drop br->lock, but that creates some concurrency
> complications
On 08/02/2021 13:45, Vladimir Oltean wrote:
> On Mon, Feb 08, 2021 at 01:37:03PM +0200, Nikolay Aleksandrov wrote:
>> Hi Vladimir,
>> I think this patch potentially breaks some use cases. There are a few
>> problems, I'll
>> start with the more serious one: before
On 08/02/2021 01:21, Vladimir Oltean wrote:
> From: Vladimir Oltean
>
> It must first be admitted that switchdev device drivers have a life
> beyond the bridge, and when they aren't offloading the bridge driver
> they are operating with forwarding disabled between ports, emulating as
> closely
store_flag(struct net_bridge_port *p, unsigned
> long v,
> flags &= ~mask;
>
> if (flags != p->flags) {
> + err = br_switchdev_set_port_flag(p, flags, mask);
> + if (err)
> + return err;
> +
> p->flags = flags;
> br_port_flags_change(p, mask);
> }
>
Acked-by: Nikolay Aleksandrov
break;
> }
>
Somehow this hasn't hit my inbox, good thing I just got the reply and saw the
patch. Anyway, thanks!
Acked-by: Nikolay Aleksandrov
The following commit has been merged into the locking/core branch of tip:
Commit-ID: 442187f3c2de40bab13b8f9751b37925bede73b0
Gitweb:
https://git.kernel.org/tip/442187f3c2de40bab13b8f9751b37925bede73b0
Author:Nikolay Borisov
AuthorDate:Tue, 26 Jan 2021 12:17:21 +02:00
On 29.01.21 г. 18:49 ч., Josh Poimboeuf wrote:
> Agreed, stable is a good idea. I think Nikolay saw it with GCC 9.
Yes I did, with the default Ubuntu compiler as well as the default gcc-10
compiler:
# gcc -v -Q -O2 --help=target | grep protection
gcc version 9.3.0 (Ubuntu 9.
On 29.01.21 г. 3:34 ч., Alexei Starovoitov wrote:
> On Thu, Jan 28, 2021 at 07:24:14PM +0100, Peter Zijlstra wrote:
>> On Thu, Jan 28, 2021 at 06:45:56PM +0200, Nikolay Borisov wrote:
>>> it would be placed on the __fentry__ (and not endbr64) hence it works.
>>> So p
, for functions which can be called indirectly.
>
> CET instrumentation isn't currently necessary in the kernel, as CET is
> only supported in user space. Disable it unconditionally.
>
> Reported-by: Nikolay Borisov
> Signed-off-by: Josh Poimboeuf
Tested-by: Nikolay Borisov
Reviewed-by: Nikolay Borisov
On 28.01.21 г. 18:12 ч., Nikolay Borisov wrote:
>
>
> On 28.01.21 г. 5:38 ч., Masami Hiramatsu wrote:
>> Hi,
>
>
>
>>
>> Alexei, could you tell me what is the concerning situation for bpf?
>
> Another data point masami is that this affect
On 28.01.21 г. 5:38 ч., Masami Hiramatsu wrote:
> Hi,
>
> Alexei, could you tell me what is the concerning situation for bpf?
Another data point masami is that this affects bpf kprobes which are
entered via int3, alternatively if the kprobe is entered via
kprobe_ftrace_handler it works as
On 28.01.21 г. 5:38 ч., Masami Hiramatsu wrote:
> Hi,
>
>
> Yeah, there is. Nikolay, could you try this tentative patch?
I can confirm that with this patch everything is working. I also applied
the following diff:
diff --git a/kernel/trace/bpf_trace.c b/kernel/trace/bpf_t
On 27.01.21 г. 17:24 ч., Masami Hiramatsu wrote:
> On Thu, 28 Jan 2021 00:13:53 +0900
> Masami Hiramatsu wrote:
>
>> Hi Nikolay,
>>
>> On Wed, 27 Jan 2021 15:43:29 +0200
>> Nikolay Borisov wrote:
>>
>>> Hello,
>>>
>>> I'm
On 27.01.21 г. 15:57 ч., Michal Rostecki wrote:
> From: Michal Rostecki
>
> Before this change, the btrfs_get_io_geometry() function was calling
> btrfs_get_chunk_map() to get the extent mapping, necessary for
> calculating the I/O geometry. It was using that extent mapping only
> internally
Hello,
I'm currently seeing latest Linus' master being somewhat broken w.r.t
krpobes. In particular I have the following test-case:
#!/bin/bash
mkfs.btrfs -f /dev/vdc &> /dev/null
mount /dev/vdc /media/scratch/
bpftrace -e 'kprobe:btrfs_sync_file {printf("kprobe: %s\n", kstack());}'
This is a leftover from 7f26482a872c ("locking/percpu-rwsem: Remove the
embedded rwsem")
Signed-off-by: Nikolay Borisov
---
V2:
* Add reference to commit which made the file useless.
kernel/locking/rwsem.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100
oups */
> - err = IS_ERR(pg) ? PTR_ERR(pg) : 0;
> + err = PTR_ERR_OR_ZERO(pg);
> spin_unlock(>multicast_lock);
>
> return err;
>
This should be targeted at net-next.
Acked-by: Nikolay Aleksandrov
On 19.01.21 г. 7:05 ч., Chaitanya Kulkarni wrote:
> Signed-off-by: Chaitanya Kulkarni
> ---
> fs/btrfs/volumes.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index ee086fc56c30..836167212252 100644
> ---
On 19/01/2021 06:39, Jakub Kicinski wrote:
> On Sun, 17 Jan 2021 05:34:16 -0800 wangyingji...@126.com wrote:
>> From: Yingjie Wang
>>
>> There is no iPv4_is_multicast() check added to ip_mc_leave_group()
>> to check if imr->imr_multiaddr.s_addr is a multicast address.
>> If not a multicast
> 3 files changed, 5 insertions(+), 12 deletions(-)
>
Acked-by: Nikolay Aleksandrov
On 16/01/2021 17:39, Joachim Wiberg wrote:
> On Wed, Jan 13, 2021 at 14:15, Nikolay Aleksandrov wrote:
>> On 12/01/2021 15:59, Horatiu Vultur wrote:
>>> Based on the comments of the previous version, we started to work on a
>>> new version, so it would be possible to
On 14/01/2021 09:51, menglong8.d...@gmail.com wrote:
> From: Menglong Dong
>
> Replace the check for ETH_P_8021Q and ETH_P_8021AD in
> br_dev_queue_push_xmit with eth_type_vlan.
>
> Signed-off-by: Menglong Dong
> ---
> net/bridge/br_forward.c | 3 +--
> 1 file changed, 1 insertion(+), 2
Signed-off-by: Nikolay Borisov
---
kernel/locking/rwsem.h | 0
1 file changed, 0 insertions(+), 0 deletions(-)
delete mode 100644 kernel/locking/rwsem.h
diff --git a/kernel/locking/rwsem.h b/kernel/locking/rwsem.h
deleted file mode 100644
index e69de29bb2d1..
--
2.25.1
On 13/01/2021 11:44, Jiapeng Zhong wrote:
> Fix the following warnings:
>
> net/bridge/br_sysfs_if.c(162): warning: %ld in format string (no. 1)
> requires 'long' but the argument type is 'unsigned long'.
> net/bridge/br_sysfs_if.c(155): warning: %ld in format string (no. 1)
> requires 'long' but
On 13/01/2021 11:36, Jiapeng Zhong wrote:
> Fix the following warnings:
>
> net/bridge/br_sysfs_br.c(833): warning: %u in format string (no. 1)
> requires 'unsigned int' but the argument type is 'signed int'.
> net/bridge/br_sysfs_br.c(817): warning: %u in format string (no. 1)
> requires
On 12/01/2021 15:59, Horatiu Vultur wrote:
> Based on the comments of the previous version, we started to work on a
> new version, so it would be possible to enable/disable queries per vlan.
> This is still work in progress and there are plenty of things that are
> not implemented and tested:
> -
On 13/12/2020 15:55, Vladimir Oltean wrote:
> Hi Nik,
>
> On Sun, Dec 13, 2020 at 03:22:16PM +0200, Nikolay Aleksandrov wrote:
>> Hi Vladimir,
>> Thank you for the good explanation, it really helps a lot to understand the
>> issue.
>> Even though it's deceptive
On 13/12/2020 15:22, Nikolay Aleksandrov wrote:
> On 13/12/2020 04:40, Vladimir Oltean wrote:
>> Currently the bridge emits atomic switchdev notifications for
>> dynamically learnt FDB entries. Monitoring these notifications works
>> wonders for switchdev drivers that want t
On 13/12/2020 04:40, Vladimir Oltean wrote:
> Currently the bridge emits atomic switchdev notifications for
> dynamically learnt FDB entries. Monitoring these notifications works
> wonders for switchdev drivers that want to keep their hardware FDB in
> sync with the bridge's FDB.
>
> For example
bridge completed, add sysfs entries */
> - br_sysfs_addbr(dev);
> + err = br_sysfs_addbr(dev);
> + if (err)
> + return notifier_from_errno(err);
> +
> return NOTIFY_DONE;
> }
> }
>
Patch looks good, I also tested it with a notifier error injecting.
Tested-by: Nikolay Aleksandrov
Acked-by: Nikolay Aleksandrov
On 11/12/2020 11:26, Horatiu Vultur wrote:
> This patch tries to add vlan support to IGMP queries.
> It extends the function 'br_ip4_multicast_alloc_query' to add
> also a vlan tag if vlan is enabled. Therefore the bridge will send
> queries for each vlan the ports are in.
>
> There are few other
On 8.12.20 г. 21:46 ч., Matthew Wilcox (Oracle) wrote:
> Pages being added to the page cache should already be folios, so
> turn add_to_page_cache_lru() into a wrapper. Saves hundreds of
> bytes of text.
>
> Signed-off-by: Matthew Wilcox (Oracle)
> ---
> include/linux/pagemap.h | 13
On 6.12.20 г. 10:56 ч., Yun Levi wrote:
>> This, and the change above this, are not related to this patch so you
>> might not want to include them.
>
>> Also, why is this patch series even needed? I don't see a justification
>> for it anywhere, only "what" this patch is, not "why".
>
> I
f-by: Joseph Huang
> ---
> net/bridge/br_device.c| 6 ++
> net/bridge/br_multicast.c | 34 +-
> net/bridge/br_private.h | 10 ++
> 3 files changed, 41 insertions(+), 9 deletions(-)
>
LGTM, thanks!
Acked-by: Nikolay Aleksandrov
On 04/12/2020 23:39, Joseph Huang wrote:
> When enabling multicast snooping, bridge module deadlocks on multicast_lock
> if 1) IPv6 is enabled, and 2) there is an existing querier on the same L2
> network.
>
> The deadlock was caused by the following sequence: While holding the lock,
>
{
> + err = -ENOMEM;
> goto out_filt;
> + }
> v->brvlan = masterv;
> if (br_opt_get(br, BROPT_VLAN_STATS_PER_PORT)) {
> v->stats = netdev_alloc_pcpu_stats(struct
> br_vlan_stats);
>
Acked-by: Nikolay Aleksandrov
On 04/12/2020 00:42, Huang, Joseph wrote:
>> From: Huang, Joseph
>> Sent: Thursday, December 3, 2020 4:53 PM
>> To: Nikolay Aleksandrov ; Jakub Kicinski
>>
>> Cc: Roopa Prabhu ; David S. Miller
>> ; bri...@lists.linux-foundation.org;
>> net...@vger.kerne
cast_leave_snoopers -> ipv6_dev_mc_dec -> igmp6_group_dropped ->
igmp6_leave_group ->
MLDv1 mode && last reporter -> igmp6_send() ?
I think it was saved by the fact that !br_opt_get(br, BROPT_MULTICAST_ENABLED)
would be true and the
multicast lock won't be acquired in the br_dev_xmit path? If so, I'd appreciate
a comment about that
because it's not really trivial to find out. :)
Anyhow, the patch is fine as-is too:
Acked-by: Nikolay Aleksandrov
Thanks,
Nik
On 03/12/2020 03:03, Jakub Kicinski wrote:
> On Tue, 1 Dec 2020 22:01:14 +0800 Wang Hai wrote:
>> If adding bridge sysfs fails, br->ifobj will be NULL, there is no
>> need to delete its non-existent sysfs when deleting the bridge device,
>> otherwise, it will cause a warning. So, when br->ifobj ==
On 23/11/2020 14:31, Horatiu Vultur wrote:
> The 11/23/2020 14:13, Nikolay Aleksandrov wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you know the
>> content is safe
>>
>> On 23/11/2020 13:14, Horatiu Vultur wrote:
>>> Exte
On 23/11/2020 13:14, Horatiu Vultur wrote:
> Extend MRP to support LC mode(link check) for the interconnect port.
> This applies only to the interconnect ring.
>
> Opposite to RC mode(ring check) the LC mode is using CFM frames to
> detect when the link goes up or down and based on that the
On 10.11.20 г. 15:14 ч., John Ogness wrote:
> On 2020-11-10, Nikolay Borisov wrote:
>> data_alloc's 2nd argument is always rb::text_data_ring and that functino
>> always takes a struct printk_ringbuffer. Instead of passing the data
>> ring buffer as an argument simply mak
data_alloc's 2nd argument is always rb::text_data_ring and that functino
always takes a struct printk_ringbuffer. Instead of passing the data
ring buffer as an argument simply make it a local variable.
Signed-off-by: Nikolay Borisov
---
kernel/printk/printk_ringbuffer.c | 9 -
1 file
> + br_opt_toggle(br, BROPT_MULTICAST_ENABLED, false);
> spin_unlock_bh(>multicast_lock);
>
> br_multicast_gc(_head);
This doesn't make any sense. It doesn't fix anything.
If 4.4 has a problem then the relevant patches should get backported to it.
We don't add random changes to fix older releases.
Cheers,
Nik
Nacked-by: Nikolay Aleksandrov
On Wed, 2020-10-28 at 12:54 +0200, Vladimir Oltean wrote:
> From: Nikolay Aleksandrov
>
> Extend the bridge multicast control and data path to configure routes
> for L2 (non-IP) multicast groups.
>
> The uapi struct br_mdb_entry union u is extended with another variant,
>
On Tue, 2020-10-27 at 07:59 -0700, Stephen Hemminger wrote:
> On Tue, 27 Oct 2020 10:02:42 +
> Henrik Bjoernlund via Bridge wrote:
>
> > +/* Return 0 if the frame was not processed otherwise 1
> > + * note: already called with rcu_read_lock
> > + */
> > +static int
On Sun, 2020-10-25 at 06:59 +, Vladimir Oltean wrote:
> On Wed, Oct 21, 2020 at 09:17:07AM +0000, Nikolay Aleksandrov wrote:
> > > diff --git a/include/uapi/linux/if_bridge.h
> > > b/include/uapi/linux/if_bridge.h
> > > index 4c687686aa8f..a25f6f9aa8c3 100644
On Wed, 2020-10-21 at 09:17 +, Nikolay Aleksandrov wrote:
> On Sat, 2020-10-17 at 21:41 +0300, Vladimir Oltean wrote:
> > From: Nikolay Aleksandrov
> >
> > Extend the bridge multicast control and data path to configure routes
> > for L2 (non-IP) multicast group
On Sat, 2020-10-17 at 21:41 +0300, Vladimir Oltean wrote:
> From: Nikolay Aleksandrov
>
> Extend the bridge multicast control and data path to configure routes
> for L2 (non-IP) multicast groups.
>
> The uapi struct br_mdb_entry union u is extended with another variant
On Thu, 2020-10-15 at 20:33 +0300, Vladimir Oltean wrote:
> Switchdev drivers often have different VLAN semantics than the bridge.
> For example, consider this:
>
> ip link add br0 type bridge
> ip link set swp0 master br0
> bridge mdb add dev br0 port swp0 grp 01:02:03:04:05:06 permanent
> ip
TLINK IFLA_BRIDGE_CFM_CC_PEER_STATUS_INFO.
>
> Signed-off-by: Henrik Bjoernlund
> Reviewed-by: Horatiu Vultur
> ---
> include/uapi/linux/if_bridge.h | 29 +
> include/uapi/linux/rtnetlink.h | 1 +
> net/bridge/br_cfm_netlink.c| 105 +
> net/bridge/br_netlink.c| 16 -
> net/bridge/br_private.h| 6 ++
> 5 files changed, 154 insertions(+), 3 deletions(-)
>
>
Acked-by: Nikolay Aleksandrov
.
> IFLA_BRIDGE_CFM_CC_CCM_TX_PORT_TLV_VALUE:
> The transmitted Port Status TLV value field.
> The type is u8.
>
> Signed-off-by: Henrik Bjoernlund
> Reviewed-by: Horatiu Vultur
> ---
> include/uapi/linux/if_bridge.h | 6 ++
> net/bridge/br_cfm_netlink.c| 161 +
> net/bridge/br_netlink.c| 29 +-
> net/bridge/br_private.h| 6 ++
> 4 files changed, 200 insertions(+), 2 deletions(-)
>
Acked-by: Nikolay Aleksandrov
-
> net/bridge/br_mrp.c | 19 +++
> net/bridge/br_private.h | 19 ---
> 4 files changed, 60 insertions(+), 12 deletions(-)
>
Looks good.
Acked-by: Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote:
> This patch extends the processing of frames in the bridge. Currently MRP
> frames needs special processing and the current implementation doesn't
> allow a nice way to process different frame types. Therefore try to
> improve this by
oernlund
> Reviewed-by: Horatiu Vultur
> ---
> net/bridge/br_cfm.c | 48
> net/bridge/br_cfm_netlink.c | 25 ++++-
> net/bridge/br_netlink.c | 73 -
> net/bridge/br_private.h | 22 ++-
> 4 files changed, 147 insertions(+), 21 deletions(-)
>
Acked-by: Nikolay Aleksandrov
On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote:
> This is the implementation of CFM netlink status
> get information interface.
>
> Add new nested netlink attributes. These attributes are used by the
> user space to get status information.
>
> GETLINK:
> Request filter
On Sat, 2020-10-10 at 00:56 +0300, Nikolay Aleksandrov wrote:
> On Fri, 2020-10-09 at 14:35 +, Henrik Bjoernlund wrote:
> > This is the implementation of CFM netlink configuration
> > get information interface.
> >
> > Add new nested netlink attributes
.
> IFLA_BRIDGE_CFM_CC_CCM_TX_PORT_TLV_VALUE:
> The transmitted Port Status TLV value field.
> The type is u8.
>
> Signed-off-by: Henrik Bjoernlund
> Reviewed-by: Horatiu Vultur
> ---
> include/uapi/linux/if_bridge.h | 6 ++
> net/bridge/br_cfm_netlink.c| 161 +
> net/bridge/br_netlink.c| 29 +-
> net/bridge/br_private.h| 6 ++
> 4 files changed, 200 insertions(+), 2 deletions(-)
>
Acked-by: Nikolay Aleksandrov
_bridge.h | 90 +++
> include/uapi/linux/rtnetlink.h | 1 +
> net/bridge/Makefile| 2 +-
> net/bridge/br_cfm.c| 5 +
> net/bridge/br_cfm_netlink.c| 458 +
> net/bridge/br_netlink.c| 5 +
> net/bridge/br_private.h| 17 +-
> 7 files changed, 576 insertions(+), 2 deletions(-)
> create mode 100644 net/bridge/br_cfm_netlink.c
>
Acked-by: Nikolay Aleksandrov
net/bridge/br_cfm.c | 269
> net/bridge/br_private_cfm.h | 32
> 3 files changed, 311 insertions(+)
>
Acked-by: Nikolay Aleksandrov
by
> br_cfm_cc_rdi_set()
>
> Signed-off-by: Henrik Bjoernlund
> Reviewed-by: Horatiu Vultur
> ---
> include/uapi/linux/cfm_bridge.h | 39 -
> net/bridge/br_cfm.c | 284
> net/bridge/br_private_cfm.h | 54 ++
> 3 files changed, 376 insertions(+), 1 deletion(-)
>
Acked-by: Nikolay Aleksandrov
1 - 100 of 1052 matches
Mail list logo
