Re: [PATCH 0/2] Add support for TI AM18XX/OMAP-L138 PRUSS

2021-01-24 Thread santosh.shilim...@oracle.com
On 1/4/21 10:30 AM, David Lechner wrote: This is the first step for adding support for the PRUSS on TI AM18XX/OMAP-L138 SoCs. This series adds support in the top-level PRUSS driver. (Patches for the interrupt controller and individual PRUs are independent of this change and will be submitted

Re: [PATCH v2 0/5] Introduce PRU remoteproc consumer API

2021-01-24 Thread santosh.shilim...@oracle.com
Hi Suman, Mathieu, On 1/7/21 2:49 PM, Suman Anna wrote: On 1/7/21 4:44 PM, Mathieu Poirier wrote: On Wed, Jan 06, 2021 at 06:03:25PM -0600, Suman Anna wrote: Hi Mathieu, [...] I only see input from Andy and Lars in the thread you point out, nothing from Greg. I have also taken a look at

Re: [PATCH v2 00/11] firmware/soc: ti_sci, ringacc/inta: Preparation for AM64 DMA support

2020-11-01 Thread santosh.shilim...@oracle.com
Hi Peter, On 10/8/20 5:56 PM, santosh.shilim...@oracle.com wrote: On 10/8/20 4:52 AM, Peter Ujfalusi wrote: Santosh: if you plan to take this series for 5.11, then can you create an immutable branch which I can refer to Vinod for the DMA patches I'm going to send soon. I will set it up

Re: [PATCH -next v2] soc: ti: Convert to DEFINE_SHOW_ATTRIBUTE

2020-09-20 Thread santosh.shilim...@oracle.com
On 9/18/20 7:52 PM, Qinglang Miao wrote: Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. Signed-off-by: Qinglang Miao --- v2: based on linux-next(20200917), and can be applied to mainline cleanly now. Applied. Thanks !! Regards, Santosh

Re: [PATCH next v2 0/3] soc: ti: k3: ringacc: add am65x sr2.0 support

2020-09-11 Thread santosh.shilim...@oracle.com
On 9/9/20 9:52 AM, santosh.shilim...@oracle.com wrote: On 9/2/20 7:08 AM, Nishanth Menon wrote: On 11:34-20200831, santosh.shilim...@oracle.com wrote: On 8/29/20 11:41 AM, Grygorii Strashko wrote: [..] Santosh, in this series, may i suggest that the dtsi changes[1] be hosted on my tree

Re: [PATCH next v2 0/3] soc: ti: k3: ringacc: add am65x sr2.0 support

2020-09-11 Thread santosh.shilim...@oracle.com
On 9/8/20 7:40 PM, santosh.shilim...@oracle.com wrote: On 9/8/20 3:09 PM, Suman Anna wrote: Hi Santosh, On 8/31/20 1:34 PM, santosh.shilim...@oracle.com wrote: On 8/29/20 11:41 AM, Grygorii Strashko wrote: Hi Santosh, I've rebased on top of  linux-next and identified merge conflict

Re: [Linux-kernel-mentees] [PATCH net] rds: Prevent kernel-infoleak in rds_notify_queue_get()

2020-07-30 Thread santosh.shilim...@oracle.com
On 7/30/20 12:20 PM, Peilin Ye wrote: rds_notify_queue_get() is potentially copying uninitialized kernel stack memory to userspace since the compiler may leave a 4-byte hole at the end of `cmsg`. In 2016 we tried to fix this issue by doing `= { 0 };` on `cmsg`, which unfortunately does not

Re: [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy

2020-07-25 Thread santosh.shilim...@oracle.com
On 7/25/20 12:57 AM, Arnd Bergmann wrote: On Fri, Jul 24, 2020 at 11:57 PM santosh.shilim...@oracle.com wrote: On 7/24/20 2:42 PM, Grygorii Strashko wrote: Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") the networking is broken on keysto

Re: [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy

2020-07-24 Thread santosh.shilim...@oracle.com
Hi Arnd, Olof, On 7/24/20 2:42 PM, Grygorii Strashko wrote: Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") the networking is broken on keystone-k2g-evm board. The above board have phy-mode = "rgmii-id" and it is worked before because KSZ9031 PHY

Re: [PATCH v3 00/14] dmaengine/soc: Add Texas Instruments UDMA support

2019-10-09 Thread santosh.shilim...@oracle.com
On 10/8/19 3:09 AM, Peter Ujfalusi wrote: Hi Santosh, On 04/10/2019 19.35, santosh.shilim...@oracle.com wrote: On 9/30/19 11:16 PM, Peter Ujfalusi wrote: Hi, Changes since v2 )https://patchwork.kernel.org/project/linux-dmaengine/list/?series=152609=*) - Based on 5.4-rc1 - Support

Re: [PATCH v3 -next] firmware: ti_sci: Fix gcc unused-but-set-variable warning

2019-06-18 Thread santosh.shilim...@oracle.com
On 6/17/19 11:41 AM, Suman Anna wrote: On 6/15/19 7:50 AM, YueHaibing wrote: Fixes gcc '-Wunused-but-set-variable' warning: drivers/firmware/ti_sci.c: In function ti_sci_cmd_ring_config: drivers/firmware/ti_sci.c:2035:17: warning: variable dev set but not used [-Wunused-but-set-variable]

Re: [PATCH] firmware: ti_sci: Use the correct style for SPDX License Identifier

2019-06-18 Thread santosh.shilim...@oracle.com
On 6/14/19 6:57 AM, Nishad Kamdar wrote: This patch corrects the SPDX License Identifier style in header file related to Firmware Drivers for Texas Instruments SCI Protocol. For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++

Re: [PATCH] soc: ti: pm33xx: Add a print while entering RTC only mode with DDR in self-refresh

2019-04-29 Thread santosh.shilim...@oracle.com
On 4/28/19 9:44 PM, Keerthy wrote: Currently there is no way to distinguish if the SoC entered DS0 mode or the RTC only mode. Hence add a print before entering the RTC only mode. Signed-off-by: Keerthy --- Acked-by: Santosh Shilimkar Tony, Am assuming you will queue this up ?

Re: [PATCH] memory: ti-emif-sram: move driver-specific asm-offset.h to drivers/memory/

2019-04-12 Thread santosh.shilim...@oracle.com
On 4/11/19 8:09 PM, Masahiro Yamada wrote: is only generated and included by drivers/memory/, so it does not need to reside in the globally visible include/generated/. Signed-off-by: Masahiro Yamada --- I will apply this to linux-kbuild since this depends on another patch there. Sure.

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread santosh.shilim...@oracle.com
On 10/30/18 12:00 PM, Greg Kroah-Hartman wrote: On Tue, Oct 30, 2018 at 10:18:08AM -0700, Santosh Shilimkar wrote: Hi Greg, [...] Would be able to apply this fix from Marc for stable or it needs to be re-posted with CC to stable ? This is not the correct way to submit patches for

Re: [PATCH] soc: ti: QMSS: Fix usage of irq_set_affinity_hint

2018-10-30 Thread santosh.shilim...@oracle.com
On 10/30/18 12:00 PM, Greg Kroah-Hartman wrote: On Tue, Oct 30, 2018 at 10:18:08AM -0700, Santosh Shilimkar wrote: Hi Greg, [...] Would be able to apply this fix from Marc for stable or it needs to be re-posted with CC to stable ? This is not the correct way to submit patches for

Re: [PATCH] soc: ti: fix spelling mistake "instace" -> "instance"

2018-09-24 Thread santosh.shilim...@oracle.com
On 9/23/18 3:14 PM, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake in dev_err messages and comments Signed-off-by: Colin Ian King --- Thanks. I will fix this up. Regards, Santosh

Re: [PATCH] soc: ti: fix spelling mistake "instace" -> "instance"

2018-09-24 Thread santosh.shilim...@oracle.com
On 9/23/18 3:14 PM, Colin King wrote: From: Colin Ian King Trivial fix to spelling mistake in dev_err messages and comments Signed-off-by: Colin Ian King --- Thanks. I will fix this up. Regards, Santosh

Re: [PATCH] uapi: Fix linux/rds.h userspace compilation errors.

2018-08-24 Thread santosh.shilim...@oracle.com
On 8/24/18 6:26 PM, Vinson Lee wrote: Include linux/in6.h for struct in6_addr. /usr/include/linux/rds.h:156:18: error: field ‘laddr’ has incomplete type struct in6_addr laddr; ^ /usr/include/linux/rds.h:157:18: error: field ‘faddr’ has incomplete type struct

Re: [PATCH] uapi: Fix linux/rds.h userspace compilation errors.

2018-08-24 Thread santosh.shilim...@oracle.com
On 8/24/18 6:26 PM, Vinson Lee wrote: Include linux/in6.h for struct in6_addr. /usr/include/linux/rds.h:156:18: error: field ‘laddr’ has incomplete type struct in6_addr laddr; ^ /usr/include/linux/rds.h:157:18: error: field ‘faddr’ has incomplete type struct

Re: general protection fault in rds_ib_get_mr

2018-07-24 Thread santosh.shilim...@oracle.com
On 7/6/18 1:11 AM, Johannes Thumshirn wrote: On Thu, Jul 05, 2018 at 09:09:44AM -0700, Santosh Shilimkar wrote: OK. we will look into it if an interim fix can be made Thanks a lot. Intermediate fix is posted here [1] Regards, Santosh [1] https://patchwork.ozlabs.org/patch/949010/

Re: general protection fault in rds_ib_get_mr

2018-07-24 Thread santosh.shilim...@oracle.com
On 7/6/18 1:11 AM, Johannes Thumshirn wrote: On Thu, Jul 05, 2018 at 09:09:44AM -0700, Santosh Shilimkar wrote: OK. we will look into it if an interim fix can be made Thanks a lot. Intermediate fix is posted here [1] Regards, Santosh [1] https://patchwork.ozlabs.org/patch/949010/

Re: [GIT PULL 2/3] ARM: Keystone config update for v4.19

2018-07-08 Thread santosh.shilim...@oracle.com
On 7/8/18 9:12 AM, Olof Johansson wrote: On Fri, Jul 06, 2018 at 02:25:41PM -0700, Santosh Shilimkar wrote: The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: Linux 4.18-rc1 (2018-06-17 08:04:49 +0900) are available in the git repository at:

Re: [GIT PULL 2/3] ARM: Keystone config update for v4.19

2018-07-08 Thread santosh.shilim...@oracle.com
On 7/8/18 9:12 AM, Olof Johansson wrote: On Fri, Jul 06, 2018 at 02:25:41PM -0700, Santosh Shilimkar wrote: The following changes since commit ce397d215ccd07b8ae3f71db689aedb85d56ab40: Linux 4.18-rc1 (2018-06-17 08:04:49 +0900) are available in the git repository at:

Re: [PATCH] soc: ti: wkup_m3_ipc: mark PM functions as __maybe_unused

2018-07-06 Thread santosh.shilim...@oracle.com
On 7/6/18 5:36 AM, Arnd Bergmann wrote: Everyone gets these #ifdefs wrong, leading to another warning here: drivers/soc/ti/wkup_m3_ipc.c:547:12: error: 'wkup_m3_ipc_resume' defined but not used [-Werror=unused-function] static int wkup_m3_ipc_resume(struct device *dev)

Re: [PATCH] soc: ti: wkup_m3_ipc: mark PM functions as __maybe_unused

2018-07-06 Thread santosh.shilim...@oracle.com
On 7/6/18 5:36 AM, Arnd Bergmann wrote: Everyone gets these #ifdefs wrong, leading to another warning here: drivers/soc/ti/wkup_m3_ipc.c:547:12: error: 'wkup_m3_ipc_resume' defined but not used [-Werror=unused-function] static int wkup_m3_ipc_resume(struct device *dev)

Re: [PATCH 0/3] Dts nodes for Keystone2 hw_rng driver

2018-05-25 Thread santosh.shilim...@oracle.com
On 5/24/18 6:12 AM, Vitaly Andrianov wrote: This series adds dts nodes for Keystone2 hw_rng driver Vitaly Andrianov (3): ARM: dts: k2hk: add dts node for k2hk hw_rng driver ARM: dts: k2l: add dts node for k2l hw_rng driver ARM: dts: k2e: add dts node for k2e hw_rng driver Looks good.

Re: [PATCH 0/3] Dts nodes for Keystone2 hw_rng driver

2018-05-25 Thread santosh.shilim...@oracle.com
On 5/24/18 6:12 AM, Vitaly Andrianov wrote: This series adds dts nodes for Keystone2 hw_rng driver Vitaly Andrianov (3): ARM: dts: k2hk: add dts node for k2hk hw_rng driver ARM: dts: k2l: add dts node for k2l hw_rng driver ARM: dts: k2e: add dts node for k2e hw_rng driver Looks good.

Re: [linux-next PATCH 0/4] Enable network driver on K2G ICE and GP EVMs

2018-05-20 Thread santosh.shilim...@oracle.com
On 5/11/18 12:29 PM, Murali Karicheri wrote: Now that NetCP driver patches for K2G SoC is merged to linux-next master this series add patches to enable network driver on K2G ICE and GP EVMs. Thanks Applied the patches on top of latest linux-next master, built kernel and booted up on both EVMs.

Re: [linux-next PATCH 0/4] Enable network driver on K2G ICE and GP EVMs

2018-05-20 Thread santosh.shilim...@oracle.com
On 5/11/18 12:29 PM, Murali Karicheri wrote: Now that NetCP driver patches for K2G SoC is merged to linux-next master this series add patches to enable network driver on K2G ICE and GP EVMs. Thanks Applied the patches on top of latest linux-next master, built kernel and booted up on both EVMs.

Re: general protection fault in rds_ib_get_mr

2018-05-13 Thread santosh.shilim...@oracle.com
On 5/13/18 2:10 PM, Eric Biggers wrote: On Wed, Mar 21, 2018 at 09:00:01AM -0700, syzbot wrote: [...] Still reproducible on Linus' tree (commit 66e1c94db3cd4) and linux-next (next-20180511). Here's a simplified reproducer: Thanks for the test case !! Regards, Santosh

Re: general protection fault in rds_ib_get_mr

2018-05-13 Thread santosh.shilim...@oracle.com
On 5/13/18 2:10 PM, Eric Biggers wrote: On Wed, Mar 21, 2018 at 09:00:01AM -0700, syzbot wrote: [...] Still reproducible on Linus' tree (commit 66e1c94db3cd4) and linux-next (next-20180511). Here's a simplified reproducer: Thanks for the test case !! Regards, Santosh

Re: [PATCH 0/3] K2G: mmc: Update mmc dt node to use sdhci-omap

2018-05-04 Thread santosh.shilim...@oracle.com
On 5/4/18 1:06 AM, Kishon Vijay Abraham I wrote: Hi Santosh, On Friday 04 May 2018 12:22 AM, santosh.shilim...@oracle.com wrote: On 5/3/18 4:57 AM, Kishon Vijay Abraham I wrote: Hi Santosh, On Wednesday 25 April 2018 11:10 PM, Santosh Shilimkar wrote: On 4/25/2018 6:27 AM, Kishon Vijay

Re: [PATCH 0/3] K2G: mmc: Update mmc dt node to use sdhci-omap

2018-05-04 Thread santosh.shilim...@oracle.com
On 5/4/18 1:06 AM, Kishon Vijay Abraham I wrote: Hi Santosh, On Friday 04 May 2018 12:22 AM, santosh.shilim...@oracle.com wrote: On 5/3/18 4:57 AM, Kishon Vijay Abraham I wrote: Hi Santosh, On Wednesday 25 April 2018 11:10 PM, Santosh Shilimkar wrote: On 4/25/2018 6:27 AM, Kishon Vijay

Re: [PATCH v2] ARM: dts: k2g-evm: Add DCAN dt nodes

2018-05-04 Thread santosh.shilim...@oracle.com
On 5/3/18 12:28 AM, Faiz Abbas wrote: The 66AK2G evm has support for dcan. Add nodes and pinmuxes for dcan0 and dcan1. Signed-off-by: Faiz Abbas --- Changes since v1: Description updated. Will pick this up. Regards, Santosh

Re: [PATCH v2] ARM: dts: k2g-evm: Add DCAN dt nodes

2018-05-04 Thread santosh.shilim...@oracle.com
On 5/3/18 12:28 AM, Faiz Abbas wrote: The 66AK2G evm has support for dcan. Add nodes and pinmuxes for dcan0 and dcan1. Signed-off-by: Faiz Abbas --- Changes since v1: Description updated. Will pick this up. Regards, Santosh

Re: [PATCH 0/3] K2G: mmc: Update mmc dt node to use sdhci-omap

2018-05-03 Thread santosh.shilim...@oracle.com
On 5/3/18 4:57 AM, Kishon Vijay Abraham I wrote: Hi Santosh, On Wednesday 25 April 2018 11:10 PM, Santosh Shilimkar wrote: On 4/25/2018 6:27 AM, Kishon Vijay Abraham I wrote: Update mmc dt node to use sdhci-omap binding instead of omap_hsmmc binding. I've also updated keystone_defconfig to

Re: [PATCH 0/3] K2G: mmc: Update mmc dt node to use sdhci-omap

2018-05-03 Thread santosh.shilim...@oracle.com
On 5/3/18 4:57 AM, Kishon Vijay Abraham I wrote: Hi Santosh, On Wednesday 25 April 2018 11:10 PM, Santosh Shilimkar wrote: On 4/25/2018 6:27 AM, Kishon Vijay Abraham I wrote: Update mmc dt node to use sdhci-omap binding instead of omap_hsmmc binding. I've also updated keystone_defconfig to

Re: [PATCH v2 0/2] memory: aemif: add support for machine code

2018-04-20 Thread santosh.shilim...@oracle.com
On 4/19/18 8:12 AM, Bartosz Golaszewski wrote: From: Bartosz Golaszewski This is a follow-up to the series that contained both changes to the aemif driver and platform code. It contains only the driver changes. As the first step in removing duplicate support for

Re: [PATCH v2 0/2] memory: aemif: add support for machine code

2018-04-20 Thread santosh.shilim...@oracle.com
On 4/19/18 8:12 AM, Bartosz Golaszewski wrote: From: Bartosz Golaszewski This is a follow-up to the series that contained both changes to the aemif driver and platform code. It contains only the driver changes. As the first step in removing duplicate support for aemif from the kernel we need

Re: [PATCH] soc: ti: knav_qmss: Use percpu instead atomic for stats counter

2018-04-13 Thread santosh.shilim...@oracle.com
On 4/11/18 3:28 PM, santosh.shilim...@oracle.com wrote: On 4/11/18 12:16 PM, Vasyl Gomonovych wrote: Hwqueue has collect statistics in heavy use queue_pop/queu_push functions for cache efficiency and make push/pop faster use percpu variables. For performance reasons, driver should keep

Re: [PATCH] soc: ti: knav_qmss: Use percpu instead atomic for stats counter

2018-04-13 Thread santosh.shilim...@oracle.com
On 4/11/18 3:28 PM, santosh.shilim...@oracle.com wrote: On 4/11/18 12:16 PM, Vasyl Gomonovych wrote: Hwqueue has collect statistics in heavy use queue_pop/queu_push functions for cache efficiency and make push/pop faster use percpu variables. For performance reasons, driver should keep

Re: [PATCH 01/14] memory: ti-emif-sram: Add resume function to recopy sram code

2018-04-12 Thread santosh.shilim...@oracle.com
On 4/11/18 9:53 PM, Keerthy wrote: From: Dave Gerlach After an RTC+DDR cycle we lose sram context so emif pm functions present in sram are lost. We can check if the first byte of the original code in DDR contains the same first byte as the code in sram, and if they do not

Re: [PATCH 01/14] memory: ti-emif-sram: Add resume function to recopy sram code

2018-04-12 Thread santosh.shilim...@oracle.com
On 4/11/18 9:53 PM, Keerthy wrote: From: Dave Gerlach After an RTC+DDR cycle we lose sram context so emif pm functions present in sram are lost. We can check if the first byte of the original code in DDR contains the same first byte as the code in sram, and if they do not match we know we have

Re: [PATCH] soc: ti: knav_qmss: Use percpu instead atomic for stats counter

2018-04-11 Thread santosh.shilim...@oracle.com
On 4/11/18 12:16 PM, Vasyl Gomonovych wrote: Hwqueue has collect statistics in heavy use queue_pop/queu_push functions for cache efficiency and make push/pop faster use percpu variables. For performance reasons, driver should keep descriptor in software handler as short as possible and quickly

Re: [PATCH] soc: ti: knav_qmss: Use percpu instead atomic for stats counter

2018-04-11 Thread santosh.shilim...@oracle.com
On 4/11/18 12:16 PM, Vasyl Gomonovych wrote: Hwqueue has collect statistics in heavy use queue_pop/queu_push functions for cache efficiency and make push/pop faster use percpu variables. For performance reasons, driver should keep descriptor in software handler as short as possible and quickly

Re: [PATCH 2/2] net: rds: drop VLA in rds_walk_conn_path_info()

2018-03-12 Thread santosh.shilim...@oracle.com
On 3/11/18 2:07 PM, Salvatore Mesoraca wrote: Avoid VLA[1] by using an already allocated buffer passed by the caller. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Salvatore Mesoraca <s.mesorac...@gmail.com> --- Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH 2/2] net: rds: drop VLA in rds_walk_conn_path_info()

2018-03-12 Thread santosh.shilim...@oracle.com
On 3/11/18 2:07 PM, Salvatore Mesoraca wrote: Avoid VLA[1] by using an already allocated buffer passed by the caller. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Salvatore Mesoraca --- Acked-by: Santosh Shilimkar

Re: [PATCH 1/2] net: rds: drop VLA in rds_for_each_conn_info()

2018-03-12 Thread santosh.shilim...@oracle.com
limkar <santosh.shilim...@oracle.com>

Re: [PATCH 1/2] net: rds: drop VLA in rds_for_each_conn_info()

2018-03-12 Thread santosh.shilim...@oracle.com
On 3/11/18 2:07 PM, Salvatore Mesoraca wrote: Avoid VLA[1] by using an already allocated buffer passed by the caller. [1] https://lkml.org/lkml/2018/3/7/621 Signed-off-by: Salvatore Mesoraca --- Thanks for both VLA fixes Salvatore. FWIW, Acked-by: Santosh Shilimkar

Re: [PATCH][rds-next] rds: make functions rds_info_from_znotifier and rds_message_zcopy_from_user static

2018-03-12 Thread santosh.shilim...@oracle.com
On 3/11/18 11:54 PM, santosh.shilim...@oracle.com wrote: On 3/11/18 10:03 AM, Colin King wrote: From: Colin Ian King <colin.k...@canonical.com> Functions rds_info_from_znotifier and rds_message_zcopy_from_user are local to the source and do not need to be in global scope, so make them

Re: [PATCH][rds-next] rds: make functions rds_info_from_znotifier and rds_message_zcopy_from_user static

2018-03-12 Thread santosh.shilim...@oracle.com
On 3/11/18 11:54 PM, santosh.shilim...@oracle.com wrote: On 3/11/18 10:03 AM, Colin King wrote: From: Colin Ian King Functions rds_info_from_znotifier and rds_message_zcopy_from_user are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnins

Re: [PATCH][rds-next] rds: make functions rds_info_from_znotifier and rds_message_zcopy_from_user static

2018-03-12 Thread santosh.shilim...@oracle.com
e changed, 4 insertions(+), 2 deletions(-) Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH][rds-next] rds: make functions rds_info_from_znotifier and rds_message_zcopy_from_user static

2018-03-12 Thread santosh.shilim...@oracle.com
On 3/11/18 10:03 AM, Colin King wrote: From: Colin Ian King Functions rds_info_from_znotifier and rds_message_zcopy_from_user are local to the source and do not need to be in global scope, so make them static. Cleans up sparse warnins: net/rds/message.c:70:27: warning: symbol

Re: [PATCH][rds-next] rds: remove redundant variable 'sg_off'

2018-03-12 Thread santosh.shilim...@oracle.com
Signed-off-by: Colin Ian King <colin.k...@canonical.com> --- net/rds/message.c | 2 -- 1 file changed, 2 deletions(-) Thanks Colin !! Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH][rds-next] rds: remove redundant variable 'sg_off'

2018-03-12 Thread santosh.shilim...@oracle.com
On 3/11/18 9:27 AM, Colin King wrote: From: Colin Ian King Variable sg_off is assigned a value but it is never read, hence it is redundant and can be removed. Cleans up clang warning: net/rds/message.c:373:2: warning: Value stored to 'sg_off' is never read Signed-off-by: Colin Ian King ---

Re: [GIT PULL 2/2] SOC: Couple of drivers changes for v4.17

2018-03-07 Thread santosh.shilim...@oracle.com
On 3/7/18 7:50 AM, Arnd Bergmann wrote: On Tue, Mar 6, 2018 at 1:41 AM, Santosh Shilimkar <santosh.shilim...@oracle.com> wrote: The following changes since commit 91ab883eb21325ad80f3473633f794c78ac87f51: Linux 4.16-rc2 (2018-02-18 17:29:42 -0800) are available in the git repo

Re: [GIT PULL 2/2] SOC: Couple of drivers changes for v4.17

2018-03-07 Thread santosh.shilim...@oracle.com
On 3/7/18 7:50 AM, Arnd Bergmann wrote: On Tue, Mar 6, 2018 at 1:41 AM, Santosh Shilimkar wrote: The following changes since commit 91ab883eb21325ad80f3473633f794c78ac87f51: Linux 4.16-rc2 (2018-02-18 17:29:42 -0800) are available in the git repository at:

Re: [PATCH v5 0/4] ARM: OMAP2+: AM33XX/AM43XX: Add suspend-resume support

2018-02-26 Thread santosh.shilim...@oracle.com
On 2/26/18 1:26 PM, Tony Lindgren wrote: * Santosh Shilimkar <santosh.shilim...@oracle.com> [180225 23:36]: Dave Gerlach (4): ARM: OMAP2+: Introduce low-level suspend code for AM33XX ARM: OMAP2+: Introduce low-level suspend code for AM43XX ARM: OMAP2+: pm33xx-core: Add platfor

Re: [PATCH v5 0/4] ARM: OMAP2+: AM33XX/AM43XX: Add suspend-resume support

2018-02-26 Thread santosh.shilim...@oracle.com
On 2/26/18 1:26 PM, Tony Lindgren wrote: * Santosh Shilimkar [180225 23:36]: Dave Gerlach (4): ARM: OMAP2+: Introduce low-level suspend code for AM33XX ARM: OMAP2+: Introduce low-level suspend code for AM43XX ARM: OMAP2+: pm33xx-core: Add platform code needed for PM soc: ti:

Re: BUG: spinlock bad magic (2)

2018-01-30 Thread santosh.shilim...@oracle.com
On 1/30/18 2:28 PM, Eric Biggers wrote: On Mon, Dec 18, 2017 at 06:01:30PM +0100, 'Dmitry Vyukov' via syzkaller-bugs wrote: On Mon, Dec 18, 2017 at 5:46 PM, Santosh Shilimkar <santosh.shilim...@oracle.com> wrote: On 12/18/2017 4:36 AM, syzbot wrote: Hello, syzkaller hit the fol

Re: BUG: spinlock bad magic (2)

2018-01-30 Thread santosh.shilim...@oracle.com
On 1/30/18 2:28 PM, Eric Biggers wrote: On Mon, Dec 18, 2017 at 06:01:30PM +0100, 'Dmitry Vyukov' via syzkaller-bugs wrote: On Mon, Dec 18, 2017 at 5:46 PM, Santosh Shilimkar wrote: On 12/18/2017 4:36 AM, syzbot wrote: Hello, syzkaller hit the following crash on

Re: [GIT PULL 1/3] ARM: Keystone DTS for 4.16

2018-01-05 Thread santosh.shilim...@oracle.com
On 1/4/18 11:12 PM, Olof Johansson wrote: On Wed, Dec 27, 2017 at 06:07:50PM -0800, Santosh Shilimkar wrote: The following changes since commit 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323: Linux 4.15-rc1 (2017-11-26 16:01:47 -0800) are available in the git repository at:

Re: [GIT PULL 1/3] ARM: Keystone DTS for 4.16

2018-01-05 Thread santosh.shilim...@oracle.com
On 1/4/18 11:12 PM, Olof Johansson wrote: On Wed, Dec 27, 2017 at 06:07:50PM -0800, Santosh Shilimkar wrote: The following changes since commit 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323: Linux 4.15-rc1 (2017-11-26 16:01:47 -0800) are available in the git repository at:

Re: KASAN: use-after-free Read in rds_find_bound

2017-12-30 Thread santosh.shilim...@oracle.com
On 12/30/17 1:17 AM, syzbot wrote: Hello, syzkaller hit the following crash on fba961ab29e5ffb055592442808bb0f7962e05da git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached. Unfortunately,

Re: KASAN: use-after-free Read in rds_find_bound

2017-12-30 Thread santosh.shilim...@oracle.com
On 12/30/17 1:17 AM, syzbot wrote: Hello, syzkaller hit the following crash on fba961ab29e5ffb055592442808bb0f7962e05da git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master compiler: gcc (GCC) 7.1.1 20170620 .config is attached Raw console output is attached. Unfortunately,

Re: [PATCH net] RDS: Check cmsg_len before dereferencing CMSG_DATA

2017-12-21 Thread santosh.shilim...@oracle.com
that the cmsg_len is large enough to hold the data to be read, before proceeding further. Reported-by: syzbot <syzkaller-b...@googlegroups.com> Signed-off-by: Avinash Repaka <avinash.rep...@oracle.com> --- Thanks !! Acked-by: Santosh Shilimkar <santosh.shilim...@oracle.com>

Re: [PATCH net] RDS: Check cmsg_len before dereferencing CMSG_DATA

2017-12-21 Thread santosh.shilim...@oracle.com
On 12/21/17 8:17 PM, Avinash Repaka wrote: RDS currently doesn't check if the length of the control message is large enough to hold the required data, before dereferencing the control message data. This results in following crash: BUG: KASAN: stack-out-of-bounds in rds_rdma_bytes

Re: [PATCH] divers/soc/ti: fix max dup length for kstrndup

2017-12-16 Thread santosh.shilim...@oracle.com
On 12/12/17 1:29 AM, Ma Shimiao wrote: If source string longer than max, kstrndup will alloc max+1 space. So, we should make sure the result will not over limit. Signed-off-by: Ma Shimiao --- Applied. Thanks !!

Re: [PATCH] divers/soc/ti: fix max dup length for kstrndup

2017-12-16 Thread santosh.shilim...@oracle.com
On 12/12/17 1:29 AM, Ma Shimiao wrote: If source string longer than max, kstrndup will alloc max+1 space. So, we should make sure the result will not over limit. Signed-off-by: Ma Shimiao --- Applied. Thanks !!

Re: [PATCH V2 0/8] ARM: dts: keystone*: Stage 1 cleanup for W=1

2017-12-16 Thread santosh.shilim...@oracle.com
On 12/16/17 12:40 PM, Nishanth Menon wrote: Hi, The following changes have been done in the updated series: * Updates for couple few typo errors in commit messages * copyrights are now always behind description * rebased to maintainer branch (was previously against master) Rebased to:

Re: [PATCH V2 0/8] ARM: dts: keystone*: Stage 1 cleanup for W=1

2017-12-16 Thread santosh.shilim...@oracle.com
On 12/16/17 12:40 PM, Nishanth Menon wrote: Hi, The following changes have been done in the updated series: * Updates for couple few typo errors in commit messages * copyrights are now always behind description * rebased to maintainer branch (was previously against master) Rebased to:

Re: [PATCH] firmware: ti_sci: Use %zu for size_t print format

2017-12-16 Thread santosh.shilim...@oracle.com
On 12/2/17 2:20 AM, Nishanth Menon wrote: mbox_msg->len is of type size_t and %d is incorrect format. Instead use %zu for handling size_t correctly. Signed-off-by: Nishanth Menon --- Applied to 'for_4.16/drivers-soc' with Lokesh's ack.

Re: [PATCH] firmware: ti_sci: Use %zu for size_t print format

2017-12-16 Thread santosh.shilim...@oracle.com
On 12/2/17 2:20 AM, Nishanth Menon wrote: mbox_msg->len is of type size_t and %d is incorrect format. Instead use %zu for handling size_t correctly. Signed-off-by: Nishanth Menon --- Applied to 'for_4.16/drivers-soc' with Lokesh's ack.

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-16 Thread santosh.shilim...@oracle.com
On 12/16/17 10:24 AM, Joe Perches wrote: On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang wrote: +# Code simplification: +# +except ALLOC_WITH_MULTIPLY ib.c +except PREFER_PR_LEVEL ib_cm.c ib_recv.c ib_send.c

Re: [PATCH v2 4/5] rds: Add runchecks.cfg for net/rds

2017-12-16 Thread santosh.shilim...@oracle.com
On 12/16/17 10:24 AM, Joe Perches wrote: On Sat, 2017-12-16 at 09:45 -0800, Stephen Hemminger wrote: On Sat, 16 Dec 2017 15:42:29 +0100 Knut Omang wrote: +# Code simplification: +# +except ALLOC_WITH_MULTIPLY ib.c +except PREFER_PR_LEVEL ib_cm.c ib_recv.c ib_send.c rdma_transport.c threads.c

Re: [PATCH 07/25] arm: keystone: dts: Remove leading 0x and 0s from bindings notation

2017-12-16 Thread santosh.shilim...@oracle.com
On 12/15/17 4:46 AM, Mathieu Malaterre wrote: Improve the DTS files by removing all the leading "0x" and zeros to fix the following dtc warnings: Warning (unit_address_format): Node /XXX unit name should not have leading "0x" and Warning (unit_address_format): Node /XXX unit name should not

Re: [PATCH 07/25] arm: keystone: dts: Remove leading 0x and 0s from bindings notation

2017-12-16 Thread santosh.shilim...@oracle.com
On 12/15/17 4:46 AM, Mathieu Malaterre wrote: Improve the DTS files by removing all the leading "0x" and zeros to fix the following dtc warnings: Warning (unit_address_format): Node /XXX unit name should not have leading "0x" and Warning (unit_address_format): Node /XXX unit name should not

Re: [PATCH 2/8] ARM: dts: keystone*: Use a single soc0 instance

2017-12-16 Thread santosh.shilim...@oracle.com
On 12/15/17 5:38 AM, Nishanth Menon wrote: Crap.. couple of typos crept in. Apologies - Santosh, if you dont want to manualy change, I can rebase and repost if you like to any branch of your choice. Just post it against for_4.16/keystone-dts

Re: [PATCH 2/8] ARM: dts: keystone*: Use a single soc0 instance

2017-12-16 Thread santosh.shilim...@oracle.com
On 12/15/17 5:38 AM, Nishanth Menon wrote: Crap.. couple of typos crept in. Apologies - Santosh, if you dont want to manualy change, I can rebase and repost if you like to any branch of your choice. Just post it against for_4.16/keystone-dts

Re: [PATCH 0/2] 66AK2G: Add DT entry for UART1 and UART2

2017-12-06 Thread santosh.shilim...@oracle.com
On 12/4/17 10:48 PM, Vignesh R wrote: This series adds DT entry for the remaining two UART instances on 66AK2G SoC. Based on linux-next. Franklin S Cooper Jr (2): ARM: dts: keystone-k2g: Add UART 1 and 2 instances ARM: dts: keystone-k2g-evm: Enable UART 2 Applied !!

Re: [PATCH] memory: ti-emif-sram: remove unused variable

2017-12-06 Thread santosh.shilim...@oracle.com
On 12/6/17 6:13 AM, Arnd Bergmann wrote: The newly introduced driver causes a harmless warning for a variable that was evidently never used: drivers/memory/ti-emif-pm.c: In function 'ti_emif_remove': drivers/memory/ti-emif-pm.c:303:17: error: unused variable 'dev' [-Werror=unused-variable]

Re: [PATCH 0/2] 66AK2G: Add DT entry for UART1 and UART2

2017-12-06 Thread santosh.shilim...@oracle.com
On 12/4/17 10:48 PM, Vignesh R wrote: This series adds DT entry for the remaining two UART instances on 66AK2G SoC. Based on linux-next. Franklin S Cooper Jr (2): ARM: dts: keystone-k2g: Add UART 1 and 2 instances ARM: dts: keystone-k2g-evm: Enable UART 2 Applied !!

Re: [PATCH] memory: ti-emif-sram: remove unused variable

2017-12-06 Thread santosh.shilim...@oracle.com
On 12/6/17 6:13 AM, Arnd Bergmann wrote: The newly introduced driver causes a harmless warning for a variable that was evidently never used: drivers/memory/ti-emif-pm.c: In function 'ti_emif_remove': drivers/memory/ti-emif-pm.c:303:17: error: unused variable 'dev' [-Werror=unused-variable]

Re: [PATCH] ARM: multi_v7_defconfig: Add configs for peripherals on Keystone2 SoCs

2017-12-05 Thread santosh.shilim...@oracle.com
3X etc etc Could please check the complete config and update the patch please ? On linux-next(on which this patch is based on) I see commit: commit f15187dcdbcd8e649948a525153a356b35993655 Author: Santosh Shilimkar <santosh.shilim...@oracle.com> Date: Sat Dec 2 19:53:29 2017 -0800

Re: [PATCH] ARM: multi_v7_defconfig: Add configs for peripherals on Keystone2 SoCs

2017-12-05 Thread santosh.shilim...@oracle.com
On 12/5/17 9:10 AM, Vignesh R wrote: On 05-Dec-17 10:19 PM, Santosh Shilimkar wrote: On 12/5/2017 1:19 AM, Vignesh R wrote: Enable Cadence QSPI present on 66AK2G SoC and Keystone USB PHY driver for K2E. Signed-off-by: Vignesh R --- arch/arm/configs/multi_v7_defconfig | 2 ++ 1 file

Re: [RESEND PATCH 2/4] ARM: dts: keystone: Add generic compatible string for I2C EEPROM

2017-12-03 Thread santosh.shilim...@oracle.com
On 11/24/17 8:27 AM, Javier Martinez Canillas wrote: The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries. But when matching using an

Re: [RESEND PATCH 2/4] ARM: dts: keystone: Add generic compatible string for I2C EEPROM

2017-12-03 Thread santosh.shilim...@oracle.com
On 11/24/17 8:27 AM, Javier Martinez Canillas wrote: The at24 driver allows to register I2C EEPROM chips using different vendor and devices, but the I2C subsystem does not take the vendor into account when matching using the I2C table since it only has device entries. But when matching using an

Re: [PATCH 0/6] 66AK2G: Add DT nodes for few peripherals

2017-12-03 Thread santosh.shilim...@oracle.com
On 11/22/17 11:51 PM, Vignesh R wrote: This patch series adds DT nodes for bunch of peripherials on 66AK2G EVM and 66AK2G ICE boards. Tested on 66AK2G EVM and ICE boards Vignesh R (6): ARM: dts: keystone-k2g: Add QSPI DT entry ARM: dts: keystone-k2g-evm: Fix botched up merge ARM:

Re: [PATCH 0/6] 66AK2G: Add DT nodes for few peripherals

2017-12-03 Thread santosh.shilim...@oracle.com
On 11/22/17 11:51 PM, Vignesh R wrote: This patch series adds DT nodes for bunch of peripherials on 66AK2G EVM and 66AK2G ICE boards. Tested on 66AK2G EVM and ICE boards Vignesh R (6): ARM: dts: keystone-k2g: Add QSPI DT entry ARM: dts: keystone-k2g-evm: Fix botched up merge ARM:

Re: [PATCH v6 0/2] memory: Introduce ti-emif-sram driver

2017-12-03 Thread santosh.shilim...@oracle.com
On 11/30/17 2:56 PM, Dave Gerlach wrote: This is a resend of v5 of this series found here [1]. It introduces relocatable PM handlers for the emif that are copied to sram and run from there during low power mode entry. The patches still have the previous ACKs but have a small change to

Re: [PATCH v6 0/2] memory: Introduce ti-emif-sram driver

2017-12-03 Thread santosh.shilim...@oracle.com
On 11/30/17 2:56 PM, Dave Gerlach wrote: This is a resend of v5 of this series found here [1]. It introduces relocatable PM handlers for the emif that are copied to sram and run from there during low power mode entry. The patches still have the previous ACKs but have a small change to

Re: [PATCH] ARM: dts: keystone-k2l: Add the second gpio bank node

2017-12-02 Thread santosh.shilim...@oracle.com
On 11/13/17 9:12 AM, Santosh Shilimkar wrote: On 11/9/2017 3:42 AM, Keerthy wrote: In case of k2l there are 2 more banks with 16 pins each. Adding the node as the da-vinci driver now supports multiple banks. Signed-off-by: Keerthy --- This is based on linux-next branch.

Re: [PATCH] ARM: dts: keystone-k2l: Add the second gpio bank node

2017-12-02 Thread santosh.shilim...@oracle.com
On 11/13/17 9:12 AM, Santosh Shilimkar wrote: On 11/9/2017 3:42 AM, Keerthy wrote: In case of k2l there are 2 more banks with 16 pins each. Adding the node as the da-vinci driver now supports multiple banks. Signed-off-by: Keerthy --- This is based on linux-next branch. Boot tested on

Re: [PATCH 6/6] ARM: configs: keystone_defconfig: Enable few peripheral drivers

2017-12-02 Thread santosh.shilim...@oracle.com
On 11/22/17 11:51 PM, Vignesh R wrote: Enable drivers for QSPI, LEDS, gpio-decoder that are present on 66AK2G EVM and 66AK2G ICE boards. Signed-off-by: Vignesh R --- Please submit a patch also to enable all these peripherals in multi-v7 config. Just enable all remainder

Re: [PATCH 6/6] ARM: configs: keystone_defconfig: Enable few peripheral drivers

2017-12-02 Thread santosh.shilim...@oracle.com
On 11/22/17 11:51 PM, Vignesh R wrote: Enable drivers for QSPI, LEDS, gpio-decoder that are present on 66AK2G EVM and 66AK2G ICE boards. Signed-off-by: Vignesh R --- Please submit a patch also to enable all these peripherals in multi-v7 config. Just enable all remainder options enabled in

Re: linux-next: build failure after merge of the keystone tree

2017-10-22 Thread santosh.shilim...@oracle.com
On 10/10/17 12:19 AM, Mark Brown wrote: Hi Santosh, After merging the keystone tree, today's linux-next build (multi_v7_defconfig) failed like this: DTC arch/arm/boot/dts/keystone-k2g-evm.dtb Error: /home/broonie/tmpfs/next/arch/arm/boot/dts/keystone-k2g-evm.dts:150.1-15 syntax error

Re: linux-next: build failure after merge of the keystone tree

2017-10-22 Thread santosh.shilim...@oracle.com
On 10/10/17 12:19 AM, Mark Brown wrote: Hi Santosh, After merging the keystone tree, today's linux-next build (multi_v7_defconfig) failed like this: DTC arch/arm/boot/dts/keystone-k2g-evm.dtb Error: /home/broonie/tmpfs/next/arch/arm/boot/dts/keystone-k2g-evm.dts:150.1-15 syntax error

Re: [RESEND PATCH] gpio: omap: Fix lost edge interrupts

2017-10-07 Thread santosh.shilim...@oracle.com
On 10/7/17 4:18 AM, Linus Walleij wrote: On Tue, Oct 3, 2017 at 6:17 PM, Grygorii Strashko wrote: Now acking of edge irqs happens the following way: - omap_gpio_irq_handler - "isr" = read irq status - omap_clear_gpio_irqbank(bank, isr_saved & ~level_mask);

Re: [RESEND PATCH] gpio: omap: Fix lost edge interrupts

2017-10-07 Thread santosh.shilim...@oracle.com
On 10/7/17 4:18 AM, Linus Walleij wrote: On Tue, Oct 3, 2017 at 6:17 PM, Grygorii Strashko wrote: Now acking of edge irqs happens the following way: - omap_gpio_irq_handler - "isr" = read irq status - omap_clear_gpio_irqbank(bank, isr_saved & ~level_mask); ^ clear edge status,

  1   2   3   >