在 2021/4/2 18:34, Christophe Leroy 写道:
Le 02/04/2021 à 11:55, Meng Yu a écrit :
This function declaration has been added in 'ecc_curve.h',
delete it in 'crypto/ecc.h'.
Fixes: 14bb76768275(crypto: ecc - expose ecc curves)
Fixes tag is wrong I think, should be 4e6602916bc6
Yes, you are
在 2021/4/2 18:22, Herbert Xu 写道:
On Fri, Apr 02, 2021 at 06:16:16PM +0800, yumeng wrote:
I think it is not a real bug, and soft fallback setkey can always catch the
error.
But our original intention was to make it don't go to 'xxx_set_pub_key'
when the key is null, and i
在 2021/4/2 15:12, Herbert Xu 写道:
On Fri, Mar 26, 2021 at 02:13:32PM +0800, Meng Yu wrote:
We should ensure key is not empty before we set key.
Signed-off-by: Meng Yu
---
drivers/crypto/hisilicon/hpre/hpre_crypto.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/crypto/h
Thanks, there is a similar patch to yours that was sent in advance:
https://www.spinics.net/lists/linux-crypto/msg54238.html
在 2021/3/26 15:16, Zhang Jianhua 写道:
If CRYPTO_DEV_HISI_HPRE=y, the following errors will be seen while
building hpre_crypto.c
drivers/crypto/hisilicon/hpre/hpre_crypto.o
在 2021/3/1 21:11, Mimi Zohar 写道:
On Sat, 2021-02-27 at 11:35 +0800, yumeng wrote:
在 2021/2/26 0:08, Stefan Berger 写道:
From: Stefan Berger
diff --git a/certs/Makefile b/certs/Makefile
index 3fe6b73786fa..c487d7021c54 100644
--- a/certs/Makefile
+++ b/certs/Makefile
@@ -69,6 +69,18
在 2021/2/26 0:08, Stefan Berger 写道:
From: Stefan Berger
diff --git a/certs/Makefile b/certs/Makefile
index 3fe6b73786fa..c487d7021c54 100644
--- a/certs/Makefile
+++ b/certs/Makefile
@@ -69,6 +69,18 @@ else
SIGNER = -signkey $(obj)/signing_key.key
endif # CONFIG_IMA_APPRAISE_MODSIG
在 2021/2/24 18:15, tudor.amba...@microchip.com 写道:
On 2/24/21 3:29 AM, yumeng wrote:
EXTERNAL EMAIL: Do not click links or open attachments unless you know the
content is safe
在 2021/2/23 18:44, tudor.amba...@microchip.com 写道:
Hi,
On 2/23/21 9:10 AM, Meng Yu wrote:
--- a/drivers/crypto
在 2021/2/23 18:44, tudor.amba...@microchip.com 写道:
Hi,
On 2/23/21 9:10 AM, Meng Yu wrote:
--- a/drivers/crypto/atmel-ecc.c
+++ b/drivers/crypto/atmel-ecc.c
@@ -104,7 +104,7 @@ static int atmel_ecdh_set_secret(struct crypto_kpp *tfm,
const void *buf,
return -EINVAL;
在 2021/2/23 18:44, tudor.amba...@microchip.com 写道:
Hi,
On 2/23/21 9:10 AM, Meng Yu wrote:
--- a/drivers/crypto/atmel-ecc.c
+++ b/drivers/crypto/atmel-ecc.c
@@ -104,7 +104,7 @@ static int atmel_ecdh_set_secret(struct crypto_kpp *tfm,
const void *buf,
return -EINVAL;
在 2021/2/19 4:01, Herbert Xu 写道:
On Thu, Feb 18, 2021 at 10:24:40AM +0800, yumeng wrote:
Ecdh-nist-p384 is supported by HPRE now, currently there is no patch of
the generic ecdh-nist-p384.
In that case please leave it out until there is:
1) An in-kernel user of p384.
2) There is a
在 2021/2/10 12:57, Herbert Xu 写道:
On Mon, Feb 08, 2021 at 05:38:55PM +0800, Meng Yu wrote:
1. Enable 'ECDH' algorithm in Kunpeng 930;
2. HPRE ECDH Support: ecdh-nist-p192, ecdh-nist-p224,
ecdh-nist-p256, ecdh-nist-p384, ecdh-nist-p521.
Where is the patch that adds the generic ecdh-nist-
在 2021/2/10 12:56, Herbert Xu 写道:
On Mon, Feb 08, 2021 at 05:38:51PM +0800, Meng Yu wrote:
As curve id of ECDH will be moved from its key into algorithm name,
we cannot use 'curve_id' in 'struct ecdh', so we should modify ECDH
driver in atmel, and make ECDH algorithm name be the same as crypt
在 2021/2/1 7:32, Stefan Berger 写道:
+/**
+ * ecc_get_curve() - Get a curve given its curve_id
+ *
+ * @curve_id: Id of the curve
+ *
+ * Returns pointer to the curve data, NULL if curve is not available
+ */
+const struct ecc_curve *ecc_get_curve(unsigned int curve_id);
+
/**
* ecc_is_ke
在 2021/1/28 13:03, Herbert Xu 写道:
On Fri, Jan 22, 2021 at 03:09:52PM +0800, Meng Yu wrote:
1. Add ecc curves(P224, P384, P521) for ECDH;
OK I think this is getting unwieldy.
In light of the fact that we already have hardware that supports
a specific subset of curves, I think perhaps it wou
在 2021/1/3 5:29, Herbert Xu 写道:
On Thu, Dec 24, 2020 at 02:08:25PM +0800, Meng Yu wrote:
Move elliptic curves definition to 'include/crypto/ecc_curve_defs.h',
so all can use it,
Signed-off-by: Meng Yu
Reviewed-by: Zaibo Xu
---
crypto/ecc.c| 1 -
crypto/ecc.h
在 2020/12/17 4:10, Stephan Mueller 写道:
Am Mittwoch, dem 16.12.2020 um 10:39 +0800 schrieb yumeng:
Am Freitag, den 11.12.2020, 14:30 +0800 schrieb Meng Yu:
+/* size in bytes of the n prime */
+#define HPRE_ECC_NIST_P128_N_SIZE 16
Do we truly need P-128? Besides, I do not see that
Am Freitag, den 11.12.2020, 14:30 +0800 schrieb Meng Yu:
+/* curve25519 */
+static u64 curve25519_g_x[] = { 0x0009, 0x,
+ 0x, 0x };
+static u64 curve25519_p[] = { 0xffed, 0x
Am Freitag, den 11.12.2020, 14:30 +0800 schrieb Meng Yu:
+/* size in bytes of the n prime */
+#define HPRE_ECC_NIST_P128_N_SIZE 16
Do we truly need P-128? Besides, I do not see that curve being defined in
contemporary cipher specs.
+#define HPRE_ECC_NIST_P192_N_SIZE 24
+#defin
Meng,
It looks like not just definitions but some static data is moved to
includes. Why?
Thanks,
Yes, as both 'crypto' and HPRE use elliptic curves parameters, once
we keep them in 'include/crypto/ecc_curve_defs.h', crypto drivers
can use curves parameters without redefining them.
Thanks,
Ok, I think I can make a patch to keep them at "include/crypto" .
-邮件原件-
发件人: Stephan Mueller [mailto:smuel...@chronox.de]
发送时间: 2020年11月19日 4:25
收件人: yumeng (J) ; herb...@gondor.apana.org.au;
da...@davemloft.net
抄送: linux-cry...@vger.kernel.org; Xu Zaibo ; Wangzhou (B)
; li
Adjust some tiny coding problems and fix a bug of DH algorithm.
Changes since v1:
Remove 'u64' cast in 'cpu_to_le64';
Meng Yu (3):
crypto: hisilicon/hpre - remove useless code
crypto: hisilicon/hpre - adjust some coding style
crypto: hisilicon/hpre - fix a bug in dh algorithm
drivers/cryp
From: Meng Yu
1. Remove unused member 'debug_root' in 'struct hpre_debug';
2. The u64 cast is redundant in 'cpu_to_le64'.
Fixes: 848974151618("crypto: hisilicon - Add debugfs for HPRE")
Fixes: dadbe4c11753("crypto: hisilicon/hpre - update debugfs ...")
Signed-off-by: Meng Yu
Reviewed-by: Zaibo
From: Meng Yu
Using 'g' not equal to 2 in dh algorithm may cause an error like this:
arm-smmu-v3 arm-smmu-v3.1.auto: event 0x10 received:
dh: Party A: generate public key test failed. err -22
11375.065672] dh alg: dh: test failed on vector 1, err=-22
arm-smmu-v3 arm-smmu-v3.1.auto: 0x79
From: Meng Yu
Adjust some coding style to make code aligned.
Signed-off-by: Meng Yu
Reviewed-by: Zaibo Xu
---
drivers/crypto/hisilicon/hpre/hpre_crypto.c | 13 +
1 file changed, 5 insertions(+), 8 deletions(-)
diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c
b/drivers/cr
Yes, 'u64' is redundant, I will resend one!
Thank you!
On 2020/9/18 15:11, Herbert Xu wrote:
On Thu, Sep 10, 2020 at 07:25:22PM +0800, Meng Yu wrote:
diff --git a/drivers/crypto/hisilicon/hpre/hpre_crypto.c
b/drivers/crypto/hisilicon/hpre/hpre_crypto.c
index 0cbe99a1
25 matches
Mail list logo
