Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-07 Thread Myklebust, Trond
On Wed, 2013-08-07 at 22:01 +0100, Nix wrote: > On 7 Aug 2013, Trond Myklebust said: > > > On Wed, 2013-08-07 at 11:18 +0100, Nix wrote: > >> On 6 Aug 2013, Trond Myklebust verbalised: > >> > True. How about something like the following instead. Note the change to > >> > the original patch... >

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-07 Thread Nix
On 7 Aug 2013, Trond Myklebust said: > On Wed, 2013-08-07 at 11:18 +0100, Nix wrote: >> On 6 Aug 2013, Trond Myklebust verbalised: >> > True. How about something like the following instead. Note the change to >> > the original patch... >> >> Well, with those applied I could reboot without a

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-07 Thread Myklebust, Trond
On Wed, 2013-08-07 at 11:18 +0100, Nix wrote: > On 6 Aug 2013, Trond Myklebust verbalised: > > True. How about something like the following instead. Note the change to > > the original patch... > > Well, with those applied I could reboot without a panic for the first > time since 3.8.x: looking

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-07 Thread Nix
On 6 Aug 2013, Trond Myklebust verbalised: > True. How about something like the following instead. Note the change to > the original patch... Well, with those applied I could reboot without a panic for the first time since 3.8.x: looking good. I'll give it a reboot or two with a system that's not

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-07 Thread Nix
On 6 Aug 2013, Trond Myklebust verbalised: True. How about something like the following instead. Note the change to the original patch... Well, with those applied I could reboot without a panic for the first time since 3.8.x: looking good. I'll give it a reboot or two with a system that's not

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-07 Thread Myklebust, Trond
On Wed, 2013-08-07 at 11:18 +0100, Nix wrote: On 6 Aug 2013, Trond Myklebust verbalised: True. How about something like the following instead. Note the change to the original patch... Well, with those applied I could reboot without a panic for the first time since 3.8.x: looking good.

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-07 Thread Nix
On 7 Aug 2013, Trond Myklebust said: On Wed, 2013-08-07 at 11:18 +0100, Nix wrote: On 6 Aug 2013, Trond Myklebust verbalised: True. How about something like the following instead. Note the change to the original patch... Well, with those applied I could reboot without a panic for the

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-07 Thread Myklebust, Trond
On Wed, 2013-08-07 at 22:01 +0100, Nix wrote: On 7 Aug 2013, Trond Myklebust said: On Wed, 2013-08-07 at 11:18 +0100, Nix wrote: On 6 Aug 2013, Trond Myklebust verbalised: True. How about something like the following instead. Note the change to the original patch... Well, with

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-06 Thread Nix
On 5 Aug 2013, Trond Myklebust uttered the following: > Yes. This scheme will only work if we make sure that host->h_rpcclnt is > initialised at mount time. Here is a v2 patch that should do the right > thing. Confirmed, that fixes it! I'll try your shutdown crash fix next. -- NULL && (void) --

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-06 Thread Jeff Layton
On Tue, 6 Aug 2013 02:21:35 + "Myklebust, Trond" wrote: > On Mon, 2013-08-05 at 14:33 -0400, Jeff Layton wrote: > > On Mon, 5 Aug 2013 18:18:03 + > > "Myklebust, Trond" wrote: > > > > > On Mon, 2013-08-05 at 13:37 -0400, Jeff Layton wrote: > > > > On Mon, 5 Aug 2013 16:15:01 + > >

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-06 Thread Jeff Layton
On Tue, 6 Aug 2013 02:21:35 + Myklebust, Trond trond.mykleb...@netapp.com wrote: On Mon, 2013-08-05 at 14:33 -0400, Jeff Layton wrote: On Mon, 5 Aug 2013 18:18:03 + Myklebust, Trond trond.mykleb...@netapp.com wrote: On Mon, 2013-08-05 at 13:37 -0400, Jeff Layton wrote: On

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-06 Thread Nix
On 5 Aug 2013, Trond Myklebust uttered the following: Yes. This scheme will only work if we make sure that host-h_rpcclnt is initialised at mount time. Here is a v2 patch that should do the right thing. Confirmed, that fixes it! I'll try your shutdown crash fix next. -- NULL (void) -- To

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 14:33 -0400, Jeff Layton wrote: > On Mon, 5 Aug 2013 18:18:03 + > "Myklebust, Trond" wrote: > > > On Mon, 2013-08-05 at 13:37 -0400, Jeff Layton wrote: > > > On Mon, 5 Aug 2013 16:15:01 + > > > "Myklebust, Trond" wrote: > > > > > > > From

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 19:33 +0100, Nix wrote: > On 5 Aug 2013, Trond Myklebust told this: > > Does the attached patch fix the problem? > > > From 3c50ba80105464a28d456d9a1e0f1d81d4af92a8 Mon Sep 17 00:00:00 2001 > > From: Trond Myklebust > > Date: Mon, 5 Aug 2013 12:06:12 -0400 > > Subject:

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Jeff Layton
On Mon, 5 Aug 2013 18:18:03 + "Myklebust, Trond" wrote: > On Mon, 2013-08-05 at 13:37 -0400, Jeff Layton wrote: > > On Mon, 5 Aug 2013 16:15:01 + > > "Myklebust, Trond" wrote: > > > > > From 3c50ba80105464a28d456d9a1e0f1d81d4af92a8 Mon Sep 17 00:00:00 2001 > > > From: Trond Myklebust

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Nix
On 5 Aug 2013, Trond Myklebust told this: > Does the attached patch fix the problem? > From 3c50ba80105464a28d456d9a1e0f1d81d4af92a8 Mon Sep 17 00:00:00 2001 > From: Trond Myklebust > Date: Mon, 5 Aug 2013 12:06:12 -0400 > Subject: [PATCH] LOCKD: Don't call utsname()->nodename from >

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 13:37 -0400, Jeff Layton wrote: > On Mon, 5 Aug 2013 16:15:01 + > "Myklebust, Trond" wrote: > > > From 3c50ba80105464a28d456d9a1e0f1d81d4af92a8 Mon Sep 17 00:00:00 2001 > > From: Trond Myklebust > > Date: Mon, 5 Aug 2013 12:06:12 -0400 > > Subject: [PATCH] LOCKD: Don't

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Jeff Layton
On Mon, 5 Aug 2013 16:15:01 + "Myklebust, Trond" wrote: > From 3c50ba80105464a28d456d9a1e0f1d81d4af92a8 Mon Sep 17 00:00:00 2001 > From: Trond Myklebust > Date: Mon, 5 Aug 2013 12:06:12 -0400 > Subject: [PATCH] LOCKD: Don't call utsname()->nodename from > nlmclnt_setlockargs >

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Jeff Layton
On Mon, 05 Aug 2013 16:50:37 +0100 Nix wrote: > On 5 Aug 2013, Jeff Layton said: > > > On Mon, 5 Aug 2013 11:04:27 -0400 > > Jeff Layton wrote: > > > >> On Mon, 05 Aug 2013 15:48:01 +0100 > >> Nix wrote: > >> > >> > On 5 Aug 2013, Jeff Layton stated: > >> > > >> > > On Sun, 04 Aug 2013

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 16:50 +0100, Nix wrote: > On 5 Aug 2013, Jeff Layton said: > > > On Mon, 5 Aug 2013 11:04:27 -0400 > > Jeff Layton wrote: > > > >> On Mon, 05 Aug 2013 15:48:01 +0100 > >> Nix wrote: > >> > >> > On 5 Aug 2013, Jeff Layton stated: > >> > > >> > > On Sun, 04 Aug 2013

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Nix
On 5 Aug 2013, Jeff Layton said: > On Mon, 5 Aug 2013 11:04:27 -0400 > Jeff Layton wrote: > >> On Mon, 05 Aug 2013 15:48:01 +0100 >> Nix wrote: >> >> > On 5 Aug 2013, Jeff Layton stated: >> > >> > > On Sun, 04 Aug 2013 16:40:58 +0100 >> > > Nix wrote: >> > > >> > >> I just got this panic on

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Jeff Layton
On Mon, 5 Aug 2013 11:04:27 -0400 Jeff Layton wrote: > On Mon, 05 Aug 2013 15:48:01 +0100 > Nix wrote: > > > On 5 Aug 2013, Jeff Layton stated: > > > > > On Sun, 04 Aug 2013 16:40:58 +0100 > > > Nix wrote: > > > > > >> I just got this panic on 3.10.4, in the middle of a large parallel > > >>

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Jeff Layton
On Mon, 05 Aug 2013 15:48:01 +0100 Nix wrote: > On 5 Aug 2013, Jeff Layton stated: > > > On Sun, 04 Aug 2013 16:40:58 +0100 > > Nix wrote: > > > >> I just got this panic on 3.10.4, in the middle of a large parallel > >> compilation (of Chromium, as it happens) over NFSv3: > >> > >>

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Nix
On 5 Aug 2013, Jeff Layton stated: > On Sun, 04 Aug 2013 16:40:58 +0100 > Nix wrote: > >> I just got this panic on 3.10.4, in the middle of a large parallel >> compilation (of Chromium, as it happens) over NFSv3: >> >> [16364.527516] BUG: unable to handle kernel NULL pointer dereference at >>

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Jeff Layton
On Sun, 04 Aug 2013 16:40:58 +0100 Nix wrote: > I just got this panic on 3.10.4, in the middle of a large parallel > compilation (of Chromium, as it happens) over NFSv3: > > [16364.527516] BUG: unable to handle kernel NULL pointer dereference at > 0008 > [16364.527571] IP: []

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Jeff Layton
On Sun, 04 Aug 2013 16:40:58 +0100 Nix n...@esperi.org.uk wrote: I just got this panic on 3.10.4, in the middle of a large parallel compilation (of Chromium, as it happens) over NFSv3: [16364.527516] BUG: unable to handle kernel NULL pointer dereference at 0008 [16364.527571]

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Nix
On 5 Aug 2013, Jeff Layton stated: On Sun, 04 Aug 2013 16:40:58 +0100 Nix n...@esperi.org.uk wrote: I just got this panic on 3.10.4, in the middle of a large parallel compilation (of Chromium, as it happens) over NFSv3: [16364.527516] BUG: unable to handle kernel NULL pointer dereference

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Jeff Layton
On Mon, 05 Aug 2013 15:48:01 +0100 Nix n...@esperi.org.uk wrote: On 5 Aug 2013, Jeff Layton stated: On Sun, 04 Aug 2013 16:40:58 +0100 Nix n...@esperi.org.uk wrote: I just got this panic on 3.10.4, in the middle of a large parallel compilation (of Chromium, as it happens) over NFSv3:

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Jeff Layton
On Mon, 5 Aug 2013 11:04:27 -0400 Jeff Layton jlay...@redhat.com wrote: On Mon, 05 Aug 2013 15:48:01 +0100 Nix n...@esperi.org.uk wrote: On 5 Aug 2013, Jeff Layton stated: On Sun, 04 Aug 2013 16:40:58 +0100 Nix n...@esperi.org.uk wrote: I just got this panic on 3.10.4, in the

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Nix
On 5 Aug 2013, Jeff Layton said: On Mon, 5 Aug 2013 11:04:27 -0400 Jeff Layton jlay...@redhat.com wrote: On Mon, 05 Aug 2013 15:48:01 +0100 Nix n...@esperi.org.uk wrote: On 5 Aug 2013, Jeff Layton stated: On Sun, 04 Aug 2013 16:40:58 +0100 Nix n...@esperi.org.uk wrote: I

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 16:50 +0100, Nix wrote: On 5 Aug 2013, Jeff Layton said: On Mon, 5 Aug 2013 11:04:27 -0400 Jeff Layton jlay...@redhat.com wrote: On Mon, 05 Aug 2013 15:48:01 +0100 Nix n...@esperi.org.uk wrote: On 5 Aug 2013, Jeff Layton stated: On Sun, 04 Aug 2013

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Jeff Layton
On Mon, 05 Aug 2013 16:50:37 +0100 Nix n...@esperi.org.uk wrote: On 5 Aug 2013, Jeff Layton said: On Mon, 5 Aug 2013 11:04:27 -0400 Jeff Layton jlay...@redhat.com wrote: On Mon, 05 Aug 2013 15:48:01 +0100 Nix n...@esperi.org.uk wrote: On 5 Aug 2013, Jeff Layton stated:

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Jeff Layton
On Mon, 5 Aug 2013 16:15:01 + Myklebust, Trond trond.mykleb...@netapp.com wrote: From 3c50ba80105464a28d456d9a1e0f1d81d4af92a8 Mon Sep 17 00:00:00 2001 From: Trond Myklebust trond.mykleb...@netapp.com Date: Mon, 5 Aug 2013 12:06:12 -0400 Subject: [PATCH] LOCKD: Don't call

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 13:37 -0400, Jeff Layton wrote: On Mon, 5 Aug 2013 16:15:01 + Myklebust, Trond trond.mykleb...@netapp.com wrote: From 3c50ba80105464a28d456d9a1e0f1d81d4af92a8 Mon Sep 17 00:00:00 2001 From: Trond Myklebust trond.mykleb...@netapp.com Date: Mon, 5 Aug 2013

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Nix
On 5 Aug 2013, Trond Myklebust told this: Does the attached patch fix the problem? From 3c50ba80105464a28d456d9a1e0f1d81d4af92a8 Mon Sep 17 00:00:00 2001 From: Trond Myklebust trond.mykleb...@netapp.com Date: Mon, 5 Aug 2013 12:06:12 -0400 Subject: [PATCH] LOCKD: Don't call

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Jeff Layton
On Mon, 5 Aug 2013 18:18:03 + Myklebust, Trond trond.mykleb...@netapp.com wrote: On Mon, 2013-08-05 at 13:37 -0400, Jeff Layton wrote: On Mon, 5 Aug 2013 16:15:01 + Myklebust, Trond trond.mykleb...@netapp.com wrote: From 3c50ba80105464a28d456d9a1e0f1d81d4af92a8 Mon Sep 17

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 19:33 +0100, Nix wrote: On 5 Aug 2013, Trond Myklebust told this: Does the attached patch fix the problem? From 3c50ba80105464a28d456d9a1e0f1d81d4af92a8 Mon Sep 17 00:00:00 2001 From: Trond Myklebust trond.mykleb...@netapp.com Date: Mon, 5 Aug 2013 12:06:12 -0400

Re: [3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-05 Thread Myklebust, Trond
On Mon, 2013-08-05 at 14:33 -0400, Jeff Layton wrote: On Mon, 5 Aug 2013 18:18:03 + Myklebust, Trond trond.mykleb...@netapp.com wrote: On Mon, 2013-08-05 at 13:37 -0400, Jeff Layton wrote: On Mon, 5 Aug 2013 16:15:01 + Myklebust, Trond trond.mykleb...@netapp.com wrote:

[3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-04 Thread Nix
I just got this panic on 3.10.4, in the middle of a large parallel compilation (of Chromium, as it happens) over NFSv3: [16364.527516] BUG: unable to handle kernel NULL pointer dereference at 0008 [16364.527571] IP: [] nlmclnt_setlockargs+0x55/0xcf [16364.527611] PGD 0

[3.10.4] NFS locking panic, plus persisting NFS shutdown panic from 3.9.*

2013-08-04 Thread Nix
I just got this panic on 3.10.4, in the middle of a large parallel compilation (of Chromium, as it happens) over NFSv3: [16364.527516] BUG: unable to handle kernel NULL pointer dereference at 0008 [16364.527571] IP: [81245157] nlmclnt_setlockargs+0x55/0xcf [16364.527611] PGD