Re: [BUG] perf report/annotate: consuming too many file descriptors

2014-02-17 Thread Stephane Eranian
Hi, On Fri, Feb 14, 2014 at 8:11 AM, Namhyung Kim wrote: > > Hi Stephane, > > On Thu, 13 Feb 2014 17:26:30 +0100, Stephane Eranian wrote: > > Hi, > > > > Your patch does solve the file consumption problem on my test case. > > We still open and do the ELF read 5 times. > >>> The first problem is

Re: [BUG] perf report/annotate: consuming too many file descriptors

2014-02-17 Thread Stephane Eranian
Hi, On Fri, Feb 14, 2014 at 8:11 AM, Namhyung Kim namhy...@kernel.org wrote: Hi Stephane, On Thu, 13 Feb 2014 17:26:30 +0100, Stephane Eranian wrote: Hi, Your patch does solve the file consumption problem on my test case. We still open and do the ELF read 5 times. The first problem

Re: [BUG] perf report/annotate: consuming too many file descriptors

2014-02-13 Thread Namhyung Kim
Hi Stephane, On Thu, 13 Feb 2014 17:26:30 +0100, Stephane Eranian wrote: > Hi, > > Your patch does solve the file consumption problem on my test case. > We still open and do the ELF read 5 times. >>> The first problem is why is dso__read_binary_type_filename() >>> blindly returning success on

Re: [BUG] perf report/annotate: consuming too many file descriptors

2014-02-13 Thread Namhyung Kim
Hi Stephane, On Thu, 13 Feb 2014 17:26:30 +0100, Stephane Eranian wrote: > Hi, > > Your patch does solve the file consumption problem on my test case. > We still open and do the ELF read 5 times. Cool. Could you also confirm what's the problem case - whether it's stripped or static linked? > >

Re: [BUG] perf report/annotate: consuming too many file descriptors

2014-02-13 Thread Stephane Eranian
Hi, Your patch does solve the file consumption problem on my test case. We still open and do the ELF read 5 times. Now, if on top of your patch, we also add the following, we save one open(). diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c index 4045d08..87a0ecb 100644 ---

Re: [BUG] perf report/annotate: consuming too many file descriptors

2014-02-13 Thread Stephane Eranian
Hi, Your patch does solve the file consumption problem on my test case. We still open and do the ELF read 5 times. Now, if on top of your patch, we also add the following, we save one open(). diff --git a/tools/perf/util/dso.c b/tools/perf/util/dso.c index 4045d08..87a0ecb 100644 ---

Re: [BUG] perf report/annotate: consuming too many file descriptors

2014-02-13 Thread Namhyung Kim
Hi Stephane, On Thu, 13 Feb 2014 17:26:30 +0100, Stephane Eranian wrote: Hi, Your patch does solve the file consumption problem on my test case. We still open and do the ELF read 5 times. Cool. Could you also confirm what's the problem case - whether it's stripped or static linked? Now,

Re: [BUG] perf report/annotate: consuming too many file descriptors

2014-02-13 Thread Namhyung Kim
Hi Stephane, On Thu, 13 Feb 2014 17:26:30 +0100, Stephane Eranian wrote: Hi, Your patch does solve the file consumption problem on my test case. We still open and do the ELF read 5 times. The first problem is why is dso__read_binary_type_filename() blindly returning success on many types.

Re: [BUG] perf report/annotate: consuming too many file descriptors

2014-02-12 Thread Namhyung Kim
Hi Stephane, (I'd be better if you use my korg address). 2014-02-12 PM 11:32, Stephane Eranian wrote: Hi, I was testing 3.14-rc2 (tip.git) perf and ran into a serious problem with report/annotate on a collection with lots of shared libraries (500). Perf ran out of file descriptors (ulimit

[BUG] perf report/annotate: consuming too many file descriptors

2014-02-12 Thread Stephane Eranian
Hi, I was testing 3.14-rc2 (tip.git) perf and ran into a serious problem with report/annotate on a collection with lots of shared libraries (500). Perf ran out of file descriptors (ulimit set to 1024). It did not print an error message, but simply refused to proceed to objdump. I ran strace

[BUG] perf report/annotate: consuming too many file descriptors

2014-02-12 Thread Stephane Eranian
Hi, I was testing 3.14-rc2 (tip.git) perf and ran into a serious problem with report/annotate on a collection with lots of shared libraries (500). Perf ran out of file descriptors (ulimit set to 1024). It did not print an error message, but simply refused to proceed to objdump. I ran strace

Re: [BUG] perf report/annotate: consuming too many file descriptors

2014-02-12 Thread Namhyung Kim
Hi Stephane, (I'd be better if you use my korg address). 2014-02-12 PM 11:32, Stephane Eranian wrote: Hi, I was testing 3.14-rc2 (tip.git) perf and ran into a serious problem with report/annotate on a collection with lots of shared libraries (500). Perf ran out of file descriptors (ulimit