Re: [PATCH] [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-23 Thread Kamalesh Babulal
On Fri, Feb 22, 2008 at 11:25:04AM -0800, Randy Dunlap wrote: > Let's see what the ACPI people think about this change. > > Thanks, Sam. > --- > From: Randy Dunlap <[EMAIL PROTECTED]> > > Make ACPI_CUSTOM_DSDT boolean config symbol a hidden and derived > value, based on the value of

Re: [PATCH] [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-23 Thread Kamalesh Babulal
On Fri, Feb 22, 2008 at 11:25:04AM -0800, Randy Dunlap wrote: Let's see what the ACPI people think about this change. Thanks, Sam. --- From: Randy Dunlap [EMAIL PROTECTED] Make ACPI_CUSTOM_DSDT boolean config symbol a hidden and derived value, based on the value of ACPI_CUSTOM_DSDT_FILE

Re: [PATCH] [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Len Brown
works for me! applied. thanks, -len ps. CONFIG_ACPI_CUSTOM_DSDT's only use is to guard the use of CONFIG_ACPI_CUSTOM_DSDT_FILE: #ifdef CONFIG_ACPI_CUSTOM_DSDT #include CONFIG_ACPI_CUSTOM_DSDT_FILE #endif we could get rid of it if cpp could so something like #if (CONFIG_ACPI_CUSTOM_DSDT_FILE

[PATCH] [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Randy Dunlap
Let's see what the ACPI people think about this change. Thanks, Sam. --- From: Randy Dunlap <[EMAIL PROTECTED]> Make ACPI_CUSTOM_DSDT boolean config symbol a hidden and derived value, based on the value of ACPI_CUSTOM_DSDT_FILE (string). Only the latter is presented to the user as a config

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Sam Ravnborg
On Fri, Feb 22, 2008 at 10:29:38AM -0800, Randy Dunlap wrote: > Sam Ravnborg wrote: > >>Is there a way to generate (in Kconfig language) the boolean > >>CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE > >>== "" or != "" ? I tried to muck around with that last night but >

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Randy Dunlap
Sam Ravnborg wrote: Is there a way to generate (in Kconfig language) the boolean CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE == "" or != "" ? I tried to muck around with that last night but couldn't get it to work. I.e., just present the ACPI_CUSTOM_DSDT_FILE config

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Sam Ravnborg
> > Is there a way to generate (in Kconfig language) the boolean > CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE > == "" or != "" ? I tried to muck around with that last night but > couldn't get it to work. I.e., just present the ACPI_CUSTOM_DSDT_FILE > config symbol to

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Nish Aravamudan
On 2/22/08, Randy Dunlap <[EMAIL PROTECTED]> wrote: > On Fri, 22 Feb 2008 19:08:15 +0100 Sam Ravnborg wrote: > > > On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: > > > On 2/21/08, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > > On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Randy Dunlap
On Fri, 22 Feb 2008 19:08:15 +0100 Sam Ravnborg wrote: > On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: > > On 2/21/08, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: > > > > On 2/20/08, Len Brown <[EMAIL

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Nish Aravamudan
On 2/22/08, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: > > On 2/21/08, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > > On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: > > > > On 2/20/08, Len Brown <[EMAIL

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Sam Ravnborg
On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: > On 2/21/08, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: > > > On 2/20/08, Len Brown <[EMAIL PROTECTED]> wrote: > > > > On Saturday 16 February 2008 14:47, Kamalesh

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Sam Ravnborg
On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: On 2/21/08, Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: On 2/20/08, Len Brown [EMAIL PROTECTED] wrote: On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote:

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Nish Aravamudan
On 2/22/08, Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: On 2/21/08, Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: On 2/20/08, Len Brown [EMAIL PROTECTED] wrote:

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Randy Dunlap
On Fri, 22 Feb 2008 19:08:15 +0100 Sam Ravnborg wrote: On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: On 2/21/08, Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: On 2/20/08, Len Brown [EMAIL PROTECTED] wrote:

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Nish Aravamudan
On 2/22/08, Randy Dunlap [EMAIL PROTECTED] wrote: On Fri, 22 Feb 2008 19:08:15 +0100 Sam Ravnborg wrote: On Thu, Feb 21, 2008 at 05:38:52PM -0800, Nish Aravamudan wrote: On 2/21/08, Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote:

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Sam Ravnborg
Is there a way to generate (in Kconfig language) the boolean CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE == or != ? I tried to muck around with that last night but couldn't get it to work. I.e., just present the ACPI_CUSTOM_DSDT_FILE config symbol to the user

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Randy Dunlap
Sam Ravnborg wrote: Is there a way to generate (in Kconfig language) the boolean CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE == or != ? I tried to muck around with that last night but couldn't get it to work. I.e., just present the ACPI_CUSTOM_DSDT_FILE config

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Sam Ravnborg
On Fri, Feb 22, 2008 at 10:29:38AM -0800, Randy Dunlap wrote: Sam Ravnborg wrote: Is there a way to generate (in Kconfig language) the boolean CONFIG_ACPI_CUSTOM_DSDT based on whether CONFIG_ACPI_CUSTOM_DSDT_FILE == or != ? I tried to muck around with that last night but couldn't get it to

[PATCH] [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Randy Dunlap
Let's see what the ACPI people think about this change. Thanks, Sam. --- From: Randy Dunlap [EMAIL PROTECTED] Make ACPI_CUSTOM_DSDT boolean config symbol a hidden and derived value, based on the value of ACPI_CUSTOM_DSDT_FILE (string). Only the latter is presented to the user as a config option.

Re: [PATCH] [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-22 Thread Len Brown
works for me! applied. thanks, -len ps. CONFIG_ACPI_CUSTOM_DSDT's only use is to guard the use of CONFIG_ACPI_CUSTOM_DSDT_FILE: #ifdef CONFIG_ACPI_CUSTOM_DSDT #include CONFIG_ACPI_CUSTOM_DSDT_FILE #endif we could get rid of it if cpp could so something like #if (CONFIG_ACPI_CUSTOM_DSDT_FILE

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-21 Thread Nish Aravamudan
On 2/21/08, Sam Ravnborg <[EMAIL PROTECTED]> wrote: > On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: > > On 2/20/08, Len Brown <[EMAIL PROTECTED]> wrote: > > > On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: > > > > Hi Andrew, > > > > > > > > The

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-21 Thread Nish Aravamudan
On 2/20/08, Len Brown <[EMAIL PROTECTED]> wrote: > On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: > > Hi Andrew, > > > > The 2.6.25-rc2-mm1 kernel with randconfig build option, fails > > to build on x86_64 machine > > > > CC drivers/acpi/osl.o > >

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-21 Thread Nish Aravamudan
On 2/20/08, Len Brown [EMAIL PROTECTED] wrote: On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: Hi Andrew, The 2.6.25-rc2-mm1 kernel with randconfig build option, fails to build on x86_64 machine CC drivers/acpi/osl.o drivers/acpi/osl.c:60:38: error: empty

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-21 Thread Nish Aravamudan
On 2/21/08, Sam Ravnborg [EMAIL PROTECTED] wrote: On Thu, Feb 21, 2008 at 10:54:40AM -0800, Nish Aravamudan wrote: On 2/20/08, Len Brown [EMAIL PROTECTED] wrote: On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: Hi Andrew, The 2.6.25-rc2-mm1 kernel with

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-20 Thread Len Brown
On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: > Hi Andrew, > > The 2.6.25-rc2-mm1 kernel with randconfig build option, fails > to build on x86_64 machine > > CC drivers/acpi/osl.o > drivers/acpi/osl.c:60:38: error: empty filename in #include > drivers/acpi/osl.c: In function

Re: [BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-20 Thread Len Brown
On Saturday 16 February 2008 14:47, Kamalesh Babulal wrote: Hi Andrew, The 2.6.25-rc2-mm1 kernel with randconfig build option, fails to build on x86_64 machine CC drivers/acpi/osl.o drivers/acpi/osl.c:60:38: error: empty filename in #include drivers/acpi/osl.c: In function

[BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-16 Thread Kamalesh Babulal
Hi Andrew, The 2.6.25-rc2-mm1 kernel with randconfig build option, fails to build on x86_64 machine CC drivers/acpi/osl.o drivers/acpi/osl.c:60:38: error: empty filename in #include drivers/acpi/osl.c: In function ‘acpi_os_table_override’: drivers/acpi/osl.c:399: error: ‘AmlCode’

[BUILD_FAILURE] 2.6.25-rc2-mm1 - Build Failure at acpi_os

2008-02-16 Thread Kamalesh Babulal
Hi Andrew, The 2.6.25-rc2-mm1 kernel with randconfig build option, fails to build on x86_64 machine CC drivers/acpi/osl.o drivers/acpi/osl.c:60:38: error: empty filename in #include drivers/acpi/osl.c: In function ‘acpi_os_table_override’: drivers/acpi/osl.c:399: error: ‘AmlCode’