Re: [GIT PULL] Please pull NFS client changes for 5.11

On Thu, 2020-12-17 at 12:25 -0800, Linus Torvalds wrote: > On Thu, Dec 17, 2020 at 10:05 AM Trond Myklebust > wrote: > > > >   git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs- > > for- > > 5.11-1 > > > > for you to fetch changes up to > >

Re: [GIT PULL] Please pull NFS client changes for 5.11

On Thu, Dec 17, 2020 at 10:05 AM Trond Myklebust wrote: > > git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for- > 5.11-1 > > for you to fetch changes up to > 52104f274e2d7f134d34bab11cada8913d4544e2: pr-tracker-bot doesn't seem to have reacted to this email. I suspect it's

[GIT PULL] Please pull NFS client changes for 5.11

Hi Linus, The following changes since commit 63e2fffa59a9dd91e443b08832656399fd80b7f0: pNFS/flexfiles: Fix array overflow when flexfiles mirroring is enabled (2020-11-30 10:52:22 -0500) are available in the Git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git

Re: [GIT PULL] Please pull NFS client changes

The pull request you sent on Thu, 6 Dec 2018 21:55:54 +: > git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.20-5 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7f80c7325be49db3fb8b5f343f47691b7999fda7 Thank you! -- Deet-doot-dot, I am a

Re: [GIT PULL] Please pull NFS client changes

The pull request you sent on Thu, 6 Dec 2018 21:55:54 +: > git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.20-5 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7f80c7325be49db3fb8b5f343f47691b7999fda7 Thank you! -- Deet-doot-dot, I am a

[GIT PULL] Please pull NFS client changes

Hi Linus, Apologies for the relatively high volume this late in -rc. This is mainly fallout from the updates to the SUNRPC code that is being triggered from less common combinations of NFS mount options. Cheers Trond The following changes since commit 4b78317679c4f3782a3cff0ddb269c1fcfde7621:

[GIT PULL] Please pull NFS client changes

Hi Linus, Apologies for the relatively high volume this late in -rc. This is mainly fallout from the updates to the SUNRPC code that is being triggered from less common combinations of NFS mount options. Cheers Trond The following changes since commit 4b78317679c4f3782a3cff0ddb269c1fcfde7621:

Re: [GIT PULL] Please pull NFS client changes

The pull request you sent on Sun, 25 Nov 2018 03:04:11 +: > git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.20-4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/17c2f540863a6c0faa3f0ede3c785d9427bcaf80 Thank you! -- Deet-doot-dot, I am a

Re: [GIT PULL] Please pull NFS client changes

The pull request you sent on Sun, 25 Nov 2018 03:04:11 +: > git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.20-4 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/17c2f540863a6c0faa3f0ede3c785d9427bcaf80 Thank you! -- Deet-doot-dot, I am a

[GIT PULL] Please pull NFS client changes

Hi Linus, The following changes since commit 9ff01193a20d391e8dbce4403dd5ef87c7eaaca6: Linux 4.20-rc3 (2018-11-18 13:33:44 -0800) are available in the Git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.20-4 for you to fetch changes up to

[GIT PULL] Please pull NFS client changes

Hi Linus, The following changes since commit 9ff01193a20d391e8dbce4403dd5ef87c7eaaca6: Linux 4.20-rc3 (2018-11-18 13:33:44 -0800) are available in the Git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.20-4 for you to fetch changes up to

Re: [GIT PULL] Please pull NFS client changes for Linux 4.20.

On Fri, Oct 26, 2018 at 1:21 PM Trond Myklebust wrote: > > We agreed about a year or so ago to take turns maintaining the linux- > next branches. Heh. That was a simpler pattern than I thought. It was just hidden by the fact that there are sometimes more than one pull request during the merge

Re: [GIT PULL] Please pull NFS client changes for Linux 4.20.

On Fri, Oct 26, 2018 at 1:21 PM Trond Myklebust wrote: > > We agreed about a year or so ago to take turns maintaining the linux- > next branches. Heh. That was a simpler pattern than I thought. It was just hidden by the fact that there are sometimes more than one pull request during the merge

Re: [GIT PULL] Please pull NFS client changes for Linux 4.20.

On Fri, 2018-10-26 at 13:10 -0700, Linus Torvalds wrote: > On Fri, Oct 26, 2018 at 8:45 AM Trond Myklebust < > tron...@hammerspace.com> wrote: > > > > NFS client updates for Linux 4.20 > > Pulled. Thank you! > Btw, just out of curiosity - is there some pattern to when I get the > pull requests

Re: [GIT PULL] Please pull NFS client changes for Linux 4.20.

On Fri, 2018-10-26 at 13:10 -0700, Linus Torvalds wrote: > On Fri, Oct 26, 2018 at 8:45 AM Trond Myklebust < > tron...@hammerspace.com> wrote: > > > > NFS client updates for Linux 4.20 > > Pulled. Thank you! > Btw, just out of curiosity - is there some pattern to when I get the > pull requests

Re: [GIT PULL] Please pull NFS client changes for Linux 4.20.

On Fri, Oct 26, 2018 at 8:45 AM Trond Myklebust wrote: > > NFS client updates for Linux 4.20 Pulled. Btw, just out of curiosity - is there some pattern to when I get the pull requests from you vs Anna? Or is it just "whoever happens to have the baton"? Not that it matters, but I was wondering

Re: [GIT PULL] Please pull NFS client changes for Linux 4.20.

On Fri, Oct 26, 2018 at 8:45 AM Trond Myklebust wrote: > > NFS client updates for Linux 4.20 Pulled. Btw, just out of curiosity - is there some pattern to when I get the pull requests from you vs Anna? Or is it just "whoever happens to have the baton"? Not that it matters, but I was wondering

[GIT PULL] Please pull NFS client changes for Linux 4.20.

Hi Linus, The following changes since commit 17b57b1883c1285f3d0dc2266e8f79286a7bef38: Linux 4.19-rc6 (2018-09-30 07:15:35 -0700) are available in the Git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.20-1 for you to fetch changes up to

[GIT PULL] Please pull NFS client changes for Linux 4.20.

Hi Linus, The following changes since commit 17b57b1883c1285f3d0dc2266e8f79286a7bef38: Linux 4.19-rc6 (2018-09-30 07:15:35 -0700) are available in the Git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.20-1 for you to fetch changes up to

Re: [GIT PULL] Please pull NFS client changes for 4.18

On Wed, Jun 13, 2018 at 11:42:51AM +1000, NeilBrown wrote: > On Tue, Jun 12 2018, Paul E. McKenney wrote: > > > On Tue, Jun 12, 2018 at 06:11:50PM -0700, Linus Torvalds wrote: > >> On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney > >> wrote: > >> > > >> > We did review this one, and Neil did

Re: [GIT PULL] Please pull NFS client changes for 4.18

On Wed, Jun 13, 2018 at 11:42:51AM +1000, NeilBrown wrote: > On Tue, Jun 12 2018, Paul E. McKenney wrote: > > > On Tue, Jun 12, 2018 at 06:11:50PM -0700, Linus Torvalds wrote: > >> On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney > >> wrote: > >> > > >> > We did review this one, and Neil did

Re: [GIT PULL] Please pull NFS client changes for 4.18

On Tue, Jun 12 2018, Paul E. McKenney wrote: > On Tue, Jun 12, 2018 at 06:11:50PM -0700, Linus Torvalds wrote: >> On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney >> wrote: >> > >> > We did review this one, and Neil did make requested changes to the comment >> > header and documentation. >> >>

Re: [GIT PULL] Please pull NFS client changes for 4.18

On Tue, Jun 12 2018, Paul E. McKenney wrote: > On Tue, Jun 12, 2018 at 06:11:50PM -0700, Linus Torvalds wrote: >> On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney >> wrote: >> > >> > We did review this one, and Neil did make requested changes to the comment >> > header and documentation. >> >>

Re: [GIT PULL] Please pull NFS client changes for 4.18

On Tue, Jun 12, 2018 at 06:11:50PM -0700, Linus Torvalds wrote: > On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney > wrote: > > > > We did review this one, and Neil did make requested changes to the comment > > header and documentation. > > Oh, I checked the commit for "acked-by" from you and

Re: [GIT PULL] Please pull NFS client changes for 4.18

On Tue, Jun 12, 2018 at 06:11:50PM -0700, Linus Torvalds wrote: > On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney > wrote: > > > > We did review this one, and Neil did make requested changes to the comment > > header and documentation. > > Oh, I checked the commit for "acked-by" from you and

Re: [GIT PULL] Please pull NFS client changes for 4.18

On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney wrote: > > We did review this one, and Neil did make requested changes to the comment > header and documentation. Oh, I checked the commit for "acked-by" from you and didn't see any, so I was assuming this was just Neil and Trond on their own..

Re: [GIT PULL] Please pull NFS client changes for 4.18

On Tue, Jun 12, 2018 at 6:02 PM Paul E. McKenney wrote: > > We did review this one, and Neil did make requested changes to the comment > header and documentation. Oh, I checked the commit for "acked-by" from you and didn't see any, so I was assuming this was just Neil and Trond on their own..

Re: [GIT PULL] Please pull NFS client changes for 4.18

On Tue, Jun 12, 2018 at 11:08:31AM -0700, Linus Torvalds wrote: > Final note (for now) on this: I've merged the nfs code, but I really > am obviously not happy with these crazy random ad-hoc > cursor-not-cursor list games. We did review this one, and Neil did make requested changes to the comment

Re: [GIT PULL] Please pull NFS client changes for 4.18

On Tue, Jun 12, 2018 at 11:08:31AM -0700, Linus Torvalds wrote: > Final note (for now) on this: I've merged the nfs code, but I really > am obviously not happy with these crazy random ad-hoc > cursor-not-cursor list games. We did review this one, and Neil did make requested changes to the comment

Re: [GIT PULL] Please pull NFS client changes for 4.18

On Tue, Jun 12 2018, Linus Torvalds wrote: > Final note (for now) on this: I've merged the nfs code, but I really > am obviously not happy with these crazy random ad-hoc > cursor-not-cursor list games. > > Linus Hi Linus, thanks for merging the code despite your reservations.

Re: [GIT PULL] Please pull NFS client changes for 4.18

On Tue, Jun 12 2018, Linus Torvalds wrote: > Final note (for now) on this: I've merged the nfs code, but I really > am obviously not happy with these crazy random ad-hoc > cursor-not-cursor list games. > > Linus Hi Linus, thanks for merging the code despite your reservations.

Re: [GIT PULL] Please pull NFS client changes for 4.18

Final note (for now) on this: I've merged the nfs code, but I really am obviously not happy with these crazy random ad-hoc cursor-not-cursor list games. Linus

Re: [GIT PULL] Please pull NFS client changes for 4.18

Final note (for now) on this: I've merged the nfs code, but I really am obviously not happy with these crazy random ad-hoc cursor-not-cursor list games. Linus

Re: [GIT PULL] Please pull NFS client changes for 4.18

On Tue, Jun 12, 2018 at 10:42 AM Linus Torvalds wrote: > > So could we please have a cursor entry for RCU walking, and actually > have a agreed-upon way to do this? Maybe even using the low bit in the > "next" field to mark a cursor entry generically - the same way we > already do for the HEAD

Re: [GIT PULL] Please pull NFS client changes for 4.18

On Tue, Jun 12, 2018 at 10:42 AM Linus Torvalds wrote: > > So could we please have a cursor entry for RCU walking, and actually > have a agreed-upon way to do this? Maybe even using the low bit in the > "next" field to mark a cursor entry generically - the same way we > already do for the HEAD

Re: [GIT PULL] Please pull NFS client changes for 4.18

On Tue, Jun 12, 2018 at 6:39 AM Trond Myklebust wrote: > > NeilBrown (4): > rculist: add list_for_each_entry_from_rcu() Oh christ, people. Not another one of these. We need to start having a real rule in place where people DO NOT PLAY GAMES WITH RCU LISTS. Adding Paul McKenney to the

Re: [GIT PULL] Please pull NFS client changes for 4.18

On Tue, Jun 12, 2018 at 6:39 AM Trond Myklebust wrote: > > NeilBrown (4): > rculist: add list_for_each_entry_from_rcu() Oh christ, people. Not another one of these. We need to start having a real rule in place where people DO NOT PLAY GAMES WITH RCU LISTS. Adding Paul McKenney to the

[GIT PULL] Please pull NFS client changes for 4.18

Hi Linus, The following changes since commit 786b71f5b754273ccef6d9462e52062b3e1f9877: Merge tag 'nds32-for-linus-4.17-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/greentime/linux (2018-05-28 05:25:57 -0700) are available in the Git repository at:

[GIT PULL] Please pull NFS client changes for 4.18

Hi Linus, The following changes since commit 786b71f5b754273ccef6d9462e52062b3e1f9877: Merge tag 'nds32-for-linus-4.17-fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/greentime/linux (2018-05-28 05:25:57 -0700) are available in the Git repository at:

[GIT PULL] Please pull NFS client changes

Hi Linus, The following changes since commit a8750ddca918032d6349adbf9a4b6555e7db20da: Linux 4.15-rc8 (2018-01-14 15:32:30 -0800) are available in the Git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.16-1 for you to fetch changes up to

[GIT PULL] Please pull NFS client changes

Hi Linus, The following changes since commit a8750ddca918032d6349adbf9a4b6555e7db20da: Linux 4.15-rc8 (2018-01-14 15:32:30 -0800) are available in the Git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.16-1 for you to fetch changes up to

[GIT PULL] Please pull NFS client changes

Hi Linus, The following changes since commit 9e66317d3c92ddaab330c125dfe9d06eee268aff: Linux 4.14-rc3 (2017-10-01 14:54:54 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.14-3 for you to fetch changes up to

[GIT PULL] Please pull NFS client changes

Hi Linus, The following changes since commit 9e66317d3c92ddaab330c125dfe9d06eee268aff: Linux 4.14-rc3 (2017-10-01 14:54:54 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.14-3 for you to fetch changes up to

[GIT PULL] Please pull NFS client changes for 4.14

Hi Linus, The following changes since commit ef954844c7ace62f773f4f23e28d2d915adc419f: Linux 4.13-rc5 (2017-08-13 16:01:32 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.14-1 for you to fetch changes up to

[GIT PULL] Please pull NFS client changes for 4.14

Hi Linus, The following changes since commit ef954844c7ace62f773f4f23e28d2d915adc419f: Linux 4.13-rc5 (2017-08-13 16:01:32 -0700) are available in the git repository at: git://git.linux-nfs.org/projects/trondmy/linux-nfs.git tags/nfs-for-4.14-1 for you to fetch changes up to

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Tue, 2017-08-01 at 13:50 -0400, da...@codemonkey.org.uk wrote: > On Tue, Aug 01, 2017 at 10:20:31AM -0700, Linus Torvalds wrote: > > > So I think the 'pathname' part may actually be entirely a red > herring, > > and it's the underlying access itself that just picks up a random > > pointer

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Tue, 2017-08-01 at 13:50 -0400, da...@codemonkey.org.uk wrote: > On Tue, Aug 01, 2017 at 10:20:31AM -0700, Linus Torvalds wrote: > > > So I think the 'pathname' part may actually be entirely a red > herring, > > and it's the underlying access itself that just picks up a random > > pointer

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Tue, Aug 1, 2017 at 10:20 AM, Linus Torvalds wrote: > > So I think the 'pathname' part may actually be entirely a red herring, > and it's the underlying access itself that just picks up a random > pointer from a stack that now contains something different. And

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Tue, Aug 1, 2017 at 10:20 AM, Linus Torvalds wrote: > > So I think the 'pathname' part may actually be entirely a red herring, > and it's the underlying access itself that just picks up a random > pointer from a stack that now contains something different. And KASAN > didn't notice the stale

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Tue, Aug 01, 2017 at 10:20:31AM -0700, Linus Torvalds wrote: > So I think the 'pathname' part may actually be entirely a red herring, > and it's the underlying access itself that just picks up a random > pointer from a stack that now contains something different. And KASAN > didn't notice

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Tue, Aug 01, 2017 at 10:20:31AM -0700, Linus Torvalds wrote: > So I think the 'pathname' part may actually be entirely a red herring, > and it's the underlying access itself that just picks up a random > pointer from a stack that now contains something different. And KASAN > didn't notice

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Tue, 2017-08-01 at 10:20 -0700, Linus Torvalds wrote: > On Tue, Aug 1, 2017 at 8:51 AM, da...@codemonkey.org.uk > wrote: > > On Mon, Jul 31, 2017 at 10:35:45PM -0700, Linus Torvalds wrote: > > > Any chance of getting the output from > > > > > >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Tue, 2017-08-01 at 10:20 -0700, Linus Torvalds wrote: > On Tue, Aug 1, 2017 at 8:51 AM, da...@codemonkey.org.uk > wrote: > > On Mon, Jul 31, 2017 at 10:35:45PM -0700, Linus Torvalds wrote: > > > Any chance of getting the output from > > > > > >./scripts/faddr2line vmlinux > >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Tue, Aug 1, 2017 at 8:51 AM, da...@codemonkey.org.uk wrote: > On Mon, Jul 31, 2017 at 10:35:45PM -0700, Linus Torvalds wrote: > > Any chance of getting the output from > > > >./scripts/faddr2line vmlinux nfs4_exchange_id_done+0x3d7/0x8e0 > > > Hm, that points to

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Tue, Aug 1, 2017 at 8:51 AM, da...@codemonkey.org.uk wrote: > On Mon, Jul 31, 2017 at 10:35:45PM -0700, Linus Torvalds wrote: > > Any chance of getting the output from > > > >./scripts/faddr2line vmlinux nfs4_exchange_id_done+0x3d7/0x8e0 > > > Hm, that points to this.. > > 7463

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Mon, Jul 31, 2017 at 10:35:45PM -0700, Linus Torvalds wrote: > On Mon, Jul 31, 2017 at 8:43 AM, da...@codemonkey.org.uk > wrote: > > Another NFSv4 KASAN splat, this time from rc3. > > > > BUG: KASAN: use-after-free in nfs4_exchange_id_done+0x3d7/0x8e0 [nfsv4] >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Mon, Jul 31, 2017 at 10:35:45PM -0700, Linus Torvalds wrote: > On Mon, Jul 31, 2017 at 8:43 AM, da...@codemonkey.org.uk > wrote: > > Another NFSv4 KASAN splat, this time from rc3. > > > > BUG: KASAN: use-after-free in nfs4_exchange_id_done+0x3d7/0x8e0 [nfsv4] > > Ugh. It's really hard

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Mon, Jul 31, 2017 at 8:43 AM, da...@codemonkey.org.uk wrote: > Another NFSv4 KASAN splat, this time from rc3. > > BUG: KASAN: use-after-free in nfs4_exchange_id_done+0x3d7/0x8e0 [nfsv4] Ugh. It's really hard to tell what access that it - KASAN doesn't actually give

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Mon, Jul 31, 2017 at 8:43 AM, da...@codemonkey.org.uk wrote: > Another NFSv4 KASAN splat, this time from rc3. > > BUG: KASAN: use-after-free in nfs4_exchange_id_done+0x3d7/0x8e0 [nfsv4] Ugh. It's really hard to tell what access that it - KASAN doesn't actually give enough information. There's

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

Another NFSv4 KASAN splat, this time from rc3. == BUG: KASAN: use-after-free in nfs4_exchange_id_done+0x3d7/0x8e0 [nfsv4] Read of size 8 at addr 8804508af528 by task kworker/2:1/34 CPU: 2 PID: 34 Comm: kworker/2:1 Not tainted

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

Another NFSv4 KASAN splat, this time from rc3. == BUG: KASAN: use-after-free in nfs4_exchange_id_done+0x3d7/0x8e0 [nfsv4] Read of size 8 at addr 8804508af528 by task kworker/2:1/34 CPU: 2 PID: 34 Comm: kworker/2:1 Not tainted

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Sun, Jul 16, 2017 at 8:05 PM, da...@codemonkey.org.uk wrote: > On Sun, Jul 16, 2017 at 10:57:27PM +, Trond Myklebust wrote: > > > > BUG: KASAN: global-out-of-bounds in call_start+0x93/0x100 > > > Read of size 8 at addr 8d582588 by task kworker/0:1/22 > >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Sun, Jul 16, 2017 at 8:05 PM, da...@codemonkey.org.uk wrote: > On Sun, Jul 16, 2017 at 10:57:27PM +, Trond Myklebust wrote: > > > > BUG: KASAN: global-out-of-bounds in call_start+0x93/0x100 > > > Read of size 8 at addr 8d582588 by task kworker/0:1/22 > > > > Does the following

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Sun, Jul 16, 2017 at 10:57:27PM +, Trond Myklebust wrote: > > BUG: KASAN: global-out-of-bounds in call_start+0x93/0x100 > > Read of size 8 at addr 8d582588 by task kworker/0:1/22 > > Does the following patch fix it? Yep, seems to do the trick! Dave

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Sun, Jul 16, 2017 at 10:57:27PM +, Trond Myklebust wrote: > > BUG: KASAN: global-out-of-bounds in call_start+0x93/0x100 > > Read of size 8 at addr 8d582588 by task kworker/0:1/22 > > Does the following patch fix it? Yep, seems to do the trick! Dave

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

Hi Dave, On Sun, 2017-07-16 at 17:15 -0400, Dave Jones wrote: > On Fri, Jul 14, 2017 at 10:25:43AM -0400, Dave Jones wrote: > > On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > > > Hi Linus, > > > > > > The following changes since commit >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

Hi Dave, On Sun, 2017-07-16 at 17:15 -0400, Dave Jones wrote: > On Fri, Jul 14, 2017 at 10:25:43AM -0400, Dave Jones wrote: > > On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > > > Hi Linus, > > > > > > The following changes since commit >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Fri, Jul 14, 2017 at 10:25:43AM -0400, Dave Jones wrote: > On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > > Hi Linus, > > > > The following changes since commit > 32c1431eea4881a6b17bd7c639315010aeefa452: > > > > Linux 4.12-rc5 (2017-06-11 16:48:20 -0700) >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Fri, Jul 14, 2017 at 10:25:43AM -0400, Dave Jones wrote: > On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > > Hi Linus, > > > > The following changes since commit > 32c1431eea4881a6b17bd7c639315010aeefa452: > > > > Linux 4.12-rc5 (2017-06-11 16:48:20 -0700) >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

> I find "hardening" code that adds bugs to be particularly bad and > ugly, the same way that I absolutely *hate* debugging code that turns > out to make debugging impossible (we had that with the "better" stack > tracing code that caused kernel panics to kill the machine entirely > rather than

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

> I find "hardening" code that adds bugs to be particularly bad and > ugly, the same way that I absolutely *hate* debugging code that turns > out to make debugging impossible (we had that with the "better" stack > tracing code that caused kernel panics to kill the machine entirely > rather than

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

> The reason q_size isn't used is because it doesn't yet prevent read > overflow. The commit message mentions that among the current > limitations > along with __builtin_object_size(ptr, 1). Er rather, in strlcat, the q_size is unused after the fast path is because strnlen obtains the constant

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

> The reason q_size isn't used is because it doesn't yet prevent read > overflow. The commit message mentions that among the current > limitations > along with __builtin_object_size(ptr, 1). Er rather, in strlcat, the q_size is unused after the fast path is because strnlen obtains the constant

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Fri, 2017-07-14 at 13:50 -0700, Linus Torvalds wrote: > On Fri, Jul 14, 2017 at 1:38 PM, Daniel Micay > wrote: > > > > If strscpy treats the count parameter as a *guarantee* of the dest > > size > > rather than a limit, > > No, it's a *limit*. > > And by a *limit*, I

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Fri, 2017-07-14 at 13:50 -0700, Linus Torvalds wrote: > On Fri, Jul 14, 2017 at 1:38 PM, Daniel Micay > wrote: > > > > If strscpy treats the count parameter as a *guarantee* of the dest > > size > > rather than a limit, > > No, it's a *limit*. > > And by a *limit*, I mean that we know that

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

> My initial patch used strlcpy there, because I wasn't aware of strscpy > before it was suggested: > > http://www.openwall.com/lists/kernel-hardening/2017/05/04/11 > > I was wrong to move it to strscpy. It could be switched back to > strlcpy > again unless the kernel considers the count

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

> My initial patch used strlcpy there, because I wasn't aware of strscpy > before it was suggested: > > http://www.openwall.com/lists/kernel-hardening/2017/05/04/11 > > I was wrong to move it to strscpy. It could be switched back to > strlcpy > again unless the kernel considers the count

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Fri, Jul 14, 2017 at 1:38 PM, Daniel Micay wrote: > > If strscpy treats the count parameter as a *guarantee* of the dest size > rather than a limit, No, it's a *limit*. And by a *limit*, I mean that we know that we can access both source and destination within that

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Fri, Jul 14, 2017 at 1:38 PM, Daniel Micay wrote: > > If strscpy treats the count parameter as a *guarantee* of the dest size > rather than a limit, No, it's a *limit*. And by a *limit*, I mean that we know that we can access both source and destination within that limit. > My initial patch

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Fri, 2017-07-14 at 12:58 -0700, Linus Torvalds wrote: > On Fri, Jul 14, 2017 at 12:43 PM, Andrey Ryabinin > wrote: > > > > > yet when I look at the generated code for __ip_map_lookup, I see > > > > > >movl$32, %edx #, > > >movq%r13, %rsi

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Fri, 2017-07-14 at 12:58 -0700, Linus Torvalds wrote: > On Fri, Jul 14, 2017 at 12:43 PM, Andrey Ryabinin > wrote: > > > > > yet when I look at the generated code for __ip_map_lookup, I see > > > > > >movl$32, %edx #, > > >movq%r13, %rsi # class, > > >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On 07/14/2017 10:58 PM, Linus Torvalds wrote: > On Fri, Jul 14, 2017 at 12:43 PM, Andrey Ryabinin > wrote: >> >>> yet when I look at the generated code for __ip_map_lookup, I see >>> >>>movl$32, %edx #, >>>movq%r13, %rsi # class, >>>

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On 07/14/2017 10:58 PM, Linus Torvalds wrote: > On Fri, Jul 14, 2017 at 12:43 PM, Andrey Ryabinin > wrote: >> >>> yet when I look at the generated code for __ip_map_lookup, I see >>> >>>movl$32, %edx #, >>>movq%r13, %rsi # class, >>>leaq48(%rax),

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Fri, Jul 14, 2017 at 12:43 PM, Andrey Ryabinin wrote: > >> yet when I look at the generated code for __ip_map_lookup, I see >> >>movl$32, %edx #, >>movq%r13, %rsi # class, >>leaq48(%rax), %rdi #, tmp126 >>call

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Fri, Jul 14, 2017 at 12:43 PM, Andrey Ryabinin wrote: > >> yet when I look at the generated code for __ip_map_lookup, I see >> >>movl$32, %edx #, >>movq%r13, %rsi # class, >>leaq48(%rax), %rdi #, tmp126 >>callstrscpy # >> >> what's

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Fri, Jul 14, 2017 at 12:05:02PM -0700, Linus Torvalds wrote: > On Fri, Jul 14, 2017 at 7:25 AM, Dave Jones wrote: > > On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > > > > > > git://git.linux-nfs.org/projects/anna/linux-nfs.git > >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Fri, Jul 14, 2017 at 12:05:02PM -0700, Linus Torvalds wrote: > On Fri, Jul 14, 2017 at 7:25 AM, Dave Jones wrote: > > On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > > > > > > git://git.linux-nfs.org/projects/anna/linux-nfs.git > > tags/nfs-for-4.13-1 > > > >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On 07/14/2017 10:05 PM, Linus Torvalds wrote: > On Fri, Jul 14, 2017 at 7:25 AM, Dave Jones wrote: >> On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: >> > >> > git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-1 >> >> Since this

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On 07/14/2017 10:05 PM, Linus Torvalds wrote: > On Fri, Jul 14, 2017 at 7:25 AM, Dave Jones wrote: >> On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: >> > >> > git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-1 >> >> Since this landed, I'm seeing this

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Fri, Jul 14, 2017 at 7:25 AM, Dave Jones wrote: > On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > > > > git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-1 > > Since this landed, I'm seeing this during boot.. > >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Fri, Jul 14, 2017 at 7:25 AM, Dave Jones wrote: > On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > > > > git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-1 > > Since this landed, I'm seeing this during boot.. > >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Fri, Jul 14, 2017 at 10:25:43AM -0400, Dave Jones wrote: > On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > > Hi Linus, > > > > The following changes since commit > 32c1431eea4881a6b17bd7c639315010aeefa452: > > > > Linux 4.12-rc5 (2017-06-11 16:48:20 -0700) > > > >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Fri, Jul 14, 2017 at 10:25:43AM -0400, Dave Jones wrote: > On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > > Hi Linus, > > > > The following changes since commit > 32c1431eea4881a6b17bd7c639315010aeefa452: > > > > Linux 4.12-rc5 (2017-06-11 16:48:20 -0700) > > > >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > Hi Linus, > > The following changes since commit 32c1431eea4881a6b17bd7c639315010aeefa452: > > Linux 4.12-rc5 (2017-06-11 16:48:20 -0700) > > are available in the git repository at: > >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Thu, Jul 13, 2017 at 05:16:24PM -0400, Anna Schumaker wrote: > Hi Linus, > > The following changes since commit 32c1431eea4881a6b17bd7c639315010aeefa452: > > Linux 4.12-rc5 (2017-06-11 16:48:20 -0700) > > are available in the git repository at: > >

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On 07/14/2017 03:09 AM, Christoph Hellwig wrote: > On Thu, Jul 13, 2017 at 02:43:14PM -0700, Linus Torvalds wrote: >> On Thu, Jul 13, 2017 at 2:16 PM, Anna Schumaker >> wrote: >>> >>> git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-1 >> >> Btw,

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On 07/14/2017 03:09 AM, Christoph Hellwig wrote: > On Thu, Jul 13, 2017 at 02:43:14PM -0700, Linus Torvalds wrote: >> On Thu, Jul 13, 2017 at 2:16 PM, Anna Schumaker >> wrote: >>> >>> git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-1 >> >> Btw, your key seems to have

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Thu, Jul 13, 2017 at 02:43:14PM -0700, Linus Torvalds wrote: > On Thu, Jul 13, 2017 at 2:16 PM, Anna Schumaker > wrote: > > > > git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-1 > > Btw, your key seems to have expired, and doing a refresh on

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Thu, Jul 13, 2017 at 02:43:14PM -0700, Linus Torvalds wrote: > On Thu, Jul 13, 2017 at 2:16 PM, Anna Schumaker > wrote: > > > > git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-1 > > Btw, your key seems to have expired, and doing a refresh on it doesn't fix it. > > I'm

Re: [GIT PULL] Please pull NFS client changes for Linux 4.13

On Thu, Jul 13, 2017 at 2:16 PM, Anna Schumaker wrote: > > git://git.linux-nfs.org/projects/anna/linux-nfs.git tags/nfs-for-4.13-1 Btw, your key seems to have expired, and doing a refresh on it doesn't fix it. I'm sure you've refreshed your key, but apparently that

  1   2   >