[GIT PULL] ext4 updates for 3.9-rc6

2013-04-03 Thread Theodore Ts'o
The following changes since commit 07961ac7c0ee8b546658717034fe692fd12eefa9: Linux 3.9-rc5 (2013-03-31 15:12:43 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git tags/ext4_for_linus_stable for you to fetch changes up to

[GIT PULL] ext4 updates for 3.9-rc6

2013-04-03 Thread Theodore Ts'o
The following changes since commit 07961ac7c0ee8b546658717034fe692fd12eefa9: Linux 3.9-rc5 (2013-03-31 15:12:43 -0700) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git tags/ext4_for_linus_stable for you to fetch changes up to

[GIT PULL] ext4 updates for 3.9-rc4

2013-03-21 Thread Theodore Ts'o
The following changes since commit 9b2ff35753c0512bc8c6adae9e9c87cbeee86f82: ext4: enable quotas before orphan cleanup (2013-03-02 18:22:38 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git tags/ext4_for_linue for you to fetch

[GIT PULL] ext4 updates for 3.9-rc4

2013-03-21 Thread Theodore Ts'o
The following changes since commit 9b2ff35753c0512bc8c6adae9e9c87cbeee86f82: ext4: enable quotas before orphan cleanup (2013-03-02 18:22:38 -0500) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git tags/ext4_for_linue for you to fetch

Re: [GIT PULL] ext4 updates for 3.9

2013-03-01 Thread Eric Sandeen
On 2/27/13 2:58 PM, Dmitry Monakhov wrote: > On Wed, 27 Feb 2013 14:29:07 -0500, Theodore Ts'o wrote: >> On Wed, Feb 27, 2013 at 02:19:23PM -0500, Dave Jones wrote: >>> >>> Looks like it's fixed here too. >>> >>> How did this make it through -next without anyone hitting it ? >>> >>> I can't

Re: [GIT PULL] ext4 updates for 3.9

2013-03-01 Thread Eric Sandeen
On 2/27/13 2:58 PM, Dmitry Monakhov wrote: On Wed, 27 Feb 2013 14:29:07 -0500, Theodore Ts'o ty...@mit.edu wrote: On Wed, Feb 27, 2013 at 02:19:23PM -0500, Dave Jones wrote: Looks like it's fixed here too. How did this make it through -next without anyone hitting it ? I can't remember how

Re: [GIT PULL] ext4 updates for 3.9

2013-02-28 Thread Dave Chinner
On Wed, Feb 27, 2013 at 02:29:07PM -0500, Theodore Ts'o wrote: > On Wed, Feb 27, 2013 at 02:19:23PM -0500, Dave Jones wrote: > > > > Looks like it's fixed here too. > > > > How did this make it through -next without anyone hitting it ? > > > Is anyone running xfstests or similar on linux-next

Re: [GIT PULL] ext4 updates for 3.9

2013-02-28 Thread Dave Chinner
On Wed, Feb 27, 2013 at 02:29:07PM -0500, Theodore Ts'o wrote: On Wed, Feb 27, 2013 at 02:19:23PM -0500, Dave Jones wrote: Looks like it's fixed here too. How did this make it through -next without anyone hitting it ? Is anyone running xfstests or similar on linux-next regularly ?

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Theodore Ts'o
On Thu, Feb 28, 2013 at 12:58:55AM +0400, Dmitry Monakhov wrote: > Indeed. That's why i give-up rotated disks and run xfstest only on SSD > or brd module Note that some problems only show up on slower devices (because then the race window is wider), and sometimes they only show up on fast

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Dmitry Monakhov
On Wed, 27 Feb 2013 14:29:07 -0500, Theodore Ts'o wrote: > On Wed, Feb 27, 2013 at 02:19:23PM -0500, Dave Jones wrote: > > > > Looks like it's fixed here too. > > > > How did this make it through -next without anyone hitting it ? > > > > I can't remember how many years ago I last bought a disk

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Theodore Ts'o
On Wed, Feb 27, 2013 at 02:19:23PM -0500, Dave Jones wrote: > > Looks like it's fixed here too. > > How did this make it through -next without anyone hitting it ? > > I can't remember how many years ago I last bought a disk < 1TB, > and I can't be alone. Or is everyone all about SSDs these

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Zheng Liu
On 02/28/2013 03:19 AM, Dave Jones wrote: > On Wed, Feb 27, 2013 at 07:56:25PM +0100, Markus Trippelsdorf wrote: > > On 2013.02.27 at 13:49 -0500, Theodore Ts'o wrote: > > > > > Markus, Dave, can you confirm that this fixes your problem? > > > > Yes, it fixes the issue. > > Looks like it's

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Dave Jones
On Wed, Feb 27, 2013 at 07:56:25PM +0100, Markus Trippelsdorf wrote: > On 2013.02.27 at 13:49 -0500, Theodore Ts'o wrote: > > > Markus, Dave, can you confirm that this fixes your problem? > > Yes, it fixes the issue. Looks like it's fixed here too. How did this make it through -next

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Theodore Ts'o
On Wed, Feb 27, 2013 at 02:11:15PM -0500, Dave Jones wrote: > > fsck never found anything. I do have another disk (XFS formatted) with > a backup from a week ago. I'll run a --dry-run rsync to see if it > picks up any changes that I don't expect. Probably a good idea. Given that Markus reports

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Dave Jones
On Wed, Feb 27, 2013 at 02:04:19PM -0500, Theodore Ts'o wrote: > On Wed, Feb 27, 2013 at 01:57:55PM -0500, Dave Jones wrote: > > Building now. Can you confirm that nothing on-disk should be awry ? > > Or will I need a new fsck to detect what happened ? > > > > Well, it's possible that a

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Borislav Petkov
On Wed, Feb 27, 2013 at 01:49:12PM -0500, Theodore Ts'o wrote: > -#define EXTENT_STATUS_WRITTEN0x8000 /* written extent */ > -#define EXTENT_STATUS_UNWRITTEN 0x4000 /* unwritten extent */ > -#define EXTENT_STATUS_DELAYED0x2000 /* delayed extent */ >

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Theodore Ts'o
On Wed, Feb 27, 2013 at 01:57:55PM -0500, Dave Jones wrote: > Building now. Can you confirm that nothing on-disk should be awry ? > Or will I need a new fsck to detect what happened ? > Well, it's possible that a read from data file which had blocks located above 512GB might have gotten bogus

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Zheng Liu
Hi Ted, On 02/28/2013 02:49 AM, Theodore Ts'o wrote: > Markus, Dave, can you confirm that this fixes your problem? > > Thanks!! > > (Sigh, this is a real brown paper bug; I'm embarassed I missed this in > my code review.) Sorry, I don't have a big disk in my hand now. So I could reproduce it.

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Dave Jones
On Wed, Feb 27, 2013 at 01:49:12PM -0500, Theodore Ts'o wrote: > Markus, Dave, can you confirm that this fixes your problem? > > Thanks!! > > (Sigh, this is a real brown paper bug; I'm embarassed I missed this in > my code review.) Building now. Can you confirm that nothing on-disk

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Theodore Ts'o
Markus, Dave, can you confirm that this fixes your problem? Thanks!! (Sigh, this is a real brown paper bug; I'm embarassed I missed this in my code review.) - Ted >From f47f0d11096ca5d9e1965d8a9f266aa13fe2b73b Mon Sep 17 00:00:00 2001 From:

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Linus Torvalds
On Wed, Feb 27, 2013 at 9:45 AM, Markus Trippelsdorf wrote: > > git revert > 06b0c886214a223dde7b21cbfc3008fd20a8ce16..74cd15cd02708c7188581f279f33a98b2ae8d322 > fixes all issues... Hmm. I'm hoping this will have a quick resolution that doesn't mean having to revert all that. But it's good to

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Markus Trippelsdorf
On 2013.02.28 at 01:38 +0800, gnehzuil.liu wrote: > 在 2013-2-28,上午1:22,Markus Trippelsdorf 写道: > > > On 2013.02.28 at 01:10 +0800, gnehzuil.liu wrote: > >> 在 2013-2-28,上午1:01,Markus Trippelsdorf 写道: > >> > >>> On 2013.02.27 at 16:44 +0100, Markus Trippelsdorf wrote: > On 2013.02.27 at

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread gnehzuil.liu
在 2013-2-28,上午1:22,Markus Trippelsdorf 写道: > On 2013.02.28 at 01:10 +0800, gnehzuil.liu wrote: >> 在 2013-2-28,上午1:01,Markus Trippelsdorf 写道: >> >>> On 2013.02.27 at 16:44 +0100, Markus Trippelsdorf wrote: On 2013.02.27 at 10:34 -0500, Theodore Ts'o wrote: > On Wed, Feb 27, 2013 at

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Markus Trippelsdorf
On 2013.02.28 at 01:10 +0800, gnehzuil.liu wrote: > 在 2013-2-28,上午1:01,Markus Trippelsdorf 写道: > > > On 2013.02.27 at 16:44 +0100, Markus Trippelsdorf wrote: > >> On 2013.02.27 at 10:34 -0500, Theodore Ts'o wrote: > >>> On Wed, Feb 27, 2013 at 01:47:27PM +0100, Markus Trippelsdorf wrote: >

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread gnehzuil.liu
在 2013-2-28,上午1:01,Markus Trippelsdorf 写道: > On 2013.02.27 at 16:44 +0100, Markus Trippelsdorf wrote: >> On 2013.02.27 at 10:34 -0500, Theodore Ts'o wrote: >>> On Wed, Feb 27, 2013 at 01:47:27PM +0100, Markus Trippelsdorf wrote: Just booted todays Linux tree and got the following errors:

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Markus Trippelsdorf
On 2013.02.27 at 16:44 +0100, Markus Trippelsdorf wrote: > On 2013.02.27 at 10:34 -0500, Theodore Ts'o wrote: > > On Wed, Feb 27, 2013 at 01:47:27PM +0100, Markus Trippelsdorf wrote: > > > Just booted todays Linux tree and got the following errors: > > > > > > ... > > > Feb 27 13:33:31 x4 kernel:

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Markus Trippelsdorf
On 2013.02.27 at 10:34 -0500, Theodore Ts'o wrote: > On Wed, Feb 27, 2013 at 01:47:27PM +0100, Markus Trippelsdorf wrote: > > Just booted todays Linux tree and got the following errors: > > > > ... > > Feb 27 13:33:31 x4 kernel: EXT4-fs (sda): mounted filesystem with ordered > > data mode. Opts:

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Theodore Ts'o
On Wed, Feb 27, 2013 at 01:47:27PM +0100, Markus Trippelsdorf wrote: > Just booted todays Linux tree and got the following errors: > > ... > Feb 27 13:33:31 x4 kernel: EXT4-fs (sda): mounted filesystem with ordered > data mode. Opts: (null) > ... > Feb 27 13:33:32 x4 kernel: EXT4-fs error

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Markus Trippelsdorf
On 2013.02.26 at 15:39 -0500, Theodore Ts'o wrote: > > The following changes since commit 9931faca02c604c22335f5a935a501bb2ace6e20: > > Linux 3.8-rc3 (2013-01-09 18:59:55 -0800) > > are available in the git repository at: > > git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git >

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Markus Trippelsdorf
On 2013.02.26 at 15:39 -0500, Theodore Ts'o wrote: The following changes since commit 9931faca02c604c22335f5a935a501bb2ace6e20: Linux 3.8-rc3 (2013-01-09 18:59:55 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Theodore Ts'o
On Wed, Feb 27, 2013 at 01:47:27PM +0100, Markus Trippelsdorf wrote: Just booted todays Linux tree and got the following errors: ... Feb 27 13:33:31 x4 kernel: EXT4-fs (sda): mounted filesystem with ordered data mode. Opts: (null) ... Feb 27 13:33:32 x4 kernel: EXT4-fs error (device sda):

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Markus Trippelsdorf
On 2013.02.27 at 10:34 -0500, Theodore Ts'o wrote: On Wed, Feb 27, 2013 at 01:47:27PM +0100, Markus Trippelsdorf wrote: Just booted todays Linux tree and got the following errors: ... Feb 27 13:33:31 x4 kernel: EXT4-fs (sda): mounted filesystem with ordered data mode. Opts: (null)

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Markus Trippelsdorf
On 2013.02.27 at 16:44 +0100, Markus Trippelsdorf wrote: On 2013.02.27 at 10:34 -0500, Theodore Ts'o wrote: On Wed, Feb 27, 2013 at 01:47:27PM +0100, Markus Trippelsdorf wrote: Just booted todays Linux tree and got the following errors: ... Feb 27 13:33:31 x4 kernel: EXT4-fs (sda):

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread gnehzuil.liu
在 2013-2-28,上午1:01,Markus Trippelsdorf mar...@trippelsdorf.de 写道: On 2013.02.27 at 16:44 +0100, Markus Trippelsdorf wrote: On 2013.02.27 at 10:34 -0500, Theodore Ts'o wrote: On Wed, Feb 27, 2013 at 01:47:27PM +0100, Markus Trippelsdorf wrote: Just booted todays Linux tree and got the

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Markus Trippelsdorf
On 2013.02.28 at 01:10 +0800, gnehzuil.liu wrote: 在 2013-2-28,上午1:01,Markus Trippelsdorf mar...@trippelsdorf.de 写道: On 2013.02.27 at 16:44 +0100, Markus Trippelsdorf wrote: On 2013.02.27 at 10:34 -0500, Theodore Ts'o wrote: On Wed, Feb 27, 2013 at 01:47:27PM +0100, Markus Trippelsdorf

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread gnehzuil.liu
在 2013-2-28,上午1:22,Markus Trippelsdorf mar...@trippelsdorf.de 写道: On 2013.02.28 at 01:10 +0800, gnehzuil.liu wrote: 在 2013-2-28,上午1:01,Markus Trippelsdorf mar...@trippelsdorf.de 写道: On 2013.02.27 at 16:44 +0100, Markus Trippelsdorf wrote: On 2013.02.27 at 10:34 -0500, Theodore Ts'o wrote:

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Markus Trippelsdorf
On 2013.02.28 at 01:38 +0800, gnehzuil.liu wrote: 在 2013-2-28,上午1:22,Markus Trippelsdorf mar...@trippelsdorf.de 写道: On 2013.02.28 at 01:10 +0800, gnehzuil.liu wrote: 在 2013-2-28,上午1:01,Markus Trippelsdorf mar...@trippelsdorf.de 写道: On 2013.02.27 at 16:44 +0100, Markus Trippelsdorf

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Linus Torvalds
On Wed, Feb 27, 2013 at 9:45 AM, Markus Trippelsdorf mar...@trippelsdorf.de wrote: git revert 06b0c886214a223dde7b21cbfc3008fd20a8ce16..74cd15cd02708c7188581f279f33a98b2ae8d322 fixes all issues... Hmm. I'm hoping this will have a quick resolution that doesn't mean having to revert all that.

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Theodore Ts'o
Markus, Dave, can you confirm that this fixes your problem? Thanks!! (Sigh, this is a real brown paper bug; I'm embarassed I missed this in my code review.) - Ted From f47f0d11096ca5d9e1965d8a9f266aa13fe2b73b Mon Sep 17 00:00:00 2001 From:

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Dave Jones
On Wed, Feb 27, 2013 at 01:49:12PM -0500, Theodore Ts'o wrote: Markus, Dave, can you confirm that this fixes your problem? Thanks!! (Sigh, this is a real brown paper bug; I'm embarassed I missed this in my code review.) Building now. Can you confirm that nothing on-disk should be

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Zheng Liu
Hi Ted, On 02/28/2013 02:49 AM, Theodore Ts'o wrote: Markus, Dave, can you confirm that this fixes your problem? Thanks!! (Sigh, this is a real brown paper bug; I'm embarassed I missed this in my code review.) Sorry, I don't have a big disk in my hand now. So I could reproduce it. But

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Theodore Ts'o
On Wed, Feb 27, 2013 at 01:57:55PM -0500, Dave Jones wrote: Building now. Can you confirm that nothing on-disk should be awry ? Or will I need a new fsck to detect what happened ? Well, it's possible that a read from data file which had blocks located above 512GB might have gotten bogus

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Borislav Petkov
On Wed, Feb 27, 2013 at 01:49:12PM -0500, Theodore Ts'o wrote: -#define EXTENT_STATUS_WRITTEN0x8000 /* written extent */ -#define EXTENT_STATUS_UNWRITTEN 0x4000 /* unwritten extent */ -#define EXTENT_STATUS_DELAYED0x2000 /* delayed extent */

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Dave Jones
On Wed, Feb 27, 2013 at 02:04:19PM -0500, Theodore Ts'o wrote: On Wed, Feb 27, 2013 at 01:57:55PM -0500, Dave Jones wrote: Building now. Can you confirm that nothing on-disk should be awry ? Or will I need a new fsck to detect what happened ? Well, it's possible that a read from

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Theodore Ts'o
On Wed, Feb 27, 2013 at 02:11:15PM -0500, Dave Jones wrote: fsck never found anything. I do have another disk (XFS formatted) with a backup from a week ago. I'll run a --dry-run rsync to see if it picks up any changes that I don't expect. Probably a good idea. Given that Markus reports

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Dave Jones
On Wed, Feb 27, 2013 at 07:56:25PM +0100, Markus Trippelsdorf wrote: On 2013.02.27 at 13:49 -0500, Theodore Ts'o wrote: Markus, Dave, can you confirm that this fixes your problem? Yes, it fixes the issue. Looks like it's fixed here too. How did this make it through -next without

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Zheng Liu
On 02/28/2013 03:19 AM, Dave Jones wrote: On Wed, Feb 27, 2013 at 07:56:25PM +0100, Markus Trippelsdorf wrote: On 2013.02.27 at 13:49 -0500, Theodore Ts'o wrote: Markus, Dave, can you confirm that this fixes your problem? Yes, it fixes the issue. Looks like it's fixed here

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Theodore Ts'o
On Wed, Feb 27, 2013 at 02:19:23PM -0500, Dave Jones wrote: Looks like it's fixed here too. How did this make it through -next without anyone hitting it ? I can't remember how many years ago I last bought a disk 1TB, and I can't be alone. Or is everyone all about SSDs these days? I

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Dmitry Monakhov
On Wed, 27 Feb 2013 14:29:07 -0500, Theodore Ts'o ty...@mit.edu wrote: On Wed, Feb 27, 2013 at 02:19:23PM -0500, Dave Jones wrote: Looks like it's fixed here too. How did this make it through -next without anyone hitting it ? I can't remember how many years ago I last bought a disk

Re: [GIT PULL] ext4 updates for 3.9

2013-02-27 Thread Theodore Ts'o
On Thu, Feb 28, 2013 at 12:58:55AM +0400, Dmitry Monakhov wrote: Indeed. That's why i give-up rotated disks and run xfstest only on SSD or brd module Note that some problems only show up on slower devices (because then the race window is wider), and sometimes they only show up on fast devices.

[GIT PULL] ext4 updates for 3.9

2013-02-26 Thread Theodore Ts'o
The following changes since commit 9931faca02c604c22335f5a935a501bb2ace6e20: Linux 3.8-rc3 (2013-01-09 18:59:55 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git tags/ext4_for_linus for you to fetch changes up to

[GIT PULL] ext4 updates for 3.9

2013-02-26 Thread Theodore Ts'o
The following changes since commit 9931faca02c604c22335f5a935a501bb2ace6e20: Linux 3.8-rc3 (2013-01-09 18:59:55 -0800) are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git tags/ext4_for_linus for you to fetch changes up to