Re: [Linux-zigbee-devel] [PATCH net-next 1/3] ieee802154: cc2520: driver for TI cc2520 radio

2014-06-16 Thread Alexander Aring
Hi, On Mon, Jun 16, 2014 at 02:21:19PM +0530, Varka Bhadram wrote: ... > >>+ > >>+static void cc2520_unregister(struct cc2520_private *priv) > >>+{ > >>+ ieee802154_unregister_device(priv->dev); > >>+ ieee802154_free_device(priv->dev); > >>+} > >Only used in remove callback of module. It's

Re: [Linux-zigbee-devel] [PATCH net-next 1/3] ieee802154: cc2520: driver for TI cc2520 radio

2014-06-16 Thread Varka Bhadram
Hi Alex, Thanks for the comments. I will create a patch for the required changes with Reported-by Alexander Aring <...> reply if this is okay for you. On 06/16/2014 01:08 PM, Alexander Aring wrote: Hi Varka, On Mon, Jun 16, 2014 at 10:21:56AM +0530, Varka Bhadram wrote: Maybe some more

Re: [Linux-zigbee-devel] [PATCH net-next 1/3] ieee802154: cc2520: driver for TI cc2520 radio

2014-06-16 Thread Alexander Aring
Hi Varka, On Mon, Jun 16, 2014 at 10:21:56AM +0530, Varka Bhadram wrote: > Maybe some more information about this chip in the commit msg? > Signed-off-by: Varka Bhadram > --- > drivers/net/ieee802154/cc2520.c | 805 > +++ > include/linux/spi/cc2520.h

Re: [Linux-zigbee-devel] [PATCH net-next 1/3] ieee802154: cc2520: driver for TI cc2520 radio

2014-06-16 Thread Alexander Aring
Hi Varka, On Mon, Jun 16, 2014 at 10:21:56AM +0530, Varka Bhadram wrote: Maybe some more information about this chip in the commit msg? Signed-off-by: Varka Bhadram var...@cdac.in --- drivers/net/ieee802154/cc2520.c | 805 +++

Re: [Linux-zigbee-devel] [PATCH net-next 1/3] ieee802154: cc2520: driver for TI cc2520 radio

2014-06-16 Thread Varka Bhadram
Hi Alex, Thanks for the comments. I will create a patch for the required changes with Reported-by Alexander Aring ... reply if this is okay for you. On 06/16/2014 01:08 PM, Alexander Aring wrote: Hi Varka, On Mon, Jun 16, 2014 at 10:21:56AM +0530, Varka Bhadram wrote: Maybe some more

Re: [Linux-zigbee-devel] [PATCH net-next 1/3] ieee802154: cc2520: driver for TI cc2520 radio

2014-06-16 Thread Alexander Aring
Hi, On Mon, Jun 16, 2014 at 02:21:19PM +0530, Varka Bhadram wrote: ... + +static void cc2520_unregister(struct cc2520_private *priv) +{ + ieee802154_unregister_device(priv-dev); + ieee802154_free_device(priv-dev); +} Only used in remove callback of module. It's small enough to do this