Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-13 Thread Yinghai Lu
wakeup_level4_pgt need to be updated in addtion to boot_level4_pgt? also comment could be updated for good unstanding too. YH - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-13 Thread Yinghai Lu
On 12/12/06, Eric W. Biederman <[EMAIL PROTECTED]> wrote: diff --git a/arch/x86_64/kernel/head.S b/arch/x86_64/kernel/head.S index 1e6f808..2f65469 100644 --- a/arch/x86_64/kernel/head.S +++ b/arch/x86_64/kernel/head.S @@ -328,9 +328,9 @@ ENTRY(wakeup_level4_pgt) .align PAGE_SIZE

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-13 Thread Yinghai Lu
On 12/12/06, Eric W. Biederman [EMAIL PROTECTED] wrote: diff --git a/arch/x86_64/kernel/head.S b/arch/x86_64/kernel/head.S index 1e6f808..2f65469 100644 --- a/arch/x86_64/kernel/head.S +++ b/arch/x86_64/kernel/head.S @@ -328,9 +328,9 @@ ENTRY(wakeup_level4_pgt) .align PAGE_SIZE

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-13 Thread Yinghai Lu
wakeup_level4_pgt need to be updated in addtion to boot_level4_pgt? also comment could be updated for good unstanding too. YH - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-12 Thread Eric W. Biederman
"Yinghai Lu" <[EMAIL PROTECTED]> writes: > On 12/8/06, Eric W. Biederman <[EMAIL PROTECTED]> wrote: >> >> Your or I missed a bug fix/enhancement in there somewhere. >> > > I found the problem. the __set_fixmap need to __va, so the entries > will be referred from PAGE_OFFSET. > > solution will be

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-12 Thread Yinghai Lu
On 12/8/06, Eric W. Biederman <[EMAIL PROTECTED]> wrote: Your or I missed a bug fix/enhancement in there somewhere. I found the problem. the __set_fixmap need to __va, so the entries will be referred from PAGE_OFFSET. solution will be 1. move enable_dbgp_console from setup_early_printk, and

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-12 Thread Yinghai Lu
On 12/8/06, Eric W. Biederman [EMAIL PROTECTED] wrote: Your or I missed a bug fix/enhancement in there somewhere. I found the problem. the __set_fixmap need to __va, so the entries will be referred from PAGE_OFFSET. solution will be 1. move enable_dbgp_console from setup_early_printk, and

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-12 Thread Eric W. Biederman
Yinghai Lu [EMAIL PROTECTED] writes: On 12/8/06, Eric W. Biederman [EMAIL PROTECTED] wrote: Your or I missed a bug fix/enhancement in there somewhere. I found the problem. the __set_fixmap need to __va, so the entries will be referred from PAGE_OFFSET. solution will be 1. move

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-09 Thread Peter Stuge
On Fri, Dec 08, 2006 at 07:16:09PM -0800, Lu, Yinghai wrote: > It works in LinuxBIOS now. Cool, can't wait to try it out. Good work! //Peter - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-09 Thread Peter Stuge
On Fri, Dec 08, 2006 at 07:16:09PM -0800, Lu, Yinghai wrote: It works in LinuxBIOS now. Cool, can't wait to try it out. Good work! //Peter - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

RE: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-08 Thread Lu, Yinghai
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, December 07, 2006 11:42 PM >> With Eric code in LinuxBIOS, it will report "No device found in debug >> port" >Hmm. At least this is partial progress :) It works in LinuxBIOS now. It will loop all

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-08 Thread Eric W. Biederman
"Yinghai Lu" <[EMAIL PROTECTED]> writes: > On 12/7/06, Eric W. Biederman <[EMAIL PROTECTED]> wrote: >> Ugh. I'd check the code. But it looks like my tweak to the >> early fixmap code. But my hunch is that my tweak to __fixmap >> so that it's pud and pmd were prepopulated didn't take on >> your

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-08 Thread Yinghai Lu
On 12/7/06, Eric W. Biederman <[EMAIL PROTECTED]> wrote: Ugh. I'd check the code. But it looks like my tweak to the early fixmap code. But my hunch is that my tweak to __fixmap so that it's pud and pmd were prepopulated didn't take on your build. I missed some options? YH - To unsubscribe

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-08 Thread Yinghai Lu
On 12/7/06, Greg KH <[EMAIL PROTECTED]> wrote: Ugh, no, never use the usb-serial driver as a console device. That was a bad hack done as a bet many years ago. For many obvious reasons it does not work well. understood, I found with usb_serial convertor could lose some chatacter. but the

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-08 Thread Yinghai Lu
On 12/7/06, Greg KH [EMAIL PROTECTED] wrote: Ugh, no, never use the usb-serial driver as a console device. That was a bad hack done as a bet many years ago. For many obvious reasons it does not work well. understood, I found with usb_serial convertor could lose some chatacter. but the

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-08 Thread Yinghai Lu
On 12/7/06, Eric W. Biederman [EMAIL PROTECTED] wrote: Ugh. I'd check the code. But it looks like my tweak to the early fixmap code. But my hunch is that my tweak to __fixmap so that it's pud and pmd were prepopulated didn't take on your build. I missed some options? YH - To unsubscribe

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-08 Thread Eric W. Biederman
Yinghai Lu [EMAIL PROTECTED] writes: On 12/7/06, Eric W. Biederman [EMAIL PROTECTED] wrote: Ugh. I'd check the code. But it looks like my tweak to the early fixmap code. But my hunch is that my tweak to __fixmap so that it's pud and pmd were prepopulated didn't take on your build. I

RE: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-08 Thread Lu, Yinghai
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Thursday, December 07, 2006 11:42 PM With Eric code in LinuxBIOS, it will report No device found in debug port Hmm. At least this is partial progress :) It works in LinuxBIOS now. It will loop all connected

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-07 Thread Eric W. Biederman
"Lu, Yinghai" <[EMAIL PROTECTED]> writes: > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > [EMAIL PROTECTED] > > >>Ok due to popular demands here is the slightly fixed patch that works >>on both i386 and x86_64. For the i386 version you must not

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-07 Thread Greg KH
On Thu, Dec 07, 2006 at 07:48:17PM -0800, Lu, Yinghai wrote: > With Greg's USB Debug, host and target can talk. > target with console=ttyUSB0,115200n8 Ugh, no, never use the usb-serial driver as a console device. That was a bad hack done as a bet many years ago. For many obvious reasons it does

RE: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-07 Thread Lu, Yinghai
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of [EMAIL PROTECTED] >Ok due to popular demands here is the slightly fixed patch that works >on both i386 and x86_64. For the i386 version you must not have >HIGHMEM64G enabled. >I just rolled it all into

RE: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-07 Thread Lu, Yinghai
Two side are identical if two side are connected. YH - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-07 Thread Peter Stuge
On Wed, Dec 06, 2006 at 01:08:14PM -0800, Lu, Yinghai wrote: > -Original Message- > From: Andi Kleen [mailto:[EMAIL PROTECTED] > Sent: Wednesday, December 06, 2006 12:59 PM > > >I haven't looked how the other usb_debug works -- if it's polled > >too then it wouldn't have much advantage.

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-07 Thread Peter Stuge
On Wed, Dec 06, 2006 at 01:08:14PM -0800, Lu, Yinghai wrote: -Original Message- From: Andi Kleen [mailto:[EMAIL PROTECTED] Sent: Wednesday, December 06, 2006 12:59 PM I haven't looked how the other usb_debug works -- if it's polled too then it wouldn't have much advantage. Need

RE: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-07 Thread Lu, Yinghai
Two side are identical if two side are connected. YH - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

RE: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-07 Thread Lu, Yinghai
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of [EMAIL PROTECTED] Ok due to popular demands here is the slightly fixed patch that works on both i386 and x86_64. For the i386 version you must not have HIGHMEM64G enabled. I just rolled it all into one

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-07 Thread Greg KH
On Thu, Dec 07, 2006 at 07:48:17PM -0800, Lu, Yinghai wrote: With Greg's USB Debug, host and target can talk. target with console=ttyUSB0,115200n8 Ugh, no, never use the usb-serial driver as a console device. That was a bad hack done as a bet many years ago. For many obvious reasons it does

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-07 Thread Eric W. Biederman
Lu, Yinghai [EMAIL PROTECTED] writes: -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of [EMAIL PROTECTED] Ok due to popular demands here is the slightly fixed patch that works on both i386 and x86_64. For the i386 version you must not have HIGHMEM64G

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-06 Thread Segher Boessenkool
What do you mean by + for (reps = 0; reps >= 0; reps++) { ? If you will not reps is negative. Roughly it is a loop that will timeout eventually if a usb debug cable is not present. So since I didn't know how many loop iterations made sense I allowed it to loop for 2^31 times or until

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-06 Thread Segher Boessenkool
What do you mean by + for (reps = 0; reps = 0; reps++) { ? If you will not reps is negative. Roughly it is a loop that will timeout eventually if a usb debug cable is not present. So since I didn't know how many loop iterations made sense I allowed it to loop for 2^31 times or until

RE: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-05 Thread Lu, Yinghai
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Tuesday, December 05, 2006 3:50 PM >If you will not reps is negative. Roughly it is a loop >that will timeout eventually if a usb debug cable is not present. >Putting some deliberate delays in there so I could

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-05 Thread Eric W. Biederman
"Lu, Yinghai" <[EMAIL PROTECTED]> writes: > -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of > [EMAIL PROTECTED] > Sent: Tuesday, December 05, 2006 3:01 AM > >>+static int ehci_wait_for_port(int port) >>+{ >>+ unsigned status; >>+ int ret,

RE: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-05 Thread Lu, Yinghai
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of [EMAIL PROTECTED] Sent: Tuesday, December 05, 2006 3:01 AM >+static int ehci_wait_for_port(int port) >+{ >+ unsigned status; >+ int ret, reps; >+ for (reps = 0; reps >= 0; reps++) { >+

RE: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-05 Thread Lu, Yinghai
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of [EMAIL PROTECTED] Sent: Tuesday, December 05, 2006 3:01 AM +static int ehci_wait_for_port(int port) +{ + unsigned status; + int ret, reps; + for (reps = 0; reps = 0; reps++) { +

Re: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-05 Thread Eric W. Biederman
Lu, Yinghai [EMAIL PROTECTED] writes: -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of [EMAIL PROTECTED] Sent: Tuesday, December 05, 2006 3:01 AM +static int ehci_wait_for_port(int port) +{ + unsigned status; + int ret, reps; + for (reps

RE: [LinuxBIOS] [linux-usb-devel] [RFC][PATCH 0/2] x86_64 Early usb debug port support.

2006-12-05 Thread Lu, Yinghai
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Tuesday, December 05, 2006 3:50 PM If you will not reps is negative. Roughly it is a loop that will timeout eventually if a usb debug cable is not present. Putting some deliberate delays in there so I could be