Re: [Ocfs2-devel] [PATCH 1/1] OCFS2: Remove NULL assignments on static

2014-04-09 Thread Andrew Morton
On Wed, 09 Apr 2014 08:53:14 +0800 Wengang wrote: > ___ 2014___04___09___ 04:13, Fabian Frederick __: > > static values are automatically initialized to NULL. > > > > What's the badness if we do the assignments? (top-posting repaired...) Back in the olden days, static int x = 0;

Re: [Ocfs2-devel] [PATCH 1/1] OCFS2: Remove NULL assignments on static

2014-04-09 Thread Andrew Morton
On Wed, 09 Apr 2014 08:53:14 +0800 Wengang wen.gang.w...@oracle.com wrote: ___ 2014___04___09___ 04:13, Fabian Frederick __: static values are automatically initialized to NULL. What's the badness if we do the assignments? (top-posting repaired...) Back in the olden days,

Re: [Ocfs2-devel] [PATCH 1/1] OCFS2: Remove NULL assignments on static

2014-04-08 Thread Fabian Frederick
On Wed, 09 Apr 2014 08:53:14 +0800 Wengang wrote: > Hi Fabian, > > What's the badness if we do the assignments? > > thanks, > wengang Hi Wengang, Nothing wrong but AFAICS redundant. Regards, Fabian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: [Ocfs2-devel] [PATCH 1/1] OCFS2: Remove NULL assignments on static

2014-04-08 Thread Wengang
Hi Fabian, What's the badness if we do the assignments? thanks, wengang 于 2014年04月09日 04:13, Fabian Frederick 写道: static values are automatically initialized to NULL. Cc: Andrew Morton Cc: ocfs2-de...@oss.oracle.com Signed-off-by: Fabian Frederick --- fs/ocfs2/cluster/tcp.c | 2 +-

Re: [Ocfs2-devel] [PATCH 1/1] OCFS2: Remove NULL assignments on static

2014-04-08 Thread Wengang
Hi Fabian, What's the badness if we do the assignments? thanks, wengang 于 2014年04月09日 04:13, Fabian Frederick 写道: static values are automatically initialized to NULL. Cc: Andrew Morton a...@linux-foundation.org Cc: ocfs2-de...@oss.oracle.com Signed-off-by: Fabian Frederick f...@skynet.be ---

Re: [Ocfs2-devel] [PATCH 1/1] OCFS2: Remove NULL assignments on static

2014-04-08 Thread Fabian Frederick
On Wed, 09 Apr 2014 08:53:14 +0800 Wengang wen.gang.w...@oracle.com wrote: Hi Fabian, What's the badness if we do the assignments? thanks, wengang Hi Wengang, Nothing wrong but AFAICS redundant. Regards, Fabian -- To unsubscribe from this list: send the line unsubscribe