Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-12 Thread Ingo Molnar
* Fengguang Wu wrote: > Ingo, > > After adding more test runs to these kernels, we can see that the boot hangs > happen both before/after patch. So the patch is fine. > > Tested-by: Fengguang Wu Cool, thanks for all the testing - I'll send the fix to Linus. > btw, the boot hangs all

Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-12 Thread Ingo Molnar
* Fengguang Wu fengguang...@intel.com wrote: Ingo, After adding more test runs to these kernels, we can see that the boot hangs happen both before/after patch. So the patch is fine. Tested-by: Fengguang Wu fengguang...@intel.com Cool, thanks for all the testing - I'll send the fix to

Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-11 Thread Fengguang Wu
Ingo, After adding more test runs to these kernels, we can see that the boot hangs happen both before/after patch. So the patch is fine. Tested-by: Fengguang Wu /kernel/x86_64-randconfig-a1-1009/c015a7f0b746d0a7e18b82876bd2b693722479d2

Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-11 Thread Fengguang Wu
On Fri, Oct 11, 2013 at 07:46:55AM +0200, Ingo Molnar wrote: > > * Fengguang Wu wrote: > > > > Indeed. Something like the updated version below? > > > > > > [ I kept the asm_volatile_goto() naming to make sure the implicit > > > volatile > > > is visible. ] > > > > Ingo, I applied this

Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-11 Thread Fengguang Wu
On Fri, Oct 11, 2013 at 07:46:55AM +0200, Ingo Molnar wrote: * Fengguang Wu fengguang...@intel.com wrote: Indeed. Something like the updated version below? [ I kept the asm_volatile_goto() naming to make sure the implicit volatile is visible. ] Ingo, I applied this

Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-11 Thread Fengguang Wu
Ingo, After adding more test runs to these kernels, we can see that the boot hangs happen both before/after patch. So the patch is fine. Tested-by: Fengguang Wu fengguang...@intel.com /kernel/x86_64-randconfig-a1-1009/c015a7f0b746d0a7e18b82876bd2b693722479d2

Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-10 Thread Ingo Molnar
* Fengguang Wu wrote: > > Indeed. Something like the updated version below? > > > > [ I kept the asm_volatile_goto() naming to make sure the implicit volatile > > is visible. ] > > Ingo, I applied this patch (as commit c015a7f0b746) on top of > tip/sched/core > > 3354781a2184

Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-10 Thread Fengguang Wu
On Thu, Oct 10, 2013 at 05:12:19PM +0200, Ingo Molnar wrote: > > * Jakub Jelinek wrote: > > > On Thu, Oct 10, 2013 at 07:04:18AM -0700, Richard Henderson wrote: > > > On 10/10/2013 01:31 AM, Jakub Jelinek wrote: > > > > Also, for the bitops patch, you probably want an asm_volatile_goto > > > >

Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-10 Thread Ingo Molnar
* Richard Henderson wrote: > On 10/10/2013 08:12 AM, Ingo Molnar wrote: > > Indeed. Something like the updated version below? > > > > [ I kept the asm_volatile_goto() naming to make sure the implicit volatile > > is visible. ] > > > > Thanks, > > > > Ingo > > Looks good. > >

Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-10 Thread Richard Henderson
On 10/10/2013 08:12 AM, Ingo Molnar wrote: > Indeed. Something like the updated version below? > > [ I kept the asm_volatile_goto() naming to make sure the implicit volatile > is visible. ] > > Thanks, > > Ingo Looks good. Reviewed-by: Richard Henderson r~ -- To unsubscribe from

[PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-10 Thread Ingo Molnar
* Jakub Jelinek wrote: > On Thu, Oct 10, 2013 at 07:04:18AM -0700, Richard Henderson wrote: > > On 10/10/2013 01:31 AM, Jakub Jelinek wrote: > > > Also, for the bitops patch, you probably want an asm_volatile_goto > > > variant. > > > > Why? Asm without output (which asm goto must be) are

[PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-10 Thread Ingo Molnar
* Jakub Jelinek ja...@redhat.com wrote: On Thu, Oct 10, 2013 at 07:04:18AM -0700, Richard Henderson wrote: On 10/10/2013 01:31 AM, Jakub Jelinek wrote: Also, for the bitops patch, you probably want an asm_volatile_goto variant. Why? Asm without output (which asm goto must be) are

Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-10 Thread Richard Henderson
On 10/10/2013 08:12 AM, Ingo Molnar wrote: Indeed. Something like the updated version below? [ I kept the asm_volatile_goto() naming to make sure the implicit volatile is visible. ] Thanks, Ingo Looks good. Reviewed-by: Richard Henderson r...@twiddle.net r~ -- To

Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-10 Thread Ingo Molnar
* Richard Henderson r...@twiddle.net wrote: On 10/10/2013 08:12 AM, Ingo Molnar wrote: Indeed. Something like the updated version below? [ I kept the asm_volatile_goto() naming to make sure the implicit volatile is visible. ] Thanks, Ingo Looks good. Reviewed-by:

Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-10 Thread Fengguang Wu
On Thu, Oct 10, 2013 at 05:12:19PM +0200, Ingo Molnar wrote: * Jakub Jelinek ja...@redhat.com wrote: On Thu, Oct 10, 2013 at 07:04:18AM -0700, Richard Henderson wrote: On 10/10/2013 01:31 AM, Jakub Jelinek wrote: Also, for the bitops patch, you probably want an asm_volatile_goto

Re: [PATCH, -v3] compiler/gcc4: Add quirk for 'asm goto' miscompilation bug

2013-10-10 Thread Ingo Molnar
* Fengguang Wu fengguang...@intel.com wrote: Indeed. Something like the updated version below? [ I kept the asm_volatile_goto() naming to make sure the implicit volatile is visible. ] Ingo, I applied this patch (as commit c015a7f0b746) on top of tip/sched/core